[Lldb-commits] [lldb] [lldb] fix vFile:open, vFile:unlink error codes (PR #106950)

2024-09-26 Thread David Spickett via lldb-commits
DavidSpickett wrote: Yes working to the standard is good, but in the minority of cases where you do get a strange errno, `GDB_EUNKNOWN` is zero help and then you're working out the `lldb-server gdbserver --log-channels` etc. command to get it to print the real number. So far that hasn't been

[Lldb-commits] [lldb] [lldb][AArch64] Add register fields for the fpmr register (PR #109934)

2024-09-26 Thread Omair Javaid via lldb-commits
https://github.com/omjavaid approved this pull request. Looks good to me but I have not tested this. https://github.com/llvm/llvm-project/pull/109934 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[Lldb-commits] [lldb] 0e24611 - [lldb][AArch64] Add register fields for the fpmr register (#109934)

2024-09-26 Thread via lldb-commits
Author: David Spickett Date: 2024-09-26T11:44:01+01:00 New Revision: 0e24611f5703d56a93fc2f7e46c73fabf2e3a8fe URL: https://github.com/llvm/llvm-project/commit/0e24611f5703d56a93fc2f7e46c73fabf2e3a8fe DIFF: https://github.com/llvm/llvm-project/commit/0e24611f5703d56a93fc2f7e46c73fabf2e3a8fe.diff

[Lldb-commits] [lldb] [lldb][AArch64] Read fpmr register from core files (PR #110104)

2024-09-26 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/110104 None >From 58911927a59557aab167792f62f2c9ba9a86fa0d Mon Sep 17 00:00:00 2001 From: David Spickett Date: Thu, 29 Aug 2024 16:18:56 +0100 Subject: [PATCH] [lldb][AArch64] Read fpmr register from core files

[Lldb-commits] [lldb] [lldb][AArch64] Read fpmr register from core files (PR #110104)

2024-09-26 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/110104 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AArch64] Read fpmr register from core files (PR #110104)

2024-09-26 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/110104.diff 6 Files Affected: - (modified) lldb/source/Plugins/Process/elf-core/RegisterContextPOSIXCore_arm64.cpp (+13) - (modified) lld

[Lldb-commits] [lldb] [lldb][AArch64] Read fpmr register from core files (PR #110104)

2024-09-26 Thread David Spickett via lldb-commits
@@ -61,3 +65,19 @@ def test_fpmr_register(self): # 0 means the program found the new value in the sysreg as expected. self.expect("continue", substrs=["exited with status = 0"]) + +@skipIfLLVMTargetMissing("AArch64") +def test_fpmr_register_core(self):

[Lldb-commits] [lldb] [lldb][AArch64] Read fpmr register from core files (PR #110104)

2024-09-26 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/110104 >From 58911927a59557aab167792f62f2c9ba9a86fa0d Mon Sep 17 00:00:00 2001 From: David Spickett Date: Thu, 29 Aug 2024 16:18:56 +0100 Subject: [PATCH 1/2] [lldb][AArch64] Read fpmr register from core files -

[Lldb-commits] [lldb] [lldb][AArch64] Read fpmr register from core files (PR #110104)

2024-09-26 Thread David Spickett via lldb-commits
DavidSpickett wrote: Last one for FPMR. I'll push the release notes directly. Thanks for reviewing! https://github.com/llvm/llvm-project/pull/110104 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[Lldb-commits] [lldb] [lldb][AArch64] Add register fields for the fpmr register (PR #109934)

2024-09-26 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/109934 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Don't flush llvm::raw_string_ostream (NFC) (PR #110128)

2024-09-26 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/110128 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [DWARF]Set uuid for symbol file spec (PR #110066)

2024-09-26 Thread Kevin Frei via lldb-commits
kevinfrei wrote: The DWP tests I tried to land turned into a nightmare of "your change to test infra requires you learn about all the wacky ways obscure test infra may or may not be configured" so there *are* tests, but they're disabled. If folks are okay with using yaml2obj as a mechanism to

[Lldb-commits] [lldb] f35719f - [lldb] Don't flush llvm::raw_string_ostream (NFC) (#110128)

2024-09-26 Thread via lldb-commits
Author: Youngsuk Kim Date: 2024-09-26T12:29:14-04:00 New Revision: f35719ff670521454c8dfd83ec9d55dde65a5c3d URL: https://github.com/llvm/llvm-project/commit/f35719ff670521454c8dfd83ec9d55dde65a5c3d DIFF: https://github.com/llvm/llvm-project/commit/f35719ff670521454c8dfd83ec9d55dde65a5c3d.diff

[Lldb-commits] [lldb] [lldb] Don't flush llvm::raw_string_ostream (NFC) (PR #110128)

2024-09-26 Thread Youngsuk Kim via lldb-commits
https://github.com/JOE1994 closed https://github.com/llvm/llvm-project/pull/110128 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Inline expression evaluator error visualization (PR #106470)

2024-09-26 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/106470 >From 9f4ba3fdb8b144736e51134ced3019a2c57ca861 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Wed, 28 Aug 2024 10:04:33 -0700 Subject: [PATCH 1/2] [lldb] Store expression evaluator diagnostics in an l

[Lldb-commits] [lldb] [LLDB][ProcessELFCore] Add Description to ProcessELFCore/ELFThread stop reasons (PR #110065)

2024-09-26 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/110065 >From 0e31c0ad2b9db1ba9055bb4b984557100c0a9feb Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Tue, 24 Sep 2024 17:42:49 -0700 Subject: [PATCH 1/4] Add the addr info when appropriate for NIX' crash signals -

[Lldb-commits] [lldb] [lldb][test] Support remote run of Shell tests (PR #95986)

2024-09-26 Thread David Spickett via lldb-commits
@@ -235,6 +235,8 @@ if (CMAKE_SIZEOF_VOID_P EQUAL 8) set(LLDB_IS_64_BITS 1) endif() +set(LLDB_SHELL_TESTS_DISABLE_REMOTE OFF CACHE BOOL "Disable remote Shell tests execution") DavidSpickett wrote: Ok and that means you can still use a single `ninja check-l

[Lldb-commits] [lldb] [lldb] Don't flush llvm::raw_string_ostream (NFC) (PR #110128)

2024-09-26 Thread Youngsuk Kim via lldb-commits
https://github.com/JOE1994 created https://github.com/llvm/llvm-project/pull/110128 Don't call raw_string_ostream::flush(), which is essentially a no-op. As specified in the docs, raw_string_ostream is always unbuffered. ( 65b13610a5226b84889b923bae884ba395ad084d for further reference ) >From

[Lldb-commits] [lldb] [lldb] Don't flush llvm::raw_string_ostream (NFC) (PR #110128)

2024-09-26 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Youngsuk Kim (JOE1994) Changes Don't call raw_string_ostream::flush(), which is essentially a no-op. As specified in the docs, raw_string_ostream is always unbuffered. ( 65b13610a5226b84889b923bae884ba395ad084d for further reference ) ---

[Lldb-commits] [lldb] [lldb] Don't flush llvm::raw_string_ostream (NFC) (PR #110128)

2024-09-26 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 3e0d31c97cf27d46c464bf5a2712b28b69fa0503 e69c4a54403aae94d08302f4a33f25d7c70e7a37 --e

[Lldb-commits] [lldb] [lldb] Don't flush llvm::raw_string_ostream (NFC) (PR #110128)

2024-09-26 Thread Youngsuk Kim via lldb-commits
JOE1994 wrote: > ⚠️ C/C++ code formatter, clang-format found issues in your code. ⚠️ > > You can test this locally with the following command: > View the diff from clang-format here. clang-format is complaining about an adjacent line that is untouched by this revision. To simplify patch diff,

[Lldb-commits] [lldb] [llvm] [lldb][DWARF] Replace lldb's DWARFDebugArangeSet with llvm's (PR #110058)

2024-09-26 Thread Jonas Devlieghere via lldb-commits
@@ -7,65 +7,45 @@ //===--===// #include "DWARFDebugAranges.h" -#include "DWARFDebugArangeSet.h" #include "DWARFUnit.h" #include "LogChannelDWARF.h" #include "lldb/Utility/Log.h" #include "lldb/Utility/Tim

[Lldb-commits] [lldb] [llvm] [lldb][DWARF] Replace lldb's DWARFDebugArangeSet with llvm's (PR #110058)

2024-09-26 Thread Jonas Devlieghere via lldb-commits
@@ -73,6 +73,12 @@ class DWARFDebugArangeSet { return desc_iterator_range(ArangeDescriptors.begin(), ArangeDescriptors.end()); } + + size_t getDescriptorsSize() const { return ArangeDescriptors.size(); } + + const Descriptor &getDescriptio

[Lldb-commits] [lldb] [llvm] [lldb][DWARF] Replace lldb's DWARFDebugArangeSet with llvm's (PR #110058)

2024-09-26 Thread Jonas Devlieghere via lldb-commits
@@ -7,65 +7,45 @@ //===--===// #include "DWARFDebugAranges.h" -#include "DWARFDebugArangeSet.h" #include "DWARFUnit.h" #include "LogChannelDWARF.h" #include "lldb/Utility/Log.h" #include "lldb/Utility/Tim

[Lldb-commits] [lldb] [lldb][test] Support remote run of Shell tests (PR #95986)

2024-09-26 Thread Vladislav Dzhidzhoev via lldb-commits
https://github.com/dzhidzhoev updated https://github.com/llvm/llvm-project/pull/95986 >From da63c0b7439358942b379776715a2369acc56593 Mon Sep 17 00:00:00 2001 From: Vladislav Dzhidzhoev Date: Fri, 31 May 2024 21:39:56 + Subject: [PATCH 1/8] [lldb][test] Support remote run of Shell tests 1.

[Lldb-commits] [lldb] 3eaaf7c - [lldb][AArch64] Fix crash loading core files on 32 bit systems

2024-09-26 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2024-09-26T12:06:23Z New Revision: 3eaaf7c4d062976901c79b523e9f3cc606943119 URL: https://github.com/llvm/llvm-project/commit/3eaaf7c4d062976901c79b523e9f3cc606943119 DIFF: https://github.com/llvm/llvm-project/commit/3eaaf7c4d062976901c79b523e9f3cc606943119.diff LOG

[Lldb-commits] [lldb] [lldb][test] Support remote run of Shell tests (PR #95986)

2024-09-26 Thread David Spickett via lldb-commits
@@ -60,7 +60,8 @@ something like ``target.BreakpointCreateByName`` [#]_. A good rule of thumb is to prefer shell tests when what is being tested is relatively simple. Expressivity is limited compared to the API tests, which means that you have to have a well-defined test scenar

[Lldb-commits] [lldb] [lldb][test] Support remote run of Shell tests (PR #95986)

2024-09-26 Thread Vladislav Dzhidzhoev via lldb-commits
@@ -60,7 +60,8 @@ something like ``target.BreakpointCreateByName`` [#]_. A good rule of thumb is to prefer shell tests when what is being tested is relatively simple. Expressivity is limited compared to the API tests, which means that you have to have a well-defined test scenar

[Lldb-commits] [lldb] [lldb][test] Support remote run of Shell tests (PR #95986)

2024-09-26 Thread David Spickett via lldb-commits
@@ -235,6 +235,8 @@ if (CMAKE_SIZEOF_VOID_P EQUAL 8) set(LLDB_IS_64_BITS 1) endif() +set(LLDB_SHELL_TESTS_DISABLE_REMOTE OFF CACHE BOOL "Disable remote Shell tests execution") DavidSpickett wrote: Remind me again what this does (probably the third time I'v

[Lldb-commits] [lldb] [lldb][test] Support remote run of Shell tests (PR #95986)

2024-09-26 Thread Vladislav Dzhidzhoev via lldb-commits
dzhidzhoev wrote: Rebased & added a line to documentation about the usage of API tests for remote testing. https://github.com/llvm/llvm-project/pull/95986 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[Lldb-commits] [lldb] [lldb][test] Support remote run of Shell tests (PR #95986)

2024-09-26 Thread Vladislav Dzhidzhoev via lldb-commits
https://github.com/dzhidzhoev updated https://github.com/llvm/llvm-project/pull/95986 >From da63c0b7439358942b379776715a2369acc56593 Mon Sep 17 00:00:00 2001 From: Vladislav Dzhidzhoev Date: Fri, 31 May 2024 21:39:56 + Subject: [PATCH 1/9] [lldb][test] Support remote run of Shell tests 1.

[Lldb-commits] [lldb] [lldb][test] Support remote run of Shell tests (PR #95986)

2024-09-26 Thread Vladislav Dzhidzhoev via lldb-commits
@@ -235,6 +235,8 @@ if (CMAKE_SIZEOF_VOID_P EQUAL 8) set(LLDB_IS_64_BITS 1) endif() +set(LLDB_SHELL_TESTS_DISABLE_REMOTE OFF CACHE BOOL "Disable remote Shell tests execution") dzhidzhoev wrote: > Also should this be LLDB_TEST_SHELL_TESTS_DISABLE_REMOTE? So

[Lldb-commits] [lldb] [lldb][test] Support remote run of Shell tests (PR #95986)

2024-09-26 Thread Vladislav Dzhidzhoev via lldb-commits
https://github.com/dzhidzhoev updated https://github.com/llvm/llvm-project/pull/95986 >From da63c0b7439358942b379776715a2369acc56593 Mon Sep 17 00:00:00 2001 From: Vladislav Dzhidzhoev Date: Fri, 31 May 2024 21:39:56 + Subject: [PATCH 01/11] [lldb][test] Support remote run of Shell tests 1

[Lldb-commits] [lldb] [lldb] Fix minor runCmd error message formatting (PR #110150)

2024-09-26 Thread Dave Lee via lldb-commits
https://github.com/kastiglione created https://github.com/llvm/llvm-project/pull/110150 None >From fb0c5eefa9d3f3500a4767a727a0c39f2dff01d2 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Wed, 25 Sep 2024 15:07:34 -0700 Subject: [PATCH] [lldb] Fix minor runCmd error message formatting --- lldb

[Lldb-commits] [lldb] [lldb] Fix minor runCmd error message formatting (PR #110150)

2024-09-26 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dave Lee (kastiglione) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/110150.diff 1 Files Affected: - (modified) lldb/packages/Python/lldbsuite/test/lldbtest.py (+5-7) ``diff diff --git a/lldb/packages/Pytho

[Lldb-commits] [lldb] [lldb] Fix minor runCmd error message formatting (PR #110150)

2024-09-26 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/110150 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb][DWARF] Replace lldb's DWARFDebugArangeSet with llvm's (PR #110058)

2024-09-26 Thread Zequan Wu via lldb-commits
https://github.com/ZequanWu updated https://github.com/llvm/llvm-project/pull/110058 >From 8e1c59729905fb89a8764ace3dfa0d04119d273e Mon Sep 17 00:00:00 2001 From: Zequan Wu Date: Wed, 25 Sep 2024 15:59:29 -0700 Subject: [PATCH 1/3] [lldb][DWARF] Replace lldb's DWARFDebugArangeSet with llvm's

[Lldb-commits] [lldb] [llvm] [lldb][DWARF] Replace lldb's DWARFDebugArangeSet with llvm's (PR #110058)

2024-09-26 Thread Zequan Wu via lldb-commits
@@ -7,65 +7,45 @@ //===--===// #include "DWARFDebugAranges.h" -#include "DWARFDebugArangeSet.h" #include "DWARFUnit.h" #include "LogChannelDWARF.h" #include "lldb/Utility/Log.h" #include "lldb/Utility/Tim

[Lldb-commits] [lldb] [lldb] Support frame recognizer regexp on mangled names. (PR #105756)

2024-09-26 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: > @adrian-prantl Now that #105695 is merged, do you still want to open a > follow-up pull request to change the assert-recognizer and the > verbose-trap-recognizer to use `ePreferMangled`? That would be a nice improvement! https://github.com/llvm/llvm-project/pull/105756

[Lldb-commits] [lldb] [DWARF]Set uuid for symbol file spec (PR #110066)

2024-09-26 Thread Greg Clayton via lldb-commits
clayborg wrote: Change looks good to me, but we should find a way to test. We just need a test file + .dwp file and load that into lldb and force it to try and find the symbols right? Shouldn't require a core file. Then both the executable + .dwp file can be obj2yaml'ed https://github.com/ll

[Lldb-commits] [lldb] [lldb] Fix minor runCmd error message formatting (PR #110150)

2024-09-26 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/110150 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix minor runCmd error message formatting (PR #110150)

2024-09-26 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. https://github.com/llvm/llvm-project/pull/110150 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Inline expression evaluator error visualization (PR #106470)

2024-09-26 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: Done. @labath, you can now opt into the inline diagnostics with `show-inline-diagnostics` which `tools/driver` sets. https://github.com/llvm/llvm-project/pull/106470 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https:

[Lldb-commits] [lldb] Add docs describing how the thread plan stack affects stepping (PR #110167)

2024-09-26 Thread via lldb-commits
https://github.com/jimingham created https://github.com/llvm/llvm-project/pull/110167 This is a convenient little feature of lldb, but if you didn't know it was there you'd likely never discover it. >From 0f79f9cf1820b46199fe587cafc67532136ed04b Mon Sep 17 00:00:00 2001 From: Jim Ingham Date:

[Lldb-commits] [lldb] Add docs describing how the thread plan stack affects stepping (PR #110167)

2024-09-26 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (jimingham) Changes This is a convenient little feature of lldb, but if you didn't know it was there you'd likely never discover it. --- Full diff: https://github.com/llvm/llvm-project/pull/110167.diff 1 Files Affected: - (modified

[Lldb-commits] [lldb] Improve type lookup using .debug_names parent chain (PR #108907)

2024-09-26 Thread via lldb-commits
https://github.com/kusmour commented: Just some nits https://github.com/llvm/llvm-project/pull/108907 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Improve type lookup using .debug_names parent chain (PR #108907)

2024-09-26 Thread via lldb-commits
https://github.com/kusmour edited https://github.com/llvm/llvm-project/pull/108907 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Improve type lookup using .debug_names parent chain (PR #108907)

2024-09-26 Thread via lldb-commits
@@ -115,6 +122,11 @@ class DWARFIndex { bool GetFullyQualifiedTypeImpl(const DWARFDeclContext &context, DWARFDIE die, llvm::function_ref callback); + + /// Check if the type \a die can meet the requirements of \a query. + bool + ProcessTypeDie

[Lldb-commits] [lldb] Improve type lookup using .debug_names parent chain (PR #108907)

2024-09-26 Thread via lldb-commits
@@ -118,6 +122,36 @@ class DebugNamesDWARFIndex : public DWARFIndex { bool SameParentChain(llvm::ArrayRef parent_names, llvm::ArrayRef parent_entries) const; + bool SameParentChain(llvm::ArrayRef parent_names, kusmour wrote: ```sugge

[Lldb-commits] [lldb] [lldb] Fix minor runCmd error message formatting (PR #110150)

2024-09-26 Thread Dave Lee via lldb-commits
https://github.com/kastiglione closed https://github.com/llvm/llvm-project/pull/110150 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] bfe2994 - [lldb] Fix minor runCmd error message formatting (#110150)

2024-09-26 Thread via lldb-commits
Author: Dave Lee Date: 2024-09-26T13:39:54-07:00 New Revision: bfe29945603e2040cc56d9e30f05da0627c819cd URL: https://github.com/llvm/llvm-project/commit/bfe29945603e2040cc56d9e30f05da0627c819cd DIFF: https://github.com/llvm/llvm-project/commit/bfe29945603e2040cc56d9e30f05da0627c819cd.diff LOG:

[Lldb-commits] [lldb] Add docs describing how the thread plan stack affects stepping (PR #110167)

2024-09-26 Thread Alex Langford via lldb-commits
@@ -536,6 +536,33 @@ This command will run the thread in the current frame until it reaches line 100 in this frame or stops if it leaves the current frame. This is a pretty close equivalent to GDB's ``until`` command. +One other useful thing to note about the lldb stepping co

[Lldb-commits] [lldb] Add docs describing how the thread plan stack affects stepping (PR #110167)

2024-09-26 Thread Alex Langford via lldb-commits
@@ -536,6 +536,33 @@ This command will run the thread in the current frame until it reaches line 100 in this frame or stops if it leaves the current frame. This is a pretty close equivalent to GDB's ``until`` command. +One other useful thing to note about the lldb stepping co

[Lldb-commits] [lldb] Add docs describing how the thread plan stack affects stepping (PR #110167)

2024-09-26 Thread Alex Langford via lldb-commits
https://github.com/bulbazord edited https://github.com/llvm/llvm-project/pull/110167 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add docs describing how the thread plan stack affects stepping (PR #110167)

2024-09-26 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. LGTM, a few minor suggestions but nothing of great importance. Thanks for writing this up! https://github.com/llvm/llvm-project/pull/110167 ___ lldb-commits mailing list lldb-commits@lists.llvm.

[Lldb-commits] [lldb] Add docs describing how the thread plan stack affects stepping (PR #110167)

2024-09-26 Thread Alex Langford via lldb-commits
@@ -536,6 +536,33 @@ This command will run the thread in the current frame until it reaches line 100 in this frame or stops if it leaves the current frame. This is a pretty close equivalent to GDB's ``until`` command. +One other useful thing to note about the lldb stepping co

[Lldb-commits] [lldb] Add docs describing how the thread plan stack affects stepping (PR #110167)

2024-09-26 Thread Alex Langford via lldb-commits
@@ -536,6 +536,33 @@ This command will run the thread in the current frame until it reaches line 100 in this frame or stops if it leaves the current frame. This is a pretty close equivalent to GDB's ``until`` command. +One other useful thing to note about the lldb stepping co

[Lldb-commits] [lldb] [lldb] Introduce an always-on system log category/channel (PR #108495)

2024-09-26 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/108495 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Introduce an always-on system log category/channel (PR #108495)

2024-09-26 Thread Pavel Labath via lldb-commits
@@ -272,6 +272,12 @@ class Log final { void VAFormatf(llvm::StringRef file, llvm::StringRef function, const char *format, va_list args); + void Enable(const std::shared_ptr &handler_sp, + uint32_t options = 0, + MaskType flags = st

[Lldb-commits] [lldb] [lldb] Introduce an always-on system log category/channel (PR #108495)

2024-09-26 Thread Pavel Labath via lldb-commits
@@ -83,6 +85,9 @@ llvm::Error SystemInitializerFull::Initialize() { // Use the Debugger's LLDBAssert callback. SetLLDBAssertCallback(Debugger::AssertCallback); + // Log the LLDB version to the system log. labath wrote: I don't think this tells us anythin

[Lldb-commits] [lldb] Improve type lookup using .debug_names parent chain (PR #108907)

2024-09-26 Thread via lldb-commits
https://github.com/jeffreytan81 updated https://github.com/llvm/llvm-project/pull/108907 >From 6e84ab9a14e63c58e1facdbf9a695c093882b37b Mon Sep 17 00:00:00 2001 From: jeffreytan81 Date: Mon, 19 Aug 2024 10:57:35 -0700 Subject: [PATCH 1/2] Fix StartDebuggingRequestHandler/ReplModeRequestHandler

[Lldb-commits] [lldb] c117222 - [LLDB][Minidump] Add Multiplatform test to ensure determinism (#108602)

2024-09-26 Thread via lldb-commits
Author: Jacob Lalonde Date: 2024-09-26T14:33:12-07:00 New Revision: c1173bacf604e60414542743d021a9f13aee URL: https://github.com/llvm/llvm-project/commit/c1173bacf604e60414542743d021a9f13aee DIFF: https://github.com/llvm/llvm-project/commit/c1173bacf604e60414542743d021a9f13aee.diff

[Lldb-commits] [lldb] [LLDB][Minidump] Add Multiplatform test to ensure determinism (PR #108602)

2024-09-26 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond closed https://github.com/llvm/llvm-project/pull/108602 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add docs describing how the thread plan stack affects stepping (PR #110167)

2024-09-26 Thread via lldb-commits
https://github.com/jimingham updated https://github.com/llvm/llvm-project/pull/110167 >From 0f79f9cf1820b46199fe587cafc67532136ed04b Mon Sep 17 00:00:00 2001 From: Jim Ingham Date: Thu, 26 Sep 2024 13:31:57 -0700 Subject: [PATCH 1/2] Add docs describing how the thread plan stack affects steppi

[Lldb-commits] [lldb] Add docs describing how the thread plan stack affects stepping (PR #110167)

2024-09-26 Thread Chelsea Cassanova via lldb-commits
chelcassanova wrote: Adding myself as a reviewer here, I didn't know about either of these commands and the behaviour described here is something I've noticed without knowing exactly what was happening 😅 . The explanation for the docs looks good here so this LGTM. https://github.com/llvm/llvm

[Lldb-commits] [lldb] [LLDB][Minidump] Add Multiplatform test to ensure determinism (PR #108602)

2024-09-26 Thread via lldb-commits
https://github.com/kusmour approved this pull request. 🚀 https://github.com/llvm/llvm-project/pull/108602 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add docs describing how the thread plan stack affects stepping (PR #110167)

2024-09-26 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova approved this pull request. https://github.com/llvm/llvm-project/pull/110167 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][ProcessELFCore] Add Description to ProcessELFCore/ELFThread stop reasons (PR #110065)

2024-09-26 Thread Jacob Lalonde via lldb-commits
Jlalond wrote: Looks like I got some failures due to the tests expecting an exact string match. Will fix https://github.com/llvm/llvm-project/pull/110065 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[Lldb-commits] [lldb] [lldb] Inline expression evaluator error visualization (PR #106470)

2024-09-26 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/106470 >From 9f4ba3fdb8b144736e51134ced3019a2c57ca861 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Wed, 28 Aug 2024 10:04:33 -0700 Subject: [PATCH 1/2] [lldb] Store expression evaluator diagnostics in an l

[Lldb-commits] [lldb] Add docs describing how the thread plan stack affects stepping (PR #110167)

2024-09-26 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/110167 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits