[Lldb-commits] [lldb] [lldb-dap] Add feature to remember last non-empty expression. (PR #107485)

@@ -1376,6 +1382,16 @@ void request_evaluate(const llvm::json::Object &request) { EmplaceSafeString(body, "result", result); body.try_emplace("variablesReference", (int64_t)0); } else { +if (context == "repl") { + // If the expression is empty and the last e

[Lldb-commits] [lldb] [lldb-dap] Add feature to remember last non-empty expression. (PR #107485)

@@ -1364,8 +1364,14 @@ void request_evaluate(const llvm::json::Object &request) { std::string expression = GetString(arguments, "expression").str(); llvm::StringRef context = GetString(arguments, "context"); - if (context == "repl" && g_dap.DetectExpressionContext(frame,

[Lldb-commits] [lldb] [lldb] Do not use LC_FUNCTION_STARTS data to determine symbol size as symbols are created (PR #106791)

JDevlieghere wrote: It looks like this breaks `Unwind.trap_frame_sym_ctx` on x86_64: https://ci.swift.org/view/all/job/llvm.org/view/LLDB/job/lldb-cmake/5745/testReport/junit/lldb-shell/Unwind/trap_frame_sym_ctx_test/ I'm going to revert this to get the bots green over the weekend. https://gi

[Lldb-commits] [lldb] Revert "[lldb] Do not use LC_FUNCTION_STARTS data to determine symbol size as symbols are created" (PR #108715)

https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/108715 Reverts llvm/llvm-project#106791 because it breaks `trap_frame_sym_ctx.test ` on x86_64. https://ci.swift.org/view/all/job/llvm.org/view/LLDB/job/lldb-cmake/5745/ >From ba6e663299e1d7b54a3ac4a7c647d44f66

[Lldb-commits] [lldb] Revert "[lldb] Do not use LC_FUNCTION_STARTS data to determine symbol size as symbols are created" (PR #108715)

https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/108715 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] fa478bd - Revert "[lldb] Do not use LC_FUNCTION_STARTS data to determine symbol size as symbols are created" (#108715)

Author: Jonas Devlieghere Date: 2024-09-14T10:50:44-07:00 New Revision: fa478bd275f473861f6d4df4896244a730d4853f URL: https://github.com/llvm/llvm-project/commit/fa478bd275f473861f6d4df4896244a730d4853f DIFF: https://github.com/llvm/llvm-project/commit/fa478bd275f473861f6d4df4896244a730d4853f.d

[Lldb-commits] [lldb] Revert "[lldb] Do not use LC_FUNCTION_STARTS data to determine symbol size as symbols are created" (PR #108715)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes Reverts llvm/llvm-project#106791 because it breaks `trap_frame_sym_ctx.test ` on x86_64. https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/lldb-cmake/5745/ --- Full diff: https://github.com/ll

[Lldb-commits] [lldb] Revert "[lldb] Do not use LC_FUNCTION_STARTS data to determine symbol size as symbols are created" (PR #108715)

https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/108715 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][intel-pt] Fix build error on conversion from llvm::Error to Status::FromError (PR #108719)

https://github.com/kusmour created https://github.com/llvm/llvm-project/pull/108719 Summary: This introduced from upstream [#107163](https://github.com/llvm/llvm-project/pull/107163) Test Plan: I can build >From ff2f26081b5535587e5ccb28522b728a596b6e12 Mon Sep 17 00:00:00 2001 From: Wanyi Ye

[Lldb-commits] [lldb] [lldb][intel-pt] Fix build error on conversion from llvm::Error to Status::FromError (PR #108719)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Wanyi (kusmour) Changes Summary: This introduced from upstream [#107163](https://github.com/llvm/llvm-project/pull/107163) Test Plan: I can build --- Full diff: https://github.com/llvm/llvm-project/pull/108719.diff 1 Files Affected: - (

[Lldb-commits] [lldb] [lldb][intel-pt] Fix build error on conversion from llvm::Error to Status::FromError (PR #108719)

Jlalond wrote: Hey @kusmour. I actually looked into this on Thursday, see #108248. If we are going to merge this I think we should just call `std::move` and not `Status::FromError(std::move(err))` as the API takes an err r-value. https://github.com/llvm/llvm-project/pull/108719 ___

[Lldb-commits] [lldb] [lldb] [debugserver] Use "full" x86_64 GPR state when available. (PR #108663)

jasonmolenda wrote: Nice improvement. Let me apply it and experiment a tiny bit next week, but a quick read looks good. https://github.com/llvm/llvm-project/pull/108663 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/

[Lldb-commits] [lldb] [lldb] [debugserver] Use "full" x86_64 GPR state when available. (PR #108663)

jasonmolenda wrote: (I hadn't noticed the kernel added this new flavor for intel machines, I've had people ask for access to these before.) https://github.com/llvm/llvm-project/pull/108663 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http