[Lldb-commits] [lldb] [lldb] Introduce an always-on system log category/channel (PR #108495)

2024-09-13 Thread David Spickett via lldb-commits
@@ -31,6 +31,22 @@ class ProcessInstanceInfo; class ProcessInstanceInfoMatch; typedef std::vector ProcessInstanceInfoList; +// Always on system log category and channel. DavidSpickett wrote: So is the log naming `system system` or for now is it just `system`

[Lldb-commits] [lldb] [lldb] Introduce an always-on system log category/channel (PR #108495)

2024-09-13 Thread David Spickett via lldb-commits
@@ -0,0 +1,3 @@ +RUN: %lldb -o 'log list' -o 'log disable system' 2>&1 | FileCheck %s +CHECK-NOT: Logging categories for 'system' +CHECK: Cannot disable internal log channel 'system'. DavidSpickett wrote: This is bikeshedding but perhaps: ``` `system` is an inter

[Lldb-commits] [lldb] [lldb] Introduce an always-on system log category/channel (PR #108495)

2024-09-13 Thread David Spickett via lldb-commits
DavidSpickett wrote: > Unlike other, existing log channels, it is not exposed to users. This is presumably because: 1. It contains very low level messages they likely won't be interested in. 2. If it weren't hidden, it would be printing into their sessions all the time. Users can still list it,

[Lldb-commits] [lldb] [lldb] Introduce an always-on system log category/channel (PR #108495)

2024-09-13 Thread David Spickett via lldb-commits
DavidSpickett wrote: >We have a similar concept in the downstream Swift fork and this has proven to >be extremely valuable. This is especially true on macOS where system log >messages are automatically captured as part of a sysdiagnose. Does this mean someone has already been putting non-MacOS

[Lldb-commits] [lldb] [lldb] Removed gdbserver ports map from lldb-server (PR #104238)

2024-09-13 Thread Dmitry Vasilyev via lldb-commits
slydiman wrote: @labath Let's decide how to finish this patch, please. I would prefer to commit the new functionality. Any cosmetics and refactoring is possible at any time. https://github.com/llvm/llvm-project/pull/104238 ___ lldb-commits mailing lis

[Lldb-commits] [lldb] [LLDB] Fix operators <= and >= returning a wrong result when comparing to a floating point NaN (PR #108060)

2024-09-13 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. Thanks. https://github.com/llvm/llvm-project/pull/108060 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb] Change lldb's breakpoint detection behavior [WIP] (PR #105594)

2024-09-13 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda updated https://github.com/llvm/llvm-project/pull/105594 >From 56ca564185bdceea25162a1ce3b1e8c8fa2641e2 Mon Sep 17 00:00:00 2001 From: Jason Molenda Date: Fri, 19 Jul 2024 17:26:13 -0700 Subject: [PATCH 1/6] [lldb] Change lldb's breakpoint handling behavior (#96

[Lldb-commits] [lldb] [lldb] Set the stop reason when receiving swbreak/hwbreak (PR #108518)

2024-09-13 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda created https://github.com/llvm/llvm-project/pull/108518 xusheng added support for swbreak/hwbreak a month ago, and no special support was needed in ProcessGDBRemote when they're received because lldb already marks a thread as having hit a breakpoint when it sto

[Lldb-commits] [lldb] [lldb] Set the stop reason when receiving swbreak/hwbreak (PR #108518)

2024-09-13 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jason Molenda (jasonmolenda) Changes xusheng added support for swbreak/hwbreak a month ago, and no special support was needed in ProcessGDBRemote when they're received because lldb already marks a thread as having hit a breakpoint when it

[Lldb-commits] [lldb] [lldb] Set the stop reason when receiving swbreak/hwbreak (PR #108518)

2024-09-13 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: This is the follow up patch I alluded to in https://github.com/llvm/llvm-project/pull/102873 needed for my work to re-land my change to how breakpoints are handled in lldb (work in progress at https://github.com/llvm/llvm-project/pull/108504 ). It's the same thing we do f

[Lldb-commits] [lldb] [llvm] [lldb] Change lldb's breakpoint detection behavior [WIP] (PR #105594)

2024-09-13 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda updated https://github.com/llvm/llvm-project/pull/105594 >From 56ca564185bdceea25162a1ce3b1e8c8fa2641e2 Mon Sep 17 00:00:00 2001 From: Jason Molenda Date: Fri, 19 Jul 2024 17:26:13 -0700 Subject: [PATCH 1/7] [lldb] Change lldb's breakpoint handling behavior (#96

[Lldb-commits] [lldb] [lldb] Make sure TestDAP_subtleFrames actually uses libc++ (PR #108227)

2024-09-13 Thread Pavel Labath via lldb-commits
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/108227 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 069b841 - [lldb] Make sure TestDAP_subtleFrames actually uses libc++ (#108227)

2024-09-13 Thread via lldb-commits
Author: Pavel Labath Date: 2024-09-13T11:18:05+02:00 New Revision: 069b841c2ecde39c65ca74660b681d4d25a4bbb2 URL: https://github.com/llvm/llvm-project/commit/069b841c2ecde39c65ca74660b681d4d25a4bbb2 DIFF: https://github.com/llvm/llvm-project/commit/069b841c2ecde39c65ca74660b681d4d25a4bbb2.diff

[Lldb-commits] [lldb] [lldb] Change the implementation of Status to store an llvm::Error (NFC) (PR #106774)

2024-09-13 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/106774 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Change the implementation of Status to store an llvm::Error (NFC) (PR #106774)

2024-09-13 Thread Pavel Labath via lldb-commits
@@ -94,25 +126,36 @@ Status Status::FromErrorStringWithFormat(const char *format, ...) { return Status(string); } -Status Status::FromError(llvm::Error error) { return Status(std::move(error)); } +Status Status::FromExpressionError(lldb::ExpressionResults result, +

[Lldb-commits] [lldb] [lldb] Change the implementation of Status to store an llvm::Error (NFC) (PR #106774)

2024-09-13 Thread Pavel Labath via lldb-commits
@@ -94,26 +123,49 @@ Status Status::FromErrorStringWithFormat(const char *format, ...) { return Status(string); } -Status Status::FromError(llvm::Error error) { return Status(std::move(error)); } +Status Status::FromExpressionError(lldb::ExpressionResults result, +

[Lldb-commits] [lldb] [lldb] Deflake TestDAP_attach (PR #108226)

2024-09-13 Thread Pavel Labath via lldb-commits
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/108226 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] e054712 - [lldb] Deflake TestDAP_attach (#108226)

2024-09-13 Thread via lldb-commits
Author: Pavel Labath Date: 2024-09-13T11:21:50+02:00 New Revision: e054712a85f924e0afe7f180fd960be7a8214d64 URL: https://github.com/llvm/llvm-project/commit/e054712a85f924e0afe7f180fd960be7a8214d64 DIFF: https://github.com/llvm/llvm-project/commit/e054712a85f924e0afe7f180fd960be7a8214d64.diff

[Lldb-commits] [lldb] [lldb][test] TestDataFormatterLibcxxStringSimulator.py: fix padding for current layout (PR #108362)

2024-09-13 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/108362 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 4ca8fb1 - [lldb][test] TestDataFormatterLibcxxStringSimulator.py: fix padding for current layout (#108362)

2024-09-13 Thread via lldb-commits
Author: Michael Buch Date: 2024-09-13T11:01:25+01:00 New Revision: 4ca8fb18129e6465c3594a8681f1cca0e2aff724 URL: https://github.com/llvm/llvm-project/commit/4ca8fb18129e6465c3594a8681f1cca0e2aff724 DIFF: https://github.com/llvm/llvm-project/commit/4ca8fb18129e6465c3594a8681f1cca0e2aff724.diff

[Lldb-commits] [lldb] [lldb][test] TestDataFormatterLibcxxStringSimulator.py: fix padding for current layout (PR #108362)

2024-09-13 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/108362 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Add feature to remember last non-empty expression. (PR #107485)

2024-09-13 Thread Pavel Labath via lldb-commits
@@ -1376,6 +1382,16 @@ void request_evaluate(const llvm::json::Object &request) { EmplaceSafeString(body, "result", result); body.try_emplace("variablesReference", (int64_t)0); } else { +if (context != "hover") { labath wrote: Should the `!=hove

[Lldb-commits] [lldb] [lldb-dap] Add feature to remember last non-empty expression. (PR #107485)

2024-09-13 Thread Pavel Labath via lldb-commits
@@ -45,7 +45,8 @@ bool RunLLDBCommands(llvm::StringRef prefix, // RunTerminateCommands. static std::mutex handle_command_mutex; std::lock_guard locker(handle_command_mutex); - interp.HandleCommand(command.str().c_str(), result); + interp.HandleComman

[Lldb-commits] [lldb] [lldb-dap] Add feature to remember last non-empty expression. (PR #107485)

2024-09-13 Thread Pavel Labath via lldb-commits
@@ -1364,8 +1364,14 @@ void request_evaluate(const llvm::json::Object &request) { std::string expression = GetString(arguments, "expression").str(); llvm::StringRef context = GetString(arguments, "context"); - if (context == "repl" && g_dap.DetectExpressionContext(frame,

[Lldb-commits] [lldb] [lldb][test] TestDataFormatterLibcxxStringSimulator.py: add new padding layout (PR #108375)

2024-09-13 Thread Michael Buch via lldb-commits
@@ -77,7 +89,12 @@ template class basic_string { }; #else // !SUBCLASS_PADDING +#ifdef UB_PADDING unsigned char __padding[sizeof(value_type) - 1]; Michael137 wrote: Good point! I'll rename it to `NON_STANDARD_PADDING` https://github.com/llvm/llvm-

[Lldb-commits] [lldb] [lldb][test] TestDataFormatterLibcxxStringSimulator.py: add new padding layout (PR #108375)

2024-09-13 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/108375 >From 7932edadf5726b2c73911d1316112af36ab7f044 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Thu, 12 Sep 2024 12:55:17 +0100 Subject: [PATCH 1/2] [lldb][test] TestDataFormatterLibcxxStringSimulator.py: a

[Lldb-commits] [lldb] [lldb] Add pc check for thread-step-by-bp algorithms (PR #108504)

2024-09-13 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/108504 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Introduce an always-on system log category/channel (PR #108495)

2024-09-13 Thread Pavel Labath via lldb-commits
labath wrote: My first thought when seeing (before opening the phabricator patch) this was "wouldn't this be better off as a separate API". After opening the link, I saw that this was the last comment on it as well. So, what has changed since then? My think is that, our logging API is a fairly

[Lldb-commits] [lldb] [lldb] Add pc check for thread-step-by-bp algorithms (PR #108504)

2024-09-13 Thread David Spickett via lldb-commits
DavidSpickett wrote: > "if a thread stops at a breakpoint site, we set the thread's stop reason to > breakpoint-hit, even if the breakpoint hasn't been executed" What does it look like for a thread to be stopped at a *breakpoint site* but not to have executed the breakpoint? Is this just a ti

[Lldb-commits] [lldb] [lldb] Set the stop reason when receiving swbreak/hwbreak (PR #108518)

2024-09-13 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. Still curious exactly how we end up with threads on a breakpoint that didn't execute it - https://github.com/llvm/llvm-project/pull/108504#issuecomment-2348626494 But aside from that this LGTM. https://github.com/llvm/llvm-project/p

[Lldb-commits] [lldb] [lldb] Add a MainLoop version of DomainSocket::Accept (PR #108188)

2024-09-13 Thread Pavel Labath via lldb-commits
@@ -85,6 +85,43 @@ TEST_P(SocketTest, DomainListenConnectAccept) { std::unique_ptr socket_b_up; CreateDomainConnectedSockets(Path, &socket_a_up, &socket_b_up); } + +TEST_P(SocketTest, DomainMainLoopAccept) { labath wrote: It's already in a ifdef block, nex

[Lldb-commits] [lldb] ebbc9ed - [lldb] Add a MainLoop version of DomainSocket::Accept (#108188)

2024-09-13 Thread via lldb-commits
Author: Pavel Labath Date: 2024-09-13T12:56:52+02:00 New Revision: ebbc9ed2d60cacffc87232dc32374a2b38b92175 URL: https://github.com/llvm/llvm-project/commit/ebbc9ed2d60cacffc87232dc32374a2b38b92175 DIFF: https://github.com/llvm/llvm-project/commit/ebbc9ed2d60cacffc87232dc32374a2b38b92175.diff

[Lldb-commits] [lldb] [lldb] Add a MainLoop version of DomainSocket::Accept (PR #108188)

2024-09-13 Thread Pavel Labath via lldb-commits
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/108188 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add a MainLoop version of DomainSocket::Accept (PR #108188)

2024-09-13 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-x86_64-debian` running on `lldb-x86_64-debian` while building `lldb` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/162/builds/6215 Here is the relevant piece of the build log

[Lldb-commits] [lldb] [lldb] Add pc check for thread-step-by-bp algorithms (PR #108504)

2024-09-13 Thread Pavel Labath via lldb-commits
labath wrote: It can happen through timing, but also in single-threaded code as well. A thread could reach-but-not execute a breakpoint insn due to some activity on the previous insn. E.g. it could be single-stepping over it (so the stop reason is "i've completed a step", not "I've hit a break

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

2024-09-13 Thread via lldb-commits
@@ -471,6 +498,18 @@ static void SetupTargetOpts(CompilerInstance &compiler, // Set the target ABI if (std::string abi = GetClangTargetABI(target_arch); !abi.empty()) compiler.getTargetOpts().ABI = std::move(abi); + + if ((target_machine == llvm::Triple::riscv64 && +

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

2024-09-13 Thread via lldb-commits
https://github.com/dlav-sc edited https://github.com/llvm/llvm-project/pull/99336 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Add feature to remember last non-empty expression. (PR #107485)

2024-09-13 Thread Walter Erquinigo via lldb-commits
@@ -1376,6 +1382,16 @@ void request_evaluate(const llvm::json::Object &request) { EmplaceSafeString(body, "result", result); body.try_emplace("variablesReference", (int64_t)0); } else { +if (context != "hover") { walter-erquinigo wrote: yeah, th

[Lldb-commits] [lldb] Make env and source map dictionaries #95137 (PR #106919)

2024-09-13 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo approved this pull request. https://github.com/llvm/llvm-project/pull/106919 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

2024-09-13 Thread Michael Buch via lldb-commits
@@ -471,6 +498,18 @@ static void SetupTargetOpts(CompilerInstance &compiler, // Set the target ABI if (std::string abi = GetClangTargetABI(target_arch); !abi.empty()) compiler.getTargetOpts().ABI = std::move(abi); + + if ((target_machine == llvm::Triple::riscv64 && +

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

2024-09-13 Thread Michael Buch via lldb-commits
https://github.com/Michael137 commented: Expression parser side of things LGTM (apart from the redundant tests and the RuntimeDyld changes being in this patch). I'll let the others comment on the RISCV plugin changes. https://github.com/llvm/llvm-project/pull/99336

[Lldb-commits] [lldb] Make env and source map dictionaries #95137 (PR #106919)

2024-09-13 Thread via lldb-commits
Da-Viper wrote: > Nice improvement. Don't forget to write a test Will do this evening https://github.com/llvm/llvm-project/pull/106919 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm

[Lldb-commits] [lldb] [lldb] Add pc check for thread-step-by-bp algorithms (PR #108504)

2024-09-13 Thread David Spickett via lldb-commits
DavidSpickett wrote: Thanks I understand now. https://github.com/llvm/llvm-project/pull/108504 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Removed gdbserver ports map from lldb-server (PR #104238)

2024-09-13 Thread Pavel Labath via lldb-commits
labath wrote: > If you want to execute such child process for unix socket too, it is > necessary to transfer the protocol somehow too. I do want it. I don't think it's necessary to transfer the type of the socket, as that can be determined by inspecting the socket FD (`getsockopt(SO_DOMAIN/S

[Lldb-commits] [lldb] [lldb-dap] Add feature to remember last non-empty expression. (PR #107485)

2024-09-13 Thread via lldb-commits
@@ -45,7 +45,8 @@ bool RunLLDBCommands(llvm::StringRef prefix, // RunTerminateCommands. static std::mutex handle_command_mutex; std::lock_guard locker(handle_command_mutex); - interp.HandleCommand(command.str().c_str(), result); + interp.HandleComman

[Lldb-commits] [lldb] [lldb] Add pc check for thread-step-by-bp algorithms (PR #108504)

2024-09-13 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: Yeah, the problem with our current algorithm is that you lose the actual stop reason, and sometimes that's important. For instance, if you have a store instruction that modifies a watchpointed memory, and you have a user breakpoint on the next instruction, on AArch64, the

[Lldb-commits] [lldb] 213c59d - [lldb] Add pc check for thread-step-by-bp algorithms (#108504)

2024-09-13 Thread via lldb-commits
Author: Jason Molenda Date: 2024-09-13T09:02:31-07:00 New Revision: 213c59ddd2a702ddd3d849cea250440b1ed718e0 URL: https://github.com/llvm/llvm-project/commit/213c59ddd2a702ddd3d849cea250440b1ed718e0 DIFF: https://github.com/llvm/llvm-project/commit/213c59ddd2a702ddd3d849cea250440b1ed718e0.diff

[Lldb-commits] [lldb] [lldb] Add pc check for thread-step-by-bp algorithms (PR #108504)

2024-09-13 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda closed https://github.com/llvm/llvm-project/pull/108504 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 65a4d11 - [lldb] Set the stop reason when receiving swbreak/hwbreak (#108518)

2024-09-13 Thread via lldb-commits
Author: Jason Molenda Date: 2024-09-13T09:04:28-07:00 New Revision: 65a4d11b1e67429d53df1fcee0f93492aa95c448 URL: https://github.com/llvm/llvm-project/commit/65a4d11b1e67429d53df1fcee0f93492aa95c448 DIFF: https://github.com/llvm/llvm-project/commit/65a4d11b1e67429d53df1fcee0f93492aa95c448.diff

[Lldb-commits] [lldb] [lldb] Set the stop reason when receiving swbreak/hwbreak (PR #108518)

2024-09-13 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda closed https://github.com/llvm/llvm-project/pull/108518 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb] Change lldb's breakpoint detection behavior [WIP] (PR #105594)

2024-09-13 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda updated https://github.com/llvm/llvm-project/pull/105594 >From 56ca564185bdceea25162a1ce3b1e8c8fa2641e2 Mon Sep 17 00:00:00 2001 From: Jason Molenda Date: Fri, 19 Jul 2024 17:26:13 -0700 Subject: [PATCH 1/7] [lldb] Change lldb's breakpoint handling behavior (#96

[Lldb-commits] [lldb] 661382f - [LLDB][Minidump] Minidump erase file on failure (#108259)

2024-09-13 Thread via lldb-commits
Author: Jacob Lalonde Date: 2024-09-13T09:17:06-07:00 New Revision: 661382f2c07ba464caa0ad0fb8c64c1c3b20e9a4 URL: https://github.com/llvm/llvm-project/commit/661382f2c07ba464caa0ad0fb8c64c1c3b20e9a4 DIFF: https://github.com/llvm/llvm-project/commit/661382f2c07ba464caa0ad0fb8c64c1c3b20e9a4.diff

[Lldb-commits] [lldb] [LLDB][Minidump] Minidump erase file on failure (PR #108259)

2024-09-13 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond closed https://github.com/llvm/llvm-project/pull/108259 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Add feature to remember last non-empty expression. (PR #107485)

2024-09-13 Thread via lldb-commits
https://github.com/cmtice updated https://github.com/llvm/llvm-project/pull/107485 >From 15541f354decf80586d590db9f9cb353be04b122 Mon Sep 17 00:00:00 2001 From: Caroline Tice Date: Thu, 5 Sep 2024 15:51:35 -0700 Subject: [PATCH 1/6] [lldb-dap] Add feature to remember last non-empty expression.

[Lldb-commits] [lldb] [lldb-dap] Add feature to remember last non-empty expression. (PR #107485)

2024-09-13 Thread via lldb-commits
@@ -45,7 +45,8 @@ bool RunLLDBCommands(llvm::StringRef prefix, // RunTerminateCommands. static std::mutex handle_command_mutex; std::lock_guard locker(handle_command_mutex); - interp.HandleCommand(command.str().c_str(), result); + interp.HandleComman

[Lldb-commits] [lldb] [lldb-dap] Add feature to remember last non-empty expression. (PR #107485)

2024-09-13 Thread via lldb-commits
@@ -1364,8 +1364,14 @@ void request_evaluate(const llvm::json::Object &request) { std::string expression = GetString(arguments, "expression").str(); llvm::StringRef context = GetString(arguments, "context"); - if (context == "repl" && g_dap.DetectExpressionContext(frame,

[Lldb-commits] [lldb] [lldb-dap] Add feature to remember last non-empty expression. (PR #107485)

2024-09-13 Thread via lldb-commits
@@ -1376,6 +1382,16 @@ void request_evaluate(const llvm::json::Object &request) { EmplaceSafeString(body, "result", result); body.try_emplace("variablesReference", (int64_t)0); } else { +if (context != "hover") { cmtice wrote: Done. https://git

[Lldb-commits] [lldb] [lldb-dap] Add feature to remember last non-empty expression. (PR #107485)

2024-09-13 Thread via lldb-commits
cmtice wrote: All reviewer comments have been addressed. Please take another look. Thank you! https://github.com/llvm/llvm-project/pull/107485 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lld

[Lldb-commits] [lldb] [LLDB][Minidump] Add Multiplatform test to ensure determinism (PR #108602)

2024-09-13 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond created https://github.com/llvm/llvm-project/pull/108602 Adds a test that ensures two minidumps produced from the same target are the same bytes. Covers the three primary core flavors. >From 60b48f98ffa70dbf633f1b9bf935479dbfce59d4 Mon Sep 17 00:00:00 2001 From: Jaco

[Lldb-commits] [lldb] [LLDB][Minidump] Add Multiplatform test to ensure determinism (PR #108602)

2024-09-13 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jacob Lalonde (Jlalond) Changes Adds a test that ensures two minidumps produced from the same target are the same bytes. Covers the three primary core flavors. --- Full diff: https://github.com/llvm/llvm-project/pull/108602.diff 1 Files

[Lldb-commits] [lldb] [LLDB][Minidump] Add Multiplatform test to ensure determinism (PR #108602)

2024-09-13 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 661382f2c07ba464caa0ad0fb8c64c1c3b20e9a4...60b48f98ffa70dbf633f1b9bf935479dbfce59d4 lldb

[Lldb-commits] [lldb] [lldb] Emit signpost intervals for progress events (NFC) (PR #108498)

2024-09-13 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/108498 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Change the implementation of Status to store an llvm::Error (NFC) (PR #106774)

2024-09-13 Thread Adrian Prantl via lldb-commits
@@ -94,25 +126,36 @@ Status Status::FromErrorStringWithFormat(const char *format, ...) { return Status(string); } -Status Status::FromError(llvm::Error error) { return Status(std::move(error)); } +Status Status::FromExpressionError(lldb::ExpressionResults result, +

[Lldb-commits] [lldb] [lldb] Change the implementation of Status to store an llvm::Error (NFC) (PR #106774)

2024-09-13 Thread Adrian Prantl via lldb-commits
@@ -94,25 +126,36 @@ Status Status::FromErrorStringWithFormat(const char *format, ...) { return Status(string); } -Status Status::FromError(llvm::Error error) { return Status(std::move(error)); } +Status Status::FromExpressionError(lldb::ExpressionResults result, +

[Lldb-commits] [lldb] [LLDB][Minidump] Add Multiplatform test to ensure determinism (PR #108602)

2024-09-13 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/108602 >From 41bb7f8a13483e55f677d51e049e3d79d763088b Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Fri, 13 Sep 2024 09:29:46 -0700 Subject: [PATCH 1/2] Add multiplatform minidump determinism test --- .../TestPr

[Lldb-commits] [lldb] Avoid expression evaluation in libStdC++ std::vector synthetic children provider (PR #108414)

2024-09-13 Thread via lldb-commits
https://github.com/jimingham approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/108414 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Avoid expression evaluation in libStdC++ std::vector synthetic children provider (PR #108414)

2024-09-13 Thread via lldb-commits
@@ -645,6 +645,23 @@ lldb::SBValue SBValue::CreateValueFromData(const char *name, SBData data, return sb_value; } +lldb::SBValue SBValue::CreateBoolValue(const char *name, bool value) { + LLDB_INSTRUMENT_VA(this, name); + + lldb::SBValue sb_value; + lldb::ValueObjectSP n

[Lldb-commits] [lldb] 02d8813 - Add a comment in the SB API doc about keeping the SB API's lightweight. (#108462)

2024-09-13 Thread via lldb-commits
Author: jimingham Date: 2024-09-13T10:18:03-07:00 New Revision: 02d8813820b1ebf3fae6993e677db269f0077272 URL: https://github.com/llvm/llvm-project/commit/02d8813820b1ebf3fae6993e677db269f0077272 DIFF: https://github.com/llvm/llvm-project/commit/02d8813820b1ebf3fae6993e677db269f0077272.diff LOG

[Lldb-commits] [lldb] Add a comment in the SB API doc about keeping the SB API's lightweight. (PR #108462)

2024-09-13 Thread via lldb-commits
https://github.com/jimingham closed https://github.com/llvm/llvm-project/pull/108462 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Emit signpost intervals for progress events (NFC) (PR #108498)

2024-09-13 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. https://github.com/llvm/llvm-project/pull/108498 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] b6bf27e - Avoid expression evaluation in libStdC++ std::vector synthetic children provider (#108414)

2024-09-13 Thread via lldb-commits
Author: jeffreytan81 Date: 2024-09-13T10:26:01-07:00 New Revision: b6bf27ef3c179eefd805f39aa681705fc980ceed URL: https://github.com/llvm/llvm-project/commit/b6bf27ef3c179eefd805f39aa681705fc980ceed DIFF: https://github.com/llvm/llvm-project/commit/b6bf27ef3c179eefd805f39aa681705fc980ceed.diff

[Lldb-commits] [lldb] Avoid expression evaluation in libStdC++ std::vector synthetic children provider (PR #108414)

2024-09-13 Thread via lldb-commits
https://github.com/jeffreytan81 closed https://github.com/llvm/llvm-project/pull/108414 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 0351dc5 - [lldb] Do not use LC_FUNCTION_STARTS data to determine symbol size as symbols are created (#106791)

2024-09-13 Thread via lldb-commits
Author: Alex Langford Date: 2024-09-13T10:33:43-07:00 New Revision: 0351dc522a25df0473a63b414a5bfde5814d3dc3 URL: https://github.com/llvm/llvm-project/commit/0351dc522a25df0473a63b414a5bfde5814d3dc3 DIFF: https://github.com/llvm/llvm-project/commit/0351dc522a25df0473a63b414a5bfde5814d3dc3.diff

[Lldb-commits] [lldb] [lldb] Do not use LC_FUNCTION_STARTS data to determine symbol size as symbols are created (PR #106791)

2024-09-13 Thread Alex Langford via lldb-commits
https://github.com/bulbazord closed https://github.com/llvm/llvm-project/pull/106791 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Removed gdbserver ports map from lldb-server (PR #104238)

2024-09-13 Thread Dmitry Vasilyev via lldb-commits
slydiman wrote: > I do want it. I don't think it's necessary to transfer the type of the > socket, as that can be determined by inspecting the socket FD > (getsockopt(SO_DOMAIN/SO_PROTOCOL)). Oh, I expected this. We can determine non-tcp by missing or 0 gdb port. But it is impossible to separ

[Lldb-commits] [lldb] [lldb] Removed gdbserver ports map from lldb-server (PR #104238)

2024-09-13 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman updated https://github.com/llvm/llvm-project/pull/104238 >From 792cb17f05ded47b152408ac7f4d1de6c986013f Mon Sep 17 00:00:00 2001 From: Dmitry Vasilyev Date: Fri, 6 Sep 2024 16:12:50 +0400 Subject: [PATCH] [lldb] Removed gdbserver ports map from lldb-server Listen to

[Lldb-commits] [lldb] Make env and source map dictionaries #95137 (PR #106919)

2024-09-13 Thread via lldb-commits
https://github.com/Da-Viper updated https://github.com/llvm/llvm-project/pull/106919 >From d2bddca1753b4c960895f51d7eb80b6efa7dc986 Mon Sep 17 00:00:00 2001 From: Ezike Ebuka Date: Sun, 1 Sep 2024 17:26:11 +0100 Subject: [PATCH 1/9] [lldb-dap] Make environment option an object --- .../tools/l

[Lldb-commits] [lldb] [lldb] Emit signpost intervals for progress events (NFC) (PR #108498)

2024-09-13 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/108498 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Remove benchmark API tests (PR #108629)

2024-09-13 Thread Michael Buch via lldb-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/108629 These benchmarks don't get run as part of the regular API test-suite. And I'm not aware of any CI running this. Also, I haven't quite managed to actually run them locally using the `bench.py` script. It look

[Lldb-commits] [lldb] [lldb][test] Remove benchmark API tests (PR #108629)

2024-09-13 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes These benchmarks don't get run as part of the regular API test-suite. And I'm not aware of any CI running this. Also, I haven't quite managed to actually run them locally using the `bench.py` script. It lo

[Lldb-commits] [lldb] [lldb][test] Remove benchmark API tests (PR #108629)

2024-09-13 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. Looks like a nice thing to have conceptually, but if it's not maintained and not functional ... https://github.com/llvm/llvm-project/pull/108629 ___ lldb-commits mailing list lldb-commits@li

[Lldb-commits] [lldb] [lldb][test] Remove benchmark API tests (PR #108629)

2024-09-13 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. Unless someone steps up to maintain these tests I'm fine with removing them. https://github.com/llvm/llvm-project/pull/108629 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://

[Lldb-commits] [lldb] [lldb] Introduce an always-on system log category/channel (PR #108495)

2024-09-13 Thread Adrian Prantl via lldb-commits
@@ -31,6 +31,22 @@ class ProcessInstanceInfo; class ProcessInstanceInfoMatch; typedef std::vector ProcessInstanceInfoList; +// Always on system log category and channel. adrian-prantl wrote: I think we should have a comment that explains what this channel is

[Lldb-commits] [lldb] [lldb] Removed gdbserver ports map from lldb-server (PR #104238)

2024-09-13 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman updated https://github.com/llvm/llvm-project/pull/104238 >From 792cb17f05ded47b152408ac7f4d1de6c986013f Mon Sep 17 00:00:00 2001 From: Dmitry Vasilyev Date: Fri, 6 Sep 2024 16:12:50 +0400 Subject: [PATCH 1/2] [lldb] Removed gdbserver ports map from lldb-server Liste

[Lldb-commits] [lldb] [llvm] [lldb] Change lldb's breakpoint detection behavior [WIP] (PR #105594)

2024-09-13 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: (1) the armv7/aarch32 step-by-breakpoint fix for lldb-server is merged on github main. (2) the change to ProcessGDBRemote to recognize "swbreak" and "hwbreak" as a breakpoint is merged on github main. (3) lldb with this patch works fine with the existing debugserver on arm

[Lldb-commits] [lldb] [lldb] [debugserver] Use "full" x86_64 GPR state when available. (PR #108663)

2024-09-13 Thread Brendan Shanks via lldb-commits
https://github.com/mrpippy created https://github.com/llvm/llvm-project/pull/108663 macOS 10.15 added a "full" x86_64 GPR thread state flavor, equivalent to the normal one but with DS, ES, SS, and GSbase added. This flavor can only be used with processes that install a custom LDT (functionalit

[Lldb-commits] [lldb] [lldb] [debugserver] Use "full" x86_64 GPR state when available. (PR #108663)

2024-09-13 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Brendan Shanks (mrpippy) Changes macOS 10.15 added a "full" x86_64 GPR thread state flavor, equivalent to the normal one but with DS, ES, SS, and GSbase added. This flavor can only be used with processes that install a custom LDT (function

[Lldb-commits] [lldb] [lldb] [debugserver] Use "full" x86_64 GPR state when available. (PR #108663)

2024-09-13 Thread via lldb-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[Lldb-commits] [lldb] [lldb] [debugserver] Use "full" x86_64 GPR state when available. (PR #108663)

2024-09-13 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff b74e7792194d9a8a9ef32c7dc1ffcd205b299336 4453801c7d8abf7a6adfb7fae57ad9fa9d52a0c4 --e