[Lldb-commits] [lldb] [lldb][AIX] Added Ptrace extensions for AIX (PR #108000)

labath wrote: > > Given [#108000 > > (comment)](https://github.com/llvm/llvm-project/pull/108000#discussion_r1752296507), > > my feeling is that this file just should not (need not) exist. For now, > > I'd suggest moving the header into NativeProcessAIX (that's the only place > > which uses i

[Lldb-commits] [lldb] [LLDB] Fix operators <= and >= returning a wrong result when comparing to a floating point NaN (PR #108060)

https://github.com/labath commented: The change looks great, but I'd like to reduce the duplication. Could you create a single comparison function (`Compare`, like `APFloat` has) and have the individual operators call that? Maybe the function could even return APFloat::cmpResult? (Basically t

[Lldb-commits] [lldb] [llvm] [lldb]Implement LLDB Telemetry (PR #98528)

@@ -754,6 +760,7 @@ class Debugger : public std::enable_shared_from_this, uint32_t m_interrupt_requested = 0; ///< Tracks interrupt requests std::mutex m_interrupt_mutex; + std::shared_ptr m_telemeter; labath wrote: Yes, please. If the pointer is non-nu

[Lldb-commits] [lldb] [lldb][test] Add test for no_unique_address when mixed with bitfields (PR #108155)

https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/108155 This is the root-cause for the LLDB failures that started occurring after https://github.com/llvm/llvm-project/pull/105865. The DWARFASTParserClang has logic to try derive unnamed bitfields from DWARF offse

[Lldb-commits] [lldb] [lldb][test] Add test for no_unique_address when mixed with bitfields (PR #108155)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes This is the root-cause for the LLDB failures that started occurring after https://github.com/llvm/llvm-project/pull/105865. The DWARFASTParserClang has logic to try derive unnamed bitfields from DWARF off

[Lldb-commits] [lldb] [lldb][lldb-dap] Added readMemory and WriteMemory, var type correction (PR #108036)

https://github.com/labath edited https://github.com/llvm/llvm-project/pull/108036 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][lldb-dap] Added readMemory and WriteMemory, var type correction (PR #108036)

https://github.com/labath commented: Looks fairly straight forward, but it needs a test case. https://github.com/llvm/llvm-project/pull/108036 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lld

[Lldb-commits] [lldb] [lldb][lldb-dap] Added readMemory and WriteMemory, var type correction (PR #108036)

@@ -4332,6 +4339,232 @@ void request_setInstructionBreakpoints(const llvm::json::Object &request) { g_dap.SendJSON(llvm::json::Value(std::move(response))); } +// "ReadMemoryRequest": { +// "allOf": [ { "$ref": "#/definitions/Request" }, { +// "type": "object", +//

[Lldb-commits] [lldb] [lldb][lldb-dap] Added readMemory and WriteMemory, var type correction (PR #108036)

@@ -4332,6 +4339,232 @@ void request_setInstructionBreakpoints(const llvm::json::Object &request) { g_dap.SendJSON(llvm::json::Value(std::move(response))); } +// "ReadMemoryRequest": { +// "allOf": [ { "$ref": "#/definitions/Request" }, { +// "type": "object", +//

[Lldb-commits] [lldb] [lldb][test] Add test for no_unique_address when mixed with bitfields (PR #108155)

https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/108155 >From ab898a3e176d0366fc15f6aad4b627d6e999753d Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Wed, 11 Sep 2024 01:15:21 +0100 Subject: [PATCH 1/2] [lldb][test] Add test for no_unique_address when mixed wi

[Lldb-commits] [lldb] [lldb][test] Add test for no_unique_address when mixed with bitfields (PR #108155)

https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/108155 >From ab898a3e176d0366fc15f6aad4b627d6e999753d Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Wed, 11 Sep 2024 01:15:21 +0100 Subject: [PATCH 1/3] [lldb][test] Add test for no_unique_address when mixed wi

[Lldb-commits] [lldb] 19f604e - [lldb][test] Add test for printing std::string through expression evaluator

Author: Michael Buch Date: 2024-09-11T08:58:03+01:00 New Revision: 19f604edfc015b35999b3b95e94f18389e4b392d URL: https://github.com/llvm/llvm-project/commit/19f604edfc015b35999b3b95e94f18389e4b392d DIFF: https://github.com/llvm/llvm-project/commit/19f604edfc015b35999b3b95e94f18389e4b392d.diff

[Lldb-commits] [lldb] WoA HW Break and Watchpoint support in LLDB (PR #108072)

https://github.com/labath edited https://github.com/llvm/llvm-project/pull/108072 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] WoA HW Break and Watchpoint support in LLDB (PR #108072)

@@ -178,9 +178,41 @@ Status NativeThreadWindows::RemoveWatchpoint(lldb::addr_t addr) { Status NativeThreadWindows::SetHardwareBreakpoint(lldb::addr_t addr, size_t size) { +#if defined(__aarch64__) || defined(_M_ARM64)

[Lldb-commits] [lldb] WoA HW Break and Watchpoint support in LLDB (PR #108072)

https://github.com/labath commented: Seems ok to me. If I had to guess, I'd say that the initial stop problem is due to us stopping the process "too early" (i.e., in a state where it's not yet fully initialized and ready to accept debugger commands). Maybe there's a different way to stop the

[Lldb-commits] [lldb] [lldb][test] Add test for no_unique_address when mixed with bitfields (PR #108155)

https://github.com/labath approved this pull request. The test will fail on windows because no_unique_address is not a thing there: ``` $ bin/clang++ -c --target=x86_64-pc-windows -gdwarf -o /tmp/a.out /tmp/a.cc /tmp/a.cc:23:5: warning: unknown attribute 'no_unique_address' ignored [-Wunknown-at

[Lldb-commits] [lldb] [lldb][test] TestDataFormatterLibcxxStringSimulator.py: add new padding layout (PR #108169)

https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/108169 Adds new layout for https://github.com/llvm/llvm-project/pull/105865 >From fd093d23400fc48b013cafceafc009fcb5f2142c Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Wed, 11 Sep 2024 09:32:13 +0100 Subject:

[Lldb-commits] [lldb] [lldb][test] TestDataFormatterLibcxxStringSimulator.py: add new padding layout (PR #108169)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 19f604edfc015b35999b3b95e94f18389e4b392d fd093d23400fc48b013cafceafc009fcb5f2142c --e

[Lldb-commits] [lldb] [lldb][Windows] WoA HW Break and Watchpoint support in LLDB (PR #108072)

https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/108072 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Only send "posix" error codes through the gdb-remote protocol (PR #108170)

https://github.com/labath created https://github.com/llvm/llvm-project/pull/108170 The other side has no way of telling which namespace do these codes belong to, so mashing them all together is not very helpful. I'm mainly doing this to simplify some code in a pending patch

[Lldb-commits] [lldb] [lldb] Only send "posix" error codes through the gdb-remote protocol (PR #108170)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes The other side has no way of telling which namespace do these codes belong to, so mashing them all together is not very helpful. I'm mainly doing this to simplify some code in a pending patch

[Lldb-commits] [lldb] [lldb][Windows] WoA HW Break and Watchpoint support in LLDB (PR #108072)

@@ -491,24 +491,47 @@ NativeProcessWindows::OnDebugException(bool first_chance, return ExceptionResult::MaskException; } case DWORD(STATUS_BREAKPOINT): - case STATUS_WX86_BREAKPOINT: -if (FindSoftwareBreakpoint(record.GetExceptionAddress())) { - LLDB_LOG(log,

[Lldb-commits] [lldb] [lldb][Windows] WoA HW Break and Watchpoint support in LLDB (PR #108072)

@@ -143,8 +142,14 @@ NativeRegisterContextWindows::CreateHostNativeRegisterContextWindows( NativeRegisterContextWindows_arm64::NativeRegisterContextWindows_arm64( const ArchSpec &target_arch, NativeThreadProtocol &native_thread) -: NativeRegisterContextWindows(native_

[Lldb-commits] [lldb] [lldb][Windows] WoA HW Break and Watchpoint support in LLDB (PR #108072)

@@ -143,8 +142,14 @@ NativeRegisterContextWindows::CreateHostNativeRegisterContextWindows( NativeRegisterContextWindows_arm64::NativeRegisterContextWindows_arm64( const ArchSpec &target_arch, NativeThreadProtocol &native_thread) -: NativeRegisterContextWindows(native_

[Lldb-commits] [lldb] [lldb][Windows] WoA HW Break and Watchpoint support in LLDB (PR #108072)

https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/108072 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Windows] WoA HW Break and Watchpoint support in LLDB (PR #108072)

DavidSpickett wrote: Remind me, does lldb support hardware breakpoints for x86 right now either? From the content of this PR, I assume it does not. (which is fine, I'm just trying to be clear what our starting point is) https://github.com/llvm/llvm-project/pull/108072 _

[Lldb-commits] [lldb] [lldb][AArch64][Linux] Add Floating Point Mode Register (PR #106695)

DavidSpickett wrote: ping! I should also note that all required changes are in the kernel, but not in firmware. I have used a WIP firmware patch that the kernel contributor also used, to develop this. So there is a tiny chance that there would be changes later when official firmware support i

[Lldb-commits] [lldb] [lldb][Windows] WoA HW Break and Watchpoint support in LLDB (PR #108072)

DavidSpickett wrote: Relates to https://github.com/llvm/llvm-project/issues/80665 https://github.com/llvm/llvm-project/pull/108072 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Only send "posix" error codes through the gdb-remote protocol (PR #108170)

DavidSpickett wrote: Does this impact https://github.com/llvm/llvm-project/pull/106950 at all? https://github.com/llvm/llvm-project/pull/108170 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/ll

[Lldb-commits] [lldb] [lldb] Change the implementation of Status to store an llvm::Error (NFC) (PR #106774)

@@ -181,29 +226,68 @@ const char *Status::AsCString(const char *default_error_str) const { // Clear the error and any cached error string that it might contain. void Status::Clear() { - m_code = 0; - m_type = eErrorTypeInvalid; - m_string.clear(); + if (m_error) +LLDB

[Lldb-commits] [lldb] [lldb] Change the implementation of Status to store an llvm::Error (NFC) (PR #106774)

https://github.com/labath edited https://github.com/llvm/llvm-project/pull/106774 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Change the implementation of Status to store an llvm::Error (NFC) (PR #106774)

@@ -174,33 +233,91 @@ const char *Status::AsCString(const char *default_error_str) const { // Clear the error and any cached error string that it might contain. void Status::Clear() { - m_code = 0; - m_type = eErrorTypeInvalid; - m_string.clear(); + if (m_error) +LLDB

[Lldb-commits] [lldb] [lldb] Change the implementation of Status to store an llvm::Error (NFC) (PR #106774)

@@ -181,29 +241,61 @@ const char *Status::AsCString(const char *default_error_str) const { // Clear the error and any cached error string that it might contain. void Status::Clear() { - m_code = 0; - m_type = eErrorTypeInvalid; - m_string.clear(); + if (m_error) +LLDB

[Lldb-commits] [lldb] [lldb] Change the implementation of Status to store an llvm::Error (NFC) (PR #106774)

@@ -174,33 +233,91 @@ const char *Status::AsCString(const char *default_error_str) const { // Clear the error and any cached error string that it might contain. void Status::Clear() { - m_code = 0; - m_type = eErrorTypeInvalid; - m_string.clear(); + if (m_error) +LLDB

[Lldb-commits] [lldb] [lldb] Change the implementation of Status to store an llvm::Error (NFC) (PR #106774)

@@ -94,26 +123,49 @@ Status Status::FromErrorStringWithFormat(const char *format, ...) { return Status(string); } -Status Status::FromError(llvm::Error error) { return Status(std::move(error)); } +Status Status::FromExpressionError(lldb::ExpressionResults result, +

[Lldb-commits] [lldb] [lldb] Change the implementation of Status to store an llvm::Error (NFC) (PR #106774)

https://github.com/labath commented: > Status is already extensively unittested. The fact that you were able to pull this switch off without changing a single line of test code tells me otherwise. Surely there is *some* new functionality being added here. > Is there something you feel is mi

[Lldb-commits] [lldb] [lldb] Change the implementation of Status to store an llvm::Error (NFC) (PR #106774)

labath wrote: Overall, this looks pretty good, but I'm suspicious of the Python change as PyErr_Fetch should already return an owned reference. https://github.com/llvm/llvm-project/pull/106774 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] [lldb][Windows] WoA HW Break and Watchpoint support in LLDB (PR #108072)

@@ -178,9 +178,41 @@ Status NativeThreadWindows::RemoveWatchpoint(lldb::addr_t addr) { Status NativeThreadWindows::SetHardwareBreakpoint(lldb::addr_t addr, size_t size) { +#if defined(__aarch64__) || defined(_M_ARM64)

[Lldb-commits] [lldb] [lldb][Windows] WoA HW Break and Watchpoint support in LLDB (PR #108072)

@@ -491,24 +491,47 @@ NativeProcessWindows::OnDebugException(bool first_chance, return ExceptionResult::MaskException; } case DWORD(STATUS_BREAKPOINT): - case STATUS_WX86_BREAKPOINT: -if (FindSoftwareBreakpoint(record.GetExceptionAddress())) { - LLDB_LOG(log,

[Lldb-commits] [lldb] [lldb][Windows] WoA HW Break and Watchpoint support in LLDB (PR #108072)

@@ -143,8 +142,14 @@ NativeRegisterContextWindows::CreateHostNativeRegisterContextWindows( NativeRegisterContextWindows_arm64::NativeRegisterContextWindows_arm64( const ArchSpec &target_arch, NativeThreadProtocol &native_thread) -: NativeRegisterContextWindows(native_

[Lldb-commits] [lldb] [lldb][Windows] WoA HW Break and Watchpoint support in LLDB (PR #108072)

omjavaid wrote: > Remind me, does lldb support hardware breakpoints for x86 right now either? > From the content of this PR, I assume it does not. > > (which is fine, I'm just trying to be clear what our starting point is) yes x86_64 windows does not support hardware breakpoints. However it doe

[Lldb-commits] [lldb] [lldb][test] Add test for no_unique_address when mixed with bitfields (PR #108155)

frederick-vs-ja wrote: > The test will fail on windows because no_unique_address is not a thing there: Seems like that we should spell it as `[[msvc::no_unique_address]]` on Windows. Is there already such a macro in lldb/test covering this? https://github.com/llvm/llvm-project/pull/108155

[Lldb-commits] [lldb] [lldb][Windows] WoA HW Break and Watchpoint support in LLDB (PR #108072)

https://github.com/omjavaid edited https://github.com/llvm/llvm-project/pull/108072 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Windows] WoA HW Break and Watchpoint support in LLDB (PR #108072)

omjavaid wrote: > Seems ok to me. > > If I had to guess, I'd say that the initial stop problem is due to us > stopping the process "too early" (i.e., in a state where it's not yet fully > initialized and ready to accept debugger commands). Maybe there's a different > way to stop the process a

[Lldb-commits] [lldb] [lldb][Windows] WoA HW Break and Watchpoint support in LLDB (PR #108072)

@@ -143,8 +142,14 @@ NativeRegisterContextWindows::CreateHostNativeRegisterContextWindows( NativeRegisterContextWindows_arm64::NativeRegisterContextWindows_arm64( const ArchSpec &target_arch, NativeThreadProtocol &native_thread) -: NativeRegisterContextWindows(native_

[Lldb-commits] [lldb] [lldb][test] Add test for no_unique_address when mixed with bitfields (PR #108155)

https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/108155 >From ab898a3e176d0366fc15f6aad4b627d6e999753d Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Wed, 11 Sep 2024 01:15:21 +0100 Subject: [PATCH 1/4] [lldb][test] Add test for no_unique_address when mixed wi

[Lldb-commits] [lldb] [lldb][test] Add test for no_unique_address when mixed with bitfields (PR #108155)

Michael137 wrote: > > The test will fail on windows because no_unique_address is not a thing > > there: > > Seems like that we should spell it as `[[msvc::no_unique_address]]` on > Windows. Is there already such a macro in lldb/test covering this? Don't think we have coverage for the `[[msvc:

[Lldb-commits] [clang] [lldb] [llvm] Test branch1 (PR #108178)

github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[Lldb-commits] [clang] [lldb] [llvm] Test branch1 (PR #108178)

llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-llvm-binary-utilities Author: None (Lakshmi-Surekha) Changes --- Patch is 388.71 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/108178.diff 129 Files Affected: - (modified) cla

[Lldb-commits] [clang] [lldb] [llvm] Test branch1 (PR #108178)

https://github.com/Lakshmi-Surekha closed https://github.com/llvm/llvm-project/pull/108178 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [llvm] Test branch1 (PR #108178)

https://github.com/Lakshmi-Surekha reopened https://github.com/llvm/llvm-project/pull/108178 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [llvm] Test branch1 (PR #108178)

https://github.com/Lakshmi-Surekha closed https://github.com/llvm/llvm-project/pull/108178 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Only send "posix" error codes through the gdb-remote protocol (PR #108170)

labath wrote: > Does this impact #106950 at all? It's related to it in the sense that the error codes we're sending are rubish, but it doesn't really "impact" it because the "host IO" packets use a different response format (`Fxx,yy`) vs (`Exx`). If we wanted to assign meaning to these errors

[Lldb-commits] [lldb] [lldb] gdb rsp file error pass fix (PR #106950)

@@ -3064,22 +3064,41 @@ static int gdb_errno_to_system(int err) { static uint64_t ParseHostIOPacketResponse(StringExtractorGDBRemote &response, uint64_t fail_result, Status &error) { + // The packet is expected to have the following

[Lldb-commits] [lldb] [lldb][Windows] WoA HW Break and Watchpoint support in LLDB (PR #108072)

@@ -143,8 +142,14 @@ NativeRegisterContextWindows::CreateHostNativeRegisterContextWindows( NativeRegisterContextWindows_arm64::NativeRegisterContextWindows_arm64( const ArchSpec &target_arch, NativeThreadProtocol &native_thread) -: NativeRegisterContextWindows(native_

[Lldb-commits] [lldb] [lldb][test] Handle failure to get /proc/cpuinfo from a remote Linux platform (PR #108183)

https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/108183 I've been testing against qemu-aarch64 using the qemu-user platform, which doesn't support get-file: ``` AssertionError: False is not true : Command 'platform get-file "/proc/cpuinfo" <...>/TestAArch64Lin

[Lldb-commits] [lldb] [lldb][test] Handle failure to get /proc/cpuinfo from a remote Linux platform (PR #108183)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) Changes I've been testing against qemu-aarch64 using the qemu-user platform, which doesn't support get-file: ``` AssertionError: False is not true : Command 'platform get-file "/proc/cpuinfo" <...>/TestAArch6

[Lldb-commits] [lldb] [lldb][test] Handle failure to get /proc/cpuinfo from a remote Linux platform (PR #108183)

DavidSpickett wrote: Note that this is not part of a big push to get the test suite working this way, it's because I've been working on qemu compatibility as part of https://github.com/llvm/llvm-project/issues/87471 and need to sanity check my changes somehow. https://github.com/llvm/llvm-pro

[Lldb-commits] [lldb] [lldb][test] Handle failure to get /proc/cpuinfo from a remote Linux platform (PR #108183)

DavidSpickett wrote: If anyone wants to actually get the features we'll either have to delay checks until there is an actual process, or find a command line to qemu to dump out the features in equivalent form. But either way - not something I'm going to do myself. https://github.com/llvm/llvm

[Lldb-commits] [lldb] [lldb][Windows] WoA HW Break and Watchpoint support in LLDB (PR #108072)

@@ -143,8 +142,14 @@ NativeRegisterContextWindows::CreateHostNativeRegisterContextWindows( NativeRegisterContextWindows_arm64::NativeRegisterContextWindows_arm64( const ArchSpec &target_arch, NativeThreadProtocol &native_thread) -: NativeRegisterContextWindows(native_

[Lldb-commits] [lldb] [lldb][Windows] WoA HW Break and Watchpoint support in LLDB (PR #108072)

@@ -143,8 +142,14 @@ NativeRegisterContextWindows::CreateHostNativeRegisterContextWindows( NativeRegisterContextWindows_arm64::NativeRegisterContextWindows_arm64( const ArchSpec &target_arch, NativeThreadProtocol &native_thread) -: NativeRegisterContextWindows(native_

[Lldb-commits] [lldb] da69449 - [lldb][test] Add test for no_unique_address when mixed with bitfields (#108155)

Author: Michael Buch Date: 2024-09-11T11:36:27+01:00 New Revision: da6944912baffa430468078c38f65d55fb83dd43 URL: https://github.com/llvm/llvm-project/commit/da6944912baffa430468078c38f65d55fb83dd43 DIFF: https://github.com/llvm/llvm-project/commit/da6944912baffa430468078c38f65d55fb83dd43.diff

[Lldb-commits] [lldb] [lldb][test] Add test for no_unique_address when mixed with bitfields (PR #108155)

https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/108155 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AIX] Added Ptrace extensions for AIX (PR #108000)

DhruvSrivastavaX wrote: > You can do that as a temporary fix so that we can move on to dealing with > other Host functionality. In the longer run I'll still most likely want to > get rid of those constants by doing something like I described in that > comment. Yes, agreed. If we do not need b

[Lldb-commits] [lldb] [lldb] Add a MainLoop version of DomainSocket::Accept (PR #108188)

https://github.com/labath created https://github.com/llvm/llvm-project/pull/108188 To go along with the existing TCPSocket implementation. >From eb9799b9a1631e34b9553386ce968fd5379378fc Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Wed, 11 Sep 2024 12:55:09 +0200 Subject: [PATCH] [lldb] Ad

[Lldb-commits] [lldb] [lldb] Add a MainLoop version of DomainSocket::Accept (PR #108188)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes To go along with the existing TCPSocket implementation. --- Full diff: https://github.com/llvm/llvm-project/pull/108188.diff 9 Files Affected: - (modified) lldb/include/lldb/Host/Socket.h (+12-1) - (modifie

[Lldb-commits] [lldb] [lldb] Add a MainLoop version of DomainSocket::Accept (PR #108188)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 1e3a24d2e4eb63c17b962161ae6588d1b2c178f8 eb9799b9a1631e34b9553386ce968fd5379378fc --e

[Lldb-commits] [lldb] [lldb] Add a MainLoop version of DomainSocket::Accept (PR #108188)

https://github.com/labath updated https://github.com/llvm/llvm-project/pull/108188 >From eb9799b9a1631e34b9553386ce968fd5379378fc Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Wed, 11 Sep 2024 12:55:09 +0200 Subject: [PATCH 1/2] [lldb] Add a MainLoop version of DomainSocket::Accept To go a

[Lldb-commits] [lldb] [lldb] Add a MainLoop version of DomainSocket::Accept (PR #108188)

https://github.com/slydiman edited https://github.com/llvm/llvm-project/pull/108188 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add a MainLoop version of DomainSocket::Accept (PR #108188)

@@ -85,6 +85,43 @@ TEST_P(SocketTest, DomainListenConnectAccept) { std::unique_ptr socket_b_up; CreateDomainConnectedSockets(Path, &socket_a_up, &socket_b_up); } + +TEST_P(SocketTest, DomainMainLoopAccept) { slydiman wrote: Add `#if LLDB_ENABLE_POSIX`. Oth

[Lldb-commits] [lldb] [lldb] Add a MainLoop version of DomainSocket::Accept (PR #108188)

https://github.com/slydiman approved this pull request. LGTM, but fix the test please. https://github.com/llvm/llvm-project/pull/108188 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commi

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang][NFC] Factor out unnamed bitfield creation into helper (PR #108196)

https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/108196 This logic will need adjusting soon for https://github.com/llvm/llvm-project/pull/108155 This patch pulls out the logic for detecting/creating unnamed bitfields out of `ParseSingleMember` to make the latter

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang][NFC] Factor out unnamed bitfield creation into helper (PR #108196)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes This logic will need adjusting soon for https://github.com/llvm/llvm-project/pull/108155 This patch pulls out the logic for detecting/creating unnamed bitfields out of `ParseSingleMember` to make the latt

[Lldb-commits] [lldb] [lldb][test] TestDataFormatterLibcxxStringSimulator.py: add new padding layout (PR #108169)

https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/108169 >From fd093d23400fc48b013cafceafc009fcb5f2142c Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Wed, 11 Sep 2024 09:32:13 +0100 Subject: [PATCH 1/2] [lldb][test] TestDataFormatterLibcxxStringSimulator.py: a

[Lldb-commits] [lldb] [lldb][test] TestDataFormatterLibcxxStringSimulator.py: add new padding layout (PR #108169)

Michael137 wrote: Test currently expectedly fails on CI https://github.com/llvm/llvm-project/pull/108169 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Windows] WoA HW Break and Watchpoint support in LLDB (PR #108072)

@@ -143,8 +142,14 @@ NativeRegisterContextWindows::CreateHostNativeRegisterContextWindows( NativeRegisterContextWindows_arm64::NativeRegisterContextWindows_arm64( const ArchSpec &target_arch, NativeThreadProtocol &native_thread) -: NativeRegisterContextWindows(native_

[Lldb-commits] [lldb] [lldb][Windows] WoA HW Break and Watchpoint support in LLDB (PR #108072)

DavidSpickett wrote: > Yes I think there might be a Windows API launch flag that can let us do early > detection of hardware breakpoints and watchpoints. But so far after lots of > experimentation I have not been able to find the right set. Is it possible this is a bug in Windows itself? Thoug

[Lldb-commits] [lldb] [lldb][test] Toolchain detection rewrite in Python (PR #102185)

@@ -96,16 +98,120 @@ def getArchSpec(self, architecture): """ return ["ARCH=" + architecture] if architecture else [] -def getCCSpec(self, compiler): +def getToolchainSpec(self, compiler): """ -Helper function to return the key-value st

[Lldb-commits] [lldb] [lldb][test] Toolchain detection rewrite in Python (PR #102185)

https://github.com/dzhidzhoev updated https://github.com/llvm/llvm-project/pull/102185 >From b3fb433811a0f072823f03de7814cbc574c18dec Mon Sep 17 00:00:00 2001 From: Vladislav Dzhidzhoev Date: Sat, 27 Jul 2024 02:39:32 +0200 Subject: [PATCH 01/15] [lldb][test] Improve toolchain detection in Mak

[Lldb-commits] [lldb] [lldb][test] Toolchain detection rewrite in Python (PR #102185)

@@ -96,17 +98,105 @@ def getArchSpec(self, architecture): """ return ["ARCH=" + architecture] if architecture else [] -def getCCSpec(self, compiler): +def getToolchainSpec(self, compiler): """ -Helper function to return the key-value st

[Lldb-commits] [lldb] [lldb][test] Toolchain detection rewrite in Python (PR #102185)

https://github.com/dzhidzhoev closed https://github.com/llvm/llvm-project/pull/102185 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 44fc987 - [lldb][test] Toolchain detection rewrite in Python (#102185)

Author: Vladislav Dzhidzhoev Date: 2024-09-11T16:04:01+03:00 New Revision: 44fc987ed174e32544a577387ab0df6886495e82 URL: https://github.com/llvm/llvm-project/commit/44fc987ed174e32544a577387ab0df6886495e82 DIFF: https://github.com/llvm/llvm-project/commit/44fc987ed174e32544a577387ab0df6886495e8

[Lldb-commits] [lldb] [lldb] Deflake TestDAP_attach (PR #108226)

https://github.com/labath created https://github.com/llvm/llvm-project/pull/108226 The test failed in due to frame variable not being in stop commands, even though the DAP log shows the command being present there. I'm pretty sure this

[Lldb-commits] [lldb] [lldb] Deflake TestDAP_attach (PR #108226)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes The test failed in ; due to frame variable not being in stop commands, even though the DAP log shows the command being present there. I'm pretty sure t

[Lldb-commits] [lldb] [lldb] Make sure TestDAP_subtleFrames actually uses libc++ (PR #108227)

https://github.com/labath created https://github.com/llvm/llvm-project/pull/108227 Without this, the binary would still be built with libstdc++, if that's the system/compiler default. >From 2cd17c367db099e59497f1050f9bb07ce2a6d269 Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Wed, 11 Sep

[Lldb-commits] [lldb] [lldb] Make sure TestDAP_subtleFrames actually uses libc++ (PR #108227)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes Without this, the binary would still be built with libstdc++, if that's the system/compiler default. --- Full diff: https://github.com/llvm/llvm-project/pull/108227.diff 1 Files Affected: - (modified) lldb/

[Lldb-commits] [lldb] [lldb] Deflake TestDAP_attach (PR #108226)

https://github.com/DavidSpickett approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/108226 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Print a warning on checksum mismatch (PR #107968)

https://github.com/medismailben approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/107968 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Print a warning on checksum mismatch (PR #107968)

https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/107968 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] ffa2f53 - [lldb] Print a warning on checksum mismatch (#107968)

Author: Jonas Devlieghere Date: 2024-09-11T08:53:07-07:00 New Revision: ffa2f539ae2a4e79c01b3d54f8b12c63d8781a0c URL: https://github.com/llvm/llvm-project/commit/ffa2f539ae2a4e79c01b3d54f8b12c63d8781a0c DIFF: https://github.com/llvm/llvm-project/commit/ffa2f539ae2a4e79c01b3d54f8b12c63d8781a0c.d

[Lldb-commits] [lldb] [lldb] Print a warning on checksum mismatch (PR #107968)

https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/107968 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Make sure TestDAP_subtleFrames actually uses libc++ (PR #108227)

https://github.com/Michael137 approved this pull request. https://github.com/llvm/llvm-project/pull/108227 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [compiler-rt] [libcxx] [lldb] [llvm] Rename Sanitizer Coverage => Coverage Sanitizer (PR #106505)

cor3ntin wrote: ping! https://github.com/llvm/llvm-project/pull/106505 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang][NFC] Factor out unnamed bitfield creation into helper (PR #108196)

https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/108196 >From 0484639d79dc79eba39d203a35487a0cc1064caa Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Wed, 11 Sep 2024 12:15:02 +0100 Subject: [PATCH 1/3] [lldb][DWARFASTParserClang][NFC] Factor out unnamed bitfi

[Lldb-commits] [lldb] [NFC][LLDB] Remove CommandObjectTraceStartIntelPT.cpp Status Constructor (PR #108248)

https://github.com/Jlalond created https://github.com/llvm/llvm-project/pull/108248 @adrian-prantl from your recent changes I keep encountering issues iwth this file in my build chain. Does this API usage look correct for your new redesign? >From 0b449cc60c33ee8231c7a108511207298fab0403 Mon Se

[Lldb-commits] [lldb] [NFC][LLDB] Remove CommandObjectTraceStartIntelPT.cpp call to protected Status Constructor (PR #108248)

https://github.com/Jlalond edited https://github.com/llvm/llvm-project/pull/108248 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [NFC][LLDB] Remove CommandObjectTraceStartIntelPT.cpp call to protected Status Constructor (PR #108248)

https://github.com/Jlalond edited https://github.com/llvm/llvm-project/pull/108248 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Handle failure to get /proc/cpuinfo from a remote Linux platform (PR #108183)

https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/108183 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [NFC][LLDB] Remove CommandObjectTraceStartIntelPT.cpp call to protected Status Constructor (PR #108248)

https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/108248 >From c13cca79b5b90a858fe32b4ee490189c10fcd7c9 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Wed, 11 Sep 2024 09:46:02 -0700 Subject: [PATCH] Remove CommandObjectTraceStartIntelPT.cpp call to Status() cons

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang][NFC] Factor out unnamed bitfield creation into helper (PR #108196)

https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/108196 >From 0484639d79dc79eba39d203a35487a0cc1064caa Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Wed, 11 Sep 2024 12:15:02 +0100 Subject: [PATCH 1/5] [lldb][DWARFASTParserClang][NFC] Factor out unnamed bitfi

  1   2   >