@@ -96,16 +124,44 @@ Status Status::FromErrorStringWithFormat(const char
*format, ...) {
return Status(string);
}
-llvm::Error Status::ToError() const {
- if (Success())
-return llvm::Error::success();
- if (m_type == ErrorType::eErrorTypePOSIX)
-return llvm::erro
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/106774
>From a597eaa461f5d5b6c88d51341e03a967496b35b8 Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Wed, 4 Sep 2024 12:50:37 -0700
Subject: [PATCH] [lldb] Change the implementation of Status to store an
llv
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/106774
>From d6d55a4d6f806f260e875dc29fdf7481d44fa1b1 Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Wed, 4 Sep 2024 12:50:37 -0700
Subject: [PATCH] [lldb] Change the implementation of Status to store an
llv
@@ -174,33 +233,91 @@ const char *Status::AsCString(const char
*default_error_str) const {
// Clear the error and any cached error string that it might contain.
void Status::Clear() {
- m_code = 0;
- m_type = eErrorTypeInvalid;
- m_string.clear();
+ if (m_error)
+LLDB
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff ba2aa1dcf3e18aa9bd40c7016d7fb500c77959dc
d6d55a4d6f806f260e875dc29fdf7481d44fa1b1 --e
@@ -174,33 +233,91 @@ const char *Status::AsCString(const char
*default_error_str) const {
// Clear the error and any cached error string that it might contain.
void Status::Clear() {
- m_code = 0;
- m_type = eErrorTypeInvalid;
- m_string.clear();
+ if (m_error)
+LLDB
@@ -174,33 +233,91 @@ const char *Status::AsCString(const char
*default_error_str) const {
// Clear the error and any cached error string that it might contain.
void Status::Clear() {
- m_code = 0;
- m_type = eErrorTypeInvalid;
- m_string.clear();
+ if (m_error)
+LLDB
Author: John Harrison
Date: 2024-09-10T12:40:20-07:00
New Revision: 5b4100cc354148a1140546e7f5ac2bf380bc5eff
URL:
https://github.com/llvm/llvm-project/commit/5b4100cc354148a1140546e7f5ac2bf380bc5eff
DIFF:
https://github.com/llvm/llvm-project/commit/5b4100cc354148a1140546e7f5ac2bf380bc5eff.diff
https://github.com/ashgti closed
https://github.com/llvm/llvm-project/pull/105905
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Jlalond wrote:
Investigating the windows issue
https://github.com/llvm/llvm-project/pull/102708
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
adrian-prantl wrote:
> Also, some (unit) tests would be nice.
Status is already extensively unittested. Is there something you feel is
missing?
https://github.com/llvm/llvm-project/pull/106774
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://github.com/Jlalond created
https://github.com/llvm/llvm-project/pull/108079
Follow up to #102708, the tests are failing for windows. There is a large
variance in these tests between summary strings and built in types. I'm
disabling these test for windows, and will add windows specific
https://github.com/Jlalond edited
https://github.com/llvm/llvm-project/pull/108079
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jacob Lalonde (Jlalond)
Changes
Follow up to #102708, the tests are failing for windows. There is a
large variance in these tests between summary strings and built in types. I'm
disabling these test for windows, and will add windows specif
Jlalond wrote:
@Michael137 / @JDevlieghere are we okay disabling these tests for windows? Even
on Linux we encountered significant variance between built in types and summary
strings. We can either land this or I can make the tests Linux specific and add
mac and windows specific tests as a fol
@@ -3801,6 +3801,17 @@ void request_variables(const llvm::json::Object
&request) {
variable_name_counts[GetNonNullVariableName(variable)]++;
}
+// Show return value if there is any ( in the top frame )
+auto process = g_dap.target.GetProcess();
+auto sel
https://github.com/walter-erquinigo requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/106907
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/106919
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1370,13 +1395,16 @@ CreateRunInTerminalReverseRequest(const
llvm::json::Object &launch_request,
if (!cwd.empty())
run_in_terminal_args.try_emplace("cwd", cwd);
- // We need to convert the input list of environments variables into a
- // dictionary
- std::vector e
https://github.com/walter-erquinigo requested changes to this pull request.
Thanks for working on this!
I second all that Pavel said.
https://github.com/llvm/llvm-project/pull/107485
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://l
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/107485
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -60,7 +60,10 @@ def run_test_evaluate_expressions(
# Expressions at breakpoint 1, which is in main
self.assertEvaluate("var1", "20")
+# Empty expression should equate to the previous expression.
walter-erquinigo wrote:
Please add a
https://github.com/dlav-sc updated
https://github.com/llvm/llvm-project/pull/99336
>From 7fe1c5129e37f0eef3a67f8ccd1123e252f064b7 Mon Sep 17 00:00:00 2001
From: Daniil Avdeev
Date: Thu, 11 Jul 2024 11:21:36 +
Subject: [PATCH 1/5] [lldb][RISCV] add jitted function calls to ABI
Function call
https://github.com/Jlalond closed
https://github.com/llvm/llvm-project/pull/108079
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jacob Lalonde
Date: 2024-09-10T15:12:56-07:00
New Revision: 10c04d9873dbbbca26f4d996396da297b9144add
URL:
https://github.com/llvm/llvm-project/commit/10c04d9873dbbbca26f4d996396da297b9144add
DIFF:
https://github.com/llvm/llvm-project/commit/10c04d9873dbbbca26f4d996396da297b9144add.diff
jasonmolenda wrote:
i skimmed the patch, I didn't see anything that concerns me. The fact that we
can't query the number of hardware watchpoints/breakpoints means that this code
will misbehave on other platforms where the numbers are different - we might
have four hardware watchpoints, but yo
https://github.com/jasonmolenda edited
https://github.com/llvm/llvm-project/pull/105594
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/106442
>From d6d55a4d6f806f260e875dc29fdf7481d44fa1b1 Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Wed, 4 Sep 2024 12:50:37 -0700
Subject: [PATCH 1/2] [lldb] Change the implementation of Status to store an
adrian-prantl wrote:
Rebased once more. I think this should address all the high-level comments.
https://github.com/llvm/llvm-project/pull/106442
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/
@@ -0,0 +1,44 @@
+//===-- Ptrace.h *- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
DhruvSrivastavaX wrote:
> Given [#108000
> (comment)](https://github.com/llvm/llvm-project/pull/108000#discussion_r1752296507),
> my feeling is that this file just should not (need not) exist. For now, I'd
> suggest moving the header into NativeProcessAIX (that's the only place which
> uses i
101 - 131 of 131 matches
Mail list logo
