[Lldb-commits] [lldb] [LLDB][Minidump] Support minidumps where there are multiple exception streams (PR #97470)

2024-09-09 Thread Pavel Labath via lldb-commits
@@ -387,10 +399,8 @@ bool ProcessMinidump::DoUpdateThreadList(ThreadList &old_thread_list, LocationDescriptor context_location = thread.Context; // If the minidump contains an exception context, use it -if (m_active_exception != nullptr && -m_active_except

[Lldb-commits] [lldb] [LLDB][Minidump] Support minidumps where there are multiple exception streams (PR #97470)

2024-09-09 Thread Pavel Labath via lldb-commits
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/97470 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][Minidump] Support minidumps where there are multiple exception streams (PR #97470)

2024-09-09 Thread Pavel Labath via lldb-commits
https://github.com/labath commented: Looks good to me. Just a few suggestions. https://github.com/llvm/llvm-project/pull/97470 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][Minidump] Support minidumps where there are multiple exception streams (PR #97470)

2024-09-09 Thread Pavel Labath via lldb-commits
@@ -209,7 +208,23 @@ Status ProcessMinidump::DoLoadCore() { GetTarget().SetArchitecture(arch, true /*set_platform*/); m_thread_list = m_minidump_parser->GetThreads(); - m_active_exception = m_minidump_parser->GetExceptionStream(); + auto exception_stream_it = m_minidump_

[Lldb-commits] [lldb] [LLDB][TableGen] Migrate lldb-tblgen to use const RecordKeeper (PR #107536)

2024-09-09 Thread David Spickett via lldb-commits
DavidSpickett wrote: Great, please add that link to the PR description and then this can land. https://github.com/llvm/llvm-project/pull/107536 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/ll

[Lldb-commits] [clang] [lldb] [ASTImporter][lldb] Avoid implicit imports in VisitFieldDecl (PR #107828)

2024-09-09 Thread Andrew Savonichev via lldb-commits
https://github.com/asavonic created https://github.com/llvm/llvm-project/pull/107828 Fields from external sources are typically loaded implicitly by `RecordDecl` or `DeclContext` iterators and other functions (see LoadFieldsFromExternalStorage function and its uses). The assumption is that we

[Lldb-commits] [clang] [lldb] [ASTImporter][lldb] Avoid implicit imports in VisitFieldDecl (PR #107828)

2024-09-09 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Andrew Savonichev (asavonic) Changes Fields from external sources are typically loaded implicitly by `RecordDecl` or `DeclContext` iterators and other functions (see LoadFieldsFromExternalStorage function and its uses). The assumption is

[Lldb-commits] [clang] [lldb] [ASTImporter][lldb] Avoid implicit imports in VisitFieldDecl (PR #107828)

2024-09-09 Thread Michael Buch via lldb-commits
Michael137 wrote: Thanks for taking a stab at this and for the analysis. You rightly point out that this is the root problem: > If an implicit import happens between (2) and (3), it may indirectly bring > the same field into the context. When (3) happens we add it again, > duplicating the f

[Lldb-commits] [lldb] 345cc47 - [NFC] Add explicit #include llvm-config.h where its macros are used, lldb part. (#107603)

2024-09-09 Thread via lldb-commits
Author: Daniil Fukalov Date: 2024-09-09T12:44:03+02:00 New Revision: 345cc47ba7a28811ae4ec7d113059ccb39c500a3 URL: https://github.com/llvm/llvm-project/commit/345cc47ba7a28811ae4ec7d113059ccb39c500a3 DIFF: https://github.com/llvm/llvm-project/commit/345cc47ba7a28811ae4ec7d113059ccb39c500a3.diff

[Lldb-commits] [lldb] [NFC] Add explicit #include llvm-config.h where its macros are used, lldb part. (PR #107603)

2024-09-09 Thread Daniil Fukalov via lldb-commits
https://github.com/dfukalov closed https://github.com/llvm/llvm-project/pull/107603 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][TableGen] Migrate lldb-tblgen to use const RecordKeeper (PR #107536)

2024-09-09 Thread Rahul Joshi via lldb-commits
https://github.com/jurahul edited https://github.com/llvm/llvm-project/pull/107536 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][TableGen] Migrate lldb-tblgen to use const RecordKeeper (PR #107536)

2024-09-09 Thread Rahul Joshi via lldb-commits
jurahul wrote: Done. https://github.com/llvm/llvm-project/pull/107536 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

2024-09-09 Thread via lldb-commits
https://github.com/dlav-sc updated https://github.com/llvm/llvm-project/pull/99336 >From 7608d0ad88a74faf502429e32bd967a959bd42a5 Mon Sep 17 00:00:00 2001 From: Daniil Avdeev Date: Thu, 11 Jul 2024 11:21:36 + Subject: [PATCH 1/6] [lldb][RISCV] add jitted function calls to ABI Function call

[Lldb-commits] [lldb] [LLDB][TableGen] Migrate lldb-tblgen to use const RecordKeeper (PR #107536)

2024-09-09 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. https://github.com/llvm/llvm-project/pull/107536 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 32cef07 - [LLDB][TableGen] Migrate lldb-tblgen to use const RecordKeeper (#107536)

2024-09-09 Thread via lldb-commits
Author: Rahul Joshi Date: 2024-09-09T13:27:38+01:00 New Revision: 32cef07885e112d05bc2b1c285f40e353d80e18f URL: https://github.com/llvm/llvm-project/commit/32cef07885e112d05bc2b1c285f40e353d80e18f DIFF: https://github.com/llvm/llvm-project/commit/32cef07885e112d05bc2b1c285f40e353d80e18f.diff L

[Lldb-commits] [lldb] [LLDB][TableGen] Migrate lldb-tblgen to use const RecordKeeper (PR #107536)

2024-09-09 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/107536 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [ASTImporter][lldb] Avoid implicit imports in VisitFieldDecl (PR #107828)

2024-09-09 Thread Andrew Savonichev via lldb-commits
asavonic wrote: Thanks Michael, I'm glad I'm not the only one seeing this problem. > > If an implicit import happens between (2) and (3), it may indirectly bring > > the same field into the context. When (3) happens we add it again, > > duplicating the field and breaking the record. This is no

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

2024-09-09 Thread via lldb-commits
https://github.com/dlav-sc updated https://github.com/llvm/llvm-project/pull/99336 >From 7608d0ad88a74faf502429e32bd967a959bd42a5 Mon Sep 17 00:00:00 2001 From: Daniil Avdeev Date: Thu, 11 Jul 2024 11:21:36 + Subject: [PATCH 1/6] [lldb][RISCV] add jitted function calls to ABI Function call

[Lldb-commits] [lldb] [lldb] gdb rsp file error pass fix (PR #106950)

2024-09-09 Thread via lldb-commits
@@ -3064,22 +3064,41 @@ static int gdb_errno_to_system(int err) { static uint64_t ParseHostIOPacketResponse(StringExtractorGDBRemote &response, uint64_t fail_result, Status &error) { + // The packet is expected to have the following

[Lldb-commits] [lldb] [lldb][test] Improve toolchain detection in Makefile.rules (PR #102185)

2024-09-09 Thread Vladislav Dzhidzhoev via lldb-commits
https://github.com/dzhidzhoev updated https://github.com/llvm/llvm-project/pull/102185 >From b3fb433811a0f072823f03de7814cbc574c18dec Mon Sep 17 00:00:00 2001 From: Vladislav Dzhidzhoev Date: Sat, 27 Jul 2024 02:39:32 +0200 Subject: [PATCH 01/14] [lldb][test] Improve toolchain detection in Mak

[Lldb-commits] [lldb] [lldb][test] Improve toolchain detection in Makefile.rules (PR #102185)

2024-09-09 Thread Vladislav Dzhidzhoev via lldb-commits
https://github.com/dzhidzhoev edited https://github.com/llvm/llvm-project/pull/102185 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Rewrite toolchain detection in Python (PR #102185)

2024-09-09 Thread Vladislav Dzhidzhoev via lldb-commits
https://github.com/dzhidzhoev edited https://github.com/llvm/llvm-project/pull/102185 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Rewrite toolchain detection in Python (PR #102185)

2024-09-09 Thread Vladislav Dzhidzhoev via lldb-commits
@@ -96,16 +98,120 @@ def getArchSpec(self, architecture): """ return ["ARCH=" + architecture] if architecture else [] -def getCCSpec(self, compiler): +def getToolchainSpec(self, compiler): """ -Helper function to return the key-value st

[Lldb-commits] [lldb] [lldb][test] Toolchain detection rewrite in Python (PR #102185)

2024-09-09 Thread Vladislav Dzhidzhoev via lldb-commits
https://github.com/dzhidzhoev edited https://github.com/llvm/llvm-project/pull/102185 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Add feature to remember last non-empty expression. (PR #107485)

2024-09-09 Thread John Harrison via lldb-commits
@@ -1364,6 +1364,13 @@ void request_evaluate(const llvm::json::Object &request) { std::string expression = GetString(arguments, "expression").str(); llvm::StringRef context = GetString(arguments, "context"); + // Remember the last non-empty expression from the user, and

[Lldb-commits] [lldb] [lldb][test] Support remote run of Shell tests (PR #95986)

2024-09-09 Thread Vladislav Dzhidzhoev via lldb-commits
dzhidzhoev wrote: > > > That bug shows we're not able to create a test for a very simple thing > > > (an unaligned stack pointer) that works reliably for everyone. > > > > > > Honestly, based on [#101710 > > (comment)](https://github.com/llvm/llvm-project/issues/101710#issuecomment-2291180977

[Lldb-commits] [lldb] [LLDB][Minidump] Support minidumps where there are multiple exception streams (PR #97470)

2024-09-09 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/97470 >From 5d7f2a6fb8dc06b838bf072aca1d8829eb61b316 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Fri, 6 Sep 2024 13:09:27 -0700 Subject: [PATCH 1/5] MSquash merge lldb changes and drop llvm changes --- .../Pro

[Lldb-commits] [lldb] [LLDB][Minidump] Support minidumps where there are multiple exception streams (PR #97470)

2024-09-09 Thread Jacob Lalonde via lldb-commits
@@ -387,10 +399,8 @@ bool ProcessMinidump::DoUpdateThreadList(ThreadList &old_thread_list, LocationDescriptor context_location = thread.Context; // If the minidump contains an exception context, use it -if (m_active_exception != nullptr && -m_active_except

[Lldb-commits] [lldb] [LLDB][Minidump] Support minidumps where there are multiple exception streams (PR #97470)

2024-09-09 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/97470 >From 5d7f2a6fb8dc06b838bf072aca1d8829eb61b316 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Fri, 6 Sep 2024 13:09:27 -0700 Subject: [PATCH 1/5] MSquash merge lldb changes and drop llvm changes --- .../Pro

[Lldb-commits] [lldb] [lldb-dap] Improve `stackTrace` and `exceptionInfo` DAP request handlers (PR #105905)

2024-09-09 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/105905 >From ebcf4842c7d6c5ac0da4976c9cffb68bc3b22807 Mon Sep 17 00:00:00 2001 From: John Harrison Date: Fri, 23 Aug 2024 16:04:44 -0700 Subject: [PATCH 1/8] [lldb-dap] Improve `stackTrace` and `exceptionInfo` DAP requ

[Lldb-commits] [lldb] [lldb-dap] Improve `stackTrace` and `exceptionInfo` DAP request handlers (PR #105905)

2024-09-09 Thread John Harrison via lldb-commits
@@ -3106,80 +3235,109 @@ void request_stackTrace(const llvm::json::Object &request) { llvm::json::Array stackFrames; llvm::json::Object body; + // Threads stacks may contain runtime specific extended backtraces, when + // constructing a stack trace first report the full

[Lldb-commits] [lldb] [lldb] gdb rsp file error pass fix (PR #106950)

2024-09-09 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda edited https://github.com/llvm/llvm-project/pull/106950 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] gdb rsp file error pass fix (PR #106950)

2024-09-09 Thread Jason Molenda via lldb-commits
@@ -3064,22 +3064,41 @@ static int gdb_errno_to_system(int err) { static uint64_t ParseHostIOPacketResponse(StringExtractorGDBRemote &response, uint64_t fail_result, Status &error) { + // The packet is expected to have the following

[Lldb-commits] [lldb] Revert "[LLDB] Reappply SBSaveCore AddMemoryList" (PR #107731)

2024-09-09 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: Took a quick peek at what debugserver is sending back. For this program there are 68 separate memory regions. There are 593 dirty pages across those 68 regions, pagesize is 16384 so 9715712 bytes of dirty memory (what we see lldb dumping currently). This entry, ``` <

[Lldb-commits] [lldb] Revert "[LLDB] Reappply SBSaveCore AddMemoryList" (PR #107731)

2024-09-09 Thread Jacob Lalonde via lldb-commits
Jlalond wrote: @jasonmolenda I was just about to respond. In `AddDirtyPages` [I am in fact passing End() as Size()] (https://github.com/llvm/llvm-project/commit/bb343468ffa8c2190fcdd0f704d370c75d3b5edd#diff-96c5fb7a96b37c4401faaef482eaf8d4e1ecd38d49a1ff8eb96d361b0dfa24b9L6497). I'm using this

[Lldb-commits] [lldb] [LLDB] Reapply SBSaveCore Add Memory List (PR #107937)

2024-09-09 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jacob Lalonde (Jlalond) Changes Recently in #107731 this change was revereted due to excess memory size in `TestSkinnyCore`. This was due to a bug where a range's end was being passed as size. Creating massive memory ranges. Additionally,

[Lldb-commits] [lldb] [LLDB] Reapply SBSaveCore Add Memory List (PR #107937)

2024-09-09 Thread Jacob Lalonde via lldb-commits
@@ -0,0 +1,99 @@ +//===-- CoreFileMemoryRanges.cpp *- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [LLDB] Reapply SBSaveCore Add Memory List (PR #107937)

2024-09-09 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond created https://github.com/llvm/llvm-project/pull/107937 Recently in #107731 this change was revereted due to excess memory size in `TestSkinnyCore`. This was due to a bug where a range's end was being passed as size. Creating massive memory ranges. Additionally, an

[Lldb-commits] [lldb] [lldb] Fix some tests that fail with system libstdc++ (PR #106885)

2024-09-09 Thread Tom Stellard via lldb-commits
https://github.com/tstellar milestoned https://github.com/llvm/llvm-project/pull/106885 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix some tests that fail with system libstdc++ (PR #106885)

2024-09-09 Thread Tom Stellard via lldb-commits
tstellar wrote: /cherry-pick adf44d5c3ea03569f019740e1140c3205810b3fa https://github.com/llvm/llvm-project/pull/106885 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix some tests that fail with system libstdc++ (PR #106885)

2024-09-09 Thread via lldb-commits
llvmbot wrote: /pull-request llvm/llvm-project#107938 https://github.com/llvm/llvm-project/pull/106885 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][Minidump] Support minidumps where there are multiple exception streams (PR #97470)

2024-09-09 Thread via lldb-commits
https://github.com/jeffreytan81 approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/97470 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Print a warning on checksum mismatch (PR #107968)

2024-09-09 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/107968 Print a warning when the debugger detects a mismatch between the MD5 checksum in the DWARF 5 line table and the file on disk. The warning is printed only once per file. >From 397e41bfb8516659ec6af7cf98c2d

[Lldb-commits] [lldb] [lldb] Print a warning on checksum mismatch (PR #71459)

2024-09-09 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/71459 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 4926835 - [LLDB][Minidump] Support minidumps where there are multiple exception streams (#97470)

2024-09-09 Thread via lldb-commits
Author: Jacob Lalonde Date: 2024-09-09T21:07:12-07:00 New Revision: 492683527eda7ef055660842d9a6b7e2575ae208 URL: https://github.com/llvm/llvm-project/commit/492683527eda7ef055660842d9a6b7e2575ae208 DIFF: https://github.com/llvm/llvm-project/commit/492683527eda7ef055660842d9a6b7e2575ae208.diff

[Lldb-commits] [lldb] [LLDB][Minidump] Support minidumps where there are multiple exception streams (PR #97470)

2024-09-09 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond closed https://github.com/llvm/llvm-project/pull/97470 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Print a warning on checksum mismatch (PR #71459)

2024-09-09 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Closing in favor of https://github.com/llvm/llvm-project/pull/107968 https://github.com/llvm/llvm-project/pull/71459 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm

[Lldb-commits] [lldb] [lldb] Print a warning on checksum mismatch (PR #107968)

2024-09-09 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes Print a warning when the debugger detects a mismatch between the MD5 checksum in the DWARF 5 line table and the file on disk. The warning is printed only once per file. --- Full diff: https://githu