https://github.com/DavidSpickett approved this pull request.
LGTM, thanks!
https://github.com/llvm/llvm-project/pull/106478
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Igor Kudrin
Date: 2024-08-30T09:00:35+01:00
New Revision: ce7c828e085563f29451ec5fac9626c76ebf70ee
URL:
https://github.com/llvm/llvm-project/commit/ce7c828e085563f29451ec5fac9626c76ebf70ee
DIFF:
https://github.com/llvm/llvm-project/commit/ce7c828e085563f29451ec5fac9626c76ebf70ee.diff
L
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/106478
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/106695
Otherwise known as FEAT_FPMR. This register controls the behaviour of floating
point operations.
https://developer.arm.com/documentation/ddi0601/2024-06/AArch64-Registers/FPMR--Floating-point-Mode-Registe
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: David Spickett (DavidSpickett)
Changes
Otherwise known as FEAT_FPMR. This register controls the behaviour of floating
point operations.
https://developer.arm.com/documentation/ddi0601/2024-06/AArch64-Registers/FPMR--Floating-point-Mode-Reg
DavidSpickett wrote:
Follow up PRs will add core file support and register fields.
https://github.com/llvm/llvm-project/pull/106695
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/dklimkin created
https://github.com/llvm/llvm-project/pull/106698
New value added in e00e9a3f8294c9b96cb0328bf136fab72aeec749
>From 241469a4e639a95caed22605d59728e605d09db5 Mon Sep 17 00:00:00 2001
From: Danial Klimkin
Date: Fri, 30 Aug 2024 11:36:16 +0200
Subject: [PATCH 1/
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Danial Klimkin (dklimkin)
Changes
New value added in e00e9a3f8294c9b96cb0328bf136fab72aeec749
---
Full diff: https://github.com/llvm/llvm-project/pull/106698.diff
1 Files Affected:
- (modified) lldb/source/Plugins/TypeSystem/Clang/TypeSy
Author: Danial Klimkin
Date: 2024-08-30T11:51:44+02:00
New Revision: 1b32c3e2985f89900030289eaa44e3d92cab85af
URL:
https://github.com/llvm/llvm-project/commit/1b32c3e2985f89900030289eaa44e3d92cab85af
DIFF:
https://github.com/llvm/llvm-project/commit/1b32c3e2985f89900030289eaa44e3d92cab85af.diff
https://github.com/dklimkin closed
https://github.com/llvm/llvm-project/pull/106698
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/dlav-sc updated
https://github.com/llvm/llvm-project/pull/99336
>From b7f51237438285b1be922ae754618b8c6b0b0ea3 Mon Sep 17 00:00:00 2001
From: Daniil Avdeev
Date: Thu, 11 Jul 2024 11:21:36 +
Subject: [PATCH 1/6] [lldb][RISCV] add jitted function calls to ABI
Function call
https://github.com/AaronBallman commented:
Thank you for working on this; it's a minor inconsistency, but a needless one
as best I can tell. The changes mostly look good, but there are a bunch of
binary files (.exe) that seem to have changed; do you know why?
https://github.com/llvm/llvm-proje
cor3ntin wrote:
> Thank you for working on this; it's a minor inconsistency, but a needless one
> as best I can tell. The changes mostly look good, but there are a bunch of
> binary files (.exe) that seem to have changed; do you know why?
Global find of replace in the binaries.
Sadly I'm not s
Author: Jonas Devlieghere
Date: 2024-08-30T07:18:55-07:00
New Revision: ab40ae8ff9f87b6e3d68cab2c47d692016ede958
URL:
https://github.com/llvm/llvm-project/commit/ab40ae8ff9f87b6e3d68cab2c47d692016ede958
DIFF:
https://github.com/llvm/llvm-project/commit/ab40ae8ff9f87b6e3d68cab2c47d692016ede958.d
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/106639
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2024-08-30T07:21:45-07:00
New Revision: b0eefb4c4e5136fd606cf4cff566df9dbc0fa051
URL:
https://github.com/llvm/llvm-project/commit/b0eefb4c4e5136fd606cf4cff566df9dbc0fa051
DIFF:
https://github.com/llvm/llvm-project/commit/b0eefb4c4e5136fd606cf4cff566df9dbc0fa051.d
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/106740
To support detecting MD5 checksum mismatches, deal with SupportFiles rather
than a plain FileSpecs in the SourceManager.
>From f7b0874d6bd83c85f4fb6411fc4da7dfb4dd8453 Mon Sep 17 00:00:00 2001
From: Jonas
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
To support detecting MD5 checksum mismatches, deal with SupportFiles rather
than a plain FileSpecs in the SourceManager.
---
Patch is 21.82 KiB, truncated to 20.00 KiB below, full version:
https:/
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff b0eefb4c4e5136fd606cf4cff566df9dbc0fa051
f7b0874d6bd83c85f4fb6411fc4da7dfb4dd8453 --e
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/106740
>From f7b0874d6bd83c85f4fb6411fc4da7dfb4dd8453 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Fri, 30 Aug 2024 07:20:26 -0700
Subject: [PATCH 1/2] [lldb] Deal with SupportFiles in SourceManager (NFC
Author: Walter Erquinigo
Date: 2024-08-30T12:51:56-04:00
New Revision: 9aa25b8c15c99d8e717121837a2559801e311e2d
URL:
https://github.com/llvm/llvm-project/commit/9aa25b8c15c99d8e717121837a2559801e311e2d
DIFF:
https://github.com/llvm/llvm-project/commit/9aa25b8c15c99d8e717121837a2559801e311e2d.di
walter-erquinigo wrote:
Merging because of time constraints, but happy to get follow up feedback.
https://github.com/llvm/llvm-project/pull/106609
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo
https://github.com/walter-erquinigo closed
https://github.com/llvm/llvm-project/pull/106609
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/clayborg commented:
Please fix and revert this, we do not want this in open source. Very easy to
fix and the warning does nothing to improve the situation and actually will be
bad for the product. Happy to discuss over VC and get a real fix in quickly
https://github.com/llvm
walter-erquinigo wrote:
@clayborg , sure!
https://github.com/llvm/llvm-project/pull/106609
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo created
https://github.com/llvm/llvm-project/pull/106765
Reverts llvm/llvm-project#106609
>From c6ff3f00afa70a47853af3e420aa8a99f76db3a9 Mon Sep 17 00:00:00 2001
From: Walter Erquinigo
Date: Fri, 30 Aug 2024 13:17:47 -0400
Subject: [PATCH] =?UTF-8?q?Revert=2
walter-erquinigo wrote:
Revert commit: https://github.com/llvm/llvm-project/pull/106765
https://github.com/llvm/llvm-project/pull/106609
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Walter Erquinigo (walter-erquinigo)
Changes
Reverts llvm/llvm-project#106609
---
Full diff: https://github.com/llvm/llvm-project/pull/106765.diff
2 Files Affected:
- (modified) lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp (+1
Author: Walter Erquinigo
Date: 2024-08-30T13:18:23-04:00
New Revision: 5500e21942f7047344b6fee62d3e08c0ba2f9182
URL:
https://github.com/llvm/llvm-project/commit/5500e21942f7047344b6fee62d3e08c0ba2f9182
DIFF:
https://github.com/llvm/llvm-project/commit/5500e21942f7047344b6fee62d3e08c0ba2f9182.di
https://github.com/walter-erquinigo closed
https://github.com/llvm/llvm-project/pull/106765
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond created
https://github.com/llvm/llvm-project/pull/106767
A follow up to #106473 Minidump wasn't collecting fs or gs_base. This patch
extends the x86_64 register context and gated reading it behind an lldb
specific flag. Additionally these registers are explicitly che
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jacob Lalonde (Jlalond)
Changes
A follow up to #106473 Minidump wasn't collecting fs or gs_base. This
patch extends the x86_64 register context and gated reading it behind an lldb
specific flag. Additionally these registers are explicitly
@@ -769,20 +769,26 @@ class CommandObjectBreakpointSet : public
CommandObjectParsed {
private:
bool GetDefaultFile(Target &target, FileSpec &file,
CommandReturnObject &result) {
-uint32_t default_line;
// First use the Source Manager's default
https://github.com/bulbazord edited
https://github.com/llvm/llvm-project/pull/106740
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -159,22 +158,31 @@ class SourceManager {
size_t DisplayMoreWithLineNumbers(Stream *s, uint32_t count, bool reverse,
const SymbolContextList *bp_locs =
nullptr);
- bool SetDefaultFileAndLine(const FileSpec &file_spec, uint32_t line);
+
https://github.com/bulbazord approved this pull request.
LGTM overall, I looked at the previous PR to get some context.
https://github.com/llvm/llvm-project/pull/106740
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cg
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/106740
>From f7b0874d6bd83c85f4fb6411fc4da7dfb4dd8453 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Fri, 30 Aug 2024 07:20:26 -0700
Subject: [PATCH 1/3] [lldb] Deal with SupportFiles in SourceManager (NFC
Author: Jonas Devlieghere
Date: 2024-08-30T10:58:32-07:00
New Revision: 130eddf7a13f15c9c48b7fa7faf60e9bbee4f703
URL:
https://github.com/llvm/llvm-project/commit/130eddf7a13f15c9c48b7fa7faf60e9bbee4f703
DIFF:
https://github.com/llvm/llvm-project/commit/130eddf7a13f15c9c48b7fa7faf60e9bbee4f703.d
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/106740
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -473,7 +473,8 @@ GetThreadContext_x86_64(RegisterContext *reg_ctx) {
lldb_private::minidump::MinidumpContext_x86_64_Flags::x86_64_Flag |
lldb_private::minidump::MinidumpContext_x86_64_Flags::Control |
lldb_private::minidump::MinidumpContext_x86_64_Flags::Se
@@ -473,7 +473,8 @@ GetThreadContext_x86_64(RegisterContext *reg_ctx) {
lldb_private::minidump::MinidumpContext_x86_64_Flags::x86_64_Flag |
lldb_private::minidump::MinidumpContext_x86_64_Flags::Control |
lldb_private::minidump::MinidumpContext_x86_64_Flags::Se
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/106773
This patch updates the source cache dump command to print both the actual
(on-disk) checksum and the expected (line table) checksum. To achieve that we
now read and store the on-disk checksum in the cached
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
This patch updates the source cache dump command to print both the actual
(on-disk) checksum and the expected (line table) checksum. To achieve that we
now read and store the on-disk checksum in the
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/106773
>From a73b63a4b3e74b92b9ef5f913c75b4710859bca6 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Fri, 30 Aug 2024 11:07:50 -0700
Subject: [PATCH 1/2] [lldb] Include checksum in source cache dump
This
https://github.com/adrian-prantl created
https://github.com/llvm/llvm-project/pull/106774
(based on a conversation I had with @labath yesterday in
https://github.com/llvm/llvm-project/pull/106442)
Most APIs that currently vend a Status would be better served by returning
llvm::Expected<> inst
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Adrian Prantl (adrian-prantl)
Changes
(based on a conversation I had with @labath yesterday in
https://github.com/llvm/llvm-project/pull/106442)
Most APIs that currently vend a Status would be better served by returning
llvm::Expected<> i
Author: Nicolas van Kempen
Date: 2024-08-30T19:26:49+01:00
New Revision: c49770c60f26e449379447109f7d915bd8de0384
URL:
https://github.com/llvm/llvm-project/commit/c49770c60f26e449379447109f7d915bd8de0384
DIFF:
https://github.com/llvm/llvm-project/commit/c49770c60f26e449379447109f7d915bd8de0384.
https://github.com/arichardson closed
https://github.com/llvm/llvm-project/pull/106500
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -37,49 +39,75 @@ class raw_ostream;
using namespace lldb;
using namespace lldb_private;
-Status::Status() {}
+char MachKernelError::ID;
+char Win32Error::ID;
+char ExpressionError::ID;
+
+namespace {
+/// A std::error_code category for eErrorTypeGeneric.
+class GenericCateg
@@ -91,10 +136,14 @@ class Status {
~Status();
- // llvm::Error support
- explicit Status(llvm::Error error) { *this = std::move(error); }
+ /// Try not to use this in new code. Migrate APIs to llvm::Expected instead.
JDevlieghere wrote:
[nit] I'd word
@@ -145,10 +194,12 @@ class Status {
bool Success() const;
protected:
- /// Status code as an integer value.
- ValueType m_code = 0;
- /// The type of the above error code.
- lldb::ErrorType m_type = lldb::eErrorTypeInvalid;
+ Status(llvm::Error &&error) : m_error(std::
@@ -96,16 +124,44 @@ Status Status::FromErrorStringWithFormat(const char
*format, ...) {
return Status(string);
}
-llvm::Error Status::ToError() const {
- if (Success())
-return llvm::Error::success();
- if (m_type == ErrorType::eErrorTypePOSIX)
-return llvm::erro
@@ -96,16 +124,44 @@ Status Status::FromErrorStringWithFormat(const char
*format, ...) {
return Status(string);
}
-llvm::Error Status::ToError() const {
- if (Success())
-return llvm::Error::success();
- if (m_type == ErrorType::eErrorTypePOSIX)
-return llvm::erro
@@ -37,49 +39,75 @@ class raw_ostream;
using namespace lldb;
using namespace lldb_private;
-Status::Status() {}
+char MachKernelError::ID;
+char Win32Error::ID;
+char ExpressionError::ID;
+
+namespace {
+/// A std::error_code category for eErrorTypeGeneric.
+class GenericCateg
@@ -153,6 +153,10 @@ struct MinidumpContext_x86_64 {
llvm::support::ulittle64_t last_branch_from_rip;
llvm::support::ulittle64_t last_exception_to_rip;
llvm::support::ulittle64_t last_exception_from_rip;
+
+ // These registers are LLDB specific.
clayborg
@@ -473,7 +473,8 @@ GetThreadContext_x86_64(RegisterContext *reg_ctx) {
lldb_private::minidump::MinidumpContext_x86_64_Flags::x86_64_Flag |
lldb_private::minidump::MinidumpContext_x86_64_Flags::Control |
lldb_private::minidump::MinidumpContext_x86_64_Flags::Se
@@ -67,6 +67,18 @@ def verify_core_file(
self.assertIn(thread_id, stacks_to_registers_map)
register_val_list = stacks_to_registers_map[thread_id]
frame_register_list = frame.GetRegisters()
+# explicitly verify we collected fs and
@@ -96,16 +124,44 @@ Status Status::FromErrorStringWithFormat(const char
*format, ...) {
return Status(string);
}
-llvm::Error Status::ToError() const {
- if (Success())
-return llvm::Error::success();
- if (m_type == ErrorType::eErrorTypePOSIX)
-return llvm::erro
@@ -96,16 +124,44 @@ Status Status::FromErrorStringWithFormat(const char
*format, ...) {
return Status(string);
}
-llvm::Error Status::ToError() const {
- if (Success())
-return llvm::Error::success();
- if (m_type == ErrorType::eErrorTypePOSIX)
-return llvm::erro
@@ -67,6 +67,18 @@ def verify_core_file(
self.assertIn(thread_id, stacks_to_registers_map)
register_val_list = stacks_to_registers_map[thread_id]
frame_register_list = frame.GetRegisters()
+# explicitly verify we collected fs and
@@ -96,16 +124,44 @@ Status Status::FromErrorStringWithFormat(const char
*format, ...) {
return Status(string);
}
-llvm::Error Status::ToError() const {
- if (Success())
-return llvm::Error::success();
- if (m_type == ErrorType::eErrorTypePOSIX)
-return llvm::erro
https://github.com/clayborg approved this pull request.
LGTM.
https://github.com/llvm/llvm-project/pull/104193
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -96,16 +124,44 @@ Status Status::FromErrorStringWithFormat(const char
*format, ...) {
return Status(string);
}
-llvm::Error Status::ToError() const {
- if (Success())
-return llvm::Error::success();
- if (m_type == ErrorType::eErrorTypePOSIX)
-return llvm::erro
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/106774
>From 1151a01022c860c4e098752e35f5eb5c022fbff3 Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Thu, 29 Aug 2024 17:29:10 -0700
Subject: [PATCH] [lldb] Change the implementation of Status to store an
ll
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/106774
>From 089f8e83cf5bbb9bf2e4846298709665e7cc2ee0 Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Thu, 29 Aug 2024 17:29:10 -0700
Subject: [PATCH] [lldb] Change the implementation of Status to store an
ll
@@ -96,7 +96,7 @@ class LLDB_API SBValueList {
std::unique_ptr m_opaque_up;
- void SetError(const lldb_private::Status &status);
+ void SetError(lldb_private::Status &&status);
bulbazord wrote:
This also breaks ABI.
https://github.com/llvm/llvm-project/
@@ -97,7 +97,7 @@ class LLDB_API SBError {
friend class lldb_private::ScriptInterpreter;
friend class lldb_private::python::SWIGBridge;
- SBError(const lldb_private::Status &error);
+ SBError(lldb_private::Status &&error);
bulbazord wrote:
This breaks A
@@ -37,49 +39,75 @@ class raw_ostream;
using namespace lldb;
using namespace lldb_private;
-Status::Status() {}
+char MachKernelError::ID;
+char Win32Error::ID;
+char ExpressionError::ID;
+
+namespace {
+/// A std::error_code category for eErrorTypeGeneric.
+class GenericCateg
@@ -107,7 +107,7 @@ class LLDB_API SBError {
lldb_private::Status &ref();
- void SetError(const lldb_private::Status &lldb_error);
+ void SetError(lldb_private::Status &&lldb_error);
bulbazord wrote:
This also breaks ABI.
https://github.com/llvm/llvm-pr
@@ -22,13 +22,14 @@ class ValueListImpl {
public:
ValueListImpl() = default;
- ValueListImpl(const ValueListImpl &rhs) = default;
+ ValueListImpl(const ValueListImpl &rhs)
bulbazord wrote:
This may be an ABI break if compilers generate different code or s
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/106773
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tedwoodward wrote:
Does the version number in package.json need to be updated, to automatically
publish the change to the marketplace?
https://github.com/llvm/llvm-project/pull/104711
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://l
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/106774
>From 01e0a8e65c63b47251eca72092e04cc20bf20986 Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Thu, 29 Aug 2024 17:29:10 -0700
Subject: [PATCH] [lldb] Change the implementation of Status to store an
ll
@@ -22,13 +22,14 @@ class ValueListImpl {
public:
ValueListImpl() = default;
- ValueListImpl(const ValueListImpl &rhs) = default;
+ ValueListImpl(const ValueListImpl &rhs)
adrian-prantl wrote:
Isn't `ValueListImpl` an implementation detail?
https://githu
Author: Jonas Devlieghere
Date: 2024-08-30T13:16:26-07:00
New Revision: 5e7f0dcd69fd666bbb2a93d20e6a56a11261b519
URL:
https://github.com/llvm/llvm-project/commit/5e7f0dcd69fd666bbb2a93d20e6a56a11261b519
DIFF:
https://github.com/llvm/llvm-project/commit/5e7f0dcd69fd666bbb2a93d20e6a56a11261b519.d
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/106773
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/106791
Summary:
This improves the performance of ObjectFileMacho::ParseSymtab by removing eager
and expensive work in favor of doing it later in a less-expensive fashion.
Experiment:
My goal was to understand LLDB's
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Alex Langford (bulbazord)
Changes
Summary:
This improves the performance of ObjectFileMacho::ParseSymtab by removing eager
and expensive work in favor of doing it later in a less-expensive fashion.
Experiment:
My goal was to understand LLD
@@ -22,13 +22,14 @@ class ValueListImpl {
public:
ValueListImpl() = default;
- ValueListImpl(const ValueListImpl &rhs) = default;
+ ValueListImpl(const ValueListImpl &rhs)
bulbazord wrote:
Actually you're right here, ValueListImpl is an implementation det
jasonmolenda wrote:
@clayborg what do you think about removing the memory limit from memory read?
I know this is code you originally wrote, and I might not be thinking of a way
for someone to do a huge memory read unintentionally. But it seems like this
cap just gets in people's way more tha
@@ -97,7 +97,7 @@ class LLDB_API SBError {
friend class lldb_private::ScriptInterpreter;
friend class lldb_private::python::SWIGBridge;
- SBError(const lldb_private::Status &error);
+ SBError(lldb_private::Status &&error);
bulbazord wrote:
I have no con
https://github.com/walter-erquinigo created
https://github.com/llvm/llvm-project/pull/106799
This FORM already has support within LLDB to be parsed as a 16-byte
BLOCK, and all that is left to properly support it in the DWARFParser is
to add it to some enums.
With this, I can debug programs that
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Walter Erquinigo (walter-erquinigo)
Changes
This FORM already has support within LLDB to be parsed as a 16-byte
BLOCK, and all that is left to properly support it in the DWARFParser is
to add it to some enums.
With this, I can debug program
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/106799
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -33,16 +33,16 @@ class RemoteAwarePlatformTester : public
RemoteAwarePlatform {
MOCK_METHOD0(CalculateTrapHandlerSymbolNames, void());
MOCK_METHOD2(ResolveExecutable,
- std::pair(const ModuleSpec &,
- const FileSp
adrian-prantl wrote:
Rebased on top of https://github.com/llvm/llvm-project/pull/106442!
https://github.com/llvm/llvm-project/pull/106470
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-com
@@ -96,16 +128,49 @@ Status Status::FromErrorStringWithFormat(const char
*format, ...) {
return Status(string);
}
-llvm::Error Status::ToError() const {
- if (Success())
+Status Status::FromExpressionError(lldb::ExpressionResults result,
+
@@ -27,15 +27,15 @@ TEST(StatusTest, Formatv) {
}
TEST(StatusTest, ErrorConstructor) {
- EXPECT_TRUE(Status(llvm::Error::success()).Success());
+ EXPECT_TRUE(Status::FromError(llvm::Error::success()).Success());
- Status eagain(
+ Status eagain = Status::FromError(
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff a777a93118a0ca71e19ac764a57a94f1be227dbb
854bd34a797fabe0f03234d23eb566eb10d4b593 --e
https://github.com/dfukalov created
https://github.com/llvm/llvm-project/pull/106810
This is the second part.
Without these explicit includes, removing other headers, who implicitly include
llvm-config.h, may have non-trivial side effects. For example, `clagd` may
report even `llvm-config.h`
@@ -133,36 +198,30 @@ static std::string RetrieveWin32ErrorString(uint32_t
error_code) {
}
#endif
+std::string MachKernelError::message() const {
+#if defined(__APPLE__)
+ if (const char *s = ::mach_error_string(convertToErrorCode().value()))
+return s;
+#endif
+ return
@@ -2076,7 +2077,11 @@ bool CommandInterpreter::HandleCommand(const char
*command_line,
}
ElapsedTime elapsed(execute_time);
-cmd_obj->Execute(remainder.c_str(), result);
+size_t nchar = real_original_command_string.find(remainder);
+std::optional pos_in_c
https://github.com/medismailben approved this pull request.
This is great! LGTM with comments.
https://github.com/llvm/llvm-project/pull/106774
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/ll
https://github.com/medismailben edited
https://github.com/llvm/llvm-project/pull/106774
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
adrian-prantl wrote:
Rebased on top of https://github.com/llvm/llvm-project/pull/106774!
https://github.com/llvm/llvm-project/pull/106442
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-com
@@ -130,13 +120,17 @@ class DiagnosticManager {
m_diagnostics.back()->AppendMessage(str);
}
- // Returns a string containing errors in this format:
- //
- // "error: error text\n
- // warning: warning text\n
- // remark text\n"
+ /// Returns a string containing e
96 matches
Mail list logo
