[Lldb-commits] [lldb] [lldb-dap] Enabling instruction breakpoint support to lldb-dap. (PR #105278)

2024-08-27 Thread David Spickett via lldb-commits
DavidSpickett wrote: The rest of the tests are disabled on Windows, this one should be too. One of these days I'll figure out what's wrong with them all. https://github.com/llvm/llvm-project/pull/105278 ___ lldb-commits mailing list lldb-commits@lists

[Lldb-commits] [lldb] [lldb-dap] Enabling instruction breakpoint support to lldb-dap. (PR #105278)

2024-08-27 Thread Santhosh Kumar Ellendula via lldb-commits
santhoshe447 wrote: > The rest of the lldb-dap tests are disabled on Windows, this one should be > too. > > One of these days I'll figure out what's wrong with them all. Thanks, I have submitted the PR for this. https://github.com/llvm/llvm-project/pull/106200 https://github.com/llvm/llvm-pro

[Lldb-commits] [lldb] [lldb-dap] Fix for TestDAP_instruction_breakpoint.py test failure on windows. (PR #106200)

2024-08-27 Thread Santhosh Kumar Ellendula via lldb-commits
https://github.com/santhoshe447 edited https://github.com/llvm/llvm-project/pull/106200 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][lldb-dap] Fix for TestDAP_instruction_breakpoint.py test failure on windows. (PR #106200)

2024-08-27 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/106200 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] fbef4c2 - [lldb][lldb-dap] Fix for TestDAP_instruction_breakpoint.py test failure on windows. (#106200)

2024-08-27 Thread via lldb-commits
Author: Santhosh Kumar Ellendula Date: 2024-08-27T10:31:18+01:00 New Revision: fbef4c2d31d1e3d1e5f7e285fdf397aeb161 URL: https://github.com/llvm/llvm-project/commit/fbef4c2d31d1e3d1e5f7e285fdf397aeb161 DIFF: https://github.com/llvm/llvm-project/commit/fbef4c2d31d1e3d1e5f7e285fdf397a

[Lldb-commits] [lldb] [lldb][lldb-dap] Fix for TestDAP_instruction_breakpoint.py test failure on windows. (PR #106200)

2024-08-27 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/106200 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][lldb-dap] Fix for TestDAP_instruction_breakpoint.py test failure on windows. (PR #106200)

2024-08-27 Thread David Spickett via lldb-commits
DavidSpickett wrote: Thanks! https://github.com/llvm/llvm-project/pull/106200 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] unique_ptr-ify some GetUserExpression APIs. (PR #106034)

2024-08-27 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/106034 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] ca3b9af - Add logs for SymbolFileDWARF::FindTypes (#106030)

2024-08-27 Thread via lldb-commits
Author: Dmitrii Galimzianov Date: 2024-08-27T10:41:09+01:00 New Revision: ca3b9af98c0b119598bc26a9130f468b196d83b3 URL: https://github.com/llvm/llvm-project/commit/ca3b9af98c0b119598bc26a9130f468b196d83b3 DIFF: https://github.com/llvm/llvm-project/commit/ca3b9af98c0b119598bc26a9130f468b196d83b3

[Lldb-commits] [lldb] Add logs for SymbolFileDWARF::FindTypes (PR #106030)

2024-08-27 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/106030 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add logs for SymbolFileDWARF::FindTypes (PR #106030)

2024-08-27 Thread via lldb-commits
github-actions[bot] wrote: @DmT021 Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a build,

[Lldb-commits] [clang] [lldb] [llvm] [ARM] musttail fixes (PR #102896)

2024-08-27 Thread via lldb-commits
https://github.com/kiran-isaac updated https://github.com/llvm/llvm-project/pull/102896 >From 24806b179d34b4afb21832e4a2150c13995b59e0 Mon Sep 17 00:00:00 2001 From: Kiran Date: Thu, 8 Aug 2024 13:07:24 +0100 Subject: [PATCH 1/4] [ARM] musttail fixes Backend: - Caller and callee arguments no l

[Lldb-commits] [lldb] [lldb] Add 'FindInMemory()' overload for PostMortemProcess. (PR #102536)

2024-08-27 Thread Pavel Labath via lldb-commits
labath wrote: > Let me know if you guys don't want this patch in. I will closed it and apply > it to our local branch. @jasonmolenda @labath Without claiming official authority to make this decision, I'm going to say that *I* don't think this is a good idea, because the patch is very (and IMO,

[Lldb-commits] [lldb] [lldb] Turn lldb_private::Status into a value type. (PR #106163)

2024-08-27 Thread Michael Buch via lldb-commits
@@ -39,8 +39,8 @@ using namespace lldb_private; Status::Status() : m_string() {} -Status::Status(ValueType err, ErrorType type) -: m_code(err), m_type(type), m_string() {} +Status::Status(ValueType err, ErrorType type, llvm::StringRef msg) Michael137 wrot

[Lldb-commits] [lldb] [lldb] Turn lldb_private::Status into a value type. (PR #106163)

2024-08-27 Thread Michael Buch via lldb-commits
@@ -51,13 +51,13 @@ Status::Status(std::error_code EC) : eErrorTypeGeneric), m_string(EC.message()) {} -Status::Status(const char *format, ...) : m_string() { - va_list args; - va_start(args, format); - SetErrorToG

[Lldb-commits] [lldb] [lldb] Turn lldb_private::Status into a value type. (PR #106163)

2024-08-27 Thread Michael Buch via lldb-commits
@@ -51,13 +51,13 @@ Status::Status(std::error_code EC) : eErrorTypeGeneric), m_string(EC.message()) {} -Status::Status(const char *format, ...) : m_string() { - va_list args; - va_start(args, format); - SetErrorToG

[Lldb-commits] [lldb] [lldb] Turn lldb_private::Status into a value type. (PR #106163)

2024-08-27 Thread Pavel Labath via lldb-commits
labath wrote: I like this. I have just two remarks: - it might be better to split this into three steps (add new APIs, port to new APIs, remove old APIs), as that will make reverts easier/less disruptive (I don't know how much we can trust pre-commit CI these days, but I wouldn't be surprised

[Lldb-commits] [lldb] [lldb] Updated TCPSocket to listen multiple ports on the same single thread (PR #104797)

2024-08-27 Thread Pavel Labath via lldb-commits
labath wrote: Having a single socket listen on multiple ports sounds like a bad idea to me. The socket class is complicated enough as it is, and it's not the way the MainLoop class was meant to be used (the idea being for it to be created at the topmost level possible, so that any number of us

[Lldb-commits] [lldb] [lldb] Updated TCPSocket to listen multiple ports on the same single thread (PR #104797)

2024-08-27 Thread Dmitry Vasilyev via lldb-commits
slydiman wrote: @labath > Having a single socket listen on multiple ports sounds like a bad idea to me. Note that currently the class TCPSocket already contains a list of NativeSocket `m_listen_sockets`. We do not need 2 TCPSocket instances with 2 separated lists of native sockets even with

[Lldb-commits] [lldb] d517b22 - [LLDB][SBSaveCore] Add selectable memory regions to SBSaveCore (#105442)

2024-08-27 Thread via lldb-commits
Author: Jacob Lalonde Date: 2024-08-27T07:33:12-07:00 New Revision: d517b224117f760e6a7299b267256e3240c04edb URL: https://github.com/llvm/llvm-project/commit/d517b224117f760e6a7299b267256e3240c04edb DIFF: https://github.com/llvm/llvm-project/commit/d517b224117f760e6a7299b267256e3240c04edb.diff

[Lldb-commits] [lldb] [LLDB][SBSaveCore] Add selectable memory regions to SBSaveCore (PR #105442)

2024-08-27 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond closed https://github.com/llvm/llvm-project/pull/105442 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][WIP] memory find speedup+bugfix (PR #104193)

2024-08-27 Thread Pavel Labath via lldb-commits
https://github.com/labath updated https://github.com/llvm/llvm-project/pull/104193 >From b46820a91f1ad8d6db46210e3135abdb1ab475e8 Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Wed, 14 Aug 2024 19:58:27 +0200 Subject: [PATCH] [lldb] Fix and speedup the `memory find` command This patch fixes

[Lldb-commits] [lldb] [lldb][WIP] memory find speedup+bugfix (PR #104193)

2024-08-27 Thread Pavel Labath via lldb-commits
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/104193 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix and speedup the `memory find` command (PR #104193)

2024-08-27 Thread Pavel Labath via lldb-commits
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/104193 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix and speedup the `memory find` command (PR #104193)

2024-08-27 Thread Pavel Labath via lldb-commits
https://github.com/labath updated https://github.com/llvm/llvm-project/pull/104193 >From 7b8b8b699902d2365ea43e5ae015546c4d20fac8 Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Wed, 14 Aug 2024 19:58:27 +0200 Subject: [PATCH] [lldb] Fix and speedup the `memory find` command This patch fixes

[Lldb-commits] [lldb] [lldb] Fix and speedup the `memory find` command (PR #104193)

2024-08-27 Thread Pavel Labath via lldb-commits
https://github.com/labath ready_for_review https://github.com/llvm/llvm-project/pull/104193 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix and speedup the `memory find` command (PR #104193)

2024-08-27 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes This patch fixes an issue where the `memory find` command would effectively stop searching after encountering a memory read error (which could happen due to unreadable memory), without giving any indication that

[Lldb-commits] [lldb] [lldb] Fix and speedup the `memory find` command (PR #104193)

2024-08-27 Thread Pavel Labath via lldb-commits
https://github.com/labath updated https://github.com/llvm/llvm-project/pull/104193 >From 7b8b8b699902d2365ea43e5ae015546c4d20fac8 Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Wed, 14 Aug 2024 19:58:27 +0200 Subject: [PATCH 1/2] [lldb] Fix and speedup the `memory find` command This patch f

[Lldb-commits] [clang] [lldb] [llvm] [mlir] [Support] Validate number of arguments passed to formatv() (PR #105745)

2024-08-27 Thread Rahul Joshi via lldb-commits
https://github.com/jurahul updated https://github.com/llvm/llvm-project/pull/105745 >From 9ae8a0361b0d26cf29cc4547658baec0c2654c89 Mon Sep 17 00:00:00 2001 From: Rahul Joshi Date: Thu, 22 Aug 2024 08:47:02 -0700 Subject: [PATCH] [Support] Detect invalid formatv() calls - Detect formatv() calls

[Lldb-commits] [lldb] [lldb] Turn lldb_private::Status into a value type. (PR #106163)

2024-08-27 Thread Adrian Prantl via lldb-commits
@@ -56,19 +56,41 @@ class Status { /// /// \param[in] type /// The type for \a err. - explicit Status(ValueType err, - lldb::ErrorType type = lldb::eErrorTypeGeneric); + explicit Status(ValueType err, lldb::ErrorType type = lldb::eErrorTypeGeneric,

[Lldb-commits] [lldb] [lldb] Turn lldb_private::Status into a value type. (PR #106163)

2024-08-27 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: > I worry the assert will kill the LLDB library and cause issues. Can we add a > temporary setting that can override this in case it does cause crashes? I > really don't want LLDB crashing if we can help it. It will be hard to test > all of the error code paths that can ha

[Lldb-commits] [lldb] [lldb] Turn lldb_private::Status into a value type. (PR #106163)

2024-08-27 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: > I like this. I have just two remarks: > > * it might be better to split this into three steps (add new APIs, port to > new APIs, remove old APIs), as that will make reverts easier/less disruptive > (I don't know how much we can trust pre-commit CI these days, but I would

[Lldb-commits] [lldb] [lldb] Turn lldb_private::Status into a value type. (PR #106163)

2024-08-27 Thread Adrian Prantl via lldb-commits
@@ -15,7 +15,7 @@ def __init__(self, exe_ctx: lldb.SBExecutionContext, args: lldb.SBStructuredData def read_memory_at_address( self, addr: int, size: int, error: lldb.SBError ) -> lldb.SBData: -error.SetErrorString("This is an invalid scripted process!"

[Lldb-commits] [lldb] [lldb] Turn lldb_private::Status into a value type. (PR #106163)

2024-08-27 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 6e44cb3ccb822085cd2f35c63daa60395dda26f2 37febe79c170b0575051b5fb24a9db3208721b0b --e

[Lldb-commits] [lldb] [lldb] Add frame recognizers for libc++ `std::invoke` (PR #105695)

2024-08-27 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/105695 >From e90463e8967c2019e220b063ed4ce73cd0172bf3 Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Thu, 22 Aug 2024 10:50:13 + Subject: [PATCH 1/6] [lldb-dap] Add frame recognizers for libc++ `std:

[Lldb-commits] [lldb] [lldb] Add frame recognizers for libc++ `std::invoke` (PR #105695)

2024-08-27 Thread Adrian Vogelsgesang via lldb-commits
@@ -305,7 +307,9 @@ def test_frame_recognizer_target_specific(self): self.expect( "frame recognizer list", -substrs=["recognizer.MyFrameRecognizer, module a.out, symbol bar"], +substrs=[ +"recognizer.MyFrameRecognizer

[Lldb-commits] [lldb] [lldb] Turn lldb_private::Status into a value type. (PR #106163)

2024-08-27 Thread via lldb-commits
jimingham wrote: > On Aug 27, 2024, at 8:51 AM, Adrian Prantl ***@***.***> wrote: > > > I like this. I have just two remarks: > > it might be better to split this into three steps (add new APIs, port to new > APIs, remove old APIs), as that will make reverts easier/less disruptive (I > don

[Lldb-commits] [lldb] [lldb] Turn lldb_private::Status into a value type. (PR #106163)

2024-08-27 Thread via lldb-commits
jimingham wrote: That should of course be lldb_private::Error -> lldb_private::Status... Jim > On Aug 27, 2024, at 9:48 AM, Jim Ingham ***@***.***> wrote: > >> >> >> >>> On Aug 27, 2024, at 8:51 AM, Adrian Prantl ***@***.***> wrote: >>> >>> >>> I like this. I have just two remarks: >>>

[Lldb-commits] [lldb] 384d69f - [lldb] Cleanup dyld_process_t after constructing SharedCacheInfo (#106157)

2024-08-27 Thread via lldb-commits
Author: Alex Langford Date: 2024-08-27T09:59:17-07:00 New Revision: 384d69fcbbd07941e7eb1899435e4d56d0469637 URL: https://github.com/llvm/llvm-project/commit/384d69fcbbd07941e7eb1899435e4d56d0469637 DIFF: https://github.com/llvm/llvm-project/commit/384d69fcbbd07941e7eb1899435e4d56d0469637.diff

[Lldb-commits] [lldb] [lldb] Cleanup dyld_process_t after constructing SharedCacheInfo (PR #106157)

2024-08-27 Thread Alex Langford via lldb-commits
https://github.com/bulbazord closed https://github.com/llvm/llvm-project/pull/106157 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add frame recognizers for libc++ `std::invoke` (PR #105695)

2024-08-27 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/105695 >From e90463e8967c2019e220b063ed4ce73cd0172bf3 Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Thu, 22 Aug 2024 10:50:13 + Subject: [PATCH 1/7] [lldb-dap] Add frame recognizers for libc++ `std:

[Lldb-commits] [lldb] [lldb] unique_ptr-ify some GetUserExpression APIs. (PR #106034)

2024-08-27 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. https://github.com/llvm/llvm-project/pull/106034 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add frame recognizers for libc++ `std::invoke` (PR #105695)

2024-08-27 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/105695 >From e90463e8967c2019e220b063ed4ce73cd0172bf3 Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Thu, 22 Aug 2024 10:50:13 + Subject: [PATCH 1/7] [lldb-dap] Add frame recognizers for libc++ `std:

[Lldb-commits] [clang] [compiler-rt] [libcxx] [lld] [lldb] [llvm] [mlir] [polly] python: use raw strings for regex (PR #105990)

2024-08-27 Thread Nikolas Klauser via lldb-commits
@@ -284,7 +284,7 @@ def sync_csv(rows: List[Tuple], from_github: List[PaperInfo]) -> List[Tuple]: results.append(gh.for_printing()) continue elif paper.status != gh.status: -print(f"We found a CSV row and a Github issue with differen

[Lldb-commits] [lldb] [lldb] Turn lldb_private::Status into a value type. (PR #106163)

2024-08-27 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: Updated all the non-Darwin plugins. I believe to have addressed all outstanding comments now. https://github.com/llvm/llvm-project/pull/106163 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[Lldb-commits] [lldb] dd060bd - [lldb] Add frame recognizers for libc++ `std::invoke` (#105695)

2024-08-27 Thread via lldb-commits
Author: Adrian Vogelsgesang Date: 2024-08-27T19:15:42+02:00 New Revision: dd060bdede8edec18ad5ca122e15cc24a821e3fe URL: https://github.com/llvm/llvm-project/commit/dd060bdede8edec18ad5ca122e15cc24a821e3fe DIFF: https://github.com/llvm/llvm-project/commit/dd060bdede8edec18ad5ca122e15cc24a821e3fe

[Lldb-commits] [lldb] [lldb] Add frame recognizers for libc++ `std::invoke` (PR #105695)

2024-08-27 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang closed https://github.com/llvm/llvm-project/pull/105695 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Turn lldb_private::Status into a value type. (PR #106163)

2024-08-27 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. I haven't reviewed every single file but the ones I did look at look straightforward and correct. The changes to `Status` itself I feel positively about. I agree with the direction that this takes `Status` in. https://github.com/llvm/llv

[Lldb-commits] [lldb] [lldb] Turn lldb_private::Status into a value type. (PR #106163)

2024-08-27 Thread Greg Clayton via lldb-commits
clayborg wrote: My concerns are addressed, thanks @adrian-prantl https://github.com/llvm/llvm-project/pull/106163 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Turn lldb_private::Status into a value type. (PR #106163)

2024-08-27 Thread Michael Buch via lldb-commits
@@ -37,10 +37,10 @@ class raw_ostream; using namespace lldb; using namespace lldb_private; -Status::Status() : m_string() {} +Status::Status() {} -Status::Status(ValueType err, ErrorType type) -: m_code(err), m_type(type), m_string() {} +Status::Status(ValueType err, Err

[Lldb-commits] [lldb] [lldb] Turn lldb_private::Status into a value type. (PR #106163)

2024-08-27 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. This is great. It's something I've wanted since the first day I started working on LLDB. We've made a lot of progress in this direction so it's great to see that we've reached a point where we can make this actually happen. https://g

[Lldb-commits] [lldb] [lldb] Don't scan more than 10MB of assembly insns (PR #105890)

2024-08-27 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/105890 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Turn lldb_private::Status into a value type. (PR #106163)

2024-08-27 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl closed https://github.com/llvm/llvm-project/pull/106163 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] d1d8edf - [lldb] Add transitional backwards-compatible API to Status

2024-08-27 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2024-08-27T11:00:08-07:00 New Revision: d1d8edf50449accf7896620afc0249af91354d17 URL: https://github.com/llvm/llvm-project/commit/d1d8edf50449accf7896620afc0249af91354d17 DIFF: https://github.com/llvm/llvm-project/commit/d1d8edf50449accf7896620afc0249af91354d17.diff

[Lldb-commits] [lldb] [lldb] Add frame recognizers for libc++ `std::invoke` (PR #105695)

2024-08-27 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: Looks like this is failing on the Darwin bot: https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/as-lldb-cmake/10463/ https://github.com/llvm/llvm-project/pull/105695 ___ lldb-commits mailing list lldb-commits@lists.llvm.org ht

[Lldb-commits] [lldb] [lldb] Add frame recognizers for libc++ `std::invoke` (PR #105695)

2024-08-27 Thread Adrian Prantl via lldb-commits
@@ -305,7 +307,9 @@ def test_frame_recognizer_target_specific(self): self.expect( "frame recognizer list", -substrs=["recognizer.MyFrameRecognizer, module a.out, symbol bar"], +substrs=[ +"recognizer.MyFrameRecognizer

[Lldb-commits] [lldb] c349ded - [lldb] Add missing namespace

2024-08-27 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2024-08-27T11:04:54-07:00 New Revision: c349ded7e61f3611ea54fa712e54b16c4c317a6b URL: https://github.com/llvm/llvm-project/commit/c349ded7e61f3611ea54fa712e54b16c4c317a6b DIFF: https://github.com/llvm/llvm-project/commit/c349ded7e61f3611ea54fa712e54b16c4c317a6b.diff

[Lldb-commits] [clang] [compiler-rt] [libcxx] [lld] [lldb] [llvm] [mlir] [polly] python: use raw strings for regex (PR #105990)

2024-08-27 Thread Paul Zander via lldb-commits
@@ -284,7 +284,7 @@ def sync_csv(rows: List[Tuple], from_github: List[PaperInfo]) -> List[Tuple]: results.append(gh.for_printing()) continue elif paper.status != gh.status: -print(f"We found a CSV row and a Github issue with differen

[Lldb-commits] [clang] [compiler-rt] [libcxx] [lld] [lldb] [llvm] [mlir] [polly] python: use raw strings for regex (PR #105990)

2024-08-27 Thread Paul Zander via lldb-commits
https://github.com/negril edited https://github.com/llvm/llvm-project/pull/105990 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] unique_ptr-ify some GetUserExpression APIs. (PR #106034)

2024-08-27 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/106034 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [compiler-rt] [libcxx] [lld] [lldb] [llvm] [mlir] [polly] python: use raw strings for regex (PR #105990)

2024-08-27 Thread Louis Dionne via lldb-commits
@@ -284,7 +284,7 @@ def sync_csv(rows: List[Tuple], from_github: List[PaperInfo]) -> List[Tuple]: results.append(gh.for_printing()) continue elif paper.status != gh.status: -print(f"We found a CSV row and a Github issue with differen

[Lldb-commits] [clang] [compiler-rt] [libcxx] [lld] [lldb] [llvm] [mlir] [polly] python: use raw strings for regex (PR #105990)

2024-08-27 Thread Louis Dionne via lldb-commits
https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/105990 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Turn lldb_private::Status into a value type. (PR #106163)

2024-08-27 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-x86_64-debian-dylib` running on `gribozavr4` while building `lldb` at step 5 "build-unified-tree". Full details are available at: https://lab.llvm.org/buildbot/#/builders/60/builds/6005 Here is the relevant piece of the

[Lldb-commits] [lldb] 5e64520 - [lldb] Update Windows test to new Status API

2024-08-27 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2024-08-27T12:28:25-07:00 New Revision: 5e64520dae5dd980bc6db25414edc3a167d8af8f URL: https://github.com/llvm/llvm-project/commit/5e64520dae5dd980bc6db25414edc3a167d8af8f DIFF: https://github.com/llvm/llvm-project/commit/5e64520dae5dd980bc6db25414edc3a167d8af8f.diff

[Lldb-commits] [lldb] [LLDB][SBSaveCore] Add selectable memory regions to SBSaveCore (PR #105442)

2024-08-27 Thread Med Ismail Bennani via lldb-commits
medismailben wrote: It looks like this broke lldb macOS bots: https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/as-lldb-cmake/10450/ @Jlalond can you take a look ? Thanks. https://github.com/llvm/llvm-project/pull/105442 ___ lldb-commits mailing

[Lldb-commits] [lldb] b24ffa6 - [lldb] Update ProcessLauncherWinows to new Status API

2024-08-27 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2024-08-27T12:34:54-07:00 New Revision: b24ffa6002424423ee6bd54347db9b0855efbc2a URL: https://github.com/llvm/llvm-project/commit/b24ffa6002424423ee6bd54347db9b0855efbc2a DIFF: https://github.com/llvm/llvm-project/commit/b24ffa6002424423ee6bd54347db9b0855efbc2a.diff

[Lldb-commits] [clang] [lldb] [llvm] [mlir] [Support] Validate number of arguments passed to formatv() (PR #105745)

2024-08-27 Thread Rahul Joshi via lldb-commits
https://github.com/jurahul ready_for_review https://github.com/llvm/llvm-project/pull/105745 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [llvm] [mlir] [Support] Validate number of arguments passed to formatv() (PR #105745)

2024-08-27 Thread Mehdi Amini via lldb-commits
joker-eph wrote: CI failed FYI. https://github.com/llvm/llvm-project/pull/105745 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [llvm] [mlir] [Support] Validate number of arguments passed to formatv() (PR #105745)

2024-08-27 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-debuginfo @llvm/pr-subscribers-lldb Author: Rahul Joshi (jurahul) Changes - Change formatv() to validate that the number of arguments passed matches number of replacement fields in the format string. - When the format string is a literal, this f

[Lldb-commits] [clang] [lldb] [llvm] [mlir] [Support] Validate number of arguments passed to formatv() (PR #105745)

2024-08-27 Thread Rahul Joshi via lldb-commits
jurahul wrote: Hi all, this is related to https://discourse.llvm.org/t/adding-argument-count-validation-for-formatv/80876/1 I still have formatv() and formatvv() functions in the code, but only a handful instances. So, if this looks ok overall, I will go ahead and rename formatvv() to formatv

[Lldb-commits] [clang] [lldb] [llvm] [mlir] [Support] Validate number of arguments passed to formatv() (PR #105745)

2024-08-27 Thread Rahul Joshi via lldb-commits
jurahul wrote: > CI failed FYI. Yeah, it looked like an unrelated failure. Windows CI passed. https://github.com/llvm/llvm-project/pull/105745 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/ll

[Lldb-commits] [clang] [lldb] [llvm] [mlir] [Support] Validate number of arguments passed to formatv() (PR #105745)

2024-08-27 Thread Mehdi Amini via lldb-commits
https://github.com/joker-eph edited https://github.com/llvm/llvm-project/pull/105745 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [llvm] [mlir] [Support] Validate number of arguments passed to formatv() (PR #105745)

2024-08-27 Thread Mehdi Amini via lldb-commits
@@ -67,92 +68,123 @@ formatv_object_base::parseReplacementItem(StringRef Spec) { StringRef Options; size_t Index = 0; RepString = RepString.trim(); - if (RepString.consumeInteger(0, Index)) { -assert(false && "Invalid replacement sequence index!"); -return Replac

[Lldb-commits] [clang] [lldb] [llvm] [mlir] [Support] Validate number of arguments passed to formatv() (PR #105745)

2024-08-27 Thread Mehdi Amini via lldb-commits
https://github.com/joker-eph commented: Thanks, I'm wondering about the cost of this: what does it do to some compile-time tests with clang for example? https://github.com/llvm/llvm-project/pull/105745 ___ lldb-commits mailing list lldb-commits@lists.

[Lldb-commits] [clang] [lldb] [llvm] [mlir] [Support] Validate number of arguments passed to formatv() (PR #105745)

2024-08-27 Thread Rahul Joshi via lldb-commits
@@ -67,92 +68,123 @@ formatv_object_base::parseReplacementItem(StringRef Spec) { StringRef Options; size_t Index = 0; RepString = RepString.trim(); - if (RepString.consumeInteger(0, Index)) { -assert(false && "Invalid replacement sequence index!"); -return Replac

[Lldb-commits] [clang] [lldb] [llvm] [mlir] [Support] Validate number of arguments passed to formatv() (PR #105745)

2024-08-27 Thread Rahul Joshi via lldb-commits
jurahul wrote: > compile-time tests with clang for example I can check. How do I run them? https://github.com/llvm/llvm-project/pull/105745 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-

[Lldb-commits] [lldb] [LLDB][SBSaveCore] Add selectable memory regions to SBSaveCore (PR #105442)

2024-08-27 Thread Jacob Lalonde via lldb-commits
Jlalond wrote: @medismailben Ack https://github.com/llvm/llvm-project/pull/105442 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [llvm] [mlir] [Support] Validate number of arguments passed to formatv() (PR #105745)

2024-08-27 Thread Mehdi Amini via lldb-commits
@@ -67,92 +68,123 @@ formatv_object_base::parseReplacementItem(StringRef Spec) { StringRef Options; size_t Index = 0; RepString = RepString.trim(); - if (RepString.consumeInteger(0, Index)) { -assert(false && "Invalid replacement sequence index!"); -return Replac

[Lldb-commits] [clang] [lldb] [llvm] [mlir] [Support] Validate number of arguments passed to formatv() (PR #105745)

2024-08-27 Thread Rahul Joshi via lldb-commits
https://github.com/jurahul edited https://github.com/llvm/llvm-project/pull/105745 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [llvm] [mlir] [Support] Validate number of arguments passed to formatv() (PR #105745)

2024-08-27 Thread Rahul Joshi via lldb-commits
https://github.com/jurahul edited https://github.com/llvm/llvm-project/pull/105745 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix test expectation in `TestFrameRecognizer.py` (PR #106281)

2024-08-27 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang created https://github.com/llvm/llvm-project/pull/106281 None >From 2fdc99f2e42ac7bc12449e420ff653fb963cee24 Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Tue, 27 Aug 2024 20:14:36 + Subject: [PATCH] [lldb] Fix test expectation in `TestFrameRecogn

[Lldb-commits] [lldb] [lldb] Fix test expectation in `TestFrameRecognizer.py` (PR #106281)

2024-08-27 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Adrian Vogelsgesang (vogelsgesang) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/106281.diff 1 Files Affected: - (modified) lldb/test/API/commands/frame/recognizer/TestFrameRecognizer.py (+1-1) ``diff diff

[Lldb-commits] [lldb] [lldb] Add frame recognizers for libc++ `std::invoke` (PR #105695)

2024-08-27 Thread Adrian Vogelsgesang via lldb-commits
vogelsgesang wrote: fixed in #106281 https://github.com/llvm/llvm-project/pull/105695 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [llvm] [mlir] [Support] Validate number of arguments passed to formatv() (PR #105745)

2024-08-27 Thread Rahul Joshi via lldb-commits
jurahul wrote: > > compile-time tests with clang for example > > I can check. How do I run them? I am wondering if running mlir-tblgen is a better benchmark, given that formatv() is widely used there (as opposed to clang), in case this measurement has to be done manually. https://github.com/

[Lldb-commits] [lldb] [lldb] Fix test expectation in `TestFrameRecognizer.py` (PR #106281)

2024-08-27 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang updated https://github.com/llvm/llvm-project/pull/106281 >From b32e85a07ab0e6dc55d28706d50eb84345575bc6 Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Tue, 27 Aug 2024 20:14:36 + Subject: [PATCH] [lldb] Fix test expectation in `TestFrameRecognizer.p

[Lldb-commits] [lldb] [lldb] Fix test expectation in `TestFrameRecognizer.py` (PR #106281)

2024-08-27 Thread Adrian Vogelsgesang via lldb-commits
vogelsgesang wrote: @adrian-prantl It seems I overlooked this test expectation. This hopefully fixes the build issue in https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/as-lldb-cmake/10463/ . Unfortunately, i was not able to run this test locally, it is marked as "unsupported" for some r

[Lldb-commits] [lldb] [lldb] Fix test expectation in `TestFrameRecognizer.py` (PR #106281)

2024-08-27 Thread Michael Buch via lldb-commits
https://github.com/Michael137 approved this pull request. https://github.com/llvm/llvm-project/pull/106281 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [llvm] [mlir] [Support] Validate number of arguments passed to formatv() (PR #105745)

2024-08-27 Thread Mehdi Amini via lldb-commits
joker-eph wrote: Possible, let's try it there then https://github.com/llvm/llvm-project/pull/105745 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] fc51797 - [lldb] Fix test expectation in `TestFrameRecognizer.py` (#106281)

2024-08-27 Thread via lldb-commits
Author: Adrian Vogelsgesang Date: 2024-08-27T22:59:14+02:00 New Revision: fc517973c299d879f0795d37500a7db1f4d63588 URL: https://github.com/llvm/llvm-project/commit/fc517973c299d879f0795d37500a7db1f4d63588 DIFF: https://github.com/llvm/llvm-project/commit/fc517973c299d879f0795d37500a7db1f4d63588

[Lldb-commits] [lldb] [lldb] Fix test expectation in `TestFrameRecognizer.py` (PR #106281)

2024-08-27 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang closed https://github.com/llvm/llvm-project/pull/106281 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[LLDB][SBSaveCore] Add selectable memory regions to SBSaveCor… (PR #106293)

2024-08-27 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond created https://github.com/llvm/llvm-project/pull/106293 Reverts #105442. Due to `TestSkinnyCoreFailing` and root causing of the failure will likely take longer than EOD. >From b0caffa2d427ea94e90186e32125452ab4e1dd1e Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Dat

[Lldb-commits] [lldb] Revert "[LLDB][SBSaveCore] Add selectable memory regions to SBSaveCor… (PR #106293)

2024-08-27 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jacob Lalonde (Jlalond) Changes Reverts #105442. Due to `TestSkinnyCoreFailing` and root causing of the failure will likely take longer than EOD. --- Patch is 29.32 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm

[Lldb-commits] [lldb] b959532 - Revert "[LLDB][SBSaveCore] Add selectable memory regions to SBSaveCor… (#106293)

2024-08-27 Thread via lldb-commits
Author: Jacob Lalonde Date: 2024-08-27T14:23:00-07:00 New Revision: b9595324846a96dd3443359a62c70cec5aa352b8 URL: https://github.com/llvm/llvm-project/commit/b9595324846a96dd3443359a62c70cec5aa352b8 DIFF: https://github.com/llvm/llvm-project/commit/b9595324846a96dd3443359a62c70cec5aa352b8.diff

[Lldb-commits] [lldb] Revert "[LLDB][SBSaveCore] Add selectable memory regions to SBSaveCor… (PR #106293)

2024-08-27 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond closed https://github.com/llvm/llvm-project/pull/106293 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[LLDB][SBSaveCore] Add selectable memory regions to SBSaveCor… (PR #106293)

2024-08-27 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 4ea2c73886c407d47215484ab6c983ac6189dd14...b0caffa2d427ea94e90186e32125452ab4e1dd1e lldb

[Lldb-commits] [lldb] Revert "[LLDB][SBSaveCore] Add selectable memory regions to SBSaveCor… (PR #106293)

2024-08-27 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 4ea2c73886c407d47215484ab6c983ac6189dd14 b0caffa2d427ea94e90186e32125452ab4e1dd1e --e

[Lldb-commits] [lldb] ff2baf0 - Revert "[lldb] Add transitional backwards-compatible API to Status"

2024-08-27 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2024-08-27T14:40:29-07:00 New Revision: ff2baf0360372a3762218b6db4beaf7117a4 URL: https://github.com/llvm/llvm-project/commit/ff2baf0360372a3762218b6db4beaf7117a4 DIFF: https://github.com/llvm/llvm-project/commit/ff2baf0360372a3762218b6db4beaf7117a4.diff

[Lldb-commits] [lldb] 67eb727 - [lldb] Update NativeProcessLinux to new Status API

2024-08-27 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2024-08-27T14:48:16-07:00 New Revision: 67eb72725d1e1c7e214c8f1feded99b152b76470 URL: https://github.com/llvm/llvm-project/commit/67eb72725d1e1c7e214c8f1feded99b152b76470 DIFF: https://github.com/llvm/llvm-project/commit/67eb72725d1e1c7e214c8f1feded99b152b76470.diff

[Lldb-commits] [lldb] 3280292 - [lldb] Don't scan more than 10MB of assembly insns (#105890)

2024-08-27 Thread via lldb-commits
Author: Jason Molenda Date: 2024-08-27T14:50:46-07:00 New Revision: 328029242136950204ce8bf953eb592bff946d30 URL: https://github.com/llvm/llvm-project/commit/328029242136950204ce8bf953eb592bff946d30 DIFF: https://github.com/llvm/llvm-project/commit/328029242136950204ce8bf953eb592bff946d30.diff

[Lldb-commits] [lldb] [lldb] Don't scan more than 10MB of assembly insns (PR #105890)

2024-08-27 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda closed https://github.com/llvm/llvm-project/pull/105890 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

  1   2   >