https://github.com/Michael137 approved this pull request.
LGTM (left some minor comments)
https://github.com/llvm/llvm-project/pull/102708
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-co
@@ -145,15 +148,27 @@ std::string CXXFunctionSummaryFormat::GetDescription() {
return std::string(sstr.GetString());
}
+std::string CXXFunctionSummaryFormat::GetName() { return m_description; }
+
+std::string CXXFunctionSummaryFormat::GetSummaryKindName() { return "c++"; }
+
@@ -0,0 +1,64 @@
+#include "lldb/DataFormatters/TypeSummary.h"
+#include "lldb/Target/Statistics.h"
+#include "lldb/Utility/Stream.h"
+#include "lldb/lldb-forward.h"
+#include "lldb/lldb-private-enumerations.h"
+#include "lldb/lldb-private.h"
+#include "llvm/Testing/Support/Error.
@@ -145,15 +148,27 @@ std::string CXXFunctionSummaryFormat::GetDescription() {
return std::string(sstr.GetString());
}
+std::string CXXFunctionSummaryFormat::GetName() { return m_description; }
+
+std::string CXXFunctionSummaryFormat::GetSummaryKindName() { return "c++"; }
+
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/102708
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -53,10 +54,32 @@ class LibCXXFrameRecognizer : public StackFrameRecognizer {
public:
LibCXXFrameRecognizer()
- : m_hidden_function_regex(
-R"(^std::__1::(__function.*::operator\(\)|__invoke))"
-R"((\[.*\])?)"// ABI tag.
-R"(( c
@@ -81,8 +105,9 @@ CPPLanguageRuntime::CPPLanguageRuntime(Process *process)
if (process)
process->GetTarget().GetFrameRecognizerManager().AddRecognizer(
StackFrameRecognizerSP(new LibCXXFrameRecognizer()), {},
-std::make_shared("^std::__1::"),
-/*f
@@ -1049,7 +1049,7 @@ let Command = "thread backtrace" in {
def thread_backtrace_extended : Option<"extended", "e">, Group<1>,
Arg<"Boolean">, Desc<"Show the extended backtrace, if available">;
def thread_backtrace_unfiltered : Option<"unfiltered", "u">, Group<1>,
- Desc
@@ -145,6 +167,17 @@
StackFrameRecognizerManager::GetRecognizerForFrame(StackFrameSP frame) {
if (!entry.module_regexp->Execute(module_name.GetStringRef()))
continue;
+ConstString function_name = [&]() {
+ switch (entry.mangling_preference) {
+ cas
@@ -927,6 +928,32 @@ class CommandObjectFrameRecognizerClear : public
CommandObjectParsed {
}
};
+static void
+PrintRecognizerDetails(Stream &strm, const std::string &module,
+ llvm::ArrayRef symbols,
+ Mangled::NamePreference pre
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/105695
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -145,6 +167,17 @@
StackFrameRecognizerManager::GetRecognizerForFrame(StackFrameSP frame) {
if (!entry.module_regexp->Execute(module_name.GetStringRef()))
continue;
+ConstString function_name = [&]() {
+ switch (entry.mangling_preference) {
+ cas
@@ -145,6 +167,17 @@
StackFrameRecognizerManager::GetRecognizerForFrame(StackFrameSP frame) {
if (!entry.module_regexp->Execute(module_name.GetStringRef()))
continue;
+ConstString function_name = [&]() {
+ switch (entry.mangling_preference) {
+ cas
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/105695
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/slydiman edited
https://github.com/llvm/llvm-project/pull/104797
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/105745
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/slydiman edited
https://github.com/llvm/llvm-project/pull/104787
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -145,6 +167,17 @@
StackFrameRecognizerManager::GetRecognizerForFrame(StackFrameSP frame) {
if (!entry.module_regexp->Execute(module_name.GetStringRef()))
continue;
+ConstString function_name = [&]() {
+ switch (entry.mangling_preference) {
+ cas
@@ -92,11 +95,13 @@ void StackFrameRecognizerManager::ForEach(
symbol_name = entry.symbol_regexp->GetText().str();
callback(entry.recognizer_id, entry.recognizer->GetName(), module_name,
- llvm::ArrayRef(ConstString(symbol_name)), true);
+
Author: Adrian Prantl
Date: 2024-08-23T09:25:24-07:00
New Revision: fd7904a07bc26950fa7735fb6871a064e3ebc836
URL:
https://github.com/llvm/llvm-project/commit/fd7904a07bc26950fa7735fb6871a064e3ebc836
DIFF:
https://github.com/llvm/llvm-project/commit/fd7904a07bc26950fa7735fb6871a064e3ebc836.diff
adrian-prantl wrote:
@gribozavr Thanks for pointing this out. This is funny: I forgot to initialize
the generation counter in StackFrame. I didn't notice because this actually
doesn't cause a bug; it just needs to increment and wrap around so the starting
position doesn't matter.
https://git
https://github.com/adrian-prantl closed
https://github.com/llvm/llvm-project/pull/105756
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
adrian-prantl wrote:
Retiring in favor of https://github.com/llvm/llvm-project/pull/105695/.
https://github.com/llvm/llvm-project/pull/105756
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb
@@ -92,11 +95,13 @@ void StackFrameRecognizerManager::ForEach(
symbol_name = entry.symbol_regexp->GetText().str();
callback(entry.recognizer_id, entry.recognizer->GetName(), module_name,
- llvm::ArrayRef(ConstString(symbol_name)), true);
+
Author: Adrian Prantl
Date: 2024-08-23T11:06:01-07:00
New Revision: b7c1be1a7f49539ea644ff3fd8b55f237e37b35e
URL:
https://github.com/llvm/llvm-project/commit/b7c1be1a7f49539ea644ff3fd8b55f237e37b35e
DIFF:
https://github.com/llvm/llvm-project/commit/b7c1be1a7f49539ea644ff3fd8b55f237e37b35e.diff
Author: Adrian Prantl
Date: 2024-08-23T11:06:01-07:00
New Revision: 3c0fba4f2471cacb27d787c7d8f54f21d9dcafae
URL:
https://github.com/llvm/llvm-project/commit/3c0fba4f2471cacb27d787c7d8f54f21d9dcafae
DIFF:
https://github.com/llvm/llvm-project/commit/3c0fba4f2471cacb27d787c7d8f54f21d9dcafae.diff
Author: Adrian Prantl
Date: 2024-08-23T11:06:01-07:00
New Revision: 9e9e8238df63b9f10c6635d3f16d8a0fbc7f00c4
URL:
https://github.com/llvm/llvm-project/commit/9e9e8238df63b9f10c6635d3f16d8a0fbc7f00c4
DIFF:
https://github.com/llvm/llvm-project/commit/9e9e8238df63b9f10c6635d3f16d8a0fbc7f00c4.diff
Author: Adrian Prantl
Date: 2024-08-23T11:06:01-07:00
New Revision: ad7577524286ae6070dc7f18bde35cf050d31e5e
URL:
https://github.com/llvm/llvm-project/commit/ad7577524286ae6070dc7f18bde35cf050d31e5e
DIFF:
https://github.com/llvm/llvm-project/commit/ad7577524286ae6070dc7f18bde35cf050d31e5e.diff
Author: Adrian Prantl
Date: 2024-08-23T11:06:02-07:00
New Revision: 11d2de436cbab8667fe1f99d7b538e6fb555b4d7
URL:
https://github.com/llvm/llvm-project/commit/11d2de436cbab8667fe1f99d7b538e6fb555b4d7
DIFF:
https://github.com/llvm/llvm-project/commit/11d2de436cbab8667fe1f99d7b538e6fb555b4d7.diff
@@ -92,11 +95,13 @@ void StackFrameRecognizerManager::ForEach(
symbol_name = entry.symbol_regexp->GetText().str();
callback(entry.recognizer_id, entry.recognizer->GetName(), module_name,
- llvm::ArrayRef(ConstString(symbol_name)), true);
+
JDevlieghere wrote:
There's a few things I don't really like about this patch:
- It's very specific to a single plugin.
- It sidesteps the plugin's `Initialize/Terminate` paradigm. It happens to
work because `ScriptInterpreterPython::Terminate` is a NOOP (see the comment
for `ScriptInterpr
https://github.com/felipepiovezan created
https://github.com/llvm/llvm-project/pull/105873
The existing algorithm was performing the following comparisons for an
`aaa,bbb,ccc,ddd`:
aaa\0bbb,ccc,ddd == "stack"
aaa\0bbb\0ccc,ddd == "stack"
aaa\0bbb\0ccc\0ddd == "stack"
Which wouldn't work. This
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Felipe de Azevedo Piovezan (felipepiovezan)
Changes
The existing algorithm was performing the following comparisons for an
`aaa,bbb,ccc,ddd`:
aaa\0bbb,ccc,ddd == "stack"
aaa\0bbb\0ccc,ddd == "stack"
aaa\0bbb\0ccc\0ddd == "stack"
Which wou
https://github.com/jasonmolenda approved this pull request.
Thanks for fixing this, looks perfect.
https://github.com/llvm/llvm-project/pull/105873
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinf
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff aec3ec04ac611f9a3d1e1ad075d50f62c1d1a1e2
8ef8ecdc8d87d474b906835d04ffdd9a19216406 --e
Author: Adrian Prantl
Date: 2024-08-23T12:09:19-07:00
New Revision: a0fac6f2d868316a88aa5b62963e26dca9bfa372
URL:
https://github.com/llvm/llvm-project/commit/a0fac6f2d868316a88aa5b62963e26dca9bfa372
DIFF:
https://github.com/llvm/llvm-project/commit/a0fac6f2d868316a88aa5b62963e26dca9bfa372.diff
adrian-prantl wrote:
I reverted the reverts and pushed two commits to fix the missing initialization.
https://github.com/llvm/llvm-project/pull/104523
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/list
Jlalond wrote:
@Michael137 implemented your feedback, and I got gcf to work. I'm going to let
CI run and then merge. Thanks for your patience!
https://github.com/llvm/llvm-project/pull/102708
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
h
Da-Viper wrote:
This is what is shown when I return undefined from the
createDebugAdapterDescriptor function
If I also throw ```vscode.FileSystemError.FileExists(`Debug pat
https://github.com/Da-Viper updated
https://github.com/llvm/llvm-project/pull/104711
>From 2cda519a06d46bd6a5ae02e8be8daacb39a49b3e Mon Sep 17 00:00:00 2001
From: Ezike Ebuka
Date: Thu, 22 Aug 2024 01:42:17 +0100
Subject: [PATCH 1/3] Rebase and add check dap path on config change
---
.../lldb
danobi wrote:
Hi @JDevlieghere , thanks for taking a look at this.
I'm not very familiar with lldb in general so I can't comment much on
alternatives. Lazy loading does some fairly reasonable to me but I don't know
what kind of code changes that'd require.
The motivation behind this change s
felipepiovezan wrote:
Since this is mostly uncontroversial, I am going to go ahead and merge it now.
Happy to address feedback in post!
https://github.com/llvm/llvm-project/pull/105873
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https:/
https://github.com/felipepiovezan updated
https://github.com/llvm/llvm-project/pull/105873
>From fbe4fdfb0e804c281ed5c52382ef4bb16ec9fce5 Mon Sep 17 00:00:00 2001
From: Felipe de Azevedo Piovezan
Date: Fri, 23 Aug 2024 11:43:16 -0700
Subject: [PATCH] [GDBRemote] Fix processing of comma-separate
felipepiovezan wrote:
Fixed clang format issue
https://github.com/llvm/llvm-project/pull/105873
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Felipe de Azevedo Piovezan
Date: 2024-08-23T13:09:31-07:00
New Revision: 8b4147d14c460f8886e882db48361d4c101917d7
URL:
https://github.com/llvm/llvm-project/commit/8b4147d14c460f8886e882db48361d4c101917d7
DIFF:
https://github.com/llvm/llvm-project/commit/8b4147d14c460f8886e882db48361d4c1
https://github.com/felipepiovezan closed
https://github.com/llvm/llvm-project/pull/105873
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan created
https://github.com/llvm/llvm-project/pull/105883
This should cause the memory region info "is stack" field to be set to "no".
>From 0730cd7f48dd4b80fba0275fed9beadcf6193987 Mon Sep 17 00:00:00 2001
From: Felipe de Azevedo Piovezan
Date: Fri, 23 Aug 202
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Felipe de Azevedo Piovezan (felipepiovezan)
Changes
This should cause the memory region info "is stack" field to be set to "no".
---
Full diff: https://github.com/llvm/llvm-project/pull/105883.diff
2 Files Affected:
- (modified)
lldb/so
https://github.com/jasonmolenda approved this pull request.
Looks good!
https://github.com/llvm/llvm-project/pull/105883
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kastiglione approved this pull request.
https://github.com/llvm/llvm-project/pull/105883
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1635,6 +1635,8 @@ Status GDBRemoteCommunicationClient::GetMemoryRegionInfo(
for (llvm::StringRef entry : llvm::split(value, ',')) {
if (entry == "stack")
region_info.SetIsStackMemory(MemoryRegionInfo::eYes);
+if (entry == "hea
https://github.com/walter-erquinigo approved this pull request.
Thanks for the screenshot, man!
https://github.com/llvm/llvm-project/pull/104711
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/l
https://github.com/jasonmolenda created
https://github.com/llvm/llvm-project/pull/105890
For supported architectures, lldb will do a static scan of the assembly
instructions of a function to detect stack/frame pointer changes, register
stores and loads, so we can retrieve register values for t
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jason Molenda (jasonmolenda)
Changes
For supported architectures, lldb will do a static scan of the assembly
instructions of a function to detect stack/frame pointer changes, register
stores and loads, so we can retrieve register values fo
jasonmolenda wrote:
This has always been a small perf issue with stripped binaries, but there is an
unusual case where it became a big problem: wine, the windows environment, has
a symbol at a low address like 0x1000, and it reserves the first 4GB of address
space to load 32-bit windows binar
@@ -562,17 +562,22 @@ Status ProcessMachCore::DoLoadCore() {
SetCanJIT(false);
- // The corefile's architecture is our best starting point.
- ArchSpec arch(m_core_module_sp->GetArchitecture());
- if (arch.IsValid())
-GetTarget().SetArchitecture(arch);
-
CreateMemo
@@ -145,6 +167,17 @@
StackFrameRecognizerManager::GetRecognizerForFrame(StackFrameSP frame) {
if (!entry.module_regexp->Execute(module_name.GetStringRef()))
continue;
+ConstString function_name = [&]() {
+ switch (entry.mangling_preference) {
+ cas
https://github.com/ashgti created
https://github.com/llvm/llvm-project/pull/105905
Refactoring `stackTrace` to perform frame look ups in a more on-demand fashion
to improve overall performance.
Additionally adding additional information to the `exceptionInfo` request to
report exception stack
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: John Harrison (ashgti)
Changes
Refactoring `stackTrace` to perform frame look ups in a more on-demand fashion
to improve overall performance.
Additionally adding additional information to the `exceptionInfo` request to
report exception st
ashgti wrote:
This was based on the comments in
https://github.com/llvm/llvm-project/pull/104874
LMKWYT
https://github.com/llvm/llvm-project/pull/105905
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/105905
>From 7641ce09208883f205c9a9deb19bae9d01f8cd70 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Fri, 23 Aug 2024 16:04:44 -0700
Subject: [PATCH 1/2] [lldb-dap] Improve `stackTrace` and `exceptionInfo` DAP
requ
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/105905
>From 7641ce09208883f205c9a9deb19bae9d01f8cd70 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Fri, 23 Aug 2024 16:04:44 -0700
Subject: [PATCH 1/3] [lldb-dap] Improve `stackTrace` and `exceptionInfo` DAP
requ
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/105905
>From 7641ce09208883f205c9a9deb19bae9d01f8cd70 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Fri, 23 Aug 2024 16:04:44 -0700
Subject: [PATCH 1/4] [lldb-dap] Improve `stackTrace` and `exceptionInfo` DAP
requ
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/105905
>From ebcf4842c7d6c5ac0da4976c9cffb68bc3b22807 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Fri, 23 Aug 2024 16:04:44 -0700
Subject: [PATCH 1/4] [lldb-dap] Improve `stackTrace` and `exceptionInfo` DAP
requ
jeffreytan81 wrote:
As another data point, I just encountered a telemetry data from a customer.
Taking profile trace from that session shows "stackTrace" request takes more
than 4 seconds. Around 94% of the time was spent in this hot path performing
function evaluation:
```
ll
jeffreytan81 wrote:
And just for fun, here is an extreme one with 18 seconds of sampling time,
99.6% time is from this hot path. Note: they are all from linux machines
because we only enable perf sampling by default for linux platform so we have
no Mac data.
```
# time of first sample : 26469
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/105765
>From 6a27ad3be748a6072014a805a5a94dede9321432 Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Thu, 22 Aug 2024 18:29:55 -0700
Subject: [PATCH 1/2] [lldb] Remove limit on max memory read size
`memory re
jasonmolenda wrote:
Updated patch to a hex constant in the .td file as per Ismail's suggestion,
fixed the new TestMemoryReadMaximumSize.py test to work with the new default.
https://github.com/llvm/llvm-project/pull/105765
___
lldb-commits mailing lis
https://github.com/medismailben approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/105765
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jasonmolenda wrote:
both of the linux PR tests failed in Unwind/trap_frame_sym_ctx.test, I could
have sworn the only test failure I had before was in
TestMemoryReadMaximumSize.py, I don't see how this PR breaks that test case.
Hmm.
https://github.com/llvm/llvm-project/pull/105765
medismailben wrote:
> both of the linux PR tests failed in Unwind/trap_frame_sym_ctx.test, I could
> have sworn the only test failure I had before was in
> TestMemoryReadMaximumSize.py, I don't see how this PR breaks that test case.
> Hmm.
I believe that failure is unrelated to your PR since
jasonmolenda wrote:
> > both of the linux PR tests failed in Unwind/trap_frame_sym_ctx.test, I
> > could have sworn the only test failure I had before was in
> > TestMemoryReadMaximumSize.py, I don't see how this PR breaks that test
> > case. Hmm.
>
> I believe that failure is unrelated to yo
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/105765
>From 6a27ad3be748a6072014a805a5a94dede9321432 Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Thu, 22 Aug 2024 18:29:55 -0700
Subject: [PATCH 1/2] [lldb] Remove limit on max memory read size
`memory re
73 matches
Mail list logo
