https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/104817
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jh7370 commented:
Looks reasonable to me, but I think it would be worth highlighting in the text
the difference between -e and -v, so that people doing code archaelogy don't
have to look up cat options.
Probably should get an lldb maintainer to approve though.
https://githu
https://github.com/petrhosek approved this pull request.
LGTM but I'd wait for @JDevlieghere to respond.
https://github.com/llvm/llvm-project/pull/104878
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/l
@@ -1,3 +1,14 @@
+include(CheckSymbolExists)
+include(CMakePushCheckState)
+
+cmake_push_check_state()
+set(CMAKE_REQUIRED_DEFINITIONS -D_GNU_SOURCE)
+check_symbol_exists(gettid "unistd.h" HAVE_GETTID)
+if(HAVE_GETTID)
+ add_compile_definitions(-DHAVE_GETTID)
pet
https://github.com/petrhosek approved this pull request.
https://github.com/llvm/llvm-project/pull/104831
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
> The code format test passed but, I see some new failures (mostly in lldb-api
> and some in lldb-shell), which were not there in the previous run.
Not sure if you mean in the GitHub CI or locally, but either way I doubt they
are due to your change. I'll see what the curre
DavidSpickett wrote:
(and I will merge this once I see that CI is happy, or unhappy in a way not
related to your changes)
https://github.com/llvm/llvm-project/pull/104679
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org
DavidSpickett wrote:
I think Jonas might be on vacation at the moment, I can do a reasonable
impression in the meantime :)
For GNU cat, `-e` is equivalent to `-eV`. `e` prints the non-printable
characters and `v` puts `$` on the end of the line.
```
-e equivalent to -vE
<...>
-E, --show-en
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/104878
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
And I just edited the title slightly, since this is changing an lldb test not
llvm-lit itself.
https://github.com/llvm/llvm-project/pull/104878
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-b
https://github.com/DavidSpickett approved this pull request.
https://github.com/llvm/llvm-project/pull/104878
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett approved this pull request.
https://github.com/llvm/llvm-project/pull/104679
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Dhruv Srivastava
Date: 2024-08-20T10:19:32+01:00
New Revision: b804516dc5cf2bb99ff02aa49f9d4da76d721ea9
URL:
https://github.com/llvm/llvm-project/commit/b804516dc5cf2bb99ff02aa49f9d4da76d721ea9
DIFF:
https://github.com/llvm/llvm-project/commit/b804516dc5cf2bb99ff02aa49f9d4da76d721ea9.di
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/104679
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
github-actions[bot] wrote:
@DhruvSrivastavaX Congratulations on having your first Pull Request (PR) merged
into the LLVM Project!
Your changes will be combined with recent changes from other authors, then
tested
by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with
https://github.com/vogelsgesang edited
https://github.com/llvm/llvm-project/pull/99736
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DhruvSrivastavaX wrote:
Ok thats a relief to hear.
> Not sure if you mean in the GitHub CI or locally
Yes I was referring to the Github CI right now.
Great, The first PR is happily merged.
Thanks alot for all of the help and inputs!!
We can now get started with the rest of the PRs since I g
https://github.com/slydiman created
https://github.com/llvm/llvm-project/pull/104918
This test is already disabled for Windows because of symlinks. Disable it for
cross build on Windows host too.
>From e6e607af0288d0102751487d4851e133eab2244c Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Dat
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dmitry Vasilyev (slydiman)
Changes
This test is already disabled for Windows because of symlinks. Disable it for
cross build on Windows host too.
---
Full diff: https://github.com/llvm/llvm-project/pull/104918.diff
1 Files Affected:
- (
https://github.com/DavidSpickett approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/104918
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/slydiman updated
https://github.com/llvm/llvm-project/pull/104918
>From dd5070e26b41f6022f09b797772378076348298b Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Tue, 20 Aug 2024 16:11:53 +0400
Subject: [PATCH] [lldb][Windows] Fixed the API test
breakpoint_with_realpath_
Author: Dmitry Vasilyev
Date: 2024-08-20T17:25:34+04:00
New Revision: fc044901a2b8ae277b62bdde9140917913bd1644
URL:
https://github.com/llvm/llvm-project/commit/fc044901a2b8ae277b62bdde9140917913bd1644
DIFF:
https://github.com/llvm/llvm-project/commit/fc044901a2b8ae277b62bdde9140917913bd1644.dif
https://github.com/slydiman closed
https://github.com/llvm/llvm-project/pull/104918
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/slydiman created
https://github.com/llvm/llvm-project/pull/105037
This test causes the assert in clang CodeGen and python crashes with the error
code 0x8003. See #105019 for more details. Note the similar test
lldb/test/API/lang/c/bitfields/TestBitfields.py is already di
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dmitry Vasilyev (slydiman)
Changes
This test causes the assert in clang CodeGen and python crashes with the error
code 0x8003. See #105019 for more details. Note the similar test
lldb/test/API/lang/c/bitfields/TestBitfields.py is alrea
walter-erquinigo wrote:
@ashgti , do you have any opinions on this?
https://github.com/llvm/llvm-project/pull/104874
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo requested changes to this pull request.
@jeffreytan81 , could you make the default to be true if the current platform
is Mac? The extension should just work nicely for the 99% of people who don't
use massive binaries.
https://github.com/llvm/llvm-project/pul
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/104523
>From ece2b891557ee8323ff7d2d67b66cb01d06502a9 Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Thu, 15 Aug 2024 16:18:33 -0700
Subject: [PATCH] [lldb] Extend frame recognizers to hide frames from
backt
adrian-prantl wrote:
Implemented StepOut.
https://github.com/llvm/llvm-project/pull/104523
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/104799
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/104817
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/connieyzhu edited
https://github.com/llvm/llvm-project/pull/104878
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/connieyzhu edited
https://github.com/llvm/llvm-project/pull/104878
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
connieyzhu wrote:
> Looks reasonable to me, but I think it would be worth highlighting in the
> text the difference between -e and -v, so that people doing code archaelogy
> don't have to look up cat options.
I just added the option description in the PR description - thanks for the
feedback!
connieyzhu wrote:
> And I edited the title slightly, since this is changing an lldb test not
> llvm-lit itself.
Totally missed that somehow, thank you for the fix!
https://github.com/llvm/llvm-project/pull/104878
___
lldb-commits mailing list
lldb-co
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/104523
>From 81af1010aad7f6ab1abcf397c81245e53cc29adc Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Thu, 15 Aug 2024 16:18:33 -0700
Subject: [PATCH] [lldb] Extend frame recognizers to hide frames from
backt
dzhidzhoev wrote:
Now this is ready for review.
https://github.com/llvm/llvm-project/pull/102185
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/connieyzhu edited
https://github.com/llvm/llvm-project/pull/104878
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/connieyzhu edited
https://github.com/llvm/llvm-project/pull/104878
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/104896
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/104896
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Michael Buch
Date: 2024-08-20T18:40:54+01:00
New Revision: 770cd24140038646539602406fff54497793dae8
URL:
https://github.com/llvm/llvm-project/commit/770cd24140038646539602406fff54497793dae8
DIFF:
https://github.com/llvm/llvm-project/commit/770cd24140038646539602406fff54497793dae8.diff
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/104799
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/104817
>From 4bb7f6495a2fbf46e01b9f01c46d335d2b680afd Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Mon, 19 Aug 2024 17:39:44 +0100
Subject: [PATCH 1/3] [lldb][ClangExpressionParser] Implement
ExternalSemaSourc
Author: Michael Buch
Date: 2024-08-20T18:42:46+01:00
New Revision: 8056d92bc201906edbb27f4efa1cc80a18359880
URL:
https://github.com/llvm/llvm-project/commit/8056d92bc201906edbb27f4efa1cc80a18359880
DIFF:
https://github.com/llvm/llvm-project/commit/8056d92bc201906edbb27f4efa1cc80a18359880.diff
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/104817
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Med Ismail Bennani
Date: 2024-08-20T10:47:06-07:00
New Revision: 356533246aa33db44c75afb2d3eb6e0e08f0d7a6
URL:
https://github.com/llvm/llvm-project/commit/356533246aa33db44c75afb2d3eb6e0e08f0d7a6
DIFF:
https://github.com/llvm/llvm-project/commit/356533246aa33db44c75afb2d3eb6e0e08f0d7a6.
https://github.com/medismailben closed
https://github.com/llvm/llvm-project/pull/104896
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/105037
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
@DavidSpickett nailed it.
PS: I'm around but I've been busy with other stuff. If people start to think
I'm on vacation I really gotta step it up again :D
https://github.com/llvm/llvm-project/pull/104878
___
lldb-commits mailing
@@ -17,6 +17,7 @@
#include "lldb/lldb-private-forward.h"
#include "lldb/lldb-public.h"
+#include <_types/_uint16_t.h>
bulbazord wrote:
Is this header portable? If you want access to `uint16_t` I'd recommend
including `cinttypes` instead.
https://github.com/
@@ -278,6 +278,29 @@ class CommandObjectFrameSelect : public
CommandObjectParsed {
if (frame_idx == UINT32_MAX)
frame_idx = 0;
+ // If moving up/down by one, skip over hidden frames.
+ if (*m_options.relative_frame_offset == 1 ||
+ *m_options.
@@ -40,8 +41,49 @@ static ConstString g_coro_frame =
ConstString("__coro_frame");
char CPPLanguageRuntime::ID = 0;
+/// A frame recognizer that is installed to hide libc++ implementation
+/// details from the backtrace.
+class LibCXXFrameRecognizer : public StackFrameRecogni
@@ -40,8 +41,49 @@ static ConstString g_coro_frame =
ConstString("__coro_frame");
char CPPLanguageRuntime::ID = 0;
+/// A frame recognizer that is installed to hide libc++ implementation
+/// details from the backtrace.
+class LibCXXFrameRecognizer : public StackFrameRecogni
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/104878
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Dmitry Vasilyev
Date: 2024-08-20T22:26:49+04:00
New Revision: 31e55d461693df035049e09cbeeb8886ca2cb6d3
URL:
https://github.com/llvm/llvm-project/commit/31e55d461693df035049e09cbeeb8886ca2cb6d3
DIFF:
https://github.com/llvm/llvm-project/commit/31e55d461693df035049e09cbeeb8886ca2cb6d3.dif
https://github.com/slydiman closed
https://github.com/llvm/llvm-project/pull/105037
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
Thanks!
https://github.com/llvm/llvm-project/pull/104831
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/94844
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1316,6 +1316,7 @@ std::string GDBRemoteCommunication::ExpandRLE(std::string
packet) {
} else {
decoded.push_back(*c);
}
+c++;
bulbazord wrote:
Having the `c++` here is equivalent to having it in the "increment" portion of
the for loop c
@@ -1316,6 +1316,7 @@ std::string GDBRemoteCommunication::ExpandRLE(std::string
packet) {
} else {
bulbazord wrote:
I can't comment on it for some reason, but above this else is an `else if (*c
== 0x7d)`. That block also does `*++c`, which will also go out
francisvm wrote:
Why is this riscv64-only?
https://github.com/llvm/llvm-project/pull/104547
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/104523
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere commented:
Mostly nits.
https://github.com/llvm/llvm-project/pull/104523
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -38,13 +42,21 @@
ScriptedStackFrameRecognizer::RecognizeFrame(lldb::StackFrameSP frame) {
ValueObjectListSP args =
m_interpreter->GetRecognizedArguments(m_python_object_sp, frame);
auto args_synthesized = ValueObjectListSP(new ValueObjectList());
- for (const aut
@@ -518,33 +523,33 @@ class StackFrame : public ExecutionContextScope,
bool HasCachedData() const;
private:
- // For StackFrame only
+ /// For StackFrame only.
JDevlieghere wrote:
Since you're touching this comment...
https://github.com/llvm/llvm-projec
@@ -123,8 +126,13 @@ class StackFrameRecognizerManager {
lldb::StackFrameRecognizerSP GetRecognizerForFrame(lldb::StackFrameSP frame);
lldb::RecognizedStackFrameSP RecognizeFrame(lldb::StackFrameSP frame);
+ /// This number changes whenever the list of recognizers has bee
@@ -518,33 +523,33 @@ class StackFrame : public ExecutionContextScope,
bool HasCachedData() const;
private:
- // For StackFrame only
+ /// For StackFrame only.
lldb::ThreadWP m_thread_wp;
uint32_t m_frame_index;
uint32_t m_concrete_frame_index;
lldb::RegisterCo
@@ -1202,6 +1202,19 @@ bool SBFrame::IsArtificial() const {
return false;
}
+bool SBFrame::IsHidden() const {
+ LLDB_INSTRUMENT_VA(this);
+
+ std::unique_lock lock;
+ ExecutionContext exe_ctx(m_opaque_sp.get(), lock);
+
+ StackFrame *frame = exe_ctx.GetFramePtr();
+ if
@@ -1208,7 +1208,8 @@ bool SBThread::GetStatus(SBStream &status) const {
ExecutionContext exe_ctx(m_opaque_sp.get(), lock);
if (exe_ctx.HasThreadScope()) {
-exe_ctx.GetThreadPtr()->GetStatus(strm, 0, 1, 1, true);
+exe_ctx.GetThreadPtr()->GetStatus(strm, 0, 1, 1, tr
@@ -17,6 +17,7 @@
#include "lldb/lldb-private-forward.h"
#include "lldb/lldb-public.h"
+#include <_types/_uint16_t.h>
JDevlieghere wrote:
+1, this looks fishy. `cstdint` or `cinttypes` should do.
https://github.com/llvm/llvm-project/pull/104523
@@ -40,8 +41,49 @@ static ConstString g_coro_frame =
ConstString("__coro_frame");
char CPPLanguageRuntime::ID = 0;
+/// A frame recognizer that is installed to hide libc++ implementation
+/// details from the backtrace.
+class LibCXXFrameRecognizer : public StackFrameRecogni
Author: Connie Zhu
Date: 2024-08-20T11:54:17-07:00
New Revision: 6558e04f02858bff61c01c9ec0900849fc8532f5
URL:
https://github.com/llvm/llvm-project/commit/6558e04f02858bff61c01c9ec0900849fc8532f5
DIFF:
https://github.com/llvm/llvm-project/commit/6558e04f02858bff61c01c9ec0900849fc8532f5.diff
LO
https://github.com/ilovepi closed
https://github.com/llvm/llvm-project/pull/104878
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
31e55d461693df035049e09cbeeb8886ca2cb6d3...7e221825b8537f69e19cf366c446d9a09a4768fe
lldb
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 31e55d461693df035049e09cbeeb8886ca2cb6d3
7e221825b8537f69e19cf366c446d9a09a4768fe --e
https://github.com/santhoshe447 edited
https://github.com/llvm/llvm-project/pull/105278
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -17,6 +17,7 @@
#include "lldb/lldb-private-forward.h"
#include "lldb/lldb-public.h"
+#include <_types/_uint16_t.h>
adrian-prantl wrote:
That was clang-format.
https://github.com/llvm/llvm-project/pull/104523
___
@@ -1208,7 +1208,8 @@ bool SBThread::GetStatus(SBStream &status) const {
ExecutionContext exe_ctx(m_opaque_sp.get(), lock);
if (exe_ctx.HasThreadScope()) {
-exe_ctx.GetThreadPtr()->GetStatus(strm, 0, 1, 1, true);
+exe_ctx.GetThreadPtr()->GetStatus(strm, 0, 1, 1, tr
@@ -278,6 +278,29 @@ class CommandObjectFrameSelect : public
CommandObjectParsed {
if (frame_idx == UINT32_MAX)
frame_idx = 0;
+ // If moving up/down by one, skip over hidden frames.
+ if (*m_options.relative_frame_offset == 1 ||
+ *m_options.
@@ -40,8 +41,49 @@ static ConstString g_coro_frame =
ConstString("__coro_frame");
char CPPLanguageRuntime::ID = 0;
+/// A frame recognizer that is installed to hide libc++ implementation
+/// details from the backtrace.
+class LibCXXFrameRecognizer : public StackFrameRecogni
@@ -40,8 +41,49 @@ static ConstString g_coro_frame =
ConstString("__coro_frame");
char CPPLanguageRuntime::ID = 0;
+/// A frame recognizer that is installed to hide libc++ implementation
+/// details from the backtrace.
+class LibCXXFrameRecognizer : public StackFrameRecogni
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/104523
>From a27308d05fb651a50e92bb9f03a56d8ad424537f Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Thu, 15 Aug 2024 16:18:33 -0700
Subject: [PATCH] [lldb] Extend frame recognizers to hide frames from
backt
https://github.com/JDevlieghere approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/104523
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jacob Lalonde (Jlalond)
Changes
This patch adds the option to specify specific memory ranges to be included in
a given core file. The current implementation lets user specified ranges either
be in addition to a certain save style, or indep
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
c4bf949171a72383d5ba4d2b587d4cc496aacebb...001ed7aa004480e052d5aecf29c7ce8132c60d24
lldb
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff c4bf949171a72383d5ba4d2b587d4cc496aacebb
001ed7aa004480e052d5aecf29c7ce8132c60d24 --e
https://github.com/hawkinsw updated
https://github.com/llvm/llvm-project/pull/104831
>From 93949029c808e2e5991df2f3c498dcd008367c34 Mon Sep 17 00:00:00 2001
From: Will Hawkins
Date: Mon, 19 Aug 2024 14:43:45 -0400
Subject: [PATCH] [lldb][test] Workaround older systems that lack gettid
Older gl
hawkinsw wrote:
@petrhosek Just requesting another review because of the change that I made
after your feedback! I'm just being cautious. Sorry to bother you!
https://github.com/llvm/llvm-project/pull/104831
___
lldb-commits mailing list
lldb-commits@
Author: Michael Buch
Date: 2024-08-20T23:30:08+01:00
New Revision: 8d712b4e3f14fe0102a5065cbd5b758dc997b529
URL:
https://github.com/llvm/llvm-project/commit/8d712b4e3f14fe0102a5065cbd5b758dc997b529
DIFF:
https://github.com/llvm/llvm-project/commit/8d712b4e3f14fe0102a5065cbd5b758dc997b529.diff
ilovepi wrote:
@hawkinsw I think you're fine to land this. From what I can tell you've
addressed @petrhosek's comments. I work on the same team as him, so we'd like
to see our CI go green ASAP.
https://github.com/llvm/llvm-project/pull/104831
___
lld
https://github.com/adrian-prantl closed
https://github.com/llvm/llvm-project/pull/104523
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Adrian Prantl
Date: 2024-08-20T16:01:22-07:00
New Revision: f01f80ce6ca7640bb0e267b84b1ed0e89b57e2d9
URL:
https://github.com/llvm/llvm-project/commit/f01f80ce6ca7640bb0e267b84b1ed0e89b57e2d9
DIFF:
https://github.com/llvm/llvm-project/commit/f01f80ce6ca7640bb0e267b84b1ed0e89b57e2d9.diff
https://github.com/vogelsgesang created
https://github.com/llvm/llvm-project/pull/105446
This is a first draft PR which fixes #103021
The main issue was that the `instructionOffset` was handled as a byte offset
and not as an instruction offset.
This commit also incorporates previous feedback
https://github.com/petrhosek approved this pull request.
https://github.com/llvm/llvm-project/pull/104831
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
82ee31f75ac1316006fa9e21dddfddec37cf7072...b809f570dd8055e5b899c337ec9ff5110ab94c6e
lldb/
https://github.com/medismailben created
https://github.com/llvm/llvm-project/pull/105449
This patch introduces new `ScriptedStopHook{,Python}Interface` classes that
make use of the Scripted Interface infrastructure and makes use of it in
`StopHookScripted`.
It also relax the requirement on th
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Med Ismail Bennani (medismailben)
Changes
This patch introduces new `ScriptedStopHook{,Python}Interface` classes that
make use of the Scripted Interface infrastructure and makes use of it in
`StopHookScripted`.
It also relax the requireme
vogelsgesang wrote:
@clayborg I would be interested in your guidance for this PR, given that you
previously reviewed a similar change in https://reviews.llvm.org/D140358
I did use `SBFunction` / `SBSymbol` as suggested by you in [this
comment](https://reviews.llvm.org/D140358#4027551).
I did
https://github.com/ashgti created
https://github.com/llvm/llvm-project/pull/105456
Previously, when output like `"hello\nworld\n"` was produced by lldb (or the
process) the message would be sent as a single Output event. By being a single
event this causes VS Code to treat this as a single mes
1 - 100 of 120 matches
Mail list logo
