llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jacob Lalonde (Jlalond)
Changes
Reapply #100443 and #101770. These were originally reverted due
to a test failure and an MSAN failure. I changed the test attribute to restrict
to x86 (following the other existing tests). I could not reprod
https://github.com/clayborg commented:
Looks good, just one {} left, see inline comment.
https://github.com/llvm/llvm-project/pull/104109
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-com
@@ -318,6 +318,32 @@ Status ELFLinuxPrStatus::Parse(const DataExtractor &data,
return error;
}
+static struct compat_timeval
+copy_timespecs(const ProcessInstanceInfo::timespec &oth) {
+ using sec_t = decltype(compat_timeval::tv_sec);
+ using usec_t = decltype(compat_timev
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/104109
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -318,6 +318,32 @@ Status ELFLinuxPrStatus::Parse(const DataExtractor &data,
return error;
}
+static struct compat_timeval
+copy_timespecs(const ProcessInstanceInfo::timespec &oth) {
+ using sec_t = decltype(compat_timeval::tv_sec);
+ using usec_t = decltype(compat_timev
https://github.com/clayborg approved this pull request.
https://github.com/llvm/llvm-project/pull/104497
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
2ef553c05ffe274d6910e3d11f52ed6417cc5061...c22b85a11ccb024b3f56112fad3e8d96ed7be041
lldb
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 2ef553c05ffe274d6910e3d11f52ed6417cc5061
c22b85a11ccb024b3f56112fad3e8d96ed7be041 --e
clayborg wrote:
Please make a follow up patch to remove the use of PATH_MAX in the SmallString.
It isn't needed. Just set the value to 1024 and let the SmallString allocate on
the heap if it goes over.
https://github.com/llvm/llvm-project/pull/104493
__
https://github.com/royitaqi created
https://github.com/llvm/llvm-project/pull/104502
https://github.com/llvm/llvm-project/pull/102223 broke Windows build by using
`PATH_MAX` without defining it.
https://github.com/llvm/llvm-project/pull/104493 fixed it by including a header
file which defines
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (royitaqi)
Changes
https://github.com/llvm/llvm-project/pull/102223 broke Windows build by using
`PATH_MAX` without defining it.
https://github.com/llvm/llvm-project/pull/104493 fixed it by including a header
file which defines it.
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/104502
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -54,7 +53,7 @@ RealpathPrefixes::ResolveSymlinks(const FileSpec &file_spec) {
LLDB_LOGF(log, "Realpath'ing support file %s", file_spec_path.c_str());
// One prefix matched. Try to realpath.
- llvm::SmallString buff;
+ llvm::SmallString<1024> buff;
@@ -54,7 +53,7 @@ RealpathPrefixes::ResolveSymlinks(const FileSpec &file_spec) {
LLDB_LOGF(log, "Realpath'ing support file %s", file_spec_path.c_str());
// One prefix matched. Try to realpath.
- llvm::SmallString buff;
+ llvm::SmallString<1024> buff;
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/101086
>From 2860a75fdc243f55d1e675068f9d120fb43cb21d Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Fri, 26 Jul 2024 14:14:42 -0700
Subject: [PATCH] Remove 64b specific method and create Cache from both memory
32
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/104502
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/104502
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kendalharland created
https://github.com/llvm/llvm-project/pull/104514
In python 3.8 PATH is no longer used to search for DLLs on Windows. When
building Swift's patched version of LLDB this prevents LLDB from starting up,
because it cannot find DLLs like swiftCore.dll, cmark
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Kendal Harland (kendalharland)
Changes
In python 3.8 PATH is no longer used to search for DLLs on Windows. When
building Swift's patched version of LLDB this prevents LLDB from starting up,
because it cannot find DLLs like swiftCore.dll, c
https://github.com/kendalharland edited
https://github.com/llvm/llvm-project/pull/104514
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
royitaqi wrote:
After fixing the build break, this now shows a test failure in windows.
```
C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\lldb\unittests\Utility\FileSpecListTest.cpp(174):
error: Expected equality of these values:
ret
Which is: 4294967295
(size_t)0
Whic
https://github.com/royitaqi updated
https://github.com/llvm/llvm-project/pull/104502
>From 1e0e766530acffc29fef0b0b2cd909a943a92599 Mon Sep 17 00:00:00 2001
From: Roy Shi
Date: Thu, 15 Aug 2024 13:34:53 -0700
Subject: [PATCH 1/2] (lldb) (minor) Correctly fix a usage of PATH_MAX
---
lldb/sourc
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff c19326cb84e871e1dd77408c2911c7d1651ba34b
3813cf592c64f5ed3202fb76032c7f2d1ac91b83 --e
https://github.com/royitaqi updated
https://github.com/llvm/llvm-project/pull/104502
>From 1e0e766530acffc29fef0b0b2cd909a943a92599 Mon Sep 17 00:00:00 2001
From: Roy Shi
Date: Thu, 15 Aug 2024 13:34:53 -0700
Subject: [PATCH 1/3] (lldb) (minor) Correctly fix a usage of PATH_MAX
---
lldb/sourc
https://github.com/royitaqi updated
https://github.com/llvm/llvm-project/pull/104502
>From 1e0e766530acffc29fef0b0b2cd909a943a92599 Mon Sep 17 00:00:00 2001
From: Roy Shi
Date: Thu, 15 Aug 2024 13:34:53 -0700
Subject: [PATCH 1/4] (lldb) (minor) Correctly fix a usage of PATH_MAX
---
lldb/sourc
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/104502
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/104502
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/104502
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/104502
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -26,6 +27,8 @@ class Platform;
class ExecutionContext;
class RegisterFlags;
+typedef llvm::SmallString<128> PathSmallString;
clayborg wrote:
I would do 256 as a starting point for paths.
https://github.com/llvm/llvm-project/pull/104502
___
https://github.com/clayborg approved this pull request.
https://github.com/llvm/llvm-project/pull/104502
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/royitaqi updated
https://github.com/llvm/llvm-project/pull/104502
>From 1e0e766530acffc29fef0b0b2cd909a943a92599 Mon Sep 17 00:00:00 2001
From: Roy Shi
Date: Thu, 15 Aug 2024 13:34:53 -0700
Subject: [PATCH 1/5] (lldb) (minor) Correctly fix a usage of PATH_MAX
---
lldb/sourc
royitaqi wrote:
Two changes made:
1. Add typedef `lldb_private::PathSmallString` with initial size 256. Use it in
`RealpathPrefixes.cpp`.
2. Fix test errors in Windows (caused by by not specify WindowsSpec vs.
PosixSpec).
https://github.com/llvm/llvm-project/pull/104502
___
https://github.com/royitaqi updated
https://github.com/llvm/llvm-project/pull/104502
>From 1e0e766530acffc29fef0b0b2cd909a943a92599 Mon Sep 17 00:00:00 2001
From: Roy Shi
Date: Thu, 15 Aug 2024 13:34:53 -0700
Subject: [PATCH 1/6] (lldb) (minor) Correctly fix a usage of PATH_MAX
---
lldb/sourc
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/104502
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jacob Lalonde
Date: 2024-08-15T16:29:59-07:00
New Revision: 572943e79080962cd70d30fe58a17a8bd0579fd7
URL:
https://github.com/llvm/llvm-project/commit/572943e79080962cd70d30fe58a17a8bd0579fd7
DIFF:
https://github.com/llvm/llvm-project/commit/572943e79080962cd70d30fe58a17a8bd0579fd7.diff
https://github.com/Jlalond closed
https://github.com/llvm/llvm-project/pull/104497
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl created
https://github.com/llvm/llvm-project/pull/104523
Compilers and language runtimes often use helper functions that are
fundamentally uninteresting when debugging anything but the compiler/runtime
itself. This patch introduces a user-extensible mechanism t
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Adrian Prantl (adrian-prantl)
Changes
Compilers and language runtimes often use helper functions that are
fundamentally uninteresting when debugging anything but the compiler/runtime
itself. This patch introduces a user-extensible mechanis
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff ae059a1f9f1e501b08a99cb636ec0869ec204c6f
6289b797e6699c356c03caf32a4b74a5e2ee3278 --e
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
ae059a1f9f1e501b08a99cb636ec0869ec204c6f...6289b797e6699c356c03caf32a4b74a5e2ee3278
lldb/
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/101086
>From 2860a75fdc243f55d1e675068f9d120fb43cb21d Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Fri, 26 Jul 2024 14:14:42 -0700
Subject: [PATCH 1/2] Remove 64b specific method and create Cache from both
memor
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 4e078e3797098daa40d254447c499bcf61415308
aab60b78229a26114a2e919039b6eb89fa56c352 --e
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/104523
>From 66292a2279cb66522932a4909a8382790da80060 Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Thu, 15 Aug 2024 16:18:33 -0700
Subject: [PATCH] [lldb] Extend frame recognizers to hide frames from
backt
@@ -553,53 +547,49 @@ static bool
CreateRegionsCacheFromMemoryList(MinidumpParser &parser,
std::vector ®ions) {
Log *log = GetLog(LLDBLog::Modules);
+ // Cache the expected memory32 into an optional
+ // because double checking the expected
https://github.com/clayborg commented:
Looks good to me. Lets give Pavel a day to respond, if not I will approve.
https://github.com/llvm/llvm-project/pull/101086
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/
Author: royitaqi
Date: 2024-08-15T17:24:39-07:00
New Revision: 26670e7fa4f032a019d23d56c6a02926e854e8af
URL:
https://github.com/llvm/llvm-project/commit/26670e7fa4f032a019d23d56c6a02926e854e8af
DIFF:
https://github.com/llvm/llvm-project/commit/26670e7fa4f032a019d23d56c6a02926e854e8af.diff
LOG:
https://github.com/royitaqi closed
https://github.com/llvm/llvm-project/pull/104502
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jasonmolenda commented:
The implementation is fine, but I have some questions about this. First,
SBFrame should have IsImplementationFrame or whatever terminology we use for
the user view of this, like we have IsInlined and IsArtificial today so a UI
can choose to omit thes
@@ -40,8 +41,49 @@ static ConstString g_coro_frame =
ConstString("__coro_frame");
char CPPLanguageRuntime::ID = 0;
+/// A frame recognizer that is isntalled to hide libc++ implementation
+/// details from the backtrace.
+class LibCXXFrameRecognizer : public StackFrameRecogni
https://github.com/jasonmolenda edited
https://github.com/llvm/llvm-project/pull/104523
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1048,6 +1048,9 @@ let Command = "thread backtrace" in {
Arg<"FrameIndex">, Desc<"Frame in which to start the backtrace">;
def thread_backtrace_extended : Option<"extended", "e">, Group<1>,
Arg<"Boolean">, Desc<"Show the extended backtrace, if available">;
+ def threa
@@ -40,8 +41,49 @@ static ConstString g_coro_frame =
ConstString("__coro_frame");
char CPPLanguageRuntime::ID = 0;
+/// A frame recognizer that is isntalled to hide libc++ implementation
jasonmolenda wrote:
installed
https://github.com/llvm/llvm-project/pu
@@ -979,6 +988,8 @@ size_t StackFrameList::GetStatus(Stream &strm, uint32_t
first_frame,
++num_frames_displayed;
}
+ if (filtered)
+strm << "Note: Some frames were hidden by frame recognizers\n";
jasonmolenda wrote:
Are we exposing the term "frame
jasonmolenda wrote:
Ah sorry was still writing and posted by accident.
For stepping we have a user exposed setting
`target.process.thread.step-avoid-regexp` which lldb uses to step over C++
inlined methods in your code, and allow the user to extend this to add it for
their own libraries. I k
@@ -979,6 +988,8 @@ size_t StackFrameList::GetStatus(Stream &strm, uint32_t
first_frame,
++num_frames_displayed;
}
+ if (filtered)
+strm << "Note: Some frames were hidden by frame recognizers\n";
medismailben wrote:
There is a `frame recognizer` m
https://github.com/jeffreytan81 created
https://github.com/llvm/llvm-project/pull/104532
This PR fixes another potential race condition in
https://github.com/llvm/llvm-project/pull/90930. The failure is found by
@labath with this log: https://paste.debian.net/hidden/30235a5c/.
The investigati
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (jeffreytan81)
Changes
This PR fixes another potential race condition in
https://github.com/llvm/llvm-project/pull/90930. The failure is found by @labath with this log: https://paste.debian.net/hidden/30235a5c/.
The investigation show
jeffreytan81 wrote:
https://github.com/llvm/llvm-project/pull/104532 should fix it.
The test runs under it for more than 10 iterations without failing. (It used to
fail under 4 iterations).
Sorry I wish I can find these issues before landing but we did not have any
infrastructure like buildbo
https://github.com/medismailben edited
https://github.com/llvm/llvm-project/pull/104523
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1048,6 +1048,9 @@ let Command = "thread backtrace" in {
Arg<"FrameIndex">, Desc<"Frame in which to start the backtrace">;
def thread_backtrace_extended : Option<"extended", "e">, Group<1>,
Arg<"Boolean">, Desc<"Show the extended backtrace, if available">;
+ def threa
@@ -91,7 +91,7 @@ class StackFrameList {
size_t GetStatus(Stream &strm, uint32_t first_frame, uint32_t num_frames,
bool show_frame_info, uint32_t num_frames_with_source,
- bool show_unique = false,
+ bool show_unique = f
https://github.com/medismailben commented:
I think this is a pretty cool idea but can we make sure it works using python
frame recognizers. I believe the user should also have the ability to hide
certain frames if they want, like it doesn't have to be system or language
runtime frames.
https:
https://github.com/jeffreytan81 edited
https://github.com/llvm/llvm-project/pull/104532
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/clayborg requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/104317
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1085,6 +1084,17 @@ std::string
VariableDescription::GetResult(llvm::StringRef context) {
return description.trim().str();
}
+std::optional GetMemoryReference(lldb::SBValue v) {
+ if (!v.GetType().IsPointerType() && !v.GetType().IsArrayType())
+return std::nullopt;
@@ -4028,6 +4049,154 @@ void request_disassemble(const llvm::json::Object
&request) {
response.try_emplace("body", std::move(body));
g_dap.SendJSON(llvm::json::Value(std::move(response)));
}
+
+// "ReadMemoryRequest": {
+// "allOf": [ { "$ref": "#/definitions/Request" },
medismailben wrote:
> `lldbPluginScriptInterpreterPythonScriptedThreadPlanPythonInterface` quite a
> mouthful for just a single cpp file. Maybe all of the interfaces could be a
> part of a single library?
>
> That would end up with something like:
>
> ```
> D:\build-lldb\tools\lldb\source\Plu
medismailben wrote:
Originally, they were built in a single library and I added a cmake variable to
make it work but @bulbazord & @JDevlieghere were not too happy with that
approach. I think their argument was that if they're each different plugins,
they need to be built into separate librarie
walter-erquinigo wrote:
This seems pretty cool!
Question: what would happen if the top frame (the one with the PC) gets
filtered out by the recognizer?
https://github.com/llvm/llvm-project/pull/104523
___
lldb-commits mailing list
lldb-commits@lists.
https://github.com/AlexeyMerzlyakov created
https://github.com/llvm/llvm-project/pull/104547
The PR adds the support optionally enabled/disabled FP-registers to LLDB
`RegisterInfoPOSIX_riscv64`. This situation might take place for RISC-V builds
have no FP-registers, like RV64IMAC or RV64IMACV.
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Alexey Merzlyakov (AlexeyMerzlyakov)
Changes
The PR adds the support optionally enabled/disabled FP-registers to LLDB
`RegisterInfoPOSIX_riscv64`. This situation might take place for RISC-V builds
have no FP-registers, like RV64IMAC or RV6
AlexeyMerzlyakov wrote:
The change - is a result of https://github.com/llvm/llvm-project/pull/93297
discussions about FP-register class refactoring
https://github.com/llvm/llvm-project/pull/104547
___
lldb-commits mailing list
lldb-commits@lists.llvm
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 43ffe2eed0d9f73789dbe213023733d164999306
f0dcd28876e3815454be3c9b2ae19cab26dede1e --e
https://github.com/AlexeyMerzlyakov updated
https://github.com/llvm/llvm-project/pull/104547
>From f0dcd28876e3815454be3c9b2ae19cab26dede1e Mon Sep 17 00:00:00 2001
From: Alexey Merzlyakov
Date: Thu, 15 Aug 2024 14:29:49 +0300
Subject: [PATCH 1/2] Support optionally disabled FPR
---
.../RISCV
https://github.com/AlexeyMerzlyakov edited
https://github.com/llvm/llvm-project/pull/104547
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
101 - 176 of 176 matches
Mail list logo
