https://github.com/nikic approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/102839
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Dhruv-Srivastava-IBM converted_to_draft
https://github.com/llvm/llvm-project/pull/102601
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/101272
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath approved this pull request.
This looks fine now, just please check what happened with one of the
suggestions I highlighted. Thanks for your patience.
https://github.com/llvm/llvm-project/pull/101272
___
lldb-commits mailing l
@@ -132,6 +140,92 @@ class MinidumpFile : public Binary {
size_t Stride;
};
+ /// Class the provides an iterator over the memory64 memory ranges. Only the
+ /// the first descriptor is validated as readable beforehand.
+ class Memory64Iterator {
+ public:
+static
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/102570
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath wrote:
Looks good, thanks. The structuring made it really easy to review.
https://github.com/llvm/llvm-project/pull/102570
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Dhruv-Srivastava-IBM edited
https://github.com/llvm/llvm-project/pull/102601
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Pavel Labath
Date: 2024-08-12T11:29:08+02:00
New Revision: 32a62ebdeab0c10d5311cf812e021717636d4514
URL:
https://github.com/llvm/llvm-project/commit/32a62ebdeab0c10d5311cf812e021717636d4514
DIFF:
https://github.com/llvm/llvm-project/commit/32a62ebdeab0c10d5311cf812e021717636d4514.diff
https://github.com/labath closed
https://github.com/llvm/llvm-project/pull/100577
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -97,12 +97,14 @@ void DWARFUnit::ExtractUnitDIEIfNeeded() {
*m_dwo_id, m_first_die.GetOffset()));
return; // Can't fetch the compile unit from the dwo file.
}
- // If the skeleton compile unit gets its unit DIE parsed first, then this
- // will fill in the DW
@@ -482,6 +482,13 @@ size_t ObjectFile::CopyData(lldb::offset_t offset, size_t
length,
return m_data.CopyData(offset, length, dst);
}
+llvm::ArrayRef ObjectFile::PeekData(lldb::addr_t offset,
+ size_t length) const {
+ const uint
https://github.com/xusheng6 created
https://github.com/llvm/llvm-project/pull/102873
This fixes https://github.com/llvm/llvm-project/issues/56125 and
https://github.com/vadimcn/codelldb/issues/666, as well as the downstream issue
in our binary ninja debugger: https://github.com/Vector35/debugg
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: xusheng (xusheng6)
Changes
This fixes https://github.com/llvm/llvm-project/issues/56125 and
https://github.com/vadimcn/codelldb/issues/666, as well as the downstream issue
in our binary ninja debugger: https://github.com/Vector35/debugger/
https://github.com/xusheng6 edited
https://github.com/llvm/llvm-project/pull/102873
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/102873
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -2349,6 +2349,9 @@ StateType
ProcessGDBRemote::SetThreadStopInfo(StringExtractor &stop_packet) {
if (!value.getAsInteger(0, addressing_bits)) {
addressable_bits.SetHighmemAddressableBits(addressing_bits);
}
+ } else if (key.compare("swbreak")
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 55d7e59023bc48f97321970cda5e400c07de59fa
73c98df4baef99f96d9c67113ba2ed0d972e5a04 --e
https://github.com/xusheng6 updated
https://github.com/llvm/llvm-project/pull/102873
>From 73c98df4baef99f96d9c67113ba2ed0d972e5a04 Mon Sep 17 00:00:00 2001
From: Xusheng
Date: Mon, 20 Mar 2023 20:24:11 +0800
Subject: [PATCH 1/3] [lldb] Claim to support swbreak and hwbreak packets when
debuggi
@@ -2349,6 +2349,9 @@ StateType
ProcessGDBRemote::SetThreadStopInfo(StringExtractor &stop_packet) {
if (!value.getAsInteger(0, addressing_bits)) {
addressable_bits.SetHighmemAddressableBits(addressing_bits);
}
+ } else if (key.compare("swbreak")
DavidSpickett wrote:
On the testing, lldb sends this qsupported value regardless of what the remote
sends. So there's nothing to do there unless you just repeat the feature list.
There are some tests that look at lldb-server's qsupported values, but I don't
see any for the client lldb.
You co
DavidSpickett wrote:
Also there is probably a qsupported parsing function in lldb-server, please add
a comment there to say we consume lldb's swbreak/hwbreak feature but it doesn't
change the behaviour of lldb-server.
https://github.com/llvm/llvm-project/pull/102873
___
@@ -2353,6 +2353,10 @@ StateType
ProcessGDBRemote::SetThreadStopInfo(StringExtractor &stop_packet) {
uint32_t reg = UINT32_MAX;
if (!key.getAsInteger(16, reg))
expedited_register_map[reg] = std::string(std::move(value));
+ } else if (key.compare(
Author: David Spickett
Date: 2024-08-12T11:03:06Z
New Revision: afe019ca93a72a5969d82cfff5018f3dd79dc75a
URL:
https://github.com/llvm/llvm-project/commit/afe019ca93a72a5969d82cfff5018f3dd79dc75a
DIFF:
https://github.com/llvm/llvm-project/commit/afe019ca93a72a5969d82cfff5018f3dd79dc75a.diff
LOG
@@ -0,0 +1,560 @@
+//===-- DILAST.cpp
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/95738
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath commented:
Even though you've removed the smart pointer checking function (the most
obvious example of language-specific behavior), I'm still worried about whether
the overall design of this code will allow you to avoid it.
Looking at the `IdentifierInfo` class, I see
@@ -0,0 +1,426 @@
+//===-- DILAST.h *- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,459 @@
+//===-- DILAST.h *- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,426 @@
+//===-- DILAST.h *- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,560 @@
+//===-- DILAST.cpp
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/labath approved this pull request.
This looks good. Thanks for your patience.
https://github.com/llvm/llvm-project/pull/101283
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/
Author: Pavel Labath
Date: 2024-08-12T14:31:14+02:00
New Revision: 21ef272ec1974244710fc639f98674eae3f8b02c
URL:
https://github.com/llvm/llvm-project/commit/21ef272ec1974244710fc639f98674eae3f8b02c
DIFF:
https://github.com/llvm/llvm-project/commit/21ef272ec1974244710fc639f98674eae3f8b02c.diff
https://github.com/labath closed
https://github.com/llvm/llvm-project/pull/102123
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath milestoned
https://github.com/llvm/llvm-project/pull/102116
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath wrote:
/cherry-pick
[57cd100](https://github.com/llvm/llvm-project/commit/57cd1000c9c93fd0e64352cfbc9fbbe5b8a8fcef)
https://github.com/llvm/llvm-project/pull/102116
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.or
llvmbot wrote:
Failed to cherry-pick:
[57cd100](https://github.com/llvm/llvm-project/commit/57cd1000c9c93fd0e64352cfbc9fbbe5b8a8fcef)
https://github.com/llvm/llvm-project/actions/runs/10352006063
Please manually backport the fix and push it to your github fork. Once this is
done, please cre
Author: David Spickett
Date: 2024-08-12T12:41:49Z
New Revision: f2991bd93146162bcc30bc5e8da8707074f3fdef
URL:
https://github.com/llvm/llvm-project/commit/f2991bd93146162bcc30bc5e8da8707074f3fdef
DIFF:
https://github.com/llvm/llvm-project/commit/f2991bd93146162bcc30bc5e8da8707074f3fdef.diff
LOG
labath wrote:
/cherry-pick 57cd100
https://github.com/llvm/llvm-project/pull/102116
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
/pull-request llvm/llvm-project#102895
https://github.com/llvm/llvm-project/pull/102116
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: David Spickett
Date: 2024-08-12T13:18:10Z
New Revision: 513c3726ebc0a324f7e5a11d25617bb9557324d6
URL:
https://github.com/llvm/llvm-project/commit/513c3726ebc0a324f7e5a11d25617bb9557324d6
DIFF:
https://github.com/llvm/llvm-project/commit/513c3726ebc0a324f7e5a11d25617bb9557324d6.diff
LOG
labath wrote:
The new test is still hanging occasionally (e.g.
https://lab.llvm.org/buildbot/#/builders/162/builds/3718/steps/6/logs/stdio ).
I don't know if it's a problem with the code being tested, or the test itself,
but it looks like there's still some issues here.
https://github.com/llv
https://github.com/xusheng6 updated
https://github.com/llvm/llvm-project/pull/102873
>From 73c98df4baef99f96d9c67113ba2ed0d972e5a04 Mon Sep 17 00:00:00 2001
From: Xusheng
Date: Mon, 20 Mar 2023 20:24:11 +0800
Subject: [PATCH 1/5] [lldb] Claim to support swbreak and hwbreak packets when
debuggi
xusheng6 wrote:
> Also there is probably a qsupported parsing function in lldb-server, please
> add a comment there to say we consume lldb's swbreak/hwbreak feature but it
> doesn't change the behaviour of lldb-server.
Fixed in
https://github.com/llvm/llvm-project/pull/102873/commits/d0851d4f
@@ -2353,6 +2353,10 @@ StateType
ProcessGDBRemote::SetThreadStopInfo(StringExtractor &stop_packet) {
uint32_t reg = UINT32_MAX;
if (!key.getAsInteger(16, reg))
expedited_register_map[reg] = std::string(std::move(value));
+ } else if (key.compare(
xusheng6 wrote:
> On the testing, lldb sends this qsupported value regardless of what the
> remote sends. So there's nothing to do there unless you just repeat the
> feature list. There are some tests that look at lldb-server's qsupported
> values, but I don't see any for the client lldb.
>
>
@@ -174,6 +176,83 @@ struct StatisticsOptions {
std::optional m_include_transcript;
};
+/// A class that represents statistics about a TypeSummaryProviders invocations
+class SummaryStatistics {
+public:
+ SummaryStatistics() = default;
+ SummaryStatistics(lldb_private::Co
@@ -174,6 +176,83 @@ struct StatisticsOptions {
std::optional m_include_transcript;
};
+/// A class that represents statistics about a TypeSummaryProviders invocations
+class SummaryStatistics {
+public:
+ SummaryStatistics() = default;
+ SummaryStatistics(lldb_private::Co
https://github.com/mbucko requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/102708
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -174,6 +176,83 @@ struct StatisticsOptions {
std::optional m_include_transcript;
};
+/// A class that represents statistics about a TypeSummaryProviders invocations
+class SummaryStatistics {
+public:
+ SummaryStatistics() = default;
+ SummaryStatistics(lldb_private::Co
@@ -408,3 +410,23 @@ llvm::json::Value DebuggerStats::ReportStatistics(
return std::move(global_stats);
}
+
+llvm::json::Value SummaryStatistics::ToJSON() const {
+ json::Object body {{
+ {"invocationCount", GetSummaryCount()},
+ {"totalTime", GetTotalTime()},
+
@@ -174,6 +176,83 @@ struct StatisticsOptions {
std::optional m_include_transcript;
};
+/// A class that represents statistics about a TypeSummaryProviders invocations
+class SummaryStatistics {
+public:
+ SummaryStatistics() = default;
+ SummaryStatistics(lldb_private::Co
Author: Dmitry Vasilyev
Date: 2024-08-12T18:50:23+04:00
New Revision: 82ee31f75ac1316006fa9e21dddfddec37cf7072
URL:
https://github.com/llvm/llvm-project/commit/82ee31f75ac1316006fa9e21dddfddec37cf7072
DIFF:
https://github.com/llvm/llvm-project/commit/82ee31f75ac1316006fa9e21dddfddec37cf7072.dif
https://github.com/slydiman closed
https://github.com/llvm/llvm-project/pull/101283
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
> or do we already have some infra that I can use?
`lldb/test/API/functionalities/gdb_remote_client/TestStopPCs.py` is an example
of that infrastructure. The `threadStopInfo` is where you would insert the
swbreak hwbreak key.
In fact, if i386 is an architecture where this
DavidSpickett wrote:
AArch64 for example would be:
```
aarch64
```
https://github.com/llvm/llvm-project/pull/102873
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb
DavidSpickett wrote:
The new test appears to be flaky on Windows:
```
# .---command stderr
# |
C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\lldb\test\Shell\SymbolFile\DWARF\x86\dwp-hash-collision.s:22:10:
error: CHECK: expected string not found in input
# | # CHECK: 0
Author: David Spickett
Date: 2024-08-12T15:09:18Z
New Revision: 7027cc6a073cb5ae7a0ce04fa4a2dbe714615da9
URL:
https://github.com/llvm/llvm-project/commit/7027cc6a073cb5ae7a0ce04fa4a2dbe714615da9
DIFF:
https://github.com/llvm/llvm-project/commit/7027cc6a073cb5ae7a0ce04fa4a2dbe714615da9.diff
LOG
https://github.com/s-barannikov updated
https://github.com/llvm/llvm-project/pull/102839
>From e3cdec63767738ca0e5fe640f9e01996ec1ecc22 Mon Sep 17 00:00:00 2001
From: Sergei Barannikov
Date: Mon, 12 Aug 2024 03:53:28 +0300
Subject: [PATCH] [lldb] Avoid calling DataLayout constructor accepting M
@@ -174,6 +176,83 @@ struct StatisticsOptions {
std::optional m_include_transcript;
};
+/// A class that represents statistics about a TypeSummaryProviders invocations
+class SummaryStatistics {
+public:
+ SummaryStatistics() = default;
+ SummaryStatistics(lldb_private::Co
@@ -174,6 +176,83 @@ struct StatisticsOptions {
std::optional m_include_transcript;
};
+/// A class that represents statistics about a TypeSummaryProviders invocations
+class SummaryStatistics {
+public:
+ SummaryStatistics() = default;
+ SummaryStatistics(lldb_private::Co
@@ -174,6 +176,83 @@ struct StatisticsOptions {
std::optional m_include_transcript;
};
+/// A class that represents statistics about a TypeSummaryProviders invocations
+class SummaryStatistics {
+public:
+ SummaryStatistics() = default;
+ SummaryStatistics(lldb_private::Co
@@ -174,6 +176,83 @@ struct StatisticsOptions {
std::optional m_include_transcript;
};
+/// A class that represents statistics about a TypeSummaryProviders invocations
+class SummaryStatistics {
+public:
+ SummaryStatistics() = default;
+ SummaryStatistics(lldb_private::Co
@@ -615,7 +615,16 @@ bool ValueObject::GetSummaryAsCString(TypeSummaryImpl
*summary_ptr,
m_synthetic_value->UpdateValueIfNeeded(); // the summary might depend on
// the synthetic children being
@@ -174,6 +176,83 @@ struct StatisticsOptions {
std::optional m_include_transcript;
};
+/// A class that represents statistics about a TypeSummaryProviders invocations
+class SummaryStatistics {
+public:
+ SummaryStatistics() = default;
+ SummaryStatistics(lldb_private::Co
@@ -25,6 +26,7 @@ namespace lldb_private {
using StatsClock = std::chrono::high_resolution_clock;
using StatsTimepoint = std::chrono::time_point;
+using Duration = std::chrono::duration;
Michael137 wrote:
Is this used anywhere?
https://github.com/llvm/llvm-p
@@ -174,6 +176,83 @@ struct StatisticsOptions {
std::optional m_include_transcript;
};
+/// A class that represents statistics about a TypeSummaryProviders invocations
+class SummaryStatistics {
+public:
+ SummaryStatistics() = default;
+ SummaryStatistics(lldb_private::Co
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/102708
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/102708
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
felipepiovezan wrote:
Isn't this going to degrade the performance of _all_ negative queries?
I don't remember off the top of my head what is "m_fallback" when we have an
accelerator table, but this worries me.
https://github.com/llvm/llvm-project/pull/102123
@@ -918,3 +920,24 @@ def test_order_of_options_do_not_matter(self):
debug_stats_1,
f"The order of options '{options[0]}' and '{options[1]}'
should not matter",
)
+
+def test_summary_statistics_providers(self):
+"""
+
@@ -1,7 +1,13 @@
// Test that the lldb command `statistics` works.
+#include
+
+void foo() {
+ std::string str = "hello world";
Michael137 wrote:
instead of relying on `std::string` formatter should we add a type summary for
a dummy type? And test against tha
https://github.com/Michael137 approved this pull request.
Lifetimes look correct to me, thanks!
https://github.com/llvm/llvm-project/pull/102839
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/l
@@ -615,7 +615,16 @@ bool ValueObject::GetSummaryAsCString(TypeSummaryImpl
*summary_ptr,
m_synthetic_value->UpdateValueIfNeeded(); // the summary might depend on
// the synthetic children being
labath wrote:
Sort of yes (*), but only so much as it is necessary to make it correct, and
the level of slowdown depends on how much non-indexed code you have. The
fallback index will only index those units that aren't covered by the
debug_names index, so if debug_names covers everything, the
Michael137 wrote:
Stats around this area could definitely be interesting to explore!
https://github.com/llvm/llvm-project/pull/102708
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
adrian-prantl wrote:
@labath This test fails in two configs on the matrix bot:
https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/lldb-cmake-matrix/602/testReport/junit/lldb-shell/SymbolFile_DWARF_x86/Test_Clang_17_0_6___dwp_hash_collision_s/
https://green.lab.llvm.org/job/llvm.org/view/LLDB/j
vogelsgesang wrote:
FYI @walter-erquinigo: There is a proposal under discussion to add first-class
support for `declarationLocation` (and also `valueLocation`) to the debug
adapter protocol. See
https://github.com/microsoft/debug-adapter-protocol/issues/343
https://github.com/llvm/llvm-projec
felipepiovezan wrote:
> The fallback index will only index those units that aren't covered by the
> debug_names index, so if debug_names covers everything, the fallback is a noop
Got it, this is what I was hoping that would happen! Thanks for explaining it.
(future ideas) This makes me wonder
walter-erquinigo wrote:
> FYI @walter-erquinigo: There is a proposal under discussion to add
> first-class support for `declarationLocation` (and also `valueLocation`) to
> the debug adapter protocol. See
> [microsoft/debug-adapter-protocol#343](https://github.com/microsoft/debug-adapter-proto
labath wrote:
It just so happens that I got a `memory find` bug today, which made me realize
just how broken the current behavior is -- it will effectively abort the search
as soon as it runs into any unreadable block of memory (plus it also reads one
byte at a time, which makes it excruciatin
labath wrote:
> So the main idea is: if either ObjectFile or PostMortemProcess can return a
> reference to the data in the Peek calls, then should as long as they have
> this data mapped into the LLDB address space and can hand out a pointer to
> the data. If they can't, we should fall back to
https://github.com/vogelsgesang created
https://github.com/llvm/llvm-project/pull/102928
`declarationLocation` is about to become part of the upstream debug adapter
protocol (see microsoft/debug-adapter-protocol#343). This is a draft
implementation, to be finalized and merged after the corresp
vogelsgesang wrote:
@walter-erquinigo I took a first stab at implementing the DAP proposal. Seemed
rather straightforward. I would love to hear if I missed anything.
Also, I am not sure how to implement `valueLocation`, i.e., a the source
location referecend by the value. E.g., for a function
Author: Pavel Labath
Date: 2024-08-12T18:36:18+02:00
New Revision: 38b67c54ed858f60c0caebcfba4b61f9326684ca
URL:
https://github.com/llvm/llvm-project/commit/38b67c54ed858f60c0caebcfba4b61f9326684ca
DIFF:
https://github.com/llvm/llvm-project/commit/38b67c54ed858f60c0caebcfba4b61f9326684ca.diff
labath wrote:
This appears to be the same issue that David reported. I'm going to revert this
while I investigate. I doubt it's a compiler thing as the test does not
actually compile anything. It's more likely that something in the code is flaky
(and I think I have an idea what could that be).
Author: Pavel Labath
Date: 2024-08-12T18:41:28+02:00
New Revision: b3ed1d92112e0f455f8ef0888ef4c5d0ca29096d
URL:
https://github.com/llvm/llvm-project/commit/b3ed1d92112e0f455f8ef0888ef4c5d0ca29096d
DIFF:
https://github.com/llvm/llvm-project/commit/b3ed1d92112e0f455f8ef0888ef4c5d0ca29096d.diff
Author: Pavel Labath
Date: 2024-08-12T18:43:16+02:00
New Revision: a0c57a0f3c6b44ce8f2c7222d0932df85883cf06
URL:
https://github.com/llvm/llvm-project/commit/a0c57a0f3c6b44ce8f2c7222d0932df85883cf06
DIFF:
https://github.com/llvm/llvm-project/commit/a0c57a0f3c6b44ce8f2c7222d0932df85883cf06.diff
Jlalond wrote:
@labath those did get omitted due to github marking them as outdated due to
moving the code around, I mixed that. I appreciate your long review on this
one, I learned a lot from your feedback.
I'm going to let CI run and merge when it's completed
https://github.com/llvm/llvm-pr
@@ -615,7 +615,16 @@ bool ValueObject::GetSummaryAsCString(TypeSummaryImpl
*summary_ptr,
m_synthetic_value->UpdateValueIfNeeded(); // the summary might depend on
// the synthetic children being
https://github.com/Jlalond edited
https://github.com/llvm/llvm-project/pull/102708
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath wrote:
The current setup makes sense to me, but I guess that's expected as I'm the one
who created it. I can also imagine something like what you propose, but it
doesn't seem like a clear win to me. These objects are owned by
SymbolFileDWARF, and we probably don't want to have it do the
felipepiovezan wrote:
> The current setup makes sense to me, but I guess that's expected as I'm the
> one who created it. I can also imagine something like what you propose, but
> it doesn't seem like a clear win to me. These objects are owned by
> SymbolFileDWARF, and we probably don't want t
https://github.com/augusto2112 requested changes to this pull request.
I think overall this looks good! Just some small things to fix.
Could you run `ninja check-lldb` from your build folder to make sure this
change doesn't break anything?
https://github.com/llvm/llvm-project/pull/102835
_
@@ -799,20 +803,21 @@ IRExecutionUnit::FindInSymbols(const
std::vector &names,
sc_list);
if (auto load_addr = resolver.Resolve(sc_list))
return *load_addr;
-}
-if (sc.target_sp) {
- SymbolContextList sc_list;
-
https://github.com/augusto2112 edited
https://github.com/llvm/llvm-project/pull/102835
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -785,6 +785,10 @@ IRExecutionUnit::FindInSymbols(const
std::vector &names,
return LLDB_INVALID_ADDRESS;
}
+ ModuleList images = target->GetImages();
augusto2112 wrote:
Check if `target` is null before accessing it.
https://github.com/llvm/llvm-pro
@@ -785,6 +785,10 @@ IRExecutionUnit::FindInSymbols(const
std::vector &names,
return LLDB_INVALID_ADDRESS;
}
+ ModuleList images = target->GetImages();
augusto2112 wrote:
Oh, looks like target is already checked right before this, disregard this
comm
@@ -785,6 +785,10 @@ IRExecutionUnit::FindInSymbols(const
std::vector &names,
return LLDB_INVALID_ADDRESS;
}
+ ModuleList images = target->GetImages();
DmT021 wrote:
It was already checked 4 lines above
```
if (!target) {
// We shouldn't be doin
1 - 100 of 163 matches
Mail list logo
