[Lldb-commits] [lldb] [lldb] Updated lldb-server to spawn the child process and share socket (PR #101283)

2024-08-09 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman updated https://github.com/llvm/llvm-project/pull/101283 >From 6b2a41ba3d71270e81e24a42d3b4f5dc2f96b939 Mon Sep 17 00:00:00 2001 From: Dmitry Vasilyev Date: Wed, 31 Jul 2024 05:41:21 +0400 Subject: [PATCH 1/5] [lldb] Updated lldb-server to spawn the child process and

[Lldb-commits] [lldb] 4bb1396 - [lldb][Platform] Move the GetSDKPathFromDebugInfo helpers from PlatformDarwin into Platform (#102488)

2024-08-09 Thread via lldb-commits
Author: Michael Buch Date: 2024-08-09T09:41:25+01:00 New Revision: 4bb139622ee318571cb2ef6649ff1766051f0e84 URL: https://github.com/llvm/llvm-project/commit/4bb139622ee318571cb2ef6649ff1766051f0e84 DIFF: https://github.com/llvm/llvm-project/commit/4bb139622ee318571cb2ef6649ff1766051f0e84.diff

[Lldb-commits] [lldb] [lldb][Platform] Move the GetSDKPathFromDebugInfo helpers from PlatformDarwin into Platform (PR #102488)

2024-08-09 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/102488 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Reland "[lldb][ClangExpressionParser] Set BuiltinHeadersInSystemModules depending on SDK version (#102309)" (PR #102497)

2024-08-09 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/102497 >From d2f0b68afe6ebfffe5a2ef3ce14a77a5e1025c90 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Thu, 8 Aug 2024 16:07:21 +0100 Subject: [PATCH 1/4] [lldb][Platform] Move the GetSDKPathFromDebugInfo helpers

[Lldb-commits] [lldb] 3fffa6d - Reland "[lldb][ClangExpressionParser] Set BuiltinHeadersInSystemModules depending on SDK version (#102309)" (#102497)

2024-08-09 Thread via lldb-commits
Author: Michael Buch Date: 2024-08-09T09:43:08+01:00 New Revision: 3fffa6d486ecedaf639927a448701df9fdc19a34 URL: https://github.com/llvm/llvm-project/commit/3fffa6d486ecedaf639927a448701df9fdc19a34 DIFF: https://github.com/llvm/llvm-project/commit/3fffa6d486ecedaf639927a448701df9fdc19a34.diff

[Lldb-commits] [lldb] Reland "[lldb][ClangExpressionParser] Set BuiltinHeadersInSystemModules depending on SDK version (#102309)" (PR #102497)

2024-08-09 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/102497 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove Phabricator usernames from Code Owners file (PR #102590)

2024-08-09 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/102590 Removing them simplifies the content and means we don't confuse anyone who joined after the Phabricator shutdown. You could use them for review archaeology but this is only a subset of the names you'd en

[Lldb-commits] [lldb] [lldb] Remove Phabricator usernames from Code Owners file (PR #102590)

2024-08-09 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) Changes Removing them simplifies the content and means we don't confuse anyone who joined after the Phabricator shutdown. You could use them for review archaeology but this is only a subset of the names you'

[Lldb-commits] [lldb] [lldb] Support new libc++ __compressed_pair layout (PR #96538)

2024-08-09 Thread Michael Buch via lldb-commits
@@ -734,9 +740,13 @@ def update(self): # variable tells which element in this NxM array is the 0th # one, and the 'size' element gives the number of elements # in the deque. -count = self._get_value_of_compressed_pair( -

[Lldb-commits] [lldb] [lldb] Support new libc++ __compressed_pair layout (PR #96538)

2024-08-09 Thread Michael Buch via lldb-commits
@@ -734,9 +740,13 @@ def update(self): # variable tells which element in this NxM array is the 0th # one, and the 'size' element gives the number of elements # in the deque. -count = self._get_value_of_compressed_pair( -

[Lldb-commits] [clang] [lldb] [llvm] Extending LLDB to work on AIX (PR #102601)

2024-08-09 Thread via lldb-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[Lldb-commits] [clang] [lldb] [llvm] Extending LLDB to work on AIX (PR #102601)

2024-08-09 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-binary-utilities @llvm/pr-subscribers-clang-codegen Author: None (Dhruv-Srivastava-IBM) Changes We have Implemented the necessary code changes required to run LLDB on AIX. This PR is for discussion as asked in #101657 With this PR, we request your

[Lldb-commits] [clang] [lldb] [llvm] Extending LLDB to work on AIX (PR #102601)

2024-08-09 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (Dhruv-Srivastava-IBM) Changes We have Implemented the necessary code changes required to run LLDB on AIX. This PR is for discussion as asked in #101657 With this PR, we request your inputs and feedback about our code changes. ---

[Lldb-commits] [clang] [lldb] [llvm] Extending LLDB to work on AIX (PR #102601)

2024-08-09 Thread via lldb-commits
https://github.com/Dhruv-Srivastava-IBM edited https://github.com/llvm/llvm-project/pull/102601 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [llvm] Extending LLDB to work on AIX (PR #102601)

2024-08-09 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/102601 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [llvm] Extending LLDB to work on AIX (PR #102601)

2024-08-09 Thread David Spickett via lldb-commits
@@ -38,6 +38,10 @@ endif() include(LLDBConfig) include(AddLLDB) +if (UNIX AND ${CMAKE_SYSTEM_NAME} MATCHES "AIX") + add_definitions("-D__AIX__") DavidSpickett wrote: This looks like a macro that a compiler might set for you, is that not the case here? http

[Lldb-commits] [clang] [lldb] [llvm] Extending LLDB to work on AIX (PR #102601)

2024-08-09 Thread David Spickett via lldb-commits
@@ -11,6 +11,11 @@ #include "lldb/Host/Config.h" +#if defined(__AIX__) +//FIXME for AIX +#undef LLDB_ENABLE_LIBXML2 DavidSpickett wrote: In theory if you configure with `-DLLDB_ENABLE_LIBXML2=OFF`, the libxml2 parts will be removed. Was something else being

[Lldb-commits] [clang] [lldb] [llvm] Extending LLDB to work on AIX (PR #102601)

2024-08-09 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett commented: It's worth putting the PR into draft mode just to be extra clear this is a request for early feedback. This PR will be later split up of course, so very general comments from me. Very impressive effort overall. https://github.com/llvm/llvm-project/p

[Lldb-commits] [clang] [lldb] [llvm] Extending LLDB to work on AIX (PR #102601)

2024-08-09 Thread David Spickett via lldb-commits
@@ -40,6 +40,113 @@ add_custom_target(lldb-sbapi-dwarf-enums DEPENDS ${sb_languages_file}) set_target_properties(lldb-sbapi-dwarf-enums PROPERTIES FOLDER "LLDB/Tablegenning") +if(CMAKE_SYSTEM_NAME MATCHES "AIX") +add_lldb_library(liblldb STATIC ${option_framework} -

[Lldb-commits] [clang] [lldb] [llvm] Extending LLDB to work on AIX (PR #102601)

2024-08-09 Thread David Spickett via lldb-commits
@@ -1510,6 +1510,18 @@ bool Module::SetLoadAddress(Target &target, lldb::addr_t value, return false; } +bool Module::SetLoadAddressByType(Target &target, lldb::addr_t value, +bool value_is_offset, bool &changed, int type_id) { + ObjectFile *obje

[Lldb-commits] [clang] [lldb] [llvm] Extending LLDB to work on AIX (PR #102601)

2024-08-09 Thread David Spickett via lldb-commits
@@ -342,7 +342,7 @@ uint32_t SBBreakpoint::GetIgnoreCount() const { return count; } -void SBBreakpoint::SetThreadID(tid_t tid) { +void SBBreakpoint::SetThreadID(lldb::tid_t tid) { DavidSpickett wrote: If these lldb:: are fixing compilation errors they would

[Lldb-commits] [clang] [lldb] [llvm] Extending LLDB to work on AIX (PR #102601)

2024-08-09 Thread David Spickett via lldb-commits
@@ -0,0 +1,62 @@ +//===-- Ptrace.h *- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [clang] [lldb] [llvm] Extending LLDB to work on AIX (PR #102601)

2024-08-09 Thread David Spickett via lldb-commits
@@ -0,0 +1,7 @@ + +This product contains small piece of code to support AIX, taken from netbsd. + + * LICENSE: +* lldb/source/Host/common/LICENSE.aix-netbsd.txt (OpenSSL License) DavidSpickett wrote: We'll need to confirm license compatibility for this. htt

[Lldb-commits] [clang] [lldb] [llvm] Extending LLDB to work on AIX (PR #102601)

2024-08-09 Thread David Spickett via lldb-commits
@@ -67,6 +67,10 @@ class RegisterContextUnwind : public lldb_private::RegisterContext { bool ReadPC(lldb::addr_t &start_pc); +#ifdef __AIX__ + bool ReadLR(lldb::addr_t &lr); +#endif + DavidSpickett wrote: It's likely we'd ask you to make this a method on

[Lldb-commits] [clang] [lldb] [llvm] Extending LLDB to work on AIX (PR #102601)

2024-08-09 Thread David Spickett via lldb-commits
@@ -0,0 +1,7 @@ + +This product contains small piece of code to support AIX, taken from netbsd. + + * LICENSE: +* lldb/source/Host/common/LICENSE.aix-netbsd.txt (OpenSSL License) DavidSpickett wrote: And if there is a way not to pull in this code, we're like

[Lldb-commits] [clang] [lldb] [llvm] Extending LLDB to work on AIX (PR #102601)

2024-08-09 Thread David Spickett via lldb-commits
@@ -38,6 +38,10 @@ endif() include(LLDBConfig) include(AddLLDB) +if (UNIX AND ${CMAKE_SYSTEM_NAME} MATCHES "AIX") + add_definitions("-D__AIX__") DavidSpickett wrote: Also remember that users may be debugging AIX from a non-AIX host where the compiler would

[Lldb-commits] [clang] [lldb] [llvm] Extending LLDB to work on AIX (PR #102601)

2024-08-09 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/102601 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Realpath symlinks for breakpoints (PR #102223)

2024-08-09 Thread via lldb-commits
@@ -0,0 +1,66 @@ +//===-- RealpathPrefixes.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [LLDB] Add AST node classes, functions, etc. for Data Inspection Lang… (PR #95738)

2024-08-09 Thread via lldb-commits
@@ -0,0 +1,560 @@ +//===-- DILAST.cpp ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb] Add 'FindInMemory()' overload for PostMortemProcess. (PR #102536)

2024-08-09 Thread Miro Bucko via lldb-commits
@@ -2835,6 +2835,34 @@ void PruneThreadPlans(); AddressRanges &matches, size_t alignment, size_t max_matches); + template + lldb::addr_t FindInMemoryGeneric(IT &&iterator, lldb::addr_t low, +

[Lldb-commits] [lldb] [lldb] Realpath symlinks for breakpoints (PR #102223)

2024-08-09 Thread via lldb-commits
@@ -0,0 +1,66 @@ +//===-- RealpathPrefixes.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb] Add 'FindInMemory()' overload for PostMortemProcess. (PR #102536)

2024-08-09 Thread Greg Clayton via lldb-commits
https://github.com/clayborg commented: Thinking about this some more here are my thoughts: both `ObjectFile::PeekData` and `PostMoretemProcess::PeekMemory` should have a way to say "I am not implemented". Using either a llvm::Expected or std::optional. If `ObjectFile::PeekData` returns unimpl

[Lldb-commits] [lldb] [LLDB] Impove ObjectFileELF's .dynamic parsing and usage. (PR #102570)

2024-08-09 Thread Greg Clayton via lldb-commits
clayborg wrote: @labath this is the same patch you already accepted + fix https://github.com/llvm/llvm-project/pull/102570 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Tolerate multiple compile units with the same DWO ID (PR #100577)

2024-08-09 Thread Greg Clayton via lldb-commits
https://github.com/clayborg approved this pull request. https://github.com/llvm/llvm-project/pull/100577 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Tolerate multiple compile units with the same DWO ID (PR #100577)

2024-08-09 Thread Greg Clayton via lldb-commits
@@ -97,12 +97,14 @@ void DWARFUnit::ExtractUnitDIEIfNeeded() { *m_dwo_id, m_first_die.GetOffset())); return; // Can't fetch the compile unit from the dwo file. } - // If the skeleton compile unit gets its unit DIE parsed first, then this - // will fill in the DW

[Lldb-commits] [lldb] [lldb] Add 'FindInMemory()' overload for PostMortemProcess. (PR #102536)

2024-08-09 Thread Miro Bucko via lldb-commits
@@ -33,6 +34,23 @@ class PostMortemProcess : public Process { FileSpec GetCoreFile() const override { return m_core_file; } protected: + typedef lldb_private::Range FileRange; + typedef lldb_private::RangeDataVector + VMRangeToFileOffset; + typedef lldb_private::Rang

[Lldb-commits] [lldb] [lldb] Add 'FindInMemory()' overload for PostMortemProcess. (PR #102536)

2024-08-09 Thread Miro Bucko via lldb-commits
mbucko wrote: > Thinking about this some more here are my thoughts: both > `ObjectFile::PeekData` and `PostMoretemProcess::PeekMemory` should have a way > to say "I am not implemented". Using either a llvm::Expected or > std::optional. If `ObjectFile::PeekData` returns unimplemented, we need t

[Lldb-commits] [lldb] [lldb] Realpath symlinks for breakpoints (PR #102223)

2024-08-09 Thread via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/102223 >From c629defe38a510ffdd23122b2e9cfac68933cf34 Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Fri, 2 Aug 2024 06:35:45 -0700 Subject: [PATCH 1/6] [lldb] Allow realpathing support files when resolving file/line b

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #99736)

2024-08-09 Thread Greg Clayton via lldb-commits
clayborg wrote: > @clayborg as far as I can tell, the ball is currently in your court to > respond to @jimingham ... thanks in advance Sounds like Jim is on the fence with a SetDirection + existing APIs and adding a direction to the calls. I am fine with either approach as long as Jim is ok w

[Lldb-commits] [lldb] [lldb][NFCI] Simplify ProcessElfCore::GetAuxvData() (PR #102263)

2024-08-09 Thread Igor Kudrin via lldb-commits
@@ -1077,10 +1077,10 @@ ArchSpec ProcessElfCore::GetArchitecture() { } DataExtractor ProcessElfCore::GetAuxvData() { - const uint8_t *start = m_auxv.GetDataStart(); - size_t len = m_auxv.GetByteSize(); - lldb::DataBufferSP buffer(new lldb_private::DataBufferHeap(start, len)

[Lldb-commits] [lldb] 101cf54 - [lldb] Move definition of SBSaveCoreOptions dtor out of header (#102539)

2024-08-09 Thread via lldb-commits
Author: Alex Langford Date: 2024-08-09T12:50:42-07:00 New Revision: 101cf540e698529d3dd899d00111bcb654a3c12b URL: https://github.com/llvm/llvm-project/commit/101cf540e698529d3dd899d00111bcb654a3c12b DIFF: https://github.com/llvm/llvm-project/commit/101cf540e698529d3dd899d00111bcb654a3c12b.diff

[Lldb-commits] [lldb] [lldb] Move definition of SBSaveCoreOptions dtor out of header (PR #102539)

2024-08-09 Thread Alex Langford via lldb-commits
https://github.com/bulbazord closed https://github.com/llvm/llvm-project/pull/102539 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Move definition of SBSaveCoreOptions dtor out of header (PR #102539)

2024-08-09 Thread Alex Langford via lldb-commits
bulbazord wrote: /cherry-pick [101cf54](https://github.com/llvm/llvm-project/commit/101cf540e698529d3dd899d00111bcb654a3c12b) https://github.com/llvm/llvm-project/pull/102539 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm

[Lldb-commits] [lldb] [lldb] Move definition of SBSaveCoreOptions dtor out of header (PR #102539)

2024-08-09 Thread via lldb-commits
llvmbot wrote: >/cherry-pick >[101cf54](https://github.com/llvm/llvm-project/commit/101cf540e698529d3dd899d00111bcb654a3c12b) Error: Command failed due to missing milestone. https://github.com/llvm/llvm-project/pull/102539 ___ lldb-commits mailing l

[Lldb-commits] [lldb] [lldb][NFCI] Simplify ProcessElfCore::GetAuxvData() (PR #102263)

2024-08-09 Thread Greg Clayton via lldb-commits
https://github.com/clayborg approved this pull request. https://github.com/llvm/llvm-project/pull/102263 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][NFCI] Simplify ProcessElfCore::GetAuxvData() (PR #102263)

2024-08-09 Thread Greg Clayton via lldb-commits
@@ -1077,10 +1077,10 @@ ArchSpec ProcessElfCore::GetArchitecture() { } DataExtractor ProcessElfCore::GetAuxvData() { - const uint8_t *start = m_auxv.GetDataStart(); - size_t len = m_auxv.GetByteSize(); - lldb::DataBufferSP buffer(new lldb_private::DataBufferHeap(start, len)

[Lldb-commits] [lldb] [lldb] Move definition of SBSaveCoreOptions dtor out of header (PR #102539)

2024-08-09 Thread Alex Langford via lldb-commits
bulbazord wrote: /cherry-pick https://github.com/llvm/llvm-project/commit/101cf540e698529d3dd899d00111bcb654a3c12b https://github.com/llvm/llvm-project/pull/102539 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[Lldb-commits] [lldb] [lldb] Move definition of SBSaveCoreOptions dtor out of header (PR #102539)

2024-08-09 Thread via lldb-commits
llvmbot wrote: >/cherry-pick >https://github.com/llvm/llvm-project/commit/101cf540e698529d3dd899d00111bcb654a3c12b Error: Command failed due to missing milestone. https://github.com/llvm/llvm-project/pull/102539 ___ lldb-commits mailing list lldb-co

[Lldb-commits] [lldb] [lldb] Add 'FindInMemory()' overload for PostMortemProcess. (PR #102536)

2024-08-09 Thread Greg Clayton via lldb-commits
@@ -33,6 +34,23 @@ class PostMortemProcess : public Process { FileSpec GetCoreFile() const override { return m_core_file; } protected: + typedef lldb_private::Range FileRange; + typedef lldb_private::RangeDataVector + VMRangeToFileOffset; + typedef lldb_private::Rang

[Lldb-commits] [lldb] [lldb] Move definition of SBSaveCoreOptions dtor out of header (PR #102539)

2024-08-09 Thread Alex Langford via lldb-commits
https://github.com/bulbazord milestoned https://github.com/llvm/llvm-project/pull/102539 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Move definition of SBSaveCoreOptions dtor out of header (PR #102539)

2024-08-09 Thread Alex Langford via lldb-commits
bulbazord wrote: /cherry-pick https://github.com/llvm/llvm-project/commit/101cf540e698529d3dd899d00111bcb654a3c12b https://github.com/llvm/llvm-project/pull/102539 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[Lldb-commits] [lldb] [lldb] Move definition of SBSaveCoreOptions dtor out of header (PR #102539)

2024-08-09 Thread via lldb-commits
llvmbot wrote: /pull-request llvm/llvm-project#102680 https://github.com/llvm/llvm-project/pull/102539 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add 'FindInMemory()' overload for PostMortemProcess. (PR #102536)

2024-08-09 Thread Greg Clayton via lldb-commits
https://github.com/clayborg commented: Looks pretty close to me. Lets give some time for others to review https://github.com/llvm/llvm-project/pull/102536 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #99736)

2024-08-09 Thread Robert O'Callahan via lldb-commits
rocallahan wrote: > > @clayborg as far as I can tell, the ball is currently in your court to > > respond to @jimingham ... thanks in advance > > Sounds like Jim is on the fence with a SetDirection + existing APIs and > adding a direction to the calls. I am fine with either approach as long as

[Lldb-commits] [lldb] [lldb] Realpath symlinks for breakpoints (PR #102223)

2024-08-09 Thread via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/102223 >From c629defe38a510ffdd23122b2e9cfac68933cf34 Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Fri, 2 Aug 2024 06:35:45 -0700 Subject: [PATCH 1/8] [lldb] Allow realpathing support files when resolving file/line b

[Lldb-commits] [lldb] [lldb] Realpath symlinks for breakpoints (PR #102223)

2024-08-09 Thread via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/102223 >From c629defe38a510ffdd23122b2e9cfac68933cf34 Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Fri, 2 Aug 2024 06:35:45 -0700 Subject: [PATCH 1/9] [lldb] Allow realpathing support files when resolving file/line b

[Lldb-commits] [lldb] [lldb] Realpath symlinks for breakpoints (PR #102223)

2024-08-09 Thread via lldb-commits
royitaqi wrote: Hi @jimingham and @labath, Thank you for your review so far. They were very helpful comments. I appreciate it. I *think* I have addressed all of your comments. When you have the time, it will be great if you can take another look. Thanks, Roy https://github.com/llvm/llvm-proj

[Lldb-commits] [lldb] [lldb] Realpath symlinks for breakpoints (PR #102223)

2024-08-09 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 396343f17b1182ff8ed698beac3f9b93b1d9dabd...d984f5c367fcc07fc1d1b88791562285c3ce0d67 lldb

[Lldb-commits] [lldb] [lldb] Realpath symlinks for breakpoints (PR #102223)

2024-08-09 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/102223 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add AST node classes, functions, etc. for Data Inspection Lang… (PR #95738)

2024-08-09 Thread via lldb-commits
@@ -0,0 +1,560 @@ +//===-- DILAST.cpp ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [LLDB][Data Formatters] Calculate average and total time for summary providers within lldb (PR #102708)

2024-08-09 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond created https://github.com/llvm/llvm-project/pull/102708 This PR adds a statistics provider cache, which allows an individual target to keep a rolling tally of it's total time and number of invocations for a given summary provider. This information is then available

[Lldb-commits] [lldb] [LLDB][Data Formatters] Calculate average and total time for summary providers within lldb (PR #102708)

2024-08-09 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jacob Lalonde (Jlalond) Changes This PR adds a statistics provider cache, which allows an individual target to keep a rolling tally of it's total time and number of invocations for a given summary provider. This information is then availab

[Lldb-commits] [lldb] [LLDB][Data Formatters] Calculate average and total time for summary providers within lldb (PR #102708)

2024-08-09 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r a3ccaed3b9f6a1fe9b7f2ef019259f88072639b2...ad4b20d2074203fce9e4c47fd6045699b1528d86 lldb/

[Lldb-commits] [lldb] [LLDB][Data Formatters] Calculate average and total time for summary providers within lldb (PR #102708)

2024-08-09 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff a3ccaed3b9f6a1fe9b7f2ef019259f88072639b2 ad4b20d2074203fce9e4c47fd6045699b1528d86 --e

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #99736)

2024-08-09 Thread Robert O'Callahan via lldb-commits
https://github.com/rocallahan updated https://github.com/llvm/llvm-project/pull/99736 >From 52b133ee9fda7b6cc3b6300756e7b8ec82a6a9bf Mon Sep 17 00:00:00 2001 From: Robert O'Callahan Date: Fri, 19 Jul 2024 22:46:42 +1200 Subject: [PATCH] [lldb] Implement basic support for reverse-continue This

[Lldb-commits] [lldb] [lldb] Implement basic support for reverse-continue (PR #99736)

2024-08-09 Thread Robert O'Callahan via lldb-commits
https://github.com/rocallahan updated https://github.com/llvm/llvm-project/pull/99736 >From 3aa5a6f08487314f12b7b0d2d13ccd20f306f16c Mon Sep 17 00:00:00 2001 From: Robert O'Callahan Date: Fri, 19 Jul 2024 22:46:42 +1200 Subject: [PATCH] [lldb] Implement basic support for reverse-continue This

[Lldb-commits] [lldb] [LLDB] Add AST node classes, functions, etc. for Data Inspection Lang… (PR #95738)

2024-08-09 Thread via lldb-commits
cmtice wrote: I think I have addressed all the review comments; please take another look. :-) https://github.com/llvm/llvm-project/pull/95738 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb

[Lldb-commits] [lldb] [LLDB] Add AST node classes, functions, etc. for Data Inspection Lang… (PR #95738)

2024-08-09 Thread via lldb-commits
@@ -0,0 +1,446 @@ +//===-- DILAST.h *- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap