https://github.com/jimingham approved this pull request.
This looks fine. I'd add a
using TimeoutInfoSP = std::shared_ptr<...>
and refer to it that way. The construct appears enough times to warrant that;
it's a lot easier to read and we use the SP suffix consistently so it will be
unders
Author: Michael Buch
Date: 2024-08-06T21:41:59+01:00
New Revision: f9f0ae1bc47fbe76141cce63a6e92e3f3546ec9b
URL:
https://github.com/llvm/llvm-project/commit/f9f0ae1bc47fbe76141cce63a6e92e3f3546ec9b
DIFF:
https://github.com/llvm/llvm-project/commit/f9f0ae1bc47fbe76141cce63a6e92e3f3546ec9b.diff
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/102161
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jeffreytan81 updated
https://github.com/llvm/llvm-project/pull/102208
>From 03e22727aa470b60762baa25e20a36f875d451c3 Mon Sep 17 00:00:00 2001
From: jeffreytan81
Date: Tue, 6 Aug 2024 12:47:50 -0700
Subject: [PATCH 1/2] Fix ASAN failure in TestSingleThreadStepTimeout.py
---
https://github.com/royitaqi created
https://github.com/llvm/llvm-project/pull/102223
# TL;DR
Improve the chance of resolving file/line breakpoints by, as a second matching
attempt, realpath'ing the support files who has a matching basename and whose
path matches one of the prefixes in a setti
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (royitaqi)
Changes
# TL;DR
Improve the chance of resolving file/line breakpoints by, as a second matching
attempt, realpath'ing the support files who has a matching basename and whose
path matches one of the prefixes in a setting.
T
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/102223
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/102223
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/102223
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/102223
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/102097
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jasonmolenda wrote:
> > My question basically was: what is the stop-reply packet for a single step
> > (vCont:s) operation on arm32?
>
> ```
> b-remote.async> < 26> send packet: $vCont;s:p365766.365766#12
> b-remote.async> < 293> read packet:
> $T05thread:p365766.365766;name:test.o;threads
jasonmolenda wrote:
(on an armv8 system running AArch32 code, it still has the MDSCR_EL1.SS bit to
do instruction stepping. Genuine armv7 cores don't have that, of course)
https://github.com/llvm/llvm-project/pull/96260
___
lldb-commits mailing list
https://github.com/royitaqi updated
https://github.com/llvm/llvm-project/pull/102097
>From 8222646222673a07d52eeb2b3a02c380e253249c Mon Sep 17 00:00:00 2001
From: Roy Shi
Date: Mon, 5 Aug 2024 20:30:14 -0700
Subject: [PATCH 1/2] Make sure that a progress completed update is always
reported at
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/102097
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/royitaqi updated
https://github.com/llvm/llvm-project/pull/102097
>From 8222646222673a07d52eeb2b3a02c380e253249c Mon Sep 17 00:00:00 2001
From: Roy Shi
Date: Mon, 5 Aug 2024 20:30:14 -0700
Subject: [PATCH 1/2] Make sure that a progress completed update is always
reported at
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 396343f17b1182ff8ed698beac3f9b93b1d9dabd
a2c9310e66250a9d046b42e8446cf5b8c2ff8172 --e
https://github.com/royitaqi updated
https://github.com/llvm/llvm-project/pull/102097
>From 8222646222673a07d52eeb2b3a02c380e253249c Mon Sep 17 00:00:00 2001
From: Roy Shi
Date: Mon, 5 Aug 2024 20:30:14 -0700
Subject: [PATCH 1/2] Make sure that a progress completed update is always
reported at
jasonmolenda wrote:
On an armv7k apple watch series 3, with debugserver, it looks like
```
(lldb) si
< 16> send packet: $vCont;s:10da#18
< 297:296> read packet:
$T05thread:10da;threads:10da;thread-pcs:1d004;00:d4fcdf27;01:;02:;03:;04:;05:;06:;
royitaqi wrote:
@JDevlieghere A unit test has been added. I have confirmed that it fails
before the patch, and succeeds after the patch.
https://github.com/llvm/llvm-project/pull/102097
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https:
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/102223
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/102097
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
Thanks @royitaqi! Once the formatting is fixed this is ready to be merged.
https://github.com/llvm/llvm-project/pull/102097
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/l
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/101272
>From d28a238367aebb814be76749a3422a49963da8ac Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Tue, 30 Jul 2024 11:04:45 -0700
Subject: [PATCH 01/13] Squash 64b-memory-regions-minidump and take only
llvm-cha
jasonmolenda wrote:
With my patch from this PR applied, the Mach Exception from debugserver is
interpreted the same way -- it could be a watchpoint, a breakpoint, or an
"instruction step", we use the address included in the ME to say which one it
is, and in the ambiguous instance of instructio
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/101929
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: jeffreytan81
Date: 2024-08-06T18:08:55-07:00
New Revision: 128ef9eb533afd00da2d3d2cfeab16de6abf2640
URL:
https://github.com/llvm/llvm-project/commit/128ef9eb533afd00da2d3d2cfeab16de6abf2640
DIFF:
https://github.com/llvm/llvm-project/commit/128ef9eb533afd00da2d3d2cfeab16de6abf2640.diff
https://github.com/jeffreytan81 closed
https://github.com/llvm/llvm-project/pull/102208
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jeffreytan81 wrote:
Should fixed by https://github.com/llvm/llvm-project/pull/102208.
https://github.com/llvm/llvm-project/pull/90930
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
mizvekov wrote:
> I don't know, but it would be a lot of work, and would likely still mean
> preserving the same information as `SubstTemplateTypeParmType` nodes
> currently provide.
>
> Our scope is also larger than what Clang's resugarer aims to do, because for
> our purposes sometimes ther
https://github.com/igorkudrin created
https://github.com/llvm/llvm-project/pull/102263
There is no need to clone the content and set extraction properties because
`m_auxv` is already in the required form.
>From d3a72694e444cf19e62bceab3234b8a338aec7b1 Mon Sep 17 00:00:00 2001
From: Igor Kudrin
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Igor Kudrin (igorkudrin)
Changes
There is no need to clone the content and set extraction properties because
`m_auxv` is already in the required form.
---
Full diff: https://github.com/llvm/llvm-project/pull/102263.diff
1 Files Affected:
@@ -108,52 +113,85 @@ size_t SupportFileList::FindFileIndex(size_t start_idx,
});
}
-size_t SupportFileList::FindCompatibleIndex(size_t start_idx,
-const FileSpec &file_spec) const {
- const size_t num_files
@@ -0,0 +1,63 @@
+//===-- RealpathPrefixes.h --*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,63 @@
+//===-- RealpathPrefixes.h --*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -1077,10 +1077,10 @@ ArchSpec ProcessElfCore::GetArchitecture() {
}
DataExtractor ProcessElfCore::GetAuxvData() {
- const uint8_t *start = m_auxv.GetDataStart();
- size_t len = m_auxv.GetByteSize();
- lldb::DataBufferSP buffer(new lldb_private::DataBufferHeap(start, len)
https://github.com/igorkudrin edited
https://github.com/llvm/llvm-project/pull/102263
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -150,6 +150,9 @@ let Definition = "target" in {
DefaultEnumValue<"eInlineBreakpointsAlways">,
EnumValues<"OptionEnumValues(g_inline_breakpoint_enums)">,
Desc<"The strategy to use when settings breakpoints by file and line.
Breakpoint locations can end up being i
https://github.com/medismailben updated
https://github.com/llvm/llvm-project/pull/101934
>From 694fe108c9bc8461c1ac001033dad8285be11ac0 Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Date: Tue, 6 Aug 2024 22:05:00 -0700
Subject: [PATCH] [lldb/Interpreter] Fix ambiguous partial command resolu
https://github.com/medismailben edited
https://github.com/llvm/llvm-project/pull/101934
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/102223
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
medismailben wrote:
@Michael137 @jimingham I've addressed your comment. The test is part of the
https://github.com/llvm/llvm-project/pull/97263.
https://github.com/llvm/llvm-project/pull/101934
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
medismailben wrote:
@labath, does this looks good to you ?
https://github.com/llvm/llvm-project/pull/101929
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -180,7 +184,19 @@ class CommandObjectPlatformSelect : public
CommandObjectParsed {
m_interpreter, ArchSpec(), select, error, platform_arch));
if (platform_sp) {
GetDebugger().GetPlatformList().SetSelectedPlatform(platform_sp);
-
+ Opti
@@ -100,6 +99,9 @@ class LLDB_API SBPlatform {
SBPlatform(const char *platform_name);
+ SBPlatform(const char *platform_name, const SBDebugger &debugger,
+ const char *script_name, const SBStructuredData &dict);
+
medismailben wrote:
That soun
@@ -111,6 +111,7 @@ class SBStructuredData {
protected:
friend class SBAttachInfo;
friend class SBLaunchInfo;
+ friend class SBPlatform;
friend class SBDebugger;
friend class SBTarget;
friend class SBProcess;
medismailben wrote:
That would be nic
https://github.com/medismailben edited
https://github.com/llvm/llvm-project/pull/99814
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
royitaqi wrote:
@jimingham
> Have you checked to make sure this also works when there is a source-path
> mapping in place for the files that also differ by realpath vrs. symlink in
> the part past the part the source-path mapping substitutes? That might "just
> work" but it also seems like i
medismailben wrote:
> Is part of the goal of this class to extend another platform by being able to
> override a built in platform? If so, we might want the script platform class
> to be able to specify the name of the platform it wants to extend with a
> method. Something like:
>
> ```
> cla
labath wrote:
Umm... could we move this logic to python, and then just pass the final tool
paths (or whatever) into the makefile, like we did with the other patches (for
`(HOST_)OS`, etc.) ?
https://github.com/llvm/llvm-project/pull/102185
___
lldb-c
labath wrote:
(that said, I would be very surprised if anyone was running this test suite
with icc, so I think ripping out `icc` support is also an option)
https://github.com/llvm/llvm-project/pull/102185
___
lldb-commits mailing list
lldb-commits@lis
https://github.com/medismailben updated
https://github.com/llvm/llvm-project/pull/99814
>From 4b8ccab40914a9a6ee32939911b66fb701605c96 Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Date: Mon, 5 Aug 2024 00:49:55 -0700
Subject: [PATCH 1/2] [lldb/API] Fix SBStructuredData JSON Array parsing
@@ -0,0 +1,619 @@
+
+//===-- Telemetry.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
101 - 153 of 153 matches
Mail list logo
