[Lldb-commits] [lldb] [LLDB][SBSaveCore] Fix bug where default values are not propagated. (PR #101770)

2024-08-06 Thread Haojian Wu via lldb-commits
hokein wrote: I saw the msan failure when integrating LLVM into our internal codebase, it is a msan-build lldb. The second error `AssertionError: launching (4) != stopped (5)` occurred in a non-msan-build lldb from the upstream repository. And I ran `llvm-lit -sv lldb/test/API/functionalitie

[Lldb-commits] [lldb] [LLDB] Add `` to AddressableBits (PR #102110)

2024-08-06 Thread Sam James via lldb-commits
https://github.com/thesamesam created https://github.com/llvm/llvm-project/pull/102110 AddressableBits uses `uint32_t` without including `` which fails to build w/ GCC 15 after a change in libstdc++ [0] [0] https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=3a817a4a5a6d94da9127af3be9f84a74e3076ee2

[Lldb-commits] [lldb] [LLDB] Add `` to AddressableBits (PR #102110)

2024-08-06 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Sam James (thesamesam) Changes AddressableBits uses `uint32_t` without including `` which fails to build w/ GCC 15 after a change in libstdc++ [0] [0] https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=3a817a4a5a6d94da9127af3be9f84a74

[Lldb-commits] [lldb] [lldb] Better matching of types in anonymous namespaces (PR #102111)

2024-08-06 Thread Pavel Labath via lldb-commits
https://github.com/labath created https://github.com/llvm/llvm-project/pull/102111 This patch extends TypeQuery matching to support anonymous namespaces. A new flag is added to control the behavior. In the "strict" mode, the query must match the type exactly -- all anonymous namespaces include

[Lldb-commits] [lldb] [lldb] Better matching of types in anonymous namespaces (PR #102111)

2024-08-06 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes This patch extends TypeQuery matching to support anonymous namespaces. A new flag is added to control the behavior. In the "strict" mode, the query must match the type exactly -- all anonymous namespaces inclu

[Lldb-commits] [lldb] [LLDB] Add `` to AddressableBits (PR #102110)

2024-08-06 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/102110 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Better matching of types in anonymous namespaces (PR #102111)

2024-08-06 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r d337f5aa59fecd2413b076ed9573e378c57c1307...c6936f3d5d0592babe9082e867b179af594c447b lldb/

[Lldb-commits] [lldb] [lldb] Better matching of types in anonymous namespaces (PR #102111)

2024-08-06 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff d337f5aa59fecd2413b076ed9573e378c57c1307 c6936f3d5d0592babe9082e867b179af594c447b --e

[Lldb-commits] [lldb] [lldb] Better matching of types in anonymous namespaces (PR #102111)

2024-08-06 Thread Pavel Labath via lldb-commits
https://github.com/labath updated https://github.com/llvm/llvm-project/pull/102111 >From c6936f3d5d0592babe9082e867b179af594c447b Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Tue, 6 Aug 2024 09:51:20 +0200 Subject: [PATCH 1/2] [lldb] Better matching of types in anonymous namespaces This p

[Lldb-commits] [lldb] [LLDB] Add `` to AddressableBits (PR #102110)

2024-08-06 Thread Sam James via lldb-commits
thesamesam wrote: Thanks! https://github.com/llvm/llvm-project/pull/102110 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] bb59f04 - [LLDB] Add `` to AddressableBits (#102110)

2024-08-06 Thread via lldb-commits
Author: Sam James Date: 2024-08-06T09:58:36+01:00 New Revision: bb59f04e7e75dcbe39f1bf952304a157f0035314 URL: https://github.com/llvm/llvm-project/commit/bb59f04e7e75dcbe39f1bf952304a157f0035314 DIFF: https://github.com/llvm/llvm-project/commit/bb59f04e7e75dcbe39f1bf952304a157f0035314.diff LOG

[Lldb-commits] [lldb] [LLDB] Add `` to AddressableBits (PR #102110)

2024-08-06 Thread Sam James via lldb-commits
https://github.com/thesamesam closed https://github.com/llvm/llvm-project/pull/102110 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add `` to AddressableBits (PR #102110)

2024-08-06 Thread Sam James via lldb-commits
https://github.com/thesamesam milestoned https://github.com/llvm/llvm-project/pull/102110 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add `` to AddressableBits (PR #102110)

2024-08-06 Thread Sam James via lldb-commits
thesamesam wrote: /cherry-pick bb59f04e7e75dcbe39f1bf952304a157f0035314 https://github.com/llvm/llvm-project/pull/102110 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add `` to AddressableBits (PR #102110)

2024-08-06 Thread via lldb-commits
llvmbot wrote: /pull-request llvm/llvm-project#102112 https://github.com/llvm/llvm-project/pull/102110 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix crash when adding members to an "incomplete" type (PR #102116)

2024-08-06 Thread Pavel Labath via lldb-commits
https://github.com/labath created https://github.com/llvm/llvm-project/pull/102116 This fixes a regression caused by delayed type definition searching (#96755 and friends): If we end up adding a member (e.g. a typedef) to a type that we've already attempted to complete (and failed), the result

[Lldb-commits] [lldb] [lldb] Fix crash when adding members to an "incomplete" type (PR #102116)

2024-08-06 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes This fixes a regression caused by delayed type definition searching (#96755 and friends): If we end up adding a member (e.g. a typedef) to a type that we've already attempted to complete (and failed), the resul

[Lldb-commits] [lldb] [lldb][ClangExpressionParser] Set BuiltinHeadersInSystemModules depending on SDK version (PR #101778)

2024-08-06 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/101778 >From 3d7c2b87ec73a48de30e1c5387a7f0d8d817b0f4 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Fri, 2 Aug 2024 23:38:18 +0100 Subject: [PATCH 1/6] [lldb][ClangExpressionParser] Set BuiltinHeadersInSystemMo

[Lldb-commits] [lldb] [lldb/DWARF] Search fallback to the manual index in GetFullyQualified… (PR #102123)

2024-08-06 Thread Pavel Labath via lldb-commits
https://github.com/labath created https://github.com/llvm/llvm-project/pull/102123 …Type This is needed to ensure we find a type if its definition is in a CU that wasn't indexed. This can happen if the definition is in some precompiled code (e.g. the c++ standard library) which was built with

[Lldb-commits] [lldb] [lldb/DWARF] Search fallback to the manual index in GetFullyQualified… (PR #102123)

2024-08-06 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes …Type This is needed to ensure we find a type if its definition is in a CU that wasn't indexed. This can happen if the definition is in some precompiled code (e.g. the c++ standard library) which was built wi

[Lldb-commits] [lldb] [lldb] Better matching of types in anonymous namespaces (PR #102111)

2024-08-06 Thread Michael Buch via lldb-commits
https://github.com/Michael137 approved this pull request. LGTM, thanks! Left some stylistic comments/clarifications https://github.com/llvm/llvm-project/pull/102111 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[Lldb-commits] [lldb] [lldb] Better matching of types in anonymous namespaces (PR #102111)

2024-08-06 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/102111 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Better matching of types in anonymous namespaces (PR #102111)

2024-08-06 Thread Michael Buch via lldb-commits
@@ -788,7 +808,10 @@ Type::GetTypeScopeAndBasename(llvm::StringRef name) { switch (pos.value()) { case ':': if (prev_is_colon && template_depth == 0) { -result.scope.push_back(name.slice(name_begin, pos.index() - 1)); +llvm::StringRef scope_name =

[Lldb-commits] [lldb] [lldb] Better matching of types in anonymous namespaces (PR #102111)

2024-08-06 Thread Michael Buch via lldb-commits
@@ -111,4 +115,22 @@ TEST(Type, CompilerContextPattern) { Matches(std::vector{make_class("C")})); EXPECT_THAT((std::vector{make_namespace("NS"), make_class("C")}), Not(Matches(std::vector{make_any_type("C")}))); + + EXPECT_THAT((std::vector{make_n

[Lldb-commits] [lldb] [lldb] Better matching of types in anonymous namespaces (PR #102111)

2024-08-06 Thread Michael Buch via lldb-commits
@@ -145,10 +159,16 @@ bool TypeQuery::ContextMatches( ++pat; } - // Skip over any remaining module entries if we were asked to do that. - while (GetIgnoreModules() && ctx != ctx_end && - ctx->kind == CompilerContextKind::Module) -++ctx; + // Skip over any

[Lldb-commits] [lldb] [lldb] Better matching of types in anonymous namespaces (PR #102111)

2024-08-06 Thread Michael Buch via lldb-commits
@@ -266,6 +269,11 @@ class TypeQuery { bool GetIgnoreModules() const { return (m_options & e_ignore_modules) != 0; } void SetIgnoreModules() { m_options &= ~e_ignore_modules; } + bool GetStrictNamespaces() const { +return (m_options & e_strict_namespaces) != 0; + } +

[Lldb-commits] [lldb] [lldb] Better matching of types in anonymous namespaces (PR #102111)

2024-08-06 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/102111 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Better matching of types in anonymous namespaces (PR #102111)

2024-08-06 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/102111 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix crash when adding members to an "incomplete" type (PR #102116)

2024-08-06 Thread Michael Buch via lldb-commits
@@ -0,0 +1,23 @@ +// RUN: %clangxx --target=x86_64-pc-linux -o %t -c %s -g Michael137 wrote: This would only crash with `-flimit-debug-info` right? Could we add that here? Also should we move it to the non-x86 directory? Not sure what the intent behind the x86 d

[Lldb-commits] [lldb] [lldb] Updated lldb-server to spawn the child process and share socket on Windows (PR #101283)

2024-08-06 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman updated https://github.com/llvm/llvm-project/pull/101283 >From 6b2a41ba3d71270e81e24a42d3b4f5dc2f96b939 Mon Sep 17 00:00:00 2001 From: Dmitry Vasilyev Date: Wed, 31 Jul 2024 05:41:21 +0400 Subject: [PATCH 1/2] [lldb] Updated lldb-server to spawn the child process and

[Lldb-commits] [lldb] [lldb] Updated lldb-server to spawn the child process and share socket (PR #101283)

2024-08-06 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman edited https://github.com/llvm/llvm-project/pull/101283 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Updated lldb-server to spawn the child process and share socket (PR #101283)

2024-08-06 Thread Dmitry Vasilyev via lldb-commits
slydiman wrote: I have updated the patch to spawn the child process on non-Windows too and minimized the number of `#ifdef _WIN32`. https://github.com/llvm/llvm-project/pull/101283 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://list

[Lldb-commits] [lldb] [lldb] Updated lldb-server to spawn the child process and share socket (PR #101283)

2024-08-06 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman updated https://github.com/llvm/llvm-project/pull/101283 >From 6b2a41ba3d71270e81e24a42d3b4f5dc2f96b939 Mon Sep 17 00:00:00 2001 From: Dmitry Vasilyev Date: Wed, 31 Jul 2024 05:41:21 +0400 Subject: [PATCH 1/2] [lldb] Updated lldb-server to spawn the child process and

[Lldb-commits] [lldb] [lldb] Updated lldb-server to spawn the child process and share socket (PR #101283)

2024-08-06 Thread Pavel Labath via lldb-commits
labath wrote: I would start looking at this from the other end. Let's identify logical pieces of functionality that can be shared between the various modes of operation (fork/exec/singleserver), and try to refactor to code to fit that. While doing that, I think an important criteria should be

[Lldb-commits] [lldb] [lldb] Updated lldb-server to spawn the child process and share socket (PR #101283)

2024-08-06 Thread Pavel Labath via lldb-commits
labath wrote: We raced updating the PR, so I didn't see the new version. I think the new version is looking better. I'm going to comment in more detail soon. https://github.com/llvm/llvm-project/pull/101283 ___ lldb-commits mailing list lldb-commits@l

[Lldb-commits] [lldb] [lldb] Updated lldb-server to spawn the child process and share socket (PR #101283)

2024-08-06 Thread Dmitry Vasilyev via lldb-commits
slydiman wrote: @labath Please look at the updated patch. ServeSingleConnection() = client_handle() AcceptConnectionFromParent() = some code + client_handle() ServeInSubprocess() = spawn_process() lldb-platform.cpp is simple. Currently we don't see the whole picture before the part 2 of this pa

[Lldb-commits] [clang] [lldb] [clang][AST] fix ast-print of extern with >=2 declarators, fixed, fixed (PR #98795)

2024-08-06 Thread Aaron Ballman via lldb-commits
AaronBallman wrote: Ping @JDevlieghere for lldb test suite assistance. As for ORC JIT, [the compiler-rt project](https://compiler-rt.llvm.org/) does not claim to support Windows to begin with, so it's unclear whether the bot should not be testing on Windows or whether compiler-rt needs to upda

[Lldb-commits] [lldb] [LLDB][test] Update Makefile.rules to support Windows host+Linux target (PR #99266)

2024-08-06 Thread Vladislav Dzhidzhoev via lldb-commits
dzhidzhoev wrote: Thank you! https://github.com/llvm/llvm-project/pull/99266 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] a0fa9a3 - [LLDB][test] Update Makefile.rules to support Windows host+Linux target (#99266)

2024-08-06 Thread via lldb-commits
Author: Vladislav Dzhidzhoev Date: 2024-08-06T15:07:12+02:00 New Revision: a0fa9a308d20786ceb63b5d021c7f643ea2ef1c2 URL: https://github.com/llvm/llvm-project/commit/a0fa9a308d20786ceb63b5d021c7f643ea2ef1c2 DIFF: https://github.com/llvm/llvm-project/commit/a0fa9a308d20786ceb63b5d021c7f643ea2ef1c

[Lldb-commits] [lldb] [LLDB][test] Update Makefile.rules to support Windows host+Linux target (PR #99266)

2024-08-06 Thread Vladislav Dzhidzhoev via lldb-commits
https://github.com/dzhidzhoev closed https://github.com/llvm/llvm-project/pull/99266 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix crash when adding members to an "incomplete" type (PR #102116)

2024-08-06 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,23 @@ +// RUN: %clangxx --target=x86_64-pc-linux -o %t -c %s -g labath wrote: > This would only crash with -flimit-debug-info right? Correct. The type definition needs to be absent from the binary and the ~only way to achieve that is to compile at lea

[Lldb-commits] [lldb] [lldb] Fix crash when adding members to an "incomplete" type (PR #102116)

2024-08-06 Thread Pavel Labath via lldb-commits
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/102116 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix crash when adding members to an "incomplete" type (PR #102116)

2024-08-06 Thread Pavel Labath via lldb-commits
https://github.com/labath updated https://github.com/llvm/llvm-project/pull/102116 >From c5373215793f744ab80b80e394354e455b415fcb Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Tue, 6 Aug 2024 11:36:31 +0200 Subject: [PATCH 1/2] [lldb] Fix crash when adding members to an "incomplete" type

[Lldb-commits] [clang] [lldb] [clang][AST] fix ast-print of extern with >=2 declarators, fixed, fixed (PR #98795)

2024-08-06 Thread Pavel Labath via lldb-commits
labath wrote: I don't have the full context but I can definitely run the lldb test suite for you. I'm building now. (BTW, I see there are some merge conflicts on the PR.) https://github.com/llvm/llvm-project/pull/98795 ___ lldb-commits mailing list ll

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [clang] Reland: Instantiate alias templates with sugar (PR #101858)

2024-08-06 Thread Dmitri Gribenko via lldb-commits
gribozavr wrote: > So from my undertstanding, IWYU only needs the SubstTemplateTypeParmType for > resugaring purposes, in order to recover the type as written by the user. > > But with this patch we are doing the substitution already with sugar, so > there is no need to resugar, so IWYU should

[Lldb-commits] [clang] [lldb] [clang][AST] fix ast-print of extern with >=2 declarators, fixed, fixed (PR #98795)

2024-08-06 Thread Pavel Labath via lldb-commits
labath wrote: > I don't have the full context but I can definitely run the lldb test suite > for you. I'm building now. (BTW, I see there are some merge conflicts on the > PR.) I have the results now. The patch is based on a fairly old revision, so it didn't work for me without a python 3.12

[Lldb-commits] [lldb] [lldb] Fix crash when adding members to an "incomplete" type (PR #102116)

2024-08-06 Thread Michael Buch via lldb-commits
@@ -0,0 +1,23 @@ +// RUN: %clangxx --target=x86_64-pc-linux -o %t -c %s -g Michael137 wrote: Ahh got it I saw the tests in this directory weren't run on my M1 and misinterpreted that. ``` The thing I like about a test like this is that it (again, like the llvm t

[Lldb-commits] [lldb] [lldb] Fix crash when adding members to an "incomplete" type (PR #102116)

2024-08-06 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/102116 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Docs] Add edit link to docs pages (PR #102144)

2024-08-06 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/102144 That aren't the generated `python_api/` pages. This button is a pencil icon at the top right of the page and takes you to a GitHub page where you can edit the content, assuming you have a fork already. I

[Lldb-commits] [lldb] [lldb][Docs] Add edit link to docs pages (PR #102144)

2024-08-06 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) Changes That aren't the generated `python_api/` pages. This button is a pencil icon at the top right of the page and takes you to a GitHub page where you can edit the content, assuming you have a fork already

[Lldb-commits] [lldb] [lldb][Docs] Add edit link to docs pages (PR #102144)

2024-08-06 Thread David Spickett via lldb-commits
DavidSpickett wrote: https://github.com/pradyunsg/furo/blob/main/src/furo/theme/furo/components/edit-this-page.html is the file that gets extended. https://github.com/llvm/llvm-project/pull/102144 ___ lldb-commits mailing list lldb-commits@lists.llvm.

[Lldb-commits] [lldb] [lldb][Docs] Add edit link to docs pages (PR #102144)

2024-08-06 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 4c670b266a10d613a58b71cc9c3d3a21cb6dc36b...8fddf6f57dcb4bcdef78139f49718fcc2ea0fd20 lldb/

[Lldb-commits] [lldb] [lldb][Docs] Add edit link to docs pages (PR #102144)

2024-08-06 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/102144 >From 8fddf6f57dcb4bcdef78139f49718fcc2ea0fd20 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Tue, 6 Aug 2024 13:25:32 +0100 Subject: [PATCH 1/2] [lldb][Docs] Add edit link to docs pages That aren't

[Lldb-commits] [lldb] [lldb][Docs] Add edit link to docs pages (PR #102144)

2024-08-06 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben approved this pull request. https://github.com/llvm/llvm-project/pull/102144 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][TypeSystemClang] Pass ClangASTMetadata around by value (PR #102161)

2024-08-06 Thread Michael Buch via lldb-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/102161 This patch changes the return type of `GetMetadata` from a `ClangASTMetadata*` to a `std::optional`. Except for one call-site (`SetDeclIsForcefullyCompleted`), we never actually make use of the mutability o

[Lldb-commits] [lldb] [lldb][TypeSystemClang] Pass ClangASTMetadata around by value (PR #102161)

2024-08-06 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes This patch changes the return type of `GetMetadata` from a `ClangASTMetadata*` to a `std::optional`. Except for one call-site (`SetDeclIsForcefullyCompleted`), we never actually make use

[Lldb-commits] [lldb] [lldb][TypeSystemClang] Pass ClangASTMetadata around by value (PR #102161)

2024-08-06 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/102161 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][TypeSystemClang] Pass ClangASTMetadata around by value (PR #102161)

2024-08-06 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/102161 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][TypeSystemClang] Pass ClangASTMetadata around by value (PR #102161)

2024-08-06 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. Makes sense. https://github.com/llvm/llvm-project/pull/102161 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][TypeSystemClang] Pass ClangASTMetadata around by value (PR #102161)

2024-08-06 Thread Jonas Devlieghere via lldb-commits
@@ -219,9 +219,9 @@ void ClangUserExpression::ScanContext(ExecutionContext &exe_ctx, Status &err) { // whatever runtime the debug info says the object pointer belongs to. Do // that here. -ClangASTMetadata *metadata = -TypeSystemClang::DeclContextGetMetaD

[Lldb-commits] [lldb] Make sure that a `Progress` "completed" update is always reported at destruction (PR #102097)

2024-08-06 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM. Could we cover this scenario by the existing unit test? https://github.com/llvm/llvm-project/pull/102097 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org

[Lldb-commits] [lldb] [lldb][ClangExpressionParser] Set BuiltinHeadersInSystemModules depending on SDK version (PR #101778)

2024-08-06 Thread Jonas Devlieghere via lldb-commits
@@ -561,7 +562,85 @@ static void SetupLangOpts(CompilerInstance &compiler, lang_opts.NoBuiltin = true; } -static void SetupImportStdModuleLangOpts(CompilerInstance &compiler) { +// NOTE: should be kept in sync with sdkSupportsBuiltinModules in +// Toolchains/Darwin.cpp +stat

[Lldb-commits] [lldb] [lldb][TypeSystemClang] Pass ClangASTMetadata around by value (PR #102161)

2024-08-06 Thread Michael Buch via lldb-commits
@@ -219,9 +219,9 @@ void ClangUserExpression::ScanContext(ExecutionContext &exe_ctx, Status &err) { // whatever runtime the debug info says the object pointer belongs to. Do // that here. -ClangASTMetadata *metadata = -TypeSystemClang::DeclContextGetMetaD

[Lldb-commits] [lldb] [lldb][ClangExpressionParser] Set BuiltinHeadersInSystemModules depending on SDK version (PR #101778)

2024-08-06 Thread Michael Buch via lldb-commits
@@ -561,7 +562,85 @@ static void SetupLangOpts(CompilerInstance &compiler, lang_opts.NoBuiltin = true; } -static void SetupImportStdModuleLangOpts(CompilerInstance &compiler) { +// NOTE: should be kept in sync with sdkSupportsBuiltinModules in +// Toolchains/Darwin.cpp +stat

[Lldb-commits] [lldb] [lldb][ClangExpressionParser] Set BuiltinHeadersInSystemModules depending on SDK version (PR #101778)

2024-08-06 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/101778 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][TypeSystemClang] Pass ClangASTMetadata around by value (PR #102161)

2024-08-06 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/102161 >From 624022e5737e7c51aa4976928183fa099503437c Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Tue, 6 Aug 2024 15:16:56 +0100 Subject: [PATCH 1/2] [lldb][TypeSystemClang] Pass ClangASTMetadata around by va

[Lldb-commits] [lldb] [lldb][debuginfod] Fix the DebugInfoD PR that caused issues when working with stripped binaries (PR #99362)

2024-08-06 Thread Kevin Frei via lldb-commits
kevinfrei wrote: Ping @JDevlieghere https://github.com/llvm/llvm-project/pull/99362 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [clang] Reland: Instantiate alias templates with sugar (PR #101858)

2024-08-06 Thread Matheus Izvekov via lldb-commits
mizvekov wrote: > I agree that we don't need `SubstTemplateTypeParmType` nodes if all > resuraging that we ever do is related to types that the Clang frontend itself > knows. However that is not universally true. > > For example, we (Google) have a tool for inferring and checking nullability

[Lldb-commits] [clang] [lldb] [clang][AST] fix ast-print of extern with >=2 declarators, fixed, fixed (PR #98795)

2024-08-06 Thread via lldb-commits
temyurchenko wrote: > > I don't have the full context but I can definitely run the lldb test suite > > for you. I'm building now. (BTW, I see there are some merge conflicts on > > the PR.) > > I have the results now. The patch is based on a fairly old revision, so it > didn't work for me with

[Lldb-commits] [clang] [lldb] [clang][AST] fix ast-print of extern with >=2 declarators, fixed, fixed (PR #98795)

2024-08-06 Thread via lldb-commits
https://github.com/temyurchenko updated https://github.com/llvm/llvm-project/pull/98795 >From 24ee56b5a104bdc8434413458f23b2d271764c78 Mon Sep 17 00:00:00 2001 From: Artem Yurchenko <44875844+temyurche...@users.noreply.github.com> Date: Thu, 30 May 2024 16:18:47 -0400 Subject: [PATCH 1/4] [clang

[Lldb-commits] [lldb] [lldb][TypeSystemClang] Pass ClangASTMetadata around by value (PR #102161)

2024-08-06 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/102161 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Make sure that a `Progress` "completed" update is always reported at destruction (PR #102097)

2024-08-06 Thread via lldb-commits
royitaqi wrote: > LGTM. Could we cover this scenario by the existing unit test? Yes, definitely. At the time of the patch I didn't find any existing unit test files by searching for "ProgressTest.cpp". Just now I realize there is the [ProgressReportTest.cpp](https://github.com/llvm/llvm-proje

[Lldb-commits] [lldb] [lldb][ClangExpressionParser] Set BuiltinHeadersInSystemModules depending on SDK version (PR #101778)

2024-08-06 Thread Michael Buch via lldb-commits
Michael137 wrote: Talked to Adrian and we decided it's best if we landed this on the apple/llvm-project fork 6.0 branch. There's a larger refactor we'll do on llvm.org main instead (mainly re-using the PlatformDarwin and HostInfo utilities to get the correct SDK directory, instead of the DWARF

[Lldb-commits] [lldb] [lldb][ClangExpressionParser] Set BuiltinHeadersInSystemModules depending on SDK version (PR #101778)

2024-08-06 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/101778 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] New ThreadPlanSingleThreadTimeout to resolve potential deadlock in single thread stepping (PR #90930)

2024-08-06 Thread via lldb-commits
jimingham wrote: This patch almost certainly caused this asan failure: https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/lldb-cmake-sanitized/581/consoleText Can you take a look? https://github.com/llvm/llvm-project/pull/90930 ___ lldb-commits ma

[Lldb-commits] [lldb] New ThreadPlanSingleThreadTimeout to resolve potential deadlock in single thread stepping (PR #90930)

2024-08-06 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: @jimingham Should we revert the patch until this is fixed or are there more patches depending on this? https://github.com/llvm/llvm-project/pull/90930 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.or

[Lldb-commits] [lldb] [lldb][test] Improve toolchain detection in Makefile.rules (PR #102185)

2024-08-06 Thread Vladislav Dzhidzhoev via lldb-commits
https://github.com/dzhidzhoev created https://github.com/llvm/llvm-project/pull/102185 This fix is based on a problem with cxx_compiler and cxx_linker macros on Windows. There was an issue with compiler detection in paths containing "icc". In such case, Makefile.rules thought it was provided w

[Lldb-commits] [lldb] [lldb][test] Improve toolchain detection in Makefile.rules (PR #102185)

2024-08-06 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Vladislav Dzhidzhoev (dzhidzhoev) Changes This fix is based on a problem with cxx_compiler and cxx_linker macros on Windows. There was an issue with compiler detection in paths containing "icc". In such case, Makefile.rules thought it was

[Lldb-commits] [lldb] [lldb][test] Improve toolchain detection in Makefile.rules (PR #102185)

2024-08-06 Thread Vladislav Dzhidzhoev via lldb-commits
https://github.com/dzhidzhoev edited https://github.com/llvm/llvm-project/pull/102185 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Improve toolchain detection in Makefile.rules (PR #102185)

2024-08-06 Thread Vladislav Dzhidzhoev via lldb-commits
https://github.com/dzhidzhoev edited https://github.com/llvm/llvm-project/pull/102185 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/Plugins] Introduce Scripted Platform Plugin (PR #99814)

2024-08-06 Thread via lldb-commits
@@ -1003,6 +1010,21 @@ class Platform : public PluginInterface { FileSpec GetModuleCacheRoot(); }; +class PlatformMetadata { +public: + PlatformMetadata(Debugger &debugger, const ScriptedMetadata metadata); + ~PlatformMetadata() = default; + + Debugger &GetDebugger() cons

[Lldb-commits] [lldb] [lldb/Plugins] Introduce Scripted Platform Plugin (PR #99814)

2024-08-06 Thread via lldb-commits
https://github.com/jimingham edited https://github.com/llvm/llvm-project/pull/99814 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Improve toolchain detection in Makefile.rules (PR #102185)

2024-08-06 Thread Vladislav Dzhidzhoev via lldb-commits
https://github.com/dzhidzhoev updated https://github.com/llvm/llvm-project/pull/102185 >From 5b3f0df1c35dc2f02d15da0e3222d6f5388e6f92 Mon Sep 17 00:00:00 2001 From: Vladislav Dzhidzhoev Date: Sat, 27 Jul 2024 02:39:32 +0200 Subject: [PATCH 1/2] [lldb][test] Improve toolchain detection in Makef

[Lldb-commits] [lldb] New ThreadPlanSingleThreadTimeout to resolve potential deadlock in single thread stepping (PR #90930)

2024-08-06 Thread via lldb-commits
jimingham wrote: This is a pretty big patch, since it's only failing on ASAN bots, I'd give @jeffreytan81 a bit to see if it's something obvious before reverting that. reverts aren't 100% free, they can make cherrypicking a hassle, so... https://github.com/llvm/llvm-project/pull/90930 ___

[Lldb-commits] [lldb] [lldb][debuginfod] Fix the DebugInfoD PR that caused issues when working with stripped binaries (PR #99362)

2024-08-06 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/99362 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] e77ac42 - [lldb][debuginfod] Fix the DebugInfoD PR that caused issues when working with stripped binaries (#99362)

2024-08-06 Thread via lldb-commits
Author: Kevin Frei Date: 2024-08-06T11:06:04-07:00 New Revision: e77ac42bccb8c26bbf4b74d8e92eb09e7fa1b218 URL: https://github.com/llvm/llvm-project/commit/e77ac42bccb8c26bbf4b74d8e92eb09e7fa1b218 DIFF: https://github.com/llvm/llvm-project/commit/e77ac42bccb8c26bbf4b74d8e92eb09e7fa1b218.diff LO

[Lldb-commits] [lldb] [lldb][debuginfod] Fix the DebugInfoD PR that caused issues when working with stripped binaries (PR #99362)

2024-08-06 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/99362 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] New ThreadPlanSingleThreadTimeout to resolve potential deadlock in single thread stepping (PR #90930)

2024-08-06 Thread via lldb-commits
jeffreytan81 wrote: @jimingham, @adrian-prantl , thanks for letting me know. Surprised that I did not get failure email. Do you know how I can reproduce the failure? https://github.com/llvm/llvm-project/pull/90930 ___ lldb-commits mailing list lldb

[Lldb-commits] [lldb] [llvm] [Obj2Yaml] Add support for minidump generation with 64b memory ranges. (PR #101272)

2024-08-06 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/101272 >From 78ab13e3da15832117a7e2f8f85090a63482ca41 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Tue, 30 Jul 2024 11:04:45 -0700 Subject: [PATCH 01/10] Squash 64b-memory-regions-minidump and take only llvm-cha

[Lldb-commits] [lldb] [llvm] [Obj2Yaml] Add support for minidump generation with 64b memory ranges. (PR #101272)

2024-08-06 Thread Jacob Lalonde via lldb-commits
@@ -132,6 +140,79 @@ class MinidumpFile : public Binary { size_t Stride; }; +class Memory64Iterator { + public: +static Memory64Iterator begin(ArrayRef Storage, ArrayRef Descriptors, uint64_t BaseRVA) { + return Memory64Iterator(Storage, Descriptors, BaseRVA);

[Lldb-commits] [lldb] New ThreadPlanSingleThreadTimeout to resolve potential deadlock in single thread stepping (PR #90930)

2024-08-06 Thread via lldb-commits
jimingham wrote: The console logs for the bots usually have the CMake command used to configure the tree for the test. The one I referred to above has: '/usr/local/bin/cmake' '-G' 'Ninja' '/Users/ec2-user/jenkins/workspace/llvm.org/lldb-cmake-sanitized/llvm-project/llvm' '-DCMAKE_BUILD_TYPE

[Lldb-commits] [lldb] [lldb/Plugins] Introduce Scripted Platform Plugin (PR #99814)

2024-08-06 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: I haven't had a chance to review this, but I would appreciate if we can keep in mind how this might affect breaking up the platforms. Right now, the Platform abstraction covers two concepts: 1. How you connect to a platform and do things like transfer files, list processe

[Lldb-commits] [lldb] [llvm] [Obj2Yaml] Add support for minidump generation with 64b memory ranges. (PR #101272)

2024-08-06 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/101272 >From d28a238367aebb814be76749a3422a49963da8ac Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Tue, 30 Jul 2024 11:04:45 -0700 Subject: [PATCH 01/11] Squash 64b-memory-regions-minidump and take only llvm-cha

[Lldb-commits] [lldb] New ThreadPlanSingleThreadTimeout to resolve potential deadlock in single thread stepping (PR #90930)

2024-08-06 Thread via lldb-commits
jeffreytan81 wrote: I think I understand the lifetime issue that caused the ASAN failure. I will fix it. https://github.com/llvm/llvm-project/pull/90930 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[Lldb-commits] [lldb] [llvm] [Obj2Yaml] Add support for minidump generation with 64b memory ranges. (PR #101272)

2024-08-06 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/101272 >From d28a238367aebb814be76749a3422a49963da8ac Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Tue, 30 Jul 2024 11:04:45 -0700 Subject: [PATCH 01/12] Squash 64b-memory-regions-minidump and take only llvm-cha

[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Support minidumps where there are multiple exception streams (PR #97470)

2024-08-06 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond closed https://github.com/llvm/llvm-project/pull/97470 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [llvm]Added lib/Telemetry (PR #98528)

2024-08-06 Thread Vy Nguyen via lldb-commits
@@ -0,0 +1,619 @@ + +//===-- Telemetry.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [lldb] [llvm] [llvm]Added lib/Telemetry (PR #98528)

2024-08-06 Thread Vy Nguyen via lldb-commits
@@ -0,0 +1,619 @@ + +//===-- Telemetry.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [lldb] Fix ASAN failure in TestSingleThreadStepTimeout.py (PR #102208)

2024-08-06 Thread via lldb-commits
https://github.com/jeffreytan81 created https://github.com/llvm/llvm-project/pull/102208 This PR fixes the ASAN failure in https://github.com/llvm/llvm-project/pull/90930. The original PR made the assumption that parent `ThreadPlanStepOverRange`'s lifetime will always be longer than `ThreadP

[Lldb-commits] [lldb] Fix ASAN failure in TestSingleThreadStepTimeout.py (PR #102208)

2024-08-06 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (jeffreytan81) Changes This PR fixes the ASAN failure in https://github.com/llvm/llvm-project/pull/90930. The original PR made the assumption that parent `ThreadPlanStepOverRange`'s lifetime will always be longer than `ThreadPlanSin

  1   2   >