https://github.com/labath commented:
I've made one pass over the PR. I think this would be easier to review if it
was split into multiple patches:
- core llvm infrastructure
- core lldb infrastructure
- ~one patch per event type
I think the biggest hurdle will be finding someone to approve the
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/98528
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,153 @@
+#ifndef LLDB_CORE_TELEMETRY_H
+#define LLDB_CORE_TELEMETRY_H
+
+#include
+#include
+#include
+#include
+#include
+#include
+
+#include "lldb/Interpreter/CommandReturnObject.h"
+#include "lldb/Utility/StructuredData.h"
+#include "lldb/lldb-forward.h"
+#incl
@@ -0,0 +1,619 @@
+
+//===-- Telemetry.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -0,0 +1,619 @@
+
labath wrote:
delete empty line
https://github.com/llvm/llvm-project/pull/98528
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -9,10 +9,12 @@
#ifndef LLDB_API_SBDEBUGGER_H
#define LLDB_API_SBDEBUGGER_H
+#include
labath wrote:
Is this used anywhere?
https://github.com/llvm/llvm-project/pull/98528
___
lldb-commits mailing list
lldb-commi
@@ -0,0 +1,619 @@
+
+//===-- Telemetry.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -34,6 +34,7 @@
#include "lldb/API/SBTypeNameSpecifier.h"
#include "lldb/API/SBTypeSummary.h"
#include "lldb/API/SBTypeSynthetic.h"
+#include
labath wrote:
`` is
[banned](https://llvm.org/docs/CodingStandards.html#include-iostream-is-forbidden)
in llvm, b
@@ -0,0 +1,153 @@
+#ifndef LLDB_CORE_TELEMETRY_H
+#define LLDB_CORE_TELEMETRY_H
+
+#include
+#include
+#include
+#include
+#include
+#include
+
+#include "lldb/Interpreter/CommandReturnObject.h"
+#include "lldb/Utility/StructuredData.h"
+#include "lldb/lldb-forward.h"
+#incl
@@ -0,0 +1,619 @@
+
+//===-- Telemetry.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -0,0 +1,153 @@
+#ifndef LLDB_CORE_TELEMETRY_H
+#define LLDB_CORE_TELEMETRY_H
+
+#include
+#include
+#include
+#include
+#include
+#include
+
+#include "lldb/Interpreter/CommandReturnObject.h"
+#include "lldb/Utility/StructuredData.h"
+#include "lldb/lldb-forward.h"
+#incl
@@ -0,0 +1,619 @@
+
+//===-- Telemetry.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -0,0 +1,153 @@
+#ifndef LLDB_CORE_TELEMETRY_H
+#define LLDB_CORE_TELEMETRY_H
+
+#include
+#include
+#include
+#include
+#include
+#include
+
+#include "lldb/Interpreter/CommandReturnObject.h"
+#include "lldb/Utility/StructuredData.h"
+#include "lldb/lldb-forward.h"
+#incl
DavidSpickett wrote:
Please remove the formatting changes and limit this to just the specifier
change.
I know most of the time we'd want it formatted but for a fix as limited as
this, the formatting change just gets in the way, and not formatting it doesn't
block merging either.
Otherwise th
DavidSpickett wrote:
The bot will complain again but we will ignore it :)
https://github.com/llvm/llvm-project/pull/94783
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath commented:
The field this is consuming is actually 17 bytes long, because the process name
is in parenthesis. I suspect this will cause the function to reject any process
whose name is longer than 13 characters.
The name field is actually quite hard to parse this way
https://github.com/DavidSpickett requested changes to this pull request.
> The field this is consuming is actually 17 bytes long, because the process
> name is in parenthesis.
Ok then I am confused how this ever worked, but it sounds like scanf was never
a great way to do this anyway?
https:/
labath wrote:
> > The field this is consuming is actually 17 bytes long, because the process
> > name is in parenthesis.
>
> Ok then I am confused how this ever worked, but it sounds like scanf was
> never a great way to do this anyway?
The field it's overwriting is in a struct, so it has a l
@@ -0,0 +1,153 @@
+#ifndef LLDB_CORE_TELEMETRY_H
+#define LLDB_CORE_TELEMETRY_H
+
+#include
+#include
+#include
+#include
+#include
+#include
+
+#include "lldb/Interpreter/CommandReturnObject.h"
+#include "lldb/Utility/StructuredData.h"
+#include "lldb/lldb-forward.h"
+#incl
https://github.com/xgupta updated
https://github.com/llvm/llvm-project/pull/95678
>From ef5b9cefb408ca3a721c95d8f6702abba77a602b Mon Sep 17 00:00:00 2001
From: Shivam Gupta
Date: Sun, 16 Jun 2024 00:21:51 +0530
Subject: [PATCH 1/3] [LLDB] Add an assert to verify sign_bit_pos is within the
vali
https://github.com/aaupov edited https://github.com/llvm/llvm-project/pull/99979
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/aaupov closed https://github.com/llvm/llvm-project/pull/99979
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/aaupov edited https://github.com/llvm/llvm-project/pull/99988
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/aaupov closed https://github.com/llvm/llvm-project/pull/99988
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/100387
As reported in https://github.com/llvm/llvm-project/issues/89710, the %s code
used for `comm` could and probably does, overflow the buffer. Likely we haven't
seen it cause problems because the following d
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: David Spickett (DavidSpickett)
Changes
As reported in https://github.com/llvm/llvm-project/issues/89710, the %s code
used for `comm` could and probably does, overflow the buffer. Likely we haven't
seen it cause problems because the followi
https://github.com/aaupov edited
https://github.com/llvm/llvm-project/pull/100299
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/aaupov closed
https://github.com/llvm/llvm-project/pull/100299
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/100421
Prevent passing a nullptr to std::string::insert in
ObjectFileMachO::GetDependentModules. Calling GetCString on an empty
ConstString will return a nullptr, which is undefined behavior. Instead,
use the GetSt
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
Prevent passing a nullptr to std::string::insert in
ObjectFileMachO::GetDependentModules. Calling GetCString on an empty
ConstString will return a nullptr, which is undefined behavior. Instead,
use th
JDevlieghere wrote:
This PR looks scarier than it is because it contains an NFC commit that
introduces an early return to save a level of indentation. I recommend
reviewing the two commits separately and/or ignoring whitespace changes.
https://github.com/llvm/llvm-project/pull/100421
https://github.com/bulbazord approved this pull request.
The change looks good to me. Please make sure you update the commit message so
it accurately reflects the change since there were a few revisions. :)
https://github.com/llvm/llvm-project/pull/94779
https://github.com/bulbazord requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/95678
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -746,27 +746,18 @@ Status Scalar::SetValueFromData(const DataExtractor &data,
bool Scalar::SignExtend(uint32_t sign_bit_pos) {
const uint32_t max_bit_pos = GetByteSize() * 8;
- if (sign_bit_pos < max_bit_pos) {
-switch (m_type) {
-case Scalar::e_void:
-case S
@@ -746,27 +746,18 @@ Status Scalar::SetValueFromData(const DataExtractor &data,
bool Scalar::SignExtend(uint32_t sign_bit_pos) {
const uint32_t max_bit_pos = GetByteSize() * 8;
- if (sign_bit_pos < max_bit_pos) {
-switch (m_type) {
-case Scalar::e_void:
-case S
https://github.com/bulbazord approved this pull request.
LGTM.
It becomes less scary to review if you use Github's "Ignore Whitespace" feature
in its code review tool. I wish it was more discoverable. :)
https://github.com/llvm/llvm-project/pull/100421
_
https://github.com/Jlalond created
https://github.com/llvm/llvm-project/pull/100443
In #98403 I enabled the SBSaveCoreOptions object, which allows users via the
scripting API to define what they want saved into their core file. As the first
option I've added a threadlist, so users can scan and
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jacob Lalonde (Jlalond)
Changes
In #98403 I enabled the SBSaveCoreOptions object, which allows users
via the scripting API to define what they want saved into their core file. As
the first option I've added a threadlist, so users can scan
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 0ee0eeb4bb9be6aeef6c84121ca1af463840fb6a
17ff879cd22452fca73c0d4790ebe66c0145ae2a --e
https://github.com/clayborg commented:
Update the public API to user SBThread instead of the thread IDs and then add
some tests.
https://github.com/llvm/llvm-project/pull/100443
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.l
@@ -53,6 +53,30 @@ class LLDB_API SBSaveCoreOptions {
/// \return The output file spec.
SBFileSpec GetOutputFile() const;
+ /// Add a thread to save in the core file.
+ ///
+ /// \param thread_id The thread ID to save.
+ void AddThread(lldb::tid_t thread_id);
-
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/100443
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -32,12 +33,21 @@ class SaveCoreOptions {
void SetOutputFile(lldb_private::FileSpec file);
const std::optional GetOutputFile() const;
+ void AddThread(lldb::tid_t tid);
+ bool RemoveThread(lldb::tid_t tid);
+ size_t GetNumThreads() const;
+ int64_t GetThreadAtIndex(s
@@ -53,6 +53,30 @@ class LLDB_API SBSaveCoreOptions {
/// \return The output file spec.
SBFileSpec GetOutputFile() const;
+ /// Add a thread to save in the core file.
+ ///
+ /// \param thread_id The thread ID to save.
+ void AddThread(lldb::tid_t thread_id);
+
+ ///
@@ -46,8 +46,59 @@ SaveCoreOptions::GetOutputFile() const {
return m_file;
}
+void SaveCoreOptions::AddThread(lldb::tid_t tid) {
+ if (m_threads_to_save.count(tid) == 0)
+m_threads_to_save.emplace(tid);
+}
+
+bool SaveCoreOptions::RemoveThread(lldb::tid_t tid) {
+ if (
@@ -46,8 +46,59 @@ SaveCoreOptions::GetOutputFile() const {
return m_file;
}
+void SaveCoreOptions::AddThread(lldb::tid_t tid) {
+ if (m_threads_to_save.count(tid) == 0)
+m_threads_to_save.emplace(tid);
clayborg wrote:
No need to check the count, and n
@@ -46,8 +46,59 @@ SaveCoreOptions::GetOutputFile() const {
return m_file;
}
+void SaveCoreOptions::AddThread(lldb::tid_t tid) {
+ if (m_threads_to_save.count(tid) == 0)
+m_threads_to_save.emplace(tid);
+}
+
+bool SaveCoreOptions::RemoveThread(lldb::tid_t tid) {
+ if (
@@ -53,6 +53,30 @@ class LLDB_API SBSaveCoreOptions {
/// \return The output file spec.
SBFileSpec GetOutputFile() const;
+ /// Add a thread to save in the core file.
+ ///
+ /// \param thread_id The thread ID to save.
+ void AddThread(lldb::tid_t thread_id);
+
+ ///
@@ -46,8 +46,59 @@ SaveCoreOptions::GetOutputFile() const {
return m_file;
}
+void SaveCoreOptions::AddThread(lldb::tid_t tid) {
+ if (m_threads_to_save.count(tid) == 0)
+m_threads_to_save.emplace(tid);
+}
+
+bool SaveCoreOptions::RemoveThread(lldb::tid_t tid) {
+ if (
@@ -46,8 +46,59 @@ SaveCoreOptions::GetOutputFile() const {
return m_file;
}
+void SaveCoreOptions::AddThread(lldb::tid_t tid) {
+ if (m_threads_to_save.count(tid) == 0)
+m_threads_to_save.emplace(tid);
+}
+
+bool SaveCoreOptions::RemoveThread(lldb::tid_t tid) {
+ if (
@@ -32,12 +33,21 @@ class SaveCoreOptions {
void SetOutputFile(lldb_private::FileSpec file);
const std::optional GetOutputFile() const;
+ void AddThread(lldb::tid_t tid);
+ bool RemoveThread(lldb::tid_t tid);
+ size_t GetNumThreads() const;
+ int64_t GetThreadAtIndex(s
@@ -46,8 +46,59 @@ SaveCoreOptions::GetOutputFile() const {
return m_file;
}
+void SaveCoreOptions::AddThread(lldb::tid_t tid) {
+ if (m_threads_to_save.count(tid) == 0)
+m_threads_to_save.emplace(tid);
+}
+
+bool SaveCoreOptions::RemoveThread(lldb::tid_t tid) {
+ if (
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/100443
>From d7940af06873cedf5976dc829dd9377b2851ae25 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Tue, 23 Jul 2024 16:50:57 -0700
Subject: [PATCH 1/5] Implemplement a thread list that is currently unused for
SB
@@ -53,6 +53,30 @@ class LLDB_API SBSaveCoreOptions {
/// \return The output file spec.
SBFileSpec GetOutputFile() const;
+ /// Add a thread to save in the core file.
+ ///
+ /// \param thread_id The thread ID to save.
+ void AddThread(lldb::tid_t thread_id);
-
@@ -46,8 +46,59 @@ SaveCoreOptions::GetOutputFile() const {
return m_file;
}
+void SaveCoreOptions::AddThread(lldb::tid_t tid) {
+ if (m_threads_to_save.count(tid) == 0)
+m_threads_to_save.emplace(tid);
Jlalond wrote:
Ah, good catch. Originally I was u
@@ -46,8 +46,59 @@ SaveCoreOptions::GetOutputFile() const {
return m_file;
}
+void SaveCoreOptions::AddThread(lldb::tid_t tid) {
+ if (m_threads_to_save.count(tid) == 0)
+m_threads_to_save.emplace(tid);
+}
+
+bool SaveCoreOptions::RemoveThread(lldb::tid_t tid) {
+ if (
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/100288
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/hekota edited https://github.com/llvm/llvm-project/pull/97362
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/hekota edited https://github.com/llvm/llvm-project/pull/97362
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kendalharland created
https://github.com/llvm/llvm-project/pull/100473
I'm currently working on getting the LLDB test suites to pass on Windows x86_64
which is not currently included in LLVM CI. These tests are currently failing
on this configuration.
>From 7c63b093423fd30e
https://github.com/kendalharland edited
https://github.com/llvm/llvm-project/pull/100473
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Kendal Harland (kendalharland)
Changes
I'm currently working on getting the LLDB test suites to pass on Windows x86_64
which is not currently included in LLVM CI. These tests are currently failing
on this configuration.
---
Full diff: htt
https://github.com/kendalharland edited
https://github.com/llvm/llvm-project/pull/100473
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kendalharland edited
https://github.com/llvm/llvm-project/pull/100473
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -8001,6 +8001,12 @@ NamedDecl *Sema::ActOnVariableDeclarator(
}
}
+ if (getLangOpts().HLSL) {
+if (R->isHLSLSpecificType() && !NewVD->isImplicit()) {
+ Diag(D.getBeginLoc(), diag::err_hlsl_intangible_type_cannot_be_declared);
hekota wrote:
https://github.com/kendalharland created
https://github.com/llvm/llvm-project/pull/100476
I'm currently working on getting the LLDB test suites to pass on Windows x86_64
which is not currently included in LLVM CI. These tests are currently failing
in this configuration.
See https://github.com
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Kendal Harland (kendalharland)
Changes
I'm currently working on getting the LLDB test suites to pass on Windows x86_64
which is not currently included in LLVM CI. These tests are currently failing
in this configuration.
See https://github
https://github.com/jasonmolenda approved this pull request.
LGTM.
https://github.com/llvm/llvm-project/pull/100421
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kendalharland created
https://github.com/llvm/llvm-project/pull/100477
I'm currently working on getting the LLDB test suites to pass on Windows x86_64
which is not currently included in LLVM CI. These tests are currently failing
in this configuration.
See https://github.com
Author: Jonas Devlieghere
Date: 2024-07-24T15:07:38-07:00
New Revision: e846fb48038a34d8df3ad7412bbdcf37e9e7acc9
URL:
https://github.com/llvm/llvm-project/commit/e846fb48038a34d8df3ad7412bbdcf37e9e7acc9
DIFF:
https://github.com/llvm/llvm-project/commit/e846fb48038a34d8df3ad7412bbdcf37e9e7acc9.d
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/100421
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Kendal Harland (kendalharland)
Changes
I'm currently working on getting the LLDB test suites to pass on Windows x86_64
which is not currently included in LLVM CI. These tests are currently failing
in this configuration.
See https://github
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
70c6e79e6d3e897418f3556a25e22e66ff018dc4...f8e40b90d65434838d2baa79795a1b160ab4614c
lldb/
https://github.com/JDevlieghere approved this pull request.
LGTM. Can you please bump the version number in the `package.json` file so we
can publish an update to the marketplace?
https://github.com/llvm/llvm-project/pull/99926
___
lldb-commits maili
JDevlieghere wrote:
Rather than a regex for the triple, can you use a combination of `oslist` and
`archs`? `expectedFailureAll` is supposed to combine the conditions, so the
regex should be equivalent to:
```
@expectedFailureAll(oslist=["windows"], archs=["x86_64"])
```
https://github.com/ll
kendalharland wrote:
> Rather than a regex for the triple, can you use a combination of `oslist` and
> `archs`? `expectedFailureAll` is supposed to combine the conditions, so the
> regex should be equivalent to:
>
> ```
> @expectedFailureAll(oslist=["windows"], archs=["x86_64"])
> ```
Yes. I
JDevlieghere wrote:
How are these tests failing? Neither of them seem to be testing something
specific to x86_64 and presumably the test are passing on [the aarch64 windows
buildbot](https://lab.llvm.org/buildbot/#/builders/141)?
https://github.com/llvm/llvm-project/pull/100473
__
@@ -12,6 +13,9 @@
# RUN: %clang_host -g -O0 %S/Inputs/verbose_trap.cpp -o %t.out
-DVERBOSE_TRAP_TEST_CATEGORY=\"\" -DVERBOSE_TRAP_TEST_MESSAGE=\"\"
# RUN: %lldb -b -s %s %t.out | FileCheck %s --check-prefixes=CHECK,CHECK-NONE
+# RUN: %clang_host -g -O0 %S/Inputs/verbose_trap.
https://github.com/kendalharland updated
https://github.com/llvm/llvm-project/pull/100477
>From 3a7e97987140c2d62259a54cb17c00996c0ed6db Mon Sep 17 00:00:00 2001
From: kendal
Date: Tue, 23 Jul 2024 16:50:34 -0700
Subject: [PATCH] [lldb][test][win][x86_64] XFAIL already failing API tests
---
.
kendalharland wrote:
> > Rather than a regex for the triple, can you use a combination of `oslist`
> > and `archs`? `expectedFailureAll` is supposed to combine the conditions, so
> > the regex should be equivalent to:
> > ```
> > @expectedFailureAll(oslist=["windows"], archs=["x86_64"])
> > ```
https://github.com/kendalharland updated
https://github.com/llvm/llvm-project/pull/100476
>From fc88c4ac46e0e9266bf24467b6ad6c5e55d8216c Mon Sep 17 00:00:00 2001
From: kendal
Date: Tue, 23 Jul 2024 15:47:48 -0700
Subject: [PATCH] [lldb][test][win][x86_64] XFAIL already failing Shell tests
---
@@ -12,6 +13,9 @@
# RUN: %clang_host -g -O0 %S/Inputs/verbose_trap.cpp -o %t.out
-DVERBOSE_TRAP_TEST_CATEGORY=\"\" -DVERBOSE_TRAP_TEST_MESSAGE=\"\"
# RUN: %lldb -b -s %s %t.out | FileCheck %s --check-prefixes=CHECK,CHECK-NONE
+# RUN: %clang_host -g -O0 %S/Inputs/verbose_trap.
@@ -1,3 +1,4 @@
+# XFAIL: target=x86_64-{{.*}}-windows{{.*}}
kendalharland wrote:
@JDevlieghere please LMK if the target triple can be expressed more clearly as
a combination of other filters in `.test` files, here and throughout.
https://github.com/llvm/llvm-p
kendalharland wrote:
> How are these tests failing? Neither of them seem to be testing something
> specific to x86_64 and presumably the test are passing on [the aarch64
> windows buildbot](https://lab.llvm.org/buildbot/#/builders/141)?
I am currently seeing this output:
```
Testing: 0.. 10
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/100288
>From 28439443b9e44a242e59bf1cdd114486380d54fc Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Tue, 23 Jul 2024 18:54:31 -0700
Subject: [PATCH 1/2] [lldb] Don't use a vm addr range starting at 0 for loca
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/100443
>From d7940af06873cedf5976dc829dd9377b2851ae25 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Tue, 23 Jul 2024 16:50:57 -0700
Subject: [PATCH 1/6] Implemplement a thread list that is currently unused for
SB
https://github.com/kendalharland created
https://github.com/llvm/llvm-project/pull/100487
On windows x86_64 this test stops on the set breakpoint when `val == 1` when
the breakpoint condition is set on the SBBreakpointLocation rather than the
SBBreakpoint directly. Setting the condition on th
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Kendal Harland (kendalharland)
Changes
On windows x86_64 this test stops on the set breakpoint when `val == 1` when
the breakpoint condition is set on the SBBreakpointLocation rather than the
SBBreakpoint directly. Setting the condition o
Author: Jason Molenda
Date: 2024-07-24T17:25:57-07:00
New Revision: 2ba1aeed2efd8156717886f89f6d4270b1df7a18
URL:
https://github.com/llvm/llvm-project/commit/2ba1aeed2efd8156717886f89f6d4270b1df7a18
DIFF:
https://github.com/llvm/llvm-project/commit/2ba1aeed2efd8156717886f89f6d4270b1df7a18.diff
https://github.com/jasonmolenda closed
https://github.com/llvm/llvm-project/pull/100288
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kendalharland updated
https://github.com/llvm/llvm-project/pull/100487
>From 29d5a57eb8cc344e1a93787fe9cb333761923927 Mon Sep 17 00:00:00 2001
From: kendal
Date: Tue, 23 Jul 2024 10:24:24 -0700
Subject: [PATCH 1/2] [lldb][test][x86_64][win] Split TestBreakpointConditions
ass
jasonmolenda wrote:
I've merged https://github.com/llvm/llvm-project/pull/100288 I think we should
close this PR.
https://github.com/llvm/llvm-project/pull/99045
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/
kendalharland wrote:
Uploaded a new patch set after realizing my original commit removed tests for
the codepath where `SBBReakpointLocation.SetCondition` is used, which still
needs to be tested on aarch64. The latest commit tests both
`SBBreakpointLocation.SetCondition` and `SBBreakpoint.SetCo
https://github.com/kendalharland updated
https://github.com/llvm/llvm-project/pull/100487
>From 29d5a57eb8cc344e1a93787fe9cb333761923927 Mon Sep 17 00:00:00 2001
From: kendal
Date: Tue, 23 Jul 2024 10:24:24 -0700
Subject: [PATCH 1/2] [lldb][test][x86_64][win] Split TestBreakpointConditions
ass
https://github.com/kendalharland updated
https://github.com/llvm/llvm-project/pull/100487
>From 29d5a57eb8cc344e1a93787fe9cb333761923927 Mon Sep 17 00:00:00 2001
From: kendal
Date: Tue, 23 Jul 2024 10:24:24 -0700
Subject: [PATCH 1/2] [lldb][test][x86_64][win] Split TestBreakpointConditions
ass
https://github.com/jasonmolenda commented:
The MachO changes look fine to me. I had a few other small pieces of feedback,
I think they're mostly matters of opinion so just take them as such, not
something that must be changed.
https://github.com/llvm/llvm-project/pull/100443
_
https://github.com/jasonmolenda edited
https://github.com/llvm/llvm-project/pull/100443
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -46,8 +48,79 @@ SaveCoreOptions::GetOutputFile() const {
return m_file;
}
+Status SaveCoreOptions::SetProcess(lldb::ProcessSP process_sp) {
+ Status error;
+ if (!process_sp) {
+ClearProcessSpecificData();
+m_process_sp = std::nullopt;
+return error;
+ }
+
@@ -46,8 +48,79 @@ SaveCoreOptions::GetOutputFile() const {
return m_file;
}
+Status SaveCoreOptions::SetProcess(lldb::ProcessSP process_sp) {
+ Status error;
+ if (!process_sp) {
+ClearProcessSpecificData();
+m_process_sp = std::nullopt;
+return error;
+ }
+
@@ -46,8 +48,79 @@ SaveCoreOptions::GetOutputFile() const {
return m_file;
}
+Status SaveCoreOptions::SetProcess(lldb::ProcessSP process_sp) {
+ Status error;
+ if (!process_sp) {
+ClearProcessSpecificData();
+m_process_sp = std::nullopt;
+return error;
+ }
+
1 - 100 of 124 matches
Mail list logo
