[Lldb-commits] [lldb] b77e734 - [lldb][AArch64] Add register field enum information (#96887)

2024-07-03 Thread via lldb-commits
Author: David Spickett Date: 2024-07-03T08:43:29+01:00 New Revision: b77e734e4e6c8f5e016ba3ac49526862e6039482 URL: https://github.com/llvm/llvm-project/commit/b77e734e4e6c8f5e016ba3ac49526862e6039482 DIFF: https://github.com/llvm/llvm-project/commit/b77e734e4e6c8f5e016ba3ac49526862e6039482.diff

[Lldb-commits] [lldb] [lldb][AArch64] Add register field enum information (PR #96887)

2024-07-03 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/96887 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] [DynamicLoaderPOSIXDYLD] Enable POSIX-DYLD for QNX (PR #97536)

2024-07-03 Thread Ayush Sahay via lldb-commits
https://github.com/ayushsahay1837 created https://github.com/llvm/llvm-project/pull/97536 This change enables the _POSIX_ dynamic loader plugin for _QNX_, and is the fourth in a series of changes that look to facilitate remote debug of _AArch64_ targets on _QNX_. _QNX Neutrino Real-Time Opera

[Lldb-commits] [lldb] [lldb] [DynamicLoaderPOSIXDYLD] Enable POSIX-DYLD for QNX (PR #97536)

2024-07-03 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Ayush Sahay (ayushsahay1837) Changes This change enables the _POSIX_ dynamic loader plugin for _QNX_, and is the fourth in a series of changes that look to facilitate remote debug of _AArch64_ targets on _QNX_. _QNX Neutrino Real-Time Ope

[Lldb-commits] [lldb] [lldb] [DynamicLoaderPOSIXDYLD] Enable POSIX-DYLD for QNX (PR #97536)

2024-07-03 Thread Ayush Sahay via lldb-commits
https://github.com/ayushsahay1837 edited https://github.com/llvm/llvm-project/pull/97536 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Fix type error when calling random.randrange with 'float' arg (PR #97328)

2024-07-03 Thread Pavel Labath via lldb-commits
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/97328 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix test assertions in TestDAP_stepInTargets.py (PR #96687)

2024-07-03 Thread Pavel Labath via lldb-commits
labath wrote: > AssertionError: 'funcB' not found in 'funcA()' : expect funcB The step targets are coming in different order. It's probably an ABI thing, as the compiler produces the calls in different order as well: https://godbolt.org/z/cPqhsWba6 I guess we need to adjust the test to accep

[Lldb-commits] [lldb] 2a14c06 - [lldb] Make Broadcaster mutexes non-recursive (#97400)

2024-07-03 Thread via lldb-commits
Author: Pavel Labath Date: 2024-07-03T10:29:17+02:00 New Revision: 2a14c0643597c5932af85f22172c99800f9b4a6c URL: https://github.com/llvm/llvm-project/commit/2a14c0643597c5932af85f22172c99800f9b4a6c DIFF: https://github.com/llvm/llvm-project/commit/2a14c0643597c5932af85f22172c99800f9b4a6c.diff

[Lldb-commits] [lldb] [lldb] Make Broadcaster mutexes non-recursive (PR #97400)

2024-07-03 Thread Pavel Labath via lldb-commits
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/97400 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] aa0851a - [lldb][DataFormatter][NFC] Remove redundant variables in std::map formatter

2024-07-03 Thread Michael Buch via lldb-commits
Author: Michael Buch Date: 2024-07-03T10:33:39+02:00 New Revision: aa0851a5a6fd0c8d66dfd8b259c215dba3fabd1e URL: https://github.com/llvm/llvm-project/commit/aa0851a5a6fd0c8d66dfd8b259c215dba3fabd1e DIFF: https://github.com/llvm/llvm-project/commit/aa0851a5a6fd0c8d66dfd8b259c215dba3fabd1e.diff

[Lldb-commits] [lldb] e89890e - [lldb][DataFormatter][NFC] std::map: minor restructuring in GetChildAtIndex to use early-return

2024-07-03 Thread Michael Buch via lldb-commits
Author: Michael Buch Date: 2024-07-03T10:34:16+02:00 New Revision: e89890e8e510f2b76c8c4a2b2a6fc323b1e837ad URL: https://github.com/llvm/llvm-project/commit/e89890e8e510f2b76c8c4a2b2a6fc323b1e837ad DIFF: https://github.com/llvm/llvm-project/commit/e89890e8e510f2b76c8c4a2b2a6fc323b1e837ad.diff

[Lldb-commits] [lldb] da62f5f - [lldb][DataFormatter][NFC] std::map: Add comments and other minor cleanups

2024-07-03 Thread Michael Buch via lldb-commits
Author: Michael Buch Date: 2024-07-03T10:33:39+02:00 New Revision: da62f5f8dfe4d4196191b40dc41e1ef2de1bf5cb URL: https://github.com/llvm/llvm-project/commit/da62f5f8dfe4d4196191b40dc41e1ef2de1bf5cb DIFF: https://github.com/llvm/llvm-project/commit/da62f5f8dfe4d4196191b40dc41e1ef2de1bf5cb.diff

[Lldb-commits] [lldb] [lldb][DataFormatter][NFC] Factor out MapIterator logic into separate helper (PR #97544)

2024-07-03 Thread Michael Buch via lldb-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/97544 This patch factors all the logic for advancing the `MapIterator` out of `GetChildAtIndex`. This, in my opinion, helps readability, and will be useful for upcoming cleanups in this area. While here, some driv

[Lldb-commits] [lldb] [lldb][DataFormatter][NFC] Factor out MapIterator logic into separate helper (PR #97544)

2024-07-03 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes This patch factors all the logic for advancing the `MapIterator` out of `GetChildAtIndex`. This, in my opinion, helps readability, and will be useful for upcoming cleanups in this area. While here, some d

[Lldb-commits] [lldb] [lldb][DataFormatter][NFC] Factor out MapIterator logic into separate helper (PR #97544)

2024-07-03 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/97544 >From 9dabd3a399f37789b6a9bc7578b76e738c344f1d Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Wed, 3 Jul 2024 10:55:40 +0200 Subject: [PATCH 1/2] [lldb][DataFormatter][NFC] Factor out MapIterator logic int

[Lldb-commits] [lldb] [lldb][DataFormatter] Remove support for old std::map layout (PR #97549)

2024-07-03 Thread Michael Buch via lldb-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/97549 We currently supported the layout from pre-2016 (before the layout change in [14caaddd3f08e798dcd9ac0ddfc](https://github.com/llvm/llvm-project/commit/14caaddd3f08e798dcd9ac0ddfc)). We have another upcoming la

[Lldb-commits] [lldb] [lldb][DataFormatter] Remove support for old std::map layout (PR #97549)

2024-07-03 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes We currently supported the layout from pre-2016 (before the layout change in [14caaddd3f08e798dcd9ac0ddfc](https://github.com/llvm/llvm-project/commit/14caaddd3f08e798dcd9ac0ddfc)). We have another upcoming

[Lldb-commits] [lldb] [lldb][DataFormatter] Remove support for old std::map layout (PR #97549)

2024-07-03 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/97549 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DataFormatter] Remove support for old std::map layout (PR #97549)

2024-07-03 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/97549 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DataFormatter] Clean up LibcxxStdMapSyntheticFrontEnd::GetKeyValuePair (PR #97551)

2024-07-03 Thread Michael Buch via lldb-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/97551 This patch cleans up the core of the `std::map` libc++ formatter. Depends on https://github.com/llvm/llvm-project/pull/97544 and https://github.com/llvm/llvm-project/pull/97549. Changes: * Renamed `m_skip_siz

[Lldb-commits] [lldb] [lldb][DataFormatter] Clean up LibcxxStdMapSyntheticFrontEnd::GetKeyValuePair (PR #97551)

2024-07-03 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/97551 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DataFormatter] Clean up LibcxxStdMapSyntheticFrontEnd::GetKeyValuePair (PR #97551)

2024-07-03 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes This patch cleans up the core of the `std::map` libc++ formatter. Depends on https://github.com/llvm/llvm-project/pull/97544 and https://github.com/llvm/llvm-project/pull/97549. Changes: * Renamed `m_skip

[Lldb-commits] [lldb] [lldb] Make Listener::m_broadcasters_mutex non-recursive (PR #97552)

2024-07-03 Thread Pavel Labath via lldb-commits
https://github.com/labath created https://github.com/llvm/llvm-project/pull/97552 Follow-up to #97400. No changes apart from changing the type were necessary. The mutex was already not used recursively. >From d183b37fdc4cda4f76b33b768a42e43368c68464 Mon Sep 17 00:00:00 2001 From: Pavel Labath

[Lldb-commits] [lldb] [lldb] Make Listener::m_broadcasters_mutex non-recursive (PR #97552)

2024-07-03 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes Follow-up to #97400. No changes apart from changing the type were necessary. The mutex was already not used recursively. --- Full diff: https://github.com/llvm/llvm-project/pull/97552.diff 2 Files Affected:

[Lldb-commits] [lldb] [lldb] Print empty enums as if they were unrecognised normal enums (PR #97553)

2024-07-03 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/97553 Fixes #97514 Given this example: ``` enum E {}; int main() { E x = E(0); E y = E(1); E z = E(2); return 0; } ``` lldb used to print nothing for `x`, but `0x1` for `y` and `0x2` for `z`. At

[Lldb-commits] [lldb] [lldb] Print empty enums as if they were unrecognised normal enums (PR #97553)

2024-07-03 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) Changes Fixes #97514 Given this example: ``` enum E {}; int main() { E x = E(0); E y = E(1); E z = E(2); return 0; } ``` lldb used to print nothing for `x`, but `0x1` for `y` and `0x2` for `z`

[Lldb-commits] [lldb] [lldb] Print empty enums as if they were unrecognised normal enums (PR #97553)

2024-07-03 Thread David Spickett via lldb-commits
@@ -8649,19 +8649,24 @@ static bool DumpEnumValue(const clang::QualType &qual_type, Stream &s, // At the same time, we're applying a heuristic to determine whether we want // to print this enum as a bitfield. We're likely dealing with a bitfield if // every enumerator is

[Lldb-commits] [lldb] [lldb] Print empty enums as if they were unrecognised normal enums (PR #97553)

2024-07-03 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/97553 >From 08565607da9f35649c8ef037cdd1f9ac2f5c7e25 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Wed, 3 Jul 2024 10:28:49 + Subject: [PATCH 1/2] [lldb] Print empty enums as if they were unrecognised

[Lldb-commits] [lldb] [lldb] Print empty enums as if they were unrecognised normal enums (PR #97553)

2024-07-03 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/97553 >From 08565607da9f35649c8ef037cdd1f9ac2f5c7e25 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Wed, 3 Jul 2024 10:28:49 + Subject: [PATCH 1/3] [lldb] Print empty enums as if they were unrecognised

[Lldb-commits] [lldb] [lldb] Remove Listener::SetShadow (PR #97555)

2024-07-03 Thread Pavel Labath via lldb-commits
https://github.com/labath created https://github.com/llvm/llvm-project/pull/97555 It's not used since https://reviews.llvm.org/D157556. >From 9f81f804c4c451a5ff2266405740d208dffae60f Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Wed, 3 Jul 2024 10:37:52 + Subject: [PATCH] [lldb] Remove

[Lldb-commits] [lldb] [lldb] Remove Listener::SetShadow (PR #97555)

2024-07-03 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes It's not used since https://reviews.llvm.org/D157556. --- Full diff: https://github.com/llvm/llvm-project/pull/97555.diff 4 Files Affected: - (modified) lldb/include/lldb/Utility/Listener.h (-3) - (modified

[Lldb-commits] [lldb] [lldb] Print "0x0" for bitfield like enums where the value is 0 (PR #97557)

2024-07-03 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/97557 Enums like this one are treated as bitfield like enums: enum FlagsLike {B=2, C=4}; lldb recognises them as collections of flags, so you can have "B | C". If there's any values not covered that's printed a

[Lldb-commits] [lldb] [lldb] Print "0x0" for bitfield like enums where the value is 0 (PR #97557)

2024-07-03 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) Changes Enums like this one are treated as bitfield like enums: enum FlagsLike {B=2, C=4}; lldb recognises them as collections of flags, so you can have "B | C". If there's any values not covered that's prin

[Lldb-commits] [lldb] [lldb] Print "0x0" for bitfield like enums where the value is 0 (PR #97557)

2024-07-03 Thread David Spickett via lldb-commits
DavidSpickett wrote: There is a comment in this function: ``` // Try to find an exact match for the value. // At the same time, we're applying a heuristic to determine whether we want // to print this enum as a bitfield. We're likely dealing with a bitfield if // every enumerator is eithe

[Lldb-commits] [lldb] [lldb] Make variant formatter work with libstdc++-14 (PR #97568)

2024-07-03 Thread Pavel Labath via lldb-commits
https://github.com/labath created https://github.com/llvm/llvm-project/pull/97568 In this version the internal data member has grown an additional template parameter (bool), which was throwing the summary provider off. This patch uses the type of the entire variant object. This is part of the

[Lldb-commits] [lldb] [lldb] Make variant formatter work with libstdc++-14 (PR #97568)

2024-07-03 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes In this version the internal data member has grown an additional template parameter (bool), which was throwing the summary provider off. This patch uses the type of the entire variant object. This is part of t

[Lldb-commits] [lldb] [lldb] Make variant formatter work with libstdc++-14 (PR #97568)

2024-07-03 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 2a14c0643597c5932af85f22172c99800f9b4a6c...53b9fda6f7bf0ec4df32869c9d4ba2203aa1870a lldb/

[Lldb-commits] [lldb] [lldb] Make variant formatter work with libstdc++-14 (PR #97568)

2024-07-03 Thread Michael Buch via lldb-commits
https://github.com/Michael137 approved this pull request. LGTM Been wondering if we should follow the same principle as we did with `std::string` and simulate the layouts for all the STL types, keeping a record of them as they change. So we know we don't break the old layouts. Of course it ha

[Lldb-commits] [lldb] [lldb] Print empty enums as if they were unrecognised normal enums (PR #97553)

2024-07-03 Thread Michael Buch via lldb-commits
https://github.com/Michael137 approved this pull request. makes sense https://github.com/llvm/llvm-project/pull/97553 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Print "0x0" for bitfield like enums where the value is 0 (PR #97557)

2024-07-03 Thread Michael Buch via lldb-commits
https://github.com/Michael137 approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/97557 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix printing of unsigned enum bitfields when they contain the max value (PR #96202)

2024-07-03 Thread Michael Buch via lldb-commits
https://github.com/Michael137 approved this pull request. good catch, LGTM https://github.com/llvm/llvm-project/pull/96202 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix printing of unsigned enum bitfields when they contain the max value (PR #96202)

2024-07-03 Thread David Spickett via lldb-commits
DavidSpickett wrote: Thanks for all the reviews! https://github.com/llvm/llvm-project/pull/96202 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] dde3f17 - [lldb] Fix printing of unsigned enum bitfields when they contain the max value (#96202)

2024-07-03 Thread via lldb-commits
Author: David Spickett Date: 2024-07-03T14:30:47+01:00 New Revision: dde3f17026be48c05a5d3876f12db72fdd6422ed URL: https://github.com/llvm/llvm-project/commit/dde3f17026be48c05a5d3876f12db72fdd6422ed DIFF: https://github.com/llvm/llvm-project/commit/dde3f17026be48c05a5d3876f12db72fdd6422ed.diff

[Lldb-commits] [lldb] [lldb] Fix printing of unsigned enum bitfields when they contain the max value (PR #96202)

2024-07-03 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/96202 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Print empty enums as if they were unrecognised normal enums (PR #97553)

2024-07-03 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/97553 >From 1a170e94ef9caf3012b1c3185f9c3f459171d362 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Wed, 3 Jul 2024 10:28:49 + Subject: [PATCH] [lldb] Print empty enums as if they were unrecognised norma

[Lldb-commits] [lldb] [lldb][DataFormatter] Remove support for old std::map layout (PR #97549)

2024-07-03 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/97549 >From e80ca1531751eb6750eb65fcec75c760e0282792 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Wed, 3 Jul 2024 12:06:49 +0200 Subject: [PATCH 1/2] [lldb][DataFormatter] Remove support for old std::map layou

[Lldb-commits] [lldb] 41fddc4 - [lldb] Print empty enums as if they were unrecognised normal enums (#97553)

2024-07-03 Thread via lldb-commits
Author: David Spickett Date: 2024-07-03T14:47:55+01:00 New Revision: 41fddc4ec3302f125a5b84ae86c8027dedc89984 URL: https://github.com/llvm/llvm-project/commit/41fddc4ec3302f125a5b84ae86c8027dedc89984 DIFF: https://github.com/llvm/llvm-project/commit/41fddc4ec3302f125a5b84ae86c8027dedc89984.diff

[Lldb-commits] [lldb] [lldb] Print empty enums as if they were unrecognised normal enums (PR #97553)

2024-07-03 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/97553 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 3101524 - [lldb] Print "0x0" for bitfield like enums where the value is 0 (#97557)

2024-07-03 Thread via lldb-commits
Author: David Spickett Date: 2024-07-03T14:48:48+01:00 New Revision: 31015240d366e4bf6f114856caa6e9ce90742b7f URL: https://github.com/llvm/llvm-project/commit/31015240d366e4bf6f114856caa6e9ce90742b7f DIFF: https://github.com/llvm/llvm-project/commit/31015240d366e4bf6f114856caa6e9ce90742b7f.diff

[Lldb-commits] [lldb] [lldb] Print "0x0" for bitfield like enums where the value is 0 (PR #97557)

2024-07-03 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/97557 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DataFormatter] Simplify std::map formatter (PR #97579)

2024-07-03 Thread Michael Buch via lldb-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/97579 Depends on: * https://github.com/llvm/llvm-project/pull/97544 * https://github.com/llvm/llvm-project/pull/97549 * https://github.com/llvm/llvm-project/pull/97551 This patch tries to simplify the way in which t

[Lldb-commits] [lldb] [lldb][DataFormatter] Simplify std::map formatter (PR #97579)

2024-07-03 Thread Michael Buch via lldb-commits
Michael137 wrote: This is currently a bit hard to review because it's based off of other branches that are in review. So feel free to hold off on reviewing until the dependencies landed https://github.com/llvm/llvm-project/pull/97579 ___ lldb-commits

[Lldb-commits] [lldb] [lldb][DataFormatter] Simplify std::map formatter (PR #97579)

2024-07-03 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes Depends on: * https://github.com/llvm/llvm-project/pull/97544 * https://github.com/llvm/llvm-project/pull/97549 * https://github.com/llvm/llvm-project/pull/97551 This patch tries to simplify the way in whic

[Lldb-commits] [lldb] [lldb][DataFormatter] Simplify std::map formatter (PR #97579)

2024-07-03 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/97579 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DataFormatter] Simplify std::map formatter (PR #97579)

2024-07-03 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/97579 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] f057130 - [lldb] Remove commented-out Platform::FindPlugin (NFC)

2024-07-03 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2024-07-03T09:03:47-07:00 New Revision: f057130b169fe551b1fec6633fadba26ef19bcdd URL: https://github.com/llvm/llvm-project/commit/f057130b169fe551b1fec6633fadba26ef19bcdd DIFF: https://github.com/llvm/llvm-project/commit/f057130b169fe551b1fec6633fadba26ef19bcdd.d

[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Support minidumps where there are multiple exception streams (PR #97470)

2024-07-03 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond edited https://github.com/llvm/llvm-project/pull/97470 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [API] add GetSyntheticValue (PR #95959)

2024-07-03 Thread Vincent Belliard via lldb-commits
https://github.com/v-bulle updated https://github.com/llvm/llvm-project/pull/95959 >From 27a00b54bc991dfb4747e0d37b15878beebaabba Mon Sep 17 00:00:00 2001 From: Vincent Belliard Date: Wed, 12 Jun 2024 14:23:15 -0700 Subject: [PATCH 1/4] [API] add GetSyntheticValue --- lldb/include/lldb/API/SB

[Lldb-commits] [lldb] [API] add GetSyntheticValue (PR #95959)

2024-07-03 Thread Vincent Belliard via lldb-commits
https://github.com/v-bulle updated https://github.com/llvm/llvm-project/pull/95959 >From 27a00b54bc991dfb4747e0d37b15878beebaabba Mon Sep 17 00:00:00 2001 From: Vincent Belliard Date: Wed, 12 Jun 2024 14:23:15 -0700 Subject: [PATCH 01/10] [API] add GetSyntheticValue --- lldb/include/lldb/API/

[Lldb-commits] [lldb] [API] add GetSyntheticValue (PR #95959)

2024-07-03 Thread Vincent Belliard via lldb-commits
v-bulle wrote: > The one thing about this that strikes me as odd is that if you have an > SBValue that doesn't have a Synthetic Value, this will return the > non-synthetic value. The GetNonSyntheticValue didn't have this problem > because there's always a non-synthetic value, so provided the S

[Lldb-commits] [lldb] [lldb][DataFormatter][NFC] Factor out MapIterator logic into separate helper (PR #97544)

2024-07-03 Thread David Blaikie via lldb-commits
https://github.com/dwblaikie approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/97544 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [API] add GetSyntheticValue (PR #95959)

2024-07-03 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 5da7179cb3ff80203f58ddea71562816b2ae4ff6 bcfebfbcbc4196daa9ab03874a58b53d44afeb3c --

[Lldb-commits] [lldb] [API] add GetSyntheticValue (PR #95959)

2024-07-03 Thread Vincent Belliard via lldb-commits
https://github.com/v-bulle updated https://github.com/llvm/llvm-project/pull/95959 >From 27a00b54bc991dfb4747e0d37b15878beebaabba Mon Sep 17 00:00:00 2001 From: Vincent Belliard Date: Wed, 12 Jun 2024 14:23:15 -0700 Subject: [PATCH 01/11] [API] add GetSyntheticValue --- lldb/include/lldb/API/

[Lldb-commits] [lldb] [lldb] Remove Listener::SetShadow (PR #97555)

2024-07-03 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/97555 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove Listener::SetShadow (PR #97555)

2024-07-03 Thread Jonas Devlieghere via lldb-commits
@@ -18,13 +18,10 @@ using namespace lldb; using namespace lldb_private; -Listener::Listener(const char *name) -: m_name(name), m_broadcasters(), m_broadcasters_mutex(), m_events(), - m_events_mutex(), m_is_shadow() { +Listener::Listener(const char *name) : m_name(name

[Lldb-commits] [lldb] [lldb] Remove Listener::SetShadow (PR #97555)

2024-07-03 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/97555 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [API] add GetSyntheticValue (PR #95959)

2024-07-03 Thread Vincent Belliard via lldb-commits
https://github.com/v-bulle updated https://github.com/llvm/llvm-project/pull/95959 >From 27a00b54bc991dfb4747e0d37b15878beebaabba Mon Sep 17 00:00:00 2001 From: Vincent Belliard Date: Wed, 12 Jun 2024 14:23:15 -0700 Subject: [PATCH 01/12] [API] add GetSyntheticValue --- lldb/include/lldb/API/

[Lldb-commits] [lldb] [lldb] Make Listener::m_broadcasters_mutex non-recursive (PR #97552)

2024-07-03 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/97552 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 77d131e - Add the ability for Script based commands to specify their "repeat command" (#94823)

2024-07-03 Thread via lldb-commits
Author: jimingham Date: 2024-07-03T10:39:34-07:00 New Revision: 77d131eddb6ca9060c844fae9cb78779fa70c8f0 URL: https://github.com/llvm/llvm-project/commit/77d131eddb6ca9060c844fae9cb78779fa70c8f0 DIFF: https://github.com/llvm/llvm-project/commit/77d131eddb6ca9060c844fae9cb78779fa70c8f0.diff LOG

[Lldb-commits] [lldb] Add the ability for Script based commands to specify their "repeat command" (PR #94823)

2024-07-03 Thread via lldb-commits
https://github.com/jimingham closed https://github.com/llvm/llvm-project/pull/94823 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [API] add GetSyntheticValue (PR #95959)

2024-07-03 Thread Vincent Belliard via lldb-commits
https://github.com/v-bulle updated https://github.com/llvm/llvm-project/pull/95959 >From 27a00b54bc991dfb4747e0d37b15878beebaabba Mon Sep 17 00:00:00 2001 From: Vincent Belliard Date: Wed, 12 Jun 2024 14:23:15 -0700 Subject: [PATCH 01/14] [API] add GetSyntheticValue --- lldb/include/lldb/API/

[Lldb-commits] [lldb] SBThread::StepInstruction shouldn't discard other plans (PR #97493)

2024-07-03 Thread via lldb-commits
https://github.com/jimingham updated https://github.com/llvm/llvm-project/pull/97493 >From 3fba16eaee25b1d63907640b79019309e9c019a7 Mon Sep 17 00:00:00 2001 From: Jim Ingham Date: Tue, 2 Jul 2024 16:42:00 -0700 Subject: [PATCH 1/2] SBThread::StepInstruction shouldn't discard other plans This w

[Lldb-commits] [lldb] 845dee3 - SBThread::StepInstruction shouldn't discard other plans (#97493)

2024-07-03 Thread via lldb-commits
Author: jimingham Date: 2024-07-03T10:45:20-07:00 New Revision: 845dee36ba4161df153ba05009cea615e20eda5a URL: https://github.com/llvm/llvm-project/commit/845dee36ba4161df153ba05009cea615e20eda5a DIFF: https://github.com/llvm/llvm-project/commit/845dee36ba4161df153ba05009cea615e20eda5a.diff LOG

[Lldb-commits] [lldb] SBThread::StepInstruction shouldn't discard other plans (PR #97493)

2024-07-03 Thread via lldb-commits
https://github.com/jimingham closed https://github.com/llvm/llvm-project/pull/97493 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [API] add GetSyntheticValue (PR #95959)

2024-07-03 Thread via lldb-commits
https://github.com/jimingham approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/95959 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] a017653 - [lldb][DataFormatter][NFC] Factor out MapIterator logic into separate helper (#97544)

2024-07-03 Thread via lldb-commits
Author: Michael Buch Date: 2024-07-03T19:54:20+02:00 New Revision: a0176533766201eca58b20a11e42ab30c73d1b1b URL: https://github.com/llvm/llvm-project/commit/a0176533766201eca58b20a11e42ab30c73d1b1b DIFF: https://github.com/llvm/llvm-project/commit/a0176533766201eca58b20a11e42ab30c73d1b1b.diff

[Lldb-commits] [lldb] [lldb][DataFormatter][NFC] Factor out MapIterator logic into separate helper (PR #97544)

2024-07-03 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/97544 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DataFormatter] Clean up LibcxxStdMapSyntheticFrontEnd::GetKeyValuePair (PR #97551)

2024-07-03 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/97551 >From 27fb4d207722e12ffd88df4ce5095859782f62ce Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Wed, 3 Jul 2024 11:43:47 +0200 Subject: [PATCH] [lldb][DataFormatter] Clean up LibcxxStdMapSyntheticFrontEnd::G

[Lldb-commits] [clang] [lldb] [HLSL] Implement intangible AST type (PR #97362)

2024-07-03 Thread Helena Kotas via lldb-commits
https://github.com/hekota updated https://github.com/llvm/llvm-project/pull/97362 >From a07ea8d187cbba5717b89f5c54138f12993b3ee8 Mon Sep 17 00:00:00 2001 From: Justin Bogner Date: Thu, 6 Jun 2024 11:44:56 -0700 Subject: [PATCH 1/6] wip: Stub out adding an HLSLResource builtin type There are a

[Lldb-commits] [clang] [lldb] [HLSL] Implement intangible AST type (PR #97362)

2024-07-03 Thread Helena Kotas via lldb-commits
https://github.com/hekota updated https://github.com/llvm/llvm-project/pull/97362 >From a07ea8d187cbba5717b89f5c54138f12993b3ee8 Mon Sep 17 00:00:00 2001 From: Justin Bogner Date: Thu, 6 Jun 2024 11:44:56 -0700 Subject: [PATCH 1/6] wip: Stub out adding an HLSLResource builtin type There are a

[Lldb-commits] [lldb] [lldb][DataFormatter] Remove support for old std::map layout (PR #97549)

2024-07-03 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/97549 >From 2e36d3d7670298fb296d82af2fdc9de8c32a48c3 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Wed, 3 Jul 2024 12:06:49 +0200 Subject: [PATCH] [lldb][DataFormatter] Remove support for old std::map layout We

[Lldb-commits] [lldb] [lldb/Commands] Alias `script` command to `scripting run` (PR #97263)

2024-07-03 Thread Jonas Devlieghere via lldb-commits
@@ -518,6 +518,15 @@ void CommandInterpreter::Initialize() { AddAlias("re", cmd_obj_sp); } + cmd_obj_sp = GetCommandSPExact("scripting execute"); + if (cmd_obj_sp) { +AddAlias("sc", cmd_obj_sp); +AddAlias("scr", cmd_obj_sp); +AddAlias("scri", cmd_obj_sp); +

[Lldb-commits] [lldb] [lldb][test] Fix type error when calling random.randrange with 'float' arg (PR #97328)

2024-07-03 Thread Kendal Harland via lldb-commits
https://github.com/kendalharland updated https://github.com/llvm/llvm-project/pull/97328 >From 9bb6749f1dfa57343f4e546406576fec2c7afcc5 Mon Sep 17 00:00:00 2001 From: kendal Date: Mon, 1 Jul 2024 10:33:51 -0700 Subject: [PATCH] Fix type error when calling random.randrange with 'float' arg ---

[Lldb-commits] [lldb] [lldb][DataFormatter][NFC] Factor out MapIterator logic into separate helper (PR #97544)

2024-07-03 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-aarch64-ubuntu` running on `linaro-lldb-aarch64-ubuntu` while building `lldb` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/59/builds/1001 Here is the relevant piece of the bui

[Lldb-commits] [lldb] [lldb/Commands] Alias `script` command to `scripting run` (PR #97263)

2024-07-03 Thread Jonas Devlieghere via lldb-commits
@@ -80,7 +80,13 @@ def test_command_abbreviations_and_aliases(self): # Check a command that wants the raw input. command_interpreter.ResolveCommand(r"""sc print("\n\n\tHello!\n")""", result) self.assertTrue(result.Succeeded()) JDevliegh

[Lldb-commits] [lldb] [lldb/Commands] Alias `script` command to `scripting run` (PR #97263)

2024-07-03 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > The reason behind this change is to have a top-level command that will cover > scripting related subcommands. Which other scripting subcommands do you envision, besides the [template](https://github.com/llvm/llvm-project/pull/97273) subcommand? https://github.com/llvm/l

[Lldb-commits] [lldb] [lldb][test] Fix type error when calling random.randrange with 'float' arg (PR #97328)

2024-07-03 Thread Kendal Harland via lldb-commits
https://github.com/kendalharland updated https://github.com/llvm/llvm-project/pull/97328 >From a3c524bebfc976f3dfee5b67dac490ed44705d6a Mon Sep 17 00:00:00 2001 From: kendal Date: Wed, 3 Jul 2024 11:18:43 -0700 Subject: [PATCH] Fix type error when calling random.randrange with 'float' arg ---

[Lldb-commits] [lldb] [lldb][test] Fix type error when calling random.randrange with 'float' arg (PR #97328)

2024-07-03 Thread Kendal Harland via lldb-commits
kendalharland wrote: Using `10**10`. Works for me. Updated and rebased on top of `main`. https://github.com/llvm/llvm-project/pull/97328 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm

[Lldb-commits] [clang] [lldb] [HLSL] Implement intangible AST type (PR #97362)

2024-07-03 Thread Helena Kotas via lldb-commits
https://github.com/hekota edited https://github.com/llvm/llvm-project/pull/97362 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [LLDB][Minidump] Support minidumps where there are multiple exception streams (PR #97470)

2024-07-03 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/97470 >From dc4730dcff31c2c9212d2ce5412ecb8a9f4d83c0 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Tue, 2 Jul 2024 12:41:02 -0700 Subject: [PATCH 1/5] Add support to read multiple exception streams in minidumps

[Lldb-commits] [lldb] [lldb] Remove Listener::SetShadow (PR #97555)

2024-07-03 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben approved this pull request. LGTM :) https://github.com/llvm/llvm-project/pull/97555 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [llvm] [BOLT] Match functions with name similarity (PR #95884)

2024-07-03 Thread Shaw Young via lldb-commits
https://github.com/shawbyoung edited https://github.com/llvm/llvm-project/pull/95884 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [llvm] [BOLT] Match functions with name similarity (PR #95884)

2024-07-03 Thread Shaw Young via lldb-commits
https://github.com/shawbyoung updated https://github.com/llvm/llvm-project/pull/95884 >From fab60ab1f26be1799f05d1e2b02cc6b89093b670 Mon Sep 17 00:00:00 2001 From: Sayhaan Siddiqui Date: Mon, 17 Jun 2024 23:14:07 -0700 Subject: [PATCH 1/9] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20ch?=

[Lldb-commits] [clang] [lldb] [llvm] [BOLT] Match functions with name similarity (PR #95884)

2024-07-03 Thread Shaw Young via lldb-commits
https://github.com/shawbyoung closed https://github.com/llvm/llvm-project/pull/95884 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [HLSL] Implement intangible AST type (PR #97362)

2024-07-03 Thread Helena Kotas via lldb-commits
https://github.com/hekota edited https://github.com/llvm/llvm-project/pull/97362 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [HLSL] Implement intangible AST type (PR #97362)

2024-07-03 Thread Helena Kotas via lldb-commits
https://github.com/hekota edited https://github.com/llvm/llvm-project/pull/97362 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix flake in TestZerothFrame.py (PR #96685)

2024-07-03 Thread Kendal Harland via lldb-commits
https://github.com/kendalharland updated https://github.com/llvm/llvm-project/pull/96685 >From a3c524bebfc976f3dfee5b67dac490ed44705d6a Mon Sep 17 00:00:00 2001 From: kendal Date: Wed, 3 Jul 2024 11:18:43 -0700 Subject: [PATCH 1/2] Fix type error when calling random.randrange with 'float' arg

[Lldb-commits] [lldb] Fix flake in TestZerothFrame.py (PR #96685)

2024-07-03 Thread Kendal Harland via lldb-commits
https://github.com/kendalharland updated https://github.com/llvm/llvm-project/pull/96685 >From b880f6d7951534fd90c3728fb9cabbe515295557 Mon Sep 17 00:00:00 2001 From: kendal Date: Mon, 24 Jun 2024 13:42:20 -0700 Subject: [PATCH] Fix flake in TestZerothFrame.py This test is relying on the order

[Lldb-commits] [lldb] Fix flake in TestZerothFrame.py (PR #96685)

2024-07-03 Thread Kendal Harland via lldb-commits
kendalharland wrote: Applied formatter patch and rebased onto main https://github.com/llvm/llvm-project/pull/96685 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [llvm] [BOLT] Match functions with name similarity (PR #95884)

2024-07-03 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `bolt-x86_64-ubuntu-shared` running on `bolt-worker` while building `bolt` at step 5 "build-bolt". Full details are available at: https://lab.llvm.org/buildbot/#/builders/151/builds/775 Here is the relevant piece of the build

  1   2   >