@@ -791,26 +805,99 @@ void MinidumpFileBuilder::AddLinuxFileStreams(
size_t size = memory_buffer->getBufferSize();
if (size == 0)
continue;
- AddDirectory(stream, size);
+ error = AddDirectory(stream, size);
+ if (error.Fail())
+return
@@ -821,47 +908,285 @@ Status MinidumpFileBuilder::Dump(lldb::FileUP
&core_file) const {
Status error;
size_t bytes_written;
- bytes_written = header_size;
- error = core_file->Write(&header, bytes_written);
- if (error.Fail() || bytes_written != header_size) {
-if
@@ -821,47 +908,285 @@ Status MinidumpFileBuilder::Dump(lldb::FileUP
&core_file) const {
Status error;
size_t bytes_written;
- bytes_written = header_size;
- error = core_file->Write(&header, bytes_written);
- if (error.Fail() || bytes_written != header_size) {
-if
JDevlieghere wrote:
> LGTM but all the formatting changes are a bit distracting, would be nice to
> be have them in a separate commit.
Oh yeah, that wasn't intentional, must be trailing whitespace. Let me fix that.
https://github.com/llvm/llvm-project/pull/95871
___
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/95871
>From 7956f02f180d9e7593e2ddaa2ed376ec926a6825 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Mon, 17 Jun 2024 17:41:03 -0700
Subject: [PATCH] [lldb] Suppress unsupported language warning for assembl
@@ -25,6 +25,15 @@ class LLDB_API SBStatisticsOptions {
void SetSummaryOnly(bool b);
bool GetSummaryOnly();
+ void SetIncludeTargets(bool b);
+ bool GetIncludeTargets() const;
+
+ void SetIncludeModules(bool b);
+ bool GetIncludeModules() const;
+
+ void SetIncludeTra
@@ -76,13 +77,22 @@ class CommandObjectStatsDump : public CommandObjectParsed {
m_all_targets = true;
break;
case 's':
-m_stats_options.summary_only = true;
+m_stats_options.SetSummaryOnly(true);
break;
case 'f':
-m_
@@ -1425,8 +1425,21 @@ let Command = "statistics dump" in {
Desc<"Dump the total possible debug info statistics. "
"Force loading all the debug information if not yet loaded, and collect "
"statistics with those.">;
+ def statistics_dump_targets: Option<"targets",
@@ -76,13 +77,22 @@ class CommandObjectStatsDump : public CommandObjectParsed {
m_all_targets = true;
break;
case 's':
-m_stats_options.summary_only = true;
+m_stats_options.SetSummaryOnly(true);
break;
case 'f':
-m_
@@ -76,13 +77,22 @@ class CommandObjectStatsDump : public CommandObjectParsed {
m_all_targets = true;
break;
case 's':
-m_stats_options.summary_only = true;
+m_stats_options.SetSummaryOnly(true);
break;
case 'f':
-m_
@@ -1425,8 +1425,21 @@ let Command = "statistics dump" in {
Desc<"Dump the total possible debug info statistics. "
"Force loading all the debug information if not yet loaded, and collect "
"statistics with those.">;
+ def statistics_dump_targets: Option<"targets",
@@ -29,6 +29,9 @@ struct OptionArgParser {
static bool ToBoolean(llvm::StringRef s, bool fail_value, bool *success_ptr);
+ static bool ToBoolean(llvm::StringRef option_name, llvm::StringRef
option_arg,
+bool fail_value, Status &error);
+
--
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/95871
>From 7956f02f180d9e7593e2ddaa2ed376ec926a6825 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Mon, 17 Jun 2024 17:41:03 -0700
Subject: [PATCH 1/2] [lldb] Suppress unsupported language warning for ass
https://github.com/thetruestblue updated
https://github.com/llvm/llvm-project/pull/95586
>From db161e5c87eecbd5607f78e7afd00af183aa415c Mon Sep 17 00:00:00 2001
From: Blue Gaston
Date: Fri, 14 Jun 2024 12:53:27 -0400
Subject: [PATCH 1/2] [LLDB] Don't cache module sp when Activate() fails.
Curr
https://github.com/JDevlieghere approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/95586
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jasonmolenda wrote:
> > Thanks for the overwhelming support :-)
>
> I hate to ruin a party, but I don't think this is a good use of `operator==`,
> precisely because it does not define an equivalence relation (it's not
> transitive). Might I suggest named function instead? `IsCompatible` ?
Th
@@ -791,26 +807,101 @@ void MinidumpFileBuilder::AddLinuxFileStreams(
size_t size = memory_buffer->getBufferSize();
if (size == 0)
continue;
- AddDirectory(stream, size);
+ error = AddDirectory(stream, size);
+ if (error.Fail())
+retur
@@ -20,25 +20,98 @@
#include "lldb/Target/RegisterContext.h"
#include "lldb/Target/StopInfo.h"
#include "lldb/Target/ThreadList.h"
+#include "lldb/Utility/DataBufferHeap.h"
#include "lldb/Utility/DataExtractor.h"
#include "lldb/Utility/LLDBLog.h"
#include "lldb/Utility/Log.h
@@ -791,26 +807,101 @@ void MinidumpFileBuilder::AddLinuxFileStreams(
size_t size = memory_buffer->getBufferSize();
if (size == 0)
continue;
- AddDirectory(stream, size);
+ error = AddDirectory(stream, size);
+ if (error.Fail())
+retur
@@ -791,26 +807,101 @@ void MinidumpFileBuilder::AddLinuxFileStreams(
size_t size = memory_buffer->getBufferSize();
if (size == 0)
continue;
- AddDirectory(stream, size);
+ error = AddDirectory(stream, size);
+ if (error.Fail())
+retur
101 - 120 of 120 matches
Mail list logo
