[Lldb-commits] [lldb] [LLDB] Remove the redundent increment of 'properties' variable (PR #95675)

https://github.com/xgupta created https://github.com/llvm/llvm-project/pull/95675 This is described in (N3) https://pvs-studio.com/en/blog/posts/cpp/1126/ so caught by the PVS Studio analyzer. Warning message - V547 Expression 'properties ++ > 0' is always false. CommandObjectTarget.cpp:100 I

[Lldb-commits] [lldb] [LLDB] Remove the redundent increment of 'properties' variable (PR #95675)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Shivam Gupta (xgupta) Changes This is described in (N3) https://pvs-studio.com/en/blog/posts/cpp/1126/ so caught by the PVS Studio analyzer. Warning message - V547 Expression 'properties ++ > 0' is always false. CommandObjectTarget.cpp:100

[Lldb-commits] [lldb] [lldb] Remove dead code block (NFC) (PR #94775)

xgupta wrote: Gentile ping! https://github.com/llvm/llvm-project/pull/94775 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix incorrect logical operator in 'if' condition check (NFC) (PR #94779)

xgupta wrote: Gentile ping! https://github.com/llvm/llvm-project/pull/94779 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove dead code block (NFC) (PR #94775)

https://github.com/JDevlieghere approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/94775 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove dead code block (NFC) (PR #94775)

https://github.com/xgupta closed https://github.com/llvm/llvm-project/pull/94775 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] ef01c75 - [lldb] Remove dead code block (NFC) (#94775)

Author: Shivam Gupta Date: 2024-06-15T23:39:58+05:30 New Revision: ef01c75d467df92b8c659307595aa74ed2290cd8 URL: https://github.com/llvm/llvm-project/commit/ef01c75d467df92b8c659307595aa74ed2290cd8 DIFF: https://github.com/llvm/llvm-project/commit/ef01c75d467df92b8c659307595aa74ed2290cd8.diff

[Lldb-commits] [lldb] [lldb] Remove dead code block (NFC) (PR #94775)

fmayer wrote: Random drive-by: > The check that max_bit_pos == sign_bit_pos conflicts with the check that > sign_bit_pos < max_bit_pos in the block surrounding it. Should we add an `assert` to this function then? https://github.com/llvm/llvm-project/pull/94775

[Lldb-commits] [lldb] [lldb] Correct format specifier for sscanf to prevent buffer overflow (NFC) (PR #94783)

https://github.com/xgupta updated https://github.com/llvm/llvm-project/pull/94783 >From 17d39d89ee723881063ecbea19caaa6806e4e095 Mon Sep 17 00:00:00 2001 From: Shivam Gupta Date: Sat, 15 Jun 2024 23:57:03 +0530 Subject: [PATCH] Resolved merge conflict --- lldb/source/Host/linux/Host.cpp | 2 +

[Lldb-commits] [lldb] [lldb] Correct format specifier for sscanf to prevent buffer overflow (NFC) (PR #94783)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff ef01c75d467df92b8c659307595aa74ed2290cd8 17d39d89ee723881063ecbea19caaa6806e4e095 --

[Lldb-commits] [lldb] [LLDB] Add an assert to verify sign_bit_pos is within the valid range (NFC) (PR #95678)

https://github.com/xgupta created https://github.com/llvm/llvm-project/pull/95678 None >From 74efb6ae3187fe1e67e61cdca1f99b9de8146db4 Mon Sep 17 00:00:00 2001 From: Shivam Gupta Date: Sun, 16 Jun 2024 00:21:51 +0530 Subject: [PATCH] [LLDB] Add an assert to verify sign_bit_pos is within the va

[Lldb-commits] [lldb] [LLDB] Add an assert to verify sign_bit_pos is within the valid range (NFC) (PR #95678)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Shivam Gupta (xgupta) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/95678.diff 1 Files Affected: - (modified) lldb/source/Utility/Scalar.cpp (+15-16) ``diff diff --git a/lldb/source/Utility/Scalar.cpp b/lld