@@ -2007,6 +2007,124 @@ size_t Process::ReadMemory(addr_t addr, void *buf,
size_t size, Status &error) {
}
}
+void Process::DoFindInMemory(lldb::addr_t start_addr, lldb::addr_t end_addr,
+ const uint8_t *buf, size_t size,
+
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/95007
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,21 @@
+#include
+
+int main() {
+ constexpr char SINGLE_INSTANCE_STRING[] = "there_is_only_one_of_me";
+ constexpr size_t single_instance_size = sizeof(SINGLE_INSTANCE_STRING) + 1;
+ char *single_instance = new char[single_instance_size];
+ strcpy(single_instance,
@@ -0,0 +1,21 @@
+#include
+
+int main() {
+ constexpr char SINGLE_INSTANCE_STRING[] = "there_is_only_one_of_me";
clayborg wrote:
If you take constexpr off of here, you can create the variable on the stack,
and then just use the memory region for the SP of the
@@ -0,0 +1,21 @@
+#include
+
+int main() {
+ constexpr char SINGLE_INSTANCE_STRING[] = "there_is_only_one_of_me";
+ constexpr size_t single_instance_size = sizeof(SINGLE_INSTANCE_STRING) + 1;
+ char *single_instance = new char[single_instance_size];
+ strcpy(single_instance,
@@ -0,0 +1,31 @@
+import lldb
+
+SINGLE_INSTANCE_PATTERN = "there_is_only_one_of_me"
+DOUBLE_INSTANCE_PATTERN = "there_is_exactly_two_of_me"
+
+
+def GetAddressRanges(test_base):
clayborg wrote:
Here you can just get the current thread's stack pointer for
"there
https://github.com/shawbyoung created
https://github.com/llvm/llvm-project/pull/95047
- **Rebase: [Facebook] Add clang driver options to test debug info and BOLT**
- **Rebase: [Facebook] [MC] Introduce NeverAlign fragment type**
- **[BOLT] Fix ValidateMemRefs**
- **[BOLT][NFC] Add sink block to
https://github.com/shawbyoung edited
https://github.com/llvm/llvm-project/pull/95047
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/shawbyoung edited
https://github.com/llvm/llvm-project/pull/95047
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/shawbyoung closed
https://github.com/llvm/llvm-project/pull/95047
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/shawbyoung created
https://github.com/llvm/llvm-project/pull/95049
- **Rebase: [Facebook] Add clang driver options to test debug info and BOLT**
- **Rebase: [Facebook] [MC] Introduce NeverAlign fragment type**
- **[BOLT] Fix ValidateMemRefs**
- **[BOLT][NFC] Add sink block to
https://github.com/shawbyoung closed
https://github.com/llvm/llvm-project/pull/95049
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben updated
https://github.com/llvm/llvm-project/pull/94575
>From bc3292a4cecdff503d5123a8dffe4ff32aff814d Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Date: Mon, 10 Jun 2024 14:53:29 -0700
Subject: [PATCH] [lldb/crashlog] Make interactive mode the new default
https://github.com/medismailben reopened
https://github.com/llvm/llvm-project/pull/94575
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
medismailben wrote:
Closed this by mistake.
https://github.com/llvm/llvm-project/pull/94575
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben updated
https://github.com/llvm/llvm-project/pull/94575
>From f00c33948310576668bc886415cf98dbd1ab97be Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Date: Mon, 10 Jun 2024 14:54:36 -0700
Subject: [PATCH] [lldb/crashlog] Make interactive mode the new default
@@ -1794,8 +1803,36 @@ def SymbolicateCrashLogs(debugger, command_args, result,
is_command):
result.SetError(str(e))
return
+# To avoid breaking existing users, we should keep supporting legacy flags
+# even if we don't use them / advertise them anymor
@@ -1794,8 +1803,36 @@ def SymbolicateCrashLogs(debugger, command_args, result,
is_command):
result.SetError(str(e))
return
+# To avoid breaking existing users, we should keep supporting legacy flags
+# even if we don't use them / advertise them anymor
@@ -1821,31 +1858,24 @@ def SymbolicateCrashLogs(debugger, command_args,
result, is_command):
print(debugger.GetVersionString())
return
-if options.debug:
-print("command_args = %s" % command_args)
-print("options", options)
-print(
@@ -1794,8 +1803,36 @@ def SymbolicateCrashLogs(debugger, command_args, result,
is_command):
result.SetError(str(e))
return
+# To avoid breaking existing users, we should keep supporting legacy flags
+# even if we don't use them / advertise them anymor
@@ -1794,8 +1803,36 @@ def SymbolicateCrashLogs(debugger, command_args, result,
is_command):
result.SetError(str(e))
return
+# To avoid breaking existing users, we should keep supporting legacy flags
+# even if we don't use them / advertise them anymor
https://github.com/medismailben updated
https://github.com/llvm/llvm-project/pull/94575
>From fd69e8f2bb83443b381dd11ebddac33676d5fdf3 Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Date: Mon, 10 Jun 2024 15:11:25 -0700
Subject: [PATCH] [lldb/crashlog] Make interactive mode the new default
https://github.com/shawbyoung reopened
https://github.com/llvm/llvm-project/pull/95047
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord edited
https://github.com/llvm/llvm-project/pull/94575
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord commented:
LGTM in general, a few more comments but otherwise this is looking pretty good
https://github.com/llvm/llvm-project/pull/94575
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-
@@ -1794,8 +1802,35 @@ def SymbolicateCrashLogs(debugger, command_args, result,
is_command):
result.SetError(str(e))
return
+# To avoid breaking existing users, we should keep supporting legacy flags
+# even if we don't use them / advertise them anymor
@@ -1821,31 +1856,24 @@ def SymbolicateCrashLogs(debugger, command_args,
result, is_command):
print(debugger.GetVersionString())
return
-if options.debug:
-print("command_args = %s" % command_args)
-print("options", options)
-print(
@@ -1794,8 +1802,35 @@ def SymbolicateCrashLogs(debugger, command_args, result,
is_command):
result.SetError(str(e))
return
+# To avoid breaking existing users, we should keep supporting legacy flags
+# even if we don't use them / advertise them anymor
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/94575
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,69 @@
+"""
clayborg wrote:
I can do that. I have a DWARF generator that I wrote in python.
https://github.com/llvm/llvm-project/pull/94846
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://li
@@ -0,0 +1,69 @@
+"""
+Test the SBModule and SBTarget type lookup APIs to find multiple types.
+"""
+
+import lldb
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+
+
+class TypeFindFirstTestCase(TestBase):
+def test_find_first_type(self):
+
jasonmolenda wrote:
this is fine but fwiw there are `Process::FixAnyAddress`,
`Process::FixDataAddress`, `Process::FixCodeAddress` methods that are the
preferred way of clearing pointerauth bits and they fall back to returning the
value unmodified if there is no ABI.
https://github.com/llvm/l
@@ -0,0 +1,69 @@
+"""
+Test the SBModule and SBTarget type lookup APIs to find multiple types.
+"""
+
+import lldb
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+
+
+class TypeFindFirstTestCase(TestBase):
+def test_find_first_type(self):
+
jasonmolenda wrote:
Hi, thanks for the PR. I wrote the x86 unwinder but I don't work with the ISA
very often any more, I'm a little confused. Shouldn't the sp offset after this
instruction executes be 16? The test is testing for 8. I'm sure I've
misunderstood the effects of the instruction
https://github.com/jasonmolenda approved this pull request.
Ah wait, it's because x86_64 functions on entry have the CFA == $rsp+8, right.
So you add 16 to rsp and now the CFA is $rsp-8. This is good to merge. Do you
have access to do that yourself?
https://github.com/llvm/llvm-project/pull
https://github.com/clayborg updated
https://github.com/llvm/llvm-project/pull/94846
>From 2f579ecafeaeb735cbce1bcfc829eb52a93f067c Mon Sep 17 00:00:00 2001
From: Greg Clayton
Date: Fri, 7 Jun 2024 23:56:03 -0700
Subject: [PATCH 1/2] Fix type lookup bug where wrong decl context was being
used f
@@ -657,6 +657,42 @@ std::optional
DWARFDebugNames::Entry::getLocalTUOffset() const {
return NameIdx->getLocalTUOffset(*Index);
}
+std::optional
+DWARFDebugNames::Entry::getForeignTUTypeSignature() const {
+ std::optional Index = getLocalTUIndex();
+ const uint32_t NumLoc
https://github.com/clayborg updated
https://github.com/llvm/llvm-project/pull/87740
>From c364215cef4d383bf5cb51bf61d442a5bc9fbfe9 Mon Sep 17 00:00:00 2001
From: Greg Clayton
Date: Sat, 30 Mar 2024 10:50:34 -0700
Subject: [PATCH 1/8] Add support for using foreign type units in .debug_names.
Th
https://github.com/clayborg updated
https://github.com/llvm/llvm-project/pull/94846
>From 2f579ecafeaeb735cbce1bcfc829eb52a93f067c Mon Sep 17 00:00:00 2001
From: Greg Clayton
Date: Fri, 7 Jun 2024 23:56:03 -0700
Subject: [PATCH 1/3] Fix type lookup bug where wrong decl context was being
used f
https://github.com/jasonmolenda created
https://github.com/llvm/llvm-project/pull/95067
Add comments and a test for delay-init libraries on macOS. I originally added
the support in 954d00e87cdd77d0e9e367be52e62340467bd779 a month ago, but
without these additional clarifications.
rdar://12688
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jason Molenda (jasonmolenda)
Changes
Add comments and a test for delay-init libraries on macOS. I originally added
the support in 954d00e87cdd77d0e9e367be52e62340467bd779 a month ago, but
without these additional clarifications.
rdar://1
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
c4f8ae6f32dadf9383c94ed13152d91f68631255...6b67c214ea95418e3f246c694d0a40009176fc07
lldb/
https://github.com/JDevlieghere approved this pull request.
LGTM if the formatter's happy.
https://github.com/llvm/llvm-project/pull/95067
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-co
jasonmolenda wrote:
the formatter is whining about an extra newline in a test file
https://github.com/llvm/llvm-project/pull/95067
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/95067
>From 6b67c214ea95418e3f246c694d0a40009176fc07 Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Mon, 10 Jun 2024 17:52:42 -0700
Subject: [PATCH 1/2] [lldb] NFC add comments and test case for ObjectFileMach
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/95067
>From 6b67c214ea95418e3f246c694d0a40009176fc07 Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Mon, 10 Jun 2024 17:52:42 -0700
Subject: [PATCH 1/2] [lldb] NFC add comments and test case for ObjectFileMach
Author: Jason Molenda
Date: 2024-06-10T20:33:38-07:00
New Revision: 1934208132e3a084c5952656ae29816958b8207c
URL:
https://github.com/llvm/llvm-project/commit/1934208132e3a084c5952656ae29816958b8207c
DIFF:
https://github.com/llvm/llvm-project/commit/1934208132e3a084c5952656ae29816958b8207c.diff
https://github.com/jasonmolenda closed
https://github.com/llvm/llvm-project/pull/95067
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/royitaqi created
https://github.com/llvm/llvm-project/pull/95075
# Add options
The following options are added to the `statistics dump` command:
* `--targets`: Dumps the `targets` section.
* `--modules`: Dumps the `modules` section.
When both options are given, the field `mo
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (royitaqi)
Changes
# Add options
The following options are added to the `statistics dump` command:
* `--targets`: Dumps the `targets` section.
* `--modules`: Dumps the `modules` section.
When both options are given, the field `moduleI
royitaqi wrote:
cc @kusmour, @clayborg , @jeffreytan81
https://github.com/llvm/llvm-project/pull/95075
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 1fe4f2d1a4b9d16ae41076608783df4427a4d985
f6c7737d056526714e65c35f0204b9b4a04776c3 --
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
1fe4f2d1a4b9d16ae41076608783df4427a4d985...f6c7737d056526714e65c35f0204b9b4a04776c3
lldb/
https://github.com/royitaqi updated
https://github.com/llvm/llvm-project/pull/95075
>From f57f98f22425d3c869621b43b65da705d50b5934 Mon Sep 17 00:00:00 2001
From: Roy Shi
Date: Mon, 10 Jun 2024 17:04:11 -0700
Subject: [PATCH 1/3] Add --targets and --modules option to statistics dump
---
lldb/i
https://github.com/royitaqi updated
https://github.com/llvm/llvm-project/pull/95075
>From f57f98f22425d3c869621b43b65da705d50b5934 Mon Sep 17 00:00:00 2001
From: Roy Shi
Date: Mon, 10 Jun 2024 17:04:11 -0700
Subject: [PATCH 1/4] Add --targets and --modules option to statistics dump
---
lldb/i
https://github.com/royitaqi updated
https://github.com/llvm/llvm-project/pull/95075
>From f57f98f22425d3c869621b43b65da705d50b5934 Mon Sep 17 00:00:00 2001
From: Roy Shi
Date: Mon, 10 Jun 2024 17:04:11 -0700
Subject: [PATCH 1/5] Add --targets and --modules option to statistics dump
---
lldb/i
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/95075
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/clayborg commented:
With these new options the default `statistics dump` changes the output from
what is was before. I might suggest that we set the defaults so it does what it
used to do by default, and then let users opt out of the targets and modules in
each output. This
@@ -1416,16 +1416,26 @@ let Command = "trace schema" in {
}
let Command = "statistics dump" in {
- def statistics_dump_all: Option<"all-targets", "a">, Group<1>,
+ def statistics_dump_all: Option<"all-targets", "a">, GroupRange<1, 2>,
Desc<"Include statistics for all ta
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/95075
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/clayborg requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/95075
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1416,16 +1416,26 @@ let Command = "trace schema" in {
}
let Command = "statistics dump" in {
- def statistics_dump_all: Option<"all-targets", "a">, Group<1>,
+ def statistics_dump_all: Option<"all-targets", "a">, GroupRange<1, 2>,
Desc<"Include statistics for all ta
@@ -1416,16 +1416,26 @@ let Command = "trace schema" in {
}
let Command = "statistics dump" in {
- def statistics_dump_all: Option<"all-targets", "a">, Group<1>,
+ def statistics_dump_all: Option<"all-targets", "a">, GroupRange<1, 2>,
Desc<"Include statistics for all ta
@@ -133,6 +133,8 @@ struct ConstStringStats {
struct StatisticsOptions {
bool summary_only = false;
bool load_all_debug_info = false;
+ bool include_targets = false;
+ bool include_modules = false;
clayborg wrote:
These should default to `true` if we are
@@ -110,6 +108,9 @@ bool
StopInfoMachException::DeterminePtrauthFailure(ExecutionContext &exe_ctx) {
strm.Printf("Note: Possible pointer authentication failure detected.\n");
};
+ ABISP abi_sp = process.GetABI();
+ assert(abi_sp && "Missing ABI info");
---
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/91544
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/clayborg approved this pull request.
One nit from inlined code to check `Info.GetPriorityValue().has_value()` and
this is good to go.
https://github.com/llvm/llvm-project/pull/91544
___
lldb-commits mailing list
lldb-commits@lists.l
@@ -86,4 +89,22 @@ TEST_F(HostTest, GetProcessInfo) {
ProcessInstanceInfo::timespec next_user_time = Info.GetUserTime();
ASSERT_TRUE(user_time.tv_sec <= next_user_time.tv_sec ||
user_time.tv_usec <= next_user_time.tv_usec);
+
+ struct rlimit rlim;
+ EXPECT_E
101 - 168 of 168 matches
Mail list logo
