labath wrote:
Agreed. The reason code is looking like it does is because at some point in
(now, pretty distant) past it was possible to `cd` into the test directory,
type `make` and get the test binary out. Among other problems, this has caused
duplicate code for determining various properties
DavidSpickett wrote:
The test is still failing on Windows on Arm, I will figure it out.
https://github.com/llvm/llvm-project/pull/93881
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commi
labath wrote:
> > Ok, I see now. It's an ld.bfd vs ld.lld thing. You probably have your clang
> > configured to use lld. LLD does not put relocation addends into the data
> > section (on both arm and intel). ld.bfd does, which is why this sort of
> > happens to work there. Was your intention t
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/93808
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/93808
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -3,4 +3,8 @@
# C_SOURCES := b.c
# EXE := b.out
+ifndef PIE
+ LDFLAGS := -no-pie
labath wrote:
Setting LD_EXTRAS is the typical way to pass linker flags from here (the same
for other files)
https://github.com/llvm/llvm-project/pull/93808
___
slydiman wrote:
> we support running (all?) shell tests on a remote system?
We have configured buildbots with Windows x86_64, Linux x86_64 hosts and Linux
Aarch64 targets. Currently we got 2 failed Shell tests on Windows host and 2
failed test on Linux hosts. This test failed on both hosts.
https://github.com/labath created
https://github.com/llvm/llvm-project/pull/94192
None
>From 8bb7817d913cd8843fe8c90dcd7c8b70a0366994 Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Mon, 3 Jun 2024 09:58:47 +0200
Subject: [PATCH] [lldb] Add documentation for the max_children argument
---
l
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/94192.diff
2 Files Affected:
- (modified) lldb/docs/use/variable.rst (+26-11)
- (modified) lldb/include/lldb/API/SBValue.h (+14)
``diff
d
https://github.com/labath updated
https://github.com/llvm/llvm-project/pull/93946
>From 1e25ef1cc5ff4d12a3e5b85c8ea7cd30a3e0908e Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Fri, 31 May 2024 10:06:19 +
Subject: [PATCH 1/2] [lldb] Avoid (unlimited) GetNumChildren calls when
printing va
@@ -442,16 +443,19 @@ lldb::Format
FormatManager::GetSingleItemFormat(lldb::Format vector_format) {
}
bool FormatManager::ShouldPrintAsOneLiner(ValueObject &valobj) {
+ TargetSP target_sp = valobj.GetTargetSP();
// if settings say no oneline whatsoever
- if (valobj.GetTa
labath wrote:
> This seems reasonable. However, I note that on the page where we show how to
> write synthetic child providers, we say:
>
> def num_children(self): this call should return the number of children that
> you want your object to have
>
> That's actually not true - we pass the max
@@ -930,40 +930,55 @@ be implemented by the Python class):
class SyntheticChildrenProvider:
def __init__(self, valobj, internal_dict):
- this call should initialize the Python object using valobj as the
variable to provide synthetic children for
- def nu
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/93946
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Pavel Labath
Date: 2024-06-03T10:34:44+02:00
New Revision: 763b96c86d81d51d0db430791a61fd1e8a406bce
URL:
https://github.com/llvm/llvm-project/commit/763b96c86d81d51d0db430791a61fd1e8a406bce
DIFF:
https://github.com/llvm/llvm-project/commit/763b96c86d81d51d0db430791a61fd1e8a406bce.diff
@@ -2153,26 +2152,42 @@ bool DWARFExpression::Evaluate(
}
break;
- case Value::ValueType::FileAddress:
- case Value::ValueType::HostAddress:
-if (error_ptr) {
- lldb::addr_t addr =
curr_piece_source_value.GetS
@@ -768,3 +768,63 @@ TEST(DWARFExpression, ExtensionsDWO) {
testExpressionVendorExtensions(dwo_module_sp, *dwo_dwarf_unit);
}
+
+TEST_F(DWARFExpressionMockProcessTest, DW_OP_piece_file_addr) {
+ struct MockTarget : Target {
+MockTarget(Debugger &debugger, const ArchSpec
@@ -768,3 +768,63 @@ TEST(DWARFExpression, ExtensionsDWO) {
testExpressionVendorExtensions(dwo_module_sp, *dwo_dwarf_unit);
}
+
+TEST_F(DWARFExpressionMockProcessTest, DW_OP_piece_file_addr) {
+ struct MockTarget : Target {
labath wrote:
You could consider
https://github.com/labath commented:
Can't say I'm thrilled by the addition of a random virtual method, but I don't
want to stand in the way. I'll just note that there is an alternative - in the
form of writing a minimal real target in assembly. In fact, I think
`test/Shell/SymbolFile/DWARF/x8
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/94026
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: David Spickett
Date: 2024-06-03T09:02:06Z
New Revision: 09c0607919c958c1a816acd58cc6c6585aec51a6
URL:
https://github.com/llvm/llvm-project/commit/09c0607919c958c1a816acd58cc6c6585aec51a6
DIFF:
https://github.com/llvm/llvm-project/commit/09c0607919c958c1a816acd58cc6c6585aec51a6.diff
LOG
labath wrote:
> > That said, using a package designed (AIUI) for python versions for parsing
> > versions of gcc/clang does strike me as somewhat... unusual, even if it
> > does work, so _**maybe**_ there is case to be made for writing something
> > custom (I'm not sure if we really need anyth
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/94196
On Windows the function does not have a symbol associated with it:
Function: id = {0x01c9}, name = "_Dfunction", range =
[0x000140001000-0x000140001004)
LineEntry: <...>
Whereas it
labath wrote:
I'd like to try this myself. How can I configure my build to run this sort of
thing?
https://github.com/llvm/llvm-project/pull/94127
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinf
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: David Spickett (DavidSpickett)
Changes
On Windows the function does not have a symbol associated with it:
Function: id = {0x01c9}, name = "_Dfunction", range =
[0x000140001000-0x000140001004)
LineEntry: <...>
Where
Author: David Stone
Date: 2024-06-03T11:09:13+02:00
New Revision: 8918d35dbde126c95350b674a2bb102692d90260
URL:
https://github.com/llvm/llvm-project/commit/8918d35dbde126c95350b674a2bb102692d90260
DIFF:
https://github.com/llvm/llvm-project/commit/8918d35dbde126c95350b674a2bb102692d90260.diff
L
https://github.com/cor3ntin closed
https://github.com/llvm/llvm-project/pull/67930
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 approved this pull request.
https://github.com/llvm/llvm-project/pull/94196
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: David Spickett
Date: 2024-06-03T09:16:49Z
New Revision: 770b6c792472e1ff87e8598728d37c516861218e
URL:
https://github.com/llvm/llvm-project/commit/770b6c792472e1ff87e8598728d37c516861218e
DIFF:
https://github.com/llvm/llvm-project/commit/770b6c792472e1ff87e8598728d37c516861218e.diff
LOG
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/94196
>From f45103937007bbc42fe56dc172fcbee9c37a2f34 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Mon, 3 Jun 2024 09:04:01 +
Subject: [PATCH 1/2] [lldb][test] Fix D lang mangling test on Windows
On Wi
Author: David Spickett
Date: 2024-06-03T10:18:39+01:00
New Revision: 6abf361953e9c5d019a72fd83765498d269eb080
URL:
https://github.com/llvm/llvm-project/commit/6abf361953e9c5d019a72fd83765498d269eb080
DIFF:
https://github.com/llvm/llvm-project/commit/6abf361953e9c5d019a72fd83765498d269eb080.diff
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/94196
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Pavel Labath
Date: 2024-06-03T11:23:51+02:00
New Revision: d00731cb7fcc91047531069e029964a39935a5bb
URL:
https://github.com/llvm/llvm-project/commit/d00731cb7fcc91047531069e029964a39935a5bb
DIFF:
https://github.com/llvm/llvm-project/commit/d00731cb7fcc91047531069e029964a39935a5bb.diff
github-actions[bot] wrote:
⚠️ We detected that you are using a GitHub private e-mail address to contribute
to the repo. Please turn off [Keep my email addresses
private](https://github.com/settings/emails) setting in your account. See
[LLVM
Discourse](https://discourse.llvm.org/t/hidden-email
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/94034
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/94039
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
github-actions[bot] wrote:
⚠️ We detected that you are using a GitHub private e-mail address to contribute
to the repo. Please turn off [Keep my email addresses
private](https://github.com/settings/emails) setting in your account. See
[LLVM
Discourse](https://discourse.llvm.org/t/hidden-email
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/94017
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
I approved the workflows on this and your other changes.
> We detected that you are using a GitHub private e-mail address to contribute
> to the repo
Please address this and then we can get this merged.
https://github.com/llvm/llvm-project/pull/94017
_
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
fc21387b6510ee44520f2f17fb671f1265a9055f...5c7ba6c7d95cced5d8acc609a40a6b8307bc7fed
lldb/
github-actions[bot] wrote:
⚠️ We detected that you are using a GitHub private e-mail address to contribute
to the repo. Please turn off [Keep my email addresses
private](https://github.com/settings/emails) setting in your account. See
[LLVM
Discourse](https://discourse.llvm.org/t/hidden-email
DavidSpickett wrote:
The formatter is failing, but I would prefer to keep this change purely
addressing the lint warning. Certainly you can update this to reorder the
"fr"/"rf" but ignore the rest of its complaints.
Whoever merges this (probably me) can push a reformatting change directly
aft
https://github.com/DavidSpickett approved this pull request.
This LGTM, can be merged once the private email is fixed.
https://github.com/llvm/llvm-project/pull/94039
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-
https://github.com/DavidSpickett approved this pull request.
Changes LGTM.
https://github.com/llvm/llvm-project/pull/94017
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/dzhidzhoev updated
https://github.com/llvm/llvm-project/pull/93883
>From 610481d82eae3423911f4cd5cac3c45a15904e57 Mon Sep 17 00:00:00 2001
From: Vladislav Dzhidzhoev
Date: Sat, 13 Apr 2024 23:55:25 +
Subject: [PATCH] [lldb][test] Add --make argument to dotest.py (#93883)
slydiman wrote:
> How can I configure my build to run this sort of thing?
The simplest way is to use the same arch target, e. g. x86_64 Linux host and
x86_64 Linux target. You do not need a cross compiler in this case. To run
Shell tests with a remote target it is necesasry
- define LLVM_TARG
slydiman wrote:
Note `EchoCommandsQuiet.out` expects that `TestEchoCommands.test.tmp.file` will
be
```
start
done
```
But in case of a remote target it will be something like
```
start
Platform: remote-linux
Connected: no
Platform: remote-linux
Triple: aarch64-unknown-linux-gnu
OS Vers
labath wrote:
> * LLDB_PLATFORM_URL
Is that an environment variable or a cmake variable? I don't see a single
instance of that string in the entire lldb source tree. Are you sure that's not
some downstream feature?
https://github.com/llvm/llvm-project/pull/94127
__
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/94220
This means that CI won't have to hardcode these.
We can't do conditional installs here by platform so pexpect is listed
normally. If it's installed on Windows that's fine, we just won't use it.
>From e5a6
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: David Spickett (DavidSpickett)
Changes
This means that CI won't have to hardcode these.
We can't do conditional installs here by platform so pexpect is listed
normally. If it's installed on Windows that's fine, we just won't use it.
---
F
DavidSpickett wrote:
I've not been able to find what versioning scheme these 2 packages use, so I'm
not sure what versions to put here if any.
Currently Linaro has:
psutil==5.9.4 on Windows
psutil == 5.9.8 on Linux
pexpect==4.9.0 on Linux
I don't think it needs to be `==`, but maybe pinning to
DavidSpickett wrote:
Example from MLIR:
https://github.com/llvm/llvm-project/blob/a58dd0e948040b75266b2ee02292a16ed7b2afd5/mlir/python/requirements.txt#L1-L3
https://github.com/llvm/llvm-project/pull/94220
___
lldb-commits mailing list
lldb-commits@li
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/94220
>From e5a6eca78496e6f5ac67613f1f8368cf24ea1521 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Mon, 3 Jun 2024 13:39:16 +
Subject: [PATCH 1/2] [lldb] Add Python requirements.txt for test suite
This
DavidSpickett wrote:
There is an option `args.lldb_platform_url` for `dotest.py`, maybe it's that?
https://github.com/llvm/llvm-project/pull/94127
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo
Endilll wrote:
> I've not been able to find what versioning scheme these 2 packages use, so
> I'm not sure what versions to put here if any.
>
> Currently Linaro has: psutil==5.9.4 on Windows psutil == 5.9.8 on Linux
> pexpect==4.9.0 on Linux
>
> I don't think it needs to be `==`, but maybe p
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/94220
>From e5a6eca78496e6f5ac67613f1f8368cf24ea1521 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Mon, 3 Jun 2024 13:39:16 +
Subject: [PATCH 1/3] [lldb] Add Python requirements.txt for test suite
This
DavidSpickett wrote:
Added minimum versions.
https://github.com/llvm/llvm-project/pull/94220
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Endilll approved this pull request.
https://github.com/llvm/llvm-project/pull/94220
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
Anecdotal evidence - last time I updated these I just installed the most recent
and nothing broke. So we're probably fine with minimums, especially as this
will be checked regularly by the CI job.
https://github.com/llvm/llvm-project/pull/94220
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/94220
>From e5a6eca78496e6f5ac67613f1f8368cf24ea1521 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Mon, 3 Jun 2024 13:39:16 +
Subject: [PATCH 1/4] [lldb] Add Python requirements.txt for test suite
This
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/94220
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
I was wrong, you can do conditionals - https://peps.python.org/pep-0508/.
pexpect now not installed on Windows.
https://github.com/llvm/llvm-project/pull/94220
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://list
Michael137 wrote:
Note I'm also seeing some flakiness on the public macOS buildbots:
https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/lldb-cmake-matrix/322/execution/node/69/log/
https://github.com/llvm/llvm-project/pull/74894
___
lldb-commits ma
kastiglione wrote:
@DavidSpickett thanks, is there a link to a log? I'm curious.
https://github.com/llvm/llvm-project/pull/93881
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
Fix is https://github.com/llvm/llvm-project/pull/94196.
There isn't anything to log really, the function just didn't have a symbol on
Windows.
https://github.com/llvm/llvm-project/pull/93881
___
lldb-commits mailing list
lldb-com
https://github.com/dzhidzhoev updated
https://github.com/llvm/llvm-project/pull/93883
>From 6b7b05b55926f1fecae34312a89c4271def7aa3a Mon Sep 17 00:00:00 2001
From: Vladislav Dzhidzhoev
Date: Sat, 13 Apr 2024 23:55:25 +
Subject: [PATCH] [lldb][test] Add --make argument to dotest.py (#93883)
Author: Vladislav Dzhidzhoev
Date: 2024-06-03T17:30:10+02:00
New Revision: 6b7b05b55926f1fecae34312a89c4271def7aa3a
URL:
https://github.com/llvm/llvm-project/commit/6b7b05b55926f1fecae34312a89c4271def7aa3a
DIFF:
https://github.com/llvm/llvm-project/commit/6b7b05b55926f1fecae34312a89c4271def7aa3
https://github.com/dzhidzhoev closed
https://github.com/llvm/llvm-project/pull/93883
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/slydiman converted_to_draft
https://github.com/llvm/llvm-project/pull/94165
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
dzhidzhoev wrote:
> > * LLDB_PLATFORM_URL
>
> Is that an environment variable or a cmake variable? I don't see a single
> instance of that string in the entire lldb source tree. Are you sure that's
> not some downstream feature?
> > * LLDB_PLATFORM_URL
>
> Is that an environment variable o
https://github.com/slydiman converted_to_draft
https://github.com/llvm/llvm-project/pull/94127
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Michael Buch
Date: 2024-06-03T17:04:16+01:00
New Revision: aad7874000faed77836e2bbd5c72af8776636f89
URL:
https://github.com/llvm/llvm-project/commit/aad7874000faed77836e2bbd5c72af8776636f89
DIFF:
https://github.com/llvm/llvm-project/commit/aad7874000faed77836e2bbd5c72af8776636f89.diff
https://github.com/jimingham approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/94192
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/94220
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben approved this pull request.
https://github.com/llvm/llvm-project/pull/94220
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben created
https://github.com/llvm/llvm-project/pull/94259
This patch changes the crashlog image loading default behaviour to not only
load images from the crashed thread but also for the application specific
backtrace thread.
This patch also move the Application
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Med Ismail Bennani (medismailben)
Changes
This patch changes the crashlog image loading default behaviour to not only
load images from the crashed thread but also for the application specific
backtrace thread.
This patch also move the App
https://github.com/medismailben created
https://github.com/llvm/llvm-project/pull/94262
By default, the crashlog script only loads images for the crashed thread as
well as the application specific thread.
Prior to using SymbolFileJSON and ObjectFileJSON, it didn't make sense to
create stackfr
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Med Ismail Bennani (medismailben)
Changes
By default, the crashlog script only loads images for the crashed thread as
well as the application specific thread.
Prior to using SymbolFileJSON and ObjectFileJSON, it didn't make sense to
creat
Author: David Spickett
Date: 2024-06-03T18:25:05+01:00
New Revision: 0232e2b15b8d3b2653f069a5683ccd29a5d29caf
URL:
https://github.com/llvm/llvm-project/commit/0232e2b15b8d3b2653f069a5683ccd29a5d29caf
DIFF:
https://github.com/llvm/llvm-project/commit/0232e2b15b8d3b2653f069a5683ccd29a5d29caf.diff
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/94220
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/clayborg commented:
My main question is how did you determine the clang-14 being the right version
to check against here? Which clang-14 or clang-15 did you use? The public
release branches from upstream?
https://github.com/llvm/llvm-project/pull/93710
__
https://github.com/medismailben updated
https://github.com/llvm/llvm-project/pull/94262
>From ec250e197e73b5743566db884152bea9c17dd4b9 Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Date: Mon, 3 Jun 2024 10:28:43 -0700
Subject: [PATCH] [lldb/crashlog] Create stackframes for non-crashed threa
https://github.com/medismailben edited
https://github.com/llvm/llvm-project/pull/94262
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/94067
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/94067
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/94067
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/94026
>From 72844ebd5cf8f74f6db5d1c52d1f557ca942dbee Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Fri, 31 May 2024 12:21:28 -0700
Subject: [PATCH 1/2] [lldb] Support reading DW_OP_piece from file address
@@ -768,3 +768,63 @@ TEST(DWARFExpression, ExtensionsDWO) {
testExpressionVendorExtensions(dwo_module_sp, *dwo_dwarf_unit);
}
+
+TEST_F(DWARFExpressionMockProcessTest, DW_OP_piece_file_addr) {
+ struct MockTarget : Target {
JDevlieghere wrote:
Very cool, t
Michael137 wrote:
Sorry for the late ping, but the LLDB matrix bot failure has gone unnoticed for
a bit. This patch caused following test to fail for DWARFv5:
```
FAIL: test_inline_static_members_dsym (TestConstStaticIntegralMember.TestCase)
--
Michael137 wrote:
What platform was this failing on for you? We have a matrix bot for macOS that
runs these tests on older Clang versions.
https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/lldb-cmake-matrix/
I probably wrote these checks when clang was on 16.0 to fix the matrix bot
(which
@@ -768,3 +768,63 @@ TEST(DWARFExpression, ExtensionsDWO) {
testExpressionVendorExtensions(dwo_module_sp, *dwo_dwarf_unit);
}
+
+TEST_F(DWARFExpressionMockProcessTest, DW_OP_piece_file_addr) {
+ struct MockTarget : Target {
labath wrote:
The code I linked
feg208 wrote:
@clayborg This pr is ready for re-review
https://github.com/llvm/llvm-project/pull/91544
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/94026
>From 72844ebd5cf8f74f6db5d1c52d1f557ca942dbee Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Fri, 31 May 2024 12:21:28 -0700
Subject: [PATCH 1/3] [lldb] Support reading DW_OP_piece from file address
https://github.com/clayborg approved this pull request.
https://github.com/llvm/llvm-project/pull/94067
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: royitaqi
Date: 2024-06-03T13:52:03-07:00
New Revision: c2d061da7e17e61d4a0efad261e5280793c1b7ce
URL:
https://github.com/llvm/llvm-project/commit/c2d061da7e17e61d4a0efad261e5280793c1b7ce
DIFF:
https://github.com/llvm/llvm-project/commit/c2d061da7e17e61d4a0efad261e5280793c1b7ce.diff
LOG:
https://github.com/clayborg closed
https://github.com/llvm/llvm-project/pull/94067
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
cjappl wrote:
Hi @Endilll
I did a git bisect that pointed to this change as the one blocking my
compilation on an Ubuntu docker image with clang 14.0
The error I see:
```
CMake Error at
/test_radsan/llvm-project/compiler-rt/cmake/Modules/CheckSectionExists.cmake:72
(message):
cc: error:
https://github.com/JDevlieghere approved this pull request.
LGTM but can we test this?
https://github.com/llvm/llvm-project/pull/94262
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commit
@@ -39,7 +39,7 @@ def check_simulator_ostype(self, sdk, platform_name,
arch=platform.machine()):
for device in devices:
if "availability" in device and device["availability"] !=
"(available)":
continue
-if "isAva
1 - 100 of 115 matches
Mail list logo
