Author: Pavel Labath
Date: 2024-05-30T07:16:22Z
New Revision: c7acca1cb06f3850590363fb729a3c03a43170dd
URL:
https://github.com/llvm/llvm-project/commit/c7acca1cb06f3850590363fb729a3c03a43170dd
DIFF:
https://github.com/llvm/llvm-project/commit/c7acca1cb06f3850590363fb729a3c03a43170dd.diff
LOG:
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/93712
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/93712
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1,6 +1,6 @@
# System modules
from functools import wraps
-from pkg_resources import packaging
+from packaging.version import parse
labath wrote:
```suggestion
from packaging import version
```
`parse` sounds too generic to be imported by base name alone
h
Author: Pavel Labath
Date: 2024-05-30T09:54:13+02:00
New Revision: f38ebec7106fd541046d502be0f79a4dda1a89b0
URL:
https://github.com/llvm/llvm-project/commit/f38ebec7106fd541046d502be0f79a4dda1a89b0
DIFF:
https://github.com/llvm/llvm-project/commit/f38ebec7106fd541046d502be0f79a4dda1a89b0.diff
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/93534
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Pavel Labath
Date: 2024-05-30T09:57:13+02:00
New Revision: d554f2379b427505907ba52b8b9270c0b436224f
URL:
https://github.com/llvm/llvm-project/commit/d554f2379b427505907ba52b8b9270c0b436224f
DIFF:
https://github.com/llvm/llvm-project/commit/d554f2379b427505907ba52b8b9270c0b436224f.diff
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/93458
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Pavel Labath
Date: 2024-05-30T09:57:51+02:00
New Revision: 540a36ad7e31bfeb11e795047a42bb6e30bf9985
URL:
https://github.com/llvm/llvm-project/commit/540a36ad7e31bfeb11e795047a42bb6e30bf9985
DIFF:
https://github.com/llvm/llvm-project/commit/540a36ad7e31bfeb11e795047a42bb6e30bf9985.diff
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/93675
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Endilll wrote:
I think the issue is that we no longer passed `-fno-lifetime-dse` to GCC due to
incorrect condition (my fault), which caused some downstream LTO crashes as
reported by @mveriksson in
https://github.com/llvm/llvm-project/commit/4feae05c6abda364a9295aecfa600d7d4e7dfeb6#r142466703
https://github.com/Michael137 approved this pull request.
Seems like a reasonable thing to do (as this comment in [LoadAddressResolver
::Resolve](https://github.com/llvm/llvm-project/blob/fd8b2d2046508c027ccf0fffb50d665c8355997a/lldb/source/Expression/IRExecutionUnit.cpp#L758-L761)
implies).
M
https://github.com/dzhidzhoev created
https://github.com/llvm/llvm-project/pull/93800
This commit adds dotest.py flags that come in handy for setting up
cross-platform remote runs of API tests.
`--make` argument allows to specify the path to the make executable used by
LLDB API tests to compi
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Vladislav Dzhidzhoev (dzhidzhoev)
Changes
This commit adds dotest.py flags that come in handy for setting up
cross-platform remote runs of API tests.
`--make` argument allows to specify the path to the make executable used by
LLDB API tes
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
70e189fbc96909d3841dd2bca4a2909345cd826f...771344c1003b5172ff4912b5263bc2a1d3678366
lldb/
https://github.com/santhoshe447 updated
https://github.com/llvm/llvm-project/pull/91570
>From 960351c9abf51f42d92604ac6297aa5b76ddfba5 Mon Sep 17 00:00:00 2001
From: Santhosh Kumar Ellendula
Date: Fri, 17 Nov 2023 15:09:10 +0530
Subject: [PATCH 01/10] [lldb][test] Add the ability to extract the
https://github.com/dzhidzhoev updated
https://github.com/llvm/llvm-project/pull/93800
>From b6c6238caaf9b355be53c157b25c0db32f920ab9 Mon Sep 17 00:00:00 2001
From: Vladislav Dzhidzhoev
Date: Wed, 17 Apr 2024 05:17:07 +
Subject: [PATCH] [lldb][test] Add flags useful for remote cross-platform
https://github.com/santhoshe447 updated
https://github.com/llvm/llvm-project/pull/91570
>From 960351c9abf51f42d92604ac6297aa5b76ddfba5 Mon Sep 17 00:00:00 2001
From: Santhosh Kumar Ellendula
Date: Fri, 17 Nov 2023 15:09:10 +0530
Subject: [PATCH 01/10] [lldb][test] Add the ability to extract the
Michael137 wrote:
Huh this is an interesting one. So it looks like we first parse and insert
`struct Inner` into `UniqueDWARFASTTypeMap` as a forward declaration. Then when
we search the debug-map for the definition of `Inner`, we find it declared as
`class Inner` (note, *class* vs. *struct*..
https://github.com/santhoshe447 updated
https://github.com/llvm/llvm-project/pull/91570
>From 960351c9abf51f42d92604ac6297aa5b76ddfba5 Mon Sep 17 00:00:00 2001
From: Santhosh Kumar Ellendula
Date: Fri, 17 Nov 2023 15:09:10 +0530
Subject: [PATCH 01/11] [lldb][test] Add the ability to extract the
https://github.com/dzhidzhoev created
https://github.com/llvm/llvm-project/pull/93808
When PIE is enabled on a platform by default, these tests fail since the
`target variable` command can't read a global string variable value before
running an inferior process.
>From d305048e67dd48012f5c689f
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Vladislav Dzhidzhoev (dzhidzhoev)
Changes
When PIE is enabled on a platform by default, these tests fail since the
`target variable` command can't read a global string variable value before
running an inferior process.
---
Full diff: http
Michael137 wrote:
@clayborg this change went in as part of
https://github.com/llvm/llvm-project/pull/92328 so i think we can close this
now.
Though there's a test failure linked to that PR currently, meaning it might
have to get reverted. We should keep an eye out for that
https://github.co
Michael137 wrote:
I'll revert this for now. Let me know if you need help reproducing the failure
https://github.com/llvm/llvm-project/pull/92014
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/l
Author: Michael Buch
Date: 2024-05-30T12:40:05+01:00
New Revision: 8b600a37325bd68c370b00838c9f0a0fda1af6ce
URL:
https://github.com/llvm/llvm-project/commit/8b600a37325bd68c370b00838c9f0a0fda1af6ce
DIFF:
https://github.com/llvm/llvm-project/commit/8b600a37325bd68c370b00838c9f0a0fda1af6ce.diff
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/93809
This is the outcome of the discussions we had in
https://discourse.llvm.org/t/rfc-lldb-handling-no-unique-address-in-lldb/77483
To summarize, LLDB creates AST nodes by parsing debug-info and hands those off
t
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
This is the outcome of the discussions we had in
https://discourse.llvm.org/t/rfc-lldb-handling-no-unique-address-in-lldb/77483
To summarize, LLDB creates AST nodes by parsing debug-info and hands those off
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
Author: Michael Buch (Michael137)
Changes
This is the outcome of the discussions we had in
https://discourse.llvm.org/t/rfc-lldb-handling-no-unique-address-in-lldb/77483
To summarize, LLDB creates AST nodes by parsing debug-info and hands
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/93809
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 971f1aaad3ca3680bfbab76212f498ca15b280a2
91276f5b2dc05032a285b465c0c8a69541bb25c4 --
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
971f1aaad3ca3680bfbab76212f498ca15b280a2...91276f5b2dc05032a285b465c0c8a69541bb25c4
lldb/
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/93809
>From 91276f5b2dc05032a285b465c0c8a69541bb25c4 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Thu, 2 May 2024 09:05:01 +0100
Subject: [PATCH 1/2] [clang][lldb] Don't assert structure layout correctness
for
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/93809
>From 91276f5b2dc05032a285b465c0c8a69541bb25c4 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Thu, 2 May 2024 09:05:01 +0100
Subject: [PATCH 1/3] [clang][lldb] Don't assert structure layout correctness
for
Michael137 wrote:
Looks like this is breaking the macOS CI:
https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/lldb-cmake/2534/execution/node/97/log
```
==
FAIL: test_shlib_name (TestCompletion.CommandLineCompletionTestCase)
https://github.com/santhoshe447 updated
https://github.com/llvm/llvm-project/pull/91570
>From 960351c9abf51f42d92604ac6297aa5b76ddfba5 Mon Sep 17 00:00:00 2001
From: Santhosh Kumar Ellendula
Date: Fri, 17 Nov 2023 15:09:10 +0530
Subject: [PATCH 01/12] [lldb][test] Add the ability to extract the
@@ -348,6 +348,17 @@
"type": "string",
"description": "The time in seconds to wait for a program to
stop when attaching using \"attachCommands\". Defaults to 30 seconds."
},
+ "port": {
+"type": [
+
@@ -0,0 +1,142 @@
+"""
+Test lldb-dap "port" configuration to "attach" request
+"""
+
+
+import dap_server
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+from lldbsuite.test import lldbplatformutil
+import lldb
@@ -749,9 +752,30 @@ void request_attach(const llvm::json::Object &request) {
// Disable async events so the attach will be successful when we return
from
// the launch call and the launch will happen synchronously
g_dap.debugger.SetAsync(false);
-if (core_file
@@ -749,9 +752,30 @@ void request_attach(const llvm::json::Object &request) {
// Disable async events so the attach will be successful when we return
from
// the launch call and the launch will happen synchronously
g_dap.debugger.SetAsync(false);
-if (core_file
@@ -0,0 +1,142 @@
+"""
+Test lldb-dap "port" configuration to "attach" request
+"""
+
+
+import dap_server
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test import lldbutil
+from lldbsuite.test import lldbplatformutil
+import lldb
@@ -519,9 +519,9 @@ def _find_windows_sdk_in_registry_view(self, view):
# Windows SDK version numbers consist of 4 dotted components, so we
# have to use LooseVersion, as StrictVersion supports 3 or fewer.
DavidSpickett wrote:
Does thi
DavidSpickett wrote:
`packaging` is already installed on Linaro's bots, so we're ok with this.
https://github.com/llvm/llvm-project/pull/93712
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lld
https://github.com/slydiman created
https://github.com/llvm/llvm-project/pull/93825
The TestGdbRemoteLibrariesSvr4Support test failed in case of Linux x86_64 host
and Linux Aarch64 target. Installing libraries to the remote target is not
enough. This test actively uses self.getBuildDir() and o
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dmitry Vasilyev (slydiman)
Changes
The TestGdbRemoteLibrariesSvr4Support test failed in case of Linux x86_64 host
and Linux Aarch64 target. Installing libraries to the remote target is not
enough. This test actively uses self.getBuildDir()
https://github.com/slydiman created
https://github.com/llvm/llvm-project/pull/93829
Recently we have disabled this test for Windows host and Linux target. Now we
faced the same issue #92419 in case of Linux x86_64 host and Linux Aarch64
target.
>From f932af998824b633e91460c6b03d66014ecca799 M
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dmitry Vasilyev (slydiman)
Changes
Recently we have disabled this test for Windows host and Linux target. Now we
faced the same issue #92419 in case of Linux x86_64 host and Linux
Aarch64 target.
---
Full diff: https://github.com/llvm/llv
https://github.com/slydiman created
https://github.com/llvm/llvm-project/pull/93832
Skip checking of few stat fields like st_dev (ID of device containing file) in
case of a remote target.
>From 31ad2c39b2c5ff31ac1a0109cf91a7e59e66ca26 Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Thu,
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dmitry Vasilyev (slydiman)
Changes
Skip checking of few stat fields like st_dev (ID of device containing file) in
case of a remote target.
---
Full diff: https://github.com/llvm/llvm-project/pull/93832.diff
1 Files Affected:
- (modified
https://github.com/dzhidzhoev created
https://github.com/llvm/llvm-project/pull/93833
1. Use dashes (-) instead of colons (:) as a time separator in a session log
file name since Windows doesn't support saving files with names containing
colons.
2. Temporary file creation code is changed in t
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Vladislav Dzhidzhoev (dzhidzhoev)
Changes
1. Use dashes (-) instead of colons (:) as a time separator in a session log
file name since Windows doesn't support saving files with names containing
colons.
2. Temporary file creation code is c
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
22c572eae0f3a73b9154718a3f46c08531e52e91...a11876da55230bd9c5df7cddc3726cef5f5836a1
lldb/
https://github.com/dzhidzhoev updated
https://github.com/llvm/llvm-project/pull/93833
>From 1681c41f4486047239d28d694cb29448b60b12b0 Mon Sep 17 00:00:00 2001
From: Vladislav Dzhidzhoev
Date: Fri, 10 May 2024 22:59:31 +
Subject: [PATCH] [lldb] Fix 'session save' command on Windows
1. Use da
labath wrote:
> Mind taking a look @labath ?
I think I know how to fix this, just a sec.
https://github.com/llvm/llvm-project/pull/93458
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-c
https://github.com/mbucko created
https://github.com/llvm/llvm-project/pull/93836
Summary:
This adds new SB API calls and classes to allow a user of the SB API to obtain
an address range from SBFunction and SBBlock. This is a second attempt to land
the reverted PR #92014.
Test Plan:
llvm-lit
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Miro Bucko (mbucko)
Changes
Summary:
This adds new SB API calls and classes to allow a user of the SB API to obtain
an address range from SBFunction and SBBlock. This is a second attempt to land
the reverted PR #92014.
Test Plan:
llvm-lit
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/93825
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 approved this pull request.
Can confirm that tests pass on my mac now
https://github.com/llvm/llvm-project/pull/93836
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinf
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/93829
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Pavel Labath
Date: 2024-05-30T15:28:13Z
New Revision: a2bcb932f3130c3c18ceb06872da9002f6845c4b
URL:
https://github.com/llvm/llvm-project/commit/a2bcb932f3130c3c18ceb06872da9002f6845c4b
DIFF:
https://github.com/llvm/llvm-project/commit/a2bcb932f3130c3c18ceb06872da9002f6845c4b.diff
LOG:
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/93832
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Dmitry Vasilyev
Date: 2024-05-30T19:56:04+04:00
New Revision: facb767e5b78a024d70585b24254c769473b6b54
URL:
https://github.com/llvm/llvm-project/commit/facb767e5b78a024d70585b24254c769473b6b54
DIFF:
https://github.com/llvm/llvm-project/commit/facb767e5b78a024d70585b24254c769473b6b54.dif
https://github.com/slydiman closed
https://github.com/llvm/llvm-project/pull/93825
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Dmitry Vasilyev
Date: 2024-05-30T19:56:46+04:00
New Revision: 59e2a6b08f3e40afea87da3838ba69e1e15b6672
URL:
https://github.com/llvm/llvm-project/commit/59e2a6b08f3e40afea87da3838ba69e1e15b6672
DIFF:
https://github.com/llvm/llvm-project/commit/59e2a6b08f3e40afea87da3838ba69e1e15b6672.dif
https://github.com/slydiman closed
https://github.com/llvm/llvm-project/pull/93829
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ZequanWu created
https://github.com/llvm/llvm-project/pull/93839
This fixes
https://github.com/llvm/llvm-project/pull/92328#issuecomment-2139339444.
This contains two fixes:
1. Do not differentiate `DW_TAG_class_type` and `DW_TAG_structure_type` in
`UniqueDWARFASTTypeList`,
Author: Dmitry Vasilyev
Date: 2024-05-30T19:57:16+04:00
New Revision: b62ba7f5b1caf99a3cbbe06d0e1c788c2dc85416
URL:
https://github.com/llvm/llvm-project/commit/b62ba7f5b1caf99a3cbbe06d0e1c788c2dc85416
DIFF:
https://github.com/llvm/llvm-project/commit/b62ba7f5b1caf99a3cbbe06d0e1c788c2dc85416.dif
https://github.com/slydiman closed
https://github.com/llvm/llvm-project/pull/93832
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Zequan Wu (ZequanWu)
Changes
This fixes
https://github.com/llvm/llvm-project/pull/92328#issuecomment-2139339444.
This contains two fixes:
1. Do not differentiate `DW_TAG_class_type` and `DW_TAG_structure_type` in
`UniqueDWARFASTTypeList`,
ZequanWu wrote:
For this specific case, we could fix it by making `DW_TAG_structure_type`
equals to `DW_TAG_class_type` in the `UniqueDWARFASTTypeList::Find`.
There's few things I noticed with this:
1. If `DW_TAG_structure_type` and `DW_TAG_class_type` are interchangeable, then
this compariso
@@ -61,8 +61,14 @@ def test_session_save(self):
self.assertFalse(res.Succeeded())
raw += self.raw_transcript_builder(cmd, res)
-tf = tempfile.NamedTemporaryFile()
-output_file = tf.name
+fd, output_file = tempfile.mkstemp()
-
@@ -13,12 +13,18 @@
using namespace lldb_private::dwarf;
using namespace lldb_private::plugin::dwarf;
+static bool IsStructOrClassTag(llvm::dwarf::Tag Tag) {
Michael137 wrote:
I think we have this function somewhere already. Might be worth checking
(possibly
@@ -13,12 +13,18 @@
using namespace lldb_private::dwarf;
using namespace lldb_private::plugin::dwarf;
+static bool IsStructOrClassTag(llvm::dwarf::Tag Tag) {
Michael137 wrote:
Ah yes in `SymbolFileDWARF::FindDefinitionTypeForDWARFDeclContext` we have the
sam
@@ -13,12 +13,18 @@
using namespace lldb_private::dwarf;
using namespace lldb_private::plugin::dwarf;
+static bool IsStructOrClassTag(llvm::dwarf::Tag Tag) {
ZequanWu wrote:
It's here:
https://github.com/llvm/llvm-project/blob/ed35a92c404650b15a79ff38bcaff41
@@ -2232,6 +2232,11 @@ bool DWARFASTParserClang::CompleteRecordType(const
DWARFDIE &die,
// For objective C we don't start the definition when the class is
// created.
TypeSystemClang::StartTagDeclarationDefinition(clang_type);
+} else if (!clang_type.IsB
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/93839
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -2232,6 +2232,11 @@ bool DWARFASTParserClang::CompleteRecordType(const
DWARFDIE &die,
// For objective C we don't start the definition when the class is
// created.
TypeSystemClang::StartTagDeclarationDefinition(clang_type);
+} else if (!clang_type.IsB
@@ -2232,6 +2232,11 @@ bool DWARFASTParserClang::CompleteRecordType(const
DWARFDIE &die,
// For objective C we don't start the definition when the class is
// created.
TypeSystemClang::StartTagDeclarationDefinition(clang_type);
+} else if (!clang_type.IsB
@@ -13,12 +13,18 @@
using namespace lldb_private::dwarf;
using namespace lldb_private::plugin::dwarf;
+static bool IsStructOrClassTag(llvm::dwarf::Tag Tag) {
Michael137 wrote:
Are there more tag equality checks around LLDB that could benefit from re-using
th
@@ -2232,6 +2232,11 @@ bool DWARFASTParserClang::CompleteRecordType(const
DWARFDIE &die,
// For objective C we don't start the definition when the class is
// created.
TypeSystemClang::StartTagDeclarationDefinition(clang_type);
+} else if (!clang_type.IsB
https://github.com/ZequanWu updated
https://github.com/llvm/llvm-project/pull/93839
>From 90cbcf8a97fb2e7c5131ac2cb601b95fe7a331c6 Mon Sep 17 00:00:00 2001
From: Zequan Wu
Date: Thu, 30 May 2024 11:36:10 -0400
Subject: [PATCH 1/2] [lldb][DWARF] Do not differentiate DW_TAG_class_type and
DW_TAG
@@ -13,12 +13,18 @@
using namespace lldb_private::dwarf;
using namespace lldb_private::plugin::dwarf;
+static bool IsStructOrClassTag(llvm::dwarf::Tag Tag) {
ZequanWu wrote:
Yeah, we can probably do it in a different change.
https://github.com/llvm/llvm-proj
@@ -2232,6 +2232,10 @@ bool DWARFASTParserClang::CompleteRecordType(const
DWARFDIE &die,
// For objective C we don't start the definition when the class is
// created.
TypeSystemClang::StartTagDeclarationDefinition(clang_type);
+} else {
+ assert(
+
https://github.com/ZequanWu updated
https://github.com/llvm/llvm-project/pull/93839
>From 90cbcf8a97fb2e7c5131ac2cb601b95fe7a331c6 Mon Sep 17 00:00:00 2001
From: Zequan Wu
Date: Thu, 30 May 2024 11:36:10 -0400
Subject: [PATCH 1/3] [lldb][DWARF] Do not differentiate DW_TAG_class_type and
DW_TAG
dwblaikie wrote:
Could probably adjust the assertions to be `assert (debug || whatever)` rather
than `if (!debug) assert(whatever)`.
My understanding/expectation was that these assertions would be removed
entirely - that whatever generated the AST should just be trusted, whether it's
the debu
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 16a5fd3fdb91ffb39b97dbd3a7e9346ba406360d
e7fc16ec5f31693191188b3b95728c4320465923 --
@@ -13,12 +13,18 @@
using namespace lldb_private::dwarf;
using namespace lldb_private::plugin::dwarf;
+static bool IsStructOrClassTag(llvm::dwarf::Tag Tag) {
Michael137 wrote:
There's also
```
/// Returns true if `tag` is a class_type of structure_type tag.
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/93839
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -13,12 +13,18 @@
using namespace lldb_private::dwarf;
using namespace lldb_private::plugin::dwarf;
+static bool IsStructOrClassTag(llvm::dwarf::Tag Tag) {
felipepiovezan wrote:
Yeah, we definitely need to clean all of these up.
There might be one inside ll
https://github.com/Michael137 approved this pull request.
Lets do the cleanup of `IsClassOrStruct` as a follow-up since there seem quite
a few places that could benefit from it
https://github.com/llvm/llvm-project/pull/93839
___
lldb-commits mailing l
@@ -519,9 +519,9 @@ def _find_windows_sdk_in_registry_view(self, view):
# Windows SDK version numbers consist of 4 dotted components, so we
# have to use LooseVersion, as StrictVersion supports 3 or fewer.
JDevlieghere wrote:
No, it do
labath wrote:
What do the failures look like? I tried to force -pie on some of the tests that
you modified, and I couldn't get them to fail. Is this somehow specific to
remote execution?
https://github.com/llvm/llvm-project/pull/93808
___
lldb-commit
efriedma-quic wrote:
I'm skeptical it's correct to skip all the assertions like this; the assertions
are there to ensure the layout of the LLVM IR type matches the layout provided
by the RecordLayout. If the LLVM IR layout is wrong, address-related
computations will be wrong, and ultimately y
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/93712
>From 4666a6a6470fc91ed17a9e60624a005dc97c4531 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Wed, 29 May 2024 10:36:47 -0700
Subject: [PATCH 1/2] [lldb] Use packaging module instead of pkg_resources
https://github.com/ZequanWu updated
https://github.com/llvm/llvm-project/pull/93839
>From 90cbcf8a97fb2e7c5131ac2cb601b95fe7a331c6 Mon Sep 17 00:00:00 2001
From: Zequan Wu
Date: Thu, 30 May 2024 11:36:10 -0400
Subject: [PATCH 1/4] [lldb][DWARF] Do not differentiate DW_TAG_class_type and
DW_TAG
https://github.com/ZequanWu edited
https://github.com/llvm/llvm-project/pull/93839
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ayermolo wrote:
Still would be nice to have a small repro to make sure clang, and BOLT, now
does the right thing.
https://github.com/llvm/llvm-project/pull/91808
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/
Author: Zequan Wu
Date: 2024-05-30T13:05:29-04:00
New Revision: 3d9d48523977af3590f7dd0edfd258454cb9e9cf
URL:
https://github.com/llvm/llvm-project/commit/3d9d48523977af3590f7dd0edfd258454cb9e9cf
DIFF:
https://github.com/llvm/llvm-project/commit/3d9d48523977af3590f7dd0edfd258454cb9e9cf.diff
LOG
https://github.com/ZequanWu closed
https://github.com/llvm/llvm-project/pull/93839
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
dwblaikie wrote:
One easy question would be: do you/your users use -fdebug-types-section? If so,
that'd probably explain what you were seeing & you could add some test coverage
for that wherever you like (in lldb, presumably, maybe in bolt too). But if
you/they don't, then it's unclear where t
rjmccall wrote:
I agree with Eli. We should trust external record layout to the extent that it
generates a valid layout, but if it generates something with overlapping
fields, or that runs outside the claimed bounds of the type, we'll just end up
crashing in IRGen. I assume those things are
1 - 100 of 152 matches
Mail list logo
