[Lldb-commits] [lldb] [lldb] Fix module name tab completion (PR #93458)

2024-05-27 Thread Pavel Labath via lldb-commits
https://github.com/labath created https://github.com/llvm/llvm-project/pull/93458 Module names can be matched either by a full path or just their basename. The completion machinery tried to do both, but had several bugs: - it always inserted the basename as a completion candidate, even if the s

[Lldb-commits] [lldb] [lldb] Fix module name tab completion (PR #93458)

2024-05-27 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes Module names can be matched either by a full path or just their basename. The completion machinery tried to do both, but had several bugs: - it always inserted the basename as a completion candidate, even if th

[Lldb-commits] [lldb] [lldb] Fix module name tab completion (PR #93458)

2024-05-27 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 80b78f5fb30c43cd88f0d096081bc7f1509b0110...aca5ab852854a46ba5443864c555d5479956d05d lldb/

[Lldb-commits] [lldb] [lldb][riscv] Fix setting breakpoint for undecoded instruction (PR #90075)

2024-05-27 Thread via lldb-commits
@@ -115,8 +148,23 @@ Status NativeProcessSoftwareSingleStep::SetupSoftwareSingleStepping( emulator_up->SetWriteMemCallback(&WriteMemoryCallback); emulator_up->SetWriteRegCallback(&WriteRegisterCallback); - if (!emulator_up->ReadInstruction()) -return Status("Read ins

[Lldb-commits] [lldb] [lldb][riscv] Fix setting breakpoint for undecoded instruction (PR #90075)

2024-05-27 Thread via lldb-commits
https://github.com/ita-sc updated https://github.com/llvm/llvm-project/pull/90075 >From a95314eb8afd5f697a7a138d4e1e1465611c8533 Mon Sep 17 00:00:00 2001 From: Ivan Tetyushkin Date: Fri, 19 Apr 2024 18:47:05 +0300 Subject: [PATCH 1/2] [lldb][riscv] Fix setting breakpoint for undecoded instruct

[Lldb-commits] [lldb] [lldb][riscv] Fix setting breakpoint for undecoded instruction (PR #90075)

2024-05-27 Thread via lldb-commits
@@ -115,8 +148,23 @@ Status NativeProcessSoftwareSingleStep::SetupSoftwareSingleStepping( emulator_up->SetWriteMemCallback(&WriteMemoryCallback); emulator_up->SetWriteRegCallback(&WriteRegisterCallback); - if (!emulator_up->ReadInstruction()) -return Status("Read ins

[Lldb-commits] [lldb] [lldb][riscv] Fix setting breakpoint for undecoded instruction (PR #90075)

2024-05-27 Thread via lldb-commits
@@ -115,8 +148,23 @@ Status NativeProcessSoftwareSingleStep::SetupSoftwareSingleStepping( emulator_up->SetWriteMemCallback(&WriteMemoryCallback); emulator_up->SetWriteRegCallback(&WriteRegisterCallback); - if (!emulator_up->ReadInstruction()) -return Status("Read ins

[Lldb-commits] [lldb] [lldb][riscv] Fix setting breakpoint for undecoded instruction (PR #90075)

2024-05-27 Thread via lldb-commits
@@ -99,6 +100,8 @@ class EmulateInstructionRISCV : public EmulateInstruction { private: /// Last decoded instruction from m_opcode DecodeResult m_decoded; + /// Last tried to be decoded instruction expected size. ita-sc wrote: Well, I tried to emphasize t

[Lldb-commits] [lldb] [lldb][riscv] Fix setting breakpoint for undecoded instruction (PR #90075)

2024-05-27 Thread via lldb-commits
ita-sc wrote: > I read this patch while trying to keep the RVC instruction set in mind > because it's an interesting case to consider. Maybe the test file could have > a compressed instruction? The one instruction there now ends in 0b11 so I > don't think it will decode that way. The test int

[Lldb-commits] [clang] [compiler-rt] [lldb] [llvm] [Support] Remove terminfo dependency (PR #92865)

2024-05-27 Thread Aaron Siddhartha Mondal via lldb-commits
aaronmondal wrote: @gulfemsavrun The file `terminal.c` that is causing this linker error is not in LLVM but in `libedit`. The configure step doesn't find `libedit`: ``` Not searching for unused variables given on the command line. -- Could NOT find LibEdit (missing: LibEdit_INCLUDE_DIRS LibEdit

[Lldb-commits] [clang] [compiler-rt] [lldb] [llvm] [Support] Remove terminfo dependency (PR #92865)

2024-05-27 Thread via lldb-commits
gulfemsavrun wrote: Ok, thanks for your analysis @aaronmondal! https://github.com/llvm/llvm-project/pull/92865 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] Add a createError variant without error code (NFC) (PR #93209)

2024-05-27 Thread Lang Hames via lldb-commits
lhames wrote: Late to the party here, but some context might be of interest: `inconvertibleErrorCode` was meant to never be used, except with a documented explanation of why no error code could be supplied. The idea was to make conversion between `Error` and `std::error_code` illegal when no e