https://github.com/cor3ntin approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/67930
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -11,7 +11,7 @@
//
s-barannikov wrote:
I guess this file should've been removed.
https://github.com/llvm/llvm-project/pull/93388
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-
https://github.com/davidstone updated
https://github.com/llvm/llvm-project/pull/93388
>From f4b9852b0c11a9b5087c5fdb7794b5cab7f4d22c Mon Sep 17 00:00:00 2001
From: David Stone
Date: Sun, 26 May 2024 10:34:09 -0600
Subject: [PATCH 1/3] [clang][Modules] Remove unnecessary includes of
`Module.h`
https://github.com/davidstone edited
https://github.com/llvm/llvm-project/pull/93388
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
davidstone wrote:
> I don't like the PR since I don't feel it makes the code cleaner and it may
> make the downstream suffering backporting.
>
> If there are deeper reasons or following patches, we can discuss them
> seperately.
On its own, I would agree. My goal is to split several more thin
davidstone wrote:
To give a little more detail about my plans as of right now:
* Move `VisibleModuleSet` into its own file
* Move `ASTFileSignature` into its own file
* Take some of the related members of `Module`, group them together into their
own class, and move the resulting classes into th
ChuanqiXu9 wrote:
BTW, I tried to split `Module` class into `ModuleBase`, `ClangModule` and
`Cpp20Modules` (and HeaderUnits) classes to improve the readability. But it
showed too hard and too many things get changes then I stopped.
https://github.com/llvm/llvm-project/pull/93388
__
gulfemsavrun wrote:
We started seeing the following issue after this patch in our Clang toolchain
builders:
```
1448/1517](45) Linking CXX executable unittests/LineEditor/LineEditorTests
FAILED: unittests/LineEditor/LineEditorTests
: && /b/s/w/ir/x/w/cipd/bin/clang++ --sysroot=/b/s/w/ir/x/w/ci
https://github.com/labath approved this pull request.
> BTW, it would be great to be able to pass the style or triple to SBFileSpec.
> Currently it is impossible to create a posix SBFileSpec on the Windows host.
This is definitely not intentional. Feel free to create a PR to add it.
https://gi
@@ -678,8 +678,8 @@ uint32_t PlatformPOSIX::DoLoadImage(lldb_private::Process
*process,
loaded_image->Clear();
std::string path;
labath wrote:
```suggestion
std::string path = remote_file.GetPath(false);
```
Might as well fold the assignment into the
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/93345
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Dmitry Vasilyev
Date: 2024-05-27T10:52:16+04:00
New Revision: 1c046ca3f3254944483251bdc9c843e72d7f7796
URL:
https://github.com/llvm/llvm-project/commit/1c046ca3f3254944483251bdc9c843e72d7f7796
DIFF:
https://github.com/llvm/llvm-project/commit/1c046ca3f3254944483251bdc9c843e72d7f7796.dif
https://github.com/slydiman closed
https://github.com/llvm/llvm-project/pull/93345
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
13 matches
Mail list logo
