@@ -983,6 +1001,66 @@ llvm::Error
ProcessElfCore::ParseThreadContextsFromNoteSegment(
}
}
+bool ProcessElfCore::IsElf(lldb::addr_t address) {
+ uint8_t buf[4];
+ Status error;
+ size_t byte_read = ReadMemory(address, buf, 4, error);
+ if (byte_read != 4)
+return fal
@@ -271,6 +276,17 @@ Status ProcessElfCore::DoLoadCore() {
return error;
}
+void ProcessElfCore::UpdateBuildIdForNTFileEntries() {
+ if (!m_nt_file_entries.empty()) {
+for (NT_FILE_Entry &entry : m_nt_file_entries) {
+ std::optional uuid =
labath w
@@ -983,6 +1001,66 @@ llvm::Error
ProcessElfCore::ParseThreadContextsFromNoteSegment(
}
}
+bool ProcessElfCore::IsElf(lldb::addr_t address) {
+ uint8_t buf[4];
+ Status error;
+ size_t byte_read = ReadMemory(address, buf, 4, error);
+ if (byte_read != 4)
+return fal
@@ -271,6 +282,17 @@ Status ProcessElfCore::DoLoadCore() {
return error;
}
+void ProcessElfCore::UpdateBuildIdForNTFileEntries() {
+ if (!m_nt_file_entries.empty()) {
labath wrote:
Makes sense. I though something like this might be the case.
https://githu
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/92492
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath wrote:
> Using example above, with a fix by @dwblaikie
>
> I see:
>
> ```
> Hash: 0xE0CDC6A2
> String: 0x0018 "InnerState"
> Entry @ 0x10b {
> Abbrev: 0x3
> Tag: DW_TAG_class_type
> DW_IDX_type_unit: 0x01
> DW_IDX_die_offset: 0x0030
>
https://github.com/medismailben created
https://github.com/llvm/llvm-project/pull/93149
This patch makes ScriptedThreadPlan conforming to the ScriptedInterface &
ScriptedPythonInterface facilities by introducing 2 ScriptedThreadPlanInterface
& ScriptedThreadPlanPythonInterface classes.
This a
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Med Ismail Bennani (medismailben)
Changes
This patch makes ScriptedThreadPlan conforming to the ScriptedInterface &
ScriptedPythonInterface facilities by introducing 2 ScriptedThreadPlanInterface
& ScriptedThreadPlanPythonInterface classes
https://github.com/medismailben updated
https://github.com/llvm/llvm-project/pull/93149
>From d3f819b19437645199f735c8e376c0f5041e65b1 Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Date: Thu, 23 May 2024 01:21:31 -0700
Subject: [PATCH] [lldb] Make use of Scripted{Python,}Interface for
Scri
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/93119
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben edited
https://github.com/llvm/llvm-project/pull/93149
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Med Ismail Bennani
Date: 2024-05-23T01:25:48-07:00
New Revision: 4cc6d0f4dfb26deb9863901c70258d6d7f0c8ba4
URL:
https://github.com/llvm/llvm-project/commit/4cc6d0f4dfb26deb9863901c70258d6d7f0c8ba4
DIFF:
https://github.com/llvm/llvm-project/commit/4cc6d0f4dfb26deb9863901c70258d6d7f0c8ba4.
https://github.com/medismailben closed
https://github.com/llvm/llvm-project/pull/93149
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath approved this pull request.
Nice find.
https://github.com/llvm/llvm-project/pull/93122
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben created
https://github.com/llvm/llvm-project/pull/93153
Reverts llvm/llvm-project#93149 since it breaks
https://lab.llvm.org/buildbot/#/builders/68/builds/74799
>From 788e65c8171e233d399f3f1df645d6f9fb8f66bc Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Dat
Author: Med Ismail Bennani
Date: 2024-05-23T01:46:29-07:00
New Revision: ae3f68066c8f282145435880107c1d3dc26ec3b8
URL:
https://github.com/llvm/llvm-project/commit/ae3f68066c8f282145435880107c1d3dc26ec3b8
DIFF:
https://github.com/llvm/llvm-project/commit/ae3f68066c8f282145435880107c1d3dc26ec3b8.
https://github.com/medismailben closed
https://github.com/llvm/llvm-project/pull/93153
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Med Ismail Bennani (medismailben)
Changes
Reverts llvm/llvm-project#93149 since it breaks
https://lab.llvm.org/buildbot/#/builders/68/builds/74799
---
Patch is 60.44 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llv
@@ -195,17 +195,17 @@ void DebugNamesDWARFIndex::GetCompleteObjCClass(
if (!ref)
continue;
-DWARFUnit *cu = m_debug_info.GetUnit(*ref);
-if (!cu || !cu->Supports_DW_AT_APPLE_objc_complete_type()) {
- incomplete_types.push_back(*ref);
- continue;
-
DavidSpickett wrote:
I'm currently assuming that the process classes will check those HWCAPs and
only add those registers to the register info if they exist. This code only
patches registers that are already in the info, it doesn't add any new ones.
That said, explicit is better than implicit,
@@ -44,10 +45,20 @@ bool DWARFDebugInfoEntry::Extract(const DWARFDataExtractor
&data,
const DWARFUnit *cu,
lldb::offset_t *offset_ptr) {
m_offset = *offset_ptr;
+ auto report_error = [&](const char *fmt, co
labath wrote:
> We have to back out the PeekDieName() patch locally at Meta because it was
> crashing us due to this assertion due to .debug_names tables having incorrect
> values for type units. Only one type unit will appear in the final file and
> type units can have differing contents for
https://github.com/labath updated
https://github.com/llvm/llvm-project/pull/93006
>From 03ab6febc0f40d0f39f533a5b4fd7c33a6728ae1 Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Tue, 21 May 2024 15:31:23 +
Subject: [PATCH 1/2] [lldb/DWARF] Make sure bad abbreviation codes do not
crash lld
Author: Pavel Labath
Date: 2024-05-23T11:23:07+02:00
New Revision: a2824632cba8e7d98a5cbf9acb3ca5d9960c95cb
URL:
https://github.com/llvm/llvm-project/commit/a2824632cba8e7d98a5cbf9acb3ca5d9960c95cb
DIFF:
https://github.com/llvm/llvm-project/commit/a2824632cba8e7d98a5cbf9acb3ca5d9960c95cb.diff
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/93006
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/93158
DumpValueObjectOptions can only be created and modified from C++. This means
it's currently only testable from Python by calling some command that happens
to use one, and even so, you can't pick which opti
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: David Spickett (DavidSpickett)
Changes
DumpValueObjectOptions can only be created and modified from C++. This means
it's currently only testable from Python by calling some command that happens
to use one, and even so, you can't pick which
@@ -0,0 +1,136 @@
+//===-- DumpValueObjectOptionsTests.cpp
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,136 @@
+//===-- DumpValueObjectOptionsTests.cpp
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
Author: Dmitry Vasilyev
Date: 2024-05-23T13:59:02+04:00
New Revision: 4d9e7b14e45120557e57da2f00f6d23cf122dd95
URL:
https://github.com/llvm/llvm-project/commit/4d9e7b14e45120557e57da2f00f6d23cf122dd95
DIFF:
https://github.com/llvm/llvm-project/commit/4d9e7b14e45120557e57da2f00f6d23cf122dd95.dif
https://github.com/slydiman closed
https://github.com/llvm/llvm-project/pull/93122
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Dmitry Vasilyev
Date: 2024-05-23T14:01:10+04:00
New Revision: e37da2cef7ea44f6aa52dd37978b287a0741c39f
URL:
https://github.com/llvm/llvm-project/commit/e37da2cef7ea44f6aa52dd37978b287a0741c39f
DIFF:
https://github.com/llvm/llvm-project/commit/e37da2cef7ea44f6aa52dd37978b287a0741c39f.dif
https://github.com/slydiman closed
https://github.com/llvm/llvm-project/pull/93119
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/93158
>From aff2acafd911b9eb07405beb5500a487f5d4fc4e Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Wed, 1 May 2024 13:08:54 +
Subject: [PATCH 1/2] [lldb][Test] Add C++ tests for DumpValueObjectOptions a
@@ -0,0 +1,136 @@
+//===-- DumpValueObjectOptionsTests.cpp
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/slydiman created
https://github.com/llvm/llvm-project/pull/93165
This test is based on dap_server which runs locally. This test failed in case
of Windows host and Linux target.
>From 2243749477714852ada7a00bb849514283655464 Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Dat
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dmitry Vasilyev (slydiman)
Changes
This test is based on dap_server which runs locally. This test failed in case
of Windows host and Linux target.
---
Full diff: https://github.com/llvm/llvm-project/pull/93165.diff
1 Files Affected:
- (
https://github.com/labath requested changes to this pull request.
I'm knee-deep in lldb-dap right now. Lemme just send you a PR to skip all tests
at once.
https://github.com/llvm/llvm-project/pull/93165
___
lldb-commits mailing list
lldb-commits@lists
https://github.com/labath created
https://github.com/llvm/llvm-project/pull/93169
The don't currently work (and they're also not particularly useful, since all
of the remote stuff happens inside lldb).
This saves us from annotating tests one by one.
>From 0b29674bdedee83336047a3a8de8b35980853
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
The don't currently work (and they're also not particularly useful, since all
of the remote stuff happens inside lldb).
This saves us from annotating tests one by one.
---
Patch is 32.71 KiB, truncated to 20
https://github.com/labath updated
https://github.com/llvm/llvm-project/pull/93169
>From 7f3ed4661375ca61f4ac0fedafb57c628eca3bd0 Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Thu, 23 May 2024 10:56:48 +
Subject: [PATCH] [lldb-dap] Automatically skip lldb-dap tests for remote
platforms
https://github.com/labath created
https://github.com/llvm/llvm-project/pull/93172
This is a regression from #91591. Turns out std::mutex does not prevent code
from running twice. :facepalm:
>From 26611411308c9a916bc3ffdac0f38e95f8aa8c89 Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Thu, 2
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
This is a regression from #91591. Turns out std::mutex does not prevent
code from running twice. :facepalm:
---
Full diff: https://github.com/llvm/llvm-project/pull/93172.diff
2 Files Affected:
- (modified)
https://github.com/slydiman approved this pull request.
LGTM, thanks!
https://github.com/llvm/llvm-project/pull/93169
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: David Spickett
Date: 2024-05-23T12:28:26Z
New Revision: 32c3561d44aa792ef08d72b5a4c342c9965bc4c2
URL:
https://github.com/llvm/llvm-project/commit/32c3561d44aa792ef08d72b5a4c342c9965bc4c2
DIFF:
https://github.com/llvm/llvm-project/commit/32c3561d44aa792ef08d72b5a4c342c9965bc4c2.diff
LOG
https://github.com/Endilll closed
https://github.com/llvm/llvm-project/pull/92953
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Vlad Serebrennikov
Date: 2024-05-23T17:05:41+04:00
New Revision: 4feae05c6abda364a9295aecfa600d7d4e7dfeb6
URL:
https://github.com/llvm/llvm-project/commit/4feae05c6abda364a9295aecfa600d7d4e7dfeb6
DIFF:
https://github.com/llvm/llvm-project/commit/4feae05c6abda364a9295aecfa600d7d4e7dfeb6.
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/93158
>From 0c6fe37563d7e7ee338a308b32cbea01d1f3808c Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Wed, 1 May 2024 13:08:54 +
Subject: [PATCH 1/2] [lldb][Test] Add C++ tests for DumpValueObjectOptions a
Endilll wrote:
Quite expectedly, I see buildbot failures. Working on them.
https://lab.llvm.org/buildbot/#/builders/36/builds/45836
https://lab.llvm.org/buildbot/#/builders/57/builds/35200
https://github.com/llvm/llvm-project/pull/92953
___
lldb-commit
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/89110
>From 5955863f22d5048cad91f089e96b10ea15c05446 Mon Sep 17 00:00:00 2001
From: Jacob John Lalonde
Date: Wed, 10 Apr 2024 14:33:40 -0700
Subject: [PATCH 1/7] Fix bug where an sbvalue containing a std::string create
Jlalond wrote:
@jimingham it turned out when created by data, the value object's address
points to it's buffer which itself contains the char* of the string.
I'm not sure how we can support the small string optimization if this is the
case, my testing was against a small string "test2", and it
felipepiovezan wrote:
>Since clang no longer emits entry for:
But what does the `debug_info` section look like? In particular, what is the
_parent_ of the class DIE?
If the parent of `InnerState` is not some kind of entry for `State` (either a
declaration or a definition), IMO Clang is genera
ayermolo wrote:
> > Using example above, with a fix by @dwblaikie
> > I see:
> > ```
> > Hash: 0xE0CDC6A2
> > String: 0x0018 "InnerState"
> > Entry @ 0x10b {
> > Abbrev: 0x3
> > Tag: DW_TAG_class_type
> > DW_IDX_type_unit: 0x01
> > DW_IDX_die_offse
ayermolo wrote:
> > Since clang no longer emits entry for:
>
> But what does the `debug_info` section look like? In particular, what is the
> _parent_ of the class DIE? If the parent of `InnerState` is not some kind of
> entry for `State` (either a declaration or a definition), IMO Clang is
>
felipepiovezan wrote:
Ohhh ok, I just inspected the debug_names/debug_info sections; there is no
parent at all for the InnerState debug_names entry. In this case, the
debug_names section is valid. Unfortunate, as this may cause entire CUs/TUs to
be parsed (because of all the calls to Process
felipepiovezan wrote:
> Current BOLT behavior is to skip that DIE and reference it's parent:
This, on the other hand, is concerning. It needs to reflect the debug_info
section, otherwise we can't use debug_names to answer queries like "find
A::B::C::D".
It would be better if the BOLT compiler
https://github.com/adrian-prantl created
https://github.com/llvm/llvm-project/pull/93209
For the significant amount of call sites that want to create an
incontrovertible error, such a wrapper function creates a significant
readability improvement and lowers the cost of entry to add error handl
llvmbot wrote:
@llvm/pr-subscribers-llvm-support
Author: Adrian Prantl (adrian-prantl)
Changes
For the significant amount of call sites that want to create an
incontrovertible error, such a wrapper function creates a significant
readability improvement and lowers the cost of entry to add
adrian-prantl wrote:
The obvious downside is that it makes it easier to not even try to find a
matching error code, but it looks like most incontrovertible errors are caught
before the get reported as an exit status.
https://github.com/llvm/llvm-project/pull/93209
_
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/93169
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kusmour approved this pull request.
Thanks for fixing it :)
Just tested this patch from my side, worked well!
https://github.com/llvm/llvm-project/pull/93172
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llv
https://github.com/kusmour edited
https://github.com/llvm/llvm-project/pull/93172
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
nikic wrote:
FYI this causes a minor compile-time improvement in stage1 builds using gcc:
https://llvm-compile-time-tracker.com/compare.php?from=32c3561d44aa792ef08d72b5a4c342c9965bc4c2&to=4feae05c6abda364a9295aecfa600d7d4e7dfeb6&stat=instructions:u
While that's nice, it does suggest that the f
felipepiovezan wrote:
These types of changes touching a lot of projects at once can benefit from
multiple PRs, one per project, as it makes partial reverts a lot easier and
doesn't cause as much churn downstream (plus we can get more targeted comments
from individual project owners)
https://g
dwblaikie wrote:
Sorry I can't quite figure out who/where to reply to, so perhaps by summarizing
the situation (though it's going to be verbose, and I'm going to add some other
examples/complications) I can get a grip on all this/clarify where we're at.
So, history.
* minimum spec-compliant
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/93209
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere commented:
I'm in favor of this. I rarely have a meaningful error code and it makes the
code needlessly verbose.
I was going to ask if we wanted to make an overload of the existing
`createStringError` but without the error code. But then I noticed that it uses
@@ -87,8 +87,8 @@ llvm::Error Socket::Initialize() {
if (err == 0) {
if (wsaData.wVersion < wVersion) {
WSACleanup();
- return llvm::make_error(
- "WSASock version is not expected.", llvm::inconvertibleErrorCode());
+ return llvm::createStringErro
@@ -87,8 +87,8 @@ llvm::Error Socket::Initialize() {
if (err == 0) {
if (wsaData.wVersion < wVersion) {
WSACleanup();
- return llvm::make_error(
- "WSASock version is not expected.", llvm::inconvertibleErrorCode());
+ return llvm::createStringErro
Endilll wrote:
> FYI this causes a minor compile-time improvement in stage1 builds using gcc:
> https://llvm-compile-time-tracker.com/compare.php?from=32c3561d44aa792ef08d72b5a4c342c9965bc4c2&to=4feae05c6abda364a9295aecfa600d7d4e7dfeb6&stat=instructions:u
> While that's nice, it does suggest th
https://github.com/petrhosek approved this pull request.
https://github.com/llvm/llvm-project/pull/92865
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jimingham wrote:
LGTM.
We do offer SBValue::GetDescription, which uses a default
DumpValueObjectOptions. So it would be entirely reasonable to make an
SBValueObjectDescriptionOptions (or maybe a shorter name?) and add
SBValue::GetDescription(SBValueObjectDescriptionOptions) API.
But peopl
ayermolo wrote:
OK, thanks for detailed explanation.
Will re-read few more time to fully process it. :)
I'll change BOLT behavior to reflect the new clang behavior. If there is a
forward delcaration (skeleton die), the parent chain won't skip it, but instead
won't emit parent for it's children
@@ -16,9 +16,12 @@
#include "lldb/DataFormatters/VectorIterator.h"
#include "lldb/Target/Target.h"
#include "lldb/Utility/DataBufferHeap.h"
+#include "lldb/Utility/DataExtractor.h"
#include "lldb/Utility/Endian.h"
#include "lldb/Utility/Status.h"
#include "lldb/Utility/Strea
@@ -2763,10 +2763,10 @@ ValueObjectSP ValueObject::Cast(const CompilerType
&compiler_type) {
ExecutionContextScope *exe_scope
= ExecutionContext(GetExecutionContextRef())
.GetBestExecutionContextScope();
- if (compiler_type.GetByteSize(exe_scope)
- <= G
@@ -0,0 +1,49 @@
+# coding=utf8
+"""
+Helper formmater to verify Std::String by created via SBData
jimingham wrote:
formmater -> formatter
https://github.com/llvm/llvm-project/pull/89110
___
lldb-commits mailing list
l
@@ -17,6 +17,15 @@ def setUp(self):
# Find the line number to break at.
self.line = line_number("main.cpp", "// Set break point at this line.")
+# This is the function to remove the custom formats in order to have a
jimingham wrote:
If you
@@ -17,6 +17,15 @@ def setUp(self):
# Find the line number to break at.
self.line = line_number("main.cpp", "// Set break point at this line.")
+# This is the function to remove the custom formats in order to have a
jimingham wrote:
Ah, I
https://github.com/jimingham edited
https://github.com/llvm/llvm-project/pull/89110
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -2763,10 +2763,10 @@ ValueObjectSP ValueObject::Cast(const CompilerType
&compiler_type) {
ExecutionContextScope *exe_scope
= ExecutionContext(GetExecutionContextRef())
.GetBestExecutionContextScope();
- if (compiler_type.GetByteSize(exe_scope)
- <= G
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/93209
>From bece445681b0f810927c799cea53686cd000339b Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Thu, 23 May 2024 08:36:48 -0700
Subject: [PATCH] Add a createError variant without error code (NFC)
For the
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/93209
>From c5738598436c7a9e1ba38ba8ffd6f67a2e524785 Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Thu, 23 May 2024 08:36:48 -0700
Subject: [PATCH] Add a createError variant without error code (NFC)
For the
@@ -254,13 +254,17 @@ bool
lldb_private::formatters::LibStdcppStringSummaryProvider(
} else
addr_of_string =
valobj.GetAddressOf(scalar_is_load_addr, &addr_type);
- if (addr_of_string != LLDB_INVALID_ADDRESS) {
+
+ // We have to check for host address here
+ /
https://github.com/GeorgeHuyubo updated
https://github.com/llvm/llvm-project/pull/92492
>From a9714b155a116e9b1d18434c0485ea2ad35680f3 Mon Sep 17 00:00:00 2001
From: George Hu
Date: Tue, 14 May 2024 16:18:20 -0700
Subject: [PATCH] Read and store gnu build id from loaded core file
---
.../Proc
https://github.com/medismailben approved this pull request.
This will be very useful. LGTM!
https://github.com/llvm/llvm-project/pull/93209
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-c
@@ -17,6 +17,15 @@ def setUp(self):
# Find the line number to break at.
self.line = line_number("main.cpp", "// Set break point at this line.")
+# This is the function to remove the custom formats in order to have a
Jlalond wrote:
This PR
@@ -254,13 +254,17 @@ bool
lldb_private::formatters::LibStdcppStringSummaryProvider(
} else
addr_of_string =
valobj.GetAddressOf(scalar_is_load_addr, &addr_type);
- if (addr_of_string != LLDB_INVALID_ADDRESS) {
+
+ // We have to check for host address here
+ /
dwblaikie wrote:
> "std::ios_base" is forward declared and it contains typedefs whose entries in
> the .debug_names table will point to the DIE at offset 0x0090cdd5. These
> entries cause our type lookups to try and parse a TON of forward declarations
> and waste time and resources.
>
> This
@@ -0,0 +1,65 @@
+//===-- SBAddressRange.h *- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,28 @@
+%extend lldb::SBAddressRangeList {
+#ifdef SWIGPYTHON
+%pythoncode%{
+def __len__(self):
+ '''Return the number of address ranges in a lldb.SBAddressRangeList
object.'''
+ return self.GetSize()
+
+def __iter__(self):
+ '''Iterate over
@@ -0,0 +1,65 @@
+//===-- SBAddressRange.h *- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
dwblaikie wrote:
As for the original issue this patch is meant to address - I'd still like to
see an example of the problem, as I'm not sure what the issue is. (but,
equally, I'm not a decider in lldb - so don't have to wait on my for approval
if other lldb devs reckon this is the right direct
dwblaikie wrote:
But seems like this isn't a DW_IDX_parent issue, then (other than as /maybe/ an
artifact of the producer) - so the description seems misleading. "ignore
invalid named entries that refer to declarations"
A test case/demonstration this is a real problem would be nice, though...
@@ -0,0 +1,65 @@
+//===-- SBAddressRange.h *- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
Author: Adrian Prantl
Date: 2024-05-23T14:22:07-07:00
New Revision: af31883341a122a7285e9b4f0a034470024021eb
URL:
https://github.com/llvm/llvm-project/commit/af31883341a122a7285e9b4f0a034470024021eb
DIFF:
https://github.com/llvm/llvm-project/commit/af31883341a122a7285e9b4f0a034470024021eb.diff
https://github.com/adrian-prantl closed
https://github.com/llvm/llvm-project/pull/93209
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jasonmolenda wrote:
> The way I see it, this check (at least the part about the RA register(*)) is
> heuristic that's impossible to get always right. Like, I could construct a
> test case using functions with non-standard ABIs where a non-leaf function
> legitimately has a `lr=` rule. Such cod
jimingham wrote:
We should definitely put more comments in the ValueObject.h header, a lot of
those interfaces are mysterious.
GetAddressOf is solving a very particular problem, which is that if someone
does:
(lldb) expr MakeMeAFooObject()
$0= {whatever}
(lldb) expr CallAFunctionTakingAFooPoi
https://github.com/StephanTLavavej created
https://github.com/llvm/llvm-project/pull/93260
After fixing a test name typo in #93259, I noticed these comment typos.
(This is a separate "nice to have" PR, so that it doesn't get mixed up with the
test changes that I need.)
>From 77ddab4fafd48
llvmbot wrote:
@llvm/pr-subscribers-lldb
@llvm/pr-subscribers-coroutines
@llvm/pr-subscribers-flang-fir-hlfir
Author: Stephan T. Lavavej (StephanTLavavej)
Changes
After fixing a test name typo in #93259, I noticed these comment typos.
(This is a separate "nice to have" PR, so that it does
1 - 100 of 114 matches
Mail list logo
