labath wrote:
I'm not quite sure what you have in mind, but I can tell you what's been going
through my mind in the context of the `m_all_registers_available` check in
`lldb/source/Target/RegisterContextUnwind.cpp` . The way I see it, this check
(at least the part about the RA register(*)) is
https://github.com/labath created
https://github.com/llvm/llvm-project/pull/93006
We currently cannot represent abbreviation codes with more than 16 bits, and we
were lldb-asserting if we ever ran into one. While I haven't seen any real
DWARF with these kinds of abbreviations, it is possible t
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
We currently cannot represent abbreviation codes with more than 16 bits, and we
were lldb-asserting if we ever ran into one. While I haven't seen any real
DWARF with these kinds of abbreviations, it is possibl
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/92953
>From 66e05ac24613435dbe774d49684d8ff9d119c4c3 Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Tue, 21 May 2024 21:41:24 +0300
Subject: [PATCH 1/2] Remove some `try_compile` CMake checks for compiler flag
https://github.com/walter-erquinigo approved this pull request.
Pretty nice! This will be useful for Mojo as well
https://github.com/llvm/llvm-project/pull/92979
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/m
kusmour wrote:
> > I can't remember: does terminate come before disconnecting? Or is it the
> > other way around?
>
> Disconnect docs say "The disconnect request asks the debug adapter to
> disconnect from the debuggee (thus ending the debug session) and then to shut
> down itself (the debug
https://github.com/felipepiovezan approved this pull request.
LGTM! Thanks for catching this
https://github.com/llvm/llvm-project/pull/93006
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/92843
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/cmtice updated
https://github.com/llvm/llvm-project/pull/87197
>From 68cb68d3f93aed6b3479fb305131b99ec599c9d8 Mon Sep 17 00:00:00 2001
From: Caroline Tice
Date: Sun, 31 Mar 2024 10:59:38 -0700
Subject: [PATCH 1/4] [LLDB] Add more helper functions to ValueObject class.
Create
@@ -668,6 +699,32 @@ class ValueObject {
CreateValueObjectFromData(llvm::StringRef name, const DataExtractor &data,
const ExecutionContext &exe_ctx, CompilerType
type);
+ static lldb::ValueObjectSP
+ CreateValueObjectFromBytes(lldb::TargetSP ta
@@ -668,6 +699,32 @@ class ValueObject {
CreateValueObjectFromData(llvm::StringRef name, const DataExtractor &data,
const ExecutionContext &exe_ctx, CompilerType
type);
+ static lldb::ValueObjectSP
+ CreateValueObjectFromBytes(lldb::TargetSP ta
@@ -668,6 +699,32 @@ class ValueObject {
CreateValueObjectFromData(llvm::StringRef name, const DataExtractor &data,
const ExecutionContext &exe_ctx, CompilerType
type);
+ static lldb::ValueObjectSP
+ CreateValueObjectFromBytes(lldb::TargetSP ta
@@ -668,6 +699,32 @@ class ValueObject {
CreateValueObjectFromData(llvm::StringRef name, const DataExtractor &data,
const ExecutionContext &exe_ctx, CompilerType
type);
+ static lldb::ValueObjectSP
+ CreateValueObjectFromBytes(lldb::TargetSP ta
@@ -1089,6 +1089,116 @@ int64_t ValueObject::GetValueAsSigned(int64_t
fail_value, bool *success) {
return fail_value;
}
+llvm::APSInt ValueObject::GetValueAsAPSInt() {
+ lldb::TargetSP target = GetTargetSP();
+ uint64_t byte_size = 0;
+ if (auto temp = GetCompilerType().
cmtice wrote:
I'm sorry this has taken me so long, but I believe I have addressed/fixed
everyone's comments now; if I missed any please let me know. Please review
this PR again.
https://github.com/llvm/llvm-project/pull/87197
___
lldb-commits maili
labath wrote:
Ah yes, of course, I've kept the mutex thinking that its sufficient to make it
run only once, but of course that's only true if the critical section actually
contains a "run once" check. I'll create a patch for that tomorrow. Feel free
to revert in the mean time if this is blocki
@@ -2809,6 +2919,243 @@ ValueObjectSP ValueObject::CastPointerType(const char
*name, TypeSP &type_sp) {
return valobj_sp;
}
+lldb::addr_t ValueObject::GetLoadAddress() {
+ lldb::addr_t addr_value = LLDB_INVALID_ADDRESS;
+ lldb::TargetSP target_sp = GetTargetSP();
+ if (t
https://github.com/GeorgeHuyubo updated
https://github.com/llvm/llvm-project/pull/92492
>From 304528acdd3590bf4d8d1a03e31fd0970ed2eaa2 Mon Sep 17 00:00:00 2001
From: George Hu
Date: Tue, 14 May 2024 16:18:20 -0700
Subject: [PATCH] Read and store gnu build id from loaded core file
---
.../Plug
@@ -271,6 +282,17 @@ Status ProcessElfCore::DoLoadCore() {
return error;
}
+void ProcessElfCore::UpdateBuildIdForNTFileEntries() {
+ if (!m_nt_file_entries.empty()) {
GeorgeHuyubo wrote:
@labath
There are two reasons,
1. We need to do this after we load P
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/92979
>From a8503fb49ef7964dbde318df103546bde72f7b42 Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Tue, 21 May 2024 17:41:31 -0700
Subject: [PATCH] Change GetChildCompilerTypeAtIndex to return Expected (NFC)
https://github.com/GeorgeHuyubo updated
https://github.com/llvm/llvm-project/pull/92492
>From fc7ae3cd19a999375504733be6c942978d80d5d7 Mon Sep 17 00:00:00 2001
From: George Hu
Date: Tue, 14 May 2024 16:18:20 -0700
Subject: [PATCH] Read and store gnu build id from loaded core file
---
.../Plug
Author: Adrian Prantl
Date: 2024-05-22T08:52:33-07:00
New Revision: ac1dc05b331d35f341631f798673fe8aafdda53d
URL:
https://github.com/llvm/llvm-project/commit/ac1dc05b331d35f341631f798673fe8aafdda53d
DIFF:
https://github.com/llvm/llvm-project/commit/ac1dc05b331d35f341631f798673fe8aafdda53d.diff
https://github.com/adrian-prantl closed
https://github.com/llvm/llvm-project/pull/92979
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
zxombie wrote:
It looks like `svcr` is for SME & `mte_ctrl` is for MTE. Neither of these are
currently supported in FreeBSD. When they are supported the appropriate `HWCAP`
flags (and `ID_AA64*` registers) will be set to tell userspace it can use them.
https://github.com/llvm/llvm-project/pull
https://github.com/GeorgeHuyubo updated
https://github.com/llvm/llvm-project/pull/92492
>From 4e4ca8edc4116cba0925cca8229bd5b1cb002b21 Mon Sep 17 00:00:00 2001
From: George Hu
Date: Tue, 14 May 2024 16:18:20 -0700
Subject: [PATCH] Read and store gnu build id from loaded core file
---
.../Proc
Author: Kazu Hirata
Date: 2024-05-22T10:09:10-07:00
New Revision: 8df5a37b848c6ac5a68b56eeddb4a7746b84d288
URL:
https://github.com/llvm/llvm-project/commit/8df5a37b848c6ac5a68b56eeddb4a7746b84d288
DIFF:
https://github.com/llvm/llvm-project/commit/8df5a37b848c6ac5a68b56eeddb4a7746b84d288.diff
L
https://github.com/clayborg approved this pull request.
https://github.com/llvm/llvm-project/pull/92572
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Kevin Frei
Date: 2024-05-22T10:31:04-07:00
New Revision: e558d21e87882d40e29d858b1269ee8f1ddf2a38
URL:
https://github.com/llvm/llvm-project/commit/e558d21e87882d40e29d858b1269ee8f1ddf2a38
DIFF:
https://github.com/llvm/llvm-project/commit/e558d21e87882d40e29d858b1269ee8f1ddf2a38.diff
LO
https://github.com/clayborg closed
https://github.com/llvm/llvm-project/pull/92572
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -195,17 +195,17 @@ void DebugNamesDWARFIndex::GetCompleteObjCClass(
if (!ref)
continue;
-DWARFUnit *cu = m_debug_info.GetUnit(*ref);
-if (!cu || !cu->Supports_DW_AT_APPLE_objc_complete_type()) {
- incomplete_types.push_back(*ref);
- continue;
-
https://github.com/felipepiovezan edited
https://github.com/llvm/llvm-project/pull/92894
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan edited
https://github.com/llvm/llvm-project/pull/92894
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan edited
https://github.com/llvm/llvm-project/pull/92894
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/GeorgeHuyubo updated
https://github.com/llvm/llvm-project/pull/92492
>From 11dda0b456880005695b6d1f195060788ad0edb7 Mon Sep 17 00:00:00 2001
From: George Hu
Date: Tue, 14 May 2024 16:18:20 -0700
Subject: [PATCH] Read and store gnu build id from loaded core file
---
.../Proc
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/93006
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -44,10 +45,20 @@ bool DWARFDebugInfoEntry::Extract(const DWARFDataExtractor
&data,
const DWARFUnit *cu,
lldb::offset_t *offset_ptr) {
m_offset = *offset_ptr;
+ auto report_error = [&](const char *fmt, co
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/93006
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/clayborg commented:
We have to back out the PeekDieName() patch locally at Meta because it was
crashing us due to this assertion due to .debug_names tables having incorrect
values for type units. Only one type unit will appear in the final file and
type units can have differ
https://github.com/slydiman edited
https://github.com/llvm/llvm-project/pull/90580
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
mysterymath wrote:
This broke the Fuchsia CI builders' LLDB test suite:
https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8747217173107569041/overview
```
FAIL: LLDB (/b/s/w/ir/x/w/llvm_build/bin/clang-x86_64) ::
test_normal_stripped_split_with_dwp
(TestDebugin
https://github.com/mysterymath created
https://github.com/llvm/llvm-project/pull/93094
Reverts llvm/llvm-project#92572 due to Fuchsia CI breakages (using CLI tools in
tests that weren't necessarily built).
>From daa63e1870999e8ca8db454a788a0720740d194a Mon Sep 17 00:00:00 2001
From: Daniel Tho
https://github.com/mysterymath closed
https://github.com/llvm/llvm-project/pull/93094
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Daniel Thornburgh
Date: 2024-05-22T13:56:33-07:00
New Revision: c93a67038dcc1adeafa74e105fba02714732097a
URL:
https://github.com/llvm/llvm-project/commit/c93a67038dcc1adeafa74e105fba02714732097a
DIFF:
https://github.com/llvm/llvm-project/commit/c93a67038dcc1adeafa74e105fba02714732097a.d
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Daniel Thornburgh (mysterymath)
Changes
Reverts llvm/llvm-project#92572 due to Fuchsia CI breakages (using CLI
tools in tests that weren't necessarily built).
---
Patch is 27.56 KiB, truncated to 20.00 KiB below, full version:
https://gi
@@ -1312,10 +1312,16 @@ class Process : public
std::enable_shared_from_this,
size_t GetThreadStatus(Stream &ostrm, bool only_threads_with_stop_reason,
uint32_t start_frame, uint32_t num_frames,
- uint32_t num_frames_with_sour
@@ -1312,10 +1312,16 @@ class Process : public
std::enable_shared_from_this,
size_t GetThreadStatus(Stream &ostrm, bool only_threads_with_stop_reason,
uint32_t start_frame, uint32_t num_frames,
- uint32_t num_frames_with_sour
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/92953
>From 66e05ac24613435dbe774d49684d8ff9d119c4c3 Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Tue, 21 May 2024 21:41:24 +0300
Subject: [PATCH 1/3] Remove some `try_compile` CMake checks for compiler flag
@@ -983,6 +1001,66 @@ llvm::Error
ProcessElfCore::ParseThreadContextsFromNoteSegment(
}
}
+bool ProcessElfCore::IsElf(lldb::addr_t address) {
+ uint8_t buf[4];
+ Status error;
+ size_t byte_read = ReadMemory(address, buf, 4, error);
+ if (byte_read != 4)
+return fal
@@ -167,7 +178,8 @@ class ProcessElfCore : public
lldb_private::PostMortemProcess {
AddAddressRangeFromMemoryTagSegment(const elf::ELFProgramHeader &header);
llvm::Expected>
- parseSegment(const lldb_private::DataExtractor &segment);
+ parseSegment(const lldb_private::D
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/92492
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -117,6 +117,7 @@ class ProcessElfCore : public
lldb_private::PostMortemProcess {
lldb::addr_t end;
lldb::addr_t file_ofs;
std::string path;
+lldb_private::UUID uuid; //.note.gnu.build-id
clayborg wrote:
Add a comment letting the user know t
https://github.com/clayborg requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/92492
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -983,6 +1001,66 @@ llvm::Error
ProcessElfCore::ParseThreadContextsFromNoteSegment(
}
}
+bool ProcessElfCore::IsElf(lldb::addr_t address) {
+ uint8_t buf[4];
+ Status error;
+ size_t byte_read = ReadMemory(address, buf, 4, error);
+ if (byte_read != 4)
+return fal
@@ -983,6 +1001,66 @@ llvm::Error
ProcessElfCore::ParseThreadContextsFromNoteSegment(
}
}
+bool ProcessElfCore::IsElf(lldb::addr_t address) {
+ uint8_t buf[4];
+ Status error;
+ size_t byte_read = ReadMemory(address, buf, 4, error);
+ if (byte_read != 4)
+return fal
@@ -570,11 +586,13 @@ static void ParseOpenBSDProcInfo(ThreadData &thread_data,
}
llvm::Expected>
-ProcessElfCore::parseSegment(const DataExtractor &segment) {
+ProcessElfCore::parseSegment(const DataExtractor &segment,
+ unsigned long segment_size)
@@ -983,6 +1001,66 @@ llvm::Error
ProcessElfCore::ParseThreadContextsFromNoteSegment(
}
}
+bool ProcessElfCore::IsElf(lldb::addr_t address) {
+ uint8_t buf[4];
+ Status error;
+ size_t byte_read = ReadMemory(address, buf, 4, error);
+ if (byte_read != 4)
+return fal
@@ -983,6 +1001,66 @@ llvm::Error
ProcessElfCore::ParseThreadContextsFromNoteSegment(
}
}
+bool ProcessElfCore::IsElf(lldb::addr_t address) {
+ uint8_t buf[4];
+ Status error;
+ size_t byte_read = ReadMemory(address, buf, 4, error);
+ if (byte_read != 4)
+return fal
@@ -570,11 +586,13 @@ static void ParseOpenBSDProcInfo(ThreadData &thread_data,
}
llvm::Expected>
-ProcessElfCore::parseSegment(const DataExtractor &segment) {
+ProcessElfCore::parseSegment(const DataExtractor &segment,
+ unsigned long segment_size)
@@ -801,7 +801,7 @@ static OutputDesc
*addInputSec(StringMap> &map,
auto *firstIsec = cast(
cast(sec->commands[0])->sectionBases[0]);
OutputSection *firstIsecOut =
- firstIsec->flags & SHF_LINK_ORDER
MaskRay wrote:
A CppCheck is
@@ -0,0 +1,96 @@
+//===-- ThreadPlanSingleThreadTimeout.h -*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -42,8 +45,13 @@ class ThreadPlanStepOverRange : public ThreadPlanStepRange,
void SetupAvoidNoDebug(LazyBool step_out_avoids_code_without_debug_info);
bool IsEquivalentContext(const SymbolContext &context);
+ // Clear and create a new ThreadPlanSingleThreadTimeout to de
@@ -440,6 +440,12 @@ class ProcessGDBRemote : public Process,
void HandleStopReply() override;
void HandleAsyncStructuredDataPacket(llvm::StringRef data) override;
+ // Handle thread specific async interrupt and return the original thread
+ // that requested the async in
@@ -3905,9 +3911,14 @@ thread_result_t Process::RunPrivateStateThread(bool
is_secondary_thread) {
if (interrupt_requested) {
if (StateIsStoppedState(internal_state, true)) {
- // We requested the interrupt, so mark this as such in the stop event
-
@@ -1125,6 +1125,38 @@ class StopInfoUnixSignal : public StopInfo {
std::optional m_code;
};
+// StopInfoInterrupt
+
+class StopInfoInterrupt : public StopInfo {
+public:
+ StopInfoInterrupt(Thread &thread, int signo, const char *description)
+ : StopInfo(thread, signo
ayermolo wrote:
Using example above, with a fix by @dwblaikie
I see:
```
Hash: 0xE0CDC6A2
String: 0x0018 "InnerState"
Entry @ 0x10b {
Abbrev: 0x3
Tag: DW_TAG_class_type
DW_IDX_type_unit: 0x01
DW_IDX_die_offset: 0x0030
}
```
Since clan
https://github.com/slydiman created
https://github.com/llvm/llvm-project/pull/93119
Sometimes this test failed on the assert `The thread exited` in case of a
remote target. Increase the timeout to 1 second to avoid a racing condition.
>From c51c200295425167d664197bc4c15d02ec91ed09 Mon Sep 17 0
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dmitry Vasilyev (slydiman)
Changes
Sometimes this test failed on the assert `The thread exited` in case of a
remote target. Increase the timeout to 1 second to avoid a racing condition.
---
Full diff: https://github.com/llvm/llvm-project/p
https://github.com/slydiman created
https://github.com/llvm/llvm-project/pull/93122
The TestBreakpointCommand test is incorrectly disabled for Windows target. We
can disable it for Windows host instead or just fix the issue. This patch fixes
the path separator in BreakpointResolverFileLine::De
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dmitry Vasilyev (slydiman)
Changes
The TestBreakpointCommand test is incorrectly disabled for Windows target. We
can disable it for Windows host instead or just fix the issue. This patch fixes
the path separator in BreakpointResolverFileLi
https://github.com/aaronmondal updated
https://github.com/llvm/llvm-project/pull/92865
>From 124be680ca3ae82edd6fa9a49b1fd171d1babbf5 Mon Sep 17 00:00:00 2001
From: Aaron Siddhartha Mondal
Date: Tue, 21 May 2024 06:37:49 +0200
Subject: [PATCH] [Support] Remove terminfo dependency
The terminfo
https://github.com/MaskRay approved this pull request.
https://github.com/llvm/llvm-project/pull/92865
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
71 matches
Mail list logo
