[Lldb-commits] [lldb] [lldb] Use operator==(StringRef, StringRef) instead of StringRef::equals (NFC) (PR #92476)

2024-05-16 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/92476 StringRef) instead of StringRef::equals (NFC),Note that StringRef::equals has been deprecated in favor of operator==(StringRef, StringRef). >From ec50a9b1b95ed98e0ce0b7264bd4174e965d80f5 Mon Sep 17 00:00

[Lldb-commits] [lldb] [lldb] Use operator==(StringRef, StringRef) instead of StringRef::equals (NFC) (PR #92476)

2024-05-16 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata edited https://github.com/llvm/llvm-project/pull/92476 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use operator==(StringRef, StringRef) instead of StringRef::equals (NFC) (PR #92476)

2024-05-16 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Kazu Hirata (kazutakahirata) Changes Note that StringRef::equals has been deprecated in favor of operator==(StringRef, StringRef). --- Patch is 40.84 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pu

[Lldb-commits] [lldb] [lldb] Use operator==(StringRef, StringRef) instead of StringRef::equals (NFC) (PR #92476)

2024-05-16 Thread Fangrui Song via lldb-commits
https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/92476 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] New ThreadPlanSingleThreadTimeout to resolve potential deadlock in single thread stepping (PR #90930)

2024-05-16 Thread via lldb-commits
https://github.com/jeffreytan81 updated https://github.com/llvm/llvm-project/pull/90930 >From b72df8cf2a047ed731913609b58bdb4a3601e111 Mon Sep 17 00:00:00 2001 From: jeffreytan81 Date: Thu, 2 May 2024 18:12:04 -0700 Subject: [PATCH 1/4] Single thread timeout feature --- lldb/include/lldb/Targ

[Lldb-commits] [lldb] New ThreadPlanSingleThreadTimeout to resolve potential deadlock in single thread stepping (PR #90930)

2024-05-16 Thread via lldb-commits
@@ -1312,11 +1312,13 @@ class Process : public std::enable_shared_from_this, size_t GetThreadStatus(Stream &ostrm, bool only_threads_with_stop_reason, uint32_t start_frame, uint32_t num_frames, - uint32_t num_frames_with_sour

[Lldb-commits] [lldb] New ThreadPlanSingleThreadTimeout to resolve potential deadlock in single thread stepping (PR #90930)

2024-05-16 Thread via lldb-commits
@@ -590,6 +591,7 @@ class ThreadPlanNull : public ThreadPlan { const Status &GetStatus() { return m_status; } protected: + friend class ThreadPlanSingleThreadTimeout; jeffreytan81 wrote: Hmm, I thought there is a reason I can't remember, apparently not. Re

[Lldb-commits] [lldb] [lldb] Use operator==(StringRef, StringRef) instead of StringRef::equals (NFC) (PR #92476)

2024-05-16 Thread Jakub Kuderski via lldb-commits
https://github.com/kuhar approved this pull request. https://github.com/llvm/llvm-project/pull/92476 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use operator==(StringRef, StringRef) instead of StringRef::equals (NFC) (PR #92476)

2024-05-16 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. The change looks fine. Was this done with by hand or with the help of a script? If so please put that in the commit message so we can do the same downstream. https://github.com/llvm/llvm-project/pull/92476 _

[Lldb-commits] [lldb] ebf2831 - [lldb] Include SBLanguages in the SWIG bindings (#92470)

2024-05-16 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2024-05-16T19:31:43-07:00 New Revision: ebf283162f5a0e7e9392c3a825e060856eee0991 URL: https://github.com/llvm/llvm-project/commit/ebf283162f5a0e7e9392c3a825e060856eee0991 DIFF: https://github.com/llvm/llvm-project/commit/ebf283162f5a0e7e9392c3a825e060856eee0991.d

[Lldb-commits] [lldb] [lldb] Include SBLanguages in the SWIG bindings (PR #92470)

2024-05-16 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/92470 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [lldb] [llvm] [mlir] [openmp] [polly] fix(python): fix comparison to None (PR #91857)

2024-05-16 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere commented: This should really be broken up into separate PRs per subproject. One large PR like this makes reviewing harder and causes unnecessary churn in the case that this gets reverted. https://github.com/llvm/llvm-project/pull/91857 _

[Lldb-commits] [lldb] Revert "[lldb] Include SBLanguages in the SWIG bindings" (PR #92490)

2024-05-16 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/92490 Reverts llvm/llvm-project#92470 >From ebb9f82e4c6f9b7c6f627da71ffbfb858f655d1e Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Thu, 16 May 2024 19:58:44 -0700 Subject: [PATCH] Revert "[lldb] Include

[Lldb-commits] [lldb] 5529278 - Revert "[lldb] Include SBLanguages in the SWIG bindings" (#92490)

2024-05-16 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2024-05-16T19:58:58-07:00 New Revision: 552927840319572a649cdec2d8bf2e688a5df490 URL: https://github.com/llvm/llvm-project/commit/552927840319572a649cdec2d8bf2e688a5df490 DIFF: https://github.com/llvm/llvm-project/commit/552927840319572a649cdec2d8bf2e688a5df490.d

[Lldb-commits] [lldb] Revert "[lldb] Include SBLanguages in the SWIG bindings" (PR #92490)

2024-05-16 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/92490 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert "[lldb] Include SBLanguages in the SWIG bindings" (PR #92490)

2024-05-16 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes Reverts llvm/llvm-project#92470 --- Full diff: https://github.com/llvm/llvm-project/pull/92490.diff 3 Files Affected: - (modified) lldb/bindings/CMakeLists.txt (-2) - (modified) lldb/bindings/hea

[Lldb-commits] [clang] [lldb] [llvm] [BOLT][NFC] Rename DataAggregator::BranchInfo to TakenBranchInfo (PR #92017)

2024-05-16 Thread Amir Ayupov via lldb-commits
https://github.com/aaupov edited https://github.com/llvm/llvm-project/pull/92017 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [llvm] [BOLT][NFC] Rename DataAggregator::BranchInfo to TakenBranchInfo (PR #92017)

2024-05-16 Thread Amir Ayupov via lldb-commits
https://github.com/aaupov closed https://github.com/llvm/llvm-project/pull/92017 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [libcxx] [lldb] [llvm] [mlir] [BOLT][BAT] Add entries for deleted basic blocks (PR #91906)

2024-05-16 Thread Amir Ayupov via lldb-commits
https://github.com/aaupov edited https://github.com/llvm/llvm-project/pull/91906 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Read and store gnu build id from loaded core file (PR #92492)

2024-05-16 Thread via lldb-commits
https://github.com/GeorgeHuyubo created https://github.com/llvm/llvm-project/pull/92492 As we have debuginfod as symbol locator available in lldb now, we want to make full use of it. In case of post mortem debugging, we don't always have the main executable available. However, the .note.gnu.bu

[Lldb-commits] [lldb] Read and store gnu build id from loaded core file (PR #92492)

2024-05-16 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (GeorgeHuyubo) Changes As we have debuginfod as symbol locator available in lldb now, we want to make full use of it. In case of post mortem debugging, we don't always have the main executable available. However, the .note.gnu.build-i

[Lldb-commits] [lldb] [lldb] Use operator==(StringRef, StringRef) instead of StringRef::equals (NFC) (PR #92476)

2024-05-16 Thread Kazu Hirata via lldb-commits
kazutakahirata wrote: > The change looks fine. Was this done with by hand or with the help of a > script? If so please put that in the commit message so we can do the same > downstream. Thank you for reviewing the patch! I did get help from a script, but it's a bit too involved for a commit m

[Lldb-commits] [lldb] [lldb] Use operator==(StringRef, StringRef) instead of StringRef::equals (NFC) (PR #92476)

2024-05-16 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/92476 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] c339226 - [lldb] Use operator==(StringRef, StringRef) instead of StringRef::equals (NFC) (#92476)

2024-05-16 Thread via lldb-commits
Author: Kazu Hirata Date: 2024-05-16T20:47:12-07:00 New Revision: c33922666ce219fd6cb3341c3394f72050599552 URL: https://github.com/llvm/llvm-project/commit/c33922666ce219fd6cb3341c3394f72050599552 DIFF: https://github.com/llvm/llvm-project/commit/c33922666ce219fd6cb3341c3394f72050599552.diff L

[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [lldb] [llvm] [mlir] [openmp] [polly] fix(python): fix comparison to None (PR #91857)

2024-05-16 Thread Mehdi Amini via lldb-commits
https://github.com/joker-eph approved this pull request. If you can push this to main in separate commits (one per project as it was mentioned?), that'd be great! https://github.com/llvm/llvm-project/pull/91857 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [lldb] Add new Python API `SBCommandInterpreter::GetTranscript()` (PR #90703)

2024-05-16 Thread via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/90703 >From 0fd67e2de7e702ce6f7353845454ea7ff9f980d6 Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Tue, 30 Apr 2024 21:35:49 -0700 Subject: [PATCH 01/17] Add SBCommandInterpreter::GetTranscript() --- lldb/include/lld

[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [lldb] [llvm] [mlir] [openmp] [polly] fix(python): fix comparison to None (PR #91857)

2024-05-16 Thread Maksim Levental via lldb-commits
makslevental wrote: It's a `sed s/== None/is None/g` - what is there to review? 10 separate PRs for the same exact `sed` costs more in commit noise (and effort on the part of @e-kwsm) than one solid, patient, review here. https://github.com/llvm/llvm-project/pull/91857

[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [lldb] [llvm] [mlir] [openmp] [polly] fix(python): fix comparison to None (PR #91857)

2024-05-16 Thread Maksim Levental via lldb-commits
https://github.com/makslevental approved this pull request. There you go - diligently reviewed using GitHub 's fantastic UI. ![Screenshot_20240517_011154_com android chrome](https://github.com/llvm/llvm-project/assets/5657668/ece87aff-4c44-4f07-8176-1adeaa4ff32e) https://github.com/llvm/llvm-

<    1   2