https://github.com/slydiman created
https://github.com/llvm/llvm-project/pull/91923
Transfer `stdio.log` from the remote target if necessary.
>From 47839ef62cea9d1c79c97a70c4714f365eeb4e02 Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Mon, 13 May 2024 10:56:36 +0400
Subject: [PATCH] [ll
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dmitry Vasilyev (slydiman)
Changes
Transfer `stdio.log` from the remote target if necessary.
---
Full diff: https://github.com/llvm/llvm-project/pull/91923.diff
1 Files Affected:
- (modified)
lldb/test/API/commands/platform/process/laun
https://github.com/slydiman created
https://github.com/llvm/llvm-project/pull/91931
Install `a.out` to the remote target (after handshake) if necessary and use the
remote path to call `vRun`.
>From cbc183bd78c26ca3777cc4a81797d57ab3fa945d Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: M
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dmitry Vasilyev (slydiman)
Changes
Install `a.out` to the remote target (after handshake) if necessary and use the
remote path to call `vRun`.
---
Full diff: https://github.com/llvm/llvm-project/pull/91931.diff
1 Files Affected:
- (modi
omjavaid wrote:
@labath this seems to have broken lldb-aarch64-windows bot with
TestInterruptBacktrace.py failing on
num_frames = thread.GetNumFrames()
https://github.com/llvm/llvm-project/pull/91321
___
lldb-commits mailing list
lldb-commits@lists.
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/91882
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -841,12 +841,14 @@ static bool CheckIfWatchpointsSupported(Target *target,
Status &error) {
if (!num_supported_hardware_watchpoints)
return true;
- if (num_supported_hardware_watchpoints == 0) {
-error.SetErrorStringWithFormat(
-"Target supports (%u) har
https://github.com/DavidSpickett requested changes to this pull request.
I think this function got a bit confused when we changed the return type to an
optional, thanks for taking a look at it.
https://github.com/llvm/llvm-project/pull/91882
___
lldb-
DavidSpickett wrote:
LLVM uses a GitHub setting where the PR is squashed, and the commit message is
taken from the PR description rather than the commits themselves. So all you
have to do here is copy the commit message you updated into the PR's
description.
https://github.com/llvm/llvm-proje
https://github.com/DavidSpickett approved this pull request.
LLDB changes look good to me.
https://github.com/llvm/llvm-project/pull/91857
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-co
https://github.com/DavidSpickett approved this pull request.
Makes sense to me. LLDB checks that the folder exists locally, which a remote
folder won't, so it's not in the JSON read back. And this test isn't doing
anything with the module cache itself, so any existing local path will do.
https
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/91915
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/91886
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
>So each ValueObject has the ability to show its value as an enumeration if its
>format is set to eFormatEnum. If the format is set to eFormatHex,
>eFormatUnsigned, or eFormatSigned, then we show the numeric value.
Sure, the problem I have is that often with registers you'
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/91923
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -2,7 +2,9 @@
Test platform process launch.
"""
+import lldb
DavidSpickett wrote:
Is this required?
https://github.com/llvm/llvm-project/pull/91923
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https:
@@ -78,6 +93,7 @@ def test_launch_via_vRun_no_args(self):
self.expect_gdbremote_sequence()
@add_test_categories(["llgs"])
+@skipIfRemote
DavidSpickett wrote:
Why is only this test skipped?
https://github.com/llvm/llvm-project/pull/91931
_
@@ -78,6 +93,7 @@ def test_launch_via_vRun_no_args(self):
self.expect_gdbremote_sequence()
@add_test_categories(["llgs"])
+@skipIfRemote
DavidSpickett wrote:
Ah, because we need to open the file while we attempt to run it, and doing that
on t
https://github.com/DavidSpickett approved this pull request.
LGTM
Surprised we haven't needed this before, but I didn't see any existing function
for it.
https://github.com/llvm/llvm-project/pull/91931
___
lldb-commits mailing list
lldb-commits@lists
@@ -108,6 +109,20 @@ def test_platform_file_wronly_fail(self):
)
self.expect_gdbremote_sequence()
+def remote_install(self, path, filename="test"):
+if lldb.remote_platform:
+remote_path = lldbutil.append_to_process_working_directory(sel
https://github.com/slydiman created
https://github.com/llvm/llvm-project/pull/91942
This test failed in case of Windows host and Linux target.
>From ae6c04bc568c88e41d348a1658fb44cff327ad6e Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Mon, 13 May 2024 14:10:55 +0400
Subject: [PATCH] [l
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dmitry Vasilyev (slydiman)
Changes
This test failed in case of Windows host and Linux target.
---
Full diff: https://github.com/llvm/llvm-project/pull/91942.diff
1 Files Affected:
- (modified)
lldb/test/API/macosx/duplicate-archive-memb
https://github.com/slydiman updated
https://github.com/llvm/llvm-project/pull/91923
>From 47839ef62cea9d1c79c97a70c4714f365eeb4e02 Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Mon, 13 May 2024 10:56:36 +0400
Subject: [PATCH 1/2] [lldb] Fixed the test TestPlatformProcessLaunch
Transfer
@@ -2,7 +2,9 @@
Test platform process launch.
"""
+import lldb
slydiman wrote:
This is a debug artifact. Removed now. Thanks.
https://github.com/llvm/llvm-project/pull/91923
___
lldb-commits mailing list
lldb-commi
labath wrote:
The `ifdef` in the generic code is not exactly ideal, and I'm wondering if we
should just do the same thing as Target::Install does (i.e., set the execute
flag unconditionally). Looking at the history, it appears that the
Target::Install code was [introduced](https://reviews.llvm
https://github.com/slydiman created
https://github.com/llvm/llvm-project/pull/91944
It can be used in tests #91918, #91931 and such.
>From de7135a8a4a40b5aa5ac1f44e58d62874c96448b Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Mon, 13 May 2024 14:45:33 +0400
Subject: [PATCH] [lldb] Add l
@@ -108,6 +109,20 @@ def test_platform_file_wronly_fail(self):
)
self.expect_gdbremote_sequence()
+def remote_install(self, path, filename="test"):
+if lldb.remote_platform:
+remote_path = lldbutil.append_to_process_working_directory(sel
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dmitry Vasilyev (slydiman)
Changes
It can be used in tests #91918, #91931 and such.
---
Full diff: https://github.com/llvm/llvm-project/pull/91944.diff
1 Files Affected:
- (modified) lldb/packages/Python/lldbsuite/test/lldbutil.py (+16)
slydiman wrote:
@DavidSpickett Please look at #91944.
https://github.com/llvm/llvm-project/pull/91931
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath wrote:
> Ah, I misunderstood what the nature of the failure was. I tried running the
> shell test, and it's failing for different reasons. I almost never touch
> shell tests, I find them really hard to debug so I'm not sure what the
> problem is. If I run it by hand,
>
> ```
> (lldb) s
https://github.com/labath approved this pull request.
Makes sense, although I think that slapping `@skipIfRemote` on the test would
work equally well. AFAICT, this test does not actually care about the remote
(or any other) platform, so there's very little value in running it in these
configur
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/91886
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath wrote:
This doesn't sound right. The archive format is a property of the target
system, not the host. It should still be possible to create these kinds of
linux archives, even when running on windows hosts (and vice versa: if we're
running on a linux host, then we won't be able to creat
Author: Muhammad Omair Javaid
Date: 2024-05-13T16:05:02+05:00
New Revision: 0a6103eaeb7f22c009f9add87c84780b6f7f293a
URL:
https://github.com/llvm/llvm-project/commit/0a6103eaeb7f22c009f9add87c84780b6f7f293a
DIFF:
https://github.com/llvm/llvm-project/commit/0a6103eaeb7f22c009f9add87c84780b6f7f29
Author: Muhammad Omair Javaid
Date: 2024-05-13T16:05:02+05:00
New Revision: 4b44502ac81259630b422e791a82e0252e6478c3
URL:
https://github.com/llvm/llvm-project/commit/4b44502ac81259630b422e791a82e0252e6478c3
DIFF:
https://github.com/llvm/llvm-project/commit/4b44502ac81259630b422e791a82e0252e6478
omjavaid wrote:
LLDB became unresponsive on windows when a `thread backtrace` command was
issued after hitting the exception
i have temporarily reverted the change to make buildbot green.
https://github.com/llvm/llvm-project/pull/91321
___
lldb-commi
labath wrote:
> LLDB became unresponsive on windows when a `thread backtrace` command was
> issued after hitting the exception i have temporarily reverted the change to
> make buildbot green.
Could you please give me some more information about the problem? I don't have
access to a windows ar
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/91923
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/91931
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/slydiman updated
https://github.com/llvm/llvm-project/pull/91944
>From de7135a8a4a40b5aa5ac1f44e58d62874c96448b Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Mon, 13 May 2024 14:45:33 +0400
Subject: [PATCH 1/2] [lldb] Add lldbutil.target_install() helper
It can be use
Author: Muhammad Omair Javaid
Date: 2024-05-13T16:53:15+05:00
New Revision: bc17361c2baa0351f7f19b716fbe76bc9f99e903
URL:
https://github.com/llvm/llvm-project/commit/bc17361c2baa0351f7f19b716fbe76bc9f99e903
DIFF:
https://github.com/llvm/llvm-project/commit/bc17361c2baa0351f7f19b716fbe76bc9f99e9
Author: Dmitry Vasilyev
Date: 2024-05-13T15:55:20+04:00
New Revision: 710d95d1ecb4b6d69507cb910274ef3077ddc9c9
URL:
https://github.com/llvm/llvm-project/commit/710d95d1ecb4b6d69507cb910274ef3077ddc9c9
DIFF:
https://github.com/llvm/llvm-project/commit/710d95d1ecb4b6d69507cb910274ef3077ddc9c9.dif
https://github.com/slydiman closed
https://github.com/llvm/llvm-project/pull/91915
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Dmitry Vasilyev
Date: 2024-05-13T15:58:39+04:00
New Revision: 7ce3dd49eb80816e3af52022ba2521b28a068c7b
URL:
https://github.com/llvm/llvm-project/commit/7ce3dd49eb80816e3af52022ba2521b28a068c7b
DIFF:
https://github.com/llvm/llvm-project/commit/7ce3dd49eb80816e3af52022ba2521b28a068c7b.dif
https://github.com/slydiman closed
https://github.com/llvm/llvm-project/pull/91886
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
zufuliu wrote:
> Why do we need to make this change?
https://docs.python.org/3/reference/lexical_analysis.html#escape-sequences
> Changed in version 3.12: Unrecognized escape sequences produce a
> [SyntaxWarning](https://docs.python.org/3/library/exceptions.html#SyntaxWarning).
> In a future
slydiman wrote:
Target::Install() and Platform::Install() are used indirectly in many cases.
For example look at the test
`lldb/test/API/python_api/hello_world/TestHelloWorld.py`. target.LaunchSimple()
uses Target::Install() and there is no problem with the exec permission.
spawnSubprocess()
https://github.com/slydiman closed
https://github.com/llvm/llvm-project/pull/91942
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
slydiman wrote:
Agreed. It seems the real problem is that `ar` is missing on the Windows host.
We will try to use cross `llvm-ar` instead. I will close this MR. Thanks.
https://github.com/llvm/llvm-project/pull/91942
___
lldb-commits mailing list
lldb
Author: Dmitry Vasilyev
Date: 2024-05-13T17:47:03+04:00
New Revision: 1a25b723628e439d62dfb28ca5fa52e4b2a78e5a
URL:
https://github.com/llvm/llvm-project/commit/1a25b723628e439d62dfb28ca5fa52e4b2a78e5a
DIFF:
https://github.com/llvm/llvm-project/commit/1a25b723628e439d62dfb28ca5fa52e4b2a78e5a.dif
https://github.com/slydiman closed
https://github.com/llvm/llvm-project/pull/91923
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1654,6 +1654,26 @@ def find_library_callable(test):
)
+def target_install(test, filename=None, path=None):
+test.assertTrue(filename or path, "filename or path must be specified.")
+if filename is None:
+filename = os.path.basename(path)
+if path i
@@ -1654,6 +1654,26 @@ def find_library_callable(test):
)
+def target_install(test, filename=None, path=None):
labath wrote:
This is optional, but I think something like `install_to_target` would be a
better match for the naming style of the surrounding
labath wrote:
SGTM. llvm-objcopy is already set in test/API/CMakeLists.txt:88. It should be
straightforward to add llvm-ar as well.
https://github.com/llvm/llvm-project/pull/91942
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists
labath wrote:
I'm not sure I'm following your reasoning. I'm not saying we should
replace/remove Target::Install. I'm saying we should make everything installed
by Platform::Install executable by default (which, by extension, includes
everything installed by Target::Install, because it delegat
https://github.com/aabhinavg updated
https://github.com/llvm/llvm-project/pull/91882
>From 9b4160975efe059f39a842689b1f750a10453203 Mon Sep 17 00:00:00 2001
From: aabhinavg
Date: Sun, 12 May 2024 12:42:59 +0530
Subject: [PATCH] Fix redundant condition in Target.cpp
This commit addresses issue
@@ -1654,6 +1654,26 @@ def find_library_callable(test):
)
+def target_install(test, filename=None, path=None):
+test.assertTrue(filename or path, "filename or path must be specified.")
+if filename is None:
+filename = os.path.basename(path)
+if path i
https://github.com/aabhinavg updated
https://github.com/llvm/llvm-project/pull/91882
>From 9b4160975efe059f39a842689b1f750a10453203 Mon Sep 17 00:00:00 2001
From: aabhinavg
Date: Sun, 12 May 2024 12:42:59 +0530
Subject: [PATCH 1/2] Fix redundant condition in Target.cpp
This commit addresses is
https://github.com/slydiman updated
https://github.com/llvm/llvm-project/pull/91944
>From de7135a8a4a40b5aa5ac1f44e58d62874c96448b Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Mon, 13 May 2024 14:45:33 +0400
Subject: [PATCH 1/3] [lldb] Add lldbutil.target_install() helper
It can be use
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/91985
We emit `ASTContext` and `TypeSystem` pointers into the `expr` log but there is
no easy way (that I know of) to correlate the pointer value back to an easily
readible form. This patch simply logs the name of
@@ -1654,6 +1654,26 @@ def find_library_callable(test):
)
+def target_install(test, filename=None, path=None):
slydiman wrote:
Updated. Thanks.
https://github.com/llvm/llvm-project/pull/91944
___
lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
We emit `ASTContext` and `TypeSystem` pointers into the `expr` log but there is
no easy way (that I know of) to correlate the pointer value back to an easily
readible form. This patch simply logs the name
https://github.com/slydiman edited
https://github.com/llvm/llvm-project/pull/91944
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/91989
This ensures that we log pointers as lower-case hex. E.g., instead of:
```
LayoutRecordType on (ASTContext*)0x00010E78D600 'scratch ASTContext' for
(RecordDecl*)0x00010E797
```
we now log:
```
Layout
https://github.com/feg208 updated
https://github.com/llvm/llvm-project/pull/91544
>From d01efd10f8a4b7d908acaa3237541bf6a83b4c7c Mon Sep 17 00:00:00 2001
From: Fred Grim
Date: Wed, 8 May 2024 15:36:16 -0700
Subject: [PATCH] [lldb] Adds additional fields to ProcessInfo
To implement SaveCore for
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/91989
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -86,4 +89,22 @@ TEST_F(HostTest, GetProcessInfo) {
ProcessInstanceInfo::timespec next_user_time = Info.GetUserTime();
ASSERT_TRUE(user_time.tv_sec <= next_user_time.tv_sec ||
user_time.tv_usec <= next_user_time.tv_usec);
+
+ struct rlimit rlim;
+ EXPECT_E
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
This ensures that we log pointers as lower-case hex. E.g., instead of:
```
LayoutRecordType on (ASTContext*)0x00010E78D600 'scratch ASTContext' for
(RecordDecl*)0x00010E797
```
we now log:
```
Lay
@@ -115,13 +124,19 @@ static bool GetStatusInfo(::pid_t Pid,
ProcessInstanceInfo &ProcessInfo,
return ts;
};
+ // priority (nice) values run from 19 to -20 inclusive (in linux). In the
+ // prpsinfo struct pr_nice is a char
feg208 wrote:
done
https:
@@ -115,13 +124,19 @@ static bool GetStatusInfo(::pid_t Pid,
ProcessInstanceInfo &ProcessInfo,
return ts;
};
+ // priority (nice) values run from 19 to -20 inclusive (in linux). In the
feg208 wrote:
done
https://github.com/llvm/llvm-project/pull/9154
@@ -70,6 +71,12 @@ struct StatFields {
long unsigned stime;
long cutime;
long cstime;
+ // in proc_pid_stat(5) this field is specified as priority
+ // but documented as realtime priority. To keep with the adopted
+ // nomenclature in ProcessInstanceInfo we adopt the d
@@ -70,6 +71,12 @@ struct StatFields {
long unsigned stime;
long cutime;
long cstime;
+ // in proc_pid_stat(5) this field is specified as priority
+ // but documented as realtime priority. To keep with the adopted
+ // nomenclature in ProcessInstanceInfo we adopt the d
@@ -70,6 +71,12 @@ struct StatFields {
long unsigned stime;
long cutime;
long cstime;
+ // in proc_pid_stat(5) this field is specified as priority
feg208 wrote:
done
https://github.com/llvm/llvm-project/pull/91544
__
feg208 wrote:
> Sorry for the nits! I am not smart enough to contribute on the technical
> merits, so I am trying to find some way to help!
Ehhh grammar is not where I shine. I rolled them up
https://github.com/llvm/llvm-project/pull/91544
___
lldb-c
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/91989
>From 1fba045db76f51a2dbd9a2a3cb9879858b5b653e Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Mon, 13 May 2024 14:50:07 +0100
Subject: [PATCH 1/2] [lldb][ExpressionParser][NFCI] Log pointers as hex
This en
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff abd314938dda1b117f289be5e630e43e68533929
1fba045db76f51a2dbd9a2a3cb9879858b5b653e --
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/91985
>From 1ccf935f97b21e0bd87955f3313cb47261d11379 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Mon, 13 May 2024 15:34:24 +0100
Subject: [PATCH 1/2] [lldb][TypeSystem][NFCI] Log creation of new TypeSystem
in
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/91985
>From 1ccf935f97b21e0bd87955f3313cb47261d11379 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Mon, 13 May 2024 15:34:24 +0100
Subject: [PATCH 1/3] [lldb][TypeSystem][NFCI] Log creation of new TypeSystem
in
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/91989
>From 1fba045db76f51a2dbd9a2a3cb9879858b5b653e Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Mon, 13 May 2024 14:50:07 +0100
Subject: [PATCH 1/3] [lldb][ExpressionParser][NFCI] Log pointers as hex
This en
@@ -147,96 +148,111 @@ class ProcessInstanceInfo : public ProcessInfo {
ProcessInstanceInfo() = default;
ProcessInstanceInfo(const char *name, const ArchSpec &arch, lldb::pid_t pid)
- : ProcessInfo(name, arch, pid), m_euid(UINT32_MAX), m_egid(UINT32_MAX),
-m_p
@@ -731,8 +747,11 @@ class Debugger : public
std::enable_shared_from_this,
lldb::TargetSP m_dummy_target_sp;
Diagnostics::CallbackID m_diagnostics_callback_id;
- lldb_private::DebuggerDestroyCallback m_destroy_callback = nullptr;
- void *m_destroy_callback_baton = nullp
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/89868
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/slydiman updated
https://github.com/llvm/llvm-project/pull/91944
>From de7135a8a4a40b5aa5ac1f44e58d62874c96448b Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Mon, 13 May 2024 14:45:33 +0400
Subject: [PATCH 1/4] [lldb] Add lldbutil.target_install() helper
It can be use
@@ -1654,6 +1654,26 @@ def find_library_callable(test):
)
+def target_install(test, filename=None, path=None):
+test.assertTrue(filename or path, "filename or path must be specified.")
+if filename is None:
+filename = os.path.basename(path)
+if path i
hawkinsw wrote:
> > Sorry for the nits! I am not smart enough to contribute on the technical
> > merits, so I am trying to find some way to help!
>
> Ehhh grammar is not where I shine. I rolled them up
Not at all! I thought the comments were really excellent and helpful! I just
wanted to help
@@ -147,96 +148,111 @@ class ProcessInstanceInfo : public ProcessInfo {
ProcessInstanceInfo() = default;
ProcessInstanceInfo(const char *name, const ArchSpec &arch, lldb::pid_t pid)
- : ProcessInfo(name, arch, pid), m_euid(UINT32_MAX), m_egid(UINT32_MAX),
-m_p
https://github.com/bulbazord approved this pull request.
LGTM
The PR summary is empty, but it looks like the commit message has an
explanation for this change, so that's fine.
https://github.com/llvm/llvm-project/pull/91858
___
lldb-commits mailing l
https://github.com/feg208 updated
https://github.com/llvm/llvm-project/pull/91544
>From dbb4b4126754be15ffd9d12d9997e4969f7ba5cf Mon Sep 17 00:00:00 2001
From: Fred Grim
Date: Wed, 8 May 2024 15:36:16 -0700
Subject: [PATCH] [lldb] Adds additional fields to ProcessInfo
To implement SaveCore for
https://github.com/bulbazord approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/91989
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/91985
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond created
https://github.com/llvm/llvm-project/pull/92002
Currently in Core dumps, the entire pthread is copied, including the unused
space beyond the stack pointer. This causes large amounts of core dump
inflation when the number of threads is high, but the stack usag
Jlalond wrote:
@clayborg Could you take a look at this?
https://github.com/llvm/llvm-project/pull/92002
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jacob Lalonde (Jlalond)
Changes
Currently in Core dumps, the entire pthread is copied, including the unused
space beyond the stack pointer. This causes large amounts of core dump
inflation when the number of threads is high, but the stack
@@ -6410,12 +6410,20 @@ GetCoreFileSaveRangesStackOnly(Process &process,
if (!reg_ctx_sp)
continue;
const addr_t sp = reg_ctx_sp->GetSP();
+const size_t red_zone = process.GetABI()->GetRedZoneSize();
bulbazord wrote:
Asking for my understandi
jasonmolenda wrote:
> It's not completely correct -- the frame for `signal_generating_add` is
> missing. That's what the error message is complaining about.
Ah, thanks, I missed that! Let me debug it and comment further
https://github.com/llvm/llvm-project/pull/91321
_
@@ -6410,12 +6410,20 @@ GetCoreFileSaveRangesStackOnly(Process &process,
if (!reg_ctx_sp)
continue;
const addr_t sp = reg_ctx_sp->GetSP();
+const size_t red_zone = process.GetABI()->GetRedZoneSize();
Jlalond wrote:
Correct, but on systems whe
https://github.com/jeffreytan81 requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/89868
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1689,35 +1689,56 @@ void
SBDebugger::SetLoggingCallback(lldb::LogOutputCallback log_callback,
void SBDebugger::SetDestroyCallback(
lldb::SBDebuggerDestroyCallback destroy_callback, void *baton) {
LLDB_INSTRUMENT_VA(this, destroy_callback, baton);
+
if (m_opaque_sp
@@ -743,9 +743,28 @@ DebuggerSP
Debugger::CreateInstance(lldb::LogOutputCallback log_callback,
}
void Debugger::HandleDestroyCallback() {
- if (m_destroy_callback) {
-m_destroy_callback(GetID(), m_destroy_callback_baton);
-m_destroy_callback = nullptr;
+ std::lock_g
1 - 100 of 201 matches
Mail list logo
