https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/90183
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: David Spickett
Date: 2024-04-29T08:40:09+01:00
New Revision: 41942c852e2be6c7c37f41e5128d446182fc9763
URL:
https://github.com/llvm/llvm-project/commit/41942c852e2be6c7c37f41e5128d446182fc9763
DIFF:
https://github.com/llvm/llvm-project/commit/41942c852e2be6c7c37f41e5128d446182fc9763.diff
al45tair wrote:
> I saw that, but a textual test is definitely preferable, particularly after
> the linux xz fiasco. This wouldn't be the first test binary in our repo, but
> in this case, I think it actually adds a lot of value, since yaml2obj
> operates on the same level as what you are test
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/90443
This removes various subtitles or converts them to bold text so that the table
of contents is less cluttered.
This includes "Example", "Notes", "Priority To Implement" and "Response".
>From 7810ba3e09ef94
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: David Spickett (DavidSpickett)
Changes
This removes various subtitles or converts them to bold text so that the table
of contents is less cluttered.
This includes "Example", "Notes", "Priority To Implement" and "Response".
---
Patch is 3
DavidSpickett wrote:
After this I am going to sort the entries into alphabetical order and split out
the ones that are extensions to existing packets - then I should be done with
this doc :)
https://github.com/llvm/llvm-project/pull/90443
___
lldb-co
Author: David Spickett
Date: 2024-04-29T11:41:14+01:00
New Revision: 0c8151ac809c283187e9b19d0cbe72a09c8d74e0
URL:
https://github.com/llvm/llvm-project/commit/0c8151ac809c283187e9b19d0cbe72a09c8d74e0
DIFF:
https://github.com/llvm/llvm-project/commit/0c8151ac809c283187e9b19d0cbe72a09c8d74e0.diff
https://github.com/al45tair updated
https://github.com/llvm/llvm-project/pull/90099
>From ce54a7fb339a00029da266c9f518e344aac5d19e Mon Sep 17 00:00:00 2001
From: Alastair Houghton
Date: Thu, 25 Apr 2024 11:35:55 +0100
Subject: [PATCH 1/4] [LLDB][ELF] Fix section unification to not just use
nam
@@ -1854,6 +1854,49 @@ class VMAddressProvider {
};
}
+namespace {
+ // We have to do this because ELF doesn't have section IDs, and also
+ // doesn't require section names to be unique. (We use the section index
+ // for section IDs, but that isn't guaranteed to be the sa
labath wrote:
> > I saw that, but a textual test is definitely preferable, particularly after
> > the linux xz fiasco. This wouldn't be the first test binary in our repo,
> > but in this case, I think it actually adds a lot of value, since yaml2obj
> > operates on the same level as what you ar
https://github.com/al45tair updated
https://github.com/llvm/llvm-project/pull/90099
>From ce54a7fb339a00029da266c9f518e344aac5d19e Mon Sep 17 00:00:00 2001
From: Alastair Houghton
Date: Thu, 25 Apr 2024 11:35:55 +0100
Subject: [PATCH 1/5] [LLDB][ELF] Fix section unification to not just use
nam
@@ -1854,6 +1854,49 @@ class VMAddressProvider {
};
}
+namespace {
+ // We have to do this because ELF doesn't have section IDs, and also
+ // doesn't require section names to be unique. (We use the section index
+ // for section IDs, but that isn't guaranteed to be the sa
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/89981
>From 19cfcf3230d02a93a907fe93ca95dbecd48bcaf9 Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Wed, 24 Apr 2024 12:50:43 -0700
Subject: [PATCH] Add a new SBExpressionOptions::SetLanguage() API (NFCI)
th
@@ -10,6 +10,7 @@ config.llvm_build_mode =
lit_config.substitute("@LLVM_BUILD_MODE@")
config.lit_tools_dir = "@LLVM_LIT_TOOLS_DIR@"
config.lldb_obj_root = "@LLDB_BINARY_DIR@"
config.lldb_src_root = "@LLDB_SOURCE_DIR@"
+config.lldb_built_include_dir =
lit_config.substitute("@L
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/89981
>From 6d91ad848b73183268617fecf14255b0ba0b9dd8 Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Wed, 24 Apr 2024 12:50:43 -0700
Subject: [PATCH] Add a new SBExpressionOptions::SetLanguage() API (NFCI)
th
https://github.com/JDevlieghere approved this pull request.
Thanks for bearing with me! LGTM.
https://github.com/llvm/llvm-project/pull/89981
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/90294
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
bulbazord wrote:
I think your commit summary has a typo. It should say that the parameter
defaults to false, not true.
https://github.com/llvm/llvm-project/pull/90297
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi
https://github.com/bulbazord commented:
This change does 2 things, both of which are quite substantial on their own.
Can you break them up into two changes to make it easier to review?
Higher level feedback:
Please add some documentation for these new changes. The change to dotest.py is
minor
bulbazord wrote:
> > Please update the PR subject as its a lot more than just X86AsmParser.cpp
>
> Hi @RKSimon
>
> All the issues mentioned are fixed. The title of the PR is misleading. The
> title is the same as the issue (#85868) it corresponds to. Got a look to
> other PR's and I thought t
https://github.com/ldionne approved this pull request.
The libc++abi changes look fine to me.
https://github.com/llvm/llvm-project/pull/90391
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb
lntue wrote:
> #85868
You can update the title of the PR to reflect the changes, and add `Fixes
https://github.com/llvm/llvm-project/issues/85868` to relating the PR to the
issue.
OTOH, the libc changes look good to me.
https://github.com/llvm/llvm-project/pull/90391
JDevlieghere wrote:
I'm curious to understand the motivation behind this a bit more. Specifically,
how are the JSON files different from creating separate `lit.site.cfg.py` for
the different test suite? Downstream we generate separate separate
`lit.site.cfg.py` for different test runs, and the
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/89981
>From ea06aa4664b9b47b3cb11ec27774b9a0d109f92f Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Wed, 24 Apr 2024 12:50:43 -0700
Subject: [PATCH] Add a new SBExpressionOptions::SetLanguage() API (NFCI)
th
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/89981
>From 00fdda9a57660533c5a97223bd52619b36f8999c Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Wed, 24 Apr 2024 12:50:43 -0700
Subject: [PATCH] Add a new SBExpressionOptions::SetLanguage() API (NFCI)
th
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/89981
>From c4b1ff6c92126ebf721b6044088b05112ec98477 Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Wed, 24 Apr 2024 12:50:43 -0700
Subject: [PATCH] Add a new SBExpressionOptions::SetLanguage() API (NFCI)
th
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/89981
>From 34eda7b484e3fa9eaaf97c66af3e81bf337e6edd Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Wed, 24 Apr 2024 12:50:43 -0700
Subject: [PATCH] Add a new SBExpressionOptions::SetLanguage() API (NFCI)
th
@@ -743,9 +743,19 @@ DebuggerSP
Debugger::CreateInstance(lldb::LogOutputCallback log_callback,
}
void Debugger::HandleDestroyCallback() {
- if (m_destroy_callback) {
-m_destroy_callback(GetID(), m_destroy_callback_baton);
-m_destroy_callback = nullptr;
+ std::lock_g
https://github.com/adrian-prantl closed
https://github.com/llvm/llvm-project/pull/89981
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Adrian Prantl
Date: 2024-04-29T13:26:24-07:00
New Revision: 975eca0e6a3459e59e96b0df33ea0cfbd157c597
URL:
https://github.com/llvm/llvm-project/commit/975eca0e6a3459e59e96b0df33ea0cfbd157c597
DIFF:
https://github.com/llvm/llvm-project/commit/975eca0e6a3459e59e96b0df33ea0cfbd157c597.diff
@@ -743,9 +743,19 @@ DebuggerSP
Debugger::CreateInstance(lldb::LogOutputCallback log_callback,
}
void Debugger::HandleDestroyCallback() {
- if (m_destroy_callback) {
-m_destroy_callback(GetID(), m_destroy_callback_baton);
-m_destroy_callback = nullptr;
+ std::lock_g
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/90443
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Adrian Prantl
Date: 2024-04-29T13:37:37-07:00
New Revision: 35fa46a56ae2a220de514e5de5c5e6b4607f5ebb
URL:
https://github.com/llvm/llvm-project/commit/35fa46a56ae2a220de514e5de5c5e6b4607f5ebb
DIFF:
https://github.com/llvm/llvm-project/commit/35fa46a56ae2a220de514e5de5c5e6b4607f5ebb.diff
https://github.com/royitaqi updated
https://github.com/llvm/llvm-project/pull/89868
>From 079a550481d4cdcb69ad01c376b5e1f0632a07d6 Mon Sep 17 00:00:00 2001
From: Roy Shi
Date: Tue, 23 Apr 2024 18:10:21 -0700
Subject: [PATCH 01/13] Allow multiple destroy callbacks in
`SBDebugger::SetDestroyCall
@@ -743,9 +743,19 @@ DebuggerSP
Debugger::CreateInstance(lldb::LogOutputCallback log_callback,
}
void Debugger::HandleDestroyCallback() {
- if (m_destroy_callback) {
-m_destroy_callback(GetID(), m_destroy_callback_baton);
-m_destroy_callback = nullptr;
+ std::lock_g
Author: Adrian Prantl
Date: 2024-04-29T15:08:49-07:00
New Revision: 028546cce2316a1074aa27001450295d856e1fdc
URL:
https://github.com/llvm/llvm-project/commit/028546cce2316a1074aa27001450295d856e1fdc
DIFF:
https://github.com/llvm/llvm-project/commit/028546cce2316a1074aa27001450295d856e1fdc.diff
https://github.com/adrian-prantl created
https://github.com/llvm/llvm-project/pull/90531
using the macOS version as a proxy. I can't reproduce any of these failures
locally, but the tests all use pexpect and probably have bad timeout behavior
under high load.
>From 46d19cc3211fa6e27f7e4923877
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Adrian Prantl (adrian-prantl)
Changes
using the macOS version as a proxy. I can't reproduce any of these failures
locally, but the tests all use pexpect and probably have bad timeout behavior
under high load.
---
Full diff: https://github
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/90531
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
975eca0e6a3459e59e96b0df33ea0cfbd157c597...46d19cc3211fa6e27f7e49238777e533c0a173bc
lldb/
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/90531
>From 34aaec09e03d0da6b2d511708fb3fe3e71b29c55 Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Mon, 29 Apr 2024 15:38:25 -0700
Subject: [PATCH] Skip various tests under ASAN on green dragon
using the ma
https://github.com/adrian-prantl closed
https://github.com/llvm/llvm-project/pull/90531
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Adrian Prantl
Date: 2024-04-29T15:56:41-07:00
New Revision: 1b70580dd867195b0442e582eccd42abc41ee12d
URL:
https://github.com/llvm/llvm-project/commit/1b70580dd867195b0442e582eccd42abc41ee12d
DIFF:
https://github.com/llvm/llvm-project/commit/1b70580dd867195b0442e582eccd42abc41ee12d.diff
@@ -287,8 +291,52 @@ bool
lldb_private::formatters::LibStdcppStringSummaryProvider(
} else
return true;
} break;
-case eAddressTypeHost:
- break;
+case eAddressTypeHost: {
+
+ DataExtractor data;
+ Status error;
+ valobj.GetData(da
@@ -254,13 +254,17 @@ bool
lldb_private::formatters::LibStdcppStringSummaryProvider(
} else
addr_of_string =
valobj.GetAddressOf(scalar_is_load_addr, &addr_type);
- if (addr_of_string != LLDB_INVALID_ADDRESS) {
+
+ // We have to check for host address here
+ /
@@ -287,8 +291,52 @@ bool
lldb_private::formatters::LibStdcppStringSummaryProvider(
} else
return true;
} break;
-case eAddressTypeHost:
- break;
+case eAddressTypeHost: {
+
+ DataExtractor data;
+ Status error;
+ valobj.GetData(da
@@ -287,8 +291,52 @@ bool
lldb_private::formatters::LibStdcppStringSummaryProvider(
} else
return true;
} break;
-case eAddressTypeHost:
- break;
+case eAddressTypeHost: {
+
+ DataExtractor data;
+ Status error;
+ valobj.GetData(da
@@ -287,8 +291,52 @@ bool
lldb_private::formatters::LibStdcppStringSummaryProvider(
} else
return true;
} break;
-case eAddressTypeHost:
- break;
+case eAddressTypeHost: {
+
+ DataExtractor data;
+ Status error;
+ valobj.GetData(da
https://github.com/kastiglione edited
https://github.com/llvm/llvm-project/pull/90297
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/90294
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -685,7 +686,7 @@ bool Address::Dump(Stream *s, ExecutionContextScope
*exe_scope, DumpStyle style,
sc.DumpStopContext(s, exe_scope, *this, show_fullpaths,
show_module, show_inlined_frames,
show_f
kastiglione wrote:
@jimingham I'm not sure I've understood your comment entirely. Are you saying
the following?
1. Always use `GetDisplayName` when displaying a mangled name
2. Add a setting allowing the user to see `GetName` (which `GetDisplayName`
will call whenever the setting is enabled)
@@ -685,7 +686,7 @@ bool Address::Dump(Stream *s, ExecutionContextScope
*exe_scope, DumpStyle style,
sc.DumpStopContext(s, exe_scope, *this, show_fullpaths,
show_module, show_inlined_frames,
show_f
@@ -287,8 +291,52 @@ bool
lldb_private::formatters::LibStdcppStringSummaryProvider(
} else
return true;
} break;
-case eAddressTypeHost:
- break;
+case eAddressTypeHost: {
+
+ DataExtractor data;
+ Status error;
+ valobj.GetData(da
@@ -254,13 +254,17 @@ bool
lldb_private::formatters::LibStdcppStringSummaryProvider(
} else
addr_of_string =
valobj.GetAddressOf(scalar_is_load_addr, &addr_type);
- if (addr_of_string != LLDB_INVALID_ADDRESS) {
+
+ // We have to check for host address here
+ /
https://github.com/jasonmolenda created
https://github.com/llvm/llvm-project/pull/90533
The most common case with address masks/addressable bits is that we have one
value/mask that applies across the entire address space, for code and data. On
AArch64, we can have separate masks for high and
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jason Molenda (jasonmolenda)
Changes
The most common case with address masks/addressable bits is that we have one
value/mask that applies across the entire address space, for code and data. On
AArch64, we can have separate masks for high
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/90533
>From 3c272e99326a287f0a61c1f8c2c7ee790e1aeb48 Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Mon, 29 Apr 2024 16:45:36 -0700
Subject: [PATCH 1/2] [lldb] Be conversative about setting highmem address
ma
58 matches
Mail list logo
