[Lldb-commits] [lldb] 62db434 - [lldb] Enable support for Markdown documentation pages (#89716)

2024-04-24 Thread via lldb-commits
Author: David Spickett Date: 2024-04-24T09:08:31+01:00 New Revision: 62db43497fb019d0ac0677ae0c9ea2eba136b230 URL: https://github.com/llvm/llvm-project/commit/62db43497fb019d0ac0677ae0c9ea2eba136b230 DIFF: https://github.com/llvm/llvm-project/commit/62db43497fb019d0ac0677ae0c9ea2eba136b230.diff

[Lldb-commits] [lldb] [lldb] Enable support for Markdown documentation pages (PR #89716)

2024-04-24 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/89716 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Docs] Convert GDB protocol extensions doc to Markdown and add to website (PR #89718)

2024-04-24 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/89718 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][tests] Add ability to run API tests with qemu-user simulator (PR #89765)

2024-04-24 Thread via lldb-commits
https://github.com/ita-sc updated https://github.com/llvm/llvm-project/pull/89765 >From 3d95e1f223eb7ccdd5b382d8d5e47d98421cc870 Mon Sep 17 00:00:00 2001 From: Ivan Tetyushkin Date: Thu, 11 Apr 2024 12:22:19 +0300 Subject: [PATCH] [lldb][tests] Add ability to run API tests with qemu-user simul

[Lldb-commits] [lldb] [lldb][Docs] Convert platform packets doc to Markdown (PR #89913)

2024-04-24 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/89913 As before, script did most of the work, hand edits after that. There's a lot more we can do dedupe this and the packets doc, this will come in a follow up PR. >From d9b8ee42dfb753012f2f7032d7fb2dfde3e440f

[Lldb-commits] [lldb] [lldb] Add SB API to access static constexpr member values (PR #89730)

2024-04-24 Thread Pavel Labath via lldb-commits
https://github.com/labath updated https://github.com/llvm/llvm-project/pull/89730 >From 091db4a89de2678fbdcc2db3051f34eeb8cc0cf2 Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Tue, 23 Apr 2024 08:50:31 + Subject: [PATCH 1/3] [lldb] Add SB API to access static constexpr member values Th

[Lldb-commits] [lldb] [lldb][Docs] Convert platform packets doc to Markdown (PR #89913)

2024-04-24 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) Changes As before, script did most of the work, hand edits after that. There's a lot more we can do dedupe this and the packets doc, this will come in a follow up PR. --- Patch is 27.19 KiB, truncated to 20

[Lldb-commits] [lldb] [lldb] Add SB API to access static constexpr member values (PR #89730)

2024-04-24 Thread Pavel Labath via lldb-commits
@@ -325,6 +330,79 @@ lldb::SBTypeMemberFunction SBType::GetMemberFunctionAtIndex(uint32_t idx) { return sb_func_type; } +SBTypeStaticField::SBTypeStaticField() { LLDB_INSTRUMENT_VA(this); } + +SBTypeStaticField::SBTypeStaticField(lldb_private::CompilerDecl decl) +: m_op

[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [flang] [lld] [lldb] [llvm] [mlir] [openmp] [pstl] Finally formalise our defacto line-ending policy (PR #86318)

2024-04-24 Thread via lldb-commits
ldrumm wrote: I've added the natvis changes and added a couple of clangd test exceptions. For the sanity of pending reviewers, and to make rebasing this trivial I've split this into two commits: the gitattributes changes, followed by the `--renormalize` fixup. For downstreams, I'm considering

[Lldb-commits] [lldb] [lldb] fix python extension debug suffix on Win (PR #89037)

2024-04-24 Thread Alexander M. via lldb-commits
https://github.com/amordo updated https://github.com/llvm/llvm-project/pull/89037 >From afb03ec26f847a03d0a4439f49c4ae99f2a08f0a Mon Sep 17 00:00:00 2001 From: Alexander Mordovskiy Date: Wed, 24 Apr 2024 15:47:40 +0200 Subject: [PATCH] [lldb] check python extension debug suffix on Win ae389b24

[Lldb-commits] [lldb] [lldb] fix python extension debug suffix on Win (PR #89037)

2024-04-24 Thread Alexander M. via lldb-commits
https://github.com/amordo updated https://github.com/llvm/llvm-project/pull/89037 >From 3711ce61bf34bae7e9f4e614692978e0cd3e2d94 Mon Sep 17 00:00:00 2001 From: Alexander Mordovskiy Date: Wed, 24 Apr 2024 15:48:41 +0200 Subject: [PATCH] [lldb] check python extension debug suffix on Win ae389b24

[Lldb-commits] [lldb] [lldb] fix python extension debug suffix on Win (PR #89037)

2024-04-24 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. LGTM I can merge this for you if you don't have commit access, otherwise go ahead and merge it yourself. https://github.com/llvm/llvm-project/pull/89037 ___ lldb-commits mailing list lldb-c

[Lldb-commits] [lldb] [lldb] fix python extension debug suffix on Win (PR #89037)

2024-04-24 Thread Alexander M. via lldb-commits
amordo wrote: @DavidSpickett I have no write privilege, so, please, merge it:) https://github.com/llvm/llvm-project/pull/89037 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] e0adf63 - [lldb] fix python extension debug suffix on Win (#89037)

2024-04-24 Thread via lldb-commits
Author: Alexander M Date: 2024-04-24T16:04:30+01:00 New Revision: e0adf63afc33a1e7fd4494c4f327d5ee4082b393 URL: https://github.com/llvm/llvm-project/commit/e0adf63afc33a1e7fd4494c4f327d5ee4082b393 DIFF: https://github.com/llvm/llvm-project/commit/e0adf63afc33a1e7fd4494c4f327d5ee4082b393.diff L

[Lldb-commits] [lldb] [lldb] fix python extension debug suffix on Win (PR #89037)

2024-04-24 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/89037 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [clang-tools-extra] [compiler-rt] [flang] [lld] [lldb] [llvm] [mlir] [openmp] [pstl] Finally formalise our defacto line-ending policy (PR #86318)

2024-04-24 Thread Chris B via lldb-commits
https://github.com/llvm-beanz approved this pull request. I'm happy with this approach. We can adjust and iteratively address issues if any appear. https://github.com/llvm/llvm-project/pull/86318 ___ lldb-commits mailing list lldb-commits@lists.llvm.o

[Lldb-commits] [lldb] [lldb][test] Remove restriction for remote working directory (PR #89768)

2024-04-24 Thread via lldb-commits
https://github.com/ita-sc updated https://github.com/llvm/llvm-project/pull/89768 >From 817cc08f60ba2ed74e6185c8e04ebf460631141f Mon Sep 17 00:00:00 2001 From: Ivan Tetyushkin Date: Thu, 11 Apr 2024 11:52:48 +0300 Subject: [PATCH] [lldb][test] Make remote directory optional for remote targets

[Lldb-commits] [lldb] [lldb][test] Remove restriction for remote working directory (PR #89768)

2024-04-24 Thread via lldb-commits
https://github.com/ita-sc edited https://github.com/llvm/llvm-project/pull/89768 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] I left some commented code in. This test doesn't run reliably in the different build bots (PR #89637)

2024-04-24 Thread Fred Grim via lldb-commits
https://github.com/feg208 updated https://github.com/llvm/llvm-project/pull/89637 >From 9ef4220b01a9cb18c3f23b78ae7aa3b80c2a7851 Mon Sep 17 00:00:00 2001 From: Fred Grim Date: Mon, 22 Apr 2024 10:17:14 -0700 Subject: [PATCH] I left some commented code in. This test doesn't run reliably in the

[Lldb-commits] [lldb] I left some commented code in. This test doesn't run reliably in the different build bots (PR #89637)

2024-04-24 Thread Fred Grim via lldb-commits
feg208 wrote: > Hi @feg208 , I noticed that your [previous commit > ](https://github.com/llvm/llvm-project/pull/89267) has a very.. unusual > commit title and message. The same thing applies to this PR. > > I'd appreciate it if you could follow a more standard commit title and > message, so t

[Lldb-commits] [lldb] [lldb][test] Remove restriction for remote working directory (PR #89768)

2024-04-24 Thread via lldb-commits
ita-sc wrote: > Based on the description it's not entirely clear to me what exactly you're > trying to achieve. You don't have a working directory, but presumably you > still have a platform name and a platform URL? In other words, I assume you > want to go into the `if configuration.lldb_plat

[Lldb-commits] [lldb] I left some commented code in. This test doesn't run reliably in the different build bots (PR #89637)

2024-04-24 Thread Fred Grim via lldb-commits
https://github.com/feg208 updated https://github.com/llvm/llvm-project/pull/89637 >From bd0416d37d61e71f36e9afc435f9209b544bdb78 Mon Sep 17 00:00:00 2001 From: Fred Grim Date: Mon, 22 Apr 2024 10:17:14 -0700 Subject: [PATCH] [lldb] Reenable test HostTest.GetProcessInfo with relaxed constraints

[Lldb-commits] [lldb] [lldb] Reenable test HostTest.GetProcessInfo with relaxed constraints This test was commented out which, besides being bad form, disabled the test entirely. But we do want to val

2024-04-24 Thread Fred Grim via lldb-commits
https://github.com/feg208 edited https://github.com/llvm/llvm-project/pull/89637 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Reenable test HostTest.GetProcessInfo with relaxed constraints. (PR #89637)

2024-04-24 Thread Fred Grim via lldb-commits
https://github.com/feg208 edited https://github.com/llvm/llvm-project/pull/89637 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Reenable test HostTest.GetProcessInfo with relaxed constraints. (PR #89637)

2024-04-24 Thread Fred Grim via lldb-commits
https://github.com/feg208 updated https://github.com/llvm/llvm-project/pull/89637 >From edc21c6ec34486b6155ef0ec6f6be97a9bd0f0bb Mon Sep 17 00:00:00 2001 From: Fred Grim Date: Mon, 22 Apr 2024 10:17:14 -0700 Subject: [PATCH] [lldb] Reenable test HostTest.GetProcessInfo with relaxed constraints

[Lldb-commits] [lldb] Allow multiple destroy callbacks in `SBDebugger::SetDestroyCallback()` (PR #89868)

2024-04-24 Thread via lldb-commits
jimingham wrote: I would also find it surprising if "SetDestroyCallback" did "AddDestroyCallback". That's not what the name says it does. I have no problem with supporting multiple Destroy callbacks. But I agree with Jonas, that needs to be a separate API with an appropriate name. And also

[Lldb-commits] [lldb] [lldb] Reenable test HostTest.GetProcessInfo with relaxed constraints. (PR #89637)

2024-04-24 Thread Fred Grim via lldb-commits
https://github.com/feg208 updated https://github.com/llvm/llvm-project/pull/89637 >From 41175787b1f5d1451d5ea88618ca6c229a415c0f Mon Sep 17 00:00:00 2001 From: Fred Grim Date: Mon, 22 Apr 2024 10:17:14 -0700 Subject: [PATCH] [lldb] Reenable test HostTest.GetProcessInfo with relaxed constraints

[Lldb-commits] [lldb] Allow multiple destroy callbacks in `SBDebugger::SetDestroyCallback()` (PR #89868)

2024-04-24 Thread via lldb-commits
royitaqi wrote: Thank you, @JDevlieghere and @jimingham for the input. IIUR, you are basically advocating for the following alternative approach (that was mentioned in the "Alternatives considered" section in the above): > Instead of changing SetDestroyCallback(), a new method AddDestroyCallba

[Lldb-commits] [lldb] [lldb][Docs] Convert platform packets doc to Markdown (PR #89913)

2024-04-24 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM. PS: I was looking at the website and I wonder if we should remove all the "Brief" subtitles and put the brief description right under the packet name. I don't think the subtitle adds much. If you agree, this can be done in a s

[Lldb-commits] [lldb] [lldb-dap] Report exit status message in lldb-dap, same as lldb cli (PR #89405)

2024-04-24 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/89405 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 5779483 - [lldb][nfc] Move broadcaster class strings away from ConstString (#89690)

2024-04-24 Thread via lldb-commits
Author: Alex Langford Date: 2024-04-24T12:13:18-07:00 New Revision: 57794835279669358ff2828d659eb7133fc0e4bf URL: https://github.com/llvm/llvm-project/commit/57794835279669358ff2828d659eb7133fc0e4bf DIFF: https://github.com/llvm/llvm-project/commit/57794835279669358ff2828d659eb7133fc0e4bf.diff

[Lldb-commits] [lldb] [lldb][nfc] Move broadcaster class strings away from ConstString (PR #89690)

2024-04-24 Thread Alex Langford via lldb-commits
https://github.com/bulbazord closed https://github.com/llvm/llvm-project/pull/89690 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Summarize std::string's when created from data. (PR #89110)

2024-04-24 Thread via lldb-commits
jimingham wrote: > @jimingham > > What should we do if the child address type is File? I don't know how that > could ever happen, and should we support it? Because currently we didn't > support summarizing host or file. It doesn't look like C++ allows you to make `constexpr` std::strings, so

[Lldb-commits] [lldb] Allow multiple destroy callbacks in `SBDebugger::SetDestroyCallback()` (PR #89868)

2024-04-24 Thread via lldb-commits
jimingham wrote: I don't have a strong preference for new PR vrs. reuse this one. https://github.com/llvm/llvm-project/pull/89868 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][docs] Update instructions for debugging API tests (PR #89979)

2024-04-24 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova created https://github.com/llvm/llvm-project/pull/89979 This adds the option to use the `breakpoint()` keyword as a way to debug the API tests. >From f1a0a1bc059e133d2e00157ce58b2cbda4904fab Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Wed, 24 Apr 20

[Lldb-commits] [lldb] [lldb][docs] Update instructions for debugging API tests (PR #89979)

2024-04-24 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Chelsea Cassanova (chelcassanova) Changes This adds the option to use the `breakpoint()` keyword as a way to debug the API tests. --- Full diff: https://github.com/llvm/llvm-project/pull/89979.diff 1 Files Affected: - (modified) lldb/do

[Lldb-commits] [lldb] Add a new SBExpressionOptions::SetLanguage() API (NFCI) (PR #89981)

2024-04-24 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl created https://github.com/llvm/llvm-project/pull/89981 that separates out language and version. To avoid reinventing the wheel and introducing subtle incompatibilities, this API uses the table of languages and versiond defined by the upcoming DWARF 6 standard

[Lldb-commits] [lldb] Add a new SBExpressionOptions::SetLanguage() API (NFCI) (PR #89981)

2024-04-24 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Adrian Prantl (adrian-prantl) Changes that separates out language and version. To avoid reinventing the wheel and introducing subtle incompatibilities, this API uses the table of languages and versiond defined by the upcoming DWARF 6 stand

[Lldb-commits] [lldb] Add a new SBExpressionOptions::SetLanguage() API (NFCI) (PR #89981)

2024-04-24 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 9e9595183001991a7d31d8880c4a2b33594ca30f 7e63653359ee0cfe251091017a4265aaea3770e3 --

[Lldb-commits] [lldb] Summarize std::string's when created from data. (PR #89110)

2024-04-24 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/89110 >From e0316188d22605c670079e37855d3d8b5c944cee Mon Sep 17 00:00:00 2001 From: Jacob John Lalonde Date: Wed, 10 Apr 2024 14:33:40 -0700 Subject: [PATCH 1/3] Fix bug where an sbvalue containing a std::string create

[Lldb-commits] [lldb] [lldb][Docs] Convert platform packets doc to Markdown (PR #89913)

2024-04-24 Thread Will Hawkins via lldb-commits
https://github.com/hawkinsw commented: I hope that these little fixes are helpful! I think that the documentation is really thorough and helpful! https://github.com/llvm/llvm-project/pull/89913 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] [lldb][Docs] Convert platform packets doc to Markdown (PR #89913)

2024-04-24 Thread Will Hawkins via lldb-commits
https://github.com/hawkinsw edited https://github.com/llvm/llvm-project/pull/89913 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Docs] Convert platform packets doc to Markdown (PR #89913)

2024-04-24 Thread Will Hawkins via lldb-commits
@@ -0,0 +1,482 @@ +# LLDB Platform Packets +Here is a brief overview of the packets that an lldb platform server +needs to implement for the lldb testsuite to be run on a remote +target device/system. + +These are almost all lldb extensions to the gdb-remote serial +protocol. Man

[Lldb-commits] [lldb] [lldb][Docs] Convert platform packets doc to Markdown (PR #89913)

2024-04-24 Thread Will Hawkins via lldb-commits
@@ -0,0 +1,482 @@ +# LLDB Platform Packets +Here is a brief overview of the packets that an lldb platform server +needs to implement for the lldb testsuite to be run on a remote +target device/system. + +These are almost all lldb extensions to the gdb-remote serial +protocol. Man

[Lldb-commits] [lldb] [lldb][Docs] Convert platform packets doc to Markdown (PR #89913)

2024-04-24 Thread Will Hawkins via lldb-commits
@@ -0,0 +1,482 @@ +# LLDB Platform Packets +Here is a brief overview of the packets that an lldb platform server +needs to implement for the lldb testsuite to be run on a remote +target device/system. + +These are almost all lldb extensions to the gdb-remote serial +protocol. Man

[Lldb-commits] [lldb] [lldb][Docs] Convert platform packets doc to Markdown (PR #89913)

2024-04-24 Thread Will Hawkins via lldb-commits
@@ -0,0 +1,482 @@ +# LLDB Platform Packets +Here is a brief overview of the packets that an lldb platform server +needs to implement for the lldb testsuite to be run on a remote +target device/system. + +These are almost all lldb extensions to the gdb-remote serial +protocol. Man

[Lldb-commits] [lldb] [lldb][Docs] Convert platform packets doc to Markdown (PR #89913)

2024-04-24 Thread Will Hawkins via lldb-commits
@@ -0,0 +1,482 @@ +# LLDB Platform Packets +Here is a brief overview of the packets that an lldb platform server +needs to implement for the lldb testsuite to be run on a remote +target device/system. + +These are almost all lldb extensions to the gdb-remote serial +protocol. Man

[Lldb-commits] [lldb] [lldb][Docs] Convert platform packets doc to Markdown (PR #89913)

2024-04-24 Thread Will Hawkins via lldb-commits
@@ -0,0 +1,482 @@ +# LLDB Platform Packets +Here is a brief overview of the packets that an lldb platform server +needs to implement for the lldb testsuite to be run on a remote +target device/system. + +These are almost all lldb extensions to the gdb-remote serial +protocol. Man

[Lldb-commits] [lldb] [lldb][Docs] Convert platform packets doc to Markdown (PR #89913)

2024-04-24 Thread Will Hawkins via lldb-commits
@@ -0,0 +1,482 @@ +# LLDB Platform Packets +Here is a brief overview of the packets that an lldb platform server +needs to implement for the lldb testsuite to be run on a remote +target device/system. + +These are almost all lldb extensions to the gdb-remote serial +protocol. Man

[Lldb-commits] [lldb] [lldb][Docs] Convert platform packets doc to Markdown (PR #89913)

2024-04-24 Thread Will Hawkins via lldb-commits
@@ -0,0 +1,482 @@ +# LLDB Platform Packets +Here is a brief overview of the packets that an lldb platform server +needs to implement for the lldb testsuite to be run on a remote +target device/system. + +These are almost all lldb extensions to the gdb-remote serial +protocol. Man

[Lldb-commits] [lldb] [lldb][Docs] Convert platform packets doc to Markdown (PR #89913)

2024-04-24 Thread Will Hawkins via lldb-commits
@@ -0,0 +1,482 @@ +# LLDB Platform Packets +Here is a brief overview of the packets that an lldb platform server +needs to implement for the lldb testsuite to be run on a remote +target device/system. + +These are almost all lldb extensions to the gdb-remote serial +protocol. Man

[Lldb-commits] [lldb] [lldb][Docs] Convert platform packets doc to Markdown (PR #89913)

2024-04-24 Thread Will Hawkins via lldb-commits
@@ -0,0 +1,482 @@ +# LLDB Platform Packets +Here is a brief overview of the packets that an lldb platform server +needs to implement for the lldb testsuite to be run on a remote +target device/system. + +These are almost all lldb extensions to the gdb-remote serial +protocol. Man

[Lldb-commits] [lldb] [lldb][Docs] Convert platform packets doc to Markdown (PR #89913)

2024-04-24 Thread Will Hawkins via lldb-commits
@@ -0,0 +1,482 @@ +# LLDB Platform Packets +Here is a brief overview of the packets that an lldb platform server +needs to implement for the lldb testsuite to be run on a remote +target device/system. + +These are almost all lldb extensions to the gdb-remote serial +protocol. Man

[Lldb-commits] [lldb] [lldb][Docs] Convert platform packets doc to Markdown (PR #89913)

2024-04-24 Thread Will Hawkins via lldb-commits
@@ -0,0 +1,482 @@ +# LLDB Platform Packets +Here is a brief overview of the packets that an lldb platform server +needs to implement for the lldb testsuite to be run on a remote +target device/system. + +These are almost all lldb extensions to the gdb-remote serial +protocol. Man

[Lldb-commits] [lldb] Allow multiple destroy callbacks in `SBDebugger::SetDestroyCallback()` (PR #89868)

2024-04-24 Thread via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/89868 >From 079a550481d4cdcb69ad01c376b5e1f0632a07d6 Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Tue, 23 Apr 2024 18:10:21 -0700 Subject: [PATCH 1/4] Allow multiple destroy callbacks in `SBDebugger::SetDestroyCallba

[Lldb-commits] [lldb] Allow multiple destroy callbacks in `SBDebugger::SetDestroyCallback()` (PR #89868)

2024-04-24 Thread via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/89868 >From 079a550481d4cdcb69ad01c376b5e1f0632a07d6 Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Tue, 23 Apr 2024 18:10:21 -0700 Subject: [PATCH 1/5] Allow multiple destroy callbacks in `SBDebugger::SetDestroyCallba

[Lldb-commits] [lldb] Allow multiple destroy callbacks in `SBDebugger::SetDestroyCallback()` (PR #89868)

2024-04-24 Thread via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/89868 >From 079a550481d4cdcb69ad01c376b5e1f0632a07d6 Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Tue, 23 Apr 2024 18:10:21 -0700 Subject: [PATCH 1/6] Allow multiple destroy callbacks in `SBDebugger::SetDestroyCallba

[Lldb-commits] [lldb] Allow multiple destroy callbacks in `SBDebugger::SetDestroyCallback()` (PR #89868)

2024-04-24 Thread via lldb-commits
royitaqi wrote: Hi @JDevlieghere and @jimingham, I have updated the PR to add `AddDestroyCallback()`, `ClearDestroyCallback()`, and tests for these. Also updated `SetDestroyCallback()` to work with the new field `std::vector>`. Hope it looks better now. LMK if anything else needs to be added/

[Lldb-commits] [lldb] [lldb][docs] Update instructions for debugging API tests (PR #89979)

2024-04-24 Thread Med Ismail Bennani via lldb-commits
medismailben wrote: LGTM, although it would be good to mention that this could also be used for any LLDB python script, not only API tests. https://github.com/llvm/llvm-project/pull/89979 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https

[Lldb-commits] [lldb] [lldb][docs] Update instructions for debugging API tests (PR #89979)

2024-04-24 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben approved this pull request. https://github.com/llvm/llvm-project/pull/89979 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Allow multiple destroy callbacks in `SBDebugger::SetDestroyCallback()` (PR #89868)

2024-04-24 Thread via lldb-commits
royitaqi wrote: # Tests that I did ## Manual test ``` username-mac ~/public_llvm/build % bin/lldb (lldb) script Python Interactive Interpreter. To exit, type 'quit()', 'exit()' or Ctrl-D. >>> lldb.debugger.AddDestroyCallback(lambda user_id: print('foo %s' % user_id)) >>> lldb.debugger.AddDestro

[Lldb-commits] [lldb] Add a new SBExpressionOptions::SetLanguage() API (NFCI) (PR #89981)

2024-04-24 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/89981 >From 5bd7d3da1cd1c9ec508e0fbd96c8d9f2509ee900 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Wed, 24 Apr 2024 12:50:43 -0700 Subject: [PATCH] Add a new SBExpressionOptions::SetLanguage() API (NFCI) th

[Lldb-commits] [lldb] [llvm] lldb simplified template names rebuild without clang ast (PR #90008)

2024-04-24 Thread David Blaikie via lldb-commits
https://github.com/dwblaikie created https://github.com/llvm/llvm-project/pull/90008 - DO NOT SUBMIT: lldb DWARF-Clang AST parsing tracing - Fix scope operator ordering - DO NOT SUBMIT: Really dodgy demonstration of DWARFTypePrinter reuse in lldb >From 863343317c47602163d75c13b2687601740e8410

[Lldb-commits] [lldb] [llvm] lldb simplified template names rebuild without clang ast (PR #90008)

2024-04-24 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 396cdabe47f3596464b289d0937c0066f50a0ac6 9a654b056d9c05c0aa4856db161c1f1b08b9dfe9 --

[Lldb-commits] [lldb] [lldb][docs] Update instructions for debugging API tests (PR #89979)

2024-04-24 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben approved this pull request. https://github.com/llvm/llvm-project/pull/89979 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Allow multiple destroy callbacks in `SBDebugger::SetDestroyCallback()` (PR #89868)

2024-04-24 Thread via lldb-commits
@@ -1425,10 +1426,19 @@ void Debugger::SetLoggingCallback(lldb::LogOutputCallback log_callback, std::make_shared(log_callback, baton); } +void Debugger::AddDestroyCallback( +lldb_private::DebuggerDestroyCallback destroy_callback, void *baton) { + m_destroy_callback

[Lldb-commits] [lldb] Allow multiple destroy callbacks in `SBDebugger::SetDestroyCallback()` (PR #89868)

2024-04-24 Thread via lldb-commits
@@ -321,9 +321,14 @@ class LLDB_API SBDebugger { void SetLoggingCallback(lldb::LogOutputCallback log_callback, void *baton); + void AddDestroyCallback(lldb::SBDebuggerDestroyCallback destroy_callback, + void *baton); + void SetDestroyCallback(ll

[Lldb-commits] [lldb] [lldb][docs] Update instructions for debugging API tests (PR #89979)

2024-04-24 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova closed https://github.com/llvm/llvm-project/pull/89979 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 1b54805 - [lldb][docs] Update instructions for debugging API tests (#89979)

2024-04-24 Thread via lldb-commits
Author: Chelsea Cassanova Date: 2024-04-24T18:31:31-07:00 New Revision: 1b54805dfcebe02f28e23f655c8fbf4dc610aa70 URL: https://github.com/llvm/llvm-project/commit/1b54805dfcebe02f28e23f655c8fbf4dc610aa70 DIFF: https://github.com/llvm/llvm-project/commit/1b54805dfcebe02f28e23f655c8fbf4dc610aa70.d

[Lldb-commits] [lldb] Allow multiple destroy callbacks in `SBDebugger::SetDestroyCallback()` (PR #89868)

2024-04-24 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/89868 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Allow multiple destroy callbacks in `SBDebugger::SetDestroyCallback()` (PR #89868)

2024-04-24 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/89868 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits