jh7370 wrote:
> This looks like a nice improvement for folks using those generators. Even
> though most of these changes look straightforward, it would be a lot easier
> to review if this was broken up per subproject. Is there any reason that's
> not possible?
+1 to this: 195 files is too man
@@ -75,6 +75,12 @@ if (LLDB_ENABLE_PYTHON)
endif()
endif()
endforeach()
+ if(WIN32 AND CMAKE_BUILD_TYPE STREQUAL Debug)
+string(SUBSTRING ${LLDB_PYTHON_EXT_SUFFIX} 0 2 FIRST_2_CHARS)
+if(NOT FIRST_2_CHARS STREQUAL "_d")
DavidSpickett wrote:
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/89716
RST is powerful but usually too powerful for 90% of what we need it for.
Markdown is easier to edit and can be previewed easily without building the
entire website.
This copies what llvm does already, mak
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: David Spickett (DavidSpickett)
Changes
RST is powerful but usually too powerful for 90% of what we need it for.
Markdown is easier to edit and can be previewed easily without building the
entire website.
This copies what llvm does already
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: David Spickett (DavidSpickett)
Changes
This document has never been on the website, unlike GDB's protocol docs. It
will be useful to have both available online to compare.
Markdown is easier to edit and preview in many editors (including G
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/89587
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
I'll include this as a commit in a larger PR.
https://github.com/llvm/llvm-project/pull/89587
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
As it stands this PR *will not* build, because it requires
https://github.com/llvm/llvm-project/pull/89716. I wanted to put up both to
show what I'm going to do with all this.
First https://github.com/llvm/llvm-project/pull/89716 should land, so we can
flush out any build
DavidSpickett wrote:
This will be used by https://github.com/llvm/llvm-project/pull/89718, but I
would like to land this PR first to flush out any bot config problems.
https://github.com/llvm/llvm-project/pull/89716
___
lldb-commits mailing list
lldb-
DavidSpickett wrote:
Opened https://github.com/llvm/llvm-project/pull/89718 instead, which has all
the conversion steps in it.
https://github.com/llvm/llvm-project/pull/89587
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/89716
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Pavel Labath
Date: 2024-04-23T09:11:58Z
New Revision: dbcfb434a9c7fea194c7b1f7f04f0947f88dbc85
URL:
https://github.com/llvm/llvm-project/commit/dbcfb434a9c7fea194c7b1f7f04f0947f88dbc85
DIFF:
https://github.com/llvm/llvm-project/commit/dbcfb434a9c7fea194c7b1f7f04f0947f88dbc85.diff
LOG:
https://github.com/labath created
https://github.com/llvm/llvm-project/pull/89730
The main change is the addition of a new SBTypeStaticField class, representing
a static member of a class. It can be retrieved created through
SBType::GetStaticFieldWithName. It contains several methods (GetName,
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
The main change is the addition of a new SBTypeStaticField class, representing
a static member of a class. It can be retrieved created through
SBType::GetStaticFieldWithName. It contains several methods (GetNa
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/89730
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 approved this pull request.
LGTM with some minor clarification questions/style comments
https://github.com/llvm/llvm-project/pull/89730
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-b
@@ -9074,6 +9111,21 @@ CompilerType
TypeSystemClang::DeclGetFunctionArgumentType(void *opaque_decl,
return CompilerType();
}
+Scalar TypeSystemClang::DeclGetConstantValue(void *opaque_decl) {
+ clang::Decl *decl = static_cast(opaque_decl);
+ if (clang::VarDecl *var_decl =
@@ -1156,6 +1159,10 @@ CompilerType
TypeSystemClang::GetTypeForDecl(ObjCInterfaceDecl *decl) {
return GetType(getASTContext().getObjCInterfaceType(decl));
}
+CompilerType TypeSystemClang::GetTypeForDecl(clang::ValueDecl *value_decl) {
Michael137 wrote:
Cou
@@ -27,6 +27,7 @@ class Task {
enum E : unsigned char {} e;
union U {
} u;
+static constexpr long static_constexpr_field = 47;
Michael137 wrote:
Should we have an XFAIL test for the non-constant case?
https://github.com/llvm/llvm-project/pull/
@@ -107,6 +107,35 @@ class SBTypeMemberFunction {
lldb::TypeMemberFunctionImplSP m_opaque_sp;
};
+class LLDB_API SBTypeStaticField {
+public:
+ SBTypeStaticField();
+
+ SBTypeStaticField(const lldb::SBTypeStaticField &rhs);
+ lldb::SBTypeStaticField &operator=(const lldb:
@@ -107,6 +107,35 @@ class SBTypeMemberFunction {
lldb::TypeMemberFunctionImplSP m_opaque_sp;
};
+class LLDB_API SBTypeStaticField {
+public:
+ SBTypeStaticField();
+
+ SBTypeStaticField(const lldb::SBTypeStaticField &rhs);
+ lldb::SBTypeStaticField &operator=(const lldb:
@@ -27,6 +27,7 @@ class Task {
enum E : unsigned char {} e;
union U {
} u;
+static constexpr long static_constexpr_field = 47;
labath wrote:
Good idea.
https://github.com/llvm/llvm-project/pull/89730
___
@@ -1156,6 +1159,10 @@ CompilerType
TypeSystemClang::GetTypeForDecl(ObjCInterfaceDecl *decl) {
return GetType(getASTContext().getObjCInterfaceType(decl));
}
+CompilerType TypeSystemClang::GetTypeForDecl(clang::ValueDecl *value_decl) {
labath wrote:
ValueDe
@@ -1156,6 +1159,10 @@ CompilerType
TypeSystemClang::GetTypeForDecl(ObjCInterfaceDecl *decl) {
return GetType(getASTContext().getObjCInterfaceType(decl));
}
+CompilerType TypeSystemClang::GetTypeForDecl(clang::ValueDecl *value_decl) {
Michael137 wrote:
Ahh
https://github.com/labath updated
https://github.com/llvm/llvm-project/pull/89730
>From 091db4a89de2678fbdcc2db3051f34eeb8cc0cf2 Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Tue, 23 Apr 2024 08:50:31 +
Subject: [PATCH 1/2] [lldb] Add SB API to access static constexpr member
values
Th
https://github.com/Meinersbur edited
https://github.com/llvm/llvm-project/pull/89153
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Meinersbur wrote:
As suggested, I split the patch into per-subproject patches:
[LLVM](https://github.com/llvm/llvm-project/pull/89741) (dependency of the
other patches)
[BOLT](https://github.com/llvm/llvm-project/pull/89742)
[Clang](https://github.com/llvm/llvm-project/pull/89743)
[Clang-Tools-
https://github.com/ita-sc created
https://github.com/llvm/llvm-project/pull/89760
Hi
It seems that by default
```
# On non-Apple platforms, -arch becomes -m
```
This patch overrides this behavior, and if it is used clang or gcc/g++, flag
becomes `-march`
>From e9a5462ec17beca948e8a18fc7fa5
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (ita-sc)
Changes
Hi
It seems that by default
```
# On non-Apple platforms, -arch becomes -m
```
This patch overrides this behavior, and if it is used clang or gcc/g++, flag
becomes `-march`
---
Full diff: https://github.com/llvm/l
https://github.com/ita-sc created
https://github.com/llvm/llvm-project/pull/89764
Hi
This patch adds ability to set up lldb dotest.py command with json format:
```
[
{
"test_pack_name": "check-lldb-one", # <- mandatory
"test_pack_desc": "description for test pack", # <- mandatory
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (ita-sc)
Changes
Hi
This patch adds ability to set up lldb dotest.py command with json format:
```
[
{
"test_pack_name": "check-lldb-one", # <- mandatory
"test_pack_desc": "description for test pack", # <- mandatory
"test
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
7c581b554efa7c720b780f721877107ae0fc78ff...b5e6e4ab15692a5d4ec3e1bc4d04c9c98f572d08
lldb/
https://github.com/ita-sc created
https://github.com/llvm/llvm-project/pull/89765
None
>From ec086f99bb6cb48cae02f77e621a51cb29c751d1 Mon Sep 17 00:00:00 2001
From: Ivan Tetyushkin
Date: Thu, 11 Apr 2024 12:22:19 +0300
Subject: [PATCH] [lldb][tests] Add ability to run API tests with qemu-user
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (ita-sc)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/89765.diff
1 Files Affected:
- (modified) lldb/test/API/lit.cfg.py (+7)
``diff
diff --git a/lldb/test/API/lit.cfg.py b/lldb/test/API/lit.cfg.py
in
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
7c581b554efa7c720b780f721877107ae0fc78ff...ec086f99bb6cb48cae02f77e621a51cb29c751d1
lldb/
https://github.com/ita-sc created
https://github.com/llvm/llvm-project/pull/89768
Hi
This patch removes restriction for remote directory, as some remote targets may
not have remote working directory, for example baremetal targets.
>From 3472c2b35393d2a7b348e245857ffac3765dc6e3 Mon Sep 17 00:0
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (ita-sc)
Changes
Hi
This patch removes restriction for remote directory, as some remote targets may
not have remote working directory, for example baremetal targets.
---
Full diff: https://github.com/llvm/llvm-project/pull/89768.diff
DavidSpickett wrote:
The CI build "worked" but there is this warning:
```
/home/runner/work/llvm-project/llvm-project/lldb/docs/index.rst:146: WARNING:
toctree contains reference to nonexisting document 'resources/lldbgdbremote'
```
Which is what I expected. Once it knows to look for Markdown it
https://github.com/JDevlieghere requested changes to this pull request.
Based on the description it's not entirely clear to me what exactly you're
trying to achieve. You don't have a working directory, but presumably you still
have a platform name and a platform URL? In other words, I assume yo
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/89768
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/89768
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
LGTM with the formatting fixed.
https://github.com/llvm/llvm-project/pull/89765
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-c
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/88335
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jeffreytan81 approved this pull request.
https://github.com/llvm/llvm-project/pull/89405
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/89716
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
The converted markdown looks good to me. I expect this to render very nicely on
the new website with the table-of-content on the right hand side. Thanks for
doing this!
https://github.com/llvm/llvm-project/pull/89718
_
@@ -325,6 +330,79 @@ lldb::SBTypeMemberFunction
SBType::GetMemberFunctionAtIndex(uint32_t idx) {
return sb_func_type;
}
+SBTypeStaticField::SBTypeStaticField() { LLDB_INSTRUMENT_VA(this); }
+
+SBTypeStaticField::SBTypeStaticField(lldb_private::CompilerDecl decl)
+: m_op
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/89690
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
A potential compromise would be to check that the time is great or equal?
https://github.com/llvm/llvm-project/pull/89637
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lld
@@ -37,6 +37,8 @@ def test_with_run_command(self):
substrs=["stopped", "stop reason = breakpoint"],
)
+self.runCmd("command script import ./ConvertToDataFormatter.py",
check=True)
jeffreytan81 wrote:
Instead of changing existing t
Author: Fangrui Song
Date: 2024-04-23T11:18:05-07:00
New Revision: a7e27260a92b7a40ede0c3ea4035733ea61e6571
URL:
https://github.com/llvm/llvm-project/commit/a7e27260a92b7a40ede0c3ea4035733ea61e6571
DIFF:
https://github.com/llvm/llvm-project/commit/a7e27260a92b7a40ede0c3ea4035733ea61e6571.diff
https://github.com/MaskRay closed
https://github.com/llvm/llvm-project/pull/88335
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/89808
These are now close enough that they can be swapped out.
>From 3f3989d3d7b0cd64a08a8c30d4d83e45098a4b44 Mon Sep 17 00:00:00 2001
From: Alex Langford
Date: Tue, 23 Apr 2024 12:14:02 -0700
Subject: [PATCH] [lldb
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Alex Langford (bulbazord)
Changes
These are now close enough that they can be swapped out.
---
Full diff: https://github.com/llvm/llvm-project/pull/89808.diff
4 Files Affected:
- (modified) lldb/source/Plugins/SymbolFile/DWARF/DWARFCompi
https://github.com/JDevlieghere approved this pull request.
🥳
https://github.com/llvm/llvm-project/pull/89808
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/89845
Make SymbolFileCTF::ParseFunctions resilient against not being able to
resolve the argument or return type of a function. ResolveTypeUID can
fail for a variety of reasons so we should always check its result.
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
Make SymbolFileCTF::ParseFunctions resilient against not being able to
resolve the argument or return type of a function. ResolveTypeUID can
fail for a variety of reasons so we should always check its
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
ef5906989ae2004100ff56dc5ab59be2be9d5c99...a4bf873cf76d265bed94b26e7534924b7ce5c0bf
lldb/
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/89845
>From 5a4f813590b0ceb3fb00ed737650e37715019e89 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Tue, 23 Apr 2024 15:26:30 -0700
Subject: [PATCH 1/2] [lldb] Fix crash in SymbolFileCTF::ParseFunctions
M
https://github.com/bulbazord approved this pull request.
Makes sense to me.
https://github.com/llvm/llvm-project/pull/89845
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2024-04-23T16:50:22-07:00
New Revision: fd4399cb11f4069888bc7eac01f74493b5a2af48
URL:
https://github.com/llvm/llvm-project/commit/fd4399cb11f4069888bc7eac01f74493b5a2af48
DIFF:
https://github.com/llvm/llvm-project/commit/fd4399cb11f4069888bc7eac01f74493b5a2af48.d
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/89845
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
feg208 wrote:
> A potential compromise would be to check that the time is great or equal?
That's a good idea. I'll make that change and add a note
https://github.com/llvm/llvm-project/pull/89637
___
lldb-commits mailing list
lldb-commits@lists.llvm.or
felipepiovezan wrote:
Hi @feg208 , I noticed that your [previous commit
](https://github.com/llvm/llvm-project/pull/89267) has a very.. unusual commit
title and message. The same thing applies to this PR.
I'd appreciate it if you could follow a more standard commit title and message,
so that
https://github.com/royitaqi created
https://github.com/llvm/llvm-project/pull/89868
# Motivation
Individual callers of `SBDebugger::SetDestroyCallback()` might think that they
have registered their callback and expect it to be called when the debugger is
destroyed. In reality, only the last c
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (royitaqi)
Changes
# Motivation
Individual callers of `SBDebugger::SetDestroyCallback()` might think that they
have registered their callback and expect it to be called when the debugger is
destroyed. In reality, only the last caller
https://github.com/royitaqi edited
https://github.com/llvm/llvm-project/pull/89868
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/royitaqi updated
https://github.com/llvm/llvm-project/pull/89868
>From 079a550481d4cdcb69ad01c376b5e1f0632a07d6 Mon Sep 17 00:00:00 2001
From: Roy Shi
Date: Tue, 23 Apr 2024 18:10:21 -0700
Subject: [PATCH 1/2] Allow multiple destroy callbacks in
`SBDebugger::SetDestroyCallba
https://github.com/JDevlieghere requested changes to this pull request.
Can you elaborate a bit more about why you want to change the behavior? Your
motivation touches on the fact that it might be surprising or racy. While I
think having the ability to register multiple callbacks makes sense, I
70 matches
Mail list logo
