https://github.com/kevinfrei created
https://github.com/llvm/llvm-project/pull/86292
@GeorgeHuyubo noticed an unchecked shared pointer result in
https://github.com/llvm/llvm-project/pull/85693/. This is the fix for that
issue.
>From 6bc82c0820963050752e6faabef7ec10e8c81f2f Mon Sep 17 00:00:00
@@ -44,6 +44,25 @@ llvm::StringRef
SymbolVendorELF::GetPluginDescriptionStatic() {
"executables.";
}
+// If this is needed elsewhere, it can be exported/moved.
+static bool IsDwpSymbolFile(const lldb::ModuleSP &module_sp,
+const FileSpec &
https://github.com/kevinfrei ready_for_review
https://github.com/llvm/llvm-project/pull/86292
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Kevin Frei (kevinfrei)
Changes
@GeorgeHuyubo noticed an unchecked shared pointer result in
https://github.com/llvm/llvm-project/pull/85693/. This is the fix for that
issue.
---
Full diff: https://github.com/llvm/llvm-project/pull/86292.di
https://github.com/GeorgeHuyubo approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/86292
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
avillega wrote:
I am seeing some errors related to this PR in our builds. Just want to confirm
if the fix forward you have up for review will fix it. Otherwise, could you
revert this change? Thanks!
```
ERROR: test_debuginfod_executable
(TestDebuginfod.DebugInfodTests.test_debuginfod_executabl
llvmbot wrote:
@llvm/pr-subscribers-clangd
@llvm/pr-subscribers-lldb
Author: None (ldrumm)
Changes
Historically, we've not automatically enforced how git tracks line endings, but
there are many, many commits that "undo" unintended CRLFs getting into history.
`git log --pretty=oneline --g
llvmbot wrote:
@llvm/pr-subscribers-backend-x86
Author: None (ldrumm)
Changes
Historically, we've not automatically enforced how git tracks line endings, but
there are many, many commits that "undo" unintended CRLFs getting into history.
`git log --pretty=oneline --grep=CRLF` shows nearl
ldrumm wrote:
I'm sure there are lots of people that will want to look at this, so please
bring in reviewers at will
https://github.com/llvm/llvm-project/pull/86318
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-b
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff cd8286a667d568c4319b09baa63ba899e3101a19
2dfda2e4b11c7ea0a81dd4dcd43aa426039d1e0a --
adrian-prantl wrote:
While I'm sure this commit will manage to break _something_ unexpectedly, I
think this is reasonable to do! Thanks for taking this on.
https://github.com/llvm/llvm-project/pull/86318
___
lldb-commits mailing list
lldb-commits@list
Author: Kevin Frei
Date: 2024-03-22T11:22:09-07:00
New Revision: b1575f9082071702bd6aaa2600ce9fe011a091e9
URL:
https://github.com/llvm/llvm-project/commit/b1575f9082071702bd6aaa2600ce9fe011a091e9
DIFF:
https://github.com/llvm/llvm-project/commit/b1575f9082071702bd6aaa2600ce9fe011a091e9.diff
LO
https://github.com/clayborg closed
https://github.com/llvm/llvm-project/pull/86292
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/clayborg approved this pull request.
https://github.com/llvm/llvm-project/pull/86292
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
rnk wrote:
I think it makes sense to remove carriage returns on checkin, but I'm not sure
it makes sense to add them back on checkout on Windows. Historically, it's been
really easy to write LLVM tests that fail when the source is checked out with
CRLF. Many Windows developers have noted that
pogo59 wrote:
As a data point, I've been setting `core.autocrlf=true` on Windows for years.
I've been trained to make sure _new_ files have LF endings (usually I copy an
existing file instead of creating a new file) but both Notepad and the Visual
Studio editor are willing to preserve the line
ldrumm wrote:
> So, is there a way to do CRLF -> LF on checkin, but do nothing on checkout?
To be clear, this *may* do nothing on checkout if a user has set a config
option. The point of the present policy is not to control local preferences as
far as the filetype isn't *reqired* to have a spe
rnk wrote:
> As a data point, I've been setting core.autocrlf=true on Windows for years.
If that's the case, my information is stale, which I accept.
> To be clear, this may do nothing on checkout if a user has set a config
> option.
That addresses my concerns.
https://github.com/llvm/llv
omjavaid wrote:
both commits from this PR broke LLDB buildbots on Arm and AArch64 Linux.
New tests apparently are failing on Arm/AArch64 Linux.
https://lab.llvm.org/buildbot/#/builders/96/builds/54867
https://lab.llvm.org/buildbot/#/builders/17/builds/50824
I will be reverting
[b1575f9](https:/
Author: Muhammad Omair Javaid
Date: 2024-03-23T03:31:25+05:00
New Revision: 4406e4a8bd5acadd980d84356b36030cadf9a61d
URL:
https://github.com/llvm/llvm-project/commit/4406e4a8bd5acadd980d84356b36030cadf9a61d
DIFF:
https://github.com/llvm/llvm-project/commit/4406e4a8bd5acadd980d84356b36030cadf9a6
Author: Muhammad Omair Javaid
Date: 2024-03-23T03:31:56+05:00
New Revision: 7fc2fbb3f1961e0ad0722c2d749ddd6264195a1c
URL:
https://github.com/llvm/llvm-project/commit/7fc2fbb3f1961e0ad0722c2d749ddd6264195a1c
DIFF:
https://github.com/llvm/llvm-project/commit/7fc2fbb3f1961e0ad0722c2d749ddd6264195a
https://github.com/jasonmolenda created
https://github.com/llvm/llvm-project/pull/86359
It is possible to gather code coverage in a firmware environment, where the
__LLVM_COV segment will not be mapped in memory but does exist in the binary,
see
https://llvm.org/devmtg/2020-09/slides/PhippsAla
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jason Molenda (jasonmolenda)
Changes
It is possible to gather code coverage in a firmware environment, where the
__LLVM_COV segment will not be mapped in memory but does exist in the binary,
see
https://llvm.org/devmtg/2020-09/slides/Phipp
github-actions[bot] wrote:
:white_check_mark: With the latest revision this PR passed the C/C++ code
formatter.
https://github.com/llvm/llvm-project/pull/86359
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/
github-actions[bot] wrote:
:white_check_mark: With the latest revision this PR passed the Python code
formatter.
https://github.com/llvm/llvm-project/pull/86359
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin
joker-eph wrote:
LGTM overall, but the CI failure looks real.
https://github.com/llvm/llvm-project/pull/86318
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
26 matches
Mail list logo
