[Lldb-commits] [lldb] 81ec95f - Silence -Wswitch warnings

2024-03-20 Thread Benjamin Kramer via lldb-commits
Author: Benjamin Kramer Date: 2024-03-20T13:06:29+01:00 New Revision: 81ec95ff983afd7f31c2713891bbc37bd630a100 URL: https://github.com/llvm/llvm-project/commit/81ec95ff983afd7f31c2713891bbc37bd630a100 DIFF: https://github.com/llvm/llvm-project/commit/81ec95ff983afd7f31c2713891bbc37bd630a100.dif

[Lldb-commits] [lldb] [lldb] Omit --show-globals in `help target var` (PR #85855)

2024-03-20 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan closed https://github.com/llvm/llvm-project/pull/85855 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 1232964 - [lldb] Omit --show-globals in `help target var` (#85855)

2024-03-20 Thread via lldb-commits
Author: Felipe de Azevedo Piovezan Date: 2024-03-20T07:03:24-07:00 New Revision: 12329648e2c3f8651228f17d3619b1e1ddab80f0 URL: https://github.com/llvm/llvm-project/commit/12329648e2c3f8651228f17d3619b1e1ddab80f0 DIFF: https://github.com/llvm/llvm-project/commit/12329648e2c3f8651228f17d3619b1e1d

[Lldb-commits] [lldb] DebugInfoD tests + fixing issues exposed by tests (PR #85693)

2024-03-20 Thread Kevin Frei via lldb-commits
kevinfrei wrote: @JDevlieghere ping :) https://github.com/llvm/llvm-project/pull/85693 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Support custom LLVM formatting for variables (PR #81196)

2024-03-20 Thread Adrian Prantl via lldb-commits
@@ -658,6 +658,33 @@ static char ConvertValueObjectStyleToChar( return '\0'; } +static bool DumpValueWithLLVMFormat(Stream &s, llvm::StringRef options, +ValueObject &target) { + std::string formatted; + std::string llvm_format = ("{0:" +

[Lldb-commits] [lldb] [lldb] Support custom LLVM formatting for variables (PR #81196)

2024-03-20 Thread Adrian Prantl via lldb-commits
@@ -0,0 +1,11 @@ +import lldb +from lldbsuite.test.lldbtest import * +import lldbsuite.test.lldbutil as lldbutil + + +class TestCase(TestBase): +def test(self): +self.build() +lldbutil.run_to_source_breakpoint(self, "break here", lldb.SBFileSpec("main.c")) +

[Lldb-commits] [lldb] [lldb] Support custom LLVM formatting for variables (PR #81196)

2024-03-20 Thread Greg Clayton via lldb-commits
@@ -658,6 +658,33 @@ static char ConvertValueObjectStyleToChar( return '\0'; } +static bool DumpValueWithLLVMFormat(Stream &s, llvm::StringRef options, +ValueObject &target) { clayborg wrote: Can we named this something o

[Lldb-commits] [lldb] DebugInfoD tests + fixing issues exposed by tests (PR #85693)

2024-03-20 Thread Kevin Frei via lldb-commits
https://github.com/kevinfrei updated https://github.com/llvm/llvm-project/pull/85693 >From fc0eda99c7cceeaefd33477c9b08e7221a5a6e2a Mon Sep 17 00:00:00 2001 From: Kevin Frei Date: Fri, 15 Mar 2024 08:54:04 -0700 Subject: [PATCH 1/5] Tests (w/fixes) for initial DebugInfoD LLDB integration Summa

[Lldb-commits] [lldb] [lldb] Remove process restart prompt from TestSourceManager (PR #85861)

2024-03-20 Thread Alex Langford via lldb-commits
https://github.com/bulbazord closed https://github.com/llvm/llvm-project/pull/85861 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 66a2ed5 - [lldb] Remove process restart prompt from TestSourceManager (#85861)

2024-03-20 Thread via lldb-commits
Author: Alex Langford Date: 2024-03-20T10:43:40-07:00 New Revision: 66a2ed50ccb6de64fdf82957ca0d4b55ef76f3cd URL: https://github.com/llvm/llvm-project/commit/66a2ed50ccb6de64fdf82957ca0d4b55ef76f3cd DIFF: https://github.com/llvm/llvm-project/commit/66a2ed50ccb6de64fdf82957ca0d4b55ef76f3cd.diff

[Lldb-commits] [lldb] 10b0e35 - [lldb] Invert relationship between Process and AddressableBits (#85858)

2024-03-20 Thread via lldb-commits
Author: Alex Langford Date: 2024-03-20T10:46:06-07:00 New Revision: 10b0e355372fab1f4d58536525545eef8523 URL: https://github.com/llvm/llvm-project/commit/10b0e355372fab1f4d58536525545eef8523 DIFF: https://github.com/llvm/llvm-project/commit/10b0e355372fab1f4d58536525545eef8523.diff

[Lldb-commits] [lldb] [lldb] Invert relationship between Process and AddressableBits (PR #85858)

2024-03-20 Thread Alex Langford via lldb-commits
https://github.com/bulbazord closed https://github.com/llvm/llvm-project/pull/85858 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Reland: Store SupportFile in FileEntry (NFC (PR #85892)

2024-03-20 Thread Jorge Gorbe Moya via lldb-commits
slackito wrote: I tested the two patches separately. With the first one, [Make LineEntry::file private](https://github.com/llvm/llvm-project/pull/85892/commits/0914ecdf582831ec4da776e26ae5ebd2cf9f984f), my problematic test case still passes. When I apply the second one, [Swap FileSpec for Su

[Lldb-commits] [lldb] [lldb] Reland: Store SupportFile in FileEntry (NFC (PR #85892)

2024-03-20 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > I tested the two patches separately. > > With the first one ([Make LineEntry::file > private](https://github.com/llvm/llvm-project/pull/85892/commits/0914ecdf582831ec4da776e26ae5ebd2cf9f984f)) > my problematic test case still passes. > > When I apply the second one ([Swa

[Lldb-commits] [lldb] [lldb] Reland: Store SupportFile in FileEntry (NFC (PR #85892)

2024-03-20 Thread Jorge Gorbe Moya via lldb-commits
slackito wrote: > Could you do me another favor and try swapping out line 292 in LineTable.cpp > for: > ``` > line_entry.SetFile( > > std::make_shared(m_comp_unit->GetSupportFiles().GetFileSpecAtIndex(entry.file_idx))); > ``` With that modification the test goes back to passing :) ht

[Lldb-commits] [lldb] [lldb][progress][NFC] Clarify Doxygen comments for `details` field (PR #86002)

2024-03-20 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova created https://github.com/llvm/llvm-project/pull/86002 The Doxygen comments for the `details` field of a progress report currently does not specify that this field will act as the initial set of details for a progress report that gets updated with `Progress::I

[Lldb-commits] [lldb] [lldb][progress][NFC] Clarify Doxygen comments for `details` field (PR #86002)

2024-03-20 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Chelsea Cassanova (chelcassanova) Changes The Doxygen comments for the `details` field of a progress report currently does not specify that this field will act as the initial set of details for a progress report that gets updated with `Pro

[Lldb-commits] [lldb] [PAC][lldb][Dwarf] Support `__ptrauth`-qualified types in user expressions (PR #84387)

2024-03-20 Thread Daniil Kovalev via lldb-commits
kovdan01 wrote: A kind reminder regarding the PR - would be glad to see feedback from everyone interested. https://github.com/llvm/llvm-project/pull/84387 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[Lldb-commits] [lldb] [lldb] Support custom LLVM formatting for variables (PR #81196)

2024-03-20 Thread Dave Lee via lldb-commits
@@ -658,6 +658,33 @@ static char ConvertValueObjectStyleToChar( return '\0'; } +static bool DumpValueWithLLVMFormat(Stream &s, llvm::StringRef options, +ValueObject &target) { + std::string formatted; + std::string llvm_format = ("{0:" +

[Lldb-commits] [lldb] [lldb] Support custom LLVM formatting for variables (PR #81196)

2024-03-20 Thread Dave Lee via lldb-commits
@@ -0,0 +1,11 @@ +import lldb +from lldbsuite.test.lldbtest import * +import lldbsuite.test.lldbutil as lldbutil + + +class TestCase(TestBase): +def test(self): +self.build() +lldbutil.run_to_source_breakpoint(self, "break here", lldb.SBFileSpec("main.c")) +

[Lldb-commits] [lldb] [PAC][lldb][Dwarf] Support `__ptrauth`-qualified types in user expressions (PR #84387)

2024-03-20 Thread Michael Buch via lldb-commits
@@ -664,6 +685,17 @@ CompilerType CompilerType::GetPointerType() const { return CompilerType(); } +CompilerType +CompilerType::AddPtrAuthModifier(unsigned key, bool isAddressDiscriminated, Michael137 wrote: Can we add an API test that tests this API? E.g.,

[Lldb-commits] [lldb] [PAC][lldb][Dwarf] Support `__ptrauth`-qualified types in user expressions (PR #84387)

2024-03-20 Thread Michael Buch via lldb-commits
@@ -664,6 +685,17 @@ CompilerType CompilerType::GetPointerType() const { return CompilerType(); } +CompilerType +CompilerType::AddPtrAuthModifier(unsigned key, bool isAddressDiscriminated, Michael137 wrote: Also, whose this user of this API? Presumably ther

[Lldb-commits] [lldb] [PAC][lldb][Dwarf] Support `__ptrauth`-qualified types in user expressions (PR #84387)

2024-03-20 Thread Jonas Devlieghere via lldb-commits
@@ -216,6 +216,16 @@ class TypeSystem : public PluginInterface, virtual uint32_t GetPointerByteSize() = 0; + // TODO: are we allowed to insert virtual functions in the middle of the class + // interface and break ABI? JDevlieghere wrote: Answer: Yes, th

[Lldb-commits] [lldb] [PAC][lldb][Dwarf] Support `__ptrauth`-qualified types in user expressions (PR #84387)

2024-03-20 Thread Michael Buch via lldb-commits
@@ -676,6 +677,62 @@ DWARFASTParserClang::ParseTypeModifier(const SymbolContext &sc, case DW_TAG_volatile_type: encoding_data_type = Type::eEncodingIsVolatileUID; break; + case DW_TAG_LLVM_ptrauth_type: { +DWARFDIE ptr_die = die.GetReferencedDIE(DW_AT_type); ---

[Lldb-commits] [lldb] [lldb][progress][NFC] Clarify Doxygen comments for `details` field (PR #86002)

2024-03-20 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. Thanks, that's a great improvement! https://github.com/llvm/llvm-project/pull/86002 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/l

[Lldb-commits] [lldb] [lldb][progress][NFC] Clarify Doxygen comments for `details` field (PR #86002)

2024-03-20 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/86002 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Reland: Store SupportFile in FileEntry (NFC (PR #85892)

2024-03-20 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/85892 >From b4580245ea380c9953e24d8816003ecfcd281155 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Wed, 20 Mar 2024 19:31:35 -0700 Subject: [PATCH 1/2] [lldb] Make LineEntry::file private for SupportFile

[Lldb-commits] [lldb] [lldb] Reland: Store SupportFile in FileEntry (NFC) (PR #85892)

2024-03-20 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/85892 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Reland: Store SupportFile in FileEntry (NFC) (PR #85892)

2024-03-20 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere ready_for_review https://github.com/llvm/llvm-project/pull/85892 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Reland: Store SupportFile in FileEntry (NFC) (PR #85892)

2024-03-20 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/85892 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Reland: Store SupportFile in FileEntry (NFC) (PR #85892)

2024-03-20 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes This is another step towards supporting DWARF5 checksums and inline source code in LLDB. This is a reland of #85468 but without the functional change of storing the support file from the line table (