medismailben wrote:
LGTM!
https://github.com/llvm/llvm-project/pull/85342
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl edited
https://github.com/llvm/llvm-project/pull/85329
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/85329
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,193 @@
+//===-- Alarm.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,164 @@
+//===-- AlarmTest.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/adrian-prantl edited
https://github.com/llvm/llvm-project/pull/85342
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/85342
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1066,11 +1066,21 @@ bool
SymbolLocatorDebugSymbols::DownloadObjectAndSymbolFile(
command << lookup_arg;
// Log and report progress.
+ std::string lookup_desc;
+ if (uuid_ptr && file_spec_ptr)
+lookup_desc =
+llvm::formatv("{0} ({1})", file_spec_ptr->GetF
https://github.com/kastiglione edited
https://github.com/llvm/llvm-project/pull/85152
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1066,11 +1066,21 @@ bool
SymbolLocatorDebugSymbols::DownloadObjectAndSymbolFile(
command << lookup_arg;
// Log and report progress.
+ std::string lookup_desc;
+ if (uuid_ptr && file_spec_ptr)
+lookup_desc =
+llvm::formatv("{0} ({1})", file_spec_ptr->GetF
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/85329
>From 1ee7c2ffb76f13caa2052bef5dbe4f1982c8bade Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Tue, 5 Mar 2024 22:57:43 -0800
Subject: [PATCH] [lldb] Add an Alarm class for coalescing progress reports
Author: Jonas Devlieghere
Date: 2024-03-15T09:35:38-07:00
New Revision: f01a32f5c58b199edf7cd1492a20578453852f0e
URL:
https://github.com/llvm/llvm-project/commit/f01a32f5c58b199edf7cd1492a20578453852f0e
DIFF:
https://github.com/llvm/llvm-project/commit/f01a32f5c58b199edf7cd1492a20578453852f0e.d
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/85329
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2024-03-15T09:55:15-07:00
New Revision: fd09d510d066583c088e4dbcf23ac0b500c5cc7a
URL:
https://github.com/llvm/llvm-project/commit/fd09d510d066583c088e4dbcf23ac0b500c5cc7a
DIFF:
https://github.com/llvm/llvm-project/commit/fd09d510d066583c088e4dbcf23ac0b500c5cc7a.d
https://github.com/kastiglione updated
https://github.com/llvm/llvm-project/pull/85152
>From 970cf82fa3d64c5a4e1b3929c110b42974ef13cd Mon Sep 17 00:00:00 2001
From: Dave Lee
Date: Wed, 13 Mar 2024 14:49:23 -0700
Subject: [PATCH 1/2] [lldb] Fix dwim-print to not delete non-result persistent
var
@@ -170,6 +170,14 @@ void CommandObjectDWIMPrint::DoExecute(StringRef command,
ExpressionResults expr_result = target.EvaluateExpression(
expr, exe_scope, valobj_sp, eval_options, &fixed_expression);
+auto persistent_name = valobj_sp->GetName();
+// Evaluat
https://github.com/kastiglione edited
https://github.com/llvm/llvm-project/pull/85152
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jimingham wrote:
That's an okay approach if the only time an expression produces a result
variable dwim-print should not delete is when a persistent variable is
explicitly mentioned. But anyway, since that's the case we're fixing, and
checking as a persistent variable as a short-cut early on
@@ -1066,11 +1066,21 @@ bool
SymbolLocatorDebugSymbols::DownloadObjectAndSymbolFile(
command << lookup_arg;
// Log and report progress.
+ std::string lookup_desc;
+ if (uuid_ptr && file_spec_ptr)
+lookup_desc =
+llvm::formatv("{0} ({1})", file_spec_ptr->GetF
@@ -1066,11 +1066,21 @@ bool
SymbolLocatorDebugSymbols::DownloadObjectAndSymbolFile(
command << lookup_arg;
// Log and report progress.
+ std::string lookup_desc;
+ if (uuid_ptr && file_spec_ptr)
+lookup_desc =
+llvm::formatv("{0} ({1})", file_spec_ptr->GetF
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/85342
>From b50eb7442ab8f37659596efad19f8b30b145 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Thu, 14 Mar 2024 17:43:02 -0700
Subject: [PATCH 1/2] [lldb] Show module name in progress update for
down
https://github.com/bulbazord approved this pull request.
+1 to Adrian's suggestion.
LGTM since you've addressed that now
https://github.com/llvm/llvm-project/pull/85342
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/c
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/85342
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1066,11 +1066,21 @@ bool
SymbolLocatorDebugSymbols::DownloadObjectAndSymbolFile(
command << lookup_arg;
// Log and report progress.
+ std::string lookup_desc;
+ if (uuid_ptr && file_spec_ptr)
+lookup_desc =
+llvm::formatv("{0} ({1})", file_spec_ptr->GetF
https://github.com/adrian-prantl edited
https://github.com/llvm/llvm-project/pull/85342
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/85342
>From b50eb7442ab8f37659596efad19f8b30b145 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Thu, 14 Mar 2024 17:43:02 -0700
Subject: [PATCH 1/3] [lldb] Show module name in progress update for
down
Author: Jonas Devlieghere
Date: 2024-03-15T12:34:34-07:00
New Revision: b7dd6012ebc06b6383cf1449058bf916da0eb4bc
URL:
https://github.com/llvm/llvm-project/commit/b7dd6012ebc06b6383cf1449058bf916da0eb4bc
DIFF:
https://github.com/llvm/llvm-project/commit/b7dd6012ebc06b6383cf1449058bf916da0eb4bc.d
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/85342
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/85468
This is another step towards supporting DWARF5 checksums and inline
source code in LLDB.
>From 0caa7e713711c8211a10d3e6a249213746d41e9e Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Fri, 15 Mar 202
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
This is another step towards supporting DWARF5 checksums and inline
source code in LLDB.
---
Patch is 28.14 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-project/pul
kastiglione wrote:
I'll change this to scope lookup of persistent variables to the expected
language.
However, there's an argument to be made that `dwim-print $my_var` should work
anywhere. I think that follows the spirit of "do what I mean". Maybe in the
future I'll propose that in a separat
@@ -130,18 +130,27 @@ struct LineEntry {
/// Shared pointer to the target this LineEntry belongs to.
void ApplyFileMappings(lldb::TargetSP target_sp);
- // Member variables.
- AddressRange range; ///< The section offset address range for this line
entry.
- FileSpec
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/85468
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -130,18 +130,27 @@ struct LineEntry {
/// Shared pointer to the target this LineEntry belongs to.
void ApplyFileMappings(lldb::TargetSP target_sp);
- // Member variables.
- AddressRange range; ///< The section offset address range for this line
entry.
- FileSpec
jimingham wrote:
The counter to this is that `dwim-print` differs from `frame var` in that it
supports complex expressions. So having it work for simple statements of a
variable name (what frame var and target var already do just fine) but then
fail when the SAME name is used in a slightly mo
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/85468
>From 0caa7e713711c8211a10d3e6a249213746d41e9e Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Fri, 15 Mar 2024 11:42:44 -0700
Subject: [PATCH 1/3] [lldb] Outline Doxygen comments in LineEntry.h (NFC)
https://github.com/kastiglione updated
https://github.com/llvm/llvm-project/pull/85152
>From 970cf82fa3d64c5a4e1b3929c110b42974ef13cd Mon Sep 17 00:00:00 2001
From: Dave Lee
Date: Wed, 13 Mar 2024 14:49:23 -0700
Subject: [PATCH 1/3] [lldb] Fix dwim-print to not delete non-result persistent
var
kastiglione wrote:
I don't consider it a failure to not be able to perform mixed language
expressions. But it would have to be presented to the user in a way that is
understandable, which could be a challenge.
Anyway, I pushed the change that scopes the lookup to the expected language.
thank
Author: Jonas Devlieghere
Date: 2024-03-15T15:03:54-07:00
New Revision: d5a277d309e92b1d3e493da6036cffdf815105b1
URL:
https://github.com/llvm/llvm-project/commit/d5a277d309e92b1d3e493da6036cffdf815105b1
DIFF:
https://github.com/llvm/llvm-project/commit/d5a277d309e92b1d3e493da6036cffdf815105b1.d
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/85468
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jimingham wrote:
> I don't consider it a failure to not be able to perform mixed language
> expressions. But it would have to be presented to the user in a way that is
> understandable, which could be a challenge.
>
> Anyway, I pushed the change that scopes the lookup to the expected language.
https://github.com/jimingham approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/85152
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jie Fu
Date: 2024-03-16T06:52:12+08:00
New Revision: ba97dc8c7a8fc26516fbdfe822343bc4d38fe3db
URL:
https://github.com/llvm/llvm-project/commit/ba97dc8c7a8fc26516fbdfe822343bc4d38fe3db
DIFF:
https://github.com/llvm/llvm-project/commit/ba97dc8c7a8fc26516fbdfe822343bc4d38fe3db.diff
LOG: [
Author: Jie Fu
Date: 2024-03-16T06:59:07+08:00
New Revision: 8f2632c45f54d1e91248be81db5d4908d1036213
URL:
https://github.com/llvm/llvm-project/commit/8f2632c45f54d1e91248be81db5d4908d1036213
DIFF:
https://github.com/llvm/llvm-project/commit/8f2632c45f54d1e91248be81db5d4908d1036213.diff
LOG: [
kastiglione wrote:
> I'm not sure what you mean by "mixed language expressions".
I was thinking about the case where a user attempts `p $some_c_var + 1` in
Swift frame – which is valid swift as far as the debugger is concerned.
https://github.com/llvm/llvm-project/pull/85152
_
Author: Dave Lee
Date: 2024-03-15T16:09:24-07:00
New Revision: 4da2b542b142dac441722e044ee75da2475d9a20
URL:
https://github.com/llvm/llvm-project/commit/4da2b542b142dac441722e044ee75da2475d9a20
DIFF:
https://github.com/llvm/llvm-project/commit/4da2b542b142dac441722e044ee75da2475d9a20.diff
LOG:
https://github.com/kastiglione closed
https://github.com/llvm/llvm-project/pull/85152
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jimingham wrote:
> > I'm not sure what you mean by "mixed language expressions".
>
> I was thinking about the case where a user attempts `p $some_c_var + 1` in
> Swift frame – which is valid swift as far as the debugger is concerned. I
> said mixed because it's got a C var inside a Swift expre
Author: Jonas Devlieghere
Date: 2024-03-15T17:47:04-07:00
New Revision: 113214e15b5ce3f3ec313eb1fa91a7038ecd072f
URL:
https://github.com/llvm/llvm-project/commit/113214e15b5ce3f3ec313eb1fa91a7038ecd072f
DIFF:
https://github.com/llvm/llvm-project/commit/113214e15b5ce3f3ec313eb1fa91a7038ecd072f.d
https://github.com/jimingham created
https://github.com/llvm/llvm-project/pull/85492
The idea behind the address-expression is that it handles all the common
expressions that produce addresses. It handles actual valid expressions that
return a scalar, and it handles useful cases that the vari
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (jimingham)
Changes
The idea behind the address-expression is that it handles all the common
expressions that produce addresses. It handles actual valid expressions that
return a scalar, and it handles useful cases that the various s
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
9405d5af65853ac548cce2656497195010db1d86...59320299f5aa3f9e03695e762c9fec237362c460
lldb/
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 9405d5af65853ac548cce2656497195010db1d86
59320299f5aa3f9e03695e762c9fec237362c460 --
@@ -233,24 +235,57 @@ OptionArgParser::DoToAddress(const ExecutionContext
*exe_ctx, llvm::StringRef s,
// Since the compiler can't handle things like "main + 12" we should try to
// do this for now. The compiler doesn't like adding offsets to function
// pointer types.
+
@@ -233,24 +235,57 @@ OptionArgParser::DoToAddress(const ExecutionContext
*exe_ctx, llvm::StringRef s,
// Since the compiler can't handle things like "main + 12" we should try to
// do this for now. The compiler doesn't like adding offsets to function
// pointer types.
+
@@ -233,24 +235,57 @@ OptionArgParser::DoToAddress(const ExecutionContext
*exe_ctx, llvm::StringRef s,
// Since the compiler can't handle things like "main + 12" we should try to
// do this for now. The compiler doesn't like adding offsets to function
// pointer types.
+
adrian-prantl wrote:
This is going to be incredibly useful, thanks!
https://github.com/llvm/llvm-project/pull/85492
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
57 matches
Mail list logo
