https://github.com/Michael137 approved this pull request.
lgtm thanks!
https://github.com/llvm/llvm-project/pull/83234
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
svs-quic wrote:
> lgtm thanks!
Thanks. I dont think I have commit access . Would you be able to merge this for
me?
https://github.com/llvm/llvm-project/pull/83234
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bi
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/83234
>From cf1359a825b09d48c312ce40da950c13f30c67c8 Mon Sep 17 00:00:00 2001
From: Sudharsan Veeravalli
Date: Wed, 28 Feb 2024 13:46:46 +0530
Subject: [PATCH 1/3] [LLDB] Fix crash when using tab completion on class
Author: Sudharsan Veeravalli
Date: 2024-02-29T09:40:27Z
New Revision: de5518836e16be3fbfce78394adc96d9bf70f2a5
URL:
https://github.com/llvm/llvm-project/commit/de5518836e16be3fbfce78394adc96d9bf70f2a5
DIFF:
https://github.com/llvm/llvm-project/commit/de5518836e16be3fbfce78394adc96d9bf70f2a5.dif
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/83234
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
github-actions[bot] wrote:
@svs-quic Congratulations on having your first Pull Request (PR) merged into
the LLVM Project!
Your changes will be combined with recent changes from other authors, then
tested
by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with
a build
DavidSpickett wrote:
I admit I was too scared of SWIG to look into these myself, but it always
annoyed me that we were only 2 warnings away from a clean build. Thanks for
fixing this!
https://github.com/llvm/llvm-project/pull/83317
___
lldb-commits m
@@ -60,10 +60,12 @@ def test_dwim_print(self):
def do_test_variable_completion(self, command):
self.complete_from_to(f"{command} fo", f"{command} fooo")
-self.complete_from_to(f"{command} fooo.", f"{command} fooo.")
+self.complete_from_to(f"{command
@@ -407,6 +407,118 @@ class LLDB_API SBProcess {
/// the process isn't loaded from a core file.
lldb::SBFileSpec GetCoreFile();
+ /// \{
+ /// \group Mask Address Methods
+ ///
+ /// \a type
+ /// All of the methods in this group take \a type argument
+ /// which
@@ -1255,6 +1255,95 @@ lldb::SBFileSpec SBProcess::GetCoreFile() {
return SBFileSpec(core_file);
}
+addr_t SBProcess::GetAddressMask(AddressMaskType type,
+ AddressMaskRange addr_range) {
+ LLDB_INSTRUMENT_VA(this, type, addr_range);
+ addr_
@@ -33,18 +33,26 @@ void AddressableBits::SetHighmemAddressableBits(
m_high_memory_addr_bits = highmem_addressing_bits;
}
+addr_t AddressableBits::AddressableBitToMask(uint32_t addressable_bits) {
+ assert(addressable_bits <= sizeof(addr_t) * 8);
DavidSpick
@@ -407,6 +407,118 @@ class LLDB_API SBProcess {
/// the process isn't loaded from a core file.
lldb::SBFileSpec GetCoreFile();
+ /// \{
+ /// \group Mask Address Methods
+ ///
+ /// \a type
+ /// All of the methods in this group take \a type argument
+ /// which
https://github.com/svs-quic created
https://github.com/llvm/llvm-project/pull/83406
Missed adding a . in the test check
>From 1e686b765ba8a456f6a53731a2de2f28d41f6a9c Mon Sep 17 00:00:00 2001
From: Sudharsan Veeravalli
Date: Thu, 29 Feb 2024 16:20:35 +0530
Subject: [PATCH] [LLDB] Fix test fail
https://github.com/svs-quic ready_for_review
https://github.com/llvm/llvm-project/pull/83406
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
svs-quic wrote:
@Michael137 could you please help merge this one as well.
https://github.com/llvm/llvm-project/pull/83406
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 approved this pull request.
https://github.com/llvm/llvm-project/pull/83406
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
amordo wrote:
@adrian-prantl, I'll be glad to help:)
dwarf on Win has warnings like `objdump: Warning: DW_FORM_line_strp offset too
big: 0x4008a16c` and no inlined source
here is a part of `$ objdump --dwarf a.out`
([full](https://github.com/amordo/TestInlineSourceFiles.test_dwarf/blob/main/obj
Author: Sudharsan Veeravalli
Date: 2024-02-29T11:02:22Z
New Revision: ee297a73b590ee63f0f4ec9f21c5114c106c8467
URL:
https://github.com/llvm/llvm-project/commit/ee297a73b590ee63f0f4ec9f21c5114c106c8467
DIFF:
https://github.com/llvm/llvm-project/commit/ee297a73b590ee63f0f4ec9f21c5114c106c8467.dif
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/83406
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Sudharsan Veeravalli (svs-quic)
Changes
Missed adding a . in the test check
---
Full diff: https://github.com/llvm/llvm-project/pull/83406.diff
1 Files Affected:
- (modified) lldb/test/API/functionalities/completion/TestCompletion.py (+1
DavidSpickett wrote:
The way the cmake is written it seems that Py_pexpect_FOUND is set to false the
first time you run cmake. Then you install pexpect and lldb_find_python_module
bails early because Py_pexpect_FOUND is *still* set to false.
If you remove the CMake cache it'll then find pexpec
DavidSpickett wrote:
And a data point, AArch64 and Arm Linux are fine with pexpect-4.9.0. Still
working on getting it installed on the bot containers.
https://github.com/llvm/llvm-project/pull/83191
___
lldb-commits mailing list
lldb-commits@lists.llv
DavidSpickett wrote:
FYI @labath as the x86 bot owner.
https://github.com/llvm/llvm-project/pull/83191
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: David Spickett
Date: 2024-02-29T14:22:23Z
New Revision: ec95379df363253ffcbbda21297417e703d5ccca
URL:
https://github.com/llvm/llvm-project/commit/ec95379df363253ffcbbda21297417e703d5ccca
DIFF:
https://github.com/llvm/llvm-project/commit/ec95379df363253ffcbbda21297417e703d5ccca.diff
LOG
DavidSpickett wrote:
> It should perhaps unset the variable first, I'll see if I can implement that.
https://github.com/llvm/llvm-project/commit/ec95379df363253ffcbbda21297417e703d5ccca
https://github.com/llvm/llvm-project/pull/83191
___
lldb-commits
Author: David Spickett
Date: 2024-02-29T14:59:51Z
New Revision: 99824cf7967922bdd9ac895c949f330bb8d6b85a
URL:
https://github.com/llvm/llvm-project/commit/99824cf7967922bdd9ac895c949f330bb8d6b85a
DIFF:
https://github.com/llvm/llvm-project/commit/99824cf7967922bdd9ac895c949f330bb8d6b85a.diff
LOG
Author: Jonas Devlieghere
Date: 2024-02-29T08:08:30-08:00
New Revision: 5a0bd2a36591fe48c24de220a5f8ddef9ce6f0b1
URL:
https://github.com/llvm/llvm-project/commit/5a0bd2a36591fe48c24de220a5f8ddef9ce6f0b1
DIFF:
https://github.com/llvm/llvm-project/commit/5a0bd2a36591fe48c24de220a5f8ddef9ce6f0b1.d
DavidSpickett wrote:
Arm and AArch64 bots now have pexpect 4.9.0 installed.
For Linaro's bots at least, we would be ok with you flipping
`LLDB_TEST_USE_VENDOR_PACKAGES` to `OFF` as the next step. This saves us
getting a change through zorg and should "just work" now.
https://github.com/llvm/l
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/83312
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo approved this pull request.
Other than a missing comment, this LGTM. Thanks!
https://github.com/llvm/llvm-project/pull/83312
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/ma
@@ -6,6 +6,7 @@
class DAPTestCaseBase(TestBase):
+timeoutval = 10 * (10 if ('ASAN_OPTIONS' in os.environ) else 1)
walter-erquinigo wrote:
Please add a comment here mentioning what the purpose of this variable is
https://github.com/llvm/llvm-project/pull
https://github.com/adrian-prantl edited
https://github.com/llvm/llvm-project/pull/83291
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/83291
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -517,6 +520,207 @@ bool ClangASTImporter::CompleteType(const CompilerType
&compiler_type) {
return false;
}
+template
adrian-prantl wrote:
Not your code, but I'm wondering if there's an opportunity here to add a small
doxygen comment to the top of the
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/83295
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/83069
>From 59e3b1da1335261badeace24d6136d924cda6949 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Tue, 20 Feb 2024 13:56:53 -0800
Subject: [PATCH] [lldb][progress] Hook up new broadcast bit and progress
Author: Jonas Devlieghere
Date: 2024-02-29T09:12:20-08:00
New Revision: a6d9b7ba2722953960b83fbacda1757349f00156
URL:
https://github.com/llvm/llvm-project/commit/a6d9b7ba2722953960b83fbacda1757349f00156
DIFF:
https://github.com/llvm/llvm-project/commit/a6d9b7ba2722953960b83fbacda1757349f00156.d
https://github.com/amordo created
https://github.com/llvm/llvm-project/pull/83454
This reverts commit 3434472ed74141848634b5eb3cd625d651e22562.
Closes #43097.
>From 05d72acd675d343ad844b93a2a18e7da9c6d7980 Mon Sep 17 00:00:00 2001
From: Alexander Mordovskiy
Date: Thu, 29 Feb 2024 18:58:28 +01
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Alexander M. (amordo)
Changes
This reverts commit 3434472ed74141848634b5eb3cd625d651e22562.
Closes #43097.
---
Full diff: https://github.com/llvm/llvm-project/pull/83454.diff
1 Files Affected:
- (modified) lldb/test/API/lang/c/local_var
bulbazord wrote:
@DavidSpickett If you haven't already, might I suggest looking into a CMake
setting I implemented last year? `LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS` --
this will cause your CMake configure step to fail if your bots are missing
python packages so that you know your bots are run
https://github.com/rastogishubham updated
https://github.com/llvm/llvm-project/pull/83312
>From cef723783edd5ba89fd5b9b0ec800fa1439ffb90 Mon Sep 17 00:00:00 2001
From: Shubham Sandeep Rastogi
Date: Wed, 28 Feb 2024 10:28:55 -0800
Subject: [PATCH] Increase timeout to reduce test failure rate.
T
Author: Shubham Sandeep Rastogi
Date: 2024-02-29T13:12:03-08:00
New Revision: 82c1bfc44ecee97425582f345d04e787f066b899
URL:
https://github.com/llvm/llvm-project/commit/82c1bfc44ecee97425582f345d04e787f066b899
DIFF:
https://github.com/llvm/llvm-project/commit/82c1bfc44ecee97425582f345d04e787f066
https://github.com/rastogishubham closed
https://github.com/llvm/llvm-project/pull/83312
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/83291
>From 7ffc5c966a7a0542cbde20ead3144344e68e648f Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Wed, 28 Feb 2024 13:32:01 +
Subject: [PATCH 1/2] [lldb][NFC] Move helpers to import record layout into
Clan
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/83291
>From 7ffc5c966a7a0542cbde20ead3144344e68e648f Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Wed, 28 Feb 2024 13:32:01 +
Subject: [PATCH 1/3] [lldb][NFC] Move helpers to import record layout into
Clan
@@ -517,6 +520,207 @@ bool ClangASTImporter::CompleteType(const CompilerType
&compiler_type) {
return false;
}
+template
Michael137 wrote:
done
https://github.com/llvm/llvm-project/pull/83291
___
lldb-commits m
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/83291
>From 7ffc5c966a7a0542cbde20ead3144344e68e648f Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Wed, 28 Feb 2024 13:32:01 +
Subject: [PATCH 1/4] [lldb][NFC] Move helpers to import record layout into
Clan
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 07d8a457ad8bb9a14974b9cb47072746c7f5e489
391e87f97ee17281ef4a91b3cc1ca6cec8626058 --
Author: Michael Buch
Date: 2024-02-29T21:32:28Z
New Revision: 8c1003266520ac396ce2a9e799f318af30efdd19
URL:
https://github.com/llvm/llvm-project/commit/8c1003266520ac396ce2a9e799f318af30efdd19
DIFF:
https://github.com/llvm/llvm-project/commit/8c1003266520ac396ce2a9e799f318af30efdd19.diff
LOG:
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/83291
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/83295
>From 9a6ed480fd407f9a9f12d6faccffbad952de0855 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Wed, 28 Feb 2024 13:52:54 +
Subject: [PATCH] [lldb][ClangASTImporter] Import record layouts from origin if
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/83295
>From 9a6ed480fd407f9a9f12d6faccffbad952de0855 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Wed, 28 Feb 2024 13:52:54 +
Subject: [PATCH] [lldb][ClangASTImporter] Import record layouts from origin if
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/83295
>From 7b3d74a917446ad03e605f57fcf9158eee1d21c5 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Wed, 28 Feb 2024 13:52:54 +
Subject: [PATCH] [lldb][ClangASTImporter] Import record layouts from origin if
Author: Michael Buch
Date: 2024-02-29T21:40:02Z
New Revision: 07ffb7e294767b74e43f90e9ab3d713da929b907
URL:
https://github.com/llvm/llvm-project/commit/07ffb7e294767b74e43f90e9ab3d713da929b907
DIFF:
https://github.com/llvm/llvm-project/commit/07ffb7e294767b74e43f90e9ab3d713da929b907.diff
LOG:
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/83295
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1255,6 +1255,95 @@ lldb::SBFileSpec SBProcess::GetCoreFile() {
return SBFileSpec(core_file);
}
+addr_t SBProcess::GetAddressMask(AddressMaskType type,
+ AddressMaskRange addr_range) {
+ LLDB_INSTRUMENT_VA(this, type, addr_range);
+ addr_
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/83095
>From dae16776e8c97158e8965e4d0e950cd2ce836f75 Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Mon, 26 Feb 2024 18:05:27 -0800
Subject: [PATCH 1/4] [lldb] Add SBProcess methods for get/set/use address
ma
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 86f6caa562255f81b93e72a501a926b17f5ad244
dceaef27675b724309f353aa22999563cf036cd3 --
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/83095
>From dae16776e8c97158e8965e4d0e950cd2ce836f75 Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Mon, 26 Feb 2024 18:05:27 -0800
Subject: [PATCH 1/5] [lldb] Add SBProcess methods for get/set/use address
ma
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/83095
>From dae16776e8c97158e8965e4d0e950cd2ce836f75 Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Mon, 26 Feb 2024 18:05:27 -0800
Subject: [PATCH 1/6] [lldb] Add SBProcess methods for get/set/use address
ma
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/83095
>From dae16776e8c97158e8965e4d0e950cd2ce836f75 Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Mon, 26 Feb 2024 18:05:27 -0800
Subject: [PATCH 1/7] [lldb] Add SBProcess methods for get/set/use address
ma
@@ -33,18 +33,26 @@ void AddressableBits::SetHighmemAddressableBits(
m_high_memory_addr_bits = highmem_addressing_bits;
}
+addr_t AddressableBits::AddressableBitToMask(uint32_t addressable_bits) {
+ assert(addressable_bits <= sizeof(addr_t) * 8);
jasonmolen
https://github.com/jasonmolenda edited
https://github.com/llvm/llvm-project/pull/83095
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/83095
>From dae16776e8c97158e8965e4d0e950cd2ce836f75 Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Mon, 26 Feb 2024 18:05:27 -0800
Subject: [PATCH 1/8] [lldb] Add SBProcess methods for get/set/use address
ma
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/83069
>From 5fcab5d9b7af70861bbc46f096032dce7de41517 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Tue, 20 Feb 2024 13:56:53 -0800
Subject: [PATCH] [lldb][progress] Hook up new broadcast bit and progress
https://github.com/JDevlieghere approved this pull request.
LGTM but please fix the formatting issue before merging.
https://github.com/llvm/llvm-project/pull/83095
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-b
https://github.com/adrian-prantl created
https://github.com/llvm/llvm-project/pull/83501
In the end this value comes from TypeSystem::GetNumChildren which returns a
uint32_t, so ValueObject should be consistent with that.
>From 056c198efc3c224cb87edbd8f56344bdbb3e204a Mon Sep 17 00:00:00 2001
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Adrian Prantl (adrian-prantl)
Changes
In the end this value comes from TypeSystem::GetNumChildren which returns a
uint32_t, so ValueObject should be consistent with that.
---
Full diff: https://github.com/llvm/llvm-project/pull/83501.diff
https://github.com/chelcassanova created
https://github.com/llvm/llvm-project/pull/83502
The `details` field in the constructor for `Progress` is missing Doxygen
documentation, this commit adds this.
>From 7b26213416e45853514e98d5043255ccd42153a9 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanov
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Chelsea Cassanova (chelcassanova)
Changes
The `details` field in the constructor for `Progress` is missing Doxygen
documentation, this commit adds this.
---
Full diff: https://github.com/llvm/llvm-project/pull/83502.diff
1 Files Affected
https://github.com/kastiglione approved this pull request.
https://github.com/llvm/llvm-project/pull/83501
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/83501
>From 44e21455e042a674f12f872be24ca9b7bb7d6dec Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Thu, 29 Feb 2024 15:06:28 -0800
Subject: [PATCH 1/2] Change the return type of
ValueObject::CalculateNumChi
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 21be2fbd17f9ff6f3f04e0ababc91c9cdd5aed85
242da8f612a4d7ce4f58d4e61be05dff711e469f --
https://github.com/kastiglione created
https://github.com/llvm/llvm-project/pull/83504
None
>From 969f441344e179c9167fe707cf8f01edae6dbfc5 Mon Sep 17 00:00:00 2001
From: Dave Lee
Date: Thu, 29 Feb 2024 15:38:22 -0800
Subject: [PATCH] [lldb] Extract getter function for experimental target
prop
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dave Lee (kastiglione)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/83504.diff
2 Files Affected:
- (modified) lldb/include/lldb/Target/Target.h (+4-2)
- (modified) lldb/source/Target/Target.cpp (+9-15)
``
https://github.com/kastiglione edited
https://github.com/llvm/llvm-project/pull/83504
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -4227,28 +4228,21 @@ void TargetProperties::UpdateLaunchInfoFromProperties()
{
DisableSTDIOValueChangedCallback();
}
-bool TargetProperties::GetInjectLocalVariables(
-ExecutionContext *exe_ctx) const {
+std::optional TargetProperties::GetExperimentalPropertyValue(
+
jimingham wrote:
Theoretically someone could make a synthetic type or an array with more than
UINT32_MAX elements, and with this change we can't support displaying that. I
did get one bug report that this didn't work a few years back, though this
likely a very uncommon case. If it were easy
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/82593
>From 0ba4e6402969028fa6152c366a56063a56acded1 Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Wed, 21 Feb 2024 22:48:36 -0800
Subject: [PATCH 1/2] [lldb] [debugserver] fix qLaunchSuccess error, add
QErr
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/83095
>From dae16776e8c97158e8965e4d0e950cd2ce836f75 Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Mon, 26 Feb 2024 18:05:27 -0800
Subject: [PATCH 1/9] [lldb] Add SBProcess methods for get/set/use address
ma
https://github.com/jasonmolenda edited
https://github.com/llvm/llvm-project/pull/82593
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jasonmolenda updated
https://github.com/llvm/llvm-project/pull/82593
>From 0ba4e6402969028fa6152c366a56063a56acded1 Mon Sep 17 00:00:00 2001
From: Jason Molenda
Date: Wed, 21 Feb 2024 22:48:36 -0800
Subject: [PATCH 1/3] [lldb] [debugserver] fix qLaunchSuccess error, add
QErr
jasonmolenda wrote:
Going back to this PR, @bulbazord @clayborg and I agreed that having a single
method for sending error reply packets, which correctly encode the error string
it if is available and extended-error-responses has been enabled, would be
worth modifying all the error returns, so
Author: Jason Molenda
Date: 2024-02-29T17:02:42-08:00
New Revision: 9a12b0a60084b2b92f728e1bddec884a47458459
URL:
https://github.com/llvm/llvm-project/commit/9a12b0a60084b2b92f728e1bddec884a47458459
DIFF:
https://github.com/llvm/llvm-project/commit/9a12b0a60084b2b92f728e1bddec884a47458459.diff
https://github.com/jasonmolenda closed
https://github.com/llvm/llvm-project/pull/83095
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jason Molenda
Date: 2024-02-29T17:29:24-08:00
New Revision: e8ce864a36ba02ddb63877905d49f1e9ac60b544
URL:
https://github.com/llvm/llvm-project/commit/e8ce864a36ba02ddb63877905d49f1e9ac60b544
DIFF:
https://github.com/llvm/llvm-project/commit/e8ce864a36ba02ddb63877905d49f1e9ac60b544.diff
jasonmolenda wrote:
Temporarily reverted this change while I investigate why the tests failed on
all the linux bots (lldb-x86_64-debian, lldb-arm-ubuntu, lldb-aarch64-ubuntu),
I'll build up in a VM and debug.
https://github.com/llvm/llvm-project/pull/83095
_
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/83502
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/83502
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
Thanks!
https://github.com/llvm/llvm-project/pull/83454
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Alexander M
Date: 2024-02-29T18:23:12-08:00
New Revision: 5b6e58c565cf809e4133a10ff9d9b096754bea1e
URL:
https://github.com/llvm/llvm-project/commit/5b6e58c565cf809e4133a10ff9d9b096754bea1e
DIFF:
https://github.com/llvm/llvm-project/commit/5b6e58c565cf809e4133a10ff9d9b096754bea1e.diff
L
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/83454
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
github-actions[bot] wrote:
@amordo Congratulations on having your first Pull Request (PR) merged into the
LLVM Project!
Your changes will be combined with recent changes from other authors, then
tested
by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with
a build,
https://github.com/JDevlieghere approved this pull request.
LGMT, thanks for improving this!
https://github.com/llvm/llvm-project/pull/83504
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/83069
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/83069
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -22,38 +23,47 @@ std::atomic Progress::g_id(0);
Progress::Progress(std::string title, std::string details,
std::optional total,
lldb_private::Debugger *debugger)
-: m_title(title), m_details(details), m_id(++g_id), m_completed(0),
-
https://github.com/bulbazord approved this pull request.
Looks great!!! 😄 Thanks for fixing the bug and gardening!
https://github.com/llvm/llvm-project/pull/82593
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/
bulbazord wrote:
Why not increase TypeSystem::GetNumChildren to return a size_t instead?
https://github.com/llvm/llvm-project/pull/83501
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm
1 - 100 of 112 matches
Mail list logo
