[Lldb-commits] [lldb] Fix a crasher when using the public API. (PR #80508)

2024-02-03 Thread via lldb-commits
@@ -1089,9 +1089,9 @@ void SBDebugger::SetSelectedTarget(SBTarget &sb_target) { Log *log = GetLog(LLDBLog::API); TargetSP target_sp(sb_target.GetSP()); - if (m_opaque_sp) { + if (m_opaque_sp && target_sp) m_opaque_sp->GetTargetList().SetSelectedTarget(target_sp); -

[Lldb-commits] [lldb] Fix a crasher when using the public API. (PR #80508)

2024-02-03 Thread via lldb-commits
https://github.com/kusmour edited https://github.com/llvm/llvm-project/pull/80508 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix a crasher when using the public API. (PR #80508)

2024-02-03 Thread via lldb-commits
https://github.com/kusmour requested changes to this pull request. probs should remove the irrelevant whitespace changes Otherwise looking good! https://github.com/llvm/llvm-project/pull/80508 ___ lldb-commits mailing list lldb-commits@lists.llvm.org h

[Lldb-commits] [lldb] Fix a crasher when using the public API. (PR #80508)

2024-02-03 Thread via lldb-commits
@@ -1089,9 +1089,9 @@ void SBDebugger::SetSelectedTarget(SBTarget &sb_target) { Log *log = GetLog(LLDBLog::API); TargetSP target_sp(sb_target.GetSP()); - if (m_opaque_sp) { + if (m_opaque_sp && target_sp) m_opaque_sp->GetTargetList().SetSelectedTarget(target_sp); --

[Lldb-commits] [llvm] [clang-tools-extra] [mlir] [libc] [libcxx] [lldb] [libcxxabi] [clang] [lld] [compiler-rt] [flang] [Mips] Fix unable to handle inline assembly ends with compat-branch o… (PR #7729

2024-02-03 Thread via lldb-commits
yingopq wrote: @MaskRay Hi, this issue is https://reviews.llvm.org/D158589, which you have reviewed before. Could you help review this patch at your convenience? Thanks. https://github.com/llvm/llvm-project/pull/77291 ___ lldb-commits mailing list ll

[Lldb-commits] [llvm] [clang-tools-extra] [mlir] [libc] [libcxx] [lldb] [libcxxabi] [clang] [lld] [compiler-rt] [flang] [Mips] Fix unable to handle inline assembly ends with compat-branch o… (PR #7729

2024-02-03 Thread Jessica Clarke via lldb-commits
jrtc27 wrote: What assembly does GCC emit, and how does GNU as deal with that assembly? That is, how do those two tools interact in the GNU world when dealing with forbidden slots? https://github.com/llvm/llvm-project/pull/77291 ___ lldb-commits mail