[Lldb-commits] [lldb] [lldb] Store SupportFile in LineEntry (NFC) (PR #77999)

2024-01-12 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes This is a series of 4 NFC commit to store `SupportFile`s rather than `FileSpec`s in `LineEntry`. This is work towards having the `SourceManager`operate on `SupportFile`s so that it can (1) validate

[Lldb-commits] [lldb] [lldb] Store SupportFile in LineEntry (NFC) (PR #77999)

2024-01-12 Thread Adrian Prantl via lldb-commits
@@ -20,7 +20,7 @@ LineEntry::LineEntry() void LineEntry::Clear() { range.Clear(); file.Clear(); - original_file.Clear(); + original_file = std::make_shared(); adrian-prantl wrote: Is this default-constructing an empty object? Should it be a null shared_p

[Lldb-commits] [lldb] [lldb] Store SupportFile in LineEntry (NFC) (PR #77999)

2024-01-12 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/77999 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Store SupportFile in LineEntry (NFC) (PR #77999)

2024-01-12 Thread Jonas Devlieghere via lldb-commits
@@ -20,7 +20,7 @@ LineEntry::LineEntry() void LineEntry::Clear() { range.Clear(); file.Clear(); - original_file.Clear(); + original_file = std::make_shared(); JDevlieghere wrote: Correct, this ensures I can always assume that the shared pointer is valid.

[Lldb-commits] [lldb] [lldb] Store SupportFile in LineEntry (NFC) (PR #77999)

2024-01-12 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben approved this pull request. LGTM with nits https://github.com/llvm/llvm-project/pull/77999 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Store SupportFile in LineEntry (NFC) (PR #77999)

2024-01-12 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben edited https://github.com/llvm/llvm-project/pull/77999 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Store SupportFile in LineEntry (NFC) (PR #77999)

2024-01-12 Thread Med Ismail Bennani via lldb-commits
@@ -133,7 +134,8 @@ struct LineEntry { AddressRange range; ///< The section offset address range for this line entry. FileSpec file; ///< The source file, possibly mapped by the target.source-map ///setting - FileSpec original_file; ///< The original sour

[Lldb-commits] [lldb] [lldb] Store SupportFile in LineEntry (NFC) (PR #77999)

2024-01-12 Thread Med Ismail Bennani via lldb-commits
@@ -357,7 +357,7 @@ void LineTable::Dump(Stream *s, Target *target, Address::DumpStyle style, Address::DumpStyle fallback_style, bool show_line_ranges) { const size_t count = m_entries.size(); LineEntry line_entry; - FileSpec prev_file; + SupportFil

[Lldb-commits] [clang-tools-extra] [libcxx] [clang] [flang] [lldb] [llvm] [mlir] [X86] Add "Ws" constraint and "p" modifier for symbolic address/label reference (PR #77886)

2024-01-12 Thread Phoebe Wang via lldb-commits
@@ -5336,6 +5336,7 @@ X86: operand in a SSE register. If AVX is also enabled, can also be a 256-bit vector operand in an AVX register. If AVX-512 is also enabled, can also be a 512-bit vector operand in an AVX512 register. Otherwise, an error. +- ``Ws``: A symbolic refere

[Lldb-commits] [lldb] Work around a bug in the interaction between newer dyld's and older simulator dyld's (PR #78004)

2024-01-12 Thread via lldb-commits
https://github.com/jimingham created https://github.com/llvm/llvm-project/pull/78004 There's a bad interaction between the macOS 14 dyld and the "dyld_sim" shim that comes from older (iOS 15) simulator downloads that results in dyld reporting some modules twice in the return from the dyld cal

[Lldb-commits] [lldb] Work around a bug in the interaction between newer dyld's and older simulator dyld's (PR #78004)

2024-01-12 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (jimingham) Changes There's a bad interaction between the macOS 14 dyld and the "dyld_sim" shim that comes from older (iOS 15) simulator downloads that results in dyld reporting some modules twice in the return from the dyld callback

[Lldb-commits] [lldb] [lldb-dap] Adjusting how repl-mode auto determines commands vs variable expressions. (PR #78005)

2024-01-12 Thread John Harrison via lldb-commits
https://github.com/ashgti created https://github.com/llvm/llvm-project/pull/78005 The previous logic for determining if an expression was a command or variable expression in the repl would incorrectly identify the context in many common cases where a local variable name partially overlaps with

[Lldb-commits] [lldb] [lldb-dap] Adjusting how repl-mode auto determines commands vs variable expressions. (PR #78005)

2024-01-12 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: John Harrison (ashgti) Changes The previous logic for determining if an expression was a command or variable expression in the repl would incorrectly identify the context in many common cases where a local variable name partially overlaps

[Lldb-commits] [lldb] [lldb-dap] Adjusting how repl-mode auto determines commands vs variable expressions. (PR #78005)

2024-01-12 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 3edf82d5566ed5c9898f52b5591c05f6366d6bac...6290aaa803324f6942e642b888f41966f4cc3709 lldb/

[Lldb-commits] [lldb] Work around a bug in the interaction between newer dyld's and older simulator dyld's (PR #78004)

2024-01-12 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda approved this pull request. LGTM. debugserver never expects libdyld's API (to iterate over the binary images in a process) to return the same binary multiple times, and lldb won't handle that well if we pass that behavior along. Eliminating the incorrect dupli

[Lldb-commits] [lldb] [lldb-dap] Adjusting how repl-mode auto determines commands vs variable expressions. (PR #78005)

2024-01-12 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/78005 >From 09f1556fd0615f42fe9dd49bf8c2355517f6e0da Mon Sep 17 00:00:00 2001 From: John Harrison Date: Fri, 12 Jan 2024 16:39:47 -0800 Subject: [PATCH] [lldb-dap] Adjusting how repl-mode auto determines commands vs va

[Lldb-commits] [lldb] [libc] [compiler-rt] [libcxxabi] [flang] [libcxx] [clang-tools-extra] [lld] [clang] [llvm] [Flang][OpenMP] Push genEval calls to individual operations, NFC (PR #77758)

2024-01-12 Thread Krzysztof Parzyszek via lldb-commits
https://github.com/kparzysz updated https://github.com/llvm/llvm-project/pull/77758 >From 62f31654ec66fe0e2a27200d0484d3c70d4ce2c1 Mon Sep 17 00:00:00 2001 From: Krzysztof Parzyszek Date: Wed, 20 Dec 2023 15:12:04 -0600 Subject: [PATCH 1/5] [Flang][OpenMP] Separate creation of work-sharing and

[Lldb-commits] [lldb] [libc] [compiler-rt] [libcxxabi] [flang] [libcxx] [clang-tools-extra] [lld] [clang] [llvm] [Flang][OpenMP] Push genEval calls to individual operations, NFC (PR #77758)

2024-01-12 Thread Krzysztof Parzyszek via lldb-commits
@@ -3655,8 +3661,7 @@ void Fortran::lower::genOpenMPDeclarativeConstruct( Fortran::lower::pft::Evaluation &eval, const Fortran::parser::OpenMPDeclarativeConstruct &omp) { genOMP(converter, eval, omp); kparzysz wrote: I made all `genOMP` functions hav

[Lldb-commits] [lldb] [lldb][Progress] Separate title and details (PR #77547)

2024-01-12 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/77547 >From 44a3cdca21bc9c2aa24eeaf5d82c8b8af382bfa7 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Tue, 9 Jan 2024 18:32:06 -0800 Subject: [PATCH 1/6] [lldb][Progress] Separate title and details Per thi

<    1   2