[Lldb-commits] [lldb] Add settings and code that limits the number of progress events. (PR #75769)

2024-01-10 Thread Greg Clayton via lldb-commits
@@ -1430,6 +1445,279 @@ void Debugger::SetDestroyCallback( m_destroy_callback_baton = baton; } + + /// Notify the progress thread that there is new progress data. +void Debugger::NotifyProgress(std::unique_ptr &data_up) { + // Start the progress thread if it isn't already

[Lldb-commits] [lldb] [lldb-dap] Updating VariableDescription to use GetDescription() as a fallback. (PR #77026)

2024-01-10 Thread Greg Clayton via lldb-commits
clayborg wrote: > > Looks fine to me. Can we add a test? > > Updated the existing tests to check the adjusted format. > > One issue I did notice with tests is that the response to an expression will > include a response are automatically persisted by > `SBValue::GetDescription()`, so you will

[Lldb-commits] [lldb] [lldb-dap] Updating VariableDescription to use GetDescription() as a fallback. (PR #77026)

2024-01-10 Thread Greg Clayton via lldb-commits
clayborg wrote: Is there a way we can tell that the request is from the console and only enable this feature if we are going to dump it to the debug console? https://github.com/llvm/llvm-project/pull/77026 ___ lldb-commits mailing list lldb-commits@li

[Lldb-commits] [lldb] [lldb] Add color support to StreamString (PR #77380)

2024-01-10 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. https://github.com/llvm/llvm-project/pull/77380 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [clang-tools-extra] [libcxx] [llvm] [flang] [libc] [compiler-rt] [clang] [flang] FDATE extension implementation: get date and time in ctime format (PR #71222)

2024-01-10 Thread via lldb-commits
https://github.com/jeanPerier approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/71222 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang-tools-extra] [libc] [mlir] [lld] [libcxx] [libclc] [llvm] [clang] [flang] [libunwind] [lldb] [compiler-rt] [AMDGPU] Fix broken sign-extended subword buffer load combine (PR #7747

2024-01-10 Thread Jay Foad via lldb-commits
https://github.com/jayfoad closed https://github.com/llvm/llvm-project/pull/77470 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][ClangASTImporter][NFC] Remove redundant do-while loop (PR #77596)

2024-01-10 Thread Michael Buch via lldb-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/77596 This seems to have always been a redundant do-while since its introduction in `2e93a2ad2148d19337bf5f9885e46e3c00e8ab82`. >From 5c439cb2bb04ce19c198d8a7120dc369d567f210 Mon Sep 17 00:00:00 2001 From: Michael

[Lldb-commits] [lldb] [lldb][ClangASTImporter][NFC] Remove redundant do-while loop (PR #77596)

2024-01-10 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes This seems to have always been a redundant do-while since its introduction in `2e93a2ad2148d19337bf5f9885e46e3c00e8ab82`. --- Full diff: https://github.com/llvm/llvm-project/pull/77596.diff 1 Files Affec

[Lldb-commits] [lldb] [lldb][ClangASTImporter][NFC] Remove redundant do-while loop (PR #77596)

2024-01-10 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 786cf76f434d2691878067dedb8b1eb99472810b 5c439cb2bb04ce19c198d8a7120dc369d567f210 --

[Lldb-commits] [lldb] [lldb][ClangASTImporter][NFC] Remove redundant do-while loop (PR #77596)

2024-01-10 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan approved this pull request. https://github.com/llvm/llvm-project/pull/77596 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][ClangASTImporter][NFC] Remove redundant do-while loop (PR #77596)

2024-01-10 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/77596 >From 5c439cb2bb04ce19c198d8a7120dc369d567f210 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Wed, 10 Jan 2024 12:30:53 + Subject: [PATCH 1/2] [lldb][ClangASTImporter][NFC] Remove redundant do-while lo

[Lldb-commits] [libc] [compiler-rt] [libclc] [clang] [llvm] [clang-tools-extra] [lld] [flang] [lldb] [libunwind] [libcxx] [clang] Add tests for DRs about complete-class context (PR #77444)

2024-01-10 Thread Vlad Serebrennikov via lldb-commits
https://github.com/Endilll updated https://github.com/llvm/llvm-project/pull/77444 >From 1cbf8eec15112cd6871fcfb69425c62f08c8f681 Mon Sep 17 00:00:00 2001 From: Vlad Serebrennikov Date: Tue, 9 Jan 2024 14:17:21 +0300 Subject: [PATCH 1/2] [clang] Add tests for DRs about complete-class context MI

[Lldb-commits] [lldb] [lldb][ClangASTImporter][NFC] Remove redundant do-while loop (PR #77596)

2024-01-10 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/77596 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 5c0b3a0 - [lldb][ClangASTImporter][NFC] Remove redundant do-while loop (#77596)

2024-01-10 Thread via lldb-commits
Author: Michael Buch Date: 2024-01-10T13:08:11Z New Revision: 5c0b3a0cb7f70db3ebcd195596e5fadc12d0bc9c URL: https://github.com/llvm/llvm-project/commit/5c0b3a0cb7f70db3ebcd195596e5fadc12d0bc9c DIFF: https://github.com/llvm/llvm-project/commit/5c0b3a0cb7f70db3ebcd195596e5fadc12d0bc9c.diff LOG:

[Lldb-commits] [lldb] [clang] [lld] [clang-tools-extra] [openmp] [flang] [mlir] [llvm] [libunwind] [GVNSink] Fix #77415: GVNSink fails to optimize LLVM IR with debug info (PR #77602)

2024-01-10 Thread Shan Huang via lldb-commits
https://github.com/Apochens created https://github.com/llvm/llvm-project/pull/77602 This PR fixes issue #77415 and is revised from PR #77419 . PR #77419 breaks the newly added test in the same PR on windows, because GVNSink is non-deterministic when sorting `BasicBlock*` pointers. This is ref

[Lldb-commits] [lldb] [clang] [lld] [clang-tools-extra] [openmp] [flang] [mlir] [llvm] [libunwind] [GVNSink] Fix #77415: GVNSink fails to optimize LLVM IR with debug info (PR #77602)

2024-01-10 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-transforms Author: Shan Huang (Apochens) Changes This PR fixes issue #77415 and is revised from PR #77419 . PR #77419 breaks the newly added test in the same PR on windows, because GVNSink is non-deterministic when sorting `BasicBlock*` pointers.

[Lldb-commits] [llvm] [lldb] [clang-tools-extra] [clang] [libunwind] [lld] [flang] [mlir] [openmp] [GVNSink] Fix #77415: GVNSink fails to optimize LLVM IR with debug info (PR #77602)

2024-01-10 Thread Shan Huang via lldb-commits
https://github.com/Apochens updated https://github.com/llvm/llvm-project/pull/77602 >From d08af0b38d28726bc78c8da675ea01d7c188c446 Mon Sep 17 00:00:00 2001 From: Apochens <52285902...@stu.ecnu.edu.cn> Date: Wed, 10 Jan 2024 07:10:22 + Subject: [PATCH 1/2] [GVNSink] Fix #77415: GVNSink fails

[Lldb-commits] [flang] [mlir] [libunwind] [lld] [clang-tools-extra] [llvm] [clang] [openmp] [lldb] [compiler-rt] [BranchFolding] Fix missing predecessors of landing-pad (PR #77608)

2024-01-10 Thread via lldb-commits
https://github.com/HaohaiWen updated https://github.com/llvm/llvm-project/pull/77608 >From 80a650763278061630e6ff5635bbc3a2dacc093e Mon Sep 17 00:00:00 2001 From: Haohai Wen Date: Wed, 10 Jan 2024 16:09:00 +0800 Subject: [PATCH 1/2] [BranchFolding][SEH] Add test to track SEH CFG optimization

[Lldb-commits] [flang] [mlir] [libunwind] [lld] [clang-tools-extra] [llvm] [clang] [openmp] [lldb] [compiler-rt] [BranchFolding] Fix missing predecessors of landing-pad (PR #77608)

2024-01-10 Thread via lldb-commits
HaohaiWen wrote: > > This keeps CFG as only have one entry which is required by LiveDebugValues > > If we just want to make LiveDebugValues happy, should it better to remove > these died BB instead? This died BB was already removed by BranchFolder. See rebased test diff. We just want to salva

[Lldb-commits] [flang] [mlir] [libunwind] [lld] [clang-tools-extra] [llvm] [clang] [openmp] [lldb] [compiler-rt] [BranchFolding] Fix missing predecessors of landing-pad (PR #77608)

2024-01-10 Thread via lldb-commits
@@ -1363,6 +1363,14 @@ bool BranchFolder::OptimizeBlock(MachineBasicBlock *MBB) { MachineBasicBlock *Pred = *(MBB->pred_end()-1); Pred->ReplaceUsesOfBlockWith(MBB, &*FallThrough); } + // Add rest successors of MBB to successors of FallThrough. Those

[Lldb-commits] [flang] [mlir] [libunwind] [lld] [clang-tools-extra] [llvm] [clang] [openmp] [lldb] [compiler-rt] [BranchFolding] Fix missing predecessors of landing-pad (PR #77608)

2024-01-10 Thread via lldb-commits
https://github.com/HaohaiWen edited https://github.com/llvm/llvm-project/pull/77608 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [llvm] [lldb] [clang-tools-extra] [clang] [libunwind] [libc] [compiler-rt] [flang] [lld] [libclc] [mlir] [libcxx] [mlir][tensor] Enhance pack/unpack simplification for identity outer_di

2024-01-10 Thread Han-Chung Wang via lldb-commits
https://github.com/hanhanW updated https://github.com/llvm/llvm-project/pull/77409 >From e74b859897cdf1b1effbbd48a4e5376a231f7132 Mon Sep 17 00:00:00 2001 From: hanhanW Date: Mon, 8 Jan 2024 20:17:30 -0800 Subject: [PATCH 1/2] [mlir][tensor] Enhance pack/unpack simplication patterns for identi

[Lldb-commits] [mlir] [lldb] [clang-tools-extra] [openmp] [libunwind] [llvm] [flang] [clang] [lld] [GVNSink] Fix #77415: GVNSink fails to optimize LLVM IR with debug info (PR #77602)

2024-01-10 Thread Shan Huang via lldb-commits
https://github.com/Apochens updated https://github.com/llvm/llvm-project/pull/77602 >From d08af0b38d28726bc78c8da675ea01d7c188c446 Mon Sep 17 00:00:00 2001 From: Apochens <52285902...@stu.ecnu.edu.cn> Date: Wed, 10 Jan 2024 07:10:22 + Subject: [PATCH 1/3] [GVNSink] Fix #77415: GVNSink fails

[Lldb-commits] [lldb] [lldb] Implement WebAssembly debugging (PR #76683)

2024-01-10 Thread Paolo Severini via lldb-commits
https://github.com/paolosevMSFT updated https://github.com/llvm/llvm-project/pull/76683 >From 739b26b03fd3661d1c22b975e241cbbe60ca6531 Mon Sep 17 00:00:00 2001 From: Paolo Severini Date: Mon, 1 Jan 2024 06:55:40 -0800 Subject: [PATCH 1/3] [lldb] Implement WebAssembly debugging Add support for

[Lldb-commits] [lldb] [lldb][Progress] Separate title and details (PR #77547)

2024-01-10 Thread Chelsea Cassanova via lldb-commits
@@ -69,7 +69,8 @@ class Progress { /// /// @param [in] debugger An optional debugger pointer to specify that this /// progress is to be reported only to specific debuggers. - Progress(std::string title, uint64_t total = UINT64_MAX, + Progress(std::string title, std::str

[Lldb-commits] [lldb] Fix lldb-dap pickProcess command for selecting process for debugger attachment (PR #75342)

2024-01-10 Thread Walter Erquinigo via lldb-commits
walter-erquinigo wrote: @Dodzey, the typescript extension has been merged and, if you want, you can implement an integrated process picker for lldb-dap. https://github.com/llvm/llvm-project/pull/75342 ___ lldb-commits mailing list lldb-commits@lists.l

[Lldb-commits] [libcxx] [libc] [lld] [clang-tools-extra] [libclc] [lldb] [llvm] [clang] [compiler-rt] [flang] [mlir] [libunwind] [mlir][tensor] Enhance pack/unpack simplification for identity outer_di

2024-01-10 Thread Han-Chung Wang via lldb-commits
https://github.com/hanhanW closed https://github.com/llvm/llvm-project/pull/77409 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [openmp] [flang] [mlir] [lldb] [clang-tools-extra] [llvm] [libcxx] [lld] [compiler-rt] [clang] [clang] Add `intrin0.h` header to mimic `intrin0.h` used by MSVC STL for clang-cl (PR #757

2024-01-10 Thread Max Winkler via lldb-commits
MaxEW707 wrote: > Users (Chromium included) use recent versions of Clang that are not vendored > by Microsoft. Users can also use the LLVM OSS releases. I think most users > probably won't notice the compile time regression, and it will silently go > away the next time the update MSVC, but if

[Lldb-commits] [lldb] [lldb-dap] Updating VariableDescription to use GetDescription() as a fallback. (PR #77026)

2024-01-10 Thread Walter Erquinigo via lldb-commits
walter-erquinigo wrote: Now that I think of it, it would be really nice if GetDescription() could get a `one_line` flag that prints the description as a single line. Then the rendering will be much better on vscode, because we already dump the children of each object anyway. https://github.co

[Lldb-commits] [lldb] [lldb][[DWARFDeclContext] Add function to extract qualified names as vector (PR #77349)

2024-01-10 Thread Felipe de Azevedo Piovezan via lldb-commits
@@ -68,6 +68,11 @@ class DWARFDeclContext { const char *GetQualifiedName() const; + /// Returns a vector of string, one string per entry in the fully qualified + /// name. For example, for the DeclContext `A::B::C`, this methods returns + /// `{"C", "B", "A"}` + llvm::S

[Lldb-commits] [lldb] [lldb] Add color support to StreamString (PR #77380)

2024-01-10 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl closed https://github.com/llvm/llvm-project/pull/77380 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] cd7eaaa - [lldb] Add color support to StreamString (#77380)

2024-01-10 Thread via lldb-commits
Author: Pete Lawrence Date: 2024-01-10T10:13:14-08:00 New Revision: cd7eaaa6db0dc9a00a097ba8e6ebad6fb2dec56a URL: https://github.com/llvm/llvm-project/commit/cd7eaaa6db0dc9a00a097ba8e6ebad6fb2dec56a DIFF: https://github.com/llvm/llvm-project/commit/cd7eaaa6db0dc9a00a097ba8e6ebad6fb2dec56a.diff

[Lldb-commits] [lldb] [lldb][Progress] Separate title and details (PR #77547)

2024-01-10 Thread Chelsea Cassanova via lldb-commits
@@ -519,8 +519,7 @@ void SymbolFileDWARF::InitializeObject() { if (apple_names.GetByteSize() > 0 || apple_namespaces.GetByteSize() > 0 || apple_types.GetByteSize() > 0 || apple_objc.GetByteSize() > 0) { - Progress progress(llvm::formatv("Loading Apple DWARF in

[Lldb-commits] [lldb] [lldb][Progress] Separate title and details (PR #77547)

2024-01-10 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/77547 >From 44a3cdca21bc9c2aa24eeaf5d82c8b8af382bfa7 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Tue, 9 Jan 2024 18:32:06 -0800 Subject: [PATCH 1/3] [lldb][Progress] Separate title and details Per thi

[Lldb-commits] [compiler-rt] [libc] [flang] [llvm] [libcxx] [clang-tools-extra] [lld] [lldb] [clang] [libc++][ranges] P2116R9: Implements `views::enumerate` (PR #73617)

2024-01-10 Thread Louis Dionne via lldb-commits
https://github.com/ldionne ready_for_review https://github.com/llvm/llvm-project/pull/73617 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [compiler-rt] [llvm] [lldb] [clang-tools-extra] [libc] [libclc] [mlir] [openmp] [lld] [clang] [libcxx] [libcxxabi] [flang] [libunwind] [libc++][ranges] Implement ranges::contains_subran

2024-01-10 Thread via lldb-commits
https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/66963 >From 647f5fe641b30c874bab770fced9fcec9b601161 Mon Sep 17 00:00:00 2001 From: Zijun Zhao Date: Wed, 13 Sep 2023 14:26:01 -0700 Subject: [PATCH 01/15] [libc++] Implement ranges::contains_subrange --- libcxx

[Lldb-commits] [libc] [clang-tools-extra] [flang] [libcxx] [lld] [compiler-rt] [libunwind] [llvm] [libclc] [lldb] [clang] [clang] Add tests for DRs about complete-class context (PR #77444)

2024-01-10 Thread Vlad Serebrennikov via lldb-commits
https://github.com/Endilll updated https://github.com/llvm/llvm-project/pull/77444 >From 1cbf8eec15112cd6871fcfb69425c62f08c8f681 Mon Sep 17 00:00:00 2001 From: Vlad Serebrennikov Date: Tue, 9 Jan 2024 14:17:21 +0300 Subject: [PATCH 1/3] [clang] Add tests for DRs about complete-class context MI

[Lldb-commits] [lldb] [libcxx] [clang-tools-extra] [flang] [libc] [lld] [llvm] [compiler-rt] [clang] [libc++][variant] P2637R3: Member `visit` (`std::variant`) (PR #76447)

2024-01-10 Thread Louis Dionne via lldb-commits
https://github.com/ldionne ready_for_review https://github.com/llvm/llvm-project/pull/76447 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [libcxx] [clang-tools-extra] [libcxxabi] [mlir] [flang] [libc] [lld] [libclc] [libunwind] [llvm] [openmp] [compiler-rt] [clang] [libc++][ranges] Implement ranges::contains_subran

2024-01-10 Thread Louis Dionne via lldb-commits
https://github.com/ldionne ready_for_review https://github.com/llvm/llvm-project/pull/66963 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Updating VariableDescription to use GetDescription() as a fallback. (PR #77026)

2024-01-10 Thread John Harrison via lldb-commits
ashgti wrote: > Is there a way we can tell that the request is from the console and only > enable this feature if we are going to dump it to the debug console? Yea, the DAP has a context we can use to limit this https://microsoft.github.io/debug-adapter-protocol/specification#Requests_Evaluate

[Lldb-commits] [lldb] Fix debug info size statistics for split dwarf (PR #77671)

2024-01-10 Thread via lldb-commits
https://github.com/jeffreytan81 created https://github.com/llvm/llvm-project/pull/77671 `statistics dump` command relies on `SymbolFile::GetDebugInfoSize()` to get total debug info size. The current implementation is missing debug info for split dwarf scenarios which requires getting debug in

[Lldb-commits] [lldb] Fix debug info size statistics for split dwarf (PR #77671)

2024-01-10 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (jeffreytan81) Changes `statistics dump` command relies on `SymbolFile::GetDebugInfoSize()` to get total debug info size. The current implementation is missing debug info for split dwarf scenarios which requires getting debug info fr

[Lldb-commits] [lldb] Fix debug info size statistics for split dwarf (PR #77671)

2024-01-10 Thread Greg Clayton via lldb-commits
https://github.com/clayborg commented: Looks good, need to add tests for: - split dwarf with .dwo files - split dwarf with .dwp file https://github.com/llvm/llvm-project/pull/77671 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists

[Lldb-commits] [lldb] [lldb-dap] Updating VariableDescription to use GetDescription() as a fallback. (PR #77026)

2024-01-10 Thread Greg Clayton via lldb-commits
clayborg wrote: > > Is there a way we can tell that the request is from the console and only > > enable this feature if we are going to dump it to the debug console? > > Yea, the DAP has a context we can use to limit this > https://microsoft.github.io/debug-adapter-protocol/specification#Reque

[Lldb-commits] [lldb] [lldb][Progress] Separate title and details (PR #77547)

2024-01-10 Thread Greg Clayton via lldb-commits
https://github.com/clayborg edited https://github.com/llvm/llvm-project/pull/77547 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Progress] Separate title and details (PR #77547)

2024-01-10 Thread Greg Clayton via lldb-commits
https://github.com/clayborg commented: A bit more cleanup, see inline comment https://github.com/llvm/llvm-project/pull/77547 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Progress] Separate title and details (PR #77547)

2024-01-10 Thread Greg Clayton via lldb-commits
@@ -51,9 +56,10 @@ void Progress::Increment(uint64_t amount, std::string update) { void Progress::ReportProgress(std::string update) { clayborg wrote: remove `std::string update` as we have it in `m_details` https://github.com/llvm/llvm-project/pull/77547

[Lldb-commits] [lldb] [lldb][Progress] Separate title and details (PR #77547)

2024-01-10 Thread Greg Clayton via lldb-commits
@@ -30,18 +34,19 @@ Progress::~Progress() { // Make sure to always report progress completed when this object is // destructed so it indicates the progress dialog/activity should go away. std::lock_guard guard(m_mutex); - if (!m_completed) -m_completed = m_total; +

[Lldb-commits] [lldb] [lldb][Progress] Separate title and details (PR #77547)

2024-01-10 Thread Greg Clayton via lldb-commits
@@ -30,18 +34,19 @@ Progress::~Progress() { // Make sure to always report progress completed when this object is // destructed so it indicates the progress dialog/activity should go away. std::lock_guard guard(m_mutex); - if (!m_completed) -m_completed = m_total; +

[Lldb-commits] [lldb] [lldb][Progress] Separate title and details (PR #77547)

2024-01-10 Thread Greg Clayton via lldb-commits
https://github.com/clayborg requested changes to this pull request. https://github.com/llvm/llvm-project/pull/77547 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Progress] Separate title and details (PR #77547)

2024-01-10 Thread Greg Clayton via lldb-commits
@@ -51,9 +56,10 @@ void Progress::Increment(uint64_t amount, std::string update) { void Progress::ReportProgress(std::string update) { if (!m_complete) { // Make sure we only send one notification that indicates the progress is -// complete. -m_complete = m_compl

[Lldb-commits] [lldb] [lldb][Progress] Separate title and details (PR #77547)

2024-01-10 Thread Greg Clayton via lldb-commits
@@ -30,18 +34,19 @@ Progress::~Progress() { // Make sure to always report progress completed when this object is // destructed so it indicates the progress dialog/activity should go away. std::lock_guard guard(m_mutex); - if (!m_completed) -m_completed = m_total; +

[Lldb-commits] [lldb] [lldb][Progress] Separate title and details (PR #77547)

2024-01-10 Thread Greg Clayton via lldb-commits
@@ -11,15 +11,19 @@ #include "lldb/Core/Debugger.h" #include "lldb/Utility/StreamString.h" +#include + using namespace lldb; using namespace lldb_private; std::atomic Progress::g_id(0); -Progress::Progress(std::string title, uint64_t total, +Progress::Progress(std::str

[Lldb-commits] [lldb] [lldb][Progress] Separate title and details (PR #77547)

2024-01-10 Thread Greg Clayton via lldb-commits
https://github.com/clayborg edited https://github.com/llvm/llvm-project/pull/77547 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Progress] Separate title and details (PR #77547)

2024-01-10 Thread Greg Clayton via lldb-commits
@@ -96,13 +97,14 @@ class Progress { static std::atomic g_id; /// The title of the progress activity. std::string m_title; + std::string m_details; std::mutex m_mutex; /// A unique integer identifier for progress reporting. const uint64_t m_id; /// How much w

[Lldb-commits] [lldb] [lldb][Progress] Separate title and details (PR #77547)

2024-01-10 Thread Chelsea Cassanova via lldb-commits
@@ -51,9 +56,10 @@ void Progress::Increment(uint64_t amount, std::string update) { void Progress::ReportProgress(std::string update) { if (!m_complete) { // Make sure we only send one notification that indicates the progress is -// complete. -m_complete = m_compl

[Lldb-commits] [lldb] [lldb][Progress] Separate title and details (PR #77547)

2024-01-10 Thread Chelsea Cassanova via lldb-commits
@@ -30,18 +34,19 @@ Progress::~Progress() { // Make sure to always report progress completed when this object is // destructed so it indicates the progress dialog/activity should go away. std::lock_guard guard(m_mutex); - if (!m_completed) -m_completed = m_total; +

[Lldb-commits] [lld] [clang-tools-extra] [compiler-rt] [libcxxabi] [flang] [libunwind] [lldb] [libclc] [llvm] [clang] [libc] [libcxx] [builtins] Generate __multc3 for z/OS (PR #77554)

2024-01-10 Thread Sean Perry via lldb-commits
https://github.com/perry-ca updated https://github.com/llvm/llvm-project/pull/77554 >From 7ba4d61bd2beda03ba0fcefc9ca5c1ff08ffd48e Mon Sep 17 00:00:00 2001 From: Sean Perry Date: Tue, 9 Jan 2024 20:59:28 -0600 Subject: [PATCH 1/3] Generate __multc3 for z/OS --- compiler-rt/lib/builtins/divtc3

[Lldb-commits] [lldb] [lldb][Progress] Separate title and details (PR #77547)

2024-01-10 Thread Chelsea Cassanova via lldb-commits
@@ -30,18 +34,19 @@ Progress::~Progress() { // Make sure to always report progress completed when this object is // destructed so it indicates the progress dialog/activity should go away. std::lock_guard guard(m_mutex); - if (!m_completed) -m_completed = m_total; +

[Lldb-commits] [lldb] Fix debug info size statistics for split dwarf (PR #77671)

2024-01-10 Thread via lldb-commits
jeffreytan81 wrote: > Looks good, need to add tests for: > > * split dwarf with .dwo files > * split dwarf with .dwp file @clayborg, do you have suggestion regarding how to test `GetDebugInfoSize()` for dwo/dwp? https://github.com/llvm/llvm-project/pull/77671

[Lldb-commits] [lldb] [lldb][Progress] Separate title and details (PR #77547)

2024-01-10 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/77547 >From 44a3cdca21bc9c2aa24eeaf5d82c8b8af382bfa7 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Tue, 9 Jan 2024 18:32:06 -0800 Subject: [PATCH 1/4] [lldb][Progress] Separate title and details Per thi

[Lldb-commits] [lldb] [lldb][Progress] Separate title and details (PR #77547)

2024-01-10 Thread Chelsea Cassanova via lldb-commits
@@ -90,10 +90,11 @@ class Progress { /// @param [in] amount The amount to increment m_completed by. /// /// @param [in] an optional message associated with this update. - void Increment(uint64_t amount = 1, std::string update = {}); + void Increment(uint64_t amount = 1,

[Lldb-commits] [lldb] [lldb][Progress] Separate title and details (PR #77547)

2024-01-10 Thread Greg Clayton via lldb-commits
@@ -35,25 +42,29 @@ Progress::~Progress() { ReportProgress(); } -void Progress::Increment(uint64_t amount, std::string update) { +void Progress::Increment(uint64_t amount, + std::optional updated_detail) { if (amount > 0) { std::lock_guard gua

[Lldb-commits] [lldb] [lldb][Progress] Separate title and details (PR #77547)

2024-01-10 Thread Greg Clayton via lldb-commits
@@ -35,25 +42,29 @@ Progress::~Progress() { ReportProgress(); } -void Progress::Increment(uint64_t amount, std::string update) { +void Progress::Increment(uint64_t amount, + std::optional updated_detail) { if (amount > 0) { std::lock_guard gua

[Lldb-commits] [lldb] Fix debug info size statistics for split dwarf (PR #77671)

2024-01-10 Thread Greg Clayton via lldb-commits
clayborg wrote: > > Looks good, need to add tests for: > > > > * split dwarf with .dwo files > > * split dwarf with .dwp file > > @clayborg, do you have suggestion regarding how to test `GetDebugInfoSize()` > for dwo/dwp? yes, for either we just add up the size of any debug info sections for

[Lldb-commits] [flang] [libcxx] [compiler-rt] [mlir] [clang] [clang-tools-extra] [lldb] [openmp] [llvm] [lld] [libunwind] [GVNSink] Fix #77415: GVNSink fails to optimize LLVM IR with debug info (PR #7

2024-01-10 Thread Shan Huang via lldb-commits
https://github.com/Apochens updated https://github.com/llvm/llvm-project/pull/77602 >From d08af0b38d28726bc78c8da675ea01d7c188c446 Mon Sep 17 00:00:00 2001 From: Apochens <52285902...@stu.ecnu.edu.cn> Date: Wed, 10 Jan 2024 07:10:22 + Subject: [PATCH 1/3] [GVNSink] Fix #77415: GVNSink fails

[Lldb-commits] [lldb] [lldb-dap] Updating VariableDescription to use GetDescription() as a fallback. (PR #77026)

2024-01-10 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/77026 >From 7656af47e058aa7101504cb31aaa067178110351 Mon Sep 17 00:00:00 2001 From: John Harrison Date: Thu, 4 Jan 2024 15:42:35 -0800 Subject: [PATCH 1/5] [lldb-dap] Updating VariableDescription to use GetDescription(

[Lldb-commits] [lldb] [lldb-dap] Updating VariableDescription to use GetDescription() as a fallback. (PR #77026)

2024-01-10 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 241fe83704476f81e3438e32b6d988ea123e624d...d8eb78e220b2127b78cee2868daddbe57ae2c5c8 lldb/

[Lldb-commits] [lldb] [lldb-dap] Updating VariableDescription to use GetDescription() as a fallback. (PR #77026)

2024-01-10 Thread John Harrison via lldb-commits
ashgti wrote: Sorry about the spam, I synced my branch and it looks like the pull request added reviewers from all the patches. https://github.com/llvm/llvm-project/pull/77026 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llv

[Lldb-commits] [lldb] [lldb-dap] Updating VariableDescription to use GetDescription() as a fallback. (PR #77026)

2024-01-10 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/77026 >From 7656af47e058aa7101504cb31aaa067178110351 Mon Sep 17 00:00:00 2001 From: John Harrison Date: Thu, 4 Jan 2024 15:42:35 -0800 Subject: [PATCH 1/6] [lldb-dap] Updating VariableDescription to use GetDescription(

[Lldb-commits] [clang-tools-extra] [lldb] [llvm] [openmp] [clang] [compiler-rt] [libcxx] [lld] [flang] [mlir] [clang] Add `intrin0.h` header to mimic `intrin0.h` used by MSVC STL for clang-cl (PR #757

2024-01-10 Thread Max Winkler via lldb-commits
MaxEW707 wrote: > #include > >clang-cl 16 frontend took ~190ms to parse those 3 headers. intrin.h took ~32ms >to parse. > >clang-cl built with this PR frontend took ~1368ms to parse. intrin.h took >~969ms to parse. Most of that time is from as expected. >intrin0.h took ~2ms to parse. Did th

[Lldb-commits] [libunwind] [openmp] [lld] [clang] [mlir] [clang-tools-extra] [flang] [compiler-rt] [lldb] [llvm] [BranchFolding] Fix missing predecessors of landing-pad (PR #77608)

2024-01-10 Thread Phoebe Wang via lldb-commits
@@ -1363,6 +1363,14 @@ bool BranchFolder::OptimizeBlock(MachineBasicBlock *MBB) { MachineBasicBlock *Pred = *(MBB->pred_end()-1); Pred->ReplaceUsesOfBlockWith(MBB, &*FallThrough); } + // Add rest successors of MBB to successors of FallThrough. Those

[Lldb-commits] [libunwind] [openmp] [lld] [clang] [mlir] [clang-tools-extra] [flang] [compiler-rt] [lldb] [llvm] [BranchFolding] Fix missing predecessors of landing-pad (PR #77608)

2024-01-10 Thread Phoebe Wang via lldb-commits
phoebewang wrote: > > > This keeps CFG as only have one entry which is required by LiveDebugValues > > > > > > If we just want to make LiveDebugValues happy, should it better to remove > > these died BB instead? > > This died BB was already removed by BranchFolder. See rebased test diff. We

[Lldb-commits] [libunwind] [openmp] [lld] [clang] [mlir] [clang-tools-extra] [flang] [compiler-rt] [lldb] [llvm] [BranchFolding] Fix missing predecessors of landing-pad (PR #77608)

2024-01-10 Thread Phoebe Wang via lldb-commits
https://github.com/phoebewang edited https://github.com/llvm/llvm-project/pull/77608 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [libunwind] [openmp] [lld] [clang] [mlir] [clang-tools-extra] [flang] [compiler-rt] [lldb] [llvm] [BranchFolding] Fix missing predecessors of landing-pad (PR #77608)

2024-01-10 Thread Phoebe Wang via lldb-commits
https://github.com/phoebewang edited https://github.com/llvm/llvm-project/pull/77608 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [libunwind] [openmp] [lld] [clang] [mlir] [clang-tools-extra] [flang] [compiler-rt] [lldb] [llvm] [BranchFolding] Fix missing predecessors of landing-pad (PR #77608)

2024-01-10 Thread via lldb-commits
https://github.com/HaohaiWen updated https://github.com/llvm/llvm-project/pull/77608 >From 80a650763278061630e6ff5635bbc3a2dacc093e Mon Sep 17 00:00:00 2001 From: Haohai Wen Date: Wed, 10 Jan 2024 16:09:00 +0800 Subject: [PATCH 1/4] [BranchFolding][SEH] Add test to track SEH CFG optimization

[Lldb-commits] [libunwind] [openmp] [lld] [clang] [mlir] [clang-tools-extra] [flang] [compiler-rt] [lldb] [llvm] [BranchFolding] Fix missing predecessors of landing-pad (PR #77608)

2024-01-10 Thread via lldb-commits
https://github.com/HaohaiWen edited https://github.com/llvm/llvm-project/pull/77608 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [openmp] [lld] [lldb] [clang-tools-extra] [compiler-rt] [libunwind] [llvm] [flang] [mlir] [clang] [BranchFolding] Fix missing predecessors of landing-pad (PR #77608)

2024-01-10 Thread via lldb-commits
@@ -1624,6 +1632,15 @@ bool BranchFolder::OptimizeBlock(MachineBasicBlock *MBB) { } else { DidChange = true; PMBB->ReplaceUsesOfBlockWith(MBB, CurTBB); + // Add rest successors of MBB to successors of CurTBB. Those +

[Lldb-commits] [flang] [clang] [clang-tools-extra] [lldb] [libunwind] [openmp] [llvm] [lld] [mlir] [compiler-rt] [BranchFolding] Fix missing predecessors of landing-pad (PR #77608)

2024-01-10 Thread via lldb-commits
@@ -1363,6 +1363,14 @@ bool BranchFolder::OptimizeBlock(MachineBasicBlock *MBB) { MachineBasicBlock *Pred = *(MBB->pred_end()-1); Pred->ReplaceUsesOfBlockWith(MBB, &*FallThrough); } + // Add rest successors of MBB to successors of FallThrough. Those

[Lldb-commits] [compiler-rt] [libc] [lld] [flang] [mlir] [clang-tools-extra] [lldb] [llvm] [libcxx] [clang] Don't emit relax relocs like R_X86_64_REX_GOTPCRELX on X86 target for OPENMP internal vars.

2024-01-10 Thread via lldb-commits
https://github.com/UmeshKalappa0 updated https://github.com/llvm/llvm-project/pull/75564 >From 4125e4a709c594562fa6c52f045ba7442e3cb523 Mon Sep 17 00:00:00 2001 From: Umesh Kalappa Date: Fri, 15 Dec 2023 11:52:52 +0530 Subject: [PATCH 1/4] Problem :For Kernel Modules ,emitting the relocs like

[Lldb-commits] [libcxxabi] [libunwind] [flang] [lldb] [clang-tools-extra] [libcxx] [libc] [llvm] [lld] [clang] [compiler-rt] [libclc] [Legalizer] Soften EXTRACT_ELEMENT on ppcf128 (PR #77412)

2024-01-10 Thread Matt Arsenault via lldb-commits
https://github.com/arsenm edited https://github.com/llvm/llvm-project/pull/77412 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [compiler-rt] [libcxx] [libclc] [clang-tools-extra] [libc] [clang] [libunwind] [flang] [libcxxabi] [lld] [Legalizer] Soften EXTRACT_ELEMENT on ppcf128 (PR #77412)

2024-01-10 Thread Matt Arsenault via lldb-commits
@@ -1,58 +1,305 @@ -; RUN: llc -verify-machineinstrs -mtriple=powerpc-unknown-linux-gnu -O0 < %s | FileCheck %s -; RUN: llc -verify-machineinstrs -mtriple=powerpc64-unknown-linux-gnu -O0 < %s | FileCheck %s -; RUN: llc -verify-machineinstrs -mtriple=powerpc64le-unknown-linux-

[Lldb-commits] [llvm] [clang] [flang] [clang-tools-extra] [libcxxabi] [libclc] [lld] [libunwind] [compiler-rt] [libcxx] [libc] [lldb] [Legalizer] Soften EXTRACT_ELEMENT on ppcf128 (PR #77412)

2024-01-10 Thread Matt Arsenault via lldb-commits
https://github.com/arsenm approved this pull request. https://github.com/llvm/llvm-project/pull/77412 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [openmp] [llvm] [libc] [lldb] [clang] [flang] [libcxx] [lld] [compiler-rt] [clang-tools-extra] [PGO][OpenMP] Instrumentation for GPU devices (PR #76587)

2024-01-10 Thread Matt Arsenault via lldb-commits
@@ -959,8 +959,12 @@ void CodeGenPGO::emitCounterIncrement(CGBuilderTy &Builder, const Stmt *S, unsigned Counter = (*RegionCounterMap)[S]; - llvm::Value *Args[] = {FuncNameVar, - Builder.getInt64(FunctionHash), + // Make sure that pointer to globa

[Lldb-commits] [compiler-rt] [lldb] [clang-tools-extra] [llvm] [clang] [libcxx] [lld] [flang] [libunwind] [Sema] Use lexical DC for friend functions when getting constraint instantiation args (PR #775

2024-01-10 Thread via lldb-commits
https://github.com/antangelo updated https://github.com/llvm/llvm-project/pull/77552 >From f9e35231207090afcda91d3cd3551d7d1639598b Mon Sep 17 00:00:00 2001 From: Antonio Abbatangelo Date: Tue, 9 Jan 2024 20:20:30 -0500 Subject: [PATCH] [Sema] Use lexical DC for friend functions when getting c

[Lldb-commits] [compiler-rt] [lldb] [clang-tools-extra] [llvm] [clang] [libcxx] [lld] [flang] [libunwind] [Sema] Use lexical DC for friend functions when getting constraint instantiation args (PR #775

2024-01-10 Thread via lldb-commits
antangelo wrote: Thank you for the review! I have commit access so I'll be able to merge once the CI runs pass after fixing conflicts. https://github.com/llvm/llvm-project/pull/77552 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://li