[Lldb-commits] [lldb] [lldb-dap] Implement command directives (PR #74808)

2023-12-08 Thread Greg Clayton via lldb-commits
@@ -33,9 +39,14 @@ namespace lldb_dap { /// \param[in] strm /// The stream that will receive the prefix, prompt + command and /// all command output. +/// +/// \param[in] parse_command_directives +/// If \b false, then command prefixes like \b ! or \b ? are not pars

[Lldb-commits] [lldb] [lldb-dap] Include [opt] in the frame name only if a custom frame format is not specified. (PR #74861)

2023-12-08 Thread Greg Clayton via lldb-commits
clayborg wrote: `{${function.is-optimized} [opt]}` is how is already is and can be done with frame formats, so I agree with this patch that if the user customizes it, they have complete control and we shouldn't add anything. Does everyone else agree? https://github.com/llvm/llvm-project/pull/7

[Lldb-commits] [lldb] [lldb-dap] Include [opt] in the frame name only if a custom frame format is not specified. (PR #74861)

2023-12-08 Thread Greg Clayton via lldb-commits
https://github.com/clayborg approved this pull request. https://github.com/llvm/llvm-project/pull/74861 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add a test for evicting unreachable modules from the global module cache (PR #74894)

2023-12-08 Thread Greg Clayton via lldb-commits
clayborg wrote: > Note, I thought about adding an `SBDebugger::GetSharedModules or something, > but I don't actually think that's a good thing to give external access to. > Some day we should make an SBTestAPI with some useful for testing but not for > the SB API library so we can make this so

[Lldb-commits] [lldb] Make only one function that needs to be implemented when searching for types (PR #74786)

2023-12-08 Thread Greg Clayton via lldb-commits
clayborg wrote: > Sorry, it's been a while since I last reviewed this and I must admit I forgot > about this in the mean time. The only thing I'd like to check before we can > land this is to hear from @Michael137 who has been actively working on > FindTypes performance recently whether this a

[Lldb-commits] [lldb] lldb: add support for thread names on Windows (PR #74731)

2023-12-08 Thread Greg Clayton via lldb-commits
https://github.com/clayborg commented: One other way to test is to create a python test that makes a test windows binary that creates a thread using the Windows APIs and then we set a breakpoint in one of the thread functions and then verify the thread name is returned in the output of "thread

[Lldb-commits] [lldb] [llvm] [clang-tools-extra] [clang] [lld] [ADT] Rename SmallString::{starts, ends}with to {starts, ends}_with (PR #74916)

2023-12-08 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/74916 This patch renames {starts,ends}with to {starts,ends}_with for consistency with std::{string,string_view}::{starts,ends}_with in C++20. Since there are only a handful of occurrences, this patch skips the d

[Lldb-commits] [llvm] [lldb] [lld] [clang-tools-extra] [clang] [ADT] Rename SmallString::{starts, ends}with to {starts, ends}_with (PR #74916)

2023-12-08 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Kazu Hirata (kazutakahirata) Changes This patch renames {starts,ends}with to {starts,ends}_with for consistency with std::{string,string_view}::{starts,ends}_with in C++20. Since there are only a handful of occurrences, this patch skips th

[Lldb-commits] [llvm] [lldb] [clang-tools-extra] [clang] [lld] [ADT] Rename SmallString::{starts, ends}with to {starts, ends}_with (PR #74916)

2023-12-08 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata updated https://github.com/llvm/llvm-project/pull/74916 >From ab33bda7fd31fbfc28344bb6f81ce08394e7c3fd Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Thu, 7 Dec 2023 23:20:42 -0800 Subject: [PATCH 1/2] [ADT] Rename SmallString::{starts,ends}with to {starts,e

[Lldb-commits] [llvm] [lld] [clang-tools-extra] [lldb] [clang] [ADT] Rename SmallString::{starts, ends}with to {starts, ends}_with (PR #74916)

2023-12-08 Thread Fangrui Song via lldb-commits
MaskRay wrote: flang and bolt are not changed? https://github.com/llvm/llvm-project/pull/74916 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [llvm] [lld] [lldb] [clang-tools-extra] [ADT] Rename SmallString::{starts, ends}with to {starts, ends}_with (PR #74916)

2023-12-08 Thread Kazu Hirata via lldb-commits
kazutakahirata wrote: > flang and bolt are not changed? Right. Somehow, `SmallString::{startswith,endswith}` do not occur there. By the way, they are not to be confused with `StringRef::{startswith,endswith}, which is everywhere. https://github.com/llvm/llvm-project/pull/74916 _

[Lldb-commits] [clang] [llvm] [lld] [lldb] [clang-tools-extra] [ADT] Rename SmallString::{starts, ends}with to {starts, ends}_with (PR #74916)

2023-12-08 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata updated https://github.com/llvm/llvm-project/pull/74916 >From ab33bda7fd31fbfc28344bb6f81ce08394e7c3fd Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Thu, 7 Dec 2023 23:20:42 -0800 Subject: [PATCH 1/3] [ADT] Rename SmallString::{starts,ends}with to {starts,e

[Lldb-commits] [lldb] Make only one function that needs to be implemented when searching for types (PR #74786)

2023-12-08 Thread Will Hawkins via lldb-commits
@@ -340,26 +340,22 @@ class ModuleList { lldb::SymbolType symbol_type, SymbolContextList &sc_list) const; - /// Find types by name. + /// Find types using a type matching object that contains all s

[Lldb-commits] [lldb] Make only one function that needs to be implemented when searching for types (PR #74786)

2023-12-08 Thread Will Hawkins via lldb-commits
https://github.com/hawkinsw edited https://github.com/llvm/llvm-project/pull/74786 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Make only one function that needs to be implemented when searching for types (PR #74786)

2023-12-08 Thread Will Hawkins via lldb-commits
@@ -301,21 +301,20 @@ class SymbolFile : public PluginInterface { bool include_inlines, SymbolContextList &sc_list); virtual void FindFunctions(const RegularExpression ®ex, bool include_inlines, SymbolContextList &sc_l

[Lldb-commits] [lldb] Make only one function that needs to be implemented when searching for types (PR #74786)

2023-12-08 Thread Will Hawkins via lldb-commits
@@ -84,6 +84,13 @@ class CompilerDecl { // based argument index CompilerType GetFunctionArgumentType(size_t arg_idx) const; + /// Populate a valid compiler context from the current declaration. + /// + /// \returns A valid vector of CompilerContext entries that describe

[Lldb-commits] [lldb] Make only one function that needs to be implemented when searching for types (PR #74786)

2023-12-08 Thread Will Hawkins via lldb-commits
@@ -415,70 +415,19 @@ class Module : public std::enable_shared_from_this, void FindGlobalVariables(const RegularExpression ®ex, size_t max_matches, VariableList &variable_list); - /// Find types by name. - /// - /// Type lookups in modules go t

[Lldb-commits] [lldb] Make only one function that needs to be implemented when searching for types (PR #74786)

2023-12-08 Thread Will Hawkins via lldb-commits
@@ -45,6 +66,286 @@ struct CompilerContext { bool contextMatches(llvm::ArrayRef context_chain, llvm::ArrayRef pattern); +FLAGS_ENUM(TypeQueryOptions){ +e_none = 0u, +/// If set TypeQuery::m_context contains an exact context that must match -

[Lldb-commits] [lldb] Make only one function that needs to be implemented when searching for types (PR #74786)

2023-12-08 Thread Will Hawkins via lldb-commits
@@ -45,6 +66,286 @@ struct CompilerContext { bool contextMatches(llvm::ArrayRef context_chain, llvm::ArrayRef pattern); +FLAGS_ENUM(TypeQueryOptions){ +e_none = 0u, +/// If set TypeQuery::m_context contains an exact context that must match +///

[Lldb-commits] [lldb] Make only one function that needs to be implemented when searching for types (PR #74786)

2023-12-08 Thread Will Hawkins via lldb-commits
@@ -56,6 +57,13 @@ class CompilerDeclContext { return m_type_system != nullptr && m_opaque_decl_ctx != nullptr; } + /// Populate a valid compiler context from the current decl context. + /// + /// \returns A valid vector of CompilerContext entries that describes + //

[Lldb-commits] [lldb] Make only one function that needs to be implemented when searching for types (PR #74786)

2023-12-08 Thread Will Hawkins via lldb-commits
@@ -45,6 +66,286 @@ struct CompilerContext { bool contextMatches(llvm::ArrayRef context_chain, llvm::ArrayRef pattern); +FLAGS_ENUM(TypeQueryOptions){ +e_none = 0u, +/// If set TypeQuery::m_context contains an exact context that must match +///

[Lldb-commits] [lldb] Make only one function that needs to be implemented when searching for types (PR #74786)

2023-12-08 Thread Will Hawkins via lldb-commits
https://github.com/hawkinsw commented: Thank you for the great work. I really appreciate the excellent documentation that you wrote. I am not well versed enough in the code to comment on the implementation, but your comments were so good that I intuitively understood the point of the new class

[Lldb-commits] [lldb] Make only one function that needs to be implemented when searching for types (PR #74786)

2023-12-08 Thread Will Hawkins via lldb-commits
@@ -45,6 +66,286 @@ struct CompilerContext { bool contextMatches(llvm::ArrayRef context_chain, llvm::ArrayRef pattern); +FLAGS_ENUM(TypeQueryOptions){ +e_none = 0u, +/// If set TypeQuery::m_context contains an exact context that must match +///

[Lldb-commits] [lldb] Make only one function that needs to be implemented when searching for types (PR #74786)

2023-12-08 Thread Will Hawkins via lldb-commits
@@ -45,6 +66,286 @@ struct CompilerContext { bool contextMatches(llvm::ArrayRef context_chain, llvm::ArrayRef pattern); +FLAGS_ENUM(TypeQueryOptions){ +e_none = 0u, +/// If set TypeQuery::m_context contains an exact context that must match +///

[Lldb-commits] [lldb] Make only one function that needs to be implemented when searching for types (PR #74786)

2023-12-08 Thread Will Hawkins via lldb-commits
@@ -45,6 +66,286 @@ struct CompilerContext { bool contextMatches(llvm::ArrayRef context_chain, llvm::ArrayRef pattern); +FLAGS_ENUM(TypeQueryOptions){ +e_none = 0u, +/// If set TypeQuery::m_context contains an exact context that must match +///

[Lldb-commits] [lldb] Make only one function that needs to be implemented when searching for types (PR #74786)

2023-12-08 Thread Will Hawkins via lldb-commits
@@ -45,6 +66,286 @@ struct CompilerContext { bool contextMatches(llvm::ArrayRef context_chain, llvm::ArrayRef pattern); +FLAGS_ENUM(TypeQueryOptions){ +e_none = 0u, +/// If set TypeQuery::m_context contains an exact context that must match +///

<    1   2