https://github.com/antiagainst approved this pull request.
LGTM regarding SPIR-V. But please address comments from others. :)
https://github.com/llvm/llvm-project/pull/71430
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.o
antiagainst wrote:
Thanks for breaking down this pull request into various smaller pieces to make
it easier for review. I looked at various pieces; LGTM. Looking forward to see
this being supported! :)
from @joker-eph:
> Vulkan and Spirv still have dedicated runners on the model of the origina
@@ -817,8 +817,7 @@ llvm::json::Value CreateStackFrame(lldb::SBFrame &frame) {
if (line && line != LLDB_INVALID_LINE_NUMBER)
object.try_emplace("line", line);
bulbazord wrote:
>From the [DAP
>specification](https://microsoft.github.io/debug-adapter-p
https://github.com/bulbazord approved this pull request.
I think overall this is a better error message. I think "mode" probably refers
to the configuration LLDB was built with (e.g. `LLDB_ENABLE_PYTHON`) but that's
really unhelpful for developers actually using LLDB. This message has been
aro
https://github.com/cmtice created
https://github.com/llvm/llvm-project/pull/73467
This adds 23 new helper functions to LLDB's CompilerType class, things like
IsSmartPtrType, IsPromotableIntegerType, GetNumberofNonEmptyBaseClasses, and
GetTemplateArgumentType (to name a few).
These helper func
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (cmtice)
Changes
This adds 23 new helper functions to LLDB's CompilerType class, things like
IsSmartPtrType, IsPromotableIntegerType, GetNumberofNonEmptyBaseClasses, and
GetTemplateArgumentType (to name a few).
These helper functions
https://github.com/JDevlieghere approved this pull request.
Thanks for improving the error message. I left a suggestion inline, but happy
to see this merged regardless of the concrete wording.
https://github.com/llvm/llvm-project/pull/73321
___
lldb-
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/73321
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -26,17 +26,19 @@ ScriptInterpreterNone::ScriptInterpreterNone(Debugger
&debugger)
ScriptInterpreterNone::~ScriptInterpreterNone() = default;
+static const char *no_interpreter_err_msg =
+"There is no embedded script interpreter. Check that LLDB was built with a
"
+
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff a369a5946f99254d56455f3deb0031199562c1dd
70957429780c31c8981198967af254a4232ad3bc --
https://github.com/cmtice updated
https://github.com/llvm/llvm-project/pull/73467
>From 70957429780c31c8981198967af254a4232ad3bc Mon Sep 17 00:00:00 2001
From: Caroline Tice
Date: Sun, 26 Nov 2023 16:14:46 -0800
Subject: [PATCH 1/2] [LLDB] Add more helper functions to CompilerType class.
This
Author: cmtice
Date: 2023-11-26T16:37:39-08:00
New Revision: 42d669f82c4db6abd6f39e1d89e4e62872c4e0a8
URL:
https://github.com/llvm/llvm-project/commit/42d669f82c4db6abd6f39e1d89e4e62872c4e0a8
DIFF:
https://github.com/llvm/llvm-project/commit/42d669f82c4db6abd6f39e1d89e4e62872c4e0a8.diff
LOG: [
https://github.com/cmtice closed https://github.com/llvm/llvm-project/pull/73467
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/cmtice created
https://github.com/llvm/llvm-project/pull/73470
Reverts llvm/llvm-project#73467
Merged the commit by accident!
>From d4cddc1a596b60c128996c8f96f63af6fb21506a Mon Sep 17 00:00:00 2001
From: cmtice
Date: Sun, 26 Nov 2023 16:37:50 -0800
Subject: [PATCH] Revert "
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (cmtice)
Changes
Reverts llvm/llvm-project#73467
Merged the commit by accident!
---
Full diff: https://github.com/llvm/llvm-project/pull/73470.diff
2 Files Affected:
- (modified) lldb/include/lldb/Symbol/CompilerType.h (+5-51)
- (
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 42d669f82c4db6abd6f39e1d89e4e62872c4e0a8
d4cddc1a596b60c128996c8f96f63af6fb21506a --
https://github.com/bulbazord commented:
I suppose we don't really lose anything by moving away from `expectedFailure`
from decorators?
Is it worth deleting the custom decorator that we have as well? 😄
https://github.com/llvm/llvm-project/pull/73028
___
Author: Caroline Tice
Date: 2023-11-26T17:03:35-08:00
New Revision: af3c5a7cf1e008a467eb3104424ed122b533d7b3
URL:
https://github.com/llvm/llvm-project/commit/af3c5a7cf1e008a467eb3104424ed122b533d7b3
DIFF:
https://github.com/llvm/llvm-project/commit/af3c5a7cf1e008a467eb3104424ed122b533d7b3.diff
https://github.com/cmtice closed https://github.com/llvm/llvm-project/pull/73470
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
cmtice wrote:
Can't commit this revert because of the clang format errors. Reverted manually
instead.
https://github.com/llvm/llvm-project/pull/73470
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/list
cmtice wrote:
I accidentally committed this PR. I could not revert using github pull
requests, due to clang format errors. So I reverted it manually. (See git hash
af3c5a7cf1e008a467eb3104424ed122b533d7b3).
Is there any way to re-open this PR for reviews, or do I need to start all over
again
https://github.com/cmtice created
https://github.com/llvm/llvm-project/pull/73472
This adds 23 new helper functions to LLDB's CompilerType class, things like
IsSmartPtrType, IsPromotableIntegerType,
GetNumberofNonEmptyBaseClasses, and GetTemplateArgumentType (to name a few).
It also has run cl
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (cmtice)
Changes
This adds 23 new helper functions to LLDB's CompilerType class, things like
IsSmartPtrType, IsPromotableIntegerType,
GetNumberofNonEmptyBaseClasses, and GetTemplateArgumentType (to name a few).
It also has run clang-f
cmtice wrote:
Never mind; I'll just create a new pull request. See
https://github.com/llvm/llvm-project/pull/73472.
https://github.com/llvm/llvm-project/pull/73467
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bi
https://github.com/xujuntwt95329 updated
https://github.com/llvm/llvm-project/pull/73393
>From 4621be9af9a8003c52850ed57ae7a24f26769b2c Mon Sep 17 00:00:00 2001
From: Xu Jun <693788...@qq.com>
Date: Sat, 25 Nov 2023 22:52:53 +0800
Subject: [PATCH 1/2] [lldb][dap] always add column field in Stack
@@ -817,8 +817,7 @@ llvm::json::Value CreateStackFrame(lldb::SBFrame &frame) {
if (line && line != LLDB_INVALID_LINE_NUMBER)
object.try_emplace("line", line);
xujuntwt95329 wrote:
Thanks! Updated
https://github.com/llvm/llvm-project/pull/73393
__
26 matches
Mail list logo
