dyung wrote:
For completeness, here is where I forced a build of the commit immediately
preceding yours:
https://lab.llvm.org/buildbot/#/builders/217/builds/30986
Note the git checkout step:
```
...
using PTY: False
2984156fd34a6969c7461b228d90b72711e3797c
program finished with exit code 0
...
JDevlieghere wrote:
That would've been helpful information to include in your original message and
saved me the time of having to go through the logs.
https://github.com/llvm/llvm-project/pull/71458
___
lldb-commits mailing list
lldb-commits@lists.ll
dyung wrote:
> That would've been helpful information to include in your original message
> and saved me the time of having to go through the logs.
Sorry about that, I'll be sure to do so next time.
https://github.com/llvm/llvm-project/pull/71458
___
@@ -87,8 +87,15 @@ class LLDB_API SBFrame {
// display to a user
const char *GetDisplayFunctionName();
+ /// Similar to \a GetDisplayFunctionName() but with function arguments and
+ /// their values inserted into the function display name whenever possible.
+ ///
+ ///
@@ -87,8 +87,15 @@ class LLDB_API SBFrame {
// display to a user
const char *GetDisplayFunctionName();
+ /// Similar to \a GetDisplayFunctionName() but with function arguments and
+ /// their values inserted into the function display name whenever possible.
+ ///
+ ///
@@ -187,3 +188,19 @@ def test_stackTrace(self):
self.assertEquals(
0, len(stackFrames), "verify zero frames with startFrame out of
bounds"
)
+
+@skipIfWindows
bulbazord wrote:
Why skip on Windows?
https://github.com/llvm/llvm-
@@ -1232,6 +1234,32 @@ const char *SBFrame::GetFunctionName() const {
return name;
}
+void SBFrame::GetDisplayFunctionNameWithArgs(SBStream &output) {
+ Stream &strm = output.ref();
+
+ std::unique_lock lock;
+ ExecutionContext exe_ctx(m_opaque_sp.get(), lock);
+
+ Stack
@@ -324,8 +325,23 @@ class StackFrame : public ExecutionContextScope,
///C string with the assembly instructions for this function.
const char *Disassemble();
+ /// Print a description of this frame using the provided frame format.
+ /// If the format is invalid, the
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/71780
>From e5bc858c35b479d29174c9945c6c67f4d2dc085b Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Thu, 9 Nov 2023 01:13:21 +
Subject: [PATCH 1/3] Reland "[clang][DebugInfo] Emit global variable
definitions
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/71780
>From e5bc858c35b479d29174c9945c6c67f4d2dc085b Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Thu, 9 Nov 2023 01:13:21 +
Subject: [PATCH 1/4] Reland "[clang][DebugInfo] Emit global variable
definitions
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/71800
>From d3e0391685605491383114f82d906c811f899b5d Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Mon, 6 Nov 2023 11:34:09 +
Subject: [PATCH 1/2] Reland "[lldb][DWARFASTParserClang] Fetch constant value
fr
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/71780
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Alex Langford
Date: 2023-11-09T13:34:59-08:00
New Revision: fe98cce6a91c7240a541b213d43d1132c684fd9c
URL:
https://github.com/llvm/llvm-project/commit/fe98cce6a91c7240a541b213d43d1132c684fd9c
DIFF:
https://github.com/llvm/llvm-project/commit/fe98cce6a91c7240a541b213d43d1132c684fd9c.diff
https://github.com/bulbazord closed
https://github.com/llvm/llvm-project/pull/71236
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Alex Langford
Date: 2023-11-09T13:35:35-08:00
New Revision: 1486264d5fad0ef7d76a44f6358390cf41218c7e
URL:
https://github.com/llvm/llvm-project/commit/1486264d5fad0ef7d76a44f6358390cf41218c7e
DIFF:
https://github.com/llvm/llvm-project/commit/1486264d5fad0ef7d76a44f6358390cf41218c7e.diff
https://github.com/bulbazord closed
https://github.com/llvm/llvm-project/pull/71613
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 7c7882fcffbfd204f95a3613ce076abf7da294e8
4784e02edb23b23a6e2cabfa3f7eb20c3ee441c4 --
felipepiovezan wrote:
> The correct fix seems to also store the underlying storage along with the
> accelerator tables in AppleDWARFIndex.
This was my initial reaction as well. Is there some blocker to doing this?
https://github.com/llvm/llvm-project/pull/71828
walter-erquinigo wrote:
The changes seem very trivial to me, so please let me know if there's something
else I should do or be aware of.
https://github.com/llvm/llvm-project/pull/71828
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://
https://github.com/jasonmolenda approved this pull request.
Read through 71809 before this one, both look fine. ;)
https://github.com/llvm/llvm-project/pull/71808
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin
https://github.com/jasonmolenda approved this pull request.
Looks good.
https://github.com/llvm/llvm-project/pull/71809
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/71780
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/augusto2112 updated
https://github.com/llvm/llvm-project/pull/69741
>From b34b8f1786a6fb274710c5e4318bad83b04b0480 Mon Sep 17 00:00:00 2001
From: Augusto Noronha
Date: Fri, 20 Oct 2023 10:18:03 -0700
Subject: [PATCH] Fix size in bytes of type DIEs when size in bits is not a
https://github.com/augusto2112 edited
https://github.com/llvm/llvm-project/pull/69741
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
augusto2112 wrote:
@dwblaikie I talked with Adrian, his idea is to emit the size in bits whenever
it does not cleanly fit in a byte. His point (and I agree) is that there may be
tools that can use this bit size, and if we always round up when emitting the
DWARF we will lose this information, w
https://github.com/kevinfrei updated
https://github.com/llvm/llvm-project/pull/70996
>From b04c85dbed0b369e747aa2a3823789203156736b Mon Sep 17 00:00:00 2001
From: Kevin Frei
Date: Wed, 18 Oct 2023 14:37:34 -0700
Subject: [PATCH 1/4] DEBUGINFOD based DWP acquisition for LLDB
Summary:
I've plumb
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 5195d458587b02f3edf1347fae53417a74538648
b34b8f1786a6fb274710c5e4318bad83b04b0480 --
kevinfrei wrote:
I updated the diff with the plugin-ified version of the work. It's *much*
cleaner with no debugger-wide changes to speak of (Thanks for the set up for
that, @JDevlieghere!). I did *not* add Debuginfod logging in the LLDB part of
the code, as I intend to add diagnostic debuggin
@@ -396,8 +398,22 @@ Symbols::LocateExecutableSymbolFile(const ModuleSpec
&module_spec,
}
}
}
-
- return LocateExecutableSymbolFileDsym(module_spec);
+ FileSpec dsym_bundle = LocateExecutableSymbolFileDsym(module_spec);
+ if (dsym_bundle)
+return dsym_bundle
@@ -4892,6 +4894,21 @@ void TargetProperties::SetDebugUtilityExpression(bool
debug) {
SetPropertyAtIndex(idx, debug);
}
+Args TargetProperties::GetDebugInfoDURLs() const {
+ Args urls;
+ m_collection_sp->GetPropertyAtIndexAsArgs(ePropertyDebugInfoDURLs, urls);
+ return u
@@ -0,0 +1,154 @@
+//===-- SymbolLocatorDebuginfod.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -0,0 +1,154 @@
+//===-- SymbolLocatorDebuginfod.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -0,0 +1,8 @@
+include "../../../../include/lldb/Core/PropertiesBase.td"
+
+let Definition = "symbollocatordebuginfod" in {
+ def URLs: Property<"urls", "String">,
+Global,
+DefaultStringValue<"">,
+Desc<"A space-separated, ordered list of Debuginfod server URLs to
@@ -4,7 +4,7 @@ let Definition = "modulelist" in {
def EnableExternalLookup: Property<"enable-external-lookup", "Boolean">,
Global,
DefaultTrue,
-Desc<"Control the use of external tools and repositories to locate symbol
files. Directories listed in target.debug-f
@@ -0,0 +1,154 @@
+//===-- SymbolLocatorDebuginfod.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -0,0 +1,154 @@
+//===-- SymbolLocatorDebuginfod.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -4180,7 +4180,6 @@ TargetProperties::TargetProperties(Target *target)
ePropertyInheritTCC, [this] { InheritTCCValueChangedCallback(); });
m_collection_sp->SetValueChangedCallback(
ePropertyDisableSTDIO, [this] { DisableSTDIOValueChangedCallback(); });
-
-
@@ -46,6 +46,10 @@ bool canUseDebuginfod();
/// environment variable.
SmallVector getDefaultDebuginfodUrls();
+/// Sets the list of debuginfod server URLs to query. This overrides the
+/// environment variable DEBUGINFOD_URLS.
clayborg wrote:
Should this over
@@ -62,15 +66,25 @@ bool canUseDebuginfod() {
}
SmallVector getDefaultDebuginfodUrls() {
- const char *DebuginfodUrlsEnv = std::getenv("DEBUGINFOD_URLS");
- if (DebuginfodUrlsEnv == nullptr)
-return SmallVector();
-
- SmallVector DebuginfodUrls;
- StringRef(DebuginfodU
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/71828
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/clayborg commented:
See inline comment
https://github.com/llvm/llvm-project/pull/71828
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -57,7 +57,9 @@ std::unique_ptr AppleDWARFIndex::Create(
return std::make_unique(
clayborg wrote:
DataExtractor objects don't always have shared buffers. I am guessing in this
case it does have them, but you might throw in a `lldbassert(...)` just in case
@@ -57,7 +57,9 @@ std::unique_ptr AppleDWARFIndex::Create(
return std::make_unique(
walter-erquinigo wrote:
These asserts might not always pass? I don't know if it's guaranteed that if
one of those sections is present, then the rest of them are as well.
ht
@@ -187,3 +188,19 @@ def test_stackTrace(self):
self.assertEquals(
0, len(stackFrames), "verify zero frames with startFrame out of
bounds"
)
+
+@skipIfWindows
walter-erquinigo wrote:
I think all vscode tests skip on windows...
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/71843
>From 980f1e0ceb43da5f4d504f7ed04c3abb591e406d Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Thu, 9 Nov 2023 13:15:55 -0500
Subject: [PATCH] [lldb-dap] Add an option to show function args in stac
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/71843
>From 7b9b5897e2e801d7bc97639ed302b885481659bd Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Thu, 9 Nov 2023 13:15:55 -0500
Subject: [PATCH] [lldb-dap] Add an option to show function args in stac
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/71843
>From 2f3841dc6d68f755b11f6677ed2d034a88a297c8 Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Thu, 9 Nov 2023 13:15:55 -0500
Subject: [PATCH] [lldb-dap] Add an option to show function args in stac
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/71843
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/71843
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
walter-erquinigo wrote:
@clayborg , I did pretty much what you asked but with a few changes:
- I added the `customFrameFormat` option to the json config, and it'll be used
if provided and non-empty. I just find it simpler to control everything with
one single option.
- I added the SBFormat cla
@@ -0,0 +1,9 @@
+// RUN: %clang_cc1 -fprofile-instrument=clang -fcoverage-mapping -emit-llvm
-o - %s | FileCheck %s
+// RUN: %clang_cc1 -mllvm -profile-correlate=binary -fprofile-instrument=clang
-fcoverage-mapping -emit-llvm -o - %s | FileCheck %s
--check-prefix=BIN-CORRELATE
@@ -195,8 +195,14 @@ OPTIONS
.. option:: --debug-info=
Specify the executable or ``.dSYM`` that contains debug info for the raw
profile.
- When ``-debug-info-correlate`` was used for instrumentation, use this option
- to correlate the raw profile.
+ When ``-profile-correlate
@@ -1341,20 +1344,26 @@ void
InstrProfiling::createDataVariable(InstrProfCntrInstBase *Inc,
}
auto *Data =
new GlobalVariable(*M, DataTy, false, Linkage, nullptr, DataVarName);
- // Reference the counter variable with a label difference (link-time
- // constant).
-
@@ -1829,6 +1833,22 @@ void CoverageMappingModuleGen::emit() {
llvm::GlobalValue::InternalLinkage, NamesArrVal,
llvm::getCoverageUnusedNamesVarName());
}
+ const StringRef VarName(INSTR_PROF_QUOTE(INSTR_PROF_RAW_VERSI
@@ -298,6 +298,12 @@ ParsedDWARFTypeAttributes::ParsedDWARFTypeAttributes(const
DWARFDIE &die) {
byte_size = form_value.Unsigned();
break;
+case DW_AT_bit_size:
+ // Convert the bit size to byte size, and round it up to the minimum
about
@@ -2866,8 +2879,12 @@ void DWARFASTParserClang::ParseSingleMember(
// Get the parent byte size so we can verify any members will fit
const uint64_t parent_byte_size =
parent_die.GetAttributeValueAsUnsigned(DW_AT_byte_size, UINT64_MAX);
- const uint64_t parent_bit_si
@@ -2866,8 +2879,12 @@ void DWARFASTParserClang::ParseSingleMember(
// Get the parent byte size so we can verify any members will fit
const uint64_t parent_byte_size =
parent_die.GetAttributeValueAsUnsigned(DW_AT_byte_size, UINT64_MAX);
- const uint64_t parent_bit_si
@@ -298,6 +298,12 @@ ParsedDWARFTypeAttributes::ParsedDWARFTypeAttributes(const
DWARFDIE &die) {
byte_size = form_value.Unsigned();
break;
+case DW_AT_bit_size:
+ // Convert the bit size to byte size, and round it up to the minimum
about
+ // of byt
@@ -2210,9 +2216,16 @@ bool DWARFASTParserClang::CompleteRecordType(const
DWARFDIE &die,
!layout_info.vbase_offsets.empty()) {
if (type)
layout_info.bit_size = type->GetByteSize(nullptr).value_or(0) * 8;
-if (layout_info.bit_size == 0)
- layout_info.bi
@@ -298,6 +298,12 @@ ParsedDWARFTypeAttributes::ParsedDWARFTypeAttributes(const
DWARFDIE &die) {
byte_size = form_value.Unsigned();
break;
+case DW_AT_bit_size:
+ // Convert the bit size to byte size, and round it up to the minimum
about
+ // of byt
@@ -1331,6 +1336,18 @@ static int merge_main(int argc, const char *argv[]) {
"(default: 1)"));
cl::ParseCommandLineOptions(argc, argv, "LLVM profile data merger\n");
+ if (!DebugInfoFilename.empty() && !BinaryFilename.empty()) {
+exitWithError("Expect
@@ -0,0 +1,11 @@
+; RUN: opt < %s -passes=instrprof -profile-correlate=binary -S | FileCheck %s
MaskRay wrote:
This isn't clear how `__profd_foo` is different from `-profile-correlate=none`.
This test can be added to `coverage.ll` as a new RUN line
https://gith
@@ -1331,6 +1336,18 @@ static int merge_main(int argc, const char *argv[]) {
"(default: 1)"));
cl::ParseCommandLineOptions(argc, argv, "LLVM profile data merger\n");
+ if (!DebugInfoFilename.empty() && !BinaryFilename.empty()) {
+exitWithError("Expect
https://github.com/MaskRay commented:
The comment `The data and names sections are omitted in lightweight mode.` in
compiler-rt should be updated since binary correlation is different from the
lightweight mode
https://github.com/llvm/llvm-project/pull/69493
https://github.com/MaskRay edited
https://github.com/llvm/llvm-project/pull/69493
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -46,14 +73,38 @@ const char *InstrProfCorrelator::NumCountersAttributeName =
"Num Counters";
llvm::Expected>
InstrProfCorrelator::Context::get(std::unique_ptr Buffer,
- const object::ObjectFile &Obj) {
+ con
@@ -0,0 +1,46 @@
+// REQUIRES: linux || windows
+// Default
+// RUN: %clang -o %t.normal -fprofile-instr-generate -fcoverage-mapping
-fuse-ld=lld %S/Inputs/instrprof-debug-info-correlate-main.cpp
%S/Inputs/instrprof-debug-info-correlate-foo.cpp
+// RUN: env LLVM_PROFILE_FILE=%t.
@@ -0,0 +1,46 @@
+// REQUIRES: linux || windows
MaskRay wrote:
Add `// REQUIRES: lld-available`
https://github.com/llvm/llvm-project/pull/69493
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.ll
MaskRay wrote:
The patch does not apply cleanly at HEAD. The fix-up commit `resolve conflict`
contains the rebased part and a lot of unrelated changes. I think in this case,
it's cleaner to squash all the commits and force push to `binary-correlate`.
(Force push is fine with me:
https://disco
https://github.com/MaskRay edited
https://github.com/llvm/llvm-project/pull/69493
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
101 - 170 of 170 matches
Mail list logo
