DavidSpickett wrote:
Thanks for the reviews folks.
I will wait to see what @medismailben thinks about the registers iterator
function before landing anything.
https://github.com/llvm/llvm-project/pull/70950
___
lldb-commits mailing list
lldb-commits@
llvmbot wrote:
@llvm/pr-subscribers-clangd
@llvm/pr-subscribers-clang-codegen
Author: Vlad Serebrennikov (Endilll)
Changes
This patch converts TagTypeKind into scoped enum. Among other benefits, this
allows us to forward-declare it where necessary.
I plan to land this patch as soon as pr
DavidSpickett wrote:
I'm assuming lack of new tests is because testing is running existing tests on
arm64e. LGTM.
https://github.com/llvm/llvm-project/pull/71128
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/
https://github.com/DavidSpickett approved this pull request.
https://github.com/llvm/llvm-project/pull/71128
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/71004
>From a3d165aa30e8cd32877f30812b41fee380e24e60 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Wed, 1 Nov 2023 12:25:06 +
Subject: [PATCH 1/7] [lldb][DWARFASTParserClang] Fetch constant value from
varia
DavidSpickett wrote:
So in case it was confusing, the revert did fix Arm 32 bit linux as well, but
it stayed red for other reasons.
Also I looked into it on the same machine and got:
```
Unresolved Tests (1):
lldb-api :: functionalities/thread_plan/TestThreadPlanCommands.
Author: David Spickett
Date: 2023-11-03T10:36:39Z
New Revision: 4be8a7bda55c5b50832b773b204f75cd26c5979d
URL:
https://github.com/llvm/llvm-project/commit/4be8a7bda55c5b50832b773b204f75cd26c5979d
DIFF:
https://github.com/llvm/llvm-project/commit/4be8a7bda55c5b50832b773b204f75cd26c5979d.diff
LOG
DavidSpickett wrote:
FYI this did fail on the 32 bit Arm bot
(https://lab.llvm.org/buildbot/#/builders/17/builds/44589), but it had been red
up until then so no notification went out. I've fixed the test in
https://github.com/llvm/llvm-project/commit/4be8a7bda55c5b50832b773b204f75cd26c5979d.
https://github.com/hokein updated
https://github.com/llvm/llvm-project/pull/70779
>From 4cc40aafef4db5133f4360b2fb367e1776dc2901 Mon Sep 17 00:00:00 2001
From: Haojian Wu
Date: Tue, 31 Oct 2023 11:15:45 +0100
Subject: [PATCH 1/2] [LLDB] Don't ignore artificial variables and members for
corouti
https://github.com/hokein edited https://github.com/llvm/llvm-project/pull/70779
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -3061,7 +3061,8 @@ void DWARFASTParserClang::ParseSingleMember(
// artificial member with (unnamed bitfield) padding.
// FIXME: This check should verify that this is indeed an artificial member
// we are supposed to ignore.
- if (attrs.is_artificial) {
+ if (attrs.is
https://github.com/hokein commented:
Thanks for the review.
https://github.com/llvm/llvm-project/pull/70779
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -41,7 +41,10 @@ CPPLanguageRuntime::CPPLanguageRuntime(Process *process)
: LanguageRuntime(process) {}
bool CPPLanguageRuntime::IsAllowedRuntimeValue(ConstString name) {
- return name == g_this;
+ // FIXME: use a list when the list grows more.
+ return name == g_this
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/71175
This macro expands to:
```
assert(expr);
if (!expr)
return retval;
```
This is to be used in places where during development you want a hard error so
it's less confusing to debug, but in release builds yo
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: David Spickett (DavidSpickett)
Changes
This macro expands to:
```
assert(expr);
if (!expr)
return retval;
```
This is to be used in places where during development you want a hard error so
it's less confusing to debug, but in release buil
@@ -339,6 +337,18 @@ bool RegisterContextCorePOSIX_arm64::ReadRegister(const
RegisterInfo *reg_info,
value.SetFromMemoryData(*reg_info, src + sizeof(sve::user_za_header),
reg_info->byte_size, lldb::eByteOrderLittle,
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/71175
>From b49f1a24121207c6905b4f3c48281c34b1554984 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Fri, 3 Nov 2023 10:58:15 +
Subject: [PATCH 1/2] [lldb] Add LLDB_ASSERT_OR_RETURN macro and make use of
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/71175
>From b49f1a24121207c6905b4f3c48281c34b1554984 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Fri, 3 Nov 2023 10:58:15 +
Subject: [PATCH 1/3] [lldb] Add LLDB_ASSERT_OR_RETURN macro and make use of
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/71175
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
Demo: https://godbolt.org/z/z68h7WM6M
https://github.com/llvm/llvm-project/pull/71175
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: David Spickett
Date: 2023-11-03T14:20:05Z
New Revision: 68fbc8eec38d2930b60e01ffb2cbf297eac658fb
URL:
https://github.com/llvm/llvm-project/commit/68fbc8eec38d2930b60e01ffb2cbf297eac658fb
DIFF:
https://github.com/llvm/llvm-project/commit/68fbc8eec38d2930b60e01ffb2cbf297eac658fb.diff
LOG
bolshakov-a added inline comments.
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:2205-2206
"bit-field%select{| %1}2">;
+def err_reference_bind_to_bitfield_in_cce : Error<
+ "reference cannot bind to bit-field in converted constant expression">;
def err_referen
bolshakov-a updated this revision to Diff 557997.
bolshakov-a added a comment.
Fixes after review.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140996/new/
https://reviews.llvm.org/D140996
Files:
clang-tools-extra/clangd/DumpAST.cpp
clang-tools-extra/clangd/FindTarget.cpp
clang/
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/71128
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -139,4 +139,16 @@
#define LLDB_DEPRECATED_FIXME(MSG, FIX) LLDB_DEPRECATED(MSG)
#endif
+// When asserts are enabled, use an assert to check expr. If they are not
+// enabled, return the value retval if expr is not true. Used when a hard
+// failure is useful during developme
JDevlieghere wrote:
I'm torn: on the one hand this is obviously making things better, on the other,
it undermines what an assertion and has the potential to be used where error
handling is necessary. The idea behind the latter is that if your assertion
fails, you're already in an unrecoverable
https://github.com/mysterymath closed
https://github.com/llvm/llvm-project/pull/71112
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Daniel Thornburgh
Date: 2023-11-03T09:26:47-07:00
New Revision: 17798ad7c3596d9b74b5f55ac41f10fe01e8ee4b
URL:
https://github.com/llvm/llvm-project/commit/17798ad7c3596d9b74b5f55ac41f10fe01e8ee4b
DIFF:
https://github.com/llvm/llvm-project/commit/17798ad7c3596d9b74b5f55ac41f10fe01e8ee4b.d
@@ -93,6 +93,10 @@ class DynamicRegisterInfo {
return llvm::iterator_range(m_regs);
}
+ llvm::iterator_range registers_mutable() {
medismailben wrote:
You should be able to use template specialization on the return type to use the
same method name.
I
https://github.com/medismailben approved this pull request.
https://github.com/llvm/llvm-project/pull/70950
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
medismailben wrote:
> I will wait to see what @medismailben thinks about the registers iterator
> function before landing anything.
Thanks for the ping, I replied to your comment.
https://github.com/llvm/llvm-project/pull/70950
___
lldb-commits maili
medismailben wrote:
@DavidSpickett Checking! Thanks for the heads-up.
https://github.com/llvm/llvm-project/pull/70392
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -139,4 +139,16 @@
#define LLDB_DEPRECATED_FIXME(MSG, FIX) LLDB_DEPRECATED(MSG)
#endif
+// When asserts are enabled, use an assert to check expr. If they are not
+// enabled, return the value retval if expr is not true. Used when a hard
+// failure is useful during developme
DavidSpickett wrote:
> The idea behind the latter is that if your assertion fails, you're already
> in an unrecoverable state (and if it were recoverable, error handling would
> have taken care of that).
Sounds like these should be a hypothetical `assert_even_in_release_mode` in
that case. M
@@ -93,6 +93,10 @@ class DynamicRegisterInfo {
return llvm::iterator_range(m_regs);
}
+ llvm::iterator_range registers_mutable() {
DavidSpickett wrote:
That's new to me, so I'll give it a go and worst case I learn something new.
https://github.com/llv
https://github.com/bulbazord edited
https://github.com/llvm/llvm-project/pull/71151
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord approved this pull request.
LGTM, all my comments were minor things I noticed. Thanks for doing this!
https://github.com/llvm/llvm-project/pull/71151
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.l
@@ -0,0 +1,45 @@
+//===-- SymbolLocatorDebugSymbols.h --*- C++
+//-*-===//
bulbazord wrote:
Formatting
https://github.com/llvm/llvm-project/pull/71151
___
lldb-commits mailing list
lldb-
@@ -0,0 +1,91 @@
+//===-- SymbolLocatorDefault.cpp
+//--===//
bulbazord wrote:
Formatting
https://github.com/llvm/llvm-project/pull/71151
___
lldb-commits mailing list
lldb-c
@@ -0,0 +1,328 @@
+//===-- SymbolLocatorDebugSymbols.cpp
+//--===//
bulbazord wrote:
Formatting
https://github.com/llvm/llvm-project/pull/71151
___
lldb-commits mailing list
@@ -0,0 +1,23 @@
+//===-- SymbolLocator.h -*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/71128
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/71151
>From 234258ff47b075a7094b5d57bfc0a420c49c7edb Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Thu, 2 Nov 2023 23:29:20 -0700
Subject: [PATCH 1/2] [lldb] Convert LocateSymbolFile into a plugin
This c
bolshakov-a updated this revision to Diff 558001.
bolshakov-a added a comment.
One more problem has been discovered and fixed: IR emitting didn't work when
using a subobject as a template argument when the corresponding template
parameter is used in an lvalue context. A test case has been added
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 7ca0f4418a6d385e07d9aff42865c34d3dc2adf7
9f0245e71c92f5f613689dabe227628b624ddc2b --
https://github.com/Endilll closed
https://github.com/llvm/llvm-project/pull/71160
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/71228
AddName gives no feedback other than if it succeeded whereas
AddNameWithErrorHandling gives you back an SBError object. I would like to mark
AddName as deprecated and direct folks to use AddNameWithErorrHandli
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Alex Langford (bulbazord)
Changes
AddName gives no feedback other than if it succeeded whereas
AddNameWithErrorHandling gives you back an SBError object. I would like to mark
AddName as deprecated and direct folks to use AddNameWithErorrHa
https://github.com/medismailben requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/71228
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben edited
https://github.com/llvm/llvm-project/pull/71228
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -112,6 +112,7 @@ class LLDB_API SBBreakpoint {
SBError SetScriptCallbackBody(const char *script_body_text);
+ LLDB_DEPRECATED("Use AddNameWithErrorHandling instead")
medismailben wrote:
```suggestion
LLDB_DEPRECATED_FIXME("Doesn't provide error handl
https://github.com/joker-eph edited
https://github.com/llvm/llvm-project/pull/71165
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/joker-eph closed
https://github.com/llvm/llvm-project/pull/71165
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord updated
https://github.com/llvm/llvm-project/pull/71228
>From e1e99bdf51d559aa9c96cfd733f12b35e8db7728 Mon Sep 17 00:00:00 2001
From: Alex Langford
Date: Fri, 3 Nov 2023 13:24:27 -0700
Subject: [PATCH 1/2] [lldb] Deprecate SBBreakpoint::AddName in favor of
AddNameW
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff fcc26bad82e190e1ec09bc6fe76ea320f5ffeeeb
c8d96df16b669670267e8e257f4005b80d28194b --
https://github.com/zhyty created https://github.com/llvm/llvm-project/pull/71230
Easy change to get `image dump separate-debug-info` working when using
`symbols.load-on-demand`. Also added a line of space in the default table
output.
Added tests
```
bin/lldb-dotest -p TestDumpDwo
```
It's eas
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Tom Yang (zhyty)
Changes
Easy change to get `image dump separate-debug-info` working when using
`symbols.load-on-demand`. Also added a line of space in the default table
output.
Added tests
```
bin/lldb-dotest -p TestDumpDwo
```
It's eas
https://github.com/bulbazord updated
https://github.com/llvm/llvm-project/pull/71228
>From e1e99bdf51d559aa9c96cfd733f12b35e8db7728 Mon Sep 17 00:00:00 2001
From: Alex Langford
Date: Fri, 3 Nov 2023 13:24:27 -0700
Subject: [PATCH 1/3] [lldb] Deprecate SBBreakpoint::AddName in favor of
AddNameW
@@ -1255,6 +1258,676 @@ class CommandObjectScriptingObject : public
CommandObjectRaw {
CompletionType m_completion_type = eNoCompletion;
};
+
+/// This command implements a lldb parsed scripted command. The command
+/// provides a definition of the options and arguments, a
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/71236
The return value is completely unused. Let's just return nothing.
>From 1077476df553c21a88b1cbb80f7fc8635c88ff7f Mon Sep 17 00:00:00 2001
From: Alex Langford
Date: Fri, 3 Nov 2023 14:37:07 -0700
Subject: [PATC
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Alex Langford (bulbazord)
Changes
The return value is completely unused. Let's just return nothing.
---
Full diff: https://github.com/llvm/llvm-project/pull/71236.diff
2 Files Affected:
- (modified) lldb/include/lldb/Breakpoint/Breakpoin
https://github.com/Michael137 approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/71236
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jimingham wrote:
That makes the comment directly above your change invalid.
https://github.com/llvm/llvm-project/pull/71236
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jimingham wrote:
With this change it could no longer check name validity (wasn't anyway, but...)
https://github.com/llvm/llvm-project/pull/71236
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/l
jimingham wrote:
Probably should change that to "callers are required to check name validity?"
Either that or move whoever is doing the checking here if you want to
centralize that.
https://github.com/llvm/llvm-project/pull/71236
___
lldb-commits ma
bulbazord wrote:
I'll just remove the comment. If we want to make this do error checking, we'll
have to shuffle around even more code than this change does right now. I wanted
to mostly get rid of this piece of cognitive overhead (why does this return
something and why do we drop it on the flo
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/71241
By itself this change does very little, but I plan on refactoring something
from StructuredData and it gets much easier with this change.
>From 70ca8af7794b1de998ec3b0145d3e94daac3358e Mon Sep 17 00:00:00 2001
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Alex Langford (bulbazord)
Changes
By itself this change does very little, but I plan on refactoring something
from StructuredData and it gets much easier with this change.
---
Full diff: https://github.com/llvm/llvm-project/pull/71241.diff
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/71151
>From 08eb0a2fef369c81c87c517811e634fd0cac7c6d Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Thu, 2 Nov 2023 23:29:20 -0700
Subject: [PATCH] [lldb] Introduce a plugin to locate symbols
This commit
https://github.com/bulbazord updated
https://github.com/llvm/llvm-project/pull/71236
>From 1077476df553c21a88b1cbb80f7fc8635c88ff7f Mon Sep 17 00:00:00 2001
From: Alex Langford
Date: Fri, 3 Nov 2023 14:37:07 -0700
Subject: [PATCH 1/2] [lldb] Change Breakpoint::AddName return value
The return v
Author: Jonas Devlieghere
Date: 2023-11-03T15:42:23-07:00
New Revision: c3a302d399e62ac2a21c52f1f0215bd772cbf54b
URL:
https://github.com/llvm/llvm-project/commit/c3a302d399e62ac2a21c52f1f0215bd772cbf54b
DIFF:
https://github.com/llvm/llvm-project/commit/c3a302d399e62ac2a21c52f1f0215bd772cbf54b.d
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/71151
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/71247
This builds on top of the work started in c3a302d to convert LocateSymbolFile
to a SymbolLocator plugin. This commit moves FindSymbolFileInBundle.
>From a7ea01aca6b22a5eaf48f29ba162d6f4855a0352 Mon Sep 17 0
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
This builds on top of the work started in c3a302d to convert LocateSymbolFile
to a SymbolLocator plugin. This commit moves FindSymbolFileInBundle.
---
Full diff: https://github.com/llvm/llvm-project
https://github.com/bulbazord approved this pull request.
Awesome!
https://github.com/llvm/llvm-project/pull/71247
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jasonmolenda wrote:
> I'm assuming lack of new tests is because testing is running existing tests
> on arm64e. LGTM.
Yeah, lldb can't get the dynamic type in any function that takes a base class
argument but a subclass object is passed in (and they have virtual functions),
there's tests for t
Author: Jason Molenda
Date: 2023-11-03T16:26:12-07:00
New Revision: de24b0ef94bc0c4483e39e1bad75dbec793f2b94
URL:
https://github.com/llvm/llvm-project/commit/de24b0ef94bc0c4483e39e1bad75dbec793f2b94
DIFF:
https://github.com/llvm/llvm-project/commit/de24b0ef94bc0c4483e39e1bad75dbec793f2b94.diff
https://github.com/jasonmolenda closed
https://github.com/llvm/llvm-project/pull/71128
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jimingham wrote:
LGTM
https://github.com/llvm/llvm-project/pull/71241
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben approved this pull request.
https://github.com/llvm/llvm-project/pull/71241
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/GeorgeHuyubo created
https://github.com/llvm/llvm-project/pull/71258
Easy change. Migrate to new template function call.
More context:
https://github.com/llvm/llvm-project/commit/6f8b33f6dfd0a0f8d2522b6c832bd6298ae2f3f3
>From 78ca41214490ffa9ec845979724e0f7c56ea27e9 Mon Sep
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (GeorgeHuyubo)
Changes
Easy change. Migrate to new template function call.
More context:
https://github.com/llvm/llvm-project/commit/6f8b33f6dfd0a0f8d2522b6c832bd6298ae2f3f3
---
Full diff: https://github.com/llvm/llvm-project/pull/712
https://github.com/GeorgeHuyubo closed
https://github.com/llvm/llvm-project/pull/71230
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/GeorgeHuyubo reopened
https://github.com/llvm/llvm-project/pull/71230
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/71258
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -2691,6 +2691,7 @@ class CommandObjectTargetModulesDumpSeparateDebugInfoFiles
"Found unsupported debug info type '%s'.\n",
type.str().c_str());
}
+ strm.EOL();
bulbazord wrote:
This change l
@@ -130,3 +130,29 @@ def test_dwos_not_loaded_table_output(self):
"0x[a-zA-Z0-9]{16}\s+E\s+.*foo\.dwo",
],
)
+
+@skipIfRemote
+@skipIfDarwin
+@skipIfWindows
bulbazord wrote:
This test doesn't actually debug a pro
https://github.com/medismailben created
https://github.com/llvm/llvm-project/pull/71260
This patch enforces that every scripted object implements all the necessary
abstract methods.
Every scripted affordance language interface can implement a list of abstract
methods name that checked when th
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Med Ismail Bennani (medismailben)
Changes
This patch enforces that every scripted object implements all the necessary
abstract methods.
Every scripted affordance language interface can implement a list of abstract
methods name that checke
https://github.com/medismailben approved this pull request.
https://github.com/llvm/llvm-project/pull/71258
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2023-11-03T18:07:57-07:00
New Revision: 9b2246d9fad9fe62be26d22e184f241304779551
URL:
https://github.com/llvm/llvm-project/commit/9b2246d9fad9fe62be26d22e184f241304779551
DIFF:
https://github.com/llvm/llvm-project/commit/9b2246d9fad9fe62be26d22e184f241304779551.d
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/71247
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -28,6 +28,10 @@ class ScriptedProcessInterface : virtual public
ScriptedInterface {
return {llvm::make_error()};
}
+ llvm::SmallVector GetAbstractMethods() const override {
+return {};
+ }
bulbazord wrote:
Same here
https://github.com/llvm/ll
@@ -26,6 +26,10 @@ class ScriptedPlatformInterface : virtual public
ScriptedInterface {
return {llvm::make_error()};
}
+ llvm::SmallVector GetAbstractMethods() const override {
+return {};
+ }
bulbazord wrote:
I don't think we should implement th
@@ -103,24 +139,79 @@ class ScriptedPythonInterface : virtual public
ScriptedInterface {
"Resulting object is not initialized.");
std::apply(
- [&method, &expected_return_object](auto &&...args) {
+ [&init, &expected_r
@@ -103,24 +139,79 @@ class ScriptedPythonInterface : virtual public
ScriptedInterface {
"Resulting object is not initialized.");
std::apply(
- [&method, &expected_return_object](auto &&...args) {
+ [&init, &expected_r
@@ -32,6 +32,42 @@ class ScriptedPythonInterface : virtual public
ScriptedInterface {
ScriptedPythonInterface(ScriptInterpreterPythonImpl &interpreter);
~ScriptedPythonInterface() override = default;
+ enum class AbstractMethodCheckerCases {
+eNotImplemented,
+eN
@@ -103,24 +139,79 @@ class ScriptedPythonInterface : virtual public
ScriptedInterface {
"Resulting object is not initialized.");
std::apply(
- [&method, &expected_return_object](auto &&...args) {
+ [&init, &expected_r
@@ -663,6 +663,18 @@ bool PythonDictionary::Check(PyObject *py_obj) {
return PyDict_Check(py_obj);
}
+bool PythonDictionary::HasKey(const llvm::Twine &key) const {
bulbazord wrote:
Why a `Twine` and not a `StringRef`?
https://github.com/llvm/llvm-project/p
@@ -32,6 +32,42 @@ class ScriptedPythonInterface : virtual public
ScriptedInterface {
ScriptedPythonInterface(ScriptInterpreterPythonImpl &interpreter);
~ScriptedPythonInterface() override = default;
+ enum class AbstractMethodCheckerCases {
+eNotImplemented,
+eN
1 - 100 of 117 matches
Mail list logo
