Author: David Spickett
Date: 2023-10-17T09:01:07+01:00
New Revision: 4606712ef5b422edbe3799b665dcad7dcf348b90
URL:
https://github.com/llvm/llvm-project/commit/4606712ef5b422edbe3799b665dcad7dcf348b90
DIFF:
https://github.com/llvm/llvm-project/commit/4606712ef5b422edbe3799b665dcad7dcf348b90.diff
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/68866
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -18,9 +18,10 @@
# Introduction
DavidSpickett wrote:
I think a stub README at the old lldb-vscode location is worth adding. It
should just link here.
https://github.com/llvm/llvm-project/pull/69264
___
lldb-commi
@@ -18,9 +18,10 @@
# Introduction
-The `lldb-vscode` tool creates a command line tool that implements the [Visual
-Studio Code Debug
API](https://code.visualstudio.com/docs/extensionAPI/api-debugging).
-It can be installed as an extension for the Visual Studio Code and Nucli
@@ -196,6 +196,7 @@ Changes to LLDB
for formatters to quickly find directly nested type when it's known
where to search for it, avoiding more expensive global search via
``SBTarget::FindFirstType``.
+* ``lldb-vscode`` was renamed to `lldb-dap``.
DavidSpic
@@ -40,59 +41,59 @@ If you want to make a stand alone plug-in that you can send
to others on UNIX
systems:
```bash
-mkdir -p ~/llvm-org.lldb-vscode-0.1.0/bin
-cp package.json ~/llvm-org.lldb-vscode-0.1.0
-cd ~/llvm-org.lldb-vscode-0.1.0/bin
-cp /path/to/a/built/lldb-vscode .
DavidSpickett wrote:
Also I just gave you some conflicts with
https://github.com/llvm/llvm-project/commit/4606712ef5b422edbe3799b665dcad7dcf348b90.
I think only the "type" bit needs changing to "lldb-dap".
https://github.com/llvm/llvm-project/pull/69264
@@ -1,5 +1,5 @@
{
- "name": "lldb-vscode",
+ "name": "lldb-dap",
DavidSpickett wrote:
This and others are still in an "lldb-vscode" folder, that doesn't seem right.
https://github.com/llvm/llvm-project/pull/69264
@@ -1,3 +1,10 @@
# REQUIRES: system-darwin
+# TODO: This test is breaking with my output
+# reformatting done for Large Watchpoint support,
+# but the lines being output by lldb are identical,
+# by visual inspection.
+# FileCheck is seeing some difference between them,
+# whi
@@ -135,5 +135,5 @@ def test_watch_address_with_invalid_watch_size(self):
self.expect(
error.GetCString(),
exe=False,
-substrs=["watch size of %d is not supported" % 365],
+substrs=["Setting one of the
@@ -0,0 +1,61 @@
+//===-- WatchpointResourceList.cpp
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,61 @@
+//===-- WatchpointResourceList.cpp
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -2,8 +2,8 @@
#include
int main() {
- uint8_t x1 = 0;
- uint16_t x2 = 0;
+ long x1 = 0;
+ long x2 = 0;
DavidSpickett wrote:
We need the type change here because?
https://github.com/llvm/llvm-project/pull/68845
_
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/69315
This means you don't have to do RegisterField("", 0, 0), you can do
RegisterField("", 0).
Which is useful for testing and even more useful when we are writing
definitions of real registers which have 10s
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: David Spickett (DavidSpickett)
Changes
This means you don't have to do RegisterField("", 0, 0), you can do
RegisterField("", 0).
Which is useful for testing and even more useful when we are writing
definitions of real registers which have
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/69315
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
I built this locally and I did not get a `bin/lldb-dap` only `lldb-vscde` as
before, but it was an existing build folder. So if your clean build is correct
you can ignore that part.
I followed the install instructions and got the "LLDB VSCode" extension with
type "llda-da
DavidSpickett wrote:
Actually there was a ninja target for `lldb-dap` but it wasn't built by
default. Again, existing cmake config so if yours is fine then ignore this.
https://github.com/llvm/llvm-project/pull/69264
___
lldb-commits mailing list
lldb
https://github.com/erichkeane edited
https://github.com/llvm/llvm-project/pull/69010
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -3083,6 +3083,10 @@ ScalarExprEmitter::VisitUnaryExprOrTypeTraitExpr(
E->getTypeOfArgument()->getPointeeType()))
.getQuantity();
return llvm::ConstantInt::get(CGF.SizeTy, Alignment);
+ } else if (E->getKind() == UETT_VectorElements) {
+au
@@ -5126,6 +5126,14 @@ void CXXNameMangler::mangleExpression(const Expr *E,
unsigned Arity,
Diags.Report(DiagID);
return;
}
+case UETT_VectorElements: {
lawben wrote:
I don't know. But none of the other `UETT_*` types are covered in
`Micr
https://github.com/lawben updated
https://github.com/llvm/llvm-project/pull/69010
>From df8d0a53a31e1351bb6cd3b340e9012b489e9885 Mon Sep 17 00:00:00 2001
From: Lawrence Benson
Date: Wed, 11 Oct 2023 17:26:11 +0200
Subject: [PATCH 01/10] Add __builtin_vectorelements to get the number of
element
@@ -5126,6 +5126,14 @@ void CXXNameMangler::mangleExpression(const Expr *E,
unsigned Arity,
Diags.Report(DiagID);
return;
}
+case UETT_VectorElements: {
erichkeane wrote:
OK, SGTM at least, I just know this pattern of 'cannot yet mangle...
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/69238
>From 19295d5fe84c1f06f3e5d712d5af39f8ef48286c Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Mon, 16 Oct 2023 15:08:20 -0400
Subject: [PATCH] [lldb-vscode] Allow specifying a custom escape charac
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/69238
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord edited
https://github.com/llvm/llvm-project/pull/69315
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord commented:
Makes sense to me since this seems to be a relatively common pattern (from the
tests).
Is there anywhere you can begin to use this other than in the tests? Or is this
building up to [your proposal on adding register field info to
lldb-server](https://di
@@ -17,11 +17,17 @@ class RegisterFlags {
public:
class Field {
public:
+/// Where start is the least significant bit and end is the most
+/// significant bit. The start bit must be <= the end bit.
Field(std::string name, unsigned start, unsigned end)
https://github.com/medismailben approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/69231
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg wrote:
There are probably a lot of functions that could be converted from a "Stream *"
to "Stream &".
https://github.com/llvm/llvm-project/pull/69231
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/ma
bulbazord wrote:
> There are probably a lot of functions that could be converted from a "Stream
> *" to "Stream &".
Yes, when I have a spare 5-10 minutes I pick a function and convert it. I don't
want to end up with a huge diff that is difficult to merge downstream so I do
it piecemeal.
http
JDevlieghere wrote:
> Actually there was a ninja target for `lldb-dap` but it wasn't built by
> default. Again, existing cmake config so if yours is fine then ignore this.
Yes, I had the same thing happen to me with an incremental build, but
everything looked correct for a clean build.
https
@@ -18,9 +18,10 @@
# Introduction
JDevlieghere wrote:
I've made `lldb-vscode` a symlink to `lldb-dap`.
https://github.com/llvm/llvm-project/pull/69264
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https
@@ -40,59 +41,59 @@ If you want to make a stand alone plug-in that you can send
to others on UNIX
systems:
```bash
-mkdir -p ~/llvm-org.lldb-vscode-0.1.0/bin
-cp package.json ~/llvm-org.lldb-vscode-0.1.0
-cd ~/llvm-org.lldb-vscode-0.1.0/bin
-cp /path/to/a/built/lldb-vscode .
walter-erquinigo wrote:
@JDevlieghere , PTAL
https://discourse.llvm.org/t/rfc-rename-lldb-vscode-to-lldb-dap/74075/16?u=wallace
https://github.com/llvm/llvm-project/pull/69264
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.ll
JDevlieghere wrote:
> @JDevlieghere , PTAL
> https://discourse.llvm.org/t/rfc-rename-lldb-vscode-to-lldb-dap/74075/16?u=wallace
I just replied! :D
https://github.com/llvm/llvm-project/pull/69264
___
lldb-commits mailing list
lldb-commits@lists.llvm.
https://github.com/jeffreytan81 updated
https://github.com/llvm/llvm-project/pull/69253
>From 4a668481a1a17512ee412c31b452c114626f8cde Mon Sep 17 00:00:00 2001
From: jeffreytan81
Date: Mon, 16 Oct 2023 14:21:40 -0700
Subject: [PATCH 1/3] Guard against invalid variant index
---
lldb/examples/s
https://github.com/walter-erquinigo approved this pull request.
https://github.com/llvm/llvm-project/pull/69264
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
walter-erquinigo wrote:
fantastic!
https://github.com/llvm/llvm-project/pull/69264
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -388,7 +385,7 @@ llvm::json::Value CreateThreadStopped(lldb::SBThread
&thread, uint32_t stop_id);
/// The variable name of \a value or a default placeholder.
const char *GetNonNullVariableName(lldb::SBValue value);
-/// VSCode can't display two variables with the same
@@ -196,6 +196,9 @@ Changes to LLDB
for formatters to quickly find directly nested type when it's known
where to search for it, avoiding more expensive global search via
``SBTarget::FindFirstType``.
+* ``lldb-vscode`` was renamed to ``lldb-dap`` and and its installation
+
https://github.com/slackito edited
https://github.com/llvm/llvm-project/pull/69264
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/slackito commented:
Thanks for doing this!
https://github.com/llvm/llvm-project/pull/69264
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -437,7 +434,7 @@ std::string
CreateUniqueVariableNameForDisplay(lldb::SBValue v,
/// context (e.g. locals). This can happen due to shadowed variables in
/// nested blocks.
///
-/// As VSCode doesn't render two of more variables with the same name, we
---
https://github.com/ZijunZhaoCCK updated
https://github.com/llvm/llvm-project/pull/65148
>From 02e9afd761228f401df4d9f8dfaaca44ffae0c6e Mon Sep 17 00:00:00 2001
From: zijunzhao
Date: Thu, 31 Aug 2023 20:08:32 +
Subject: [PATCH 01/16] [libc++] Implement ranges::contains
Differential Revision
https://github.com/clayborg approved this pull request.
https://github.com/llvm/llvm-project/pull/69253
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
walter-erquinigo wrote:
@clayborg , friendly ping
https://github.com/llvm/llvm-project/pull/69238
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Usama Hameed (usama54321)
Changes
[lldb] Refactor InstrumentationRuntimeAsan and add a new plugin
InstrumentationRuntimeLibsanitizers.
This commit adds InstrumentationRuntimeLibsanitizers, a new runtime plugin for
ASan. The plugin provide
https://github.com/usama54321 updated
https://github.com/llvm/llvm-project/pull/69388
>From 3ee63c7dfd8b92ac8738d19bd3cebffeccfd59ec Mon Sep 17 00:00:00 2001
From: usama
Date: Tue, 17 Oct 2023 14:35:04 -0700
Subject: [PATCH] [lldb] Refactor InstrumentationRuntimeAsan and add a new
plugin Instr
usama54321 wrote:
@llvm-ci test
https://github.com/llvm/llvm-project/pull/69388
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff cf670d5e56d14afa7c3e005c13588fd7b5ee75ce
76493df4dcfc055ec0b4f7d745f3799b904f679d --
Author: walter erquinigo
Date: 2023-10-17T18:15:29-04:00
New Revision: 59908504cd7a72cd2a614e5c6db5410101209365
URL:
https://github.com/llvm/llvm-project/commit/59908504cd7a72cd2a614e5c6db5410101209365
DIFF:
https://github.com/llvm/llvm-project/commit/59908504cd7a72cd2a614e5c6db5410101209365.di
Author: Alex Langford
Date: 2023-10-17T15:40:51-07:00
New Revision: 170b552136f845ffc4267c8728629b6b6b19518d
URL:
https://github.com/llvm/llvm-project/commit/170b552136f845ffc4267c8728629b6b6b19518d
DIFF:
https://github.com/llvm/llvm-project/commit/170b552136f845ffc4267c8728629b6b6b19518d.diff
https://github.com/bulbazord closed
https://github.com/llvm/llvm-project/pull/69231
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: walter erquinigo
Date: 2023-10-17T18:50:18-04:00
New Revision: 7d1bf1c5cf284ce1a18fe0ce4a4cf91f3e514866
URL:
https://github.com/llvm/llvm-project/commit/7d1bf1c5cf284ce1a18fe0ce4a4cf91f3e514866
DIFF:
https://github.com/llvm/llvm-project/commit/7d1bf1c5cf284ce1a18fe0ce4a4cf91f3e514866.di
@@ -1,5 +1,7 @@
+add_subdirectory(Libsanitizers)
JDevlieghere wrote:
Rather than living under the Asan plugin, it seems like his should be living at
the same level. If there's shared code between the two plugins, we should hoist
that up into a separate library
@@ -0,0 +1,56 @@
+//===-- InstrumentationRuntimeLibsanitizers.h *-
C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identi
@@ -0,0 +1,108 @@
+//===-- InstrumentationRuntimeLibsanitizers.cpp
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Ident
@@ -0,0 +1,31 @@
+//===-- ReportRetriever.h *- C++ -*-===//
JDevlieghere wrote:
Fix ASCII art
https://github.com/llvm/llvm-project/pull/69388
___
lldb-commits mailing list
lldb-commits@lists
@@ -0,0 +1,108 @@
+//===-- InstrumentationRuntimeLibsanitizers.cpp
===//
JDevlieghere wrote:
Fix ASCII art
https://github.com/llvm/llvm-project/pull/69388
___
lldb-commits mailing l
@@ -0,0 +1,56 @@
+//===-- InstrumentationRuntimeLibsanitizers.h *-
C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identi
@@ -388,7 +385,7 @@ llvm::json::Value CreateThreadStopped(lldb::SBThread
&thread, uint32_t stop_id);
/// The variable name of \a value or a default placeholder.
const char *GetNonNullVariableName(lldb::SBValue value);
-/// VSCode can't display two variables with the same
https://github.com/jeffreytan81 closed
https://github.com/llvm/llvm-project/pull/69253
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: jeffreytan81
Date: 2023-10-17T17:26:05-07:00
New Revision: 659a48f25a96b7072b44d372c47385a2608f8671
URL:
https://github.com/llvm/llvm-project/commit/659a48f25a96b7072b44d372c47385a2608f8671
DIFF:
https://github.com/llvm/llvm-project/commit/659a48f25a96b7072b44d372c47385a2608f8671.diff
rupprecht wrote:
This seems to cause `TestTemplatePackArgs.py` to fail, e.g.
https://lab.llvm.org/buildbot/#/builders/68/builds/61819
```shell
File
"/home/worker/2.0.1/lldb-x86_64-debian/llvm-project/lldb/test/API/lang/cpp/class-template-parameter-pack/TestTemplatePackArgs.py",
line 42, in
https://github.com/taalhaataahir0102 created
https://github.com/llvm/llvm-project/pull/69422
This is the current issue for symbol search:
https://github.com/llvm/llvm-project/issues/57372
Previously some work has already been done on this. A PR was generated but it
remained in review:
https://
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 112e49b38150b8bfdef01434309d1b05204193e4
07e3a614c1a346c3a09dbf232328b83b744750b2 --
67 matches
Mail list logo
