[Lldb-commits] [lldb] [AMDGPU] Change the representation of double literals in operands (PR #68740)

2023-10-13 Thread Stanislav Mekhanoshin via lldb-commits
rampitec wrote: > I suppose left shift of negative values is undefined because if you shift out > the sign bit you can overflow and get a positive value. https://github.com/llvm/llvm-project/pull/68959 https://github.com/llvm/llvm-project/pull/68740

[Lldb-commits] [lldb] [lldb] Add SBType::FindNestedType() function (PR #68705)

2023-10-13 Thread Michael Buch via lldb-commits
@@ -119,6 +119,15 @@ def test(self): self.assertEqual(task_type, task_head_pointee_type) +# Check whether we can find a nested type by name +name_type = task_type.FindNestedType("name") +self.assertTrue(name_type) +self.DebugSBType(name

[Lldb-commits] [lldb] [lldb] Add SBType::FindNestedType() function (PR #68705)

2023-10-13 Thread Michael Buch via lldb-commits
@@ -119,6 +119,38 @@ def test(self): self.assertEqual(task_type, task_head_pointee_type) +# Check whether we can find a directly nested type by name +name_type = task_type.FindDirectNestedType("name") +self.assertTrue(name_type) +self.D

[Lldb-commits] [lldb] [lldb] Add SBType::FindNestedType() function (PR #68705)

2023-10-13 Thread Michael Buch via lldb-commits
@@ -8,6 +8,9 @@ class Task { TASK_TYPE_1, TASK_TYPE_2 } type; +enum E : unsigned char {} e; +union U { +} u; Michael137 wrote: Can you move these below that `struct name`. Just so it's closer to Jim's example where if we did a

[Lldb-commits] [lldb] [lldb] Add SBType::FindNestedType() function (PR #68705)

2023-10-13 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/68705 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [mlir][arith] Fix canon pattern for large ints in chained arith (PR #68900)

2023-10-13 Thread Rik Huijzer via lldb-commits
https://github.com/rikhuijzer updated https://github.com/llvm/llvm-project/pull/68900 >From ddbde18e483d12485ba25c715e8a94480b9d6dcf Mon Sep 17 00:00:00 2001 From: Rik Huijzer Date: Thu, 12 Oct 2023 16:55:22 +0200 Subject: [PATCH 1/3] [mlir][arith] Fix canon pattern for large ints in chained a

[Lldb-commits] [lldb] [lldb][test] Temporarily disable TestQueueFromStdModule.py (PR #68970)

2023-10-13 Thread Michael Buch via lldb-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/68970 Started failing since D101206, but root-cause is unclear. It's definitely not an issue with th libc++ patch itself however. So disable the test until we know what's going on. >From 88007827eb5d2ffda60a127e66

[Lldb-commits] [lldb] [mlir][arith] Fix canon pattern for large ints in chained arith (PR #68900)

2023-10-13 Thread Rik Huijzer via lldb-commits
https://github.com/rikhuijzer updated https://github.com/llvm/llvm-project/pull/68900 >From ddbde18e483d12485ba25c715e8a94480b9d6dcf Mon Sep 17 00:00:00 2001 From: Rik Huijzer Date: Thu, 12 Oct 2023 16:55:22 +0200 Subject: [PATCH 1/4] [mlir][arith] Fix canon pattern for large ints in chained a

[Lldb-commits] [lldb] [mlir][arith] Fix canon pattern for large ints in chained arith (PR #68900)

2023-10-13 Thread Rik Huijzer via lldb-commits
@@ -39,26 +39,29 @@ using namespace mlir::arith; static IntegerAttr applyToIntegerAttrs(PatternRewriter &builder, Value res, Attribute lhs, Attribute rhs, -function_ref binFn) { - return builder.getIntegerAttr(res.getType(), -

[Lldb-commits] [lldb] [lldb][test] Temporarily disable TestQueueFromStdModule.py (PR #68970)

2023-10-13 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes Started failing since D101206, but root-cause is unclear. It's definitely not an issue with th libc++ patch itself however. So disable the test until we know what's going on. --- Full diff: https://github

[Lldb-commits] [lldb] [lldb] Add SBType::FindNestedType() function (PR #68705)

2023-10-13 Thread Vlad Serebrennikov via lldb-commits
@@ -119,6 +119,38 @@ def test(self): self.assertEqual(task_type, task_head_pointee_type) +# Check whether we can find a directly nested type by name +name_type = task_type.FindDirectNestedType("name") +self.assertTrue(name_type) +self.D

[Lldb-commits] [lldb] [lldb] Add SBType::FindNestedType() function (PR #68705)

2023-10-13 Thread Vlad Serebrennikov via lldb-commits
https://github.com/Endilll edited https://github.com/llvm/llvm-project/pull/68705 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add SBType::FindNestedType() function (PR #68705)

2023-10-13 Thread Michael Buch via lldb-commits
@@ -119,6 +119,38 @@ def test(self): self.assertEqual(task_type, task_head_pointee_type) +# Check whether we can find a directly nested type by name +name_type = task_type.FindDirectNestedType("name") +self.assertTrue(name_type) +self.D

[Lldb-commits] [lldb] [lldb] Add SBType::FindNestedType() function (PR #68705)

2023-10-13 Thread Vlad Serebrennikov via lldb-commits
https://github.com/Endilll updated https://github.com/llvm/llvm-project/pull/68705 >From ca4d1bbdeb4ea541199e3db3518b35eb2d5a8cad Mon Sep 17 00:00:00 2001 From: Vlad Serebrennikov Date: Tue, 10 Oct 2023 15:07:56 +0300 Subject: [PATCH 01/13] [lldb] Add SBType::FindNestedType() function --- lld

[Lldb-commits] [lldb] [lldb] Add SBType::FindNestedType() function (PR #68705)

2023-10-13 Thread Vlad Serebrennikov via lldb-commits
@@ -8,6 +8,9 @@ class Task { TASK_TYPE_1, TASK_TYPE_2 } type; +enum E : unsigned char {} e; +union U { +} u; Endilll wrote: Done! https://github.com/llvm/llvm-project/pull/68705 ___ l

[Lldb-commits] [lldb] [lldb][test] Temporarily disable TestQueueFromStdModule.py (PR #68970)

2023-10-13 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r f54dc7b3936f1bd751db710cfc2fec1652159a3f..88007827eb5d2ffda60a127e664c00b921875d04 lldb/

[Lldb-commits] [lldb] [lldb] Add SBType::FindNestedType() function (PR #68705)

2023-10-13 Thread Michael Buch via lldb-commits
https://github.com/Michael137 approved this pull request. LGTM, if @jimingham doesn't have any other comments https://github.com/llvm/llvm-project/pull/68705 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailm

[Lldb-commits] [lldb] [lldb] Add SBType::FindDirectNestedType() function (PR #68705)

2023-10-13 Thread Vlad Serebrennikov via lldb-commits
https://github.com/Endilll edited https://github.com/llvm/llvm-project/pull/68705 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [mlir][arith] Fix canon pattern for large ints in chained arith (PR #68900)

2023-10-13 Thread Rik Huijzer via lldb-commits
https://github.com/rikhuijzer closed https://github.com/llvm/llvm-project/pull/68900 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Temporarily disable TestQueueFromStdModule.py (PR #68970)

2023-10-13 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/68970 >From 88007827eb5d2ffda60a127e664c00b921875d04 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Fri, 13 Oct 2023 10:46:42 +0100 Subject: [PATCH 1/2] [lldb][test] Temporarily disable TestQueueFromStdModule.py

[Lldb-commits] [lldb] [lldb] Add SBType::FindDirectNestedType() function (PR #68705)

2023-10-13 Thread Vlad Serebrennikov via lldb-commits
https://github.com/Endilll updated https://github.com/llvm/llvm-project/pull/68705 >From ca4d1bbdeb4ea541199e3db3518b35eb2d5a8cad Mon Sep 17 00:00:00 2001 From: Vlad Serebrennikov Date: Tue, 10 Oct 2023 15:07:56 +0300 Subject: [PATCH 01/14] [lldb] Add SBType::FindNestedType() function --- lld

[Lldb-commits] [lldb] [lldb] Add SBType::FindDirectNestedType() function (PR #68705)

2023-10-13 Thread Vlad Serebrennikov via lldb-commits
@@ -313,6 +313,8 @@ class TypeImpl { bool GetDescription(lldb_private::Stream &strm, lldb::DescriptionLevel description_level); + CompilerType FindNestedType(ConstString name); Endilll wrote: I followed @Michael137 suggestion that `Ty

[Lldb-commits] [lldb] [lldb] Add SBType::FindDirectNestedType() function (PR #68705)

2023-10-13 Thread Vlad Serebrennikov via lldb-commits
@@ -586,6 +586,15 @@ lldb::TemplateArgumentKind SBType::GetTemplateArgumentKind(uint32_t idx) { return eTemplateArgumentKindNull; } +SBType SBType::FindNestedType(const char *name) { + LLDB_INSTRUMENT_VA(this); + + if (!IsValid()) +return SBType(); + auto ret = SBTyp

[Lldb-commits] [lldb] [lldb] fix release build (PR #68979)

2023-10-13 Thread Mikhail Goncharov via lldb-commits
https://github.com/metaflow created https://github.com/llvm/llvm-project/pull/68979 due to 64d78d8b3cd09dff32c97fbefa56bcfc8b676406 that used side effects in assert() >From d632aa31f3b5a5a98bc84b4523f06f82e9d7e8a8 Mon Sep 17 00:00:00 2001 From: Mikhail Goncharov Date: Fri, 13 Oct 2023 13:34:0

[Lldb-commits] [lldb] [lldb] fix release build (PR #68979)

2023-10-13 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Mikhail Goncharov (metaflow) Changes due to 64d78d8b3cd09dff32c97fbefa56bcfc8b676406 that used side effects in assert() --- Full diff: https://github.com/llvm/llvm-project/pull/68979.diff 1 Files Affected: - (modified) lldb/source/Comma

[Lldb-commits] [lldb] 5d35273 - [lldb] fix release build (#68979)

2023-10-13 Thread via lldb-commits
Author: Mikhail Goncharov Date: 2023-10-13T13:53:31+02:00 New Revision: 5d35273a32d239b7407338e13ed71b59174d6536 URL: https://github.com/llvm/llvm-project/commit/5d35273a32d239b7407338e13ed71b59174d6536 DIFF: https://github.com/llvm/llvm-project/commit/5d35273a32d239b7407338e13ed71b59174d6536.d

[Lldb-commits] [lldb] [lldb] fix release build (PR #68979)

2023-10-13 Thread Mikhail Goncharov via lldb-commits
https://github.com/metaflow closed https://github.com/llvm/llvm-project/pull/68979 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][lldb-vscode] Add example configuration for connecting to a remote gdbserver (PR #68866)

2023-10-13 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/68866 >From a7c0c715f8c355e548e27e7c538fb9fccaf0ce89 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Thu, 12 Oct 2023 10:04:52 +0100 Subject: [PATCH 1/2] [lldb][lldb-vscode] Add example configuration for con

[Lldb-commits] [lldb] [lldb][lldb-vscode] Add example configuration for connecting to a remote gdbserver (PR #68866)

2023-10-13 Thread David Spickett via lldb-commits
@@ -212,6 +212,21 @@ This loads the coredump file `/cores/123.core` associated with the program } ``` +### Connect to a Remote Debug Server + +This connects to a debug server (e.g. `lldb-server`, `gdbserver`) that is +debugging the program `/tmp/a.out` and listening locally o

[Lldb-commits] [lldb] [lldb] Add SBType::FindDirectNestedType() function (PR #68705)

2023-10-13 Thread Vlad Serebrennikov via lldb-commits
https://github.com/Endilll edited https://github.com/llvm/llvm-project/pull/68705 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][lldb-vscode] Add example configuration for connecting to a remote gdbserver (PR #68866)

2023-10-13 Thread Walter Erquinigo via lldb-commits
@@ -212,6 +212,38 @@ This loads the coredump file `/cores/123.core` associated with the program } ``` +### Connect to a Debug Server on the Current Machine + +This connects to a debug server (e.g. `lldb-server`, `gdbserver`) on +the current machine, that is debugging the prog

[Lldb-commits] [lldb] [LLDB][NFC] Remove dead code (PR #68927)

2023-10-13 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: I applied this patch downstream (and removed the corresponding overloads in `TypeSystemSwift`) and confirmed the rest of the functions aren't used. LGTM. https://github.com/llvm/llvm-project/pull/68927 ___ lldb-commits mailing lis

[Lldb-commits] [lldb] [LLDB][NFC] Remove dead code (PR #68927)

2023-10-13 Thread Walter Erquinigo via lldb-commits
walter-erquinigo wrote: Thanks, @JDevlieghere ! https://github.com/llvm/llvm-project/pull/68927 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DataFormatter] unordered_map: account for new libc++ __hash_node layout (PR #68574)

2023-10-13 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/68574 >From a421f1883e5b3544ec4b2ceb2bba6fac912c3ffb Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 9 Oct 2023 11:54:56 +0100 Subject: [PATCH 1/2] [lldb][DataFormatter] unordered_map: account for new libc++

[Lldb-commits] [lldb] [LLDB][NFC] Create a namespace for the DWARF plugin (PR #68150)

2023-10-13 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > Should we have a top level "lldb_plugin" namespace instead of > "lldb_private::plugin"? It would be easier to be able to export only a single > plug-in interface if needed if we did this What makes it easier to export `lldb_plugin` than `lldb_private::plugin`? I'm only f

[Lldb-commits] [lldb] [lldb][test] Temporarily disable TestQueueFromStdModule.py (PR #68970)

2023-10-13 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/68970 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DataFormatter] unordered_map: account for new libc++ __hash_node layout (PR #68574)

2023-10-13 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/68574 >From a421f1883e5b3544ec4b2ceb2bba6fac912c3ffb Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 9 Oct 2023 11:54:56 +0100 Subject: [PATCH 1/3] [lldb][DataFormatter] unordered_map: account for new libc++

[Lldb-commits] [lldb] [lldb][dump-debug-info] Fix `image dump separate-debug-info` in Release. (PR #68940)

2023-10-13 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/68940 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DataFormatter] unordered_map: account for new libc++ __hash_node layout (PR #68574)

2023-10-13 Thread Michael Buch via lldb-commits
@@ -162,10 +162,21 @@ lldb::ValueObjectSP lldb_private::formatters:: if (!node_sp || error.Fail()) return nullptr; - value_sp = node_sp->GetChildMemberWithName("__value_"); hash_sp = node_sp->GetChildMemberWithName("__hash_"); - if (!value_sp |

[Lldb-commits] [lldb] [lldb][test] Temporarily disable TestQueueFromStdModule.py (PR #68970)

2023-10-13 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/68970 >From 35a9c6ee8fae2281ac7234e16bb84b7b285ad749 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Fri, 13 Oct 2023 10:46:42 +0100 Subject: [PATCH 1/2] [lldb][test] Temporarily disable TestQueueFromStdModule.py

[Lldb-commits] [lldb] [lldb] Add SBType::FindDirectNestedType() function (PR #68705)

2023-10-13 Thread Jonas Devlieghere via lldb-commits
@@ -720,6 +720,14 @@ SBType supports the eq/ne operator. For example,:: " ) lldb::SBType::GetTypeFlags; +%feature("docstring", +"Searches for a directly nested type that has provided name. JDevlieghere wrote: `s/has provided name/has the provided name

[Lldb-commits] [lldb] [lldb] Add SBType::FindDirectNestedType() function (PR #68705)

2023-10-13 Thread Jonas Devlieghere via lldb-commits
@@ -135,6 +135,12 @@ class TypeSystem : public PluginInterface, virtual lldb::LanguageType DeclContextGetLanguage(void *opaque_decl_ctx) = 0; + // CompilerType functions JDevlieghere wrote: I know you're just being consistent with the surrounding code but

[Lldb-commits] [lldb] [lldb] Add SBType::FindDirectNestedType() function (PR #68705)

2023-10-13 Thread Jonas Devlieghere via lldb-commits
@@ -586,6 +586,15 @@ lldb::TemplateArgumentKind SBType::GetTemplateArgumentKind(uint32_t idx) { return eTemplateArgumentKindNull; } +SBType SBType::FindDirectNestedType(const char *name) { + LLDB_INSTRUMENT_VA(this, name); + + if (!IsValid()) +return SBType(); + auto

[Lldb-commits] [lldb] [lldb] Add SBType::FindDirectNestedType() function (PR #68705)

2023-10-13 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM with some small nits. https://github.com/llvm/llvm-project/pull/68705 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commit

[Lldb-commits] [lldb] [lldb] Add SBType::FindDirectNestedType() function (PR #68705)

2023-10-13 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/68705 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][lldb-vscode] Add example configuration for connecting to a remote gdbserver (PR #68866)

2023-10-13 Thread David Spickett via lldb-commits
@@ -212,6 +212,38 @@ This loads the coredump file `/cores/123.core` associated with the program } ``` +### Connect to a Debug Server on the Current Machine + +This connects to a debug server (e.g. `lldb-server`, `gdbserver`) on +the current machine, that is debugging the prog

[Lldb-commits] [lldb] [lldb][lldb-vscode] Add example configuration for connecting to a remote gdbserver (PR #68866)

2023-10-13 Thread David Spickett via lldb-commits
@@ -212,6 +212,38 @@ This loads the coredump file `/cores/123.core` associated with the program } ``` +### Connect to a Debug Server on the Current Machine + +This connects to a debug server (e.g. `lldb-server`, `gdbserver`) on +the current machine, that is debugging the prog

[Lldb-commits] [lldb] [lldb][lldb-vscode] Add example configuration for connecting to a remote gdbserver (PR #68866)

2023-10-13 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/68866 >From a7c0c715f8c355e548e27e7c538fb9fccaf0ce89 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Thu, 12 Oct 2023 10:04:52 +0100 Subject: [PATCH 1/3] [lldb][lldb-vscode] Add example configuration for con

[Lldb-commits] [lldb] [lldb][lldb-vscode] Add example configuration for connecting to a remote gdbserver (PR #68866)

2023-10-13 Thread David Spickett via lldb-commits
@@ -212,6 +212,38 @@ This loads the coredump file `/cores/123.core` associated with the program } ``` +### Connect to a Debug Server on the Current Machine + +This connects to a debug server (e.g. `lldb-server`, `gdbserver`) on +the current machine, that is debugging the prog

[Lldb-commits] [lldb] [LLDB][NFC] Create a namespace for the DWARF plugin (PR #68150)

2023-10-13 Thread Walter Erquinigo via lldb-commits
walter-erquinigo wrote: A problem that I'm seeing now is that if we move all the plugins to `lldb_private::plugin`, the `liblldb-private.exports` file will by default emit all the lldb symbols (the ones in plugins + the regular lldb_private symbols). This can potentially be too many symbols, a

[Lldb-commits] [lldb] [lldb][DataFormatter] unordered_map: account for new libc++ __hash_node layout (PR #68574)

2023-10-13 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff ba79fb2e1ff7130cde02fbbd325f0f96f8a522ca 819c92f8793a0547293e419be9394559add46564 --

[Lldb-commits] [lldb] [lldb][DataFormatter] unordered_map: account for new libc++ __hash_node layout (PR #68574)

2023-10-13 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/68574 >From a421f1883e5b3544ec4b2ceb2bba6fac912c3ffb Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 9 Oct 2023 11:54:56 +0100 Subject: [PATCH 1/4] [lldb][DataFormatter] unordered_map: account for new libc++

[Lldb-commits] [lldb] 74c5e47 - [lldb][test] Temporarily disable TestQueueFromStdModule.py (#68970)

2023-10-13 Thread via lldb-commits
Author: Michael Buch Date: 2023-10-13T16:26:51+01:00 New Revision: 74c5e474043daa7900686d0a210b8e03cebf9472 URL: https://github.com/llvm/llvm-project/commit/74c5e474043daa7900686d0a210b8e03cebf9472 DIFF: https://github.com/llvm/llvm-project/commit/74c5e474043daa7900686d0a210b8e03cebf9472.diff

[Lldb-commits] [lldb] [lldb][test] Temporarily disable TestQueueFromStdModule.py (PR #68970)

2023-10-13 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/68970 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][NFC] Create a namespace for the DWARF plugin (PR #68150)

2023-10-13 Thread Walter Erquinigo via lldb-commits
walter-erquinigo wrote: > That expectations, combined with the fact that LLDB has plugins, makes it > really sound like lldb_plugin is the interface we expose for writing > (dynamically loadable) plugins. I don't think people would have the expectation that you need to use `lldb_plugin` for

[Lldb-commits] [lldb] [lldb][DataFormatter] VectorType: fix format for arrays with size not a power-of-2 (PR #68907)

2023-10-13 Thread Adrian Prantl via lldb-commits
@@ -169,21 +169,49 @@ static lldb::Format GetItemFormatForFormat(lldb::Format format, } } -static size_t CalculateNumChildren( -CompilerType container_type, CompilerType element_type, -lldb_private::ExecutionContextScope *exe_scope = -nullptr // does not mat

[Lldb-commits] [lldb] [lldb][DataFormatter] VectorType: fix format for arrays with size not a power-of-2 (PR #68907)

2023-10-13 Thread Adrian Prantl via lldb-commits
@@ -169,21 +169,49 @@ static lldb::Format GetItemFormatForFormat(lldb::Format format, } } -static size_t CalculateNumChildren( -CompilerType container_type, CompilerType element_type, -lldb_private::ExecutionContextScope *exe_scope = -nullptr // does not mat

[Lldb-commits] [lldb] [lldb][DataFormatter] VectorType: fix format for arrays with size not a power-of-2 (PR #68907)

2023-10-13 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/68907 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix `po` alias by printing fix-its to the console. (PR #68755)

2023-10-13 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: I'm testing this locally now and will then merge https://github.com/llvm/llvm-project/pull/68755 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][NFC] Create a namespace for the DWARF plugin (PR #68150)

2023-10-13 Thread via lldb-commits
jimingham wrote: I think I'm missing something. The API's you are calling the lldb_plugin API's aren't really stand-alone, are they? The lldb_plugin::dwarf API's seem to have a bunch of methods that take lldb_private types. So you already have to have some kind of closure of the exported AP

[Lldb-commits] [lldb] [libc++] Use -nostdlib++ on GCC unconditionally (PR #68832)

2023-10-13 Thread Martin Storsjö via lldb-commits
@@ -642,18 +642,8 @@ get_sanitizer_flags(SANITIZER_FLAGS "${LLVM_USE_SANITIZER}") # Link system libraries === function(cxx_link_system_libraries target) - -# In order to remove just libc++ from the link step -# we need to us

[Lldb-commits] [lldb] [LLDB][NFC] Create a namespace for the DWARF plugin (PR #68150)

2023-10-13 Thread Walter Erquinigo via lldb-commits
walter-erquinigo wrote: > I think I'm missing something. The API's you are calling the lldb_plugin > API's aren't really stand-alone, are they? The lldb_plugin::dwarf API's seem > to have a bunch of methods that take lldb_private types. So you already have > to have some kind of closure of

[Lldb-commits] [lldb] [Clang] Add __builtin_vectorelements to get number of elements in vector (PR #69010)

2023-10-13 Thread Lawrence Benson via lldb-commits
https://github.com/lawben updated https://github.com/llvm/llvm-project/pull/69010 >From df8d0a53a31e1351bb6cd3b340e9012b489e9885 Mon Sep 17 00:00:00 2001 From: Lawrence Benson Date: Wed, 11 Oct 2023 17:26:11 +0200 Subject: [PATCH 1/5] Add __builtin_vectorelements to get the number of elements

[Lldb-commits] [lldb] [lldb][dump-debug-info] Fix `image dump separate-debug-info` in Release. (PR #68940)

2023-10-13 Thread Tom Yang via lldb-commits
https://github.com/zhyty closed https://github.com/llvm/llvm-project/pull/68940 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][dump-debug-info] Fix `image dump separate-debug-info` in Release. (PR #68940)

2023-10-13 Thread Tom Yang via lldb-commits
zhyty wrote: #68979 was committed before this, basically does the same thing. https://github.com/llvm/llvm-project/pull/68940 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [Clang] Add __builtin_vectorelements to get number of elements in vector (PR #69010)

2023-10-13 Thread Erich Keane via lldb-commits
@@ -3083,6 +3083,19 @@ ScalarExprEmitter::VisitUnaryExprOrTypeTraitExpr( E->getTypeOfArgument()->getPointeeType())) .getQuantity(); return llvm::ConstantInt::get(CGF.SizeTy, Alignment); + } else if (E->getKind() == UETT_VectorElements) { +//

[Lldb-commits] [lldb] [LLDB][NFC] Remove dead code (PR #68927)

2023-10-13 Thread Walter Erquinigo via lldb-commits
walter-erquinigo wrote: @clayborg PTAL https://github.com/llvm/llvm-project/pull/68927 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [Clang] Add __builtin_vectorelements to get number of elements in vector (PR #69010)

2023-10-13 Thread Erich Keane via lldb-commits
@@ -13595,6 +13595,15 @@ bool IntExprEvaluator::VisitUnaryExprOrTypeTraitExpr( Info.Ctx.getOpenMPDefaultSimdAlign(E->getArgumentType())) .getQuantity(), E); + case UETT_VectorElements: { +QualType Ty = E->getTypeOfArgument(); +//

[Lldb-commits] [lldb] [Clang] Add __builtin_vectorelements to get number of elements in vector (PR #69010)

2023-10-13 Thread Erich Keane via lldb-commits
@@ -10136,6 +10136,9 @@ def err_vec_builtin_incompatible_vector : Error< def err_vsx_builtin_nonconstant_argument : Error< "argument %0 to %1 must be a 2-bit unsigned literal (i.e. 0, 1, 2 or 3)">; +def err_vectorelements_non_vector : Error< + "'__builtin_vectorelements' arg

[Lldb-commits] [lldb] [Clang] Add __builtin_vectorelements to get number of elements in vector (PR #69010)

2023-10-13 Thread Erich Keane via lldb-commits
@@ -0,0 +1,121 @@ +// RUN: %clang_cc1 -O1 -triple aarch64 -target-feature +neon %s -emit-llvm -o - | FileCheck --check-prefixes=CHECK,NEON %s erichkeane wrote: Add -disable-llvm-passes to all of these. https://github.com/llvm/llvm-project/pull/69010 ___

[Lldb-commits] [lldb] [Clang] Add __builtin_vectorelements to get number of elements in vector (PR #69010)

2023-10-13 Thread Erich Keane via lldb-commits
@@ -5456,9 +5459,8 @@ class DeducedTemplateSpecializationType : public DeducedType, /// TemplateArguments, followed by a QualType representing the /// non-canonical aliased type when the template is a type alias /// template. -class alignas(8) TemplateSpecializationType -:

[Lldb-commits] [lldb] [lldb] Fix `po` alias by printing fix-its to the console. (PR #68755)

2023-10-13 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl closed https://github.com/llvm/llvm-project/pull/68755 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 8e2bd05 - [lldb] Fix `po` alias by printing fix-its to the console. (#68755)

2023-10-13 Thread via lldb-commits
Author: Pete Lawrence Date: 2023-10-13T10:06:50-07:00 New Revision: 8e2bd05c4e86834a318ef2279e271f0769be4988 URL: https://github.com/llvm/llvm-project/commit/8e2bd05c4e86834a318ef2279e271f0769be4988 DIFF: https://github.com/llvm/llvm-project/commit/8e2bd05c4e86834a318ef2279e271f0769be4988.diff

[Lldb-commits] [lldb] [LLDB][NFC] Create a namespace for the DWARF plugin (PR #68150)

2023-10-13 Thread via lldb-commits
jimingham wrote: `lldb_private::plugin::dwarf` is fine by me. https://github.com/llvm/llvm-project/pull/68150 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Reland "[mlir][arith] Canonicalization patterns for `arith.select` (#67809)" (PR #68941)

2023-10-13 Thread Han-Chung Wang via lldb-commits
https://github.com/hanhanW updated https://github.com/llvm/llvm-project/pull/68941 >From 877111a139b2f01037fdbe7c0cb120a2f4e64562 Mon Sep 17 00:00:00 2001 From: hanhanW Date: Thu, 12 Oct 2023 17:14:29 -0700 Subject: [PATCH 1/2] Reland "[mlir][arith] Canonicalization patterns for `arith.select`

[Lldb-commits] [lldb] [lldb] Add SBType::FindDirectNestedType() function (PR #68705)

2023-10-13 Thread Vlad Serebrennikov via lldb-commits
https://github.com/Endilll updated https://github.com/llvm/llvm-project/pull/68705 >From ca4d1bbdeb4ea541199e3db3518b35eb2d5a8cad Mon Sep 17 00:00:00 2001 From: Vlad Serebrennikov Date: Tue, 10 Oct 2023 15:07:56 +0300 Subject: [PATCH 01/15] [lldb] Add SBType::FindNestedType() function --- lld

[Lldb-commits] [lldb] Reland "[mlir][arith] Canonicalization patterns for `arith.select` (#67809)" (PR #68941)

2023-10-13 Thread Han-Chung Wang via lldb-commits
@@ -233,6 +233,52 @@ def CmpIExtUI : CPred<"$0.getValue() == arith::CmpIPredicate::eq || " "$0.getValue() == arith::CmpIPredicate::ne">> $pred)]>; +//===--===// +// SelectOp +//==

[Lldb-commits] [lldb] [lldb] Add SBType::FindDirectNestedType() function (PR #68705)

2023-10-13 Thread Vlad Serebrennikov via lldb-commits
@@ -586,6 +586,15 @@ lldb::TemplateArgumentKind SBType::GetTemplateArgumentKind(uint32_t idx) { return eTemplateArgumentKindNull; } +SBType SBType::FindDirectNestedType(const char *name) { + LLDB_INSTRUMENT_VA(this, name); + + if (!IsValid()) +return SBType(); + auto

[Lldb-commits] [lldb] [lldb] Add SBType::FindDirectNestedType() function (PR #68705)

2023-10-13 Thread Vlad Serebrennikov via lldb-commits
@@ -720,6 +720,14 @@ SBType supports the eq/ne operator. For example,:: " ) lldb::SBType::GetTypeFlags; +%feature("docstring", +"Searches for a directly nested type that has provided name. Endilll wrote: Done https://github.com/llvm/llvm-project/pull

[Lldb-commits] [lldb] Reland "[mlir][arith] Canonicalization patterns for `arith.select` (#67809)" (PR #68941)

2023-10-13 Thread Han-Chung Wang via lldb-commits
https://github.com/hanhanW edited https://github.com/llvm/llvm-project/pull/68941 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Fix type formatting empty c-strings (PR #68924)

2023-10-13 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. I'm alright with this, though I'm a little concerned that the return value of `ReadCStringFromMemory` and `error.Success()` don't give you the same result. I'm also somewhat sad that we have to check **both** of those to know if we succ

[Lldb-commits] [lldb] [LLDB][NFC] Remove dead code (PR #68927)

2023-10-13 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. Thanks for taking the time to clean this up, and thanks for taking the time to make sure this wouldn't hurt us downstream with swift! https://github.com/llvm/llvm-project/pull/68927 ___ lldb-c

[Lldb-commits] [lldb] [LLDB] Fix type formatting empty c-strings (PR #68924)

2023-10-13 Thread Walter Erquinigo via lldb-commits
walter-erquinigo wrote: @bulbazord , ReadCStringFromMemory returns the length of the string, which in the case of empty strings is 0! So, this code was wrong since the beginning. The only thing to check is error.Success() and not the size. https://github.com/llvm/llvm-project/pull/68924 _

[Lldb-commits] [lldb] [LLDB][NFC] Remove dead code (PR #68927)

2023-10-13 Thread Walter Erquinigo via lldb-commits
walter-erquinigo wrote: @bulbazord , thanks!! I'll try to improve the type system and other parts of the LLDB as I add support for my language. https://github.com/llvm/llvm-project/pull/68927 ___ lldb-commits mailing list lldb-commits@lists.llvm.org h

[Lldb-commits] [lldb] 158c052 - [LLDB][NFC] Remove dead code (#68927)

2023-10-13 Thread via lldb-commits
Author: Walter Erquinigo Date: 2023-10-13T13:54:03-04:00 New Revision: 158c0529901ec683a41bafafeb7f14de74999517 URL: https://github.com/llvm/llvm-project/commit/158c0529901ec683a41bafafeb7f14de74999517 DIFF: https://github.com/llvm/llvm-project/commit/158c0529901ec683a41bafafeb7f14de74999517.di

[Lldb-commits] [lldb] [LLDB][NFC] Remove dead code (PR #68927)

2023-10-13 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo closed https://github.com/llvm/llvm-project/pull/68927 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [libc++] Move the check-generated-files job to Github Actions (PR #68920)

2023-10-13 Thread Louis Dionne via lldb-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/68920 >From d1c371b9783777d90647b5d93b16266fe053287f Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Thu, 12 Oct 2023 10:29:40 -0700 Subject: [PATCH 1/4] [libc++] Move the check-generated-files job to Github Actions

[Lldb-commits] [lldb] [libc++] Use -nostdlib++ on GCC unconditionally (PR #68832)

2023-10-13 Thread Louis Dionne via lldb-commits
@@ -642,18 +642,8 @@ get_sanitizer_flags(SANITIZER_FLAGS "${LLVM_USE_SANITIZER}") # Link system libraries === function(cxx_link_system_libraries target) - -# In order to remove just libc++ from the link step -# we need to us

[Lldb-commits] [lldb] [libc++] Use -nostdlib++ on GCC unconditionally (PR #68832)

2023-10-13 Thread via lldb-commits
https://github.com/EricWF approved this pull request. It's nice having CI for all the platforms, otherwise this would be harder to review and be confident about. LGTM assuming everything passes. https://github.com/llvm/llvm-project/pull/68832 ___ lld

[Lldb-commits] [lldb] [libc++] Use -nostdlib++ on GCC unconditionally (PR #68832)

2023-10-13 Thread via lldb-commits
https://github.com/EricWF edited https://github.com/llvm/llvm-project/pull/68832 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [libc++] Use -nostdlib++ on GCC unconditionally (PR #68832)

2023-10-13 Thread via lldb-commits
@@ -108,22 +97,18 @@ if(WIN32 AND NOT MINGW) # TODO(compnerd) do we want to support an emulation layer that allows for the # use of pthread-win32 or similar libraries to emulate pthreads on Windows? set(LIBCXX_HAS_PTHREAD_LIB NO) - set(LIBCXX_HAS_M_LIB NO) set(LIBCXX_

[Lldb-commits] [lldb] ed0a141 - [LLDB] Fix type formatting empty c-strings (#68924)

2023-10-13 Thread via lldb-commits
Author: Walter Erquinigo Date: 2023-10-13T14:14:23-04:00 New Revision: ed0a14144ba980ceb29e86c9ca615b785e667dcf URL: https://github.com/llvm/llvm-project/commit/ed0a14144ba980ceb29e86c9ca615b785e667dcf DIFF: https://github.com/llvm/llvm-project/commit/ed0a14144ba980ceb29e86c9ca615b785e667dcf.di

[Lldb-commits] [lldb] [LLDB] Fix type formatting empty c-strings (PR #68924)

2023-10-13 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo closed https://github.com/llvm/llvm-project/pull/68924 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DataFormatter] VectorType: fix format for arrays with size not a power-of-2 (PR #68907)

2023-10-13 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/68907 >From 769cbd0a30f0903ff4b7263b7789fb28c49de1d6 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Thu, 12 Oct 2023 16:25:39 +0100 Subject: [PATCH 1/4] [lldb][DataFormatter][NFC] VectorType: remove redundant pa

[Lldb-commits] [lldb] [lldb][DataFormatter] VectorType: fix format for arrays with size not a power-of-2 (PR #68907)

2023-10-13 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/68907 >From 769cbd0a30f0903ff4b7263b7789fb28c49de1d6 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Thu, 12 Oct 2023 16:25:39 +0100 Subject: [PATCH 1/5] [lldb][DataFormatter][NFC] VectorType: remove redundant pa

[Lldb-commits] [lldb] [lldb][DataFormatter] VectorType: fix format for arrays with size not a power-of-2 (PR #68907)

2023-10-13 Thread Michael Buch via lldb-commits
@@ -169,21 +169,49 @@ static lldb::Format GetItemFormatForFormat(lldb::Format format, } } -static size_t CalculateNumChildren( -CompilerType container_type, CompilerType element_type, -lldb_private::ExecutionContextScope *exe_scope = -nullptr // does not mat

[Lldb-commits] [lldb] [lldb][DataFormatter] VectorType: fix format for arrays with size not a power-of-2 (PR #68907)

2023-10-13 Thread Michael Buch via lldb-commits
@@ -169,21 +169,49 @@ static lldb::Format GetItemFormatForFormat(lldb::Format format, } } -static size_t CalculateNumChildren( -CompilerType container_type, CompilerType element_type, -lldb_private::ExecutionContextScope *exe_scope = -nullptr // does not mat

[Lldb-commits] [lldb] Reland "[mlir][arith] Canonicalization patterns for `arith.select` (#67809)" (PR #68941)

2023-10-13 Thread via lldb-commits
https://github.com/peterbell10 approved this pull request. https://github.com/llvm/llvm-project/pull/68941 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DataFormatter] VectorType: fix format for arrays with size not a power-of-2 (PR #68907)

2023-10-13 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff b98b567c2501540ef4a9d586c26ab8271c6d1f0d d0d6425021e1666b92b1c96accebf9edf1d217b6 --

[Lldb-commits] [lldb] Reland "[mlir][arith] Canonicalization patterns for `arith.select` (#67809)" (PR #68941)

2023-10-13 Thread Markus Böck via lldb-commits
https://github.com/zero9178 approved this pull request. https://github.com/llvm/llvm-project/pull/68941 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

  1   2   >