[Lldb-commits] [lldb] [Clang] Fix crash when ill-formed code is treated as a deduction guide (PR #67373)

2023-10-02 Thread Mariya Podchishchaeva via lldb-commits
https://github.com/Fznamznon approved this pull request. https://github.com/llvm/llvm-project/pull/67373 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [OpenMPIRBuilder] Remove wrapper function in `createTask` (PR #67723)

2023-10-02 Thread via lldb-commits
https://github.com/shraiysh updated https://github.com/llvm/llvm-project/pull/67723 >From 6aabc3c10ea2d587120b74966b7ce96f9b8167af Mon Sep 17 00:00:00 2001 From: Shraiysh Vaishay Date: Thu, 28 Sep 2023 13:35:07 -0500 Subject: [PATCH 1/2] [OpenMPIRBuilder] Remove wrapper function in `createTask`

[Lldb-commits] [lldb] [OpenMPIRBuilder] Remove wrapper function in `createTask` (PR #67723)

2023-10-02 Thread via lldb-commits
https://github.com/shraiysh updated https://github.com/llvm/llvm-project/pull/67723 >From 6aabc3c10ea2d587120b74966b7ce96f9b8167af Mon Sep 17 00:00:00 2001 From: Shraiysh Vaishay Date: Thu, 28 Sep 2023 13:35:07 -0500 Subject: [PATCH 1/2] [OpenMPIRBuilder] Remove wrapper function in `createTask`

[Lldb-commits] [lldb] [OpenMPIRBuilder] Remove wrapper function in `createTask` (PR #67723)

2023-10-02 Thread via lldb-commits
https://github.com/shraiysh updated https://github.com/llvm/llvm-project/pull/67723 >From 6aabc3c10ea2d587120b74966b7ce96f9b8167af Mon Sep 17 00:00:00 2001 From: Shraiysh Vaishay Date: Thu, 28 Sep 2023 13:35:07 -0500 Subject: [PATCH 1/3] [OpenMPIRBuilder] Remove wrapper function in `createTask`

[Lldb-commits] [lldb] [OpenMPIRBuilder] Remove wrapper function in `createTask` (PR #67723)

2023-10-02 Thread via lldb-commits
https://github.com/shraiysh edited https://github.com/llvm/llvm-project/pull/67723 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [OpenMPIRBuilder] Remove wrapper function in `createTask`, `createTeams` (PR #67723)

2023-10-02 Thread via lldb-commits
https://github.com/shraiysh updated https://github.com/llvm/llvm-project/pull/67723 >From 6aabc3c10ea2d587120b74966b7ce96f9b8167af Mon Sep 17 00:00:00 2001 From: Shraiysh Vaishay Date: Thu, 28 Sep 2023 13:35:07 -0500 Subject: [PATCH 1/4] [OpenMPIRBuilder] Remove wrapper function in `createTask`

[Lldb-commits] [lldb] [mlir][sparse] Update Enum name for CompressedWithHigh (PR #67845)

2023-10-02 Thread Yinying Li via lldb-commits
https://github.com/yinying-lisa-li closed https://github.com/llvm/llvm-project/pull/67845 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [Clang] Fix crash when ill-formed code is treated as a deduction guide (PR #67373)

2023-10-02 Thread Shafik Yaghmour via lldb-commits
https://github.com/shafik closed https://github.com/llvm/llvm-project/pull/67373 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Export DWARF Parser symbols for external language plugins (PR #67851)

2023-10-02 Thread via lldb-commits
jimingham wrote: So first off, the lldb_private API is not a stable API and will likely never be. After all, it vends lots of llvm ADT types and other llvm & clang API's which are also not stable API's... So anything which tends to making these API's seem like we're vending them as such, or

[Lldb-commits] [lldb] [LLDB] Export DWARF Parser symbols for external language plugins (PR #67851)

2023-10-02 Thread Walter Erquinigo via lldb-commits
walter-erquinigo wrote: @jimingham , indeed, I don't want to have a plugin that could be loadable by any build of lldb. The Mojo SDK is distributing already its own build of vanilla lldb along with the mojo plugin that is loaded at runtime and that links correctly with that lldb. I initially t

[Lldb-commits] [lldb] [libc++] Implement ranges::contains_subrange (PR #66963)

2023-10-02 Thread Shafik Yaghmour via lldb-commits
shafik wrote: Please make sure you add a description to your PR. This is what usually goes into the git log and we want those entries to be as descriptive and helpful for folks who read the git logs, thank you. https://github.com/llvm/llvm-project/pull/66963 ___

[Lldb-commits] [lldb] [lldb] Replace lldb's DWARFDebugAbbrev implementation with llvm's (PR #67841)

2023-10-02 Thread Alex Langford via lldb-commits
https://github.com/bulbazord closed https://github.com/llvm/llvm-project/pull/67841 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] cdd3e96 - [lldb] Replace lldb's DWARFDebugAbbrev implementation with llvm's (#67841)

2023-10-02 Thread via lldb-commits
Author: Alex Langford Date: 2023-10-02T10:46:16-07:00 New Revision: cdd3e964f229aac5366433a549466d18ed696660 URL: https://github.com/llvm/llvm-project/commit/cdd3e964f229aac5366433a549466d18ed696660 DIFF: https://github.com/llvm/llvm-project/commit/cdd3e964f229aac5366433a549466d18ed696660.diff

[Lldb-commits] [lldb] [LLDB] Export DWARF Parser symbols for external language plugins (PR #67851)

2023-10-02 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo closed https://github.com/llvm/llvm-project/pull/67851 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Implement data formatters for LibStdC++ std::variant (PR #68012)

2023-10-02 Thread via lldb-commits
https://github.com/jeffreytan81 created https://github.com/llvm/llvm-project/pull/68012 This patch implements the data formatters for LibStdC++ `std::variant`. >From e7e47a211ebaaa0f6380810b6573fadde12ca02d Mon Sep 17 00:00:00 2001 From: jeffreytan81 Date: Mon, 2 Oct 2023 10:53:17 -0700 Subjec

[Lldb-commits] [lldb] [LLDB] Allow specifying a custom exports file (PR #68013)

2023-10-02 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo created https://github.com/llvm/llvm-project/pull/68013 LLDB has the cmake flag `LLDB_EXPORT_ALL_SYMBOLS` that exports the lldb, lldb_private namespaces, as well as other symbols like python and lua (see `third-party/llvm-project/lldb/source/API/liblldb-priv

[Lldb-commits] [lldb] [LLDB] Allow specifying a custom exports file (PR #68013)

2023-10-02 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo ready_for_review https://github.com/llvm/llvm-project/pull/68013 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Allow specifying a custom exports file (PR #68013)

2023-10-02 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Changes LLDB has the cmake flag `LLDB_EXPORT_ALL_SYMBOLS` that exports the lldb, lldb_private namespaces, as well as other symbols like python and lua (see `third-party/llvm-project/lldb/source/API/liblldb-private.exports`). However, not all symbo

[Lldb-commits] [lldb] Implement data formatters for LibStdC++ std::variant (PR #68012)

2023-10-02 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 2db8540a71ef546087158fcbf38e3b1883c5df48..e7e47a211ebaaa0f6380810b6573fadde12ca02d lldb/

[Lldb-commits] [lldb] Implement data formatters for LibStdC++ std::variant (PR #68012)

2023-10-02 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 2db8540a71ef546087158fcbf38e3b1883c5df48 e7e47a211ebaaa0f6380810b6573fadde12ca02d --

[Lldb-commits] [lldb] [lldb] add stop-at-user-entry option to process launch (PR #67019)

2023-10-02 Thread José Lira Junior via lldb-commits
junior-jl wrote: > You can use `lldb/test/Shell/Commands/command-thread-select.test` as an > example to write your own test. Using this file as a template, I wrote `command-process-launch-user-entry.test` as shown below: ``` # RUN: %clang_host -g %S/Inputs/main.c -o %t # RUN: %lldb %t -s %s -

[Lldb-commits] [lldb] [lldb] add stop-at-user-entry option to process launch (PR #67019)

2023-10-02 Thread Med Ismail Bennani via lldb-commits
=?utf-8?q?José?= L. Junior Message-ID: In-Reply-To: medismailben wrote: > > You can use `lldb/test/Shell/Commands/command-thread-select.test` as an > > example to write your own test. > > Using this file as a template, I wrote > `command-process-launch-user-entry.test` as shown below: > >

[Lldb-commits] [lldb] Improve omp offload profiler (PR #68016)

2023-10-02 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 0b07b06effe5fdf779b75bb5ac6cf15e477cb0be 7c550d3190614d7572bc2d63051d7ce56c8f73b6 --

[Lldb-commits] [lldb] Improve omp offload profiler (PR #68016)

2023-10-02 Thread via lldb-commits
https://github.com/fel-cab updated https://github.com/llvm/llvm-project/pull/68016 >From dd44de067c26ba94b6561c5ed7fa4a5d812a3d1a Mon Sep 17 00:00:00 2001 From: Felipe Cabarcas Date: Mon, 18 Sep 2023 12:07:12 + Subject: [PATCH 1/9] testing Profiler features --- openmp/libomptarget/src/int

[Lldb-commits] [lldb] [ELF] Handle relocations in synthetic .eh_frame with a non-zero offset within the output section (PR #65966)

2023-10-02 Thread via lldb-commits
https://github.com/simpal01 updated https://github.com/llvm/llvm-project/pull/65966 >From 43c156c679951cc3d827fdb7604e30aab658fd9a Mon Sep 17 00:00:00 2001 From: Simi Pallipurath Date: Mon, 11 Sep 2023 14:42:27 +0100 Subject: [PATCH 1/3] [LLD][AARCH64] lld incorrectly handles .eh_frame when it

[Lldb-commits] [lldb] [lldb] add stop-at-user-entry option to process launch (PR #67019)

2023-10-02 Thread José Lira Junior via lldb-commits
https://github.com/junior-jl updated https://github.com/llvm/llvm-project/pull/67019 From c2396253b9584af9eabe1e67ed922f5f5f0e879c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jos=C3=A9=20L=2E=20Junior?= Date: Thu, 21 Sep 2023 11:12:58 -0300 Subject: [PATCH 1/3] [lldb] add stop-at-user-entry option

[Lldb-commits] [lldb] [lldb] add stop-at-user-entry option to process launch (PR #67019)

2023-10-02 Thread José Lira Junior via lldb-commits
junior-jl wrote: > Could you file a new issue describing this behavior and pasting the link here. Done! https://github.com/llvm/llvm-project/issues/68035 > Your test looks fine to me, so we can move on with it to merge your PR. I'll > update it after we fix that other bug. Great. Added the te

[Lldb-commits] [lldb] Implement data formatters for LibStdC++ std::variant (PR #68012)

2023-10-02 Thread via lldb-commits
https://github.com/jeffreytan81 updated https://github.com/llvm/llvm-project/pull/68012 >From e7e47a211ebaaa0f6380810b6573fadde12ca02d Mon Sep 17 00:00:00 2001 From: jeffreytan81 Date: Mon, 2 Oct 2023 10:53:17 -0700 Subject: [PATCH 1/2] Implement data formatters for LibStdC++ std::variant ---

[Lldb-commits] [lldb] Implement data formatters for LibStdC++ std::variant (PR #68012)

2023-10-02 Thread via lldb-commits
https://github.com/jeffreytan81 ready_for_review https://github.com/llvm/llvm-project/pull/68012 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Implement data formatters for LibStdC++ std::variant (PR #68012)

2023-10-02 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Changes This patch implements the data formatters for LibStdC++ `std::variant`. --- Full diff: https://github.com/llvm/llvm-project/pull/68012.diff 5 Files Affected: - (modified) lldb/examples/synthetic/gnu_libstdcpp.py (+84) - (modified) lldb/s

[Lldb-commits] [lldb] Implement data formatters for LibStdC++ std::variant (PR #68012)

2023-10-02 Thread via lldb-commits
https://github.com/jeffreytan81 updated https://github.com/llvm/llvm-project/pull/68012 >From e7e47a211ebaaa0f6380810b6573fadde12ca02d Mon Sep 17 00:00:00 2001 From: jeffreytan81 Date: Mon, 2 Oct 2023 10:53:17 -0700 Subject: [PATCH 1/3] Implement data formatters for LibStdC++ std::variant ---

[Lldb-commits] [lldb] [libc++] Implement ranges::contains (PR #65148)

2023-10-02 Thread Konstantin Varlamov via lldb-commits
@@ -0,0 +1,252 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [libc++] Implement ranges::contains (PR #65148)

2023-10-02 Thread Konstantin Varlamov via lldb-commits
@@ -0,0 +1,252 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [libc++] Implement ranges::contains (PR #65148)

2023-10-02 Thread Konstantin Varlamov via lldb-commits
@@ -0,0 +1,252 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [libc++] Implement ranges::contains (PR #65148)

2023-10-02 Thread Konstantin Varlamov via lldb-commits
@@ -0,0 +1,252 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [libc++] Implement ranges::contains (PR #65148)

2023-10-02 Thread Konstantin Varlamov via lldb-commits
https://github.com/var-const unassigned https://github.com/llvm/llvm-project/pull/65148 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [mlir][OpenMP] Added translation for `omp.teams` to LLVM IR (PR #68042)

2023-10-02 Thread via lldb-commits
https://github.com/shraiysh created https://github.com/llvm/llvm-project/pull/68042 This patch adds translation from `omp.teams` operation to LLVM IR using OpenMPIRBuilder. The clauses are not handled in this patch. >From c7c9e907d897ae667331761d8097ccb7852c5d93 Mon Sep 17 00:00:00 2001 From:

[Lldb-commits] [lldb] [mlir][OpenMP] Added translation for `omp.teams` to LLVM IR (PR #68042)

2023-10-02 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-flang-openmp Changes This patch adds translation from `omp.teams` operation to LLVM IR using OpenMPIRBuilder. The clauses are not handled in this patch. --- Full diff: https://github.com/llvm/llvm-project/pull/68042.diff 2 Files Affected: - (modified

[Lldb-commits] [lldb] [mlir][OpenMP] Added translation for `omp.teams` to LLVM IR (PR #68042)

2023-10-02 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 457f582ffe23e951380bc345c4c96ec053c09681 dc0304897ba3f8731bb6062f357fe885ca7e584b --

[Lldb-commits] [lldb] [lldb] add stop-at-user-entry option to process launch (PR #67019)

2023-10-02 Thread Med Ismail Bennani via lldb-commits
=?utf-8?q?Jos=C3=A9?= L. Junior , =?utf-8?q?Jos=C3=A9?= L. Junior Message-ID: In-Reply-To: medismailben wrote: @clayborg what do you think ? Can we merge this ? https://github.com/llvm/llvm-project/pull/67019 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [lldb] [libc++] Implement ranges::contains (PR #65148)

2023-10-02 Thread Konstantin Varlamov via lldb-commits
@@ -0,0 +1,190 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] Implement data formatters for LibStdC++ std::variant (PR #68012)

2023-10-02 Thread Med Ismail Bennani via lldb-commits
medismailben wrote: LGTM with some comments. https://github.com/llvm/llvm-project/pull/68012 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Implement data formatters for LibStdC++ std::variant (PR #68012)

2023-10-02 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben approved this pull request. https://github.com/llvm/llvm-project/pull/68012 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Implement data formatters for LibStdC++ std::variant (PR #68012)

2023-10-02 Thread Med Ismail Bennani via lldb-commits
@@ -0,0 +1,72 @@ +""" +Test lldb data formatter for LibStdC++ std::variant. +""" + + +import lldb +from lldbsuite.test.decorators import * +from lldbsuite.test.lldbtest import * +from lldbsuite.test import lldbutil + +USE_LIBSTDCPP = "USE_LIBSTDCPP" + + +class LibStdcxxVariantData

[Lldb-commits] [lldb] Implement data formatters for LibStdC++ std::variant (PR #68012)

2023-10-02 Thread Med Ismail Bennani via lldb-commits
@@ -0,0 +1,72 @@ +""" +Test lldb data formatter for LibStdC++ std::variant. +""" + + +import lldb +from lldbsuite.test.decorators import * +from lldbsuite.test.lldbtest import * +from lldbsuite.test import lldbutil + +USE_LIBSTDCPP = "USE_LIBSTDCPP" + + +class LibStdcxxVariantData

[Lldb-commits] [lldb] Implement data formatters for LibStdC++ std::variant (PR #68012)

2023-10-02 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben edited https://github.com/llvm/llvm-project/pull/68012 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][FreeBSD] Add dynamic loader handle class for FreeBSD Kernel (PR #67106)

2023-10-02 Thread Ed Maste via lldb-commits
emaste wrote: Hmm, when I attempt to close it via the GitHub UI I get: ![image](https://github.com/llvm/llvm-project/assets/1034582/54534c5d-9873-40c4-81af-45c50919dc92) I think I can just fetch the commit locally and then push it to the tree https://github.com/llvm/llvm-project/pull/67106

[Lldb-commits] [lldb] [lldb] Expose Platform::Attach through the SB API (PR #68050)

2023-10-02 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/68050 Expose Platform::Attach through the SB API. rdar://116188959 >From 6cf631f5acf3eb18e7cf12a2b996c9f974a360e2 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Sun, 1 Oct 2023 20:48:50 -0700 Subject: [P

[Lldb-commits] [lldb] [lldb] Expose Platform::Attach through the SB API (PR #68050)

2023-10-02 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Changes Expose Platform::Attach through the SB API. rdar://116188959 --- Full diff: https://github.com/llvm/llvm-project/pull/68050.diff 7 Files Affected: - (modified) lldb/include/lldb/API/SBAttachInfo.h (+1) - (modified) lldb/include/lldb/API

[Lldb-commits] [lldb] [lldb] Unifying Scripted Affordance Interfaces (wip) (PR #68052)

2023-10-02 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben edited https://github.com/llvm/llvm-project/pull/68052 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/test] Update TestProgressReporting.py (NFC) (PR #68053)

2023-10-02 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben created https://github.com/llvm/llvm-project/pull/68053 None >From fddfbe53a9ab5c27da24b233cc449d0fe102a4b1 Mon Sep 17 00:00:00 2001 From: Med Ismail Bennani Date: Mon, 2 Oct 2023 16:54:45 -0700 Subject: [PATCH] [lldb/test] Update TestProgressReporting.py (NFC)

[Lldb-commits] [lldb] [lldb] Expose Platform::Attach through the SB API (PR #68050)

2023-10-02 Thread Alex Langford via lldb-commits
https://github.com/bulbazord edited https://github.com/llvm/llvm-project/pull/68050 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Expose Platform::Attach through the SB API (PR #68050)

2023-10-02 Thread Alex Langford via lldb-commits
@@ -19,6 +20,7 @@ struct PlatformShellCommand; namespace lldb { class SBLaunchInfo; +class SBAttachInfo; bulbazord wrote: sort https://github.com/llvm/llvm-project/pull/68050 ___ lldb-commits mailing list lldb-comm

[Lldb-commits] [lldb] [lldb] Expose Platform::Attach through the SB API (PR #68050)

2023-10-02 Thread Alex Langford via lldb-commits
@@ -574,6 +576,29 @@ SBError SBPlatform::Launch(SBLaunchInfo &launch_info) { }); } +SBProcess SBPlatform::Attach(SBAttachInfo &attach_info, + const SBDebugger &debugger, SBTarget &target, + SBError &error) { + LLDB_INS

[Lldb-commits] [lldb] [lldb] Expose Platform::Attach through the SB API (PR #68050)

2023-10-02 Thread Alex Langford via lldb-commits
@@ -574,6 +576,29 @@ SBError SBPlatform::Launch(SBLaunchInfo &launch_info) { }); } +SBProcess SBPlatform::Attach(SBAttachInfo &attach_info, + const SBDebugger &debugger, SBTarget &target, bulbazord wrote: I'd like to see the `att

[Lldb-commits] [lldb] [lldb] Expose Platform::Attach through the SB API (PR #68050)

2023-10-02 Thread Alex Langford via lldb-commits
https://github.com/bulbazord commented: Looks fine to me, but I want to really make sure we get this interface right. Left some comments inline. https://github.com/llvm/llvm-project/pull/68050 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] [lldb] Expose Platform::Attach through the SB API (PR #68050)

2023-10-02 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/68050 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Unifying Scripted Affordance Interfaces (wip) (PR #68052)

2023-10-02 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 824b1677a44e25b7c9808c774ba2d894ff14df2b 3ef039a731e09ec3767e71714fc273084c5773a8 --

[Lldb-commits] [lldb] Implement data formatters for LibStdC++ std::variant (PR #68012)

2023-10-02 Thread via lldb-commits
@@ -0,0 +1,72 @@ +""" +Test lldb data formatter for LibStdC++ std::variant. +""" + + +import lldb +from lldbsuite.test.decorators import * +from lldbsuite.test.lldbtest import * +from lldbsuite.test import lldbutil + +USE_LIBSTDCPP = "USE_LIBSTDCPP" + + +class LibStdcxxVariantData

[Lldb-commits] [lldb] Implement data formatters for LibStdC++ std::variant (PR #68012)

2023-10-02 Thread via lldb-commits
@@ -0,0 +1,72 @@ +""" +Test lldb data formatter for LibStdC++ std::variant. +""" + + +import lldb +from lldbsuite.test.decorators import * +from lldbsuite.test.lldbtest import * +from lldbsuite.test import lldbutil + +USE_LIBSTDCPP = "USE_LIBSTDCPP" + + +class LibStdcxxVariantData

[Lldb-commits] [lldb] Implement data formatters for LibStdC++ std::variant (PR #68012)

2023-10-02 Thread via lldb-commits
https://github.com/jeffreytan81 updated https://github.com/llvm/llvm-project/pull/68012 >From e7e47a211ebaaa0f6380810b6573fadde12ca02d Mon Sep 17 00:00:00 2001 From: jeffreytan81 Date: Mon, 2 Oct 2023 10:53:17 -0700 Subject: [PATCH 1/4] Implement data formatters for LibStdC++ std::variant ---

[Lldb-commits] [lldb] 1ec4330 - Implement data formatters for LibStdC++ std::variant (#68012)

2023-10-02 Thread via lldb-commits
Author: jeffreytan81 Date: 2023-10-02T17:46:41-07:00 New Revision: 1ec4330f7e4d9b1ed1880c957e9e897f4eaf204f URL: https://github.com/llvm/llvm-project/commit/1ec4330f7e4d9b1ed1880c957e9e897f4eaf204f DIFF: https://github.com/llvm/llvm-project/commit/1ec4330f7e4d9b1ed1880c957e9e897f4eaf204f.diff

[Lldb-commits] [lldb] Implement data formatters for LibStdC++ std::variant (PR #68012)

2023-10-02 Thread via lldb-commits
https://github.com/jeffreytan81 closed https://github.com/llvm/llvm-project/pull/68012 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/test] Update TestProgressReporting.py (NFC) (PR #68053)

2023-10-02 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben closed https://github.com/llvm/llvm-project/pull/68053 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Implement data formatters for LibStdC++ std::variant (PR #68012)

2023-10-02 Thread antoine moynault via lldb-commits
antmox wrote: Hello, It looks like this broke 2 bots: lldb-aarch64-ubuntu : https://lab.llvm.org/buildbot/#/builders/96/builds/46436 lldb-arm-ubuntu : https://lab.llvm.org/buildbot/#/builders/17/builds/44011 Could you please take a look ? https://github.com/llvm/llvm-project/pull/68012 _