[Lldb-commits] [PATCH] D156774: [lldb][DWARFASTParserClang] Resolve nested types when parsing structures

2023-08-20 Thread Vlad Serebrennikov via Phabricator via lldb-commits
Endill added a comment. I tested this patch together with the following new code: uint32_t TypeSystemClang::GetNumMemberEnums(lldb::opaque_compiler_type_t type) { using EnumIt = clang::DeclContext::specific_decl_iterator; if (!type) return 0; clang::QualType qual_type = Remov

[Lldb-commits] [PATCH] D156774: [lldb][DWARFASTParserClang] Resolve nested types when parsing structures

2023-08-20 Thread Michael Buch via Phabricator via lldb-commits
Michael137 added a comment. In D156774#4601705 , @Endill wrote: > I tested this patch together with the following new code: > > uint32_t TypeSystemClang::GetNumMemberEnums(lldb::opaque_compiler_type_t > type) { > using EnumIt = > clang::DeclContex

[Lldb-commits] [PATCH] D156774: [lldb][DWARFASTParserClang] Resolve nested types when parsing structures

2023-08-20 Thread Vlad Serebrennikov via Phabricator via lldb-commits
Endill updated this revision to Diff 551811. Endill added a comment. Follow the `DW_TAG_subprogram` approach for `DW_TAG_enum_type`, `DW_TAG_structure_type`, and `DW_TAG_union_type`: rely on `ParseType()` called afterwards instead of eagerly parsing them. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D156774: [lldb][DWARFASTParserClang] Resolve nested types when parsing structures

2023-08-20 Thread Vlad Serebrennikov via Phabricator via lldb-commits
Endill added a comment. In D156774#4601736 , @Michael137 wrote: > What were your lldb commands when you tested this? `script import lldb; frame = lldb.thread.GetFrameAtIndex(0); print(frame.variables[0].type.GetNumberOfMemberEnums())` > LLDB currently

[Lldb-commits] [PATCH] D156774: [lldb][DWARFASTParserClang] Resolve nested types when parsing structures

2023-08-20 Thread Michael Buch via Phabricator via lldb-commits
Michael137 added a comment. In D156774#4601767 , @Endill wrote: > In D156774#4601736 , @Michael137 > wrote: > >> What were your lldb commands when you tested this? > > `script import lldb; frame = lldb.thread.Get

[Lldb-commits] [PATCH] D156774: [lldb][DWARFASTParserClang] Resolve nested types when parsing structures

2023-08-20 Thread Vlad Serebrennikov via Phabricator via lldb-commits
Endill added a comment. In D156774#4601830 , @Michael137 wrote: > I think you may want to use `GetCompleteQualType` before iterating the > DeclContext; that's how some of the other TypeSystemClang APIs do it. That > will make sure we complete the type