[Lldb-commits] [PATCH] D156606: [lldb] Improve memory usage by freeing CTF types (NFC)

Michael137 accepted this revision. Michael137 added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156606/new/ https://reviews.llvm.org/D156606 ___ lldb-commits mailing list lldb

[Lldb-commits] [PATCH] D156687: [LLDB][AArch64] Add kind marker to ReadAll/WriteALLRegisterValues data

DavidSpickett created this revision. Herald added subscribers: ctetreau, kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. While working in support for SME's ZA register, I found a cir

[Lldb-commits] [PATCH] D156687: [LLDB][AArch64] Add kind marker to ReadAll/WriteALLRegisterValues data

DavidSpickett added a reviewer: omjavaid. DavidSpickett added a comment. Herald added a subscriber: JDevlieghere. Even if this turns out not to be needed for Za handling, I think `WriteAllRegisterValues` not having to care about the layout is an improvement in itself. Plus, this will give us a

[Lldb-commits] [PATCH] D156687: [LLDB][AArch64] Add kind marker to ReadAll/WriteALLRegisterValues data

DavidSpickett added a comment. And an important note, you don't need the size for each block because the scalable blocks have headers from ptrace embedded in them anyway (SVE/SSVE/ZA). I did remove some checks that seemed redundant because all data read by WriteAll is going to have been written

[Lldb-commits] [PATCH] D156687: [LLDB][AArch64] Add kind marker to ReadAll/WriteALLRegisterValues data

DavidSpickett added a comment. I have some failing tests on Graviton to debug: Failed Tests (2): lldb-api :: commands/register/register/aarch64_sve_registers/rw_access_static_config/TestSVERegisters.py lldb-api :: tools/lldb-server/TestGdbRemoteRegisterState.py But the idea still stan

[Lldb-commits] [PATCH] D156687: [LLDB][AArch64] Add kind marker to ReadAll/WriteALLRegisterValues data

DavidSpickett updated this revision to Diff 545652. DavidSpickett added a comment. Correct m_sve_state size to fix tests on SVE machines. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156687/new/ https://reviews.llvm.org/D156687 Files: lldb/sour

[Lldb-commits] [PATCH] D156687: [LLDB][AArch64] Add kind marker to ReadAll/WriteALLRegisterValues data

DavidSpickett updated this revision to Diff 545657. DavidSpickett added a comment. Remove misleading comment. We save the whole SVE context, FPSIMD or not. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156687/new/ https://reviews.llvm.org/D156687

[Lldb-commits] [lldb] ca71dc1 - [lldb-vscode] Adding support for the "disassemble" request.

Author: John Harrison Date: 2023-07-31T12:44:23-04:00 New Revision: ca71dc1b5404ac685c3190c45c342b01e94e4761 URL: https://github.com/llvm/llvm-project/commit/ca71dc1b5404ac685c3190c45c342b01e94e4761 DIFF: https://github.com/llvm/llvm-project/commit/ca71dc1b5404ac685c3190c45c342b01e94e4761.diff

[Lldb-commits] [PATCH] D156493: [lldb-vsocde] Adding support for the "disassemble" request.

This revision was automatically updated to reflect the committed changes. Closed by commit rGca71dc1b5404: [lldb-vscode] Adding support for the "disassemble" request. (authored by ashgti, committed by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[Lldb-commits] [lldb] 6891812 - [lldb] Improve memory usage by freeing CTF types (NFC)

Author: Jonas Devlieghere Date: 2023-07-31T09:47:46-07:00 New Revision: 68918125c11648379b473d8b2d297872cea9f504 URL: https://github.com/llvm/llvm-project/commit/68918125c11648379b473d8b2d297872cea9f504 DIFF: https://github.com/llvm/llvm-project/commit/68918125c11648379b473d8b2d297872cea9f504.d

[Lldb-commits] [PATCH] D156606: [lldb] Improve memory usage by freeing CTF types (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG68918125c116: [lldb] Improve memory usage by freeing CTF types (NFC) (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM

[Lldb-commits] [lldb] db9087a - [lldb] Clean up uses of UuidCompatibility.h

Author: Alex Langford Date: 2023-07-31T10:30:07-07:00 New Revision: db9087a696a65042701049b9028096aeda82aa98 URL: https://github.com/llvm/llvm-project/commit/db9087a696a65042701049b9028096aeda82aa98 DIFF: https://github.com/llvm/llvm-project/commit/db9087a696a65042701049b9028096aeda82aa98.diff

[Lldb-commits] [PATCH] D156562: [lldb] Clean up uses of UuidCompatibility.h

This revision was automatically updated to reflect the committed changes. Closed by commit rGdb9087a696a6: [lldb] Clean up uses of UuidCompatibility.h (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156562/new/ https://reviews

[Lldb-commits] [PATCH] D156086: [lldb][NFC] Use MCInstrAnalysis when available in the disassembler plugin

RamNalamothu updated this revision to Diff 545753. RamNalamothu added a comment. Add lldb test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156086/new/ https://reviews.llvm.org/D156086 Files: lldb/source/Plugins/Disassembler/LLVMC/Disassembler

[Lldb-commits] [lldb] 4e429fd - Few linter fixes

Author: David Blaikie Date: 2023-07-31T18:52:57Z New Revision: 4e429fd2a72511bc3c0a20e1b12f735863e615df URL: https://github.com/llvm/llvm-project/commit/4e429fd2a72511bc3c0a20e1b12f735863e615df DIFF: https://github.com/llvm/llvm-project/commit/4e429fd2a72511bc3c0a20e1b12f735863e615df.diff LOG:

[Lldb-commits] [PATCH] D156732: Display PC instead of for stack trace in vscode

zhyty created this revision. Herald added a project: All. zhyty requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. It isn't useful for users to see "" as a stack trace when lldb fails to symbolicate a stack frame. I've replaced "" with the va

[Lldb-commits] [PATCH] D156270: [lldb][NFCI] Change logic to find clang resource dir in standalone builds

JDevlieghere added a comment. This broke the standalone bot: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake-standalone/ I was able to reproduce the issue locally and reverting this commit fixes the issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[Lldb-commits] [PATCH] D156763: [lldb] Fix building LLDB standlone without framework

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. In a809720102fae8d1b5a7073f99f9dae9395c5f41

[Lldb-commits] [PATCH] D156764: [lldb][NFCI] More forward declarations in SBDefines.h

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham, clayborg. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. I noticed these were missing. Repository: rG LLVM G

[Lldb-commits] [PATCH] D156763: [lldb] Fix building LLDB standlone without framework

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156763/new/ https://reviews.llvm.org/D156763

[Lldb-commits] [PATCH] D156774: [WIP][lldb] Parse enums while parsing a type

Endill created this revision. Endill added a reviewer: JDevlieghere. Endill added a project: LLDB. Herald added a reviewer: shafik. Herald added a project: All. Endill requested review of this revision. Herald added a subscriber: lldb-commits. Fixes #64291

[Lldb-commits] [PATCH] D156774: [WIP][lldb] Parse enums while parsing a type

Endill added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:3043 + SymbolContextScope *scope; + scope = parent_die.GetDWARF()->GetObjectFile()->GetModule().get(); + assert(scope); I've used https://github

[Lldb-commits] [PATCH] D156774: [WIP][lldb] Parse enums while parsing a type

Endill added a comment. This patch is intentionally aimed squarely at enums. But I'd like lldb to address the issue of accessing compile-time constants holistically. Or at least agree on a path forward for that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.