[Lldb-commits] [PATCH] D156020: [lldb][PlatformDarwin] Parse SDK path for module compilation from debug-info

Michael137 updated this revision to Diff 543870. Michael137 added a comment. - Move into `PlatformDarwin` - Return `XcodeSDK` from `GetSDKPathFromDebugInfo` so it's easier to re-use from Swift plugin - Introduce `ResolveSDKPathFromDebugInfo` to be used from `PlatformDarwin` - Adjust tests Repos

[Lldb-commits] [PATCH] D156020: [lldb][PlatformDarwin] Parse SDK path for module compilation from debug-info

Michael137 updated this revision to Diff 543874. Michael137 added a comment. - Remove redundant header Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156020/new/ https://reviews.llvm.org/D156020 Files: lldb/source/Plugins/Platform/MacOSX/Platform

[Lldb-commits] [PATCH] D156020: [lldb][PlatformDarwin] Parse SDK path for module compilation from debug-info

Michael137 updated this revision to Diff 543875. Michael137 added a comment. - Remove more headers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156020/new/ https://reviews.llvm.org/D156020 Files: lldb/source/Plugins/Platform/MacOSX/PlatformDarw

[Lldb-commits] [PATCH] D156020: [lldb][PlatformDarwin] Parse SDK path for module compilation from debug-info

Michael137 added inline comments. Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp:1363 + XcodeSDK sdk; + for (unsigned i = 0; i < sym_file->GetNumCompileUnits(); ++i) +if (auto cu_sp = sym_file->GetCompileUnitAtIndex(i)) Only remaining qu

[Lldb-commits] [PATCH] D156020: [lldb][PlatformDarwin] Parse SDK path for module compilation from debug-info

Michael137 marked 2 inline comments as not done. Michael137 added inline comments. Comment at: lldb/include/lldb/Target/Platform.h:479 +/// to an internal SDK +bool found_internal_sdk = false; + Michael137 wrote: > aprantl wrote: > > These flags really on

[Lldb-commits] [PATCH] D156020: [lldb][PlatformDarwin] Parse SDK path for module compilation from debug-info

Michael137 updated this revision to Diff 543967. Michael137 marked an inline comment as not done. Michael137 added a comment. - Update unit-tests - Expand function docs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156020/new/ https://reviews.llvm.

[Lldb-commits] [PATCH] D156118: [lldb][AArch64] Add reading of TLS tpidr register from core files

DavidSpickett updated this revision to Diff 543999. DavidSpickett added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Rebase, add release note before I forget. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156118/

[Lldb-commits] [PATCH] D154989: [lldb-vsocde] Add a 'continued' event for programmatic continue events.

ashgti updated this revision to Diff 544017. ashgti added a comment. Adding back the 'threadCausedFocus' field, that is used in tests to verify behavior. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154989/new/ https://reviews.llvm.org/D154989 F

[Lldb-commits] [PATCH] D156066: [lldb][LocateModuleCallback] Call locate module callback in Platform too

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. lgtm! I like this being in platform better Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156066/new/ https://reviews.llvm.org/D156066 _

[Lldb-commits] [lldb] 8c61c9b - [lldb][LocateModuleCallback] Call locate module callback in Platform too

Author: Kazuki Sakamoto Date: 2023-07-25T10:57:50-07:00 New Revision: 8c61c9b02b492b00179e6e2cd95d2c54dac69a0e URL: https://github.com/llvm/llvm-project/commit/8c61c9b02b492b00179e6e2cd95d2c54dac69a0e DIFF: https://github.com/llvm/llvm-project/commit/8c61c9b02b492b00179e6e2cd95d2c54dac69a0e.dif

[Lldb-commits] [PATCH] D156066: [lldb][LocateModuleCallback] Call locate module callback in Platform too

This revision was automatically updated to reflect the committed changes. Closed by commit rG8c61c9b02b49: [lldb][LocateModuleCallback] Call locate module callback in Platform too (authored by splhack). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[Lldb-commits] [PATCH] D154989: [lldb-vsocde] Add a 'continued' event for programmatic continue events.

wallace added a comment. +1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154989/new/ https://reviews.llvm.org/D154989 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi

[Lldb-commits] [lldb] 3ab73a3 - [lldb-vsocde] Add a 'continued' event for programmatic continue events.

Author: John Harrison Date: 2023-07-25T14:46:17-04:00 New Revision: 3ab73a398422298fb5435ced0f7838074efa12e0 URL: https://github.com/llvm/llvm-project/commit/3ab73a398422298fb5435ced0f7838074efa12e0 DIFF: https://github.com/llvm/llvm-project/commit/3ab73a398422298fb5435ced0f7838074efa12e0.diff

[Lldb-commits] [PATCH] D154989: [lldb-vsocde] Add a 'continued' event for programmatic continue events.

This revision was automatically updated to reflect the committed changes. Closed by commit rG3ab73a398422: [lldb-vsocde] Add a 'continued' event for programmatic continue events. (authored by ashgti, committed by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[Lldb-commits] [PATCH] D156270: [lldb][NFCI] Change logic to find clang resource dir in standalone builds

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. As of 0beffb854209a41f31beb18f9631258349a99299

[Lldb-commits] [PATCH] D156270: [lldb][NFCI] Change logic to find clang resource dir in standalone builds

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156270/new/ https://reviews.llvm.org/D156270 ___

[Lldb-commits] [lldb] a809720 - [lldb][NFCI] Change logic to find clang resource dir in standalone builds

Author: Alex Langford Date: 2023-07-25T15:52:33-07:00 New Revision: a809720102fae8d1b5a7073f99f9dae9395c5f41 URL: https://github.com/llvm/llvm-project/commit/a809720102fae8d1b5a7073f99f9dae9395c5f41 DIFF: https://github.com/llvm/llvm-project/commit/a809720102fae8d1b5a7073f99f9dae9395c5f41.diff

[Lldb-commits] [PATCH] D156270: [lldb][NFCI] Change logic to find clang resource dir in standalone builds

This revision was automatically updated to reflect the committed changes. Closed by commit rGa809720102fa: [lldb][NFCI] Change logic to find clang resource dir in standalone builds (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[Lldb-commits] [PATCH] D156270: [lldb][NFCI] Change logic to find clang resource dir in standalone builds

mib added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156270/new/ https://reviews.llvm.org/D156270 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-

[Lldb-commits] [PATCH] D156279: [lldb] Increase the default timeouts when running under ASan

JDevlieghere created this revision. JDevlieghere added reviewers: aprantl, bulbazord, rupprecht. Herald added a project: All. JDevlieghere requested review of this revision. Increase the default timeouts when running under ASan. We had something similar before we adopted tablegen, but the larger

[Lldb-commits] [PATCH] D156279: [lldb] Increase the default timeouts when running under ASan

aprantl added a comment. This LGTM, but I'm surprized you didn't have to delete any older code that tried to do the same thing. Did the thing I remember not survive the transition to tablegen or is this orthogonal? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156279/new/ https://revi

[Lldb-commits] [PATCH] D156279: [lldb] Increase the default timeouts when running under ASan

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Nevermind, you answered my question in the description already! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156279/new/ https://reviews.llvm.org/D156279 _

[Lldb-commits] [lldb] 94e8fef - [lldb] Increase the default timeouts when running under ASan

Author: Jonas Devlieghere Date: 2023-07-25T17:45:19-07:00 New Revision: 94e8fefe385cd3b6a4656bec244ddf9791056f0c URL: https://github.com/llvm/llvm-project/commit/94e8fefe385cd3b6a4656bec244ddf9791056f0c DIFF: https://github.com/llvm/llvm-project/commit/94e8fefe385cd3b6a4656bec244ddf9791056f0c.d

[Lldb-commits] [PATCH] D156279: [lldb] Increase the default timeouts when running under ASan

This revision was automatically updated to reflect the committed changes. Closed by commit rG94e8fefe385c: [lldb] Increase the default timeouts when running under ASan (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[Lldb-commits] [PATCH] D155198: [lldb] Consider OP_addrx in DWARFExpression::Update_DW_OP_addr

clayborg added a comment. Sorry for the late response, but I had verbally agreed to this approach when Felipe and I spoke about how to fix this. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155198/new/ https://reviews.llvm.org/D155198

[Lldb-commits] [PATCH] D155905: lldb RFC: Exposing set/get address masks, Fix*Address methods in SBProcess

clayborg added inline comments. Comment at: lldb/include/lldb/API/SBProcess.h:415-416 + /// (unsigned long long) 0xfc00 + lldb::addr_t GetCodeAddressMask(); + lldb::addr_t GetDataAddressMask(); + Will there only ever be two variants of this for cod

[Lldb-commits] [PATCH] D155107: Add support for llvm::MCInstPrinter::setPrintBranchImmAsAddress

clayborg added a comment. So Ted, can you verify that nothing is missing in RISCV since this is already the way it works for x86/x86_64 and arm32/arm64? I am thinking like Jason is where I wonder if something isn't just hooked up right for RISCV somehow. Or if you can verify that nothing change