splhack updated this revision to Diff 540648.
splhack added a comment.
Tear down the module cache.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155333/new/
https://reviews.llvm.org/D155333
Files:
lldb/unittests/Target/LocateModuleCallbackTest.c
splhack added a comment.
@jasonmolenda thank you for looking into this!
I was finally able to repro the test failure on arm64 macOS with this diff (the
version with `ASSERT_EQ(a_file_spec.GetPath(), b_file_spec.GetPath()`) and this
CMake config.
cmake \
../llvm \
-G Ninja \
jasonmolenda accepted this revision.
jasonmolenda added a comment.
Great catch, thanks for digging in on this!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155333/new/
https://reviews.llvm.org/D155333
_
wallace accepted this revision.
wallace added a comment.
This revision is now accepted and ready to land.
fingers crossed
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155248/new/
https://reviews.llvm.org/D155248
__
Author: Kazuki Sakamoto
Date: 2023-07-15T11:53:06-07:00
New Revision: 39299f0d367d4ff6b1d1eede80ffb09718614e53
URL:
https://github.com/llvm/llvm-project/commit/39299f0d367d4ff6b1d1eede80ffb09718614e53
DIFF:
https://github.com/llvm/llvm-project/commit/39299f0d367d4ff6b1d1eede80ffb09718614e53.dif
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rG39299f0d367d: [lldb][LocateModuleCallback] Fix
LocateModuleCallbackTest (authored by splhack).
Repository:
rG LLVM Gith
JonChesterfield added a comment.
I think this patch is failing local builds for me
Failed Tests (20):
LLVM :: Transforms/Attributor/ArgumentPromotion/array.ll
LLVM :: Transforms/Attributor/ArgumentPromotion/musttail.ll
LLVM :: Transforms/Attributor/ArgumentPromotion/variadic.ll
