[Lldb-commits] [PATCH] D154705: [lldb][AArch64] Fix flakiness in TestSVEThreadedDynamic

DavidSpickett created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This test runs to a breakpoint on thread 0. Thread 0 then starts threa

[Lldb-commits] [PATCH] D154705: [lldb][AArch64] Fix flakiness in TestSVEThreadedDynamic

DavidSpickett added a comment. My brain says this is not a good way to ensure a state, but I couldn't think of anything that wouldn't have its own race conditions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154705/new/ https://reviews.llvm.org/

[Lldb-commits] [lldb] dc04b18 - [lldb][NFC] Factor out code from SymbolFileDWARF::ParseVariableDIE

Author: Felipe de Azevedo Piovezan Date: 2023-07-07T08:44:59-04:00 New Revision: dc04b18ad7e45c67df4b8b3a756257eb62447970 URL: https://github.com/llvm/llvm-project/commit/dc04b18ad7e45c67df4b8b3a756257eb62447970 DIFF: https://github.com/llvm/llvm-project/commit/dc04b18ad7e45c67df4b8b3a756257eb6

[Lldb-commits] [PATCH] D154513: [lldb][NFC] Factor out code from SymbolFileDWARF::ParseVariableDIE

This revision was automatically updated to reflect the committed changes. Closed by commit rGdc04b18ad7e4: [lldb][NFC] Factor out code from SymbolFileDWARF::ParseVariableDIE (authored by fdeazeve). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154513

[Lldb-commits] [PATCH] D154513: [lldb][NFC] Factor out code from SymbolFileDWARF::ParseVariableDIE

fdeazeve added a comment. > There are some potential improvements we could make to this code Yup, there's a lot I want to change here, but I am taking it slowly in the interest of making each change easier to verify Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[Lldb-commits] [lldb] 564ff8f - [lldb][NFCI] Remove use of Stream * from TypeSystem

Author: Alex Langford Date: 2023-07-07T10:09:43-07:00 New Revision: 564ff8ffe75d9353ac02be5a4d3aa424cb79429c URL: https://github.com/llvm/llvm-project/commit/564ff8ffe75d9353ac02be5a4d3aa424cb79429c DIFF: https://github.com/llvm/llvm-project/commit/564ff8ffe75d9353ac02be5a4d3aa424cb79429c.diff

[Lldb-commits] [PATCH] D154549: [lldb][NFCI] Remove use of Stream * from TypeSystem

This revision was automatically updated to reflect the committed changes. Closed by commit rG564ff8ffe75d: [lldb][NFCI] Remove use of Stream * from TypeSystem (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154549/new/ https:/

[Lldb-commits] [PATCH] D154730: [lldb] Consider TAG_imported_declaration in DebugNamesIndex

fdeazeve created this revision. Herald added a subscriber: arphaman. Herald added a project: All. fdeazeve requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. In order to recognize namespace aliases as a namespace, the DW_TAG_imported_declarati

[Lldb-commits] [PATCH] D153489: [lldb] Print hint if object description is requested but not implemented

kastiglione added inline comments. Comment at: lldb/source/Commands/CommandObjectDWIMPrint.cpp:133-135 + << "note: object description requested, but type doesn't implement " + "a custom object description. Consider using \"p\" instead of " + "\"po

[Lldb-commits] [PATCH] D154730: [lldb] Consider TAG_imported_declaration in DebugNamesIndex

Michael137 accepted this revision. Michael137 added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154730/new/ https://reviews.llvm.org/D154730 __

[Lldb-commits] [PATCH] D139453: Switch to a different library-loaded notification function breakpoint in Darwin dyld

jasonmolenda updated this revision to Diff 538253. jasonmolenda added a comment. Update the patch to address the failures we were hitting on the Intel macOS 10.15 CI bot. In addition to lldb_notifier_function, look for "gdb_notifier_function" which is what it was called back in macOS 10.15. Re

[Lldb-commits] [lldb] ec360fa - Change the dyld notification function that lldb puts a breakpoint in

Author: Jason Molenda Date: 2023-07-07T14:48:32-07:00 New Revision: ec360faeb30408255ebece11f36a2ad42ddc6294 URL: https://github.com/llvm/llvm-project/commit/ec360faeb30408255ebece11f36a2ad42ddc6294 DIFF: https://github.com/llvm/llvm-project/commit/ec360faeb30408255ebece11f36a2ad42ddc6294.diff

[Lldb-commits] [PATCH] D154752: runCmd should print the command before running it in case of crashes

jingham created this revision. jingham added reviewers: JDevlieghere, mib, bulbazord. Herald added a project: All. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. runCmd (and expect which uses runCmd) run the command, and when that

[Lldb-commits] [PATCH] D154752: runCmd should print the command before running it in case of crashes

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Makes sense. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154752/new/ https://reviews.llvm.org/D154752 _

[Lldb-commits] [PATCH] D154752: runCmd should print the command before running it in case of crashes

mib accepted this revision. mib added a comment. Yep, LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154752/new/ https://reviews.llvm.org/D154752 ___ lldb-commits mailing list lldb-commits@lists.llv

[Lldb-commits] [PATCH] D154752: runCmd should print the command before running it in case of crashes

bulbazord accepted this revision. bulbazord added a comment. Oh I really like this. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154752/new/ https://reviews.llvm.org/D154752 ___ lldb-commits mai

[Lldb-commits] [lldb] 01e3393 - Split up the runCmd trace printing to print the command before running.

Author: Jim Ingham Date: 2023-07-07T19:09:18-07:00 New Revision: 01e3393b94d194ee99e57f23f9c08160cef94753 URL: https://github.com/llvm/llvm-project/commit/01e3393b94d194ee99e57f23f9c08160cef94753 DIFF: https://github.com/llvm/llvm-project/commit/01e3393b94d194ee99e57f23f9c08160cef94753.diff LO

[Lldb-commits] [PATCH] D154752: runCmd should print the command before running it in case of crashes

This revision was automatically updated to reflect the committed changes. Closed by commit rG01e3393b94d1: Split up the runCmd trace printing to print the command before running. (authored by jingham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15

[Lldb-commits] [PATCH] D154757: [lldb][NFCI] TestEmulation should take a Stream ref

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, fdeazeve. Herald added subscribers: luke, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, atanasyan, edward-jones, zzheng, jrtc27, niosHD, s

[Lldb-commits] [PATCH] D154759: [lldb][NFCI] Change type of UnwindPlan::m_source_name

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jasonmolenda, jingham. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. m_source_name is currently a ConstString. Comparing